Re: [PATCH 2/2] gpio/omap: add *remove* callback in platform_driver

2012-07-17 Thread Shilimkar, Santosh
On Mon, Jul 16, 2012 at 10:40 PM, Kevin Hilman khil...@ti.com wrote: Linus Walleij linus.wall...@linaro.org writes: On Thu, Jul 12, 2012 at 7:48 PM, Kevin Hilman khil...@ti.com wrote: In the case of OMAP GPIO, unless it's an obvious fix, I would recommend you wait at least until you see

Re: [PATCH 2/2] gpio/omap: add *remove* callback in platform_driver

2012-07-16 Thread Kevin Hilman
Linus Walleij linus.wall...@linaro.org writes: On Thu, Jul 12, 2012 at 7:48 PM, Kevin Hilman khil...@ti.com wrote: In the case of OMAP GPIO, unless it's an obvious fix, I would recommend you wait at least until you see some acks/tested tags from any of - Santosh Shilimkar

Re: [PATCH 2/2] gpio/omap: add *remove* callback in platform_driver

2012-07-16 Thread Linus Walleij
On Mon, Jul 16, 2012 at 7:10 PM, Kevin Hilman khil...@ti.com wrote: Subject: [PATCH] MAINTAINERS: add entry OMAP GPIO driver Since I've been maintaining this, making it official at the request of the GPIO maintainers. Cc: Grant Likely grant.lik...@secretlab.ca Cc: Linus Walleij

Re: [PATCH 2/2] gpio/omap: add *remove* callback in platform_driver

2012-07-16 Thread Kevin Hilman
Linus Walleij linus.wall...@linaro.org writes: On Mon, Jul 16, 2012 at 7:10 PM, Kevin Hilman khil...@ti.com wrote: Subject: [PATCH] MAINTAINERS: add entry OMAP GPIO driver Since I've been maintaining this, making it official at the request of the GPIO maintainers. Cc: Grant Likely

Re: [PATCH 2/2] gpio/omap: add *remove* callback in platform_driver

2012-07-14 Thread Linus Walleij
On Thu, Jul 12, 2012 at 7:48 PM, Kevin Hilman khil...@ti.com wrote: In the case of OMAP GPIO, unless it's an obvious fix, I would recommend you wait at least until you see some acks/tested tags from any of - Santosh Shilimkar santosh.shilim...@ti.com - Rajendra Nayak rna...@ti.com - Benoit

Re: [PATCH 2/2] gpio/omap: add *remove* callback in platform_driver

2012-07-12 Thread Linus Walleij
On Thu, Jul 12, 2012 at 1:25 AM, Kevin Hilman khil...@ti.com wrote: There is quite a bit of other things to do in remove to properly cleanup what is done in probe. OK I'm dropping this patch for now... Yours, Linus Walleij -- To unsubscribe from this list: send the line unsubscribe linux-omap

Re: [PATCH 2/2] gpio/omap: add *remove* callback in platform_driver

2012-07-12 Thread Kevin Hilman
Hi Linus, Linus Walleij linus.wall...@linaro.org writes: On Thu, Jul 12, 2012 at 1:25 AM, Kevin Hilman khil...@ti.com wrote: There is quite a bit of other things to do in remove to properly cleanup what is done in probe. OK I'm dropping this patch for now... Thanks. For future

Re: [PATCH 2/2] gpio/omap: add *remove* callback in platform_driver

2012-07-11 Thread Linus Walleij
On Wed, Jul 11, 2012 at 11:13 AM, Tarun Kanti DebBarma tarun.ka...@ti.com wrote: Add *remove* callback so that necessary cleanup operations are performed when device is unregistered. The device is deleted from the list and associated clock handle is released by calling clk_put() and irq

Re: [PATCH 2/2] gpio/omap: add *remove* callback in platform_driver

2012-07-11 Thread Kevin Hilman
Tarun Kanti DebBarma tarun.ka...@ti.com writes: Add *remove* callback so that necessary cleanup operations are performed when device is unregistered. How was this tested? on what platforms? The device is deleted from the list and associated clock handle is released by calling clk_put()