Re: [PATCH 2/3] N810: Don't export camera orientation

2008-05-15 Thread andrzej zaborowski
On 15/05/2008, Felipe Balbi [EMAIL PROTECTED] wrote: On Wed, May 14, 2008 at 03:04:37PM +0300, Sakari Ailus wrote: ext Felipe Balbi wrote: Hello Felipe, and thanks for reviewing the patch! :) On Tue, 13 May 2008 19:04:22 +0300, Sakari Ailus [EMAIL PROTECTED] wrote: @@ -298,12

Re: [PATCH 2/3] N810: Don't export camera orientation

2008-05-15 Thread andrzej zaborowski
On 15/05/2008, Felipe Balbi [EMAIL PROTECTED] wrote: On Thu, May 15, 2008 at 08:54:34AM +0200, andrzej zaborowski wrote: On 15/05/2008, Felipe Balbi [EMAIL PROTECTED] wrote: On Wed, May 14, 2008 at 03:04:37PM +0300, Sakari Ailus wrote: ext Felipe Balbi wrote: Hello

Re: [PATCH 2/3] N810: Don't export camera orientation

2008-05-15 Thread Felipe Balbi
On Thu, May 15, 2008 at 10:11:59AM +0200, andrzej zaborowski wrote: This doesn't change anything - since machine_is_... is not constant, the whole expression is not constant and is a syntax error. The compiler needs to know at compile time whether to store a 0 or a 1 in the initialiser. ugh,

Re: [PATCH 2/3] N810: Don't export camera orientation

2008-05-13 Thread Felipe Balbi
On Tue, 13 May 2008 19:04:22 +0300, Sakari Ailus [EMAIL PROTECTED] wrote: On Nokia N810 the camera module is mounted upside down. This affects the mirroring controls. This patch inverts the controls for N810. Signed-off-by: Sakari Ailus [EMAIL PROTECTED] ---