Re: [PATCH 3/5] staging: tidspbridge: Lindent to drv_interface.c

2012-01-30 Thread Ramirez Luna, Omar
2012/1/23 Víctor Manuel Jáquez Leal vjaq...@igalia.com: No functional changes. According to Lindent, the file drv_internface.c had some lines with bad indentation. This commit is the output of Lindent. Usually lindent tends to do whatever it wants, unless carefully configured... ... @@

Re: [PATCH 3/5] staging: tidspbridge: Lindent to drv_interface.c

2012-01-30 Thread Víctor M . Jáquez L .
On Mon, Jan 30, 2012 at 11:25:34AM -0600, Ramirez Luna, Omar wrote: 2012/1/23 Víctor Manuel Jáquez Leal vjaq...@igalia.com: No functional changes. According to Lindent, the file drv_internface.c had some lines with bad indentation. This commit is the output of Lindent. Usually

Re: [PATCH 3/5] staging: tidspbridge: Lindent to drv_interface.c

2012-01-30 Thread Dan Carpenter
On Mon, Jan 30, 2012 at 11:25:34AM -0600, Ramirez Luna, Omar wrote: +                       pr_info(%s:%d handle(s) still opened\n, __func__, +                               atomic_read(bridge_cref)); I remember the rule was to break lines as far to the right as possible, no? Chapter 2

Re: [PATCH 3/5] staging: tidspbridge: Lindent to drv_interface.c

2012-01-30 Thread Joe Perches
On Mon, 2012-01-30 at 22:29 +0300, Dan Carpenter wrote: On Mon, Jan 30, 2012 at 11:25:34AM -0600, Ramirez Luna, Omar wrote: + pr_info(%s:%d handle(s) still opened\n, __func__, + atomic_read(bridge_cref)); I remember the rule was to

Re: [PATCH 3/5] staging: tidspbridge: Lindent to drv_interface.c

2012-01-30 Thread Víctor M . Jáquez L .
On Mon, Jan 30, 2012 at 11:53:00AM -0800, Joe Perches wrote: On Mon, 2012-01-30 at 22:29 +0300, Dan Carpenter wrote: On Mon, Jan 30, 2012 at 11:25:34AM -0600, Ramirez Luna, Omar wrote: + pr_info(%s:%d handle(s) still opened\n, __func__, +

Re: [PATCH 3/5] staging: tidspbridge: Lindent to drv_interface.c

2012-01-30 Thread Joe Perches
On Mon, 2012-01-30 at 21:33 +0100, Víctor M. Jáquez L. wrote: On Mon, Jan 30, 2012 at 11:53:00AM -0800, Joe Perches wrote: I've done a patch here to tidspbridge that standardizes printk output. Basically, the patch adds #define pr_fmt(fmt) KBUILD_MODNAME %s: , __func__ to prefix