Re: [linux-pm] [PATCH] opp: introduce library for device-specific OPPs

2010-09-18 Thread Mark Brown
On Fri, Sep 17, 2010 at 05:37:06PM -0700, Kevin Hilman wrote: [trimmed Cc list a bit, as vger bounced my last reply due to header too long] Mark Brown broo...@opensource.wolfsonmicro.com writes: The enable/disable thing wasn't so noticable in the API itself, it was in the data structures

Re: [linux-pm] [PATCH] opp: introduce library for device-specific OPPs

2010-09-18 Thread Mark Brown
On Fri, Sep 17, 2010 at 07:45:43PM +0300, Phil Carmody wrote: On 17/09/10 17:36 +0200, ext Mark Brown wrote: It might be clearer to use some term other than enabled in the code - when reading I wasn't immediately sure if enabled meant that it was available to be selected or if it was the

Re: [linux-pm] [PATCH] opp: introduce library for device-specific OPPs

2010-09-17 Thread Mark Brown
On Thu, Sep 16, 2010 at 08:29:33PM -0500, Nishanth Menon wrote: +struct opp_def { + unsigned long freq; + unsigned long u_volt; + + bool enabled; +}; It might be clearer to use some term other than enabled in the code - when reading I wasn't immediately sure if enabled meant

Re: [linux-pm] [PATCH] opp: introduce library for device-specific OPPs

2010-09-17 Thread Nishanth Menon
Mark Brown had written, on 09/17/2010 10:36 AM, the following: On Thu, Sep 16, 2010 at 08:29:33PM -0500, Nishanth Menon wrote: +struct opp_def { + unsigned long freq; + unsigned long u_volt; + + bool enabled; +}; It might be clearer to use some term other than enabled in

Re: [linux-pm] [PATCH] opp: introduce library for device-specific OPPs

2010-09-17 Thread Mark Brown
On Fri, Sep 17, 2010 at 10:53:06AM -0500, Nishanth Menon wrote: Mark Brown had written, on 09/17/2010 10:36 AM, the following: It might be clearer to use some term other than enabled in the code - when reading I wasn't immediately sure if enabled meant that it was available to be selected or

Re: [linux-pm] [PATCH] opp: introduce library for device-specific OPPs

2010-09-17 Thread Rafael J. Wysocki
On Friday, September 17, 2010, Nishanth Menon wrote: Mark Brown had written, on 09/17/2010 10:36 AM, the following: On Thu, Sep 16, 2010 at 08:29:33PM -0500, Nishanth Menon wrote: +struct opp_def { + unsigned long freq; + unsigned long u_volt; + + bool enabled; +}; It

Re: [linux-pm] [PATCH] opp: introduce library for device-specific OPPs

2010-09-17 Thread Nishanth Menon
Rafael J. Wysocki had written, on 09/17/2010 05:22 PM, the following: On Friday, September 17, 2010, Nishanth Menon wrote: Mark Brown had written, on 09/17/2010 10:36 AM, the following: On Thu, Sep 16, 2010 at 08:29:33PM -0500, Nishanth Menon wrote: +struct opp_def { + unsigned long

Re: [linux-pm] [PATCH] opp: introduce library for device-specific OPPs

2010-09-17 Thread Rafael J. Wysocki
On Saturday, September 18, 2010, Nishanth Menon wrote: Rafael J. Wysocki had written, on 09/17/2010 05:22 PM, the following: On Friday, September 17, 2010, Nishanth Menon wrote: Mark Brown had written, on 09/17/2010 10:36 AM, the following: On Thu, Sep 16, 2010 at 08:29:33PM -0500, Nishanth

Re: [linux-pm] [PATCH] opp: introduce library for device-specific OPPs

2010-09-17 Thread Kevin Hilman
[trimmed Cc list a bit, as vger bounced my last reply due to header too long] Mark Brown broo...@opensource.wolfsonmicro.com writes: On Fri, Sep 17, 2010 at 10:53:06AM -0500, Nishanth Menon wrote: Mark Brown had written, on 09/17/2010 10:36 AM, the following: It might be clearer to use some