[PATCH] OMAP2/3 clock: convert mask_to_shift() to __ffs()

2008-03-28 Thread Paul Walmsley
In OMAP2/3 clock code, we've used mask_to_shift() to convert bitmasks into shift values, via ffs(mask) - 1. It turns out that there is already a Linux idiom for this in asm/bitops.h: __ffs(). (Not to be confused with ffs(), of course. You wouldn't do that, would you?) When in Rome, do as the

Re: [PATCH 0/7] twl4030 changes

2008-03-28 Thread Tony Lindgren
* Felipe Balbi [EMAIL PROTECTED] [080327 19:20]: Hi Tony, I'm resending this series cuz I changed a bit patch #5 to set session bit on musb_platform_set_mode so musb core will really go to a_host mode when we echo sysfs. Without this small change the sysfs interface will work only with a

Re: RFC: moving twl4030-gpio.c to gpiolib

2008-03-28 Thread Tony Lindgren
* Felipe Balbi [EMAIL PROTECTED] [080320 15:48]: After the patch from Kevin Hilman, I had to rebase my gpiolib patch Here an updated version of it. Can you repost with Signed-off-by? Tony == CUT HERE == diff --git a/arch/arm/mach-omap2/board-sdp-hsmmc.c

[PATCH] I2C: Fix twl4030 timeouts on omap3430

2008-03-28 Thread Tony Lindgren
Hi all, This helps with the annoying I2C timeouts. Does anybody have an idea why the twl4030 chip does not like doing multiple transfers in a row? To me the only difference seems to be that clocks are idled between writing the twl4030 register and reading the register value. Regards, Tony From

Re: [PATCH 0/7] twl4030 changes

2008-03-28 Thread Felipe Balbi
On Fri, 28 Mar 2008 09:49:00 +0200, Tony Lindgren [EMAIL PROTECTED] wrote: * Felipe Balbi [EMAIL PROTECTED] [080327 19:20]: Hi Tony, I'm resending this series cuz I changed a bit patch #5 to set session bit on musb_platform_set_mode so musb core will really go to a_host mode when we echo

Re: RFC: moving twl4030-gpio.c to gpiolib

2008-03-28 Thread Tony Lindgren
* Felipe Balbi [EMAIL PROTECTED] [080328 12:13]: On Fri, 28 Mar 2008 10:06:16 +0200, Tony Lindgren [EMAIL PROTECTED] wrote: * Felipe Balbi [EMAIL PROTECTED] [080320 15:48]: After the patch from Kevin Hilman, I had to rebase my gpiolib patch Here an updated version of it. Can

Re: [PATCH 0/7] twl4030 changes

2008-03-28 Thread Tony Lindgren
* Felipe Balbi [EMAIL PROTECTED] [080328 12:16]: On Fri, 28 Mar 2008 09:49:00 +0200, Tony Lindgren [EMAIL PROTECTED] wrote: * Felipe Balbi [EMAIL PROTECTED] [080327 19:20]: Hi Tony, I'm resending this series cuz I changed a bit patch #5 to set session bit on musb_platform_set_mode

Re: [PATCH] i2c: tea5761: New-style i2c driver

2008-03-28 Thread Tony Lindgren
* Eduardo Valentin [EMAIL PROTECTED] [080327 17:32]: From: Eduardo Valentin [EMAIL PROTECTED] This patch updates the fm radio driver for tea5761 chip. It also moves board dependent code to its correct board file place. Pushing today. You might want to start discussing this driver on V4L

Re: [PATCH] OMAPFB: Check in suspend/resume if framebuffer device is initialized.

2008-03-28 Thread Tony Lindgren
* Jouni Högander [EMAIL PROTECTED] [080326 13:59]: Check wether fbdev is NULL in suspend / resume functions. Fbdev is NULL, if there is no lcd or it is not enabled in configuration. This one is missing Signed-off-by also. Tony --- drivers/video/omap/omapfb_main.c |7 --- 1 files

Re: [PATCH] OMAP: MMU_FWK: Changed Kconfig entry from tristate to bool.

2008-03-28 Thread Tony Lindgren
* Eduardo Valentin [EMAIL PROTECTED] [080326 16:49]: From: Eduardo Valentin [EMAIL PROTECTED] As this code uses unexported symbols, it must be always built-in. For this reason, a better type of its Kconfig entry is bool. Fixed also defconfig which sets this entry as module. Compile

Re: [PATCH] Keymap fix for palmte and palmz71.

2008-03-28 Thread Tony Lindgren
* Eduardo Valentin [EMAIL PROTECTED] [080327 21:16]: Hi andrzej, It may disappeared in a merge. However, this patch was based on: http://linux.omap.com/pipermail/linux-omap-open-source/2007-August/011225.html That's why I thought the remotion was intended. Andrzej, can you please check

Re: [PATCH] Keymap fix for palmte and palmz71.

2008-03-28 Thread Tony Lindgren
* andrzej zaborowski [EMAIL PROTECTED] [080328 13:40]: On 28/03/2008, Tony Lindgren [EMAIL PROTECTED] wrote: * Eduardo Valentin [EMAIL PROTECTED] [080327 21:16]: It may disappeared in a merge. However, this patch was based on:

[PATCH 1/2] ARM: OMAP3: Add 34xx SRAM functions

2008-03-28 Thread Tony Lindgren
This adds sram34xx.S From TI CDP. NOTE: This patch breaks compile for 34xx, the compile will be fixed in the next patch. This and next patch will eventually get merged into a single patch for linux-omap to keep git-bisect working. --- arch/arm/mach-omap2/Makefile |1 +

[PATCH 2/2] ARCH: OMAP3: Make SRAM code from TI CDP compile and work

2008-03-28 Thread Tony Lindgren
Make SRAM code from TI CDP compile and work. Signed-off-by: Tony Lindgren [EMAIL PROTECTED] --- arch/arm/mach-omap2/sram34xx.S | 112 ++ arch/arm/plat-omap/sram.c| 63 + include/asm-arm/arch-omap/sdrc.h |2 +

[PATCH] I2C: Fix twl4030 timeouts on omap3430

2008-03-28 Thread Tony Lindgren
For some reason doing a twl4030 write-read cycle can hang the I2C bus on omap3430. And doing the write and read separately in twl4030_i2c_read() seems to fix the problem... Not intended for applying, just a temporary workaround. diff --git a/drivers/i2c/chips/twl4030-core.c

[PATCH] I2C: Fix twl4030 timeouts on omap3430

2008-03-28 Thread Tony Lindgren
ARM: OMAP: Use posted mode for dmtimer This patch adds the use of write posting for the timer. Previously, every write could lock the requestor for almost 3x32KHz cycles. This patch only synchronizes before writes and reads instead of after them and it does it on per register basis. Doing it

Re: [PATCH] I2C: Fix twl4030 timeouts on omap3430

2008-03-28 Thread Tony Lindgren
* Tony Lindgren [EMAIL PROTECTED] [080328 13:47]: For some reason doing a twl4030 write-read cycle can hang the I2C bus on omap3430. And doing the write and read separately in twl4030_i2c_read() seems to fix the problem... Not intended for applying, just a temporary workaround. Uh, please

Re: [PATCH] I2C: Fix twl4030 timeouts on omap3430

2008-03-28 Thread Tony Lindgren
* Tony Lindgren [EMAIL PROTECTED] [080328 13:47]: ARM: OMAP: Use posted mode for dmtimer This patch adds the use of write posting for the timer. Previously, every write could lock the requestor for almost 3x32KHz cycles. This patch only synchronizes before writes and reads instead of after

Re: [PATCH] i2c: tea5761: New-style i2c driver

2008-03-28 Thread Eduardo Valentin
Hi Jarkko, Thanks for the review. On Thu, 27 Mar 2008 11:31:20 -0400 ext Eduardo Valentin [EMAIL PROTECTED] wrote: From: Eduardo Valentin [EMAIL PROTECTED] This patch updates the fm radio driver for tea5761 chip. It also moves board dependent code to its correct board file place. Good

[PATCH] i2c: tea5761: New-style i2c driver

2008-03-28 Thread Eduardo Valentin
From: Eduardo Valentin [EMAIL PROTECTED] This patch updates the fm radio driver for tea5761 chip. It also moves board dependent code to its correct board file place. Signed-off-by: Eduardo Valentin [EMAIL PROTECTED] --- arch/arm/mach-omap2/board-n800.c| 33

Re: [PATCH 4/17] ARM: OMAP2: Add register access for 34xx

2008-03-28 Thread Tony Lindgren
* Tony Lindgren [EMAIL PROTECTED] [080318 17:03]: This patch adds register access for 34xx power and clock management. Here's an updated version of this patch. I've folded in two more patches from Paul [1][2]. Patches change to use __ffs() instead of mask_to_shift, and clean up clock register

Re: [PATCH 9/17] ARM: OMAP2: Add common clock framework for 24xx and 34xx

2008-03-28 Thread Tony Lindgren
* Tony Lindgren [EMAIL PROTECTED] [080318 17:04]: From: Paul Walmsley [EMAIL PROTECTED] This patch adds a common clock framework for 24xx and 34xx. Note that this patch does not add it to Makefile until in next patch. Some functions are modified from earlier 24xx clock framework code.

Re: [PATCH 16/17] ARM: OMAP2: Add 34xx clock code

2008-03-28 Thread Tony Lindgren
* Tony Lindgren [EMAIL PROTECTED] [080318 17:05]: From: Paul Walmsley [EMAIL PROTECTED] This patch add 34xx clock code. Here's an updated version of this patch. I've folded in two more patches from Paul [1][2]. Patches change to use __ffs() instead of mask_to_shift, and clean up clock

Re: [PATCH] i2c: tea5761: New-style i2c driver

2008-03-28 Thread Tony Lindgren
* Eduardo Valentin [EMAIL PROTECTED] [080328 14:05]: From: Eduardo Valentin [EMAIL PROTECTED] This patch updates the fm radio driver for tea5761 chip. It also moves board dependent code to its correct board file place. Pushed. Tony Signed-off-by: Eduardo Valentin [EMAIL PROTECTED] ---