RE: [PATCH 2/2] USB: Generalize usb initialization for omap hw

2008-04-24 Thread Gadiyar, Anand
-Original Message- From: [EMAIL PROTECTED] [mailto:[EMAIL PROTECTED] On Behalf Of Felipe Balbi Sent: Thursday, April 24, 2008 7:16 PM To: linux-omap@vger.kernel.org; David Brownell Cc: Tony Lindgren; Syed Mohammed, Khasim; Felipe Balbi Subject: [PATCH 2/2] USB: Generalize usb

Re: [PATCH 2/2] USB: Generalize usb initialization for omap hw

2008-04-24 Thread Felipe Balbi
On Thu, Apr 24, 2008 at 07:43:16PM +0530, ext Gadiyar, Anand wrote: -Original Message- From: [EMAIL PROTECTED] [mailto:[EMAIL PROTECTED] On Behalf Of Felipe Balbi Sent: Thursday, April 24, 2008 7:16 PM To: linux-omap@vger.kernel.org; David Brownell Cc: Tony Lindgren; Syed

[RFC/PATCH 1/1] McBSP support for 2430/34XX

2008-04-24 Thread Chandra shekhar
Hi, Here is a patch that adds support for McBSP on 2430/34XX (without disturbing the current mcbsp equilibrium). Omap2420 specific code has been left in mcbsp.c because of difference in register set.( 16 bit registers in 2420) It has been verified in digital loopback mode. ( Compilation tested

[PATCH 3/5] Fix mcbsp clock definition on clock34xx.h

2008-04-24 Thread Eduardo Valentin
From: Eduardo Valentin [EMAIL PROTECTED] This patch fix the clock definition for mcbsps on clock34xx.h. Device identification must be done using .id field, not only name field. Signed-off-by: Eduardo Valentin [EMAIL PROTECTED] --- arch/arm/mach-omap2/clock34xx.h | 30

[PATCH 5/5] MACH-OMAP2: MCBSP: Add support for mcbsp on mach-omap2

2008-04-24 Thread Eduardo Valentin
From: Eduardo Valentin [EMAIL PROTECTED] This patch adds support for mach-omap2 based on current mcbsp platform driver. Signed-off-by: Eduardo Valentin [EMAIL PROTECTED] --- arch/arm/mach-omap2/Makefile |2 + arch/arm/mach-omap2/mcbsp.c | 108 ++ 2

framebuffer on 2430sdp, configuration and bug

2008-04-24 Thread Simon Braunschmidt
Hi all We are running 2.6.24-omap1. We have problems to get the framebuffer driver running on a SDP2430-VG5.0.1 board. At the moment the LCD stays dark, no penguin to be seen, test program not displaying anything, nothing. We tried different configurations already but we are not exactly sure

Re: [PATCH 1/2] OMAP: Introduce cpu_class_is_omap3()

2008-04-24 Thread Tony Lindgren
* Felipe Balbi [EMAIL PROTECTED] [080424 06:47]: Add cpu_class_is_omap3(). Well I thinks cpu_class_is_omap2() currently should cover both 24xx and 34xx. This should be only used to differentiate between mach-omap1 and mach-omap2. Tony Signed-off-by: Felipe Balbi [EMAIL PROTECTED] ---

Re: [PATCH 2/2] USB: Generalize usb initialization for omap hw

2008-04-24 Thread Tony Lindgren
* Felipe Balbi [EMAIL PROTECTED] [080424 06:48]: Create a generic board-file for initializing usb on omap2430 and omap3 boards. Signed-off-by: Felipe Balbi [EMAIL PROTECTED] --- arch/arm/mach-omap2/Makefile |4 +- arch/arm/mach-omap2/board-2430sdp-usb.c

Re: [PATCH 2/2] USB: Generalize usb initialization for omap hw

2008-04-24 Thread Tony Lindgren
* Felipe Balbi [EMAIL PROTECTED] [080424 07:20]: On Thu, Apr 24, 2008 at 07:43:16PM +0530, ext Gadiyar, Anand wrote: -Original Message- From: [EMAIL PROTECTED] [mailto:[EMAIL PROTECTED] On Behalf Of Felipe Balbi Sent: Thursday, April 24, 2008 7:16 PM To:

Re: [PATCH 2/2] USB: Generalize usb initialization for omap hw

2008-04-24 Thread Felipe Balbi
On Thu, Apr 24, 2008 at 10:16:18AM -0700, Tony Lindgren wrote: * Felipe Balbi [EMAIL PROTECTED] [080424 07:20]: On Thu, Apr 24, 2008 at 07:43:16PM +0530, ext Gadiyar, Anand wrote: -Original Message- From: [EMAIL PROTECTED] [mailto:[EMAIL PROTECTED] On Behalf Of Felipe Balbi

Re: [PATCH 2/2] USB: Generalize usb initialization for omap hw

2008-04-24 Thread David Brownell
On Thursday 24 April 2008, Tony Lindgren wrote:  .../mach-omap2/{board-3430sdp-usb.c = usb-musb.c} |   32 --- Good: so some of the inappropriate sdp_*() names will vanish ...  include/asm-arm/arch-omap/usb-musb.h               |   35 +++ usb-musb.{c,h}? EHCI/OHCI has

Re: [PATCH 2/2] USB: Generalize usb initialization for omap hw

2008-04-24 Thread Felipe Balbi
On Thu, Apr 24, 2008 at 11:29:27AM -0700, David Brownell wrote: On Thursday 24 April 2008, Tony Lindgren wrote:  .../mach-omap2/{board-3430sdp-usb.c = usb-musb.c} |   32 --- Good: so some of the inappropriate sdp_*() names will vanish ...  

[PATCH] USB: Generalize usb initialization for omap hw

2008-04-24 Thread Felipe Balbi
Create a generic board-file for initializing usb on omap2430 and omap3 boards. Signed-off-by: Felipe Balbi [EMAIL PROTECTED] --- arch/arm/mach-omap2/Makefile|6 +- arch/arm/mach-omap2/board-2430sdp-usb.c | 96 arch/arm/mach-omap2/board-2430sdp.c |5 +-

usb generalization

2008-04-24 Thread Felipe Balbi
Hi all, Here's an updated version of the usb generalization. Please give it a good review, it might be that I missed something in the middle although it seems to be working nice in my 3430sdp. I need someone to test on 2430sdp and give it an ack as well. Here's some output from minicom:

[PATCH] ARM: OMAP: Fix MMC2 device configuration for OMAP2430

2008-04-24 Thread Seth Forshee
Currently the MMC2 device configuration is defined for OMAP2430 when CONFIG_ARCH_OMAP243X is defined. This should be CONFIG_ARCH_OMAP2430. Signed-off-by: Seth Forshee [EMAIL PROTECTED] --- arch/arm/plat-omap/devices.c |6 +++--- 1 files changed, 3 insertions(+), 3 deletions(-) diff --git

Re: [PATCH 1/1] ARM: OMAP: omap3beagle: register SD interface

2008-04-24 Thread Koen Kooi
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Op 24 apr 2008, om 02:21 heeft Tony Lindgren het volgende geschreven: Hi, * Koen Kooi [EMAIL PROTECTED] [080423 00:42]: From dac3cdc5952ab39fa7ae0545d43e2daa95329b07 Mon Sep 17 00:00:00 2001 From: Koen Kooi [EMAIL PROTECTED] Date: Wed, 23 Apr

Re: [PATCH 1/1] ARM: OMAP: omap3beagle: register SD interface

2008-04-24 Thread Tony Lindgren
* Koen Kooi [EMAIL PROTECTED] [080424 12:54]: Op 24 apr 2008, om 02:21 heeft Tony Lindgren het volgende geschreven: Hi, * Koen Kooi [EMAIL PROTECTED] [080423 00:42]: From dac3cdc5952ab39fa7ae0545d43e2daa95329b07 Mon Sep 17 00:00:00 2001 From: Koen Kooi [EMAIL PROTECTED] Date:

Re: [PATCH 1/1] ARM: OMAP: omap3beagle: register SD interface

2008-04-24 Thread Tony Lindgren
* Tony Lindgren [EMAIL PROTECTED] [080424 13:00]: * Koen Kooi [EMAIL PROTECTED] [080424 12:54]: Op 24 apr 2008, om 02:21 heeft Tony Lindgren het volgende geschreven: Hi, * Koen Kooi [EMAIL PROTECTED] [080423 00:42]: From dac3cdc5952ab39fa7ae0545d43e2daa95329b07 Mon Sep 17

Re: [PATCH] USB: Generalize usb initialization for omap hw

2008-04-24 Thread Tony Lindgren
* David Brownell [EMAIL PROTECTED] [080424 12:07]: Looks better to me, but: On Thursday 24 April 2008, Felipe Balbi wrote: +static void setup_ehci_io_mux(void) +{ +#ifdef CONFIG_OMAP_EHCI_PHY_MODE This PHY_MODE thing should probably be provided by the board data not Kconfig, and

Re: [PATCH 1/1] ARM: OMAP: omap3beagle: register SD interface

2008-04-24 Thread Koen Kooi
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Op 24 apr 2008, om 22:00 heeft Tony Lindgren het volgende geschreven: * Koen Kooi [EMAIL PROTECTED] [080424 12:54]: Op 24 apr 2008, om 02:21 heeft Tony Lindgren het volgende geschreven: Hi, * Koen Kooi [EMAIL PROTECTED] [080423 00:42]: From

Re: [PATCH] USB: Generalize usb initialization for omap hw

2008-04-24 Thread Felipe Balbi
On Thu, Apr 24, 2008 at 01:48:11PM -0700, Tony Lindgren wrote: * David Brownell [EMAIL PROTECTED] [080424 12:07]: Looks better to me, but: On Thursday 24 April 2008, Felipe Balbi wrote: +static void setup_ehci_io_mux(void) +{ +#ifdef CONFIG_OMAP_EHCI_PHY_MODE This PHY_MODE

Re: [PATCH 0/5] Updates on mcbsp driver

2008-04-24 Thread Felipe Balbi
On Thu, Apr 24, 2008 at 11:54:20AM -0400, Eduardo Valentin wrote: From: Eduardo Valentin [EMAIL PROTECTED] This patch series updates mcbsp driver by transforming it into a platform driver. This is a very initial implementation. Basically it moves machine specific code to their correct place

Re: framebuffer on 2430sdp, configuration and bug

2008-04-24 Thread Felipe Balbi
On Thu, Apr 24, 2008 at 06:57:48PM +0200, Simon Braunschmidt wrote: Hi all We are running 2.6.24-omap1. We have problems to get the framebuffer driver running on a SDP2430-VG5.0.1 board. At the moment the LCD stays dark, no penguin to be seen, test program not displaying anything,

Re: [PATCH 0/5] Updates on mcbsp driver

2008-04-24 Thread Igor Stoppa
On Fri, 2008-04-25 at 00:10 +0300, ext Felipe Balbi wrote: On Thu, Apr 24, 2008 at 11:54:20AM -0400, Eduardo Valentin wrote: From: Eduardo Valentin [EMAIL PROTECTED] This patch series updates mcbsp driver by transforming it into a platform driver. This is a very initial implementation.

mmc generalization

2008-04-24 Thread Felipe Balbi
Hi all, The following patch, similarly to usb patch, makes mmc_init more generic by moving files around and changing function names. *** COMPILE TESTED ONLY *** Please give it a review, I might let something out. BR, - Balbi -- To unsubscribe from this list: send the line unsubscribe

Re: [PATCH 1/4] Adding OMAP3 EVM support

2008-04-24 Thread Kevin Hilman
Minor cosmetic suggestion... As new files are added, can we please leave out full path to the file in the file header? Not only is this unnecessary clutter, after a short amount of time, these are usually wrong as files get renamed, reorganized etc. and the paths rarely get updated. It's best

PRCM_CLKSRC_CTRL bits set incorrectly in omap2_en_osc_ck

2008-04-24 Thread Seth Forshee
On my OMAP2430 board I was seeing the contents of DRAM become corrupted shortly after the kernel started. I tracked this down to omap2_enable_osc_ck(). I think this function is intended to only clear the bits in OMAP_AUTOEXTCLKMODE_MASK, but it has the side-effect of setting all of the other

RE: [PATCH 4/5] OMAP3xx: Add DMA and IRQ definition for McBSP 1 and 2

2008-04-24 Thread Gadiyar, Anand
snip diff --git a/include/asm-arm/arch-omap/dma.h b/include/asm-arm/arch-omap/dma.h index be0431e..270e158 100644 --- a/include/asm-arm/arch-omap/dma.h +++ b/include/asm-arm/arch-omap/dma.h @@ -273,6 +273,10 @@ #define OMAP24XX_DMA_MS 63 /* S_DMA_62 */ #define

Re: [PATCH 4/5] OMAP3xx: Add DMA and IRQ definition for McBSP 1 and 2

2008-04-24 Thread Eduardo Valentin
Hi Anand, On Fri, Apr 25, 2008 at 1:11 AM, Gadiyar, Anand [EMAIL PROTECTED] wrote: snip diff --git a/include/asm-arm/arch-omap/dma.h b/include/asm-arm/arch-omap/dma.h index be0431e..270e158 100644 --- a/include/asm-arm/arch-omap/dma.h +++ b/include/asm-arm/arch-omap/dma.h @@

Re: [PATCH 0/5] Updates on mcbsp driver

2008-04-24 Thread Eduardo Valentin
Hi Tony and Igor, snip checkpatch doesn't complain, although i didn't really test it. However I'd prefer see this patchset being merged with [RFC/PATCH 1/1] McBSP support for 2430/34XX and only later considered for integration. Yeah, Chandra and Eduardo, can you guys

RE: [PATCH 4/5] OMAP3xx: Add DMA and IRQ definition for McBSP 1 and 2

2008-04-24 Thread Gadiyar, Anand
snip diff --git a/include/asm-arm/arch-omap/dma.h b/include/asm-arm/arch-omap/dma.h index be0431e..270e158 100644 --- a/include/asm-arm/arch-omap/dma.h +++ b/include/asm-arm/arch-omap/dma.h @@ -273,6 +273,10 @@ #define OMAP24XX_DMA_MS 63 /*