Re: [PATCH v16 09/12] OMAP: dmtimer: low-power mode support

2011-09-21 Thread Tony Lindgren
* Tarun Kanti DebBarma tarun.ka...@ti.com [110920 03:57]: Clock is enabled only when timer is started and disabled when the the timer is stopped. Therefore before accessing registers in functions clock is enabled and then disabled back at the end of access. Context save is done dynamically

Re: [PATCH v16 12/12] OMAP: dmtimer: get rid of timer_ip_version field

2011-09-21 Thread Tony Lindgren
* Tarun Kanti DebBarma tarun.ka...@ti.com [110920 03:57]: We do not need this field in dmtimer_platform_data{} anymore. Instead, read tidr register to identify the ip version now. Let's wait a bit on this one as Benoit had some comments regarding the use of tidr. Regards, Tony -- To

Re: [PATCH v16 01/12] OMAP2+: dmtimer: add device names to flck nodes

2011-09-21 Thread Tony Lindgren
* Tarun Kanti DebBarma tarun.ka...@ti.com [110920 03:57]: Add device name to OMAP2 dmtimer fclk nodes so that the fclk nodes can be retrieved by doing a clk_get with the corresponding device pointers or device names. Reviewed-by: Santosh Shilimkar santosh.shilim...@ti.com Signed-off-by:

Re: [PATCH v16 07/12] OMAP: dmtimer: add timeout to low-level routines

2011-09-21 Thread Tony Lindgren
* Tarun Kanti DebBarma tarun.ka...@ti.com [110920 03:57]: @@ -254,9 +259,15 @@ int omap_dm_timer_prepare(struct omap_dm_timer *timer); static inline u32 __omap_dm_timer_read(struct omap_dm_timer *timer, u32 reg, int posted) { - if (posted)

Re: [PATCH v16 05/12] OMAP: dmtimer: switch-over to platform device driver

2011-09-21 Thread Tony Lindgren
* Tarun Kanti DebBarma tarun.ka...@ti.com [110920 03:57]: @@ -347,15 +346,16 @@ static inline void __omap_dm_timer_stop(struct omap_dm_timer *timer, if (l OMAP_TIMER_CTRL_ST) { l = ~0x1; __omap_dm_timer_write(timer, OMAP_TIMER_CTRL_REG, l, posted); -#ifdef

Re: [PATCH v16 07/12] OMAP: dmtimer: add timeout to low-level routines

2011-09-21 Thread DebBarma, Tarun Kanti
Let's leave out these changes for now, they make the omap2_gp_timer_set_next_event used for system timer interrupts huge if you take a look at it with objdump. Later on we might want to split the posted bit check into a separate inline function, and then you can implement this for the device

Re: [PATCH 8/8] OMAP4: Fix the emif and dmm virtual mapping

2011-09-21 Thread Shilimkar, Santosh
On Wed, Sep 21, 2011 at 11:01 PM, Kevin Hilman khil...@ti.com wrote: Santosh Shilimkar santosh.shilim...@ti.com writes: On Tuesday 20 September 2011 08:31 PM, Santosh Shilimkar wrote: On Friday 16 September 2011 11:26 PM, Kevin Hilman wrote: Santosh Shilimkar santosh.shilim...@ti.com writes:

Re: [PATCH v16 05/12] OMAP: dmtimer: switch-over to platform device driver

2011-09-21 Thread DebBarma, Tarun Kanti
[...]       /* Ack possibly pending interrupt */ I've left out this is_omap2 change as it really does not improve anything. Instead it just makes __omap_dm_timer_stop inline function more complex. Agreed. I've also folded in the spinlock fixes in patch 10 into this patch. Ok, thanks. --

Re: [PATCH v16 01/12] OMAP2+: dmtimer: add device names to flck nodes

2011-09-21 Thread DebBarma, Tarun Kanti
On Thu, Sep 22, 2011 at 6:30 AM, Tony Lindgren t...@atomide.com wrote: * Tarun Kanti DebBarma tarun.ka...@ti.com [110920 03:57]: Add device name to OMAP2 dmtimer fclk nodes so that the fclk nodes can be retrieved by doing a clk_get with the corresponding device pointers or device names.

<    1   2