RE: [PATCH v3 1/6] mfd: TPS65910: Handle non-existent devices

2011-11-04 Thread Mohammed, Afzal
Hi Kyle, On Thu, Nov 03, 2011 at 22:38:01, Kyle Manna wrote: + ret = mfd_add_devices(tps65910-dev, -1, tps65910s, + ARRAY_SIZE(tps65910s), NULL, 0); + if (ret 0) + goto err2; Isn't goto err sufficient Regards Afzal -- To unsubscribe from this list:

[PATCH v2] OMAP: clock: optimize dpll locking logic

2011-11-04 Thread Vikram Pandita
From: Vikram Pandita vikram.pand...@ti.com If the dpll is already locked, code can be optimized to return much earlier than doing redundent set of lock mode and wait on idlest. Signed-off-by: Vikram Pandita vikram.pand...@ti.com Reviewed-by: Todd Poynor toddpoy...@google.com --- v1: initial

Re: [PATCH 1/4] cbus: add of_match_table

2011-11-04 Thread Felipe Balbi
Hi, On Thu, Nov 03, 2011 at 02:45:59PM -0700, Tony Lindgren wrote: * Felipe Balbi ba...@ti.com [111017 13:16]: then we can make DeviceTree conversion happen. Cool. Looks like n800 keeps running after these, pushing to cbus branch. need to find out a way to create all devices via

Re: [PATCH v8 00/24] gpio/omap: driver cleanup and fixes

2011-11-04 Thread DebBarma, Tarun Kanti
On Fri, Nov 4, 2011 at 3:14 AM, Kevin Hilman khil...@ti.com wrote: Tarun Kanti DebBarma tarun.ka...@ti.com writes: This series is continuation of cleanup of OMAP GPIO driver and fixes. Using this series on 3630/Zoom3, UART wakeups no longer work from suspend.  That suggests that GPIO wakeups

Re: Re: [PATCH 1/2] OMAP2+: DMA: Workaround for invalid source position

2011-11-04 Thread Péter Ujfalusi
On Thursday 03 November 2011 14:27:56 Tony Lindgren wrote: * Peter Ujfalusi peter.ujfal...@ti.com [111031 06:46]: If the DMA source position has been asked before the first actual data transfer has been done, the CSAC register does not contain valid information. We can identify this

[PATCH] MAINTAINERS: Update linux-omap git repository

2011-11-04 Thread Jarkko Nikula
linux-omap is back at git.kernel.org. Path is the same than before except -2.6 appendix. Signed-off-by: Jarkko Nikula jarkko.nik...@bitmer.com --- http://marc.info/?l=linux-omapm=132033925209702w=2 --- MAINTAINERS |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git

[PATCH RESEND] omap1: Remove unused omap-alsa.h

2011-11-04 Thread Jarkko Nikula
There is no use for omap-alsa.h and board-palmz71.c doesn't need it either. Signed-off-by: Jarkko Nikula jarkko.nik...@bitmer.com --- arch/arm/mach-omap1/board-palmz71.c |1 - arch/arm/plat-omap/include/plat/omap-alsa.h | 123 --- 2 files changed, 0

[PATCH 1/4] mmc: Add additional binding for mmc host controller

2011-11-04 Thread Rajendra Nayak
Add mmc host controller capability binding to support 'MMC_CAP_POWER_OFF_CARD' powering off of the card after boot. Signed-off-by: Rajendra Nayak rna...@ti.com --- .../devicetree/bindings/mmc/linux-mmc-host.txt |1 + drivers/mmc/core/host.c|2 ++ 2 files

[PATCH 0/4] omap hsmmc device tree support

2011-11-04 Thread Rajendra Nayak
This series adds device tree support for omap hsmmc driver. The series is currently based on my patch series[1] to add dt support for twl-regulators, since hsmmc requires regulators to work. I have also pulled the patch from Thomas Abraham which adds mmc host controller bindings[2] 'mmc: Add OF

[PATCH 4/4] omap4: mmc: use auxdata to pass platform function ptrs

2011-11-04 Thread Rajendra Nayak
mmc driver still relies on platform specific functions being invoked from the driver by means of function pointers being passed through platform_data structure. use the auxdata for now to pass these the same way until we find a way to get rid of these calls from the driver. Signed-off-by:

[PATCH 2/4] mmc: omap: adapt the hsmmc driver to device tree

2011-11-04 Thread Rajendra Nayak
Define dt bindings for the ti-omap-hsmmc, and adapt the driver to extract data (which was earlier passed as platform_data) from device tree node. Signed-off-by: Rajendra Nayak rna...@ti.com --- .../devicetree/bindings/mmc/ti-omap-hsmmc.txt | 50 + drivers/mmc/host/omap_hsmmc.c

[PATCH 3/4] omap4: mmc: Pass SoC and board data for omap4 mmc from dt

2011-11-04 Thread Rajendra Nayak
Pass all omap4-hsmmc related data from device tree. Currenly limited to only omap4-panda and omap4-sdp boards. Signed-off-by: Rajendra Nayak rna...@ti.com --- arch/arm/boot/dts/omap4-panda.dts | 23 ++ arch/arm/boot/dts/omap4-sdp.dts | 33 ++

Re: Simple GPMC device driver with basic User application

2011-11-04 Thread Philip Balister
On 11/03/2011 03:25 PM, Tony Lindgren wrote: * James angweiy...@gmail.com [111023 18:13]: Dear all, I'm learning embedded linux development and need help on my task. I'm trying to communicate with a FPGA via the GPMC bus on my Overo FE board and need assistance with writing a simple device

Re: omap_hsmmc noisy/broken for suspend resume

2011-11-04 Thread T Krishnamoorthy, Balaji
On Fri, Nov 4, 2011 at 2:54 AM, Kevin Hilman khil...@ti.com wrote: Hello, Using Linus' master branch, I was testing PM functionality on OMAP3/4 and noticed that the MMC driver is now rather noisy during suspend on OMAP3[1], but seems to work. On OMAP4, MMC seems to prevent suspend/resume

Re: [PATCH 1/4] cbus: add of_match_table

2011-11-04 Thread Cousson, Benoit
Hi Felipe, On 11/4/2011 10:13 AM, Balbi, Felipe wrote: Hi, On Thu, Nov 03, 2011 at 02:45:59PM -0700, Tony Lindgren wrote: * Felipe Balbiba...@ti.com [111017 13:16]: then we can make DeviceTree conversion happen. Cool. Looks like n800 keeps running after these, pushing to cbus branch.

[PATCH 0/2] PMIC TPS65910 fixes

2011-11-04 Thread Afzal Mohammed
Hi, This series applies over Kyle Manna's v3 patch series, https://lkml.org/lkml/2011/11/3/257, with changes as per comments on his 1/6 mfd: TPS65910: Handle non-existent devices Regards Afzal Afzal Mohammed (2): mfd: TPS65910: Improvements regulator:TPS65910: VDD1/2 voltage selector count

[PATCH 1/2] mfd: TPS65910: Improvements

2011-11-04 Thread Afzal Mohammed
Two changes, 1. TPS65910 can be used even if interrupt is unused. Hence let probe succeed in case interrupts can't be initialized and let Kernel only to cry about it 2. struct tps65910_platform_data usage can be avoided by making use of struct tps65910_board to simplify driver. Hence remove

[PATCH 2/2] regulator:TPS65910: VDD1/2 voltage selector count

2011-11-04 Thread Afzal Mohammed
Count of selector voltage is required for regulator_set_voltage to work via set_voltage_sel. VDD1/2 currently have it as zero, so regulator_set_voltage won't work for VDD1/2 Update count (n_voltages) for VDD1/2 Signed-off-by: Afzal Mohammed af...@ti.com ---

Re: [PATCH 2/2] regulator:TPS65910: VDD1/2 voltage selector count

2011-11-04 Thread Mark Brown
On Fri, Nov 04, 2011 at 06:18:48PM +0530, Afzal Mohammed wrote: if (i == TPS65910_REG_VDD1 || i == TPS65910_REG_VDD2) { pmic-desc[i].ops = tps65910_ops_dcdc; + pmic-desc[i].n_voltages = VDD1_2_NUM_VOLTS * 3; This looks suspicous - what's

OMAP3: PM/DSS2: Suspend broken with DSS2 in 3.1?

2011-11-04 Thread Joe Woodward
I've just switched to the 3.1 mainline kernel from 3.0.4 and am noticing some problems. I'm running a GUMSTIX Overo Fire (OMAP3530), with a GUMSTIX supplied PALO43 dev kit (to bring out USB/LAN/AUDIO/DISPLAY). My config is roughly based on the omap2plus_defconfig with DSS2 built-in (rather

Re: [PATCH 1/1] arm: omap: removed obsolete IRQF_DISABLED

2011-11-04 Thread Michael Opdenacker
Hi Tony, On 11/03/2011 06:15 PM, Tony Lindgren wrote: * Michael Opdenacker michael.opdenac...@linaro.org [111008 22:13]: This flag is a NOOP since 2.6.36 Looks like there's an ARM wide patch to do this with [PATCH 03/55] arm: irq: Remove IRQF_DISABLED. Good. Let's take this one then. I hadn't

RE: [PATCH 2/2] regulator:TPS65910: VDD1/2 voltage selector count

2011-11-04 Thread Mohammed, Afzal
Hi Brown, On Fri, Nov 04, 2011 at 19:34:22, Mark Brown wrote: On Fri, Nov 04, 2011 at 06:18:48PM +0530, Afzal Mohammed wrote: if (i == TPS65910_REG_VDD1 || i == TPS65910_REG_VDD2) { pmic-desc[i].ops = tps65910_ops_dcdc; +

OMAP: TWL4030: Sound broken in 3.1

2011-11-04 Thread Joe Woodward
In 3.1 sound support is broken for any boards using a TWL4030-based CODEC. The Kconfig option for the TWL4030 CODEC used to be TWL4030_CODEC, and in 3.1 this has been changed to MFD_TWL4030_AUDIO. I believe this has caused a problem in drives/mfd/twl-core.c:112 as the define for the

Re: [PATCH 1/2] mfd: TPS65910: Improvements

2011-11-04 Thread Mark Brown
On Fri, Nov 04, 2011 at 06:18:32PM +0530, Afzal Mohammed wrote: Two changes, ...should be in two separate commits. 2. struct tps65910_platform_data usage can be avoided by making use of struct tps65910_board to simplify driver. Hence remove it Why is this a simplification? Note that one

Re: [PATCH 2/2] regulator:TPS65910: VDD1/2 voltage selector count

2011-11-04 Thread Mark Brown
On Fri, Nov 04, 2011 at 02:26:05PM +, Mohammed, Afzal wrote: Hi Brown, Ahem. On Fri, Nov 04, 2011 at 19:34:22, Mark Brown wrote: On Fri, Nov 04, 2011 at 06:18:48PM +0530, Afzal Mohammed wrote: if (i == TPS65910_REG_VDD1 || i == TPS65910_REG_VDD2) {

Re: OMAP: TWL4030: Sound broken in 3.1

2011-11-04 Thread Péter Ujfalusi
On Friday 04 November 2011 15:18:05 Joe Woodward wrote: In 3.1 sound support is broken for any boards using a TWL4030-based CODEC. The Kconfig option for the TWL4030 CODEC used to be TWL4030_CODEC, and in 3.1 this has been changed to MFD_TWL4030_AUDIO. I believe this has caused a problem

RE: [PATCH 1/2] mfd: TPS65910: Improvements

2011-11-04 Thread Mohammed, Afzal
Hi Mark, On Fri, Nov 04, 2011 at 20:54:11, Mark Brown wrote: ...should be in two separate commits. Ok 2. struct tps65910_platform_data usage can be avoided by making use of struct tps65910_board to simplify driver. Hence remove it Why is this a simplification? Note that one of

RE: [PATCH 2/2] regulator:TPS65910: VDD1/2 voltage selector count

2011-11-04 Thread Mohammed, Afzal
Hi Mark, On Fri, Nov 04, 2011 at 20:55:59, Mark Brown wrote: On Fri, Nov 04, 2011 at 02:26:05PM +, Mohammed, Afzal wrote: Hi Brown, Ahem. I am sorry for that if it offended you, not deliberate, this may have to do with our different cultures, for me it is always a confusion whether I

Re: [PATCH 2/2] regulator:TPS65910: VDD1/2 voltage selector count

2011-11-04 Thread Mark Brown
On Fri, Nov 04, 2011 at 04:01:04PM +, Mohammed, Afzal wrote: On Fri, Nov 04, 2011 at 20:55:59, Mark Brown wrote: That doesn't really clarify things - the question is why the number of voltages we can set is three times a constant called _NUM_VOLTS? _NUM_VOLTS is the number of voltage

RE: [PATCH 2/2] regulator:TPS65910: VDD1/2 voltage selector count

2011-11-04 Thread Mohammed, Afzal
Hi Mark, On Fri, Nov 04, 2011 at 21:48:56, Mark Brown wrote: So that definitely seems wrong then - n_voltages is supposed to be the number of voltages that can be selected so if the regulator supports _NUM_VOLTS steps then I'd expect to see that constant used directly. Otherwise I'd suggest

Re: [PATCH 2/2] regulator:TPS65910: VDD1/2 voltage selector count

2011-11-04 Thread Mark Brown
On Fri, Nov 04, 2011 at 04:32:43PM +, Mohammed, Afzal wrote: On Fri, Nov 04, 2011 at 21:48:56, Mark Brown wrote: So that definitely seems wrong then - n_voltages is supposed to be the number of voltages that can be selected so if the regulator supports _NUM_VOLTS steps then I'd expect

Re: [PATCH v8 REPOST 17/24] gpio/omap: fix debounce clock handling

2011-11-04 Thread Kevin Hilman
Tarun Kanti DebBarma tarun.ka...@ti.com writes: Currently debounce clock state is not tracked in the system. ?? bank-dbck_enable_mask ? The bank-dbck is enabled/disabled in suspend/idle paths irrespective of whether debounce interval has been set or not. No. It's conditional based on

RE: [PATCH 2/2] regulator:TPS65910: VDD1/2 voltage selector count

2011-11-04 Thread Mohammed, Afzal
Hi Mark, On Fri, Nov 04, 2011 at 22:10:09, Mark Brown wrote: What do you mean when you say gain? Effective voltage expression is (value1 * 12.5mV + 562.5 mV) * value2. In this value2 is being called as gain. value1 can have values from 3 to 75, both inclusive (73 steps) value2 can have

Re: [PATCH v8 24/24] gpio/omap: handle set_dataout reg capable IP on restore

2011-11-04 Thread Kevin Hilman
Tarun Kanti DebBarma tarun.ka...@ti.com writes: From: Nishanth Menon n...@ti.com GPIO IP revisions such as those used in OMAP4 have a set_dataout while the previous revisions used a single dataout register. Depending on what is available restore the dataout settings to the right register.

Re: [PATCH v8 REPOST 21/24] gpio/omap: save and restore debounce registers

2011-11-04 Thread Kevin Hilman
Tarun Kanti DebBarma tarun.ka...@ti.com writes: From: Nishanth Menon n...@ti.com GPIO debounce registers need to be saved and restored for proper functioning of driver. OK. To save the registers, we cannot cut the clock before the save, hence move the clk disable after the save. This

Re: [PATCH v8 16/24] gpio/omap: use pm-runtime framework

2011-11-04 Thread Kevin Hilman
Tarun Kanti DebBarma tarun.ka...@ti.com writes: Call runtime pm APIs pm_runtime_get_sync() and pm_runtime_put_sync() for enabling/disabling clocks appropriately. Remove syscore_ops and instead use SET_RUNTIME_PM_OPS macro. Signed-off-by: Charulatha V ch...@ti.com Signed-off-by: Tarun Kanti

Re: [PATCH 2/2] regulator:TPS65910: VDD1/2 voltage selector count

2011-11-04 Thread Mark Brown
On Fri, Nov 04, 2011 at 04:48:09PM +, Mohammed, Afzal wrote: Effective voltage expression is (value1 * 12.5mV + 562.5 mV) * value2. In this value2 is being called as gain. value1 can have values from 3 to 75, both inclusive (73 steps) value2 can have from 1 to 3, both inclusive (3

Re: OMAP: TWL4030: Sound broken in 3.1

2011-11-04 Thread Thomas Weber
Isn't this patch fixing it already? https://lkml.org/lkml/2011/9/5/37 Thomas Péter Ujfalusi peter.ujfal...@ti.com wrote: On Friday 04 November 2011 15:18:05 Joe Woodward wrote: In 3.1 sound support is broken for any boards using a TWL4030-based CODEC. The Kconfig option for the TWL4030

Re: OMAP: TWL4030: Sound broken in 3.1

2011-11-04 Thread Ujfalusi, Peter
On Fri, Nov 4, 2011 at 8:49 PM, Thomas Weber thomas.weber.li...@googlemail.com wrote: Isn't this patch fixing it already? https://lkml.org/lkml/2011/9/5/37 Yes, it should. -- Péter -- To unsubscribe from this list: send the line unsubscribe linux-omap in the body of a message to

Re: [PATCH 1/4] mmc: Add additional binding for mmc host controller

2011-11-04 Thread Olof Johansson
On Fri, Nov 04, 2011 at 05:20:38PM +0530, Rajendra Nayak wrote: Add mmc host controller capability binding to support 'MMC_CAP_POWER_OFF_CARD' powering off of the card after boot. This adds a new undocumented property (also, see comments on Thomas Abraham's patch for more comments on that

Re: [PATCH 2/4] mmc: omap: adapt the hsmmc driver to device tree

2011-11-04 Thread Olof Johansson
On Fri, Nov 04, 2011 at 05:20:39PM +0530, Rajendra Nayak wrote: Define dt bindings for the ti-omap-hsmmc, and adapt the driver to extract data (which was earlier passed as platform_data) from device tree node. Signed-off-by: Rajendra Nayak rna...@ti.com ---

Re: Re: [PATCH 1/2] OMAP2+: DMA: Workaround for invalid source position

2011-11-04 Thread Tony Lindgren
* Péter Ujfalusi peter.ujfal...@ti.com [04 02:00]: On Thursday 03 November 2011 14:27:56 Tony Lindgren wrote: Should these tests be done only after the errata re-read for both src and dst patches? Otherwise the errata will not be handled? Yes that might be a good idea. I was trying

Re: [PATCH v3 0/4] Device tree support for regulators

2011-11-04 Thread Olof Johansson
On Thu, Oct 27, 2011 at 2:08 AM, Mark Brown broo...@opensource.wolfsonmicro.com wrote: On Thu, Oct 27, 2011 at 01:26:21PM +0530, Rajendra Nayak wrote: v3 is based on the latest devicetree/next and is tested (with twl adaptaions, which will be posted seperately) on the OMAP4 panda and OMAP4

Re: [PATCHv3 03/11] omap3: add vp and vc parameter data

2011-11-04 Thread Kevin Hilman
Tero Kristo t-kri...@ti.com writes: Signed-off-by: Tero Kristo t-kri...@ti.com Missing descriptive changelog. In particular, mentioning the spec where these voltages came from would be most helpful for future reference. Kevin -- To unsubscribe from this list: send the line unsubscribe

Re: [PATCHv3 04/11] omap4: add vp and vc parameter data

2011-11-04 Thread Kevin Hilman
Tero Kristo t-kri...@ti.com writes: Signed-off-by: Tero Kristo t-kri...@ti.com Missing descriptive changelog. Kevin -- To unsubscribe from this list: send the line unsubscribe linux-omap in the body of a message to majord...@vger.kernel.org More majordomo info at

Re: [PATCH v4 1/4] regulator: helper routine to extract regulator_init_data

2011-11-04 Thread Olof Johansson
On Thu, Oct 27, 2011 at 06:54:24PM +0530, Rajendra Nayak wrote: The helper routine is meant to be used by the regulator drivers to extract the regulator_init_data structure from the data that is passed from device tree. 'consumer_supplies' which is part of regulator_init_data is not extracted

Re: [PATCH v3 2/4] regulator: adapt fixed regulator driver to dt

2011-11-04 Thread Olof Johansson
On Thu, Oct 27, 2011 at 01:26:23PM +0530, Rajendra Nayak wrote: The fixed regulator driver uses of_get_fixed_voltage_config() to extract fixed_voltage_config structure contents from device tree. Also add documenation for additional bindings for fixed regulators that can be passed through dt.

Re: [PATCHv3 11/11] omap4: use lp params for calculating pmic setup times

2011-11-04 Thread Kevin Hilman
Tero Kristo t-kri...@ti.com writes: Signed-off-by: Tero Kristo t-kri...@ti.com Missing descriptive changelog. Why are the PMIC timings not relevant for OMAP3? Kevin --- arch/arm/mach-omap2/vc.c |9 + 1 files changed, 9 insertions(+), 0 deletions(-) diff --git

Re: [PATCH v3 2/4] regulator: adapt fixed regulator driver to dt

2011-11-04 Thread Mark Brown
On Fri, Nov 04, 2011 at 01:34:22PM -0700, Olof Johansson wrote: Shouldn't a fixed regulator just be a subset of a fixed one? If so, should the binding be merged with that one? No, the fixed voltage regultor is a superset of a general regulator - it has additional information like the voltage

Re: [PATCHv3 05/11] OMAP2+: PM: provide mechanism to describe overall behavior of osc and PMIC.

2011-11-04 Thread Kevin Hilman
Tero Kristo t-kri...@ti.com writes: From: Nishanth Menon n...@ti.com We currently have mechanisms in place to describe the PMIC per rail, however we also need to configure the system for situations such as OFF mode, where, oscillator switch off and on time, and similar durations for PMIC

Re: [PATCH v3 0/4] Device tree support for regulators

2011-11-04 Thread Mark Brown
On Fri, Nov 04, 2011 at 01:21:26PM -0700, Olof Johansson wrote: On Thu, Oct 27, 2011 at 2:08 AM, Mark Brown Looking at the device bindings I notice that these bindings loose the ability to assign a descriptive name to regulator outputs.  This is really useful for making it easy to tie the

Re: [PATCHv3 06/11] omap3+: vc: use new vc_params and vp_params in parameter calculations

2011-11-04 Thread Kevin Hilman
Tero Kristo t-kri...@ti.com writes: Signed-off-by: Tero Kristo t-kri...@ti.com Missing descriptive changelog. Some minor comments below... Also, all of these timing calculations would benefit from a few more pairs of eyes looking at this stuff, as I'm not the expert here. In particular, I'd

Re: [PATCHv3 07/11] omap3+: vp: use new vp_params for calculating vddmin and vddmax

2011-11-04 Thread Kevin Hilman
Tero Kristo t-kri...@ti.com writes: Now we select the vddmin and vddmax values based on both pmic and voltage processor data, this allows usage of different power ICs. Signed-off-by: Tero Kristo t-kri...@ti.com --- arch/arm/mach-omap2/vp.c |8 ++-- 1 files changed, 6

Re: [PATCH v4 1/4] regulator: helper routine to extract regulator_init_data

2011-11-04 Thread Mark Brown
On Fri, Nov 04, 2011 at 01:29:05PM -0700, Olof Johansson wrote: On Thu, Oct 27, 2011 at 06:54:24PM +0530, Rajendra Nayak wrote: @@ -0,0 +1,33 @@ +Voltage/Current Regulators There should be a mandatory compatible field here, right? I.e. a topmost generic one, regulator or similar. It's

Re: [PATCHv3 08/11] omap3+: voltage: remove obsolete parameters

2011-11-04 Thread Kevin Hilman
Tero Kristo t-kri...@ti.com writes: Voltages for different operating modes are now provided by vc_params. Oscillator setup times are handled as board specific. Signed-off-by: Tero Kristo t-kri...@ti.com These should be removed in the previous patches. That gets at a bigger problem with this

Re: [PATCH v3 2/4] regulator: adapt fixed regulator driver to dt

2011-11-04 Thread Olof Johansson
On Fri, Nov 04, 2011 at 09:01:52PM +, Mark Brown wrote: On Fri, Nov 04, 2011 at 01:34:22PM -0700, Olof Johansson wrote: Shouldn't a fixed regulator just be a subset of a fixed one? If so, should the binding be merged with that one? No, the fixed voltage regultor is a superset of a

Re: [PATCHv3 09/11] omap4: twl: added pmic startup / shutdown times

2011-11-04 Thread Kevin Hilman
Tero Kristo t-kri...@ti.com writes: Signed-off-by: Tero Kristo t-kri...@ti.com Missing descriptive changelog. --- arch/arm/mach-omap2/omap_twl.c | 17 + 1 files changed, 17 insertions(+), 0 deletions(-) diff --git a/arch/arm/mach-omap2/omap_twl.c

Re: [PATCHv3 09/11] omap4: twl: added pmic startup / shutdown times

2011-11-04 Thread Kevin Hilman
Tero Kristo t-kri...@ti.com writes: [...] +static struct twl_lp_description omap4_pmic_lp_desc = { + .pmic_shut_time = 500, + .pmic_start_time= 500, +}; Also, please note where these timings come from (TRM, data sheet, etc.) Kevin -- To unsubscribe from this list:

Re: [PATCH v4 1/4] regulator: helper routine to extract regulator_init_data

2011-11-04 Thread Olof Johansson
On Fri, Nov 04, 2011 at 09:14:48PM +, Mark Brown wrote: On Fri, Nov 04, 2011 at 01:29:05PM -0700, Olof Johansson wrote: On Thu, Oct 27, 2011 at 06:54:24PM +0530, Rajendra Nayak wrote: @@ -0,0 +1,33 @@ +Voltage/Current Regulators There should be a mandatory compatible field here,

Re: [PATCH 2/4] mmc: omap: adapt the hsmmc driver to device tree

2011-11-04 Thread Cousson, Benoit
Hi Olof, On 11/4/2011 9:04 PM, Olof Johansson wrote: On Fri, Nov 04, 2011 at 05:20:39PM +0530, Rajendra Nayak wrote: Define dt bindings for the ti-omap-hsmmc, and adapt the driver to extract data (which was earlier passed as platform_data) from device tree node. Signed-off-by: Rajendra

Re: [PATCH v3 2/4] regulator: adapt fixed regulator driver to dt

2011-11-04 Thread Mark Brown
On Fri, Nov 04, 2011 at 02:18:24PM -0700, Olof Johansson wrote: On Fri, Nov 04, 2011 at 09:01:52PM +, Mark Brown wrote: No, the fixed voltage regultor is a superset of a general regulator - it has additional information like the voltage it supplies and the optional enable GPIO.

Re: [PATCH 2/4] mmc: omap: adapt the hsmmc driver to device tree

2011-11-04 Thread Olof Johansson
On Fri, Nov 4, 2011 at 2:25 PM, Cousson, Benoit b-cous...@ti.com wrote: Hi Olof, On 11/4/2011 9:04 PM, Olof Johansson wrote: On Fri, Nov 04, 2011 at 05:20:39PM +0530, Rajendra Nayak wrote: Define dt bindings for the ti-omap-hsmmc, and adapt the driver to extract data (which was earlier

Re: [PATCH v4 1/4] regulator: helper routine to extract regulator_init_data

2011-11-04 Thread Mark Brown
On Fri, Nov 04, 2011 at 02:22:16PM -0700, Olof Johansson wrote: On Fri, Nov 04, 2011 at 09:14:48PM +, Mark Brown wrote: The name will be fixed by the individual device bindings, this is specifying the general form of a supply property. Each device binding will define the set of

Re: [PATCH v4 1/4] regulator: helper routine to extract regulator_init_data

2011-11-04 Thread Olof Johansson
On Fri, Nov 4, 2011 at 2:29 PM, Mark Brown broo...@opensource.wolfsonmicro.com wrote: On Fri, Nov 04, 2011 at 02:22:16PM -0700, Olof Johansson wrote: On Fri, Nov 04, 2011 at 09:14:48PM +, Mark Brown wrote: The name will be fixed by the individual device bindings, this is specifying the

Re: [PATCHv3 10/11] omap3+: use lp params for calculating clock setup times

2011-11-04 Thread Kevin Hilman
Tero Kristo t-kri...@ti.com writes: Signed-off-by: Tero Kristo t-kri...@ti.com Missing descriptive changelog. --- arch/arm/mach-omap2/vc.c | 47 +- 1 files changed, 46 insertions(+), 1 deletions(-) diff --git a/arch/arm/mach-omap2/vc.c

Re: [PATCH] CPUIdle: Reevaluate C-states under CPU load to favor deeper C-states

2011-11-04 Thread Kevin Hilman
ping v2 Kevin Hilman khil...@ti.com writes: From: Nicole Chalhoub n-chalh...@ti.com While there is CPU load, program a C-state specific one-shot timer in order to give CPUidle another opportunity to pick a deeper C-state instead of spending potentially long idle times in a shallow C-state.

Re: [PATCH v4 1/4] regulator: helper routine to extract regulator_init_data

2011-11-04 Thread Mark Brown
On Fri, Nov 04, 2011 at 02:34:35PM -0700, Olof Johansson wrote: On Fri, Nov 4, 2011 at 2:29 PM, Mark Brown I think it's useful to define how consumers are supposed to do this somewhere - it is actually part of the core binding how consumers are supposed to do this. Yeah, ok, but it

Re: [PATCH v3 2/4] regulator: adapt fixed regulator driver to dt

2011-11-04 Thread Olof Johansson
On Fri, Nov 4, 2011 at 2:25 PM, Mark Brown broo...@opensource.wolfsonmicro.com wrote: On Fri, Nov 04, 2011 at 02:18:24PM -0700, Olof Johansson wrote: On Fri, Nov 04, 2011 at 09:01:52PM +, Mark Brown wrote: No, the fixed voltage regultor is a superset of a general regulator - it has

Re: [PATCH v3 2/4] regulator: adapt fixed regulator driver to dt

2011-11-04 Thread Mark Brown
On Fri, Nov 04, 2011 at 02:47:05PM -0700, Olof Johansson wrote: On Fri, Nov 4, 2011 at 2:25 PM, Mark Brown I don't see how you can usefully do that, the task of plumbing a regulator into a board is largely orthogonal to the specific feature set of a given regulator.  The specific bindings

Re: [PATCH v7 16/21] OMAP2+: UART: Remove custom activate funcs and use generic funcs.

2011-11-04 Thread Kevin Hilman
Govindraj.R govindraj.r...@ti.com writes: The custom hwmod activate and deactivate funcs does hwmod_enable and idle same can be done with omap_device generic API's. Signed-off-by: Govindraj.R govindraj.r...@ti.com This one needs a minor update for current mainline... ---

Re: [PATCH v3 2/4] regulator: adapt fixed regulator driver to dt

2011-11-04 Thread Olof Johansson
On Fri, Nov 4, 2011 at 2:57 PM, Mark Brown broo...@opensource.wolfsonmicro.com wrote: On Fri, Nov 04, 2011 at 02:47:05PM -0700, Olof Johansson wrote: On Fri, Nov 4, 2011 at 2:25 PM, Mark Brown I don't see how you can usefully do that, the task of plumbing a regulator into a board is largely

Re: [PATCH v4 1/4] regulator: helper routine to extract regulator_init_data

2011-11-04 Thread Olof Johansson
On Fri, Nov 4, 2011 at 2:46 PM, Mark Brown broo...@opensource.wolfsonmicro.com wrote: On Fri, Nov 04, 2011 at 02:34:35PM -0700, Olof Johansson wrote: On Fri, Nov 4, 2011 at 2:29 PM, Mark Brown I think it's useful to define how consumers are supposed to do this somewhere - it is actually

Re: [PATCH 2/4] mmc: omap: adapt the hsmmc driver to device tree

2011-11-04 Thread Segher Boessenkool
+ti,hsmmc-non-removable: non-removable slot (like eMMC) Same here, non-removable should be standardized. CHRP has a built-in property for this. That was standardised in 1998, you could reuse it :-) Segher -- To unsubscribe from this list: send the line unsubscribe linux-omap in the body

Re: [PATCH v3 2/4] regulator: adapt fixed regulator driver to dt

2011-11-04 Thread Mark Brown
On Fri, Nov 04, 2011 at 03:09:32PM -0700, Olof Johansson wrote: But even things like allowing (optional) attributes such as startup-delay on non-fixed regulators could make sense. Keep in mind that the device tree should focus on describing the hardware, not just what the linux driver needs

Re: [PATCH v4 1/4] regulator: helper routine to extract regulator_init_data

2011-11-04 Thread Mark Brown
On Fri, Nov 04, 2011 at 03:16:12PM -0700, Olof Johansson wrote: On Fri, Nov 4, 2011 at 2:46 PM, Mark Brown Describing that in the device tree using regulator-specifiers shouldn't be too bad? The LDO will reference the DCDC as the parent supply (or input or whatever language you prefer).

Re: [PATCH v7 17/21] OMAP2+: UART: Remove omap_uart_can_sleep and add pm_qos

2011-11-04 Thread Kevin Hilman
Govindraj.R govindraj.r...@ti.com writes: Omap_uart_can_sleep function blocks system wide low power state until uart is active remove this func and add qos requests to prevent ^ missing some punctuation. MPU from transitioning while uart is active and remove qos request if

Re: [PATCH v4 1/4] regulator: helper routine to extract regulator_init_data

2011-11-04 Thread Olof Johansson
On Fri, Nov 4, 2011 at 3:35 PM, Mark Brown broo...@opensource.wolfsonmicro.com wrote: On Fri, Nov 04, 2011 at 03:16:12PM -0700, Olof Johansson wrote: On Fri, Nov 4, 2011 at 2:46 PM, Mark Brown Describing that in the device tree using regulator-specifiers shouldn't be too bad? The LDO will

Re: [PATCH v7 19/21] OMAP2+: UART: Use custom activate func for console uart.

2011-11-04 Thread Kevin Hilman
Govindraj.R govindraj.r...@ti.com writes: Omap-uart can be used as console uart to print early boot messages using earlyprintk so for console uart prevent hwmod reset or idling during bootup. Identify the console_uart set the id and use the custom pm_latency ops for console uart for the

Re: [PATCH 1/1] OMAP: TWL: set clk32kg regulator on

2011-11-04 Thread Kevin Hilman
Vishal Mahaveer vish...@ti.com writes: omap4_clk32kg regulator is used by connectivity (WLAN/BT/GPS) chip on omap4 platforms. Set always_on flag to true for connectivity chip to operate. The driver/init for the connectivity chip should be using the regulator API to enable/disable the

RE: [PATCH 1/1] OMAP: TWL: set clk32kg regulator on

2011-11-04 Thread Mahaveer, Vishal
omap4_clk32kg regulator is used by connectivity (WLAN/BT/GPS) chip on omap4 platforms. Set always_on flag to true for connectivity chip to operate. The driver/init for the connectivity chip should be using the regulator API to enable/disable the regulator as needed. The connectivity chip is

Re: [PATCH v3 2/4] OMAP4: hwmod data: add mmu hwmod for ipu and dsp

2011-11-04 Thread Kevin Hilman
Omar Ramirez Luna omar.rami...@ti.com writes: Add mmu hwmod data for ipu and dsp. Signed-off-by: Omar Ramirez Luna omar.rami...@ti.com [...] +static struct omap_hwmod omap44xx_ipu_mmu_hwmod = { + .name = ipu_mmu, + .class = omap44xx_mmu_hwmod_class, +

Re: [PATCH v3 4/4] OMAP3/4: iommu: adapt to runtime pm

2011-11-04 Thread Kevin Hilman
Omar Ramirez Luna omar.rami...@ti.com writes: Use runtime PM functionality interfaced with hwmod enable/idle functions, to replace direct clock operations, reset and sysconfig handling. Tidspbridge uses a macro removed with this patch, for now the value is hardcoded to avoid breaking

Re: [PATCH 1/4] ARM: OMAP3: cm-t35: add regulator supply for ads7846

2011-11-04 Thread Tony Lindgren
* Igor Grinberg grinb...@compulab.co.il [111019 02:05]: Signed-off-by: Igor Grinberg grinb...@compulab.co.il --- arch/arm/mach-omap2/board-cm-t35.c | 18 ++ 1 files changed, 18 insertions(+), 0 deletions(-) diff --git a/arch/arm/mach-omap2/board-cm-t35.c

Re: [PATCH 1/4] ARM: OMAP3: cm-t35: add regulator supply for ads7846

2011-11-04 Thread Tony Lindgren
* Tony Lindgren t...@atomide.com [04 16:05]: * Igor Grinberg grinb...@compulab.co.il [111019 02:05]: Applying to board branch for v3.3 merge window. Hmm, actually I suggest you respin patches 2 and 3 so they apply on their own to current fixes branch. Then update 1 and 4 to apply on top

Re: [PATCH RESEND] omap1: Remove unused omap-alsa.h

2011-11-04 Thread Tony Lindgren
* Jarkko Nikula jarkko.nik...@bitmer.com [04 03:53]: There is no use for omap-alsa.h and board-palmz71.c doesn't need it either. Thanks applying into fixes. Tony -- To unsubscribe from this list: send the line unsubscribe linux-omap in the body of a message to majord...@vger.kernel.org More

Re: [PATCH] ARM: OMAP2+: devices: Fixes for McPDM

2011-11-04 Thread Tony Lindgren
* Peter Ujfalusi peter.ujfal...@ti.com [03 01:07]: Clean up the omap-mcpdm init function since this part comes via sound tree, and there has been changes regarding to hwmod/omap_device_build. Missed patches: The ARM: OMAP2+: devices: Remove all omap_device_pm_latency structures OMAP:

Re: [PATCH] ARM: OMAP2+: l3-noc: Include linux/module.h

2011-11-04 Thread Tony Lindgren
* Axel Lin axel@gmail.com [01 18:05]: Include linux/module.h to fix below build error: CC arch/arm/mach-omap2/omap_l3_noc.o arch/arm/mach-omap2/omap_l3_noc.c:240: error: expected ',' or ';' before 'MODULE_DEVICE_TABLE' arch/arm/mach-omap2/omap_l3_noc.c:250: error:

Re: [PATCH] ARM: OMAP: dmtimer: Include linux/module.h

2011-11-04 Thread Tony Lindgren
* Axel Lin axel@gmail.com [01 18:15]: Include linux/module.h to fix below build error: ... I got the build error by make omap2plus_defconfig on linux-next 2001. arch/arm/plat-omap/dmtimer.c |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git

Re: [PATCH] OMAP: I2C: Fix omap_register_i2c_bus() return value on success

2011-11-04 Thread Tony Lindgren
* Laurent Pinchart laurent.pinch...@ideasonboard.com [02 04:19]: --- a/arch/arm/plat-omap/i2c.c +++ b/arch/arm/plat-omap/i2c.c @@ -165,7 +165,7 @@ static inline int omap2_i2c_add_bus(int bus_id) omap_i2c_latency, ARRAY_SIZE(omap_i2c_latency), 0);

Re: [GIT PULL] ARM: OMAP: DSS hwmod/reset fixes for 3.2

2011-11-04 Thread Tony Lindgren
* Paul Walmsley p...@pwsan.com [111006 16:33]: Hi Tony, The following changes since commit be73246058737beec52ae232bcab7776332a9e06: ARM: OMAP2+: Remove custom init_irq for remaining boards (2011-09-26 17:50:37 -0700) are available in the git repository at:

Re: [GIT PULL] ARM: OMAP3+: clock fixes for 3.2

2011-11-04 Thread Tony Lindgren
* Paul Walmsley p...@pwsan.com [111007 00:20]: On Fri, 7 Oct 2011, Paul Walmsley wrote: The following changes since commit be73246058737beec52ae232bcab7776332a9e06: ARM: OMAP2+: Remove custom init_irq for remaining boards (2011-09-26 17:50:37 -0700) are available in the git

Re: [GIT PULL] ARM: OMAP: PRCM/SCM/hwmod miscellaneous fixes for 3.2

2011-11-04 Thread Tony Lindgren
* Paul Walmsley p...@pwsan.com [111007 01:45]: Hi Tony, The following changes since commit be73246058737beec52ae232bcab7776332a9e06: ARM: OMAP2+: Remove custom init_irq for remaining boards (2011-09-26 17:50:37 -0700) are available in the git repository at:

Re: [GIT PULL] OMAP: few more PM cleanup/fixes for v3.2

2011-11-04 Thread Tony Lindgren
* Kevin Hilman khil...@ti.com [111007 13:29]: Tony, Please pull the (hopefully) last few PM fixes/cleanups for v3.2. Kevin The following changes since commit 976d167615b64e14bc1491ca51d424e2ba9a5e84: Linux 3.1-rc9 (2011-10-04 18:11:50 -0700) are available in the git repository

Re: [GIT PULL v3] ARM: OMAP: Cortex-A9 PERIPHCLK node for 3.2

2011-11-04 Thread Tony Lindgren
* Paul Walmsley p...@pwsan.com [111010 17:09]: Hi Tony The following changes since commit be73246058737beec52ae232bcab7776332a9e06: ARM: OMAP2+: Remove custom init_irq for remaining boards (2011-09-26 17:50:37 -0700) are available in the git repository at:

Re: [PATCH] MAINTAINERS: Update linux-omap git repository

2011-11-04 Thread Tony Lindgren
* Jarkko Nikula jarkko.nik...@bitmer.com [04 03:44]: linux-omap is back at git.kernel.org. Path is the same than before except -2.6 appendix. Signed-off-by: Jarkko Nikula jarkko.nik...@bitmer.com --- http://marc.info/?l=linux-omapm=132033925209702w=2 --- MAINTAINERS |2 +- 1