Re: [PATCH V2 1/2] power: twl4030_charger: detect battery presence prior to enabling charger
* Sebastian Reichel s...@kernel.org [140723 05:05]: On Wed, Jul 23, 2014 at 02:24:20AM -0700, Tony Lindgren wrote: * Nishanth Menon n...@ti.com [140528 14:48]: TWL4030's Battery Charger seems to be designed for non-hotpluggable batteries. If battery is not present in the system, BATSTS is always set with the expectation that software will take actions to move to a required safe state (could be power down or disable various charger paths). It does not seem possible even by manipulating the edge detection of the event (using BCIEDR2 register) to have a consistent hotplug handling. This seems to be the result of BATSTS interrupt generated when the thermistor of the battery pack is disconnected from the dedicated ADIN1 pin. Clearing the status just results in the status being regenerated by the monitoring ADC(MADC) and disabling the edges of event just makes hotplug no longer function. The only other option is to disable the detection of the MADC by disabling BCIMFEN4::BATSTSMCHGEN (battery presence detector) - but then, we can never again detect battery reconnection. So, detect battery presence based on precharge(which is hardware automatic state) or default main charger configuration at the time of probe and enable charger logic only if battery was present. Reported-by: Russell King li...@arm.linux.org.uk Tested-by: Tony Lindgren t...@atomide.com Signed-off-by: Nishanth Menon n...@ti.com Dmitry, can we please get this first patch merged? This is needed on some omap3 platforms for DT based booting when no battery is present. Only the second patch in this series is still being discussed AFAIK. applied to battery-2.6.git: http://git.infradead.org/battery-2.6.git/commit/61a7784efd3c89ffb6242f29bcee170dd7f55e6b Thanks! Tony -- To unsubscribe from this list: send the line unsubscribe linux-omap in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH v2 0/3] iommu: Remove OMAP IOVMM driver
* Laurent Pinchart laurent.pinch...@ideasonboard.com [140723 07:02]: Hi Joerg, On Wednesday 23 July 2014 15:52:17 Joerg Roedel wrote: On Mon, Jul 21, 2014 at 11:19:29PM -0700, Tony Lindgren wrote: Tony, is there still time to get this (and especially patch 2/3, which touches arch/ code) in v3.17 ? Yes as long as Joerg is OK to merge that branch in :) Fine with me, I can take only patch 1 or all 3 into my arm/omap branch, given Tony's Acked-by. Then you guys can merge in this branch wherever you want :) Thank you. Assuming there's currently no conflict to be resolved, I believe the easiest would be for both you and Tony to merge my branch in your trees. Yes please merge that branch via the IOMMU tree, I only need to merge it if I see merge conflicts with it. Regards, Tony -- To unsubscribe from this list: send the line unsubscribe linux-omap in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
[PATCH 00/10 linux-next] drivers/usb: remove unnecessary break after goto/return
Small patchset addressing break redundancy on drivers/usb branch (suggested by Joe Perches). Fabian Frederick (10): USB: iowarrior: remove unnecessary break after goto USB: usblcd: remove unnecessary break after return usb: dcw3: remove unnecessary break after return usb: gadget: remove unnecessary break after return usb: gadget: remove unnecessary break after goto xhci: remove unnecessary break after return usb: storage: remove unnecessary break after return USB: serial: remove unnecessary break after return USB: ftdi_sio: remove unnecessary break after return USB: microtek: remove unnecessary break after goto drivers/usb/dwc3/ep0.c | 2 -- drivers/usb/gadget/function/f_hid.c| 8 drivers/usb/gadget/legacy/tcm_usb_gadget.c | 2 -- drivers/usb/host/xhci-mem.c| 1 - drivers/usb/image/microtek.c | 1 - drivers/usb/misc/iowarrior.c | 3 --- drivers/usb/misc/usblcd.c | 1 - drivers/usb/serial/ftdi_sio.c | 1 - drivers/usb/serial/iuu_phoenix.c | 2 -- drivers/usb/storage/freecom.c | 1 - 10 files changed, 22 deletions(-) -- 1.8.4.5 -- To unsubscribe from this list: send the line unsubscribe linux-omap in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
[PATCH 03/10 linux-next] usb: dcw3: remove unnecessary break after return
Signed-off-by: Fabian Frederick f...@skynet.be
---
drivers/usb/dwc3/ep0.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/usb/dwc3/ep0.c b/drivers/usb/dwc3/ep0.c
index 21a3520..927dad3 100644
--- a/drivers/usb/dwc3/ep0.c
+++ b/drivers/usb/dwc3/ep0.c
@@ -422,7 +422,6 @@ static int dwc3_ep0_handle_feature(struct dwc3 *dwc,
case USB_DEVICE_LTM_ENABLE:
return -EINVAL;
- break;
case USB_DEVICE_TEST_MODE:
if ((wIndex 0xff) != 0)
@@ -530,7 +529,6 @@ static int dwc3_ep0_set_config(struct dwc3 *dwc, struct
usb_ctrlrequest *ctrl)
switch (state) {
case USB_STATE_DEFAULT:
return -EINVAL;
- break;
case USB_STATE_ADDRESS:
ret = dwc3_ep0_delegate_req(dwc, ctrl);
--
1.8.4.5
--
To unsubscribe from this list: send the line unsubscribe linux-omap in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 00/10 linux-next] drivers/usb: remove unnecessary break after goto/return
On Thu, 2014-07-24 at 10:18 +0200, Fabian Frederick wrote: Small patchset addressing break redundancy on drivers/usb branch (suggested by Joe Perches). Frankly, that is not a good idea. Somebody will remove a goto and forget to readd the break Regards Oliver -- To unsubscribe from this list: send the line unsubscribe linux-omap in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
[GIT PULL] Few regression fixes for omaps for v3.16-rc series
The following changes since commit 1d29a0722f6c38f79785c9ffb911730598de84e2: ARM: OMAP2+: Remove non working OMAP HDMI audio initialization (2014-07-08 01:08:44 -0700) are available in the git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/tmlind/linux-omap tags/omap-for-v3.16/fixes-rc6 for you to fetch changes up to 33753cd2ba41c72a0756edc5dc094d91602deda5: ARM: OMAP2+: gpmc: fix gpmc_hwecc_bch_capable() (2014-07-23 01:48:24 -0700) Two regression fixes for omaps and one fix for device signaling: - L2 cache regression fix for a warning about trying to access a read-only register - GPMC ECC software fallback regression fix for omap3 - Fix for dra7 pinctrl pull-up direction that causes signal issues for anybody trying to use the internal pull up or down Christoph Fritz (1): ARM: OMAP2+: gpmc: fix gpmc_hwecc_bch_capable() Nishanth Menon (1): pinctrl: dra: dt-bindings: Fix pull enable/disable Sekhar Nori (1): ARM: OMAP2+: l2c: squelch warning dump on power control setting arch/arm/mach-omap2/gpmc-nand.c| 18 ++ arch/arm/mach-omap2/omap4-common.c | 4 include/dt-bindings/pinctrl/dra.h | 7 --- 3 files changed, 18 insertions(+), 11 deletions(-) -- To unsubscribe from this list: send the line unsubscribe linux-omap in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
[GIT PULL] non-urgent omap fixes for v3.17 merge window
The following changes since commit cd3de83f147601356395b57a8673e9c5ff1e59d1: Linux 3.16-rc4 (2014-07-06 12:37:51 -0700) are available in the git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/tmlind/linux-omap tags/omap-for-v3.17/fixes-not-urgent-signed for you to fetch changes up to 00e4e5b5b0339bde4b0ecb23d7d7969a3bebd44d: Merge remote-tracking branch 'roger/for-v3.17/gpmc-omap' into omap-for-v3.17/fixes-not-urgent (2014-07-15 00:24:39 -0700) Fixes for omaps that were not considered urgent enough for the rc series. Mostly a fix for GPMC allocation and omap5 ABB (Adaptive Body Bias). Andrii.Tseglytskyi (1): ARM: dts: OMAP5: Add device nodes for ABB Nicholas Krause (1): omap16xx: Removes fixme no longer needed in ocpi_enable() Rickard Strandqvist (1): ARM: omap2+: usb-tusb6010.c: Cleaning up variable is set more than once Rostislav Lisovy (1): ARM: omap2+: gpmc-nand: Use dynamic platform_device_alloc() Tony Lindgren (1): Merge remote-tracking branch 'roger/for-v3.17/gpmc-omap' into omap-for-v3.17/fixes-not-urgent arch/arm/boot/dts/omap5.dtsi | 60 + arch/arm/mach-omap1/ocpi.c | 1 - arch/arm/mach-omap2/gpmc-nand.c| 79 ++ arch/arm/mach-omap2/usb-tusb6010.c | 1 - 4 files changed, 97 insertions(+), 44 deletions(-) -- To unsubscribe from this list: send the line unsubscribe linux-omap in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
[GIT PULL] omap soc changes for v3.17 merge window
The following changes since commit 3db53918e306d3960bf9e12eea8b2fd3f7d0fd62: Merge tag 'for-v3.17/omap-clock-a' of git://git.kernel.org/pub/scm/linux/kernel/git/pjw/omap-pending into omap-for-v3.17/soc (2014-07-21 00:35:38 -0700) are available in the git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/tmlind/linux-omap tags/omap-for-v3.17/soc-new for you to fetch changes up to 3965f5ba0489c01f419216c8909965b9a6a39388: Merge branch 'omap-for-v3.17/mailbox' into omap-for-v3.17/soc (2014-07-23 01:26:02 -0700) SoC related changes for omaps for v3.17 merge window: - Add device tree and hwmod data for various devices for new SoCs - Remove legacy mailbox hwmod data that's no longer needed for SoCs that are DT only. Note that this may cause a minor merge conflict in mach-omap2/devices.c with omap_init_mbox() and omap_init_hdmi_audio(), both are legacy code that is getting removed Kishon Vijay Abraham I (2): arm: dra7xx: Add hwmod data for pcie1 phy and pcie2 phy arm: dra7xx: Add hwmod data for pcie1 and pcie2 subsystems Lokesh Vutla (1): ARM: DRA7: hwmod: Add data for RTC Mugunthan V N (1): arm: dra7xx: Add hwmod data for MDIO and CPSW Nishanth Menon (2): ARM: OMAP2+: DMA: remove requirement of irq for platform-dma driver ARM: DRA7: hwmod: remove interrupts for DMA Roger Quadros (1): ARM: DRA7: hwmod: Add OCP2SCP3 module Sathya Prakash M R (1): ARM: AM43xx: hwmod: add DSS hwmod data Suman Anna (10): ARM: dts: OMAP2+: Add mailbox fifo and user information ARM: dts: OMAP4: Add mailbox node ARM: dts: AM33xx: Add mailbox node ARM: dts: AM4372: Correct mailbox node data ARM: dts: DRA7: Add mailbox nodes ARM: DRA7: hwmod_data: Add mailbox hwmod data ARM: OMAP2+: Avoid mailbox legacy device creation for DT-boot ARM: OMAP2: hwmod_data: Remove legacy mailbox data and addrs ARM: OMAP4: hwmod_data: Remove legacy mailbox addrs ARM: AM33xx: hwmod_data: Remove legacy mailbox addrs Tony Lindgren (2): Merge tag 'for-v3.17/omap-hwmod-a' of git://git.kernel.org/.../pjw/omap-pending into omap-for-v3.17/soc Merge branch 'omap-for-v3.17/mailbox' into omap-for-v3.17/soc arch/arm/boot/dts/am33xx.dtsi | 9 + arch/arm/boot/dts/am4372.dtsi | 3 - arch/arm/boot/dts/dra7.dtsi| 117 + arch/arm/boot/dts/omap2420.dtsi| 2 + arch/arm/boot/dts/omap2430.dtsi| 2 + arch/arm/boot/dts/omap3.dtsi | 2 + arch/arm/boot/dts/omap4.dtsi | 9 + arch/arm/boot/dts/omap5.dtsi | 2 + arch/arm/mach-omap2/Makefile | 1 + arch/arm/mach-omap2/cm2_7xx.h | 4 + arch/arm/mach-omap2/devices.c | 2 +- arch/arm/mach-omap2/dma.c | 3 + arch/arm/mach-omap2/omap_hwmod_2420_data.c | 14 - arch/arm/mach-omap2/omap_hwmod_2430_data.c | 13 - .../omap_hwmod_2xxx_3xxx_interconnect_data.c | 9 - .../mach-omap2/omap_hwmod_2xxx_3xxx_ipblock_data.c | 40 -- .../omap_hwmod_33xx_43xx_interconnect_data.c | 10 - arch/arm/mach-omap2/omap_hwmod_43xx_data.c | 100 arch/arm/mach-omap2/omap_hwmod_44xx_data.c | 10 - arch/arm/mach-omap2/omap_hwmod_7xx_data.c | 574 - arch/arm/mach-omap2/omap_hwmod_common_data.h | 1 - .../mach-omap2/omap_hwmod_common_ipblock_data.c| 55 ++ arch/arm/mach-omap2/prcm43xx.h | 1 + arch/arm/mach-omap2/prm7xx.h | 4 + arch/arm/plat-omap/dma.c | 5 +- include/linux/omap-dma.h | 1 + 26 files changed, 881 insertions(+), 112 deletions(-) create mode 100644 arch/arm/mach-omap2/omap_hwmod_common_ipblock_data.c -- To unsubscribe from this list: send the line unsubscribe linux-omap in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [GIT PULL] Few regression fixes for omaps for v3.16-rc series
On Thursday 24 July 2014 04:43:49 Tony Lindgren wrote: Two regression fixes for omaps and one fix for device signaling: - L2 cache regression fix for a warning about trying to access a read-only register - GPMC ECC software fallback regression fix for omap3 - Fix for dra7 pinctrl pull-up direction that causes signal issues for anybody trying to use the internal pull up or down Merged into the fixes branch, thanks! Arnd -- To unsubscribe from this list: send the line unsubscribe linux-omap in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 1/2] hwspinlock/omap: enable module before reading SYSSTATUS register
Hi Suman, On Thu, Jul 3, 2014 at 2:00 AM, Suman Anna s-a...@ti.com wrote: The number of hwspinlocks are determined based on the value read from the IP block's SYSSTATUS register. However, the module may not be enabled and clocked, and the read may result in a bus error. This particular issue is seen rather easily on AM33XX, since the module wakeup is software controlled, and it is disabled out of reset. Make sure the module is enabled and clocked before reading the SYSSTATUS register. Signed-off-by: Suman Anna s-a...@ti.com ... + /* +* runtime PM will make sure the clock of this module is +* enabled again iff at least one lock is requested +*/ + ret = pm_runtime_put_sync(pdev-dev); Is there a specific reason for using the put_sync variant here? If not, let's just use the regular put(). Let me know, and I can do the change while applying these two patches. Thanks, Ohad. -- To unsubscribe from this list: send the line unsubscribe linux-omap in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 1/2] hwspinlock/omap: enable module before reading SYSSTATUS register
Hi Ohad, On 07/24/2014 08:45 AM, Ohad Ben-Cohen wrote: Hi Suman, On Thu, Jul 3, 2014 at 2:00 AM, Suman Anna s-a...@ti.com wrote: The number of hwspinlocks are determined based on the value read from the IP block's SYSSTATUS register. However, the module may not be enabled and clocked, and the read may result in a bus error. This particular issue is seen rather easily on AM33XX, since the module wakeup is software controlled, and it is disabled out of reset. Make sure the module is enabled and clocked before reading the SYSSTATUS register. Signed-off-by: Suman Anna s-a...@ti.com ... + /* +* runtime PM will make sure the clock of this module is +* enabled again iff at least one lock is requested +*/ + ret = pm_runtime_put_sync(pdev-dev); Is there a specific reason for using the put_sync variant here? If not, let's just use the regular put(). There was no particular reason, you can change it. Let me know, and I can do the change while applying these two patches. Sure, thanks. regards Suman -- To unsubscribe from this list: send the line unsubscribe linux-omap in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 00/10 linux-next] drivers/usb: remove unnecessary break after goto/return
On 24 July 2014 at 13:37 Oliver Neukum oneu...@suse.de wrote: On Thu, 2014-07-24 at 10:18 +0200, Fabian Frederick wrote: Small patchset addressing break redundancy on drivers/usb branch (suggested by Joe Perches). Frankly, that is not a good idea. Somebody will remove a goto and forget to readd the break No problem ; checkpatch would give a warning anyway. See Possible switch case/default not preceeded by break or fallthrough comment Regards, Fabian Regards Oliver -- To unsubscribe from this list: send the line unsubscribe linux-omap in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 00/10 linux-next] drivers/usb: remove unnecessary break after goto/return
On Thu, 2014-07-24 at 17:46 +0200, Fabian Frederick wrote: On 24 July 2014 at 13:37 Oliver Neukum oneu...@suse.de wrote: On Thu, 2014-07-24 at 10:18 +0200, Fabian Frederick wrote: Small patchset addressing break redundancy on drivers/usb branch (suggested by Joe Perches). Frankly, that is not a good idea. Somebody will remove a goto and forget to readd the break No problem ; checkpatch would give a warning anyway. See Possible switch case/default not preceeded by break or fallthrough comment Generally true, but not everyone uses checkpatch. -- To unsubscribe from this list: send the line unsubscribe linux-omap in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
[PATCH] gpu: drm: omapdrm: Use %pad format for values of the dma_addr_t type
From: Matwey V. Kornilov mat...@sai.msu.ru
The format change is to fix the following compilation issue:
../drivers/gpu/drm/omapdrm/omap_plane.c: In function 'omap_plane_pre_apply':
../drivers/gpu/drm/omapdrm/omap_plane.c:145:2: error: format '%x' expects
argument of type 'unsigned int', but argument 5 has type 'dma_addr_t'
[-Werror=format=]
DBG(%d,%d %08x %08x, info-pos_x, info-pos_y,
^
../drivers/gpu/drm/omapdrm/omap_plane.c:145:2: error: format '%x' expects
argument of type 'unsigned int', but argument 6 has type 'dma_addr_t'
[-Werror=format=]
cc1: all warnings being treated as errors
../scripts/Makefile.build:273: recipe for target
'drivers/gpu/drm/omapdrm/omap_plane.o' failed
Signed-off-by: Matwey V. Kornilov mat...@sai.msu.ru
---
drivers/gpu/drm/omapdrm/omap_gem.c | 10 +-
drivers/gpu/drm/omapdrm/omap_plane.c | 4 ++--
2 files changed, 7 insertions(+), 7 deletions(-)
diff --git a/drivers/gpu/drm/omapdrm/omap_gem.c
b/drivers/gpu/drm/omapdrm/omap_gem.c
index 95dbce2..44305c6 100644
--- a/drivers/gpu/drm/omapdrm/omap_gem.c
+++ b/drivers/gpu/drm/omapdrm/omap_gem.c
@@ -791,7 +791,7 @@ int omap_gem_get_paddr(struct drm_gem_object *obj,
omap_obj-paddr = tiler_ssptr(block);
omap_obj-block = block;
- DBG(got paddr: %08x, omap_obj-paddr);
+ DBG(got paddr: %pad, (omap_obj-paddr));
}
omap_obj-paddr_cnt++;
@@ -985,9 +985,9 @@ void omap_gem_describe(struct drm_gem_object *obj, struct
seq_file *m)
off = drm_vma_node_start(obj-vma_node);
- seq_printf(m, %08x: %2d (%2d) %08llx %08Zx (%2d) %p %4d,
+ seq_printf(m, %08x: %2d (%2d) %08llx %pad (%2d) %p %4d,
omap_obj-flags, obj-name,
obj-refcount.refcount.counter,
- off, omap_obj-paddr, omap_obj-paddr_cnt,
+ off, (omap_obj-paddr), omap_obj-paddr_cnt,
omap_obj-vaddr, omap_obj-roll);
if (omap_obj-flags OMAP_BO_TILED) {
@@ -1467,8 +1467,8 @@ void omap_gem_init(struct drm_device *dev)
entry-paddr = tiler_ssptr(block);
entry-block = block;
- DBG(%d:%d: %dx%d: paddr=%08x stride=%d, i, j, w, h,
- entry-paddr,
+ DBG(%d:%d: %dx%d: paddr=%pad stride=%d, i, j, w, h,
+ (entry-paddr),
usergart[i].stride_pfn PAGE_SHIFT);
}
}
diff --git a/drivers/gpu/drm/omapdrm/omap_plane.c
b/drivers/gpu/drm/omapdrm/omap_plane.c
index 3cf31ee..aaa9a2c 100644
--- a/drivers/gpu/drm/omapdrm/omap_plane.c
+++ b/drivers/gpu/drm/omapdrm/omap_plane.c
@@ -142,8 +142,8 @@ static void omap_plane_pre_apply(struct omap_drm_apply
*apply)
DBG(%dx%d - %dx%d (%d), info-width, info-height,
info-out_width, info-out_height,
info-screen_width);
- DBG(%d,%d %08x %08x, info-pos_x, info-pos_y,
- info-paddr, info-p_uv_addr);
+ DBG(%d,%d %pad %pad, info-pos_x, info-pos_y,
+ (info-paddr), (info-p_uv_addr));
/* TODO: */
ilace = false;
--
1.8.1.4
--
To unsubscribe from this list: send the line unsubscribe linux-omap in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH] gpu: drm: omapdrm: Use %pad format for values of the dma_addr_t type
On Thu, 2014-07-24 at 21:58 +0400, mat...@sai.msu.ru wrote: The format change is to fix the following compilation issue: Just a trivial note: diff --git a/drivers/gpu/drm/omapdrm/omap_gem.c b/drivers/gpu/drm/omapdrm/omap_gem.c [] @@ -791,7 +791,7 @@ int omap_gem_get_paddr(struct drm_gem_object *obj, omap_obj-paddr = tiler_ssptr(block); omap_obj-block = block; - DBG(got paddr: %08x, omap_obj-paddr); + DBG(got paddr: %pad, (omap_obj-paddr)); foo-bar does not need parentheses. Most uses in the kernel do not have them. It seems to be ~25:1 without to with. @@ -985,9 +985,9 @@ void omap_gem_describe(struct drm_gem_object *obj, struct seq_file *m) off = drm_vma_node_start(obj-vma_node); - seq_printf(m, %08x: %2d (%2d) %08llx %08Zx (%2d) %p %4d, + seq_printf(m, %08x: %2d (%2d) %08llx %pad (%2d) %p %4d, omap_obj-flags, obj-name, obj-refcount.refcount.counter, - off, omap_obj-paddr, omap_obj-paddr_cnt, + off, (omap_obj-paddr), omap_obj-paddr_cnt, etc... -- To unsubscribe from this list: send the line unsubscribe linux-omap in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: Nokia N900 FB regression?
Hi, On Wed, Jul 23, 2014 at 12:37:06AM -0700, Tony Lindgren wrote: * Aaro Koskinen aaro.koski...@iki.fi [140722 14:25]: Hi, Somewhere between 3.16-rc2 and rc6 (I was on holidays...) I noticed the framebuffer stopped working on N900 (nothing on screen). I bisected this to 913fd66e9809e93e06d5bbd49cf99a6cdbee (ARM: dts: Enable twl4030 off-idle configuration for selected omaps). With this commit reverted, I can see the Tux again with 3.16-rc6. Any ideas? Hmm, OK yeah that enables the deeper idle states. I have tested this on n900, but only have remote access to it so could not see the framebuffer. Sounds like there's some twl regulator that we cannot idle by default on n900. Here are the steps to narrow it down: 1. Try ti,twl4030-power-idle in omap3-n900.dts instead of ti,twl4030-power-idle-osc-off. This probably won't help unless you're enabling off-idle though, so if it does not help, just keep on using ti,twl4030-power-idle-osc-off. 2. Try commenting out one or more of the TWL_REMAP_SLEEP or TWL_REMAP_OFF lines in omap3_idle_rconfig in file drivers/mfd/twl4030-power.c. That's the recommended init sequence like the comments in the code mention. Chances are we're missing a regulator_get somewhere but finding out which one in omap3_idle_rconfig will help narrow it down :) It's VAUX1 - commenting that out alone fixes the issue. But I think we are defining that one properly in the DTS (vdds_sdi-supply = vaux1), and also I checked that sdi_init_regulator() succeeds... BTW, this issue can be also detected without seeing the framebuffer, from dmesg: # dmesg|grep omapfb [2.785705] omapfb omapfb: no displays [2.786041] omapfb omapfb: failed to setup omapfb [2.786102] platform omapfb: Driver omapfb requests probe deferral [4.038055] acx565akm spi1.2: omapfb: acx565akm rev ab LCD detected [5.421325] omapfb omapfb: Failed to enable display 'lcd' [5.431335] omapfb omapfb: failed to initialize default display [5.450408] omapfb omapfb: failed to setup omapfb [5.455444] omapfb: probe of omapfb failed with error -1 A. -- To unsubscribe from this list: send the line unsubscribe linux-omap in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
