Re: [PATCH v13 3/6] clk: Make clk API return per-user struct clk instances

2015-02-02 Thread Tony Lindgren
* Tero Kristo t-kri...@ti.com [150202 11:35]: On 02/01/2015 11:24 PM, Mike Turquette wrote: Quoting Tomeu Vizoso (2015-01-23 03:03:30) AFAICT this doesn't break anything, but booting on OMAP3+ results in noisy WARNs. I think the correct fix is to replace clk_bypass and clk_ref pointers

Re: [PATCH v7 1/4] Documentation: dt: add common bindings for hwspinlock

2015-02-02 Thread Suman Anna
On 02/01/2015 11:55 AM, Bjorn Andersson wrote: On Fri, Jan 30, 2015 at 9:41 PM, Ohad Ben-Cohen o...@wizery.com wrote: On Sat, Jan 31, 2015 at 1:29 AM, Bjorn Andersson bj...@kryo.se wrote: In a system where you have two hwlock blocks lckA and lckB, each consisting of 8 locks and you have dspB

Re: v3.19: Nokia N900 - usb nokia gadget crash

2015-02-02 Thread Felipe Balbi
On Mon, Feb 02, 2015 at 04:17:13PM -0600, Felipe Balbi wrote: On Sat, Jan 31, 2015 at 10:25:09AM +0100, Pali Rohár wrote: On Saturday 31 January 2015 10:06:11 Pali Rohár wrote: Hello, when I try to modprobe g_nokia.ko gadget module on n900 device, it produce tons on lines to

Re: v3.19: Nokia N900 - usb nokia gadget crash

2015-02-02 Thread Felipe Balbi
On Sat, Jan 31, 2015 at 10:25:09AM +0100, Pali Rohár wrote: On Saturday 31 January 2015 10:06:11 Pali Rohár wrote: Hello, when I try to modprobe g_nokia.ko gadget module on n900 device, it produce tons on lines to display and then crash and reboot device. So its not working and I

Re: [PATCH v13 3/6] clk: Make clk API return per-user struct clk instances

2015-02-02 Thread Stephen Boyd
On 02/01/15 13:24, Mike Turquette wrote: Quoting Tomeu Vizoso (2015-01-23 03:03:30) Moves clock state to struct clk_core, but takes care to change as little API as possible. struct clk_hw still has a pointer to a struct clk, which is the implementation's per-user clk instance, for

Re: [PATCH v13 3/6] clk: Make clk API return per-user struct clk instances

2015-02-02 Thread Julia Lawall
On Mon, 2 Feb 2015, Stephen Boyd wrote: On 02/01/15 13:24, Mike Turquette wrote: Quoting Tomeu Vizoso (2015-01-23 03:03:30) Moves clock state to struct clk_core, but takes care to change as little API as possible. struct clk_hw still has a pointer to a struct clk, which is the

Re: [PATCH v7 1/4] Documentation: dt: add common bindings for hwspinlock

2015-02-02 Thread Suman Anna
On 02/01/2015 05:00 AM, Ohad Ben-Cohen wrote: On Sat, Jan 31, 2015 at 7:41 AM, Ohad Ben-Cohen o...@wizery.com wrote: On Sat, Jan 31, 2015 at 1:29 AM, Bjorn Andersson bj...@kryo.se wrote: In a system where you have two hwlock blocks lckA and lckB, each consisting of 8 locks and you have dspB

Re: [PATCH v4 1/1] extcon: usb-gpio: Introduce gpio usb extcon driver

2015-02-02 Thread Chanwoo Choi
Hi Roger, Looks good to me. Applied it on v3.21 queue. Thanks, Chanwoo Choi On 02/02/2015 07:21 PM, Roger Quadros wrote: This driver observes the USB ID pin connected over a GPIO and updates the USB cable extcon states accordingly. The existing GPIO extcon driver is not suitable for this

Re: [PATCH v13 3/6] clk: Make clk API return per-user struct clk instances

2015-02-02 Thread Tony Lindgren
* Mike Turquette mturque...@linaro.org [150202 14:51]: Quoting Tony Lindgren (2015-02-02 12:44:02) Thanks Tero, looks like your fix fixes all the issues I'm seeing with commit 59cf3fcf9baf. That is noisy dmesg, dpll_abe_ck not locking on 4430sdp, and off-idle not working for omap3.

Re: v3.19: Nokia N900 - usb nokia gadget crash

2015-02-02 Thread Felipe Balbi
On Mon, Feb 02, 2015 at 11:47:26PM +0100, Pali Rohár wrote: On Monday 02 February 2015 23:27:27 Felipe Balbi wrote: On Mon, Feb 02, 2015 at 04:17:13PM -0600, Felipe Balbi wrote: On Sat, Jan 31, 2015 at 10:25:09AM +0100, Pali Rohár wrote: On Saturday 31 January 2015 10:06:11 Pali Rohár

Re: [PATCH] watchdog: Fix omap watchdogs to enable the magic close bit

2015-02-02 Thread Tony Lindgren
* Wim Van Sebroeck w...@iguana.be [150202 15:44]: Hi Tony, * Tony Lindgren t...@atomide.com [141014 12:27]: This allows testing the watchdog easily with distros just by doing pkill -9 watchdog. Reported-by: Thomas Dziedzic gos...@gmail.com Signed-off-by: Tony Lindgren

Re: [PATCH v13 3/6] clk: Make clk API return per-user struct clk instances

2015-02-02 Thread Stephen Boyd
On 02/02/15 14:41, Mike Turquette wrote: Quoting Tero Kristo (2015-02-02 11:32:01) On 02/01/2015 11:24 PM, Mike Turquette wrote: AFAICT this doesn't break anything, but booting on OMAP3+ results in noisy WARNs. I think the correct fix is to replace clk_bypass and clk_ref pointers with a

Re: v3.19: Nokia N900 - usb nokia gadget crash

2015-02-02 Thread Pali Rohár
On Monday 02 February 2015 23:27:27 Felipe Balbi wrote: On Mon, Feb 02, 2015 at 04:17:13PM -0600, Felipe Balbi wrote: On Sat, Jan 31, 2015 at 10:25:09AM +0100, Pali Rohár wrote: On Saturday 31 January 2015 10:06:11 Pali Rohár wrote: Hello, when I try to modprobe g_nokia.ko

Re: [PATCH v13 3/6] clk: Make clk API return per-user struct clk instances

2015-02-02 Thread Mike Turquette
Quoting Tero Kristo (2015-02-02 11:32:01) On 02/01/2015 11:24 PM, Mike Turquette wrote: Quoting Tomeu Vizoso (2015-01-23 03:03:30) Moves clock state to struct clk_core, but takes care to change as little API as possible. struct clk_hw still has a pointer to a struct clk, which is the

Re: [PATCH v13 3/6] clk: Make clk API return per-user struct clk instances

2015-02-02 Thread Mike Turquette
Quoting Tony Lindgren (2015-02-02 12:44:02) * Tero Kristo t-kri...@ti.com [150202 11:35]: On 02/01/2015 11:24 PM, Mike Turquette wrote: Quoting Tomeu Vizoso (2015-01-23 03:03:30) AFAICT this doesn't break anything, but booting on OMAP3+ results in noisy WARNs. I think the correct

Re: [PATCH] watchdog: Fix omap watchdogs to enable the magic close bit

2015-02-02 Thread Wim Van Sebroeck
Hi Tony, * Tony Lindgren t...@atomide.com [141014 12:27]: This allows testing the watchdog easily with distros just by doing pkill -9 watchdog. Reported-by: Thomas Dziedzic gos...@gmail.com Signed-off-by: Tony Lindgren t...@atomide.com Wim, still not seeing this applied, did you

Re: [PATCH v13 3/6] clk: Make clk API return per-user struct clk instances

2015-02-02 Thread Stephen Boyd
On 02/02/15 13:31, Julia Lawall wrote: On Mon, 2 Feb 2015, Stephen Boyd wrote: Julia, Is there a way we can write a coccinelle script to check for this? The goal being to find all drivers that are comparing struct clk pointers or attempting to dereference them. There are probably other

Re: [PATCH v13 3/6] clk: Make clk API return per-user struct clk instances

2015-02-02 Thread Mike Turquette
Quoting Stephen Boyd (2015-02-02 14:35:59) On 02/02/15 13:31, Julia Lawall wrote: On Mon, 2 Feb 2015, Stephen Boyd wrote: Julia, Is there a way we can write a coccinelle script to check for this? The goal being to find all drivers that are comparing struct clk pointers or

Re: N900 v3.19-rc5 arm atags_to_fdt.c is broken

2015-02-02 Thread Nicolas Pitre
On Mon, 2 Feb 2015, Pavel Machek wrote: On Tue 2015-01-27 10:16:24, Nicolas Pitre wrote: On Tue, 27 Jan 2015, Pavel Machek wrote: I would say, problem is because omap3-n900 binary DT is too large I agree. OK if that's the case, then your patch makes sense to me.

Re: [PATCH v2 2/7] usb: extcon: Fix USB-Host cable name

2015-02-02 Thread Chanwoo Choi
Hi Roger, On 02/02/2015 06:09 PM, Roger Quadros wrote: Chanwoo, On 02/02/15 07:04, Chanwoo Choi wrote: Hi Roger, On 01/30/2015 11:05 PM, Roger Quadros wrote: Hi, On 30/01/15 13:04, Roger Quadros wrote: Felipe Chanwoo, On 26/01/15 14:15, Roger Quadros wrote: The recommended name for

Re: N900 v3.19-rc5 arm atags_to_fdt.c is broken

2015-02-02 Thread Pavel Machek
On Tue 2015-01-27 10:16:24, Nicolas Pitre wrote: On Tue, 27 Jan 2015, Pavel Machek wrote: I would say, problem is because omap3-n900 binary DT is too large I agree. OK if that's the case, then your patch makes sense to me. It also seems we can have the temporary stack

Re: [PATCH v2 2/7] usb: extcon: Fix USB-Host cable name

2015-02-02 Thread Chanwoo Choi
On 02/02/2015 07:01 PM, Roger Quadros wrote: On 02/02/15 11:55, Chanwoo Choi wrote: Hi Roger, On 02/02/2015 06:09 PM, Roger Quadros wrote: Chanwoo, On 02/02/15 07:04, Chanwoo Choi wrote: Hi Roger, On 01/30/2015 11:05 PM, Roger Quadros wrote: Hi, On 30/01/15 13:04, Roger Quadros wrote:

[PATCH v4 1/1] extcon: usb-gpio: Introduce gpio usb extcon driver

2015-02-02 Thread Roger Quadros
This driver observes the USB ID pin connected over a GPIO and updates the USB cable extcon states accordingly. The existing GPIO extcon driver is not suitable for this purpose as it needs to be taught to understand USB cable states and it can't handle more than one cable per instance. For the

Re: [PATCH v2 2/7] usb: extcon: Fix USB-Host cable name

2015-02-02 Thread Roger Quadros
On 02/02/15 11:55, Chanwoo Choi wrote: Hi Roger, On 02/02/2015 06:09 PM, Roger Quadros wrote: Chanwoo, On 02/02/15 07:04, Chanwoo Choi wrote: Hi Roger, On 01/30/2015 11:05 PM, Roger Quadros wrote: Hi, On 30/01/15 13:04, Roger Quadros wrote: Felipe Chanwoo, On 26/01/15 14:15, Roger

Re: [PATCH 4/4] ARM: dts: Add minimal support for dm8168-evm

2015-02-02 Thread Matthijs van Duin
On 2 February 2015 at 18:44, Tony Lindgren t...@atomide.com wrote: * Matthijs van Duin matthijsvand...@gmail.com [150128 13:46]: On 26 January 2015 at 16:58, Tony Lindgren t...@atomide.com wrote: I'm pretty sure I verified the that the audio_pll_clk1 is hardwwired to 32KiHz by looking at it

[PATCH v2] ASoC: tlv320aic3x: Add support for tlv320aic3104

2015-02-02 Thread Jyri Sarha
Disables GPIO support and LINE2 input and renames Mic3 input to Mic2, if tlv320aic3104 mode is seleced. Devicetree binding document is updated accordingly. Signed-off-by: Jyri Sarha jsa...@ti.com --- Changes since the first version of the patch - Added ti,tlv320aic3104 to tlv320aic3x_of_match

Re: [PATCH v13 3/6] clk: Make clk API return per-user struct clk instances

2015-02-02 Thread Tomeu Vizoso
On 02/02/2015 11:41 PM, Mike Turquette wrote: Quoting Tero Kristo (2015-02-02 11:32:01) On 02/01/2015 11:24 PM, Mike Turquette wrote: Quoting Tomeu Vizoso (2015-01-23 03:03:30) Moves clock state to struct clk_core, but takes care to change as little API as possible. struct clk_hw still

Re: [PATCH v13 4/6] clk: Add rate constraints to clocks

2015-02-02 Thread Tony Lindgren
on OMAPs, and hopefully does the same for SH Mobile and others. I've squashed this into Tomeu's rate constraints patch to maintain bisect. Yes, it fixes shmobile. .round_rate() is now called with a sane value of rate. Looks like next-20150202 now produces tons of the following errors, these from

Re: Clock Regression in next-20150130 caused by cb75a8fcd14e

2015-02-02 Thread Tony Lindgren
* Mike Turquette mturque...@linaro.org [150201 15:29]: Quoting Tony Lindgren (2015-01-30 17:04:44) Hi all, Looks like commit cb75a8fcd14e (clk: Add rate constraints to clocks) causes a regression on at least omaps where the serial console either does not show anything, or just prints

Re: [PATCH 4/4] ARM: dts: Add minimal support for dm8168-evm

2015-02-02 Thread Tony Lindgren
* Matthijs van Duin matthijsvand...@gmail.com [150131 17:54]: I just noticed the dm816x.dtsi says: ocp { compatible = ti,omap3-l3-smx, simple-bus; This is incorrect: the DM81xx (and siblings like the AM335x) use Arteris FlexNOC for the L3 interconnect, same as omap4/5 and vayu,

Re: [PATCH 2/3] ARM: OMAP2+: gpmc: make gpmc_cs_get_name() static

2015-02-02 Thread Tony Lindgren
* Roger Quadros rog...@ti.com [150126 01:23]: On 24/01/15 22:28, Semen Protsenko wrote: Fix sparse warning: warning: symbol 'gpmc_cs_get_name' was not declared. Should it be static? Signed-off-by: Semen Protsenko semen.protse...@globallogic.com Acked-by: Roger Quadros rog...@ti.com

Re: [PATCH v13 4/6] clk: Add rate constraints to clocks

2015-02-02 Thread Tony Lindgren
/0x34() [ 10.568237] Modules linked in: [ 10.568237] CPU: 0 PID: 1 Comm: swapper/0 Tainted: GW 3.19.0-rc6-next-20150202 #2037 [ 10.568237] Hardware name: Generic OMAP4 (Flattened Device Tree) [ 10.568267] [c0015bdc] (unwind_backtrace) from [c001222c

Re: [PATCH v13 3/6] clk: Make clk API return per-user struct clk instances

2015-02-02 Thread Tony Lindgren
* Mike Turquette mturque...@linaro.org [150201 13:27]: Quoting Tomeu Vizoso (2015-01-23 03:03:30) Moves clock state to struct clk_core, but takes care to change as little API as possible. struct clk_hw still has a pointer to a struct clk, which is the implementation's per-user clk

Re: [PATCH 1/3] ARM: OMAP2+: gpmc: Fix writing in gpmc_cs_set_memconf

2015-02-02 Thread Tony Lindgren
* Roger Quadros rog...@ti.com [150126 01:38]: On 24/01/15 22:28, Semen Protsenko wrote: Some GPMC_CONFIG7 register bits marked as RESERVED, means they shouldn't be overwritten. A typical approach to handle such bits called Read-Modify-Write. Writing procedure used in gpmc_cs_set_memconf()

Re: [PATCH v13 4/6] clk: Add rate constraints to clocks

2015-02-02 Thread Mike Turquette
with a sane value of rate. Looks like next-20150202 now produces tons of the following errors, these from omap4: next-20150202 is the rolled-back changes from last Friday. I removed the clock constraints patch and in doing so also rolled back the TI clock driver migration and clk-private.h

Re: [PATCH 4/4] ARM: dts: Add minimal support for dm8168-evm

2015-02-02 Thread Tony Lindgren
* Matthijs van Duin matthijsvand...@gmail.com [150128 13:46]: On 26 January 2015 at 16:58, Tony Lindgren t...@atomide.com wrote: See earlier I was assuming copy paste issues from dm814x to dm816x Ahh, you thought the 816x was 814x-derived... yes I can imagine that will have led to some

Re: [PATCH v13 4/6] clk: Add rate constraints to clocks

2015-02-02 Thread Russell King - ARM Linux
On Mon, Feb 02, 2015 at 09:46:46AM -0800, Mike Turquette wrote: This looks like mis-matched enable/disable calls. We now have unique struct clk pointers for every call to clk_get. I haven't yet looked through the hwmod code but I have a feeling that we're doing something like this: /*

Re: [PATCH v13 4/6] clk: Add rate constraints to clocks

2015-02-02 Thread Tony Lindgren
in: [ 10.568237] CPU: 0 PID: 1 Comm: swapper/0 Tainted: GW 3.19.0-rc6-next-20150202 #2037 [ 10.568237] Hardware name: Generic OMAP4 (Flattened Device Tree) [ 10.568267] [c0015bdc] (unwind_backtrace) from [c001222c] (show_stack+0x10/0x14) [ 10.568267] [c001222c] (show_stack) from

Re: [PATCH v13 3/6] clk: Make clk API return per-user struct clk instances

2015-02-02 Thread Tero Kristo
On 02/01/2015 11:24 PM, Mike Turquette wrote: Quoting Tomeu Vizoso (2015-01-23 03:03:30) Moves clock state to struct clk_core, but takes care to change as little API as possible. struct clk_hw still has a pointer to a struct clk, which is the implementation's per-user clk instance, for

Re: [PATCH v13 4/6] clk: Add rate constraints to clocks

2015-02-02 Thread Geert Uytterhoeven
On Sun, Feb 1, 2015 at 11:18 PM, Mike Turquette mturque...@linaro.org wrote: Quoting Tomeu Vizoso (2015-01-31 10:36:22) On 31 January 2015 at 02:31, Stephen Boyd sb...@codeaurora.org wrote: On 01/29, Stephen Boyd wrote: On 01/29/15 05:31, Geert Uytterhoeven wrote: Hi Tomeu, Mike, On

Re: [PATCH v2 2/7] usb: extcon: Fix USB-Host cable name

2015-02-02 Thread Roger Quadros
Chanwoo, On 02/02/15 07:04, Chanwoo Choi wrote: Hi Roger, On 01/30/2015 11:05 PM, Roger Quadros wrote: Hi, On 30/01/15 13:04, Roger Quadros wrote: Felipe Chanwoo, On 26/01/15 14:15, Roger Quadros wrote: The recommended name for USB-Host cable state is USB-Host and not USB-HOST as per