Re: [PATCH v2] OMAPDSS: HACK: Ensure DSS clock domain gets out of idle when HDMI is enabled

2012-02-14 Thread Archit Taneja
Hi, On Tuesday 14 February 2012 06:45 PM, Tomi Valkeinen wrote: On Tue, 2012-02-14 at 13:58 +0100, Cousson, Benoit wrote: Hi Tomi, Benoit, do you think we'll get the MODULEMODE mess cleaned up in the hwmod/clk framework at some point, and the drivers could do without these kinds of hacks?

Re: [PATCH v2] OMAPDSS: HACK: Ensure DSS clock domain gets out of idle when HDMI is enabled

2012-02-14 Thread Archit Taneja
On Tuesday 14 February 2012 07:03 PM, Tomi Valkeinen wrote: On Tue, 2012-02-14 at 19:00 +0530, Archit Taneja wrote: Hi, On Tuesday 14 February 2012 06:45 PM, Tomi Valkeinen wrote: On Tue, 2012-02-14 at 13:58 +0100, Cousson, Benoit wrote: Hi Tomi, Benoit, do you think we'll get

Re: [PATCH v2] OMAPDSS: HACK: Ensure DSS clock domain gets out of idle when HDMI is enabled

2012-02-14 Thread Archit Taneja
On Tuesday 14 February 2012 10:29 PM, Shilimkar, Santosh wrote: On Tue, Feb 14, 2012 at 9:32 PM, Cousson, Benoitb-cous...@ti.com wrote: On 2/14/2012 2:45 PM, Archit Taneja wrote: On Tuesday 14 February 2012 07:03 PM, Tomi Valkeinen wrote: On Tue, 2012-02-14 at 19:00 +0530, Archit Taneja

Re: [PATCH] OMAPDSS: HACK: Ensure DSS clock domain gets out of idle when HDMI is enabled

2012-02-09 Thread Archit Taneja
On Thursday 09 February 2012 05:32 PM, Tomi Valkeinen wrote: Hi, On Thu, 2012-02-09 at 12:14 +0530, Archit Taneja wrote: For DSS clock domain to transition from idle to active state, it's necessary to enable the optional clock DSS_FCLK before we enable the module using the MODULEMODE bits

[PATCH v2] OMAPDSS: HACK: Ensure DSS clock domain gets out of idle when HDMI is enabled

2012-02-09 Thread Archit Taneja
of HDMI not working when it's the default display. The issue is not seen if any other display is already enabled as the first display would have correctly enabled the DSS clockdomain. Signed-off-by: Archit Taneja arc...@ti.com --- Changes in v2: - Rewrite an unclear paragraph in the commit message - Add

Re: OMAP34xx

2012-02-09 Thread Archit Taneja
On Friday 10 February 2012 04:04 AM, Russell King - ARM Linux wrote: On Thu, Feb 09, 2012 at 12:22:42PM +0530, Archit Taneja wrote: Hi, On Sunday 05 February 2012 08:08 PM, Russell King - ARM Linux wrote: Okay, so this requires backlight support, and TAAL selected, so that sorts that error

[PATCH] OMAPDSS: HACK: Ensure DSS clock domain gets out of idle when HDMI is enabled

2012-02-08 Thread Archit Taneja
it's the default display. The issue is not seen if any other display is already enabled as the first display would have already correctly enabled the DSS clock domain. Signed-off-by: Archit Taneja arc...@ti.com --- drivers/video/omap2/dss/hdmi.c | 16 +++- 1 files changed, 15 insertions

Re: OMAP34xx

2012-02-08 Thread Archit Taneja
Hi, On Sunday 05 February 2012 08:08 PM, Russell King - ARM Linux wrote: On Sun, Feb 05, 2012 at 12:56:26PM +, Russell King - ARM Linux wrote: And here's another (set of) problem(s) on the 4430SDP board once the previous have been worked around: omap_hwmod: l3_div_ck: missing clockdomain

Re: [PATCH 1/2] OMAPDSS: Features: Maintain dss_feats as a list

2012-02-06 Thread Archit Taneja
On Monday 06 February 2012 04:12 PM, Tomi Valkeinen wrote: Hi, On Mon, 2012-01-30 at 10:52 +0530, Archit Taneja wrote: The number of dss_feat_id members has increased to a large value, the current way of assigning a subset of these features (for a particular OMAP) as a mask is no longer

Re: [PATCH 1/2] OMAPDSS: Features: Maintain dss_feats as a list

2012-02-06 Thread Archit Taneja
On Monday 06 February 2012 04:58 PM, Tomi Valkeinen wrote: On Mon, 2012-02-06 at 16:54 +0530, Archit Taneja wrote: On Monday 06 February 2012 04:12 PM, Tomi Valkeinen wrote: Hi, On Mon, 2012-01-30 at 10:52 +0530, Archit Taneja wrote: The number of dss_feat_id members has increased to a large

Re: [DSS2] kernel freeze with panel driver

2012-01-31 Thread Archit Taneja
Hi, On Tuesday 31 January 2012 04:26 PM, Patrick wrote: Dear mailing-list, I am working with a vanilla 3.0.17 kernel with some patch for my Omap4430 based board. I am using the driver video/omap2/panel-lgphilips-lb025q02.c with a very similar screen. I have added on my board init file the

[PATCH 1/2] OMAPDSS: Features: Maintain dss_feats as a list

2012-01-29 Thread Archit Taneja
. Signed-off-by: Archit Taneja arc...@ti.com --- drivers/video/omap2/dss/dss_features.c | 140 +++- drivers/video/omap2/dss/dss_features.h | 54 ++-- 2 files changed, 128 insertions(+), 66 deletions(-) diff --git a/drivers/video/omap2/dss/dss_features.c b

[PATCH 2/2] OMAPDSS: DISPC: Fix scaling constraints for OMAP4

2012-01-29 Thread Archit Taneja
(). Signed-off-by: Archit Taneja arc...@ti.com --- drivers/video/omap2/dss/dispc.c | 12 1 files changed, 8 insertions(+), 4 deletions(-) diff --git a/drivers/video/omap2/dss/dispc.c b/drivers/video/omap2/dss/dispc.c index 3deb982..14b1f54 100644 --- a/drivers/video/omap2/dss/dispc.c

Re: [PATCH V2] OMAP3: hwmod_data: register dss hwmods after dss_core

2011-12-30 Thread Archit Taneja
Hi, On Wednesday 28 December 2011 05:01 AM, Ilya Yanok wrote: dss_core has to be initialized before any other DSS hwmod. Currently this is broken as dss_core is listed in chip/revision specific hwmod lists while other DSS hwmods are listed in common list which is registered first. This patch

[RFC PATCH 22/29] OMAPDSS: DISPC: Setup writeback go, enable and channel_in functions

2011-12-27 Thread Archit Taneja
dispc_wb_enable() as dispc_enable_lcd_out() function and wait for the FRAMEDONEWB interrupt while disabling writeback. Signed-off-by: Archit Taneja arc...@ti.com --- drivers/video/omap2/dss/apply.c |2 +- drivers/video/omap2/dss/dispc.c | 68 +++ drivers/video

[RFC PATCH 20/29] OMAPDSS: Writeback: Add writeback capabilities

2011-12-27 Thread Archit Taneja
Add a capabilities parameter of type omap_overlay_caps to omap_dss_writeback. These caps let us reuse some of the DISPC overlay functions. Set the capabilities so the writeback supports scaling and pre multiplied alpha. Signed-off-by: Archit Taneja arc...@ti.com --- drivers/video/omap2/dss

[RFC PATCH 00/29] OMAPDSS: Initial Writeback Capture mode support

2011-12-27 Thread Archit Taneja
://gitorious.org/linux-omap-dss2/linux.git master Tested on a OMAP4 based blaze tablet. Note that this isn't tested thoroughly for all possible writeback configurations, the aim is to get comments on the design. Archit Taneja (29): omapdss/omapfb/omap_vout: Introduce manager output struct OMAPDSS: Add

[RFC PATCH 21/29] OMAPDSS: DISPC: Configure overlay-like parameters in dispc_wb_setup

2011-12-27 Thread Archit Taneja
of the manager to which the writeback pipeline is connected. The parameters in dispc_plane_setup() which do not hold for writeback are filled passed as zeroes or false, dispc_plane_setup() takes care of not configuring them if the plane is writeback. Signed-off-by: Archit Taneja arc...@ti.com --- drivers

[RFC PATCH 10/29] OMAPDSS: APPLY: Calculate channel_in for writeback

2011-12-27 Thread Archit Taneja
. Signed-off-by: Archit Taneja arc...@ti.com --- drivers/video/omap2/dss/apply.c | 59 +- drivers/video/omap2/dss/dispc.c |5 +++ drivers/video/omap2/dss/dss.h | 12 +++ drivers/video/omap2/dss/writeback.c | 15 + 4 files changed

[RFC PATCH 28/29] OMAPDSS: MANAGER: Add writeback as a sysfs attribute

2011-12-27 Thread Archit Taneja
Add writeback as a sysfs attribute. This can be used to show and store the dummy writeback panel that the manager can connect to. Add checks so that in the store functions so that a display store cant set a writeback device and vice versa. Signed-off-by: Archit Taneja arc...@ti.com --- drivers

[RFC PATCH 02/29] OMAPDSS: Add writeback to omap_dss_mgr_output

2011-12-27 Thread Archit Taneja
, and the writeback device in case of memory to memory mode. get_display() should be used when we are interested specifically in the connected display, the same holds for get_writeback(). Signed-off-by: Archit Taneja arc...@ti.com --- drivers/video/omap2/dss/manager.c | 19 +-- include

[RFC PATCH 01/29] omapdss/omapfb/omap_vout: Introduce manager output struct

2011-12-27 Thread Archit Taneja
. The omap_dss_device pointer connected to a manager is accessed by a omap_overlay or a omap_overlay_manager pointer by references like manager-device and ovl-manager-device. Replace such accesses by creating a helper function get_output() in the overlay_manager struct. Signed-off-by: Archit Taneja arc...@ti.com

[RFC PATCH 11/29] OMAPDSS: DISPC: Add writeback as a new plane

2011-12-27 Thread Archit Taneja
offsets in dispc.h, add minimal WB plane related info needed in dss_features. Add a new omap_dss_writeback parameter called plane_id, this represents the plane or pipeline number out of all the pipelines. Signed-off-by: Archit Taneja arc...@ti.com --- drivers/video/omap2/dss/dispc.h| 36

[RFC PATCH 07/29] OMAPDSS: APPLY: Add extra_info for writeback

2011-12-27 Thread Archit Taneja
. Signed-off-by: Archit Taneja arc...@ti.com --- drivers/video/omap2/dss/apply.c | 48 ++- 1 files changed, 47 insertions(+), 1 deletions(-) diff --git a/drivers/video/omap2/dss/apply.c b/drivers/video/omap2/dss/apply.c index 5263ae7..ff0baeb 100644 --- a/drivers

[RFC PATCH 27/29] OMAPDSS: MANAGER: Split manager_display_store into smaller functions

2011-12-27 Thread Archit Taneja
-by: Archit Taneja arc...@ti.com --- drivers/video/omap2/dss/manager.c | 46 ++-- 1 files changed, 38 insertions(+), 8 deletions(-) diff --git a/drivers/video/omap2/dss/manager.c b/drivers/video/omap2/dss/manager.c index f4fd3d8..fb7c1e6 100644 --- a/drivers/video

[RFC PATCH 24/29] OMAPDSS: Writeback: Use panel driver ops to configure mirroring rotation and buffer size

2011-12-27 Thread Archit Taneja
Add rotation and mirroring ops to writeback panel driver. Use these ops to get/set wb info. Signed-off-by: Archit Taneja arc...@ti.com --- drivers/video/omap2/dss/writeback.c | 79 +++ 1 files changed, 79 insertions(+), 0 deletions(-) diff --git a/drivers/video

[RFC PATCH 06/29] OMAPDSS: APPLY: Add writeback enable/disable functions

2011-12-27 Thread Archit Taneja
/disable ops. Signed-off-by: Archit Taneja arc...@ti.com --- drivers/video/omap2/dss/apply.c | 92 +- drivers/video/omap2/dss/dispc.c |5 ++ drivers/video/omap2/dss/dss.h |3 + drivers/video/omap2/dss/writeback.c | 12 - 4 files changed

[RFC PATCH 29/29] OMAPDSS: FEATURES: Allow WB panels to attach to managers

2011-12-27 Thread Archit Taneja
Add WB panel type in supported displays for all managers of OMAP4. A manager can now use set/unset ops on the dummy writeback panel. Signed-off-by: Archit Taneja arc...@ti.com --- drivers/video/omap2/dss/dss_features.c |6 -- 1 files changed, 4 insertions(+), 2 deletions(-) diff --git

[RFC PATCH 26/29] OMAPDSS: DISPLAY: Add a manager apply to sysfs store attributes for writeback

2011-12-27 Thread Archit Taneja
Writeback driver ops don't apply the writeback attribute changes, they just set the writeback info parameters. Add manager apply calls in sysfs store ops for timings, rotation and mirroring when its the writeback panel. Signed-off-by: Archit Taneja arc...@ti.com --- drivers/video/omap2/dss

[RFC PATCH 19/29] OMAPDSS: DISPC: Don't set chroma resampling bit for writeback

2011-12-27 Thread Archit Taneja
The bit YUVCHROMARESAMPLING isn't there for writeback in DISPC_WB_ATTRIBUTES2. Ignore this bit in dispc_ovl_set_scaling_uv() if the plane is OMAP_DSS_WB. Signed-off-by: Archit Taneja arc...@ti.com --- drivers/video/omap2/dss/dispc.c |9 ++--- 1 files changed, 6 insertions(+), 3 deletions

[RFC PATCH 17/29] OMAPDSS: DISPC: Make dispc_ovl_setup call dispc_plane_setup

2011-12-27 Thread Archit Taneja
Add a new static function called dispc_plane_setup(). This function is used by dispc_ovl_setup() to configure the overlay registers. This split is done so that dispc_wb_setup() can reuse the common overlay related registers configured in dispc_plane_setup(). Signed-off-by: Archit Taneja arc

[RFC PATCH 09/29] OMAPDSS: APPLY: Allow manager set/unset_device ops to set/unset writeback

2011-12-27 Thread Archit Taneja
Allow dss_mgr_set_device/unset_device to set/unset either display or writeback based on the dssdev argument passed to the function. Check if the device is a writeback device by seeing if the wbdev pointer is populated for it or not. Signed-off-by: Archit Taneja arc...@ti.com --- drivers/video

[RFC PATCH 04/29] OMAPDSS: APPLY/Writeback: Add writeback_info

2011-12-27 Thread Archit Taneja
sysfs attributes of the dummy writeback panel. Add get_wb_info/set_wb_info ops in omap_dss_writeback struct. Create a minimal wb_priv_data structure and a writeback simple_check function used for dss_wb_get_info and dss_wb_set_info functions in apply.c Signed-off-by: Archit Taneja arc...@ti.com

[RFC PATCH 25/29] OMAPDSS: Writeback: Add sysfs attributes to writeback panel

2011-12-27 Thread Archit Taneja
Add the following sysfs attributes to the writeback panel driver: - paddr - p_uv_addr - rotation_type - color_mode - pre_mult_alpha - capture_rate Signed-off-by: Archit Taneja arc...@ti.com --- drivers/video/omap2/dss/writeback.c | 210 +++ 1 files changed, 210

[RFC PATCH 14/29] OMAPDSS: DISPC: Allow both upscaling and downscaling of chroma

2011-12-27 Thread Archit Taneja
Make the function dispc_ovl_set_scaling_uv() take a boolean argument which tells if we want to upscale or downscale the chroma plane. Downscaling of chroma is required by writeback pipeline for converting the input YUV444 color format to YUV422 or NV12. Signed-off-by: Archit Taneja arc...@ti.com

[RFC PATCH 23/29] OMAPDSS: Writeback: Configure writeback specific parameters

2011-12-27 Thread Archit Taneja
(in lines) when the HW flushes writeback FIFOs and takes in new register configurations after the VSYNC is generated by the manager to which writeback is connected. Pass these parameters to dispc_wb_setup() so that they can be written in writeback registers. Signed-off-by: Archit Taneja arc

[RFC PATCH 15/29] OMAPDSS: DISPC: Pass overlay caps as a parameter to DISPC overlay related functions

2011-12-27 Thread Archit Taneja
() - dispc_ovl_calc_scaling() - dispc_ovl_setup() These functions will be used for writeback later, and the caps will help in deciding if they are to be used for writeback or not. This allows reuse of overlay caps for writeback. Signed-off-by: Archit Taneja arc...@ti.com --- drivers/video/omap2/dss

[RFC PATCH 08/29] OMAPDSS: APPLY: Modify manager unset device op

2011-12-27 Thread Archit Taneja
connected to a manager now, it will be used later to unset either the display or writeback device. Signed-off-by: Archit Taneja arc...@ti.com --- drivers/video/omap2/dss/apply.c |3 ++- drivers/video/omap2/dss/display.c |2 +- drivers/video/omap2/dss/dss.h |3 ++- drivers/video

[RFC PATCH 13/29] OMAPDSS: APPLY: Configure writeback FIFOs

2011-12-27 Thread Archit Taneja
Add writeback FIFO thresholds as extra_info parameters. Modify function dss_ovl_fifo_setup() so that it can also also configure writeback pipeline FIFOs. Extend the DISPC fifo functions to also configure the writeback registers. Signed-off-by: Archit Taneja arc...@ti.com --- drivers/video/omap2

[RFC PATCH 03/29] OMAPDSS: Writeback: Add writeback interface and panel driver

2011-12-27 Thread Archit Taneja
for the omap_dss_device pointer which represents writeback in omap_dss_mgr_output. Add a omap_dss_device pointer to the omap_dss_writeback struct, and a omap_dss_writeback pointer in omap_dss_device struct, link the writeback and dss_device together when the latter is added. Signed-off-by: Archit Taneja arc

[RFC PATCH 05/29] OMAPDSS: APPLY/Writeback: Apply writeback configurations

2011-12-27 Thread Archit Taneja
approximately WBDELAYCOUNT lines after we get the VSYNC interrupts. This is not done for now. Create dummy dispc_wb_go/go_busy and wb_setup functions. These will be filled up in a later commit. Signed-off-by: Archit Taneja arc...@ti.com --- drivers/video/omap2/dss/apply.c | 164

[RFC PATCH 16/29] OMAPDSS: OVERLAY: Add position and replication as overlay caps

2011-12-27 Thread Archit Taneja
Add position and replication as overlay caps. Pass overlay caps as an argument to the corresponding functions. These caps will be set for all overlays, but not for writeback. This is done so writeback can reuse dispc_ovl_setup() to the maximum. Signed-off-by: Archit Taneja arc...@ti.com

[RFC PATCH 18/29] OMAPDSS: DISPC: Make chroma_upscale an argument to dispc_plane_setup

2011-12-27 Thread Archit Taneja
Pass chroma_upscale boolean parameter to dispc_plane_setup(), this will be set to true when dispc_plane_setup() is called from dispc_ovl_setup() and false when called from dispc_wb_setup(). Signed-off-by: Archit Taneja arc...@ti.com --- drivers/video/omap2/dss/dispc.c | 12 ++-- 1

[RFC PATCH 12/29] OMAPDSS: Writeback: Add check for color_mode in dss_wb_simple_check()

2011-12-27 Thread Archit Taneja
Add a check for the color_mode parameter provided by the user in dss_wb_simple_check(). Signed-off-by: Archit Taneja arc...@ti.com --- drivers/video/omap2/dss/writeback.c |7 +++ 1 files changed, 7 insertions(+), 0 deletions(-) diff --git a/drivers/video/omap2/dss/writeback.c b/drivers

Re: Interesting L3 driver panic on v3.2-rc5 on 3530

2011-12-20 Thread Archit Taneja
Hi Ilya, On Tuesday 20 December 2011 06:09 AM, Ilya Yanok wrote: Hi Paul, Paul Walmsleypaulat pwsan.com writes: [0.238494] Kernel BUG at c0033e34 [verbose debug info unavailable] [0.245025] Internal error: Oops - undefined instruction: 0 [#1] SMP [0.262390] PC is at

Re: [PATCH 63/65] OMAPDSS: APPLY: add checking of ovls/mgrs settings

2011-12-13 Thread Archit Taneja
Hi, On Thursday 08 December 2011 01:59 PM, Tomi Valkeinen wrote: On Wed, 2011-12-07 at 18:35 +0530, Archit Taneja wrote: Hi, On Tuesday 22 November 2011 02:52 PM, Tomi Valkeinen wrote: Add checks for overlay and manager settings. The checks are a bit complex, as we need to observe the bigger

[PATCH 0/3] OMAPDSS: Miscellaneous Fixes

2011-12-11 Thread Archit Taneja
These are some minor fixes for DSS2. Based on Tomi's master branch in: git://gitorious.org/linux-omap-dss2/linux.git Archit Taneja (3): OMAPDSS: DSI: Fix HSDIV related PLL info in dsi_dump_clocks() OMAPDSS: Panel NEC: Set omap_dss_device states correctly OMAPDSS: Displays: Make PICODLP

[PATCH 1/3] OMAPDSS: DSI: Fix HSDIV related PLL info in dsi_dump_clocks()

2011-12-11 Thread Archit Taneja
and omap specific names for the DSI PLL's HSDIV clocks. Signed-off-by: Archit Taneja arc...@ti.com --- drivers/video/omap2/dss/dsi.c | 14 -- 1 files changed, 8 insertions(+), 6 deletions(-) diff --git a/drivers/video/omap2/dss/dsi.c b/drivers/video/omap2/dss/dsi.c index 4dc98b6

[PATCH 2/3] OMAPDSS: Panel NEC: Set omap_dss_device states correctly

2011-12-11 Thread Archit Taneja
The display state parameter of omap_dss_device struct is not being set correctly in the panel driver NEC panel driver panel-nec-nl8048hl11-01b.c. Set the correct states in the panel's enable/disable/suspend/resume functions. CC: Erik Gilling konk...@android.com Signed-off-by: Archit Taneja arc

[PATCH 3/3] OMAPDSS: Displays: Make PICODLP driver depend on DPI

2011-12-11 Thread Archit Taneja
Make PICODLP driver on OMAP2_DSS_DPI since it is the display interface it uses. Signed-off-by: Archit Taneja arc...@ti.com --- drivers/video/omap2/displays/Kconfig |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/video/omap2/displays/Kconfig b/drivers/video

Re: [PATCH 63/65] OMAPDSS: APPLY: add checking of ovls/mgrs settings

2011-12-07 Thread Archit Taneja
Hi, On Tuesday 22 November 2011 02:52 PM, Tomi Valkeinen wrote: Add checks for overlay and manager settings. The checks are a bit complex, as we need to observe the bigger picture instead of overlays and managers independently. Things like the used display and the zorder of other overlays

Re: [PATCH 58/65] OMAPDSS: APPLY: add wait_pending_extra_info_updates()

2011-12-07 Thread Archit Taneja
On Tuesday 22 November 2011 02:51 PM, Tomi Valkeinen wrote: Add wait_pending_extra_info_updates() function which can be used to wait until any extra_info changes have been taken into use by the hardware. This can be only called when holding the apply mutex, so that other threads cannot insert

Re: [PATCH 35/65] OMAPDSS: APPLY: move spinlock outside the struct

2011-11-23 Thread Archit Taneja
On Tuesday 22 November 2011 02:51 PM, Tomi Valkeinen wrote: dss_cache struct contains a spinlock used to protect the struct. A more logical place for the spinlock is outside the struct that it is protecting. So move it there. Signed-off-by: Tomi Valkeinentomi.valkei...@ti.com ---

Re: [PATCH 35/65] OMAPDSS: APPLY: move spinlock outside the struct

2011-11-23 Thread Archit Taneja
On Wednesday 23 November 2011 02:55 PM, Archit Taneja wrote: snip Minor comment: The name 'data_lock' doesn't tell much that its protecting the dss_cache struct. Probably 'cache_lock' or 'priv_data_lock' or something like that may be more informative. Archit Ah, just saw the next patch

Re: [PATCH 40/65] OMAPDSS: APPLY: add mutex

2011-11-23 Thread Archit Taneja
Hi, On Tuesday 22 November 2011 02:51 PM, Tomi Valkeinen wrote: The functions in apply.c, called mostly via function pointers in overlay and overlay_manager structs, will be divided into two groups. The other group will not sleep and can be called from interrupts, and the other group may sleep.

Re: [PATCH 41/65] OMAPDSS: APPLY: add missing uses of spinlock

2011-11-23 Thread Archit Taneja
On Tuesday 22 November 2011 02:51 PM, Tomi Valkeinen wrote: The functions in apply.c, called mostly via function pointers in overlay and overlay_manager structs, will be divided into two groups. The other group will not sleep and can be called from interrupts, and the other group may sleep. The

Re: [PATCH 42/65] OMAPDSS: DSI: call mgr_enable/disable for cmd mode displays

2011-11-23 Thread Archit Taneja
On Tuesday 22 November 2011 02:51 PM, Tomi Valkeinen wrote: The current code uses dsi_video_mode_enable/disable functions to enable/disable DISPC output for video mode displays. For command mode displays we have no notion in the DISPC side of whether the panel is enabled, except when a

Re: [PATCH 42/65] OMAPDSS: DSI: call mgr_enable/disable for cmd mode displays

2011-11-23 Thread Archit Taneja
On Wednesday 23 November 2011 04:12 PM, Tomi Valkeinen wrote: On Wed, 2011-11-23 at 15:40 +0530, Archit Taneja wrote: On Tuesday 22 November 2011 02:51 PM, Tomi Valkeinen wrote: The current code uses dsi_video_mode_enable/disable functions to enable/disable DISPC output for video mode displays

Re: [PATCH 42/65] OMAPDSS: DSI: call mgr_enable/disable for cmd mode displays

2011-11-23 Thread Archit Taneja
On Wednesday 23 November 2011 04:57 PM, Tomi Valkeinen wrote: On Wed, 2011-11-23 at 16:38 +0530, Archit Taneja wrote: I think it would be best to stuff the 'video mode enabling and manager enabling' functionality in omapdss_dsi_display_enable() itself, the panel driver shouldn't need to call

Re: [PATCH 06/65] OMAPDSS: remove partial update from the overlay manager

2011-11-22 Thread Archit Taneja
On Tuesday 22 November 2011 02:51 PM, Tomi Valkeinen wrote: Partial update for manual update displays has never worked quite well: * The HW has limitations on the update area, and the x and width need to be even. There are also some issues with partial update on OMAP4 even when 'x and

Re: [PATCH 08/65] OMAPDSS: remove partial update from panel-taal

2011-11-22 Thread Archit Taneja
On Tuesday 22 November 2011 02:51 PM, Tomi Valkeinen wrote: Partial update for manual update displays has never worked quite well: * The HW has limitations on the update area, and the x and width need to be even. * Showing a part of a scaled overlay causes artifacts. * Makes the management of

Re: [PATCH 08/65] OMAPDSS: remove partial update from panel-taal

2011-11-22 Thread Archit Taneja
On Tuesday 22 November 2011 06:02 PM, Tomi Valkeinen wrote: On Tue, 2011-11-22 at 17:23 +0530, Archit Taneja wrote: - r = taal_set_update_window(td, x, y, w, h); + /* XXX no need to send this every frame, but dsi break if not done */ + r = taal_set_update_window(td, 0, 0

Re: [PATCH 09/65] OMAPDSS: pass ovl manager to dss_start_update

2011-11-22 Thread Archit Taneja
On Tuesday 22 November 2011 02:51 PM, Tomi Valkeinen wrote: dss_start_update() takes currently the dss device as a parameter. Change the parameter to ovl manager, as that is what the dss_start_update() actually needs. Minor comment: We could rename dss_start_update() to dss_mgr_start_update()

Re: [PATCH 1/4] AM35xx: DSS: there is no VDDS_DSI on AM35xx

2011-11-09 Thread Archit Taneja
Hi, On Wednesday 09 November 2011 05:42 AM, Ilya Yanok wrote: AM35xx don't have VDDS_DSI regulator. AM35xx do have vdds_dsi regulator. Are you saying that your particular board doesn't have vdds_dsi connected to a regulator? I assumed that vdds_dsi regulator was required for DPI to

Re: [PATCH 1/4] AM35xx: DSS: there is no VDDS_DSI on AM35xx

2011-11-09 Thread Archit Taneja
Hi, On Wednesday 09 November 2011 11:56 PM, Ilya Yanok wrote: Hi Archit, 09.11.2011 14:10, Archit Taneja wrote: AM35xx don't have VDDS_DSI regulator. AM35xx do have vdds_dsi regulator. Are you saying that your particular board doesn't have vdds_dsi connected to a regulator? Yes, you

Re: [PATCH 20/30] media/omap_vout: disable driver for now

2011-10-03 Thread Archit Taneja
Hi Arnd, On Sunday 02 October 2011 08:15 PM, Arnd Bergmann wrote: This driver was broken by 8cff88c5d OMAP: DSS2: remove update_mode from omapdss: /home/arnd/linux-arm/drivers/media/video/omap/omap_vout.c: In function 'omap_vout_probe':

Re: [PATCH v2] OMAP2PLUS: DSS: Ensure DSS works correctly if display is enabled in bootloader

2011-10-02 Thread Archit Taneja
Hi Paul, On Monday 03 October 2011 10:15 AM, Paul Walmsley wrote: Hi some comments: On Mon, 12 Sep 2011, Archit Taneja wrote: Resetting DISPC when a DISPC output is enabled causes the DSS to go into an inconsistent state. Thus if the bootloader has enabled a display, the hwmod code cannot

[PATCH v4 0/5] OMAP_VOUT: Misc fixes and cleanup patches for 3.2

2011-09-28 Thread Archit Taneja
Archit Taneja (5): OMAP_VOUT: Fix check in reqbuf for buf_size allocation OMAP_VOUT: CLEANUP: Remove redundant code from omap_vout_isr OMAP_VOUT: Fix VSYNC IRQ handling in omap_vout_isr OMAP_VOUT: Add support for DSI panels OMAP_VOUT: Increase MAX_DISPLAYS to a larger value drivers/media

[PATCH v4 1/5] OMAP_VOUT: Fix check in reqbuf for buf_size allocation

2011-09-28 Thread Archit Taneja
. Signed-off-by: Archit Taneja arc...@ti.com --- drivers/media/video/omap/omap_vout.c |6 +- 1 files changed, 5 insertions(+), 1 deletions(-) diff --git a/drivers/media/video/omap/omap_vout.c b/drivers/media/video/omap/omap_vout.c index d9e64f3..e64a83c 100644 --- a/drivers/media/video/omap

[PATCH v4 3/5] OMAP_VOUT: Fix VSYNC IRQ handling in omap_vout_isr

2011-09-28 Thread Archit Taneja
is not sufficient to tell if we have received the correct irq, i.e, we shouldn't proceed ahead if we get a VSYNC interrupt for LCD2 manager, or a VSYNC2 interrupt for LCD manager. Fix this by correlating LCD manager to VSYNC interrupt and LCD2 manager to VSYNC2 interrupt. Signed-off-by: Archit Taneja arc

[PATCH v4 2/5] OMAP_VOUT: CLEANUP: Remove redundant code from omap_vout_isr

2011-09-28 Thread Archit Taneja
Currently, there is a lot of redundant code is between DPI and VENC panels, this can be made common by moving out field/interlace specific code to a separate function called omapvid_handle_interlace_display(). There is no functional change made. Signed-off-by: Archit Taneja arc...@ti.com

[PATCH v4 4/5] OMAP_VOUT: Add support for DSI panels

2011-09-28 Thread Archit Taneja
mode. Signed-off-by: Archit Taneja arc...@ti.com --- drivers/media/video/omap/omap_vout.c |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/drivers/media/video/omap/omap_vout.c b/drivers/media/video/omap/omap_vout.c index 6bc2620..65374b5 100644 --- a/drivers/media/video/omap

[PATCH v4 5/5] OMAP_VOUT: Increase MAX_DISPLAYS to a larger value

2011-09-28 Thread Archit Taneja
for more than 3 displays. Signed-off-by: Archit Taneja arc...@ti.com --- drivers/media/video/omap/omap_voutdef.h |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/media/video/omap/omap_voutdef.h b/drivers/media/video/omap/omap_voutdef.h index d793501..27a95d2 100644

Re: [PATCH 3/5] [media]: OMAP_VOUT: Fix VSYNC IRQ handling in omap_vout_isr

2011-09-27 Thread Archit Taneja
On Tuesday 27 September 2011 12:24 PM, Hiremath, Vaibhav wrote: -Original Message- From: Valkeinen, Tomi Sent: Tuesday, September 27, 2011 12:19 PM To: Hiremath, Vaibhav Cc: Semwal, Sumit; Taneja, Archit; linux-omap@vger.kernel.org; linux- me...@vger.kernel.org Subject: RE: [PATCH 3/5]

Re: [PATCH v3 4/4] OMAP_VOUT: Don't trigger updates in omap_vout_probe

2011-09-27 Thread Archit Taneja
On Tuesday 27 September 2011 11:40 AM, Valkeinen, Tomi wrote: On Mon, 2011-09-26 at 17:29 +0530, Archit Taneja wrote: Remove the code in omap_vout_probe() which calls display-driver-update() for all the displays. This isn't correct because: - An update in probe doesn't make sense, because we

Re: [PATCH v3 4/4] OMAP_VOUT: Don't trigger updates in omap_vout_probe

2011-09-27 Thread Archit Taneja
On Tuesday 27 September 2011 12:37 PM, Valkeinen, Tomi wrote: On Tue, 2011-09-27 at 12:32 +0530, Archit Taneja wrote: On Tuesday 27 September 2011 11:40 AM, Valkeinen, Tomi wrote: On Mon, 2011-09-26 at 17:29 +0530, Archit Taneja wrote: Remove the code in omap_vout_probe() which calls display

Re: [PATCH v3 1/4] OMAP_VOUT: Fix check in reqbuf for buf_size allocation

2011-09-27 Thread Archit Taneja
Hi, On Tuesday 27 September 2011 12:49 PM, Hiremath, Vaibhav wrote: -Original Message- From: Taneja, Archit Sent: Monday, September 26, 2011 5:29 PM To: Hiremath, Vaibhav Cc: Valkeinen, Tomi; linux-omap@vger.kernel.org; Semwal, Sumit; linux- me...@vger.kernel.org; Taneja, Archit

[PATCH v3 3/3] OMAPDSS/OMAP_VOUT: Fix incorrect OMAP3-alpha compatibility setting

2011-09-26 Thread Archit Taneja
driver. Use overlay cap OMAP_DSS_OVL_CAP_GLOBAL_ALPHA to check if overlay supports alpha blending or not. Replace this with checks for VIDEO1 pipeline. Cc: linux-me...@vger.kernel.org Cc: Lajos Molnar mol...@ti.com Signed-off-by: Archit Taneja arc...@ti.com --- Changes in v3: - Fix some spelling

[PATCH v2 0/5] [media]: OMAP_VOUT: Misc fixes and cleanup patches for 3.2

2011-09-26 Thread Archit Taneja
:~boddob/linux-omap-dss2/archit-dss2-clone.git 'for_omap_vout2' Archit Taneja (5): OMAP_VOUT: Fix check in reqbuf for buf_size allocation OMAP_VOUT: CLEANUP: Remove redundant code from omap_vout_isr OMAP_VOUT: Fix VSYNC IRQ handling in omap_vout_isr OMAP_VOUT: Add support for DSI panels

[PATCH v2 1/5] OMAP_VOUT: Fix check in reqbuf for buf_size allocation

2011-09-26 Thread Archit Taneja
in reqbuf. When the video device is opened the next time, this check will prevent us to allocate a buffer which is larger than what we requested the last time. Don't use vout-buffer_size, always check with the parameters video1_bufsize or video2_bufsize. Signed-off-by: Archit Taneja arc...@ti.com

[PATCH v2 2/5] OMAP_VOUT: CLEANUP: Remove redundant code from omap_vout_isr

2011-09-26 Thread Archit Taneja
Currently, there is a lot of redundant code is between DPI and VENC panels, this can be made common by moving out field/interlace specific code to a separate function called omapvid_handle_interlace_display(). There is no functional change made. Signed-off-by: Archit Taneja arc...@ti.com

[PATCH v2 3/5] OMAP_VOUT: Fix VSYNC IRQ handling in omap_vout_isr

2011-09-26 Thread Archit Taneja
is not sufficient to tell if we have received the correct irq, i.e, we shouldn't proceed ahead if we get a VSYNC interrupt for LCD2 manager, or a VSYNC2 interrupt for LCD manager. Fix this by correlating LCD manager to VSYNC interrupt and LCD2 manager to VSYNC2 interrupt. Signed-off-by: Archit Taneja arc

[PATCH v2 4/5] OMAP_VOUT: Add support for DSI panels

2011-09-26 Thread Archit Taneja
mode. Signed-off-by: Archit Taneja arc...@ti.com --- drivers/media/video/omap/omap_vout.c |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/drivers/media/video/omap/omap_vout.c b/drivers/media/video/omap/omap_vout.c index a0ca5f5..df0713c 100644 --- a/drivers/media/video/omap

[PATCH v2 5/5] OMAP_VOUT: Don't trigger updates in omap_vout_probe

2011-09-26 Thread Archit Taneja
by DSS2. This leads to a crash at probe. Signed-off-by: Archit Taneja arc...@ti.com --- drivers/media/video/omap/omap_vout.c |8 1 files changed, 0 insertions(+), 8 deletions(-) diff --git a/drivers/media/video/omap/omap_vout.c b/drivers/media/video/omap/omap_vout.c index df0713c

[PATCH v3 0/4] OMAP_VOUT: Misc fixes and cleanup patches for 3.2

2011-09-26 Thread Archit Taneja
for DSI panels Changes in v3: - Remove patch OMAP_VOUT: Fix VSYNC IRQ handling in omap_vout_isr since its still not clear whether its needed or not. Refernce base: g...@gitorious.org:~boddob/linux-omap-dss2/archit-dss2-clone.git 'for_omap_vout2' Archit Taneja (4): OMAP_VOUT: Fix check in reqbuf

[PATCH v3 1/4] OMAP_VOUT: Fix check in reqbuf for buf_size allocation

2011-09-26 Thread Archit Taneja
in reqbuf. When the video device is opened the next time, this check will prevent us to allocate a buffer which is larger than what we requested the last time. Don't use vout-buffer_size, always check with the parameters video1_bufsize or video2_bufsize. Signed-off-by: Archit Taneja arc...@ti.com

[PATCH v3 2/4] OMAP_VOUT: CLEANUP: Remove redundant code from omap_vout_isr

2011-09-26 Thread Archit Taneja
Currently, there is a lot of redundant code is between DPI and VENC panels, this can be made common by moving out field/interlace specific code to a separate function called omapvid_handle_interlace_display(). There is no functional change made. Signed-off-by: Archit Taneja arc...@ti.com

[PATCH v3 3/4] OMAP_VOUT: Add support for DSI panels

2011-09-26 Thread Archit Taneja
mode. Signed-off-by: Archit Taneja arc...@ti.com --- drivers/media/video/omap/omap_vout.c |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/drivers/media/video/omap/omap_vout.c b/drivers/media/video/omap/omap_vout.c index 01c24a4..7b8e87a 100644 --- a/drivers/media/video/omap

[PATCH v3 4/4] OMAP_VOUT: Don't trigger updates in omap_vout_probe

2011-09-26 Thread Archit Taneja
by DSS2. This leads to a crash at probe. Signed-off-by: Archit Taneja arc...@ti.com --- drivers/media/video/omap/omap_vout.c |8 1 files changed, 0 insertions(+), 8 deletions(-) diff --git a/drivers/media/video/omap/omap_vout.c b/drivers/media/video/omap/omap_vout.c index 7b8e87a

Re: [PATCH 2/5] [media]: OMAP_VOUT: CLEANUP: Remove redundant code from omap_vout_isr

2011-09-25 Thread Archit Taneja
Hi, On Wednesday 21 September 2011 04:15 PM, Taneja, Archit wrote: Hi, On Wednesday 21 September 2011 03:35 PM, Hiremath, Vaibhav wrote: -Original Message- From: Taneja, Archit Sent: Friday, September 16, 2011 3:31 PM To: Hiremath, Vaibhav Cc: Valkeinen, Tomi;

Re: [PATCH 3/5] [media]: OMAP_VOUT: Fix VSYNC IRQ handling in omap_vout_isr

2011-09-22 Thread Archit Taneja
Hi, On Wednesday 21 September 2011 07:04 PM, Hiremath, Vaibhav wrote: -Original Message- From: Taneja, Archit Sent: Friday, September 16, 2011 3:31 PM To: Hiremath, Vaibhav Cc: Valkeinen, Tomi; linux-omap@vger.kernel.org; Semwal, Sumit; linux- me...@vger.kernel.org; Taneja, Archit

Re: [PATCH 2/5] [media]: OMAP_VOUT: CLEANUP: Remove redundant code from omap_vout_isr

2011-09-21 Thread Archit Taneja
Hi, On Wednesday 21 September 2011 03:35 PM, Hiremath, Vaibhav wrote: -Original Message- From: Taneja, Archit Sent: Friday, September 16, 2011 3:31 PM To: Hiremath, Vaibhav Cc: Valkeinen, Tomi; linux-omap@vger.kernel.org; Semwal, Sumit; linux- me...@vger.kernel.org; Taneja, Archit

Re: [PATCH 1/5] [media]: OMAP_VOUT: Fix check in reqbuf mmap for buf_size allocation

2011-09-21 Thread Archit Taneja
Hi, On Wednesday 21 September 2011 02:10 PM, Hiremath, Vaibhav wrote: -Original Message- From: Taneja, Archit Sent: Friday, September 16, 2011 3:30 PM To: Hiremath, Vaibhav Cc: Valkeinen, Tomi; linux-omap@vger.kernel.org; Semwal, Sumit; linux- me...@vger.kernel.org; Taneja, Archit

Re: [PATCH v2 1/3] OMAPDSS/OMAP_VOUT: Fix incorrect OMAP3-alpha compatibility setting

2011-09-20 Thread Archit Taneja
Hi, On Tuesday 20 September 2011 01:06 AM, Hiremath, Vaibhav wrote: -Original Message- From: Taneja, Archit Sent: Friday, September 16, 2011 12:09 PM To: Valkeinen, Tomi Cc: Hiremath, Vaibhav; linux-omap@vger.kernel.org; Taneja, Archit; linux- me...@vger.kernel.org; Molnar, Lajos

Re: [PATCH v2 2/3] OMAPDSS: DISPC: VIDEO3 pipeline support

2011-09-20 Thread Archit Taneja
Hi, On Tuesday 20 September 2011 01:13 AM, Hiremath, Vaibhav wrote: -Original Message- From: Taneja, Archit Sent: Friday, September 16, 2011 12:09 PM To: Valkeinen, Tomi Cc: Hiremath, Vaibhav; linux-omap@vger.kernel.org; Taneja, Archit Subject: [PATCH v2 2/3] OMAPDSS: DISPC: VIDEO3

Re: [PATCH v2] OMAP2PLUS: DSS: Ensure DSS works correctly if display is enabled in bootloader

2011-09-20 Thread Archit Taneja
Hi Paul, On Monday 12 September 2011 12:38 PM, Taneja, Archit wrote: Resetting DISPC when a DISPC output is enabled causes the DSS to go into an inconsistent state. Thus if the bootloader has enabled a display, the hwmod code cannot reset the DISPC module just like that, but the outputs need to

[PATCH v2 1/3] OMAPDSS/OMAP_VOUT: Fix incorrect OMAP3-alpha compatibility setting

2011-09-16 Thread Archit Taneja
driver. Use overlay cap OMAP_DSS_OVL_CAP_GLOBAL_ALPHA to check if overlay supports alpha blending or not. Replace this with checks for VIDEO1 pipeline. Initial patch was made by: Lajos Molnar mol...@ti.com Cc: linux-me...@vger.kernel.org Cc: Lajos Molnar mol...@ti.com Signed-off-by: Archit Taneja arc

[PATCH v2 2/3] OMAPDSS: DISPC: VIDEO3 pipeline support

2011-09-16 Thread Archit Taneja
Add support for VIDEO3 pipeline on OMAP4: - Add VIDEO3 pipeline information in dss_features and omapdss.h - Add VIDEO3 pipeline register coefficients in dispc.h - Create a new overlay structure corresponding to VIDEO3. - Make changes in dispc.c for VIDEO3 Signed-off-by: Archit Taneja arc

[PATCH v2 3/3] OMAPDSS: DISPC: zorder support for DSS overlays

2011-09-16 Thread Archit Taneja
for the overlay or not. Use dss feature FEAT_ALPHA_FREE_ZORDER if the caps are not available. Ensure that all overlays that are enabled and connected to the same manager have different zorders. Swapping zorders of 2 enabled overlays currently requires disabling one of the overlays. Signed-off-by: Archit

[PATCH v2 0/3] OMAPDSS: DISPC: VIDEO3 and ZORDER support

2011-09-16 Thread Archit Taneja
on Tomi's master branch. It can be tried on: https://gitorious.org/~boddob/linux-omap-dss2/archit-dss2-clone/commits/dispc_misc Tested on 4430sdp, 3430sdp. Archit Taneja (3): OMAPDSS/OMAP_VOUT: Fix incorrect OMAP3-alpha compatibility setting OMAPDSS: DISPC: VIDEO3 pipeline support OMAPDSS

<    4   5   6   7   8   9   10   11   12   >