OMAP35xx MUSB kernel crash with Linux 2.6.26

2008-08-07 Thread Gupta, Ajay Kumar
Hi, I observed kernel crash in Linux 2.6.26 on OMAP35xx EVM with MUSB. The issue is described here. Case-1: 1) Connect USB stick to root hub of OMAP35xx board. 2) It gets detected successfully. 3) Disconnect the stick and connect it again 4) repeat step-3 and we get kernel crash (log-1 attached

RE: [PATCH] OMAP:MUSB: Corrects urb unlink function path

2008-08-22 Thread Gupta, Ajay Kumar
On Fri, 22 Aug 2008 [EMAIL PROTECTED] wrote: From: Ajay Kumar Gupta [EMAIL PROTECTED] Fixes kernel panic while ISO IN transfer is aborted.Replaced usb_hcd_unlink_urb_from_ep() from musb_giveback() to __musb_giveback() to make sure urb is unlinked before giveback when __musb_giveback() is

RE: [PATCH] OMAP:MUSB: Corrects urb unlink function path

2008-08-22 Thread Gupta, Ajay Kumar
From: [EMAIL PROTECTED] [EMAIL PROTECTED] On Behalf Of Gupta, Ajay Kumar [EMAIL PROTECTED] Sent: Friday, August 22, 2008 8:44 PM To: Alan Stern Cc: linux-omap@vger.kernel.org; [EMAIL PROTECTED]; [EMAIL PROTECTED]; [EMAIL PROTECTED] Subject: RE: [PATCH

RE: [PATCH 2/3 v4] musb: add musb support for AM35x

2010-09-29 Thread Gupta, Ajay Kumar
Hi, +config USB_MUSB_AM35X + boolean AM35X MUSB support + depends on USB_MUSB_HDRC MACH_OMAP3517EVM As I've already said, depending on the board type won't scale... :-( ..and to scale it up we need to add select USB_MUSB_AM35X in arch/arm/mach-omap2/Kconfig for all the boards

RE: [PATCH 1/3 v5] AM35x: Add musb support

2010-10-01 Thread Gupta, Ajay Kumar
Hi, On Thu, Sep 30, 2010 at 12:19:07AM -0500, Gupta, Ajay Kumar wrote: AM35x has musb interface (version 1.8) and uses CPPI41 DMA engine. It has USB phy built inside the IP itself. Signed-off-by: Ajay Kumar Gupta ajay.gu...@ti.com besides the one small question below: Acked-by: Felipe

RE: [PATCH 2/3 v5] musb: add musb support for AM35x

2010-10-01 Thread Gupta, Ajay Kumar
Hi, On Thu, Sep 30, 2010 at 12:19:08AM -0500, Gupta, Ajay Kumar wrote: AM35x has musb interface and uses CPPI4.1 DMA engine. Current patch supports only PIO mode. DMA support can be added later once basic CPPI4.1 DMA patch is accepted. Also added USB_MUSB_AM35X which is required

RE: [PATCH 2/3 v5] musb: add musb support for AM35x

2010-10-01 Thread Gupta, Ajay Kumar
Hi, [...] I couldn't fetch your gitorious tree so I just applied 14 patch set Manually on my branch. Anyways I will look into it and send the refreshed patch shortly. gitorious must be trying to make me look bad :-p Works like a charm here. Will try on a different laptop fine on

RE: [PATCH 1/2] AM35x: musb: fix compilation error

2010-12-01 Thread Gupta, Ajay Kumar
Tony ? Do you ack the usage of that header ? NAK. Drivers should not mess with the control registers directly. Instead, the following should be done in the platform init code: $ grep -r omap_ctrl_read drivers/usb drivers/usb/musb/am35x.c: devconf2 =

RE: [PATCH 1/2] AM35x: musb: fix compilation error

2010-12-01 Thread Gupta, Ajay Kumar
We would need control register apis for accessing USB PHY control , IPSS reset and interrupt clear register. This would require to add three different function pointer and that would mostly be custom to AM35x. Will that be acceptable from musb perspective ? why don't you add a proper

RE: [PATCH 1/2] AM35x: musb: fix compilation error

2010-12-02 Thread Gupta, Ajay Kumar
why don't you add a proper otg_transceiver driver for am35x ? Is it like omap4's internal phy ? A separate block ? AM35x PHY is built inside the ip and we need to configure it through PHY control register. Additionally we also need to access IPSS reset and Intr clear register as well

RE: [PATCH 1/2] AM35x: musb: fix compilation error

2010-12-03 Thread Gupta, Ajay Kumar
We already have generic APIs so I think we can pass function pointers to musb driver via struct omap_musb_board_data, struct omap_musb_board_data { +void(*phy_on) (void) +void(*phy_off) (void) +void (*intr_clr) (void) } Reset part can be done in board file itself

RE: [PATCH] musb: am35x: fix compile error due to control apis

2010-12-04 Thread Gupta, Ajay Kumar
As the control.h have been moved to new location and it's uses are not allowed to drivers directly so moving the phy control, interrupt clear and reset functionality to board files. Signed-off-by: Ajay Kumar Gupta ajay.gu...@ti.com --- Patch created against today's linus tree. I

RE: [PATCH] musb: am35x: fix compile error due to control apis

2010-12-04 Thread Gupta, Ajay Kumar
diff --git a/arch/arm/mach-omap2/usb-musb.c b/arch/arm/mach-omap2/usb- musb.c index 7260558..1f32fdb 100644 --- a/arch/arm/mach-omap2/usb-musb.c +++ b/arch/arm/mach-omap2/usb-musb.c @@ -33,6 +33,82 @@ #ifdef CONFIG_USB_MUSB_SOC +static void am35x_musb_phy_power(u8 on) +{ +

RE: [PATCH 1/2] AM35x: musb: fix compilation error

2010-12-06 Thread Gupta, Ajay Kumar
On Fri, Dec 03, 2010 at 07:08:53PM +0530, Gupta, Ajay Kumar wrote: We already have generic APIs so I think we can pass function pointers to musb driver via struct omap_musb_board_data, struct omap_musb_board_data { + void(*phy_on) (void) + void(*phy_off) (void) + void

RE: [PATCH v2] musb: am35x: fix compile error due to control apis

2010-12-06 Thread Gupta, Ajay Kumar
Hi, As the control.h have been moved to new location and it's uses are not allowed to drivers directly so moving the phy control, interrupt clear and reset functionality to board files. I'm not fond of the whole approach. I'm not sure why accesses to the control registers are such

RE: [PATCH 1/2] AM35x: musb: fix compilation error

2010-12-07 Thread Gupta, Ajay Kumar
Hi, Is AM35x that different ? Can't you just write to MUSB_INTRRX MUSB_INTRTX and MUSB_INTRUSB ?? Writing to MUSB_INTRRX/TX/USB wouldn't help. We have to clear interrupt Bit in control register INTR_LVL_CLR. I see, thanks for the info :-) Felipe, I have recreated this patch (attached)

RE: [PATCH v5 1/3] ARM: add CPPI 4.1 DMA support

2011-01-03 Thread Gupta, Ajay Kumar
Hi, Add support for Texas Instuments Communication Port Programming Interface 4.1 (CPPI 4.1) used on OMAP-L1x/DA8xx and AM35x. At this moment, only the DMA controller and queue manager are supported. Support for the buffer manager is lacking but these chips don't have it anyway.

RE: [PATCH v5 1/3] ARM: add CPPI 4.1 DMA support

2011-01-03 Thread Gupta, Ajay Kumar
Hi, Add support for Texas Instuments Communication Port Programming Interface 4.1 (CPPI 4.1) used on OMAP-L1x/DA8xx and AM35x. At this moment, only the DMA controller and queue manager are supported. Support for the buffer manager is lacking but these chips don't have it anyway.

RE: Interval value set in RXINTERVAL register of MUSB?

2010-01-12 Thread Gupta, Ajay Kumar
-Original Message- From: jung songtan [mailto:jungsong...@gmail.com] Sent: Tuesday, January 12, 2010 3:22 PM To: Gupta, Ajay Kumar; linux-omap@vger.kernel.org Subject: Interval value set in RXINTERVAL register of MUSB? Hi Ajay and expert, Can you correct me if my understanding

RE: Device usb1 failed to suspend: error -16

2010-01-12 Thread Gupta, Ajay Kumar
-Original Message- From: linux-omap-ow...@vger.kernel.org [mailto:linux-omap- ow...@vger.kernel.org] On Behalf Of Weng, Wending Sent: Tuesday, January 12, 2010 12:34 AM To: linux-omap Subject: PM: Device usb1 failed to suspend: error -16 Hi All, I tried to suspend the

RE: Interval value set in RXINTERVAL register of MUSB?

2010-01-12 Thread Gupta, Ajay Kumar
-Original Message- From: jung songtan [mailto:jungsong...@gmail.com] Sent: Tuesday, January 12, 2010 6:11 PM To: Gupta, Ajay Kumar Cc: linux-omap@vger.kernel.org; jungsongtan Subject: Re: Interval value set in RXINTERVAL register of MUSB? Interval=2 for a low speed device means

RE: OMAP3: PM: Disable OTG autoidle when waking up from off-mode

2010-01-21 Thread Gupta, Ajay Kumar
Hi Kristo, There are some issues with this patch in PM branch. Please find my comments inline. Regards, Ajay OMAP3: PM: Disable OTG autoidle when waking up from off-mode OMAP3 sleep can be prevented in some cases where OTG autoidle is enabled. This patch force disables

RE: [PATCH 1/7] usb: musb: Add context save and restore support

2010-01-24 Thread Gupta, Ajay Kumar
Hi, -Original Message- From: Patra, Nilkesh Sent: Monday, January 25, 2010 12:49 PM To: Felipe Balbi; Greg KH Cc: Linux USB Mailing List; Linux OMAP Mailing List; Gupta, Ajay Kumar; Gadiyar, Anand Subject: RE: [PATCH 1/7] usb: musb: Add context save and restore support

RE: [PATCH 10/11] omap: musb: get rid of dyn_fifo

2010-02-23 Thread Gupta, Ajay Kumar
-Original Message- From: linux-arm-kernel-boun...@lists.infradead.org [mailto:linux-arm- kernel-boun...@lists.infradead.org] On Behalf Of Tony Lindgren Sent: Saturday, February 20, 2010 5:01 AM To: linux-arm-ker...@lists.infradead.org Cc: Felipe Balbi; linux-omap@vger.kernel.org;

RE: [PATCH] musb: fix power field to hold all possible values

2010-02-25 Thread Gupta, Ajay Kumar
Hi, -Original Message- From: Tony Lindgren [mailto:t...@atomide.com] Sent: Friday, February 26, 2010 3:50 AM To: Felipe Balbi Cc: Gupta, Ajay Kumar; linux-omap@vger.kernel.org Subject: Re: [PATCH] musb: fix power field to hold all possible values * Felipe Balbi m

RE: [PATCH] musb: Add workqueue for URB giveback

2010-02-26 Thread Gupta, Ajay Kumar
Hi, -Original Message- From: Oliver Neukum [mailto:oli...@neukum.org] Sent: Friday, February 26, 2010 4:33 PM To: Gupta, Ajay Kumar Cc: linux-...@vger.kernel.org; linux-omap@vger.kernel.org; st...@rowland.harvard.edu Subject: Re: [PATCH] musb: Add workqueue for URB giveback Am

RE: [PATCH] musb: Add workqueue for URB giveback

2010-02-26 Thread Gupta, Ajay Kumar
Hi, Am Freitag, 26. Februar 2010 11:39:06 schrieb Ajay Kumar Gupta: +struct queue *create(void) +{ + struct queue *new; + new = kmalloc(sizeof(struct queue), GFP_ATOMIC); + if (!new) + return NULL; + new-next = NULL; +

RE: [PATCH] musb: Add workqueue for URB giveback

2010-02-26 Thread Gupta, Ajay Kumar
Hi, -Original Message- From: Laurent Pinchart [mailto:laurent.pinch...@ideasonboard.com] Sent: Friday, February 26, 2010 5:04 PM To: Gupta, Ajay Kumar Cc: linux-...@vger.kernel.org; linux-omap@vger.kernel.org; st...@rowland.harvard.edu; oli...@neukum.org Subject: Re: [PATCH] musb

RE: usb_nop_xceiv_register() missing when OTG built as modules

2010-03-03 Thread Gupta, Ajay Kumar
-Original Message- From: linux-omap-ow...@vger.kernel.org [mailto:linux-omap- ow...@vger.kernel.org] On Behalf Of Kevin Hilman Sent: Thursday, March 04, 2010 5:39 AM To: linux-omap@vger.kernel.org Subject: usb_nop_xceiv_register() missing when OTG built as modules This just

RE: usb_nop_xceiv_register() missing when OTG built as modules

2010-03-04 Thread Gupta, Ajay Kumar
-Original Message- From: Kevin Hilman [mailto:khil...@deeprootsystems.com] Sent: Thursday, March 04, 2010 11:03 PM To: Gupta, Ajay Kumar Cc: linux-omap@vger.kernel.org Subject: Re: usb_nop_xceiv_register() missing when OTG built as modules Gupta, Ajay Kumar ajay.gu...@ti.com

RE: [PATCH 3/3] omap3evm: musb: Update power capability for OMAP3EVM (Rev = E)

2009-10-28 Thread Gupta, Ajay Kumar
Felipe, -Original Message- From: Menon, Nishanth Sent: Thursday, October 29, 2009 11:06 AM To: Gupta, Ajay Kumar; Gadiyar, Anand; linux-omap@vger.kernel.org Cc: felipe.ba...@nokia.com; t...@atomide.com Subject: RE: [PATCH 3/3] omap3evm: musb: Update power capability for OMAP3EVM

RE: [PATCH 1/3] omap3evm: ehci: Add EHCI padconfig for board Rev = E

2009-10-29 Thread Gupta, Ajay Kumar
Nishanth, Signed-off-by: Ajay Kumar Gupta ajay.gu...@ti.com --- arch/arm/mach-omap2/mux.c |7 +++ arch/arm/plat-omap/include/plat/mux.h |5 + 2 files changed, 12 insertions(+), 0 deletions(-) diff --git a/arch/arm/mach-omap2/mux.c

RE: [PATCH 3/3] omap3evm: musb: Update power capability for OMAP3EVM (Rev = E)

2009-10-29 Thread Gupta, Ajay Kumar
-Original Message- From: Felipe Balbi [mailto:felipe.ba...@nokia.com] Sent: Thursday, October 29, 2009 12:29 PM To: Gupta, Ajay Kumar Cc: linux-omap@vger.kernel.org; Balbi Felipe (Nokia-D/Helsinki); Menon, Nishanth; Gadiyar, Anand Subject: Re: [PATCH 3/3] omap3evm: musb: Update

RE: [PATCH 3/3] omap3evm: musb: Update power capability for OMAP3EVM (Rev = E)

2009-10-29 Thread Gupta, Ajay Kumar
Hi, On Thu, Oct 29, 2009 at 08:03:21AM +0100, ext Gupta, Ajay Kumar wrote: I was thinking on adding a musb_hdrc_board_data which would group board-specific data such as this one. Musb's init phase is quite messy as of today so we would need to clean that up. Anyways, the main idea

Query: Regulator framework in EHCI driver

2009-11-03 Thread Gupta, Ajay Kumar
Hi Anand/Felipe, This is regarding regulator framework for 1V8 supply to EHCI PHY from twl4030 device. [EHCI port on OMAP3EVM uses SMSC USB3320 PHY and uses 1V8 supply from twl4030 chip.] I found twl4030_usb_ldo_init () function in drivers/usb/otg/twl4030-usb.c, which uses regulator

RE: Query: Regulator framework in EHCI driver

2009-11-04 Thread Gupta, Ajay Kumar
This is regarding regulator framework for 1V8 supply to EHCI PHY from twl4030 device. [EHCI port on OMAP3EVM uses SMSC USB3320 PHY and uses 1V8 supply from twl4030 chip.] I found twl4030_usb_ldo_init () function in drivers/usb/otg/twl4030- usb.c, which uses regulator framework but

RE: Query: Regulator framework in EHCI driver

2009-11-11 Thread Gupta, Ajay Kumar
Hi, -Original Message- From: Gadiyar, Anand Sent: Thursday, November 05, 2009 4:56 PM To: Mark Brown Cc: felipe.ba...@nokia.com; Gupta, Ajay Kumar; linux-omap@vger.kernel.org; Aggarwal, Anuj Subject: RE: Query: Regulator framework in EHCI driver On Thu, Nov 05, 2009 at 04:01

RE: Query: Regulator framework in EHCI driver

2009-11-11 Thread Gupta, Ajay Kumar
Hi, + /* get ehci regulator and enable */ + for (i = 0 ; i OMAP3_HS_USB_PORTS ; i++) { + if (omap-port_mode[i] == EHCI_HCD_OMAP_MODE_UNKNOWN) + continue; + sprintf(supply, ehci%d, i); The use of sprintf() here looks suspicious - these things

RE: Query: Regulator framework in EHCI driver

2009-11-11 Thread Gupta, Ajay Kumar
Hi, + /* get ehci regulator and enable */ + for (i = 0 ; i OMAP3_HS_USB_PORTS ; i++) { + if (omap-port_mode[i] == EHCI_HCD_OMAP_MODE_UNKNOWN) + continue; + sprintf(supply, ehci%d, i); The use of sprintf() here looks suspicious - these things

RE: Query: Regulator framework in EHCI driver

2009-11-11 Thread Gupta, Ajay Kumar
Hi, If you do stick with this approach you probably want to use snprintf() and make supply be 6 bytes rather than 5 bytes long. + for (i = 0 ; i OMAP3_HS_USB_PORTS ; i++) { + if (omap-port_mode[i] == EHCI_HCD_OMAP_MODE_UNKNOWN) +

RE: Query: Regulator framework in EHCI driver

2009-11-12 Thread Gupta, Ajay Kumar
Hi, MODE_UNKNOWN means that the port is not connected and so no need to check the regulator availability. Sure, currently - the point is that if you're going to check for the individual allocations anyway then the check doesn't buy you anything. Now I have taken this into consideration

[build errro on for-next branch] RE: [1/3] omap3evm: ehci: Add EHCI padconfig for board Rev = E

2009-11-13 Thread Gupta, Ajay Kumar
Hi, * Ajay Kumar Gupta ajay.gu...@ti.com [091028 16:12]: OMAP3EVM (Rev = E) has EHCI port on main board itself. Apart from this there is a slot to connect Mistral Daughter Card (MDC) to it which also has one EHCI port. Only one EHCI port can be used at a time and we can choose the port

RE: Query: Regulator framework in EHCI driver

2009-11-14 Thread Gupta, Ajay Kumar
Hi, -Original Message- From: Mark Brown [mailto:broo...@opensource.wolfsonmicro.com] Sent: Friday, November 13, 2009 6:25 PM To: Gupta, Ajay Kumar Cc: Gadiyar, Anand; felipe.ba...@nokia.com; linux-omap@vger.kernel.org; Aggarwal, Anuj Subject: Re: Query: Regulator framework in EHCI

RE: Dose OMAP3 support split transfer?

2009-11-16 Thread Gupta, Ajay Kumar
-Original Message- From: linux-omap-ow...@vger.kernel.org [mailto:linux-omap- ow...@vger.kernel.org] On Behalf Of jung songtan Sent: Monday, November 16, 2009 7:32 AM To: linux-omap@vger.kernel.org Subject: Dose OMAP3 support split transfer? Hi Guys, Dose OMAP3 support split

RE: [PATCH 3/8] musb: Update musb_init() call for all OMAP3 boards

2009-11-17 Thread Gupta, Ajay Kumar
Hi, -Original Message- From: linux-omap-ow...@vger.kernel.org [mailto:linux-omap- ow...@vger.kernel.org] On Behalf Of Sergei Shtylyov Sent: Tuesday, November 17, 2009 10:01 PM To: Gupta, Ajay Kumar Cc: linux-...@vger.kernel.org; davinci-linux-open- sou...@linux.davincidsp.com; coolo

RE: [PATCH 4/8] musb: Update setup_usb() call for all Davinci boards

2009-11-17 Thread Gupta, Ajay Kumar
Hi, -Original Message- From: Sergei Shtylyov [mailto:sshtyl...@ru.mvista.com] Sent: Tuesday, November 17, 2009 9:24 PM To: Gupta, Ajay Kumar Cc: linux-...@vger.kernel.org; davinci-linux-open- sou...@linux.davincidsp.com; coolo...@kernel.org; felipe.ba...@nokia.com; linux-omap

RE: [PATCH 2/8] musb: Get power (mA) from board data

2009-11-17 Thread Gupta, Ajay Kumar
Hi, -Original Message- From: Sergei Shtylyov [mailto:sshtyl...@ru.mvista.com] Sent: Tuesday, November 17, 2009 9:12 PM To: Gupta, Ajay Kumar Cc: linux-...@vger.kernel.org; davinci-linux-open- sou...@linux.davincidsp.com; coolo...@kernel.org; felipe.ba...@nokia.com; linux-omap

RE: [PATCH 0/8] musb: Add structure 'musb_hdrc_board_data'

2009-11-18 Thread Gupta, Ajay Kumar
Hi, -Original Message- From: Sergei Shtylyov [mailto:sshtyl...@ru.mvista.com] Sent: Wednesday, November 18, 2009 7:50 PM To: Gupta, Ajay Kumar Cc: linux-...@vger.kernel.org; davinci-linux-open-sou...@linux.davincidsp.com; coolo...@kernel.org; felipe.ba...@nokia.com; linux-omap

RE: [PATCH 1/2 v2] musb: Add context save and restore support

2009-11-26 Thread Gupta, Ajay Kumar
Hi, -Original Message- From: Dasgupta, Romit Sent: Thursday, November 26, 2009 2:33 PM To: Gupta, Ajay Kumar Cc: linux-...@vger.kernel.org; linux-omap@vger.kernel.org; felipe.ba...@nokia.com; Gadiyar, Anand Subject: Re: [PATCH 1/2 v2] musb: Add context save and restore support

Re: [PATCH 1/2 v2] musb: Add context save and restore support

2009-12-13 Thread Gupta, Ajay Kumar
Adding support for MUSB register save and restore during system suspend and resume. Changes:     - Added musb_save/restore_context() functions     - Added platform specific musb_platform_save/restore_context()   to handle platform specific jobs.     - Maintaining BlackFin

RE: Padconf not working on pm_defconfig?

2009-12-14 Thread Gupta, Ajay Kumar
-Original Message- From: linux-omap-ow...@vger.kernel.org [mailto:linux-omap- ow...@vger.kernel.org] On Behalf Of Gadiyar, Anand Sent: Monday, December 14, 2009 3:24 PM To: linux-omap@vger.kernel.org; Kevin Hilman; Tony Lindgren Subject: Padconf not working on pm_defconfig? I'm

RE: [PATCH 1/3] musb: save dynfifo in musb struct

2009-12-14 Thread Gupta, Ajay Kumar
-Original Message- From: Felipe Balbi [mailto:felipe.ba...@nokia.com] Sent: Monday, December 14, 2009 9:55 PM To: Gupta, Ajay Kumar Cc: linux-...@vger.kernel.org; linux-omap@vger.kernel.org; Balbi Felipe (Nokia-D/Helsinki); davi...@pacbell.net Subject: Re: [PATCH 1/3] musb: save

RE: [PATCH 3/3] musb: Add 'extvbus' in musb_hdrc_platform_data

2009-12-14 Thread Gupta, Ajay Kumar
-Original Message- From: Felipe Balbi [mailto:felipe.ba...@nokia.com] Sent: Monday, December 14, 2009 10:08 PM To: Gupta, Ajay Kumar Cc: linux-...@vger.kernel.org; linux-omap@vger.kernel.org; Balbi Felipe (Nokia-D/Helsinki); davi...@pacbell.net Subject: Re: [PATCH 3/3] musb: Add

RE: [PATCH 1/3] musb: save dynfifo in musb struct

2009-12-14 Thread Gupta, Ajay Kumar
-Original Message- From: Felipe Balbi [mailto:felipe.ba...@nokia.com] Sent: Tuesday, December 15, 2009 1:10 PM To: Gupta, Ajay Kumar Cc: Balbi Felipe (Nokia-D/Helsinki); linux-...@vger.kernel.org; linux- o...@vger.kernel.org; davi...@pacbell.net Subject: Re: [PATCH 1/3] musb: save

RE: [PATCH 2/3 v3] musb: Add context save and restore support

2009-12-15 Thread Gupta, Ajay Kumar
snip.. @@ -2179,15 +2322,23 @@ static int musb_suspend(struct device *dev) spin_lock_irqsave(musb-lock, flags); if (is_peripheral_active(musb)) { - /* FIXME force disconnect unless we know USB will wake -* the system up quickly enough to

RE: [PATCH 2/3 v3] musb: Add context save and restore support

2009-12-15 Thread Gupta, Ajay Kumar
-Original Message- From: Felipe Balbi [mailto:felipe.ba...@nokia.com] Sent: Tuesday, December 15, 2009 5:41 PM To: Gadiyar, Anand Cc: Gupta, Ajay Kumar; Balbi Felipe (Nokia-D/Helsinki); linux- u...@vger.kernel.org; linux-omap@vger.kernel.org; davi...@pacbell.net Subject: Re: [PATCH

RE: [PATCH 2/3 v3] musb: Add context save and restore support

2009-12-15 Thread Gupta, Ajay Kumar
It should be system's responsibility for not entering into suspend mode when there is an ongoing active transfer. If this is reliable then there is no need for any force disconnect. On OMAP3EVM, I can see that system doesn't enter into suspend mode when cable is connected so should be fine

RE: [PATCH 1/4] musb: get rid of unneeded musb-config-dyn_fifo

2009-12-15 Thread Gupta, Ajay Kumar
-Original Message- From: Tony Lindgren [mailto:t...@atomide.com] Sent: Tuesday, December 15, 2009 11:10 PM To: Gupta, Ajay Kumar Cc: linux-...@vger.kernel.org; linux-omap@vger.kernel.org; felipe.ba...@nokia.com Subject: Re: [PATCH 1/4] musb: get rid of unneeded musb-config-dyn_fifo

RE: [PATCH 1/4] musb: get rid of unneeded musb-config-dyn_fifo

2009-12-17 Thread Gupta, Ajay Kumar
-Original Message- From: linux-omap-ow...@vger.kernel.org [mailto:linux-omap- ow...@vger.kernel.org] On Behalf Of Gupta, Ajay Kumar Sent: Tuesday, December 15, 2009 8:45 PM To: felipe.ba...@nokia.com Cc: linux-...@vger.kernel.org; linux-omap@vger.kernel.org Subject: RE: [PATCH 1/4

RE: [PATCH 1/4] musb: get rid of unneeded musb-config-dyn_fifo

2009-12-17 Thread Gupta, Ajay Kumar
-Original Message- From: Felipe Balbi [mailto:felipe.ba...@nokia.com] Sent: Thursday, December 17, 2009 6:40 PM To: Gupta, Ajay Kumar Cc: Balbi Felipe (Nokia-D/Helsinki); linux-...@vger.kernel.org; linux- o...@vger.kernel.org Subject: Re: [PATCH 1/4] musb: get rid of unneeded musb

RE: [PATCH 2/3 v3] musb: Add context save and restore support

2009-12-17 Thread Gupta, Ajay Kumar
snip #ifdef CONFIG_PM +static struct musb_context_registers musb_context; + +void musb_save_context(struct musb *musb) +{ Could you add one more parameter to this function call, which would select either if we want to save the musb_platform context or not? I m working at the

RE: [PATCH 2/3 v3] musb: Add context save and restore support

2009-12-17 Thread Gupta, Ajay Kumar
-Original Message- From: Arnaud Mandy [mailto:ext-arnaud.2.ma...@nokia.com] Sent: Thursday, December 17, 2009 7:41 PM To: Gupta, Ajay Kumar Cc: linux-...@vger.kernel.org; linux-omap@vger.kernel.org; Balbi Felipe (Nokia-D/Helsinki); davi...@pacbell.net; Gadiyar, Anand Subject: Re

RE: [PATCH 2/3 v3] musb: Add context save and restore support

2009-12-17 Thread Gupta, Ajay Kumar
In order to support off-mode, we need the transceiver driver to wake-up the controller. I m working on a hook which would allow that. I want to take advantage of your implementation for saving/restoring musb context, but saving the platform data is not necessary in my case. Then

RE: [PATCH 7/8] arm: omap: musb: pass board mode to usb_musb_init

2009-12-29 Thread Gupta, Ajay Kumar
Hi, -Original Message- From: linux-omap-ow...@vger.kernel.org [mailto:linux-omap- ow...@vger.kernel.org] On Behalf Of Felipe Balbi Sent: Monday, December 28, 2009 4:40 PM To: Tony Lindgren Cc: Linux OMAP Mailing List; Felipe Balbi Subject: [PATCH 7/8] arm: omap: musb: pass board

RE: [PATCH 1/2] ARM : OMAP: MUSB : Pass board specific data using a structure

2009-12-30 Thread Gupta, Ajay Kumar
Hi, -Original Message- From: linux-omap-ow...@vger.kernel.org [mailto:linux-omap- ow...@vger.kernel.org] On Behalf Of Mankad, Maulik Ojas Sent: Wednesday, December 30, 2009 4:15 PM To: linux-omap@vger.kernel.org Cc: linux-...@vger.kernel.org; Mankad, Maulik Ojas; Felipe Balbi; Tony

RE: [PATCH 1/2] ARM : OMAP : Remove #ifdef from board-omap3evm.c

2010-01-03 Thread Gupta, Ajay Kumar
-Original Message- From: linux-usb-ow...@vger.kernel.org [mailto:linux-usb- ow...@vger.kernel.org] On Behalf Of Felipe Balbi Sent: Saturday, January 02, 2010 2:31 AM To: Mankad, Maulik Ojas Cc: linux-omap@vger.kernel.org; linux-...@vger.kernel.org; Tony Lindgren; Felipe Balbi; Greg

RE: [PATCH v2 1/2] ARM : OMAP : Add empty functions in header file

2010-01-04 Thread Gupta, Ajay Kumar
-Original Message- From: Mankad, Maulik Ojas Sent: Monday, January 04, 2010 4:40 PM To: linux-omap@vger.kernel.org Cc: linux-...@vger.kernel.org; Mankad, Maulik Ojas; Tony Lindgren; Felipe Balbi; Greg Kroah-Hartman; Olof Johansson; Sergei Shtylyov; Gupta, Ajay Kumar Subject: [PATCH

RE: [PATCH 3/3] musb: Remvoing twl4030 dependency for OMAP3EVM MUSB

2008-11-27 Thread Gupta, Ajay Kumar
no. I could even live with if (machine_is_xxx()) code, although I don't want to. But ifdefs are an automatic NAK. Felipe, this is temporary patch as described. I will submit the final one later. twl4030 dependency is bottleneck for TPS work on OMAP3EVM. -- balbi -- To unsubscribe

RE: [PATCH 3/3] musb: Remvoing twl4030 dependency for OMAP3EVM MUSB

2008-11-27 Thread Gupta, Ajay Kumar
-Original Message- From: [EMAIL PROTECTED] [mailto:[EMAIL PROTECTED] On Behalf Of David Brownell Sent: Friday, November 28, 2008 12:33 PM To: Pillai, Manikandan Cc: linux-omap@vger.kernel.org Subject: Re: [PATCH 3/3] musb: Remvoing twl4030 dependency for OMAP3EVM MUSB On Thursday

RE: [PATCH v2] usb: musb: fix bug in musbhsdma programming

2009-01-12 Thread Gupta, Ajay Kumar
-Original Message- From: Felipe Balbi [mailto:m...@felipebalbi.com] Sent: Tuesday, January 13, 2009 3:57 AM To: Gupta, Ajay Kumar Cc: linux-omap@vger.kernel.org; davi...@pacbell.net; felipe.ba...@nokia.com Subject: Re: [PATCH v2] usb: musb: fix bug in musbhsdma programming On Fri

RE: Missing USB OTG ID interrupt../

2009-01-12 Thread Gupta, Ajay Kumar
V -Original Message- From: linux-omap-ow...@vger.kernel.org [mailto:linux-omap-ow...@vger.kernel.org] On Behalf Of Peter Barada Sent: Tuesday, January 13, 2009 1:09 AM To: linux-omap Subject: Missing USB OTG ID interrupt../ On the current PM tree (2.6.28-rc8, revision 2beb9b4b)

RE: [PATCH 3/3] usb: musb: fix null pointer check in musb_platform_init()

2009-01-12 Thread Gupta, Ajay Kumar
-Original Message- From: Felipe Balbi [mailto:m...@felipebalbi.com] Sent: Tuesday, January 13, 2009 4:02 AM To: Gupta, Ajay Kumar Cc: linux-...@vger.kernel.org; linux-omap@vger.kernel.org; davi...@pacbell.net; felipe.ba...@nokia.com Subject: Re: [PATCH 3/3] usb: musb: fix null

RE: [PATCH] usb: musb: fix bug in musbhsdma programming

2009-01-23 Thread Gupta, Ajay Kumar
On Thu, Jan 08, 2009 at 06:01:36PM +0530, Ajay Kumar Gupta wrote: Mode bit should be set based on function parameter mode of configure_channel() function. Signed-off-by: Ajay Kumar Gupta ajay.gu...@ti.com Acked-by: Felipe Balbi felipe.ba...@nokia.com NAK -- interpretation of the MODE

RE: [PATCH] usb: musb: adding nop usb transceiver

2009-01-29 Thread Gupta, Ajay Kumar
We'll need something like this, yes. This one looks to need a bit of tweaking yet though ... probably that could be done after merge. The state can need changing after one of the drivers is unregistered; I didn't get this comment. using __exit not __devexit is likely wrong (especially

RE: [PATCH] usb: musb: adding nop usb transceiver

2009-01-30 Thread Gupta, Ajay Kumar
Basically, that almost all of the OTG state machine must be handled outside of this code. It's a bit of a puzzle how to partition that state machine between the drivers that need to collaborate on it. At this point I don't think there can be a single model that applies everywhere ... but

RE: OMAP3 EHCI USB HS mode performance issue

2009-02-03 Thread Gupta, Ajay Kumar
I am using OMAP3 based board,  running git based kernel 2..6.28, and enabled EHCI HCD (USB 2.0) support, PHY mode. EHCI HS performance is measured using Catalyst, USB analyzer.  Are you doing bulk transfer to a pen drive to measure performance? If so then try using any USB hard disk.

RE: OMAP3 EHCI USB HS mode performance issue

2009-02-03 Thread Gupta, Ajay Kumar
I am transfering 100MB file to pen drive.  I have tried with pen drive with different manufacturer (Tanscend, SanDisk, Kingston).  I am using OMAP35x EVM. We have observed lower throughput with pen drive so it's better if you take the performance numbers from any USB hard disk. I think you

RE: musb OTG broken in 2.6.29-rc3?

2009-02-09 Thread Gupta, Ajay Kumar
-Original Message- From: linux-omap-ow...@vger.kernel.org [mailto:linux-omap-ow...@vger.kernel.org] On Behalf Of Steve Sakoman Sent: Monday, February 09, 2009 11:11 PM To: linux-omap Subject: musb OTG broken in 2.6.29-rc3? I've been running with musb in host mode on Overo.

RE: musb OTG broken in 2.6.29-rc3?

2009-02-09 Thread Gupta, Ajay Kumar
-Original Message- From: Steve Sakoman [mailto:sako...@gmail.com] Sent: Tuesday, February 10, 2009 10:13 AM To: Gupta, Ajay Kumar Cc: linux-omap Subject: Re: musb OTG broken in 2.6.29-rc3? On Mon, Feb 9, 2009 at 8:05 PM, Gupta, Ajay Kumar ajay.gu...@ti.com wrote: Before I

Solved !!! RE: OMAP35xx MUSB kernel crash with Linux 2.6.26

2008-08-29 Thread Gupta, Ajay Kumar
Back porting drivers/usb/storage from v2.6.27rc4 to v2.6.26-omap1 solved this kernel panic. Regards, Ajay -Original Message- From: [EMAIL PROTECTED] [mailto:[EMAIL PROTECTED] On Behalf Of Gupta, Ajay Kumar Sent: Friday, August 08, 2008 11:21 AM To: linux-omap@vger.kernel.org Cc: [EMAIL

RE: Soft lockup when disconnecting musb isochronous device.

2008-09-30 Thread Gupta, Ajay Kumar
I've been trying to get the UVC camera driver working in linux-omap on the Beagleboard, which uses musb. With the latest linux-omap git, capture doesn't work. Applying Ajay Gupta's MUSB patches posted here on 9/8 allows capture to work until the device is closed. With or without Ajay's

RE: Soft lockup when disconnecting musb isochronous device.

2008-09-30 Thread Gupta, Ajay Kumar
it happens when w_scan tries to tune into a specific frequency on a USB DVB-T stick. Any ideas about that one? I have applied these patches: [PATCH v3] OMAP:MUSB: Corrects urb unlink function path usb: musb: fix something MUSB high-bandwidth support patch MUSB ISO dma fix. What

RE: USB serial devices not working on linux-omap musb.

2008-09-30 Thread Gupta, Ajay Kumar
-Original Message- From: [EMAIL PROTECTED] [mailto:[EMAIL PROTECTED] On Behalf Of Nathan Monson Sent: Wednesday, October 01, 2008 10:06 AM To: linux-omap@vger.kernel.org Subject: USB serial devices not working on linux-omap musb. I'm trying to use a USB serial device on a

RE: USB serial devices not working on linux-omap musb.

2008-10-01 Thread Gupta, Ajay Kumar
PM, Gupta, Ajay Kumar [EMAIL PROTECTED] wrote: -Original Message- From: [EMAIL PROTECTED] [mailto:[EMAIL PROTECTED] On Behalf Of Nathan Monson Sent: Wednesday, October 01, 2008 10:06 AM To: linux-omap@vger.kernel.org Subject: USB serial devices not working on linux-omap musb. I'm

RE: USB serial devices not working on linux-omap musb.

2008-10-06 Thread Gupta, Ajay Kumar
Thanks for your comments. On Wednesday 01 October 2008, Gupta, Ajay Kumar wrote: Currently all the BULK request are multiplexed on one hardware endpoint and when a wifi or eth device is in use they never release BULK hardware endpoint so that it can be used by other devices. This causes

RE: [PATCH] MUSB: BULK request on different available endpoints

2008-10-07 Thread Gupta, Ajay Kumar
-Original Message- From: David Brownell [mailto:[EMAIL PROTECTED] Sent: Tuesday, October 07, 2008 11:35 AM To: Gupta, Ajay Kumar Cc: [EMAIL PROTECTED]; linux-omap@vger.kernel.org; [EMAIL PROTECTED] Subject: Re: [PATCH] MUSB: BULK request on different available endpoints On Monday

RE: [PATCH 2/3] musb: adding qh in_list and out_list in struct hw_ep

2008-10-30 Thread Gupta, Ajay Kumar
hw_ep-regs = MUSB_EP_OFFSET(i, 0) + mbase; #ifdef CONFIG_USB_MUSB_HDRC_HCD + /* init list of in and out qhs */ + INIT_LIST_HEAD(hw_ep-in_list); + INIT_LIST_HEAD(hw_ep-out_list); hw_ep-target_regs =

RE: [PATCH 2/3] musb: adding qh in_list and out_list in struct hw_ep

2008-10-30 Thread Gupta, Ajay Kumar
if (qh-type == USB_ENDPOINT_XFER_CONTROL) { - head = musb-control; hw_ep = musb-control_ep; + head = hw_ep-in_list; So we only support control in transfer and no hope for control out here? Control transfer requires only one list

RE: [PATCH 1/3] musb: NAK timeout scheme on bulk reserved ep

2008-11-03 Thread Gupta, Ajay Kumar
On Thu, Oct 30, 2008 at 02:42:22PM +0530, Ajay Kumar Gupta wrote: Fixes endpoint starvation issue when more than one bulk qhs are multiplexed on reserved bulk endpoint.NAK timeout interval is set for such qhs and next qh is scheduled when NAK timeout occurs. This scheme doesn't work for

RE: [PATCH 1/2] musb: add musb support for AM35x

2010-03-14 Thread Gupta, Ajay Kumar
Hi, AM35x has musb interface and uses CPPI4.1 DMA engine. Current patch supports only PIO mode and there are on-going discussions on location of CPPI4.1 DMA. Signed-off-by: Ajay Kumar Gupta ajay.gu...@ti.com tristate 'Inventra Highspeed Dual Role Controller (TI, ADI, ...)' @@

RE: [PATCH] AM35x: Add musb support

2010-03-20 Thread Gupta, Ajay Kumar
Hi, AM35x has musb interface (version 1.8) and uses CPPI41 DMA engine. It supports upto 500mA of power in host mode. Signed-off-by: Ajay Kumar Gupta ajay.gu...@ti.com --- Created against latest l-o master branch and below patches. [1] AM35xx: Add clock support for new modules on AM35xx [2]

RE: [PATCH] AM35x: Add musb support

2010-03-22 Thread Gupta, Ajay Kumar
Hi, +/* USB 2.0 OTG module registers */ +#define USB_REVISION_REG 0x00 +#define USB_CTRL_REG 0x04 +#define USB_STAT_REG 0x08 +#define USB_EMULATION_REG0x0c +/* 0x10 Reserved */ Wait... so the mode register isn't supported? Does AM35x support any

RE: [PATCH] AM35x: Add musb support

2010-03-22 Thread Gupta, Ajay Kumar
Hi, I have not added CPPI4.1 DMA specific register here.. Ah. Then they're not compatible with DA8xx anyway... We could make it compatible with some change as done at, http://arago-project.org/git/people/?p=sriram/ti-psp-

RE: [PATCH] AM35x: Add musb support

2010-03-22 Thread Gupta, Ajay Kumar
Hi, It is being used from plat/usb.h. I haven't found where it's included. It's from cppi41_dma.h. Well, you've removed the register #define's from cppi41_dma.h and #includ'ed plat/usb.h Correct. BUT there's certainly no such header for DA8xx , so as I suspected

RE: [PATCH] musb: fix power field to hold all possible values

2010-03-23 Thread Gupta, Ajay Kumar
Hi, -Original Message- From: linux-omap-ow...@vger.kernel.org [mailto:linux-omap- ow...@vger.kernel.org] On Behalf Of Gupta, Ajay Kumar Sent: Friday, February 26, 2010 10:03 AM To: Tony Lindgren; Felipe Balbi Cc: linux-omap@vger.kernel.org Subject: RE: [PATCH] musb: fix power field

RE: [PATCH] musb: Add extvbus in musb_board_data

2010-03-23 Thread Gupta, Ajay Kumar
Hi, -Original Message- From: Gupta, Ajay Kumar Sent: Wednesday, February 24, 2010 10:01 AM To: linux-omap@vger.kernel.org Cc: felipe.ba...@nokia.com; Gupta, Ajay Kumar Subject: [PATCH] musb: Add extvbus in musb_board_data EXTVBUS programming is required by OMAP3EVM REV =E

RE: omap_musb_board_data -- trouble specifying 500mA supply

2010-04-28 Thread Gupta, Ajay Kumar
Hi, -Original Message- From: linux-omap-ow...@vger.kernel.org [mailto:linux-omap- ow...@vger.kernel.org] On Behalf Of Cliff Brake Sent: Wednesday, April 28, 2010 7:40 PM To: Linux OMAP Users Subject: omap_musb_board_data -- trouble specifying 500mA supply Hello, We are

RE: omap_musb_board_data -- trouble specifying 500mA supply

2010-04-28 Thread Gupta, Ajay Kumar
Hi, -Original Message- From: linux-omap-ow...@vger.kernel.org [mailto:linux-omap- ow...@vger.kernel.org] On Behalf Of Cliff Brake Sent: Wednesday, April 28, 2010 7:40 PM To: Linux OMAP Users Subject: omap_musb_board_data -- trouble specifying 500mA supply Hello, We are

RE: Re: [PATCH 2/2 v2] USB: musb: disable double buffering for older

2010-05-03 Thread Gupta, Ajay Kumar
Hi, Kroah-Hartman; Subbrathnam, Swaminathan Subject: Re: [PATCH 2/2 v2] USB: musb: disable double buffering for older RTL versions On Tue, Apr 06, 2010 at 01:46:29PM +0200, ext Gadiyar, Anand wrote: With g_zero, do you see a hang or do you have data corruption? data corruption.

RE: Re: omap_musb_board_data -- trouble specifying 500mA supply

2010-05-03 Thread Gupta, Ajay Kumar
Hi, -Original Message- From: linux-omap-ow...@vger.kernel.org [mailto:linux-omap- ow...@vger.kernel.org] On Behalf Of Cliff Brake Sent: Wednesday, April 28, 2010 7:40 PM To: Linux OMAP Users Subject: omap_musb_board_data -- trouble specifying 500mA supply Hello, We are

  1   2   3   >