Re: AM335x, early printk

2013-08-19 Thread Jean Pihet
Hi! You need to add 'earlyprintk' in the kernel command line, given (I suppose) by U-Boot. I hope this helps! Jean On Mon, Aug 19, 2013 at 1:21 PM, Sebastian Andrzej Siewior bige...@linutronix.de wrote: Hi, I activated: [*] Kernel low-level debugging functions Kernel low-level

Re: [PATCH 2/2] ARM: OMAP2+: Drop plat/cpu.h for omap2plus

2012-12-17 Thread Jean Pihet
the unused plat/cpu.h from smartreflex.c and isp.c as they will cause compile errors with ARCH_MULTIPLATFORM enabled. Cc: Jean Pihet jean.pi...@newoldbits.com Cc: Kevin Hilman khil...@deeprootsystems.com Cc: Laurent Pinchart laurent.pinch...@ideasonboard.com Cc: Mauro Carvalho Chehab mche

Re: [PATCH 1/8] ARM: OMAP2+: PM QoS: control the power domains next state from the constraints

2012-12-14 Thread Jean Pihet
Hi Paul, On Tue, Dec 11, 2012 at 1:05 AM, Paul Walmsley p...@pwsan.com wrote: Hi On Tue, 18 Sep 2012, Jean Pihet wrote: When a PM QoS device latency constraint is requested or removed the constraint is stored in the constraints list of the corresponding power domain, then the aggregated

Re: [RFC 1/5] ARM: CORESIGHT: Add generic lock/unlock helpers

2012-12-13 Thread Jean Pihet
Hi Jon, Will, On Thu, Dec 13, 2012 at 8:18 PM, Jon Hunter jon-hun...@ti.com wrote: On 12/13/2012 08:58 AM, Will Deacon wrote: Hi Jon, On Wed, Dec 12, 2012 at 09:43:04PM +, Jon Hunter wrote: The Cross Trigger Interface (CTI) helpers in cti.h include definitions for the Coresight Lock

Re: [PATCH 06/10] ARM: OMAP2+: powerdomain/clockdomain: add a per-powerdomain spinlock

2012-12-12 Thread Jean Pihet
Paul, -resending in plain text only, sorry about that- On Sun, Dec 9, 2012 at 2:23 AM, Paul Walmsley p...@pwsan.com wrote: Add a per-powerdomain spinlock. Use that instead of the clockdomain spinlock. Add pwrdm_lock()/pwrdm_unlock() functions to allow other code to acquire or release the

Re: [PATCH 05/12] ARM: OMAP3xxx: PM: convert to use the functional power states API

2012-12-12 Thread Jean Pihet
Paul, -resending in plain text only, sorry about that- On Sun, Dec 9, 2012 at 6:53 PM, Paul Walmsley p...@pwsan.com wrote: From: Jean Pihet jean.pi...@newoldbits.com Use the functional power states as the API to control power domains: - use the PWRDM_FUNC_PWRST_* macros for the power

Re: [PATCH 05/10] ARM: OMAP2+: PM/powerdomain: move omap_set_pwrdm_state() to powerdomain code

2012-12-12 Thread Jean Pihet
it to conform with the existing powerdomain function names. Glad to see this rather cryptic function getting a rewrite. It had never been clear what the function is doing so I think it owes some more comments. More comments below. Signed-off-by: Paul Walmsley p...@pwsan.com Cc: Jean Pihet jean.pi

Re: [PATCH 02/12] ARM: OMAP2+: PM: introduce power domains functional states

2012-12-12 Thread Jean Pihet
Hi Paul, -resending in plain text only, sorry about that- On Sun, Dec 9, 2012 at 6:53 PM, Paul Walmsley p...@pwsan.com wrote: From: Jean Pihet jean.pi...@newoldbits.com Introduce the functional states for power domains, which include the power states and the logic states. This patch

Re: [PATCH 06/12] ARM: OMAP44xx: PM: convert to use the functional power states API

2012-12-12 Thread Jean Pihet
Paul, On Sun, Dec 9, 2012 at 6:53 PM, Paul Walmsley p...@pwsan.com wrote: From: Jean Pihet jean.pi...@newoldbits.com Use the functional power states as the API to control power domains: - use the PWRDM_FUNC_PWRST_* and PWRDM_LOGIC_MEM_PWRST_* macros for the power states and logic settings

Re: [PATCH 07/12] ARM: OMAP2+: PM: use power domain functional state in stats counters

2012-12-12 Thread Jean Pihet
Paul, On Sun, Dec 9, 2012 at 6:53 PM, Paul Walmsley p...@pwsan.com wrote: From: Jean Pihet jean.pi...@newoldbits.com The PM code uses some counters to keep track of the power domains transitions, in order to provide the information to drivers (in pwrdm_get_context_loss_count) and to expose

Re: [PATCHv2] i2c: omap: Move the remove constraint

2012-11-15 Thread Jean Pihet
busy as we are sure that the transfers are completed by then. Signed-off-by: Shubhrajyoti D shubhrajy...@ti.com Looks good! Acked-by: Jean Pihet j-pi...@ti.com Regards, Jean --- v2: rebase to the for-next branch drivers/i2c/busses/i2c-omap.c |7 --- 1 files changed, 4 insertions

Re: [PATCHv2] i2c: omap: Move the remove constraint

2012-11-15 Thread Jean Pihet
On Thu, Nov 15, 2012 at 9:51 AM, Shubhrajyoti Datta omaplinuxker...@gmail.com wrote: On Thu, Nov 15, 2012 at 1:46 PM, Jean Pihet jean.pi...@newoldbits.com wrote: Hi Shubhrajyoti, On Thu, Nov 15, 2012 at 8:34 AM, Shubhrajyoti D shubhrajy...@ti.com wrote: Currently we just queue the transfer

Re: AM335x: Beaglebone stops to boot with current git kernel

2012-11-15 Thread Jean Pihet
Hi Tony, On Wed, Nov 14, 2012 at 6:51 PM, Tony Lindgren t...@atomide.com wrote: * Jean Pihet jean.pi...@newoldbits.com [121114 08:43]: The patch should change the name of the hwmod entry as well, can you fold this change in the current patch? This was caused by the merge of omap-for-v3.8/pm

Re: [PATCH] Revert ARM: OMAP: convert I2C driver to PM QoS for MPU latency constraints

2012-11-14 Thread Jean Pihet
Hi Wolfram, On Wed, Nov 14, 2012 at 11:51 AM, Wolfram Sang w.s...@pengutronix.de wrote: On Tue, Nov 06, 2012 at 04:31:32PM +, Paul Walmsley wrote: This reverts commit 3db11feffc1ad2ab9dea27789e6b5b3032827adc. Here giving the patch name in parens would have really made sense. Will fix

Re: [PATCH] i2c: omap: Move the remove constraint

2012-11-14 Thread Jean Pihet
the bus busy as we are sure that the transfers are completed by then. Signed-off-by: Shubhrajyoti D shubhrajy...@ti.com Good catch, the change definitely makes sense. Feel free to add: Acked-by: Jean Pihet j-pi...@ti.com Since I just reverted the QoS patch, I suppose this gets merged

Re: AM335x: Beaglebone stops to boot with current git kernel

2012-11-14 Thread Jean Pihet
Hi, On Wed, Nov 14, 2012 at 4:28 PM, Igor Mazanov i.maza...@gmail.com wrote: Hello, Beaglebone boot process is broken with the current git kernel. I use omap2plus_defconfig for tests. It looks like the boot process stops due to the last changes in the AM33xx clock sysbsystem. A following

Re: OMAP baseline test results for v3.7-rc1

2012-11-06 Thread Jean Pihet
Hi Kevin, Paul, On Tue, Nov 6, 2012 at 1:01 AM, Kevin Hilman khil...@deeprootsystems.com wrote: Jean Pihet jean.pi...@newoldbits.com writes: [...] I ran some intensive stress tests on the I2C and ... unfortunately I could not trigger the problem. It looks like the issue is caused by some

Re: [PATCH] i2c: omap: Move the remove constraint

2012-11-06 Thread Jean Pihet
are sure that the transfers are completed by then. Signed-off-by: Shubhrajyoti D shubhrajy...@ti.com Good catch, the change definitely makes sense. Feel free to add: Acked-by: Jean Pihet j-pi...@ti.com Thanks, Jean. --- drivers/i2c/busses/i2c-omap.c |6 +++--- 1 files changed, 3

Re: [PATCH] Revert ARM: OMAP: convert I2C driver to PM QoS for MPU latency constraints

2012-11-06 Thread Jean Pihet
=linux-arm-kernelm=135067558415214w=2 http://marc.info/?l=linux-arm-kernelm=135216013608196w=2 and appears to have been sent for merging before one of its prerequisites was merged: http://marc.info/?l=linux-arm-kernelm=135219411617621w=2 Indeed. Acked-by: Jean Pihet j-pi...@ti.com

Re: OMAP baseline test results for v3.7-rc1

2012-11-05 Thread Jean Pihet
Paul, On Mon, Nov 5, 2012 at 4:15 AM, Paul Walmsley p...@pwsan.com wrote: Hi Jean, On Sat, 3 Nov 2012, Jean Pihet wrote: The setup is as identical as possible to yours: - U-Boot 2011.06-dirty (Sep 04 2012 - 17:06:58) from http://www.pwsan.com/tmp/3530es3beagle-MLO-u-boot-20121023.tar.bz2

Re: [RFC PATCH 0/6] ARM: OMAP3+: move smartreflex-class3.c to drivers/power/avs

2012-11-03 Thread Jean Pihet
Hi Nishant, On Sat, Nov 3, 2012 at 2:14 PM, Kevin Hilman khil...@deeprootsystems.com wrote: Hi Nishanth, On 10/25/2012 09:21 AM, Jean Pihet wrote: Hi Nishant, On Tue, Oct 23, 2012 at 11:43 PM, Nishanth Menon n...@ti.com wrote: smartreflex.c now resides in drivers/power/avs directory

Re: OMAP baseline test results for v3.7-rc1

2012-11-03 Thread Jean Pihet
Hi Paul, On Thu, Nov 1, 2012 at 8:51 AM, Jean Pihet jean.pi...@newoldbits.com wrote: Hi Paul, On Wed, Oct 31, 2012 at 10:44 PM, Paul Walmsley p...@pwsan.com wrote: Hi On Wed, 31 Oct 2012, Jean Pihet wrote: Paul, Could you please check with the 2 calls to PM QoS from the I2C code

Re: OMAP baseline test results for v3.7-rc1

2012-11-01 Thread Jean Pihet
Hi Paul, On Wed, Oct 31, 2012 at 10:44 PM, Paul Walmsley p...@pwsan.com wrote: Hi On Wed, 31 Oct 2012, Jean Pihet wrote: Paul, Could you please check with the 2 calls to PM QoS from the I2C code commented out? This will rule out the PM QoS impact. Will be happy to do a test run for you

Re: OMAP baseline test results for v3.7-rc1

2012-10-31 Thread Jean Pihet
Hi Paul, On Tue, Oct 30, 2012 at 7:23 AM, Paul Walmsley p...@pwsan.com wrote: Hi Jean, On Tue, 30 Oct 2012, Jean Pihet wrote: On Tue, Oct 30, 2012 at 5:16 AM, Paul Walmsley p...@pwsan.com wrote: On Tue, 23 Oct 2012, Jean Pihet wrote: Let me try with the same setup as yours (bootloader

Re: OMAP baseline test results for v3.7-rc1

2012-10-31 Thread Jean Pihet
On Tue, Oct 30, 2012 at 9:17 AM, Paul Walmsley p...@pwsan.com wrote: On Tue, 30 Oct 2012, Felipe Balbi wrote: On Tue, Oct 30, 2012 at 12:50:52PM +, Paul Walmsley wrote: certainly PM-idle related, given that the problem goes away by reverting Jean's commit

Re: OMAP baseline test results for v3.7-rc1

2012-10-31 Thread Jean Pihet
Paul, - Added Rafael for the PM QoS discussion - On Tue, Oct 30, 2012 at 10:04 AM, Paul Walmsley p...@pwsan.com wrote: On Tue, 30 Oct 2012, Paul Walmsley wrote: Based on a very quick look, I'd say the original patch 3db11fe is broken. I don't see how it can ensure that its

Re: OMAP baseline test results for v3.7-rc1

2012-10-31 Thread Jean Pihet
Hi Kevin, On Wed, Oct 31, 2012 at 6:49 AM, Kevin Hilman khil...@deeprootsystems.com wrote: Hi Jean, Jean Pihet jean.pi...@newoldbits.com writes: [...] Based on a very quick look, I'd say the original patch 3db11fe is broken. I don't see how it can ensure that its PM_QOS_CPU_DMA_LATENCY

Re: OMAP baseline test results for v3.7-rc1

2012-10-30 Thread Jean Pihet
Hi Paul, On Tue, Oct 30, 2012 at 5:16 AM, Paul Walmsley p...@pwsan.com wrote: Hello Jean, On Tue, 23 Oct 2012, Jean Pihet wrote: Let me try with the same setup as yours (bootloader images, omap2pus_defconfig, angstrom roots). Had any luck reproducing this one that Aaro I are seeing

Re: [RFC PATCH 0/6] ARM: OMAP3+: move smartreflex-class3.c to drivers/power/avs

2012-10-25 Thread Jean Pihet
OK with the changes besides remarks sent on the patches: Acked-by: Jean Pihet j-pi...@ti.com I let Kevin comment on the VC/VP aspect though. This series *does not* try to fix VP/VC to be voltage regulator OR introduce a new OMAP voltage regulator series. instead, it purely tries to do

Re: [RFC PATCH 4/6] ARM: OMAP: SmartReflex: provide SoC integration API for VP

2012-10-25 Thread Jean Pihet
Nishant, On Tue, Oct 23, 2012 at 11:43 PM, Nishanth Menon n...@ti.com wrote: SoC integration of SmartReflex AVS block is varied. Some use Voltage Processor for a hardware loop in certain OMAP SoC (called hardware loop), while others have just the AVS block without hardware loop automatic

Re: OMAP baseline test results for v3.7-rc1

2012-10-23 Thread Jean Pihet
On Tue, Oct 23, 2012 at 9:19 PM, Paul Walmsley p...@pwsan.com wrote: On Mon, 22 Oct 2012, Jean Pihet wrote: On Mon, Oct 22, 2012 at 6:12 PM, Jean Pihet jean.pi...@newoldbits.com wrote: Do you have CPU_IDLE enabled? FYI the issue is not present with CPU_IDLE enabled. Hmm, how can you

Re: OMAP baseline test results for v3.7-rc1

2012-10-22 Thread Jean Pihet
by: commit 3db11feffc1ad2ab9dea27789e6b5b3032827adc Author: Jean Pihet jean.pi...@newoldbits.com Date: Thu Sep 20 18:08:03 2012 +0200 ARM: OMAP: convert I2C driver to PM QoS for MPU latency constraints Reverting this commit causes the problem to go away, but since the OMAP PM constraint code

Re: OMAP baseline test results for v3.7-rc1

2012-10-22 Thread Jean Pihet
On Mon, Oct 22, 2012 at 6:12 PM, Jean Pihet jean.pi...@newoldbits.com wrote: Hi, On Sat, Oct 20, 2012 at 8:14 AM, Paul Walmsley p...@pwsan.com wrote: Hi Jean On Fri, 19 Oct 2012, Paul Walmsley wrote: On Thu, 18 Oct 2012, Paul Walmsley wrote: Here are some basic OMAP test results

Re: [PATCH] ARM: OMAP: convert I2C driver to PM QoS for MPU latency constraints

2012-10-08 Thread Jean Pihet
On Sat, Oct 6, 2012 at 1:46 PM, Wolfram Sang w.s...@pengutronix.de wrote: On Thu, Sep 20, 2012 at 06:08:03PM +0200, Jean Pihet wrote: Convert the driver from the outdated omap_pm_set_max_mpu_wakeup_lat API to the new PM QoS API. Since the constraint is on the MPU subsystem, use

Re: [PATCH 0/2] ARM: OMAP: SmartReflex: pass device dependent data via platform data

2012-10-05 Thread Jean Pihet
On Fri, Oct 5, 2012 at 1:40 AM, Kevin Hilman khil...@deeprootsystems.com wrote: jean.pi...@newoldbits.com writes: From: Jean Pihet j-pi...@ti.com Remove the device dependent code (ex. cpu_is_xxx()) and settings from the driver code and instead pass them via the platform data. This allows

[PATCH 0/2] ARM: OMAP: SmartReflex: pass device dependent data via platform data

2012-10-04 Thread jean . pihet
From: Jean Pihet j-pi...@ti.com Remove the device dependent code (ex. cpu_is_xxx()) and settings from the driver code and instead pass them via the platform data. This allows a clean separation of the driver code and the platform code, as required by the move of the platform header files

[PATCH 1/2] ARM: OMAP: hwmod: align the SmartReflex fck names

2012-10-04 Thread jean . pihet
From: Jean Pihet j-pi...@ti.com Rename the smartreflex fck names for consistency and better readability; rename the clock aliases so that they match the hwmod main_clk names. Signed-off-by: Jean Pihet j-pi...@ti.com --- arch/arm/mach-omap2/clock33xx_data.c | 12 ++-- arch/arm

[PATCH 2/2] ARM: OMAP: SmartReflex: pass device dependent data via platform data

2012-10-04 Thread jean . pihet
From: Jean Pihet j-pi...@ti.com Remove the device dependent code (ex. cpu_is_xxx()) and settings from the driver code and instead pass them via the platform data. This allows a clean separation of the driver code and the platform code, as required by the move of the platform header files

Re: [PATCH 1/2] ARM: OMAP: hwmod: align the SmartReflex fck names

2012-10-04 Thread Jean Pihet
Hi Kevin, On Thu, Oct 4, 2012 at 2:33 AM, Kevin Hilman khil...@deeprootsystems.com wrote: Tony Lindgren t...@atomide.com writes: * jean.pi...@newoldbits.com jean.pi...@newoldbits.com [121003 08:48]: @@ -1036,8 +1036,8 @@ static struct omap_clk am33xx_clks[] = { CLK(davinci-mcasp.1,

Re: [PATCH 2/2] ARM: OMAP: SmartReflex: pass device dependent data via platform data

2012-10-03 Thread Jean Pihet
Hi Kevin, On Wed, Oct 3, 2012 at 12:21 AM, Kevin Hilman khil...@deeprootsystems.com wrote: Hi Jean, Jean Pihet jean.pi...@newoldbits.com writes: Remove the device dependent settings (cpu_is_xxx(), IP fck etc.) from the driver code and pass them instead via the platform data. This allows

[PATCH 2/2] ARM: OMAP: SmartReflex: pass device dependent data via platform data

2012-10-03 Thread jean . pihet
From: Jean Pihet j-pi...@ti.com Remove the device dependent code (ex. cpu_is_xxx()) and settings from the driver code and instead pass them via the platform data. This allows a clean separation of the driver code and the platform code, as required by the move of the platform header files

[PATCH 0/2] ARM: OMAP: SmartReflex: pass device dependent data via platform data

2012-10-03 Thread jean . pihet
From: Jean Pihet j-pi...@ti.com Remove the device dependent code (ex. cpu_is_xxx()) and settings from the driver code and instead pass them via the platform data. This allows a clean separation of the driver code and the platform code, as required by the move of the platform header files

[PATCH 1/2] ARM: OMAP: hwmod: align the SmartReflex fck names

2012-10-03 Thread jean . pihet
From: Jean Pihet j-pi...@ti.com Rename the smartreflex fck names for consistency and better readability; rename the clock aliases for use by the SmartReflex driver, with the smartreflex.%d format. Signed-off-by: Jean Pihet j-pi...@ti.com --- arch/arm/mach-omap2/clock33xx_data.c | 12

[PATCH 2/2] ARM: OMAP: SmartReflex: pass device dependent data via platform data

2012-10-03 Thread jean . pihet
From: Jean Pihet j-pi...@ti.com Remove the device dependent code (ex. cpu_is_xxx()) and settings from the driver code and instead pass them via the platform data. This allows a clean separation of the driver code and the platform code, as required by the move of the platform header files

Re: [PATCH 2/2] ARM: OMAP: SmartReflex: pass device dependent data via platform data

2012-10-03 Thread Jean Pihet
Kevin, On Wed, Oct 3, 2012 at 4:29 PM, Kevin Hilman khil...@deeprootsystems.com wrote: jean.pi...@newoldbits.com writes: From: Jean Pihet j-pi...@ti.com Remove the device dependent code (ex. cpu_is_xxx()) and settings from the driver code and instead pass them via the platform data

Re: [PATCH 1/2] ARM: OMAP: hwmod: align the SmartReflex fck names

2012-10-03 Thread Jean Pihet
Hi Tony, On Wed, Oct 3, 2012 at 7:00 PM, Tony Lindgren t...@atomide.com wrote: * jean.pi...@newoldbits.com jean.pi...@newoldbits.com [121003 08:48]: @@ -1036,8 +1036,8 @@ static struct omap_clk am33xx_clks[] = { CLK(davinci-mcasp.1, NULL, mcasp1_fck,CK_AM33XX),

Re: [PATCH] ARM: OMAP2+: SmartReflex: fix return value check in sr_dev_init()

2012-09-28 Thread Jean Pihet
: Acked-by: Jean Pihet j-pi...@ti.com Thanks, Jean -- To unsubscribe from this list: send the line unsubscribe linux-omap in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html -- To unsubscribe from this list: send the line

Re: [PATCH] ARM: OMAP2+: PM: fix return value check in omap2_set_init_voltage()

2012-09-28 Thread Jean Pihet
) { pr_err(%s: unable to get vdd pointer for vdd_%s\n, __func__, vdd_name); goto exit; This looks good, so here is the ack: Acked-by: Jean Pihet j-pi...@ti.com Thanks, Jean -- To unsubscribe from this list: send the line unsubscribe linux-omap in the body

Re: [PATCH 2/2] ARM: OMAP: SmartReflex: pass device dependent data via platform data

2012-09-24 Thread Jean Pihet
Hi Tony, On Fri, Sep 21, 2012 at 9:07 PM, Tony Lindgren t...@atomide.com wrote: * Jean Pihet jean.pi...@newoldbits.com [120920 23:31]: On Fri, Sep 21, 2012 at 12:15 AM, Tony Lindgren t...@atomide.com wrote: You should be able to make this even simpler and not have to pass the clock name

[PATCH 0/2] ARM: OMAP: SmartReflex: pass device dependent data via platform data

2012-09-24 Thread Jean Pihet
. The patch also includes a fix of the error handling path in omap_sr_probe to correctly de-allocate resources in case of problems. $SUBJECT requires this change. Jean Pihet (2): ARM: OMAP: SmartReflex: fix error path in init function ARM: OMAP: SmartReflex: pass device dependent data via platform data

[PATCH 1/2] ARM: OMAP: SmartReflex: fix error path in init function

2012-09-24 Thread Jean Pihet
Fix the error handling path in omap_sr_probe to correctly de-allocate resources in case of problems. Signed-off-by: Jean Pihet j-pi...@ti.com --- drivers/power/avs/smartreflex.c |8 1 files changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/power/avs/smartreflex.c b

[PATCH 2/2] ARM: OMAP: SmartReflex: pass device dependent data via platform data

2012-09-24 Thread Jean Pihet
-off-by: Jean Pihet j-pi...@ti.com --- arch/arm/mach-omap2/sr_device.c | 13 drivers/power/avs/smartreflex.c | 40 ++-- include/linux/power/smartreflex.h | 14 +++- 3 files changed, 36 insertions(+), 31 deletions(-) diff --git a/arch/arm

Re: [PATCH] ARM: OMAP: hwmod: align the SmartReflex fck names

2012-09-24 Thread Jean Pihet
Hi Paul, Kevin, On Thu, Sep 20, 2012 at 11:48 AM, Jean Pihet jean.pi...@newoldbits.com wrote: Rename the smartreflex fck names: - for consistency and better readability, - for use by the SmartReflex driver, through the hwmod .main_clk field. Signed-off-by: Jean Pihet j-pi...@ti.com

[PATCH] ARM: OMAP: hwmod: align the SmartReflex fck names

2012-09-24 Thread Jean Pihet
Rename the smartreflex fck names for consistency and better readability; rename the clock aliases for use by the SmartReflex driver, with the smartreflex.%d format. Signed-off-by: Jean Pihet j-pi...@ti.com --- arch/arm/mach-omap2/clock33xx_data.c | 12 ++-- arch/arm/mach-omap2

Re: [PATCH 2/2] ARM: OMAP: SmartReflex: pass device dependent data via platform data

2012-09-21 Thread Jean Pihet
Hi Tony, On Fri, Sep 21, 2012 at 12:15 AM, Tony Lindgren t...@atomide.com wrote: Hi, * Jean Pihet jean.pi...@newoldbits.com [120920 07:48]: --- a/drivers/power/avs/smartreflex.c +++ b/drivers/power/avs/smartreflex.c @@ -131,14 +131,11 @@ static void sr_set_clk_length(struct omap_sr *sr

[PATCH] ARM: OMAP: hwmod: align the SmartReflex fck names

2012-09-20 Thread Jean Pihet
Rename the smartreflex fck names: - for consistency and better readability, - for use by the SmartReflex driver, through the hwmod .main_clk field. Signed-off-by: Jean Pihet j-pi...@ti.com --- arch/arm/mach-omap2/clock3xxx_data.c | 12 ++-- arch/arm/mach-omap2

[PATCH] ARM: OMAP: SmartReflex: select CONFIG_POWER_SUPPLY in Kconfig

2012-09-20 Thread jean . pihet
From: Jean Pihet j-pi...@ti.com Select POWER_SUPPLY from POWER_AVS_OMAP entry in Kconfig. This avoids the following build problems using a randconfig that has CONFIG_POWER_SUPPLY not set: LD init/built-in.o arch/arm/mach-omap2/built-in.o: In function `sr_class3_configure': arch/arm/mach

[PATCH 0/2] ARM: OMAP: SmartReflex: pass device dependent data via platform data

2012-09-20 Thread Jean Pihet
a fix of the error handling path in omap_sr_probe to correctly de-allocate resources in case of problems. $SUBJECT requires this change. Jean Pihet (2): ARM: OMAP: SmartReflex: fix error path in init function ARM: OMAP: SmartReflex: pass device dependent data via platform data arch/arm/mach

[PATCH 2/2] ARM: OMAP: SmartReflex: pass device dependent data via platform data

2012-09-20 Thread Jean Pihet
Remove the device dependent settings (cpu_is_xxx(), IP fck etc.) from the driver code and pass them instead via the platform data. This allows a clean separation of the driver code and the platform code. Signed-off-by: Jean Pihet j-pi...@ti.com --- arch/arm/mach-omap2/sr_device.c | 14

[PATCH 1/2] ARM: OMAP: SmartReflex: fix error path in init function

2012-09-20 Thread Jean Pihet
Fix the error handling path in omap_sr_probe to correctly de-allocate resources in case of problems. Signed-off-by: Jean Pihet j-pi...@ti.com --- drivers/power/avs/smartreflex.c |8 1 files changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/power/avs/smartreflex.c b

[PATCH] ARM: OMAP: convert I2C driver to PM QoS for MPU latency constraints

2012-09-20 Thread Jean Pihet
. The I2C device latency timing is derived from the FIFO size and the clock speed and so is applicable to all OMAP SoCs. Signed-off-by: Jean Pihet j-pi...@ti.com --- Rebased on git://git.pengutronix.de/git/wsa/linux.git, branch i2c-embedded/for-next --- arch/arm/plat-omap/i2c.c | 21

Re: [PATCH 7/8] ARM: OMAP: convert I2C driver to PM QoS for latency constraints

2012-09-19 Thread Jean Pihet
Hi! On Wed, Sep 19, 2012 at 8:11 PM, Shubhrajyoti shubhrajy...@ti.com wrote: On Tuesday 18 September 2012 02:22 PM, Jean Pihet wrote: Convert the driver from the outdated omap_pm_set_max_mpu_wakeup_lat API to the new PM QoS API. Since the constraint is on the MPU subsystem, use

[PATCH 1/8] ARM: OMAP2+: PM QoS: control the power domains next state from the constraints

2012-09-18 Thread Jean Pihet
to control the IP block idle state from the FIFO empty state, from interrupt context. Tested on OMAP3 Beagleboard and OMAP4 Pandaboard in RET/OFF using wake-up latency constraints on MPU, CORE and PER. Signed-off-by: Jean Pihet j-pi...@ti.com Cc: Djamil Elaidi d-ela...@ti.com --- arch/arm/mach-omap2

[PATCH v9 0/8] PM QoS: implement the OMAP low level constraints management code

2012-09-18 Thread Jean Pihet
the kerneldoc v2: reworked the OMAP specific cpuidle code to demote the initial C-state to a valid C-state which fulfills the per-device constraints v1: initial version Jean Pihet (8): ARM: OMAP2+: PM QoS: control the power domains next state from the constraints ARM: OMAP2+: hwmod

[PATCH 5/8] ARM: OMAP3: update cpuidle latency and threshold figures

2012-09-18 Thread Jean Pihet
some numbers when sys_clkreq and sys_offmode are supported Signed-off-by: Jean Pihet j-pi...@ti.com Reviewed-by: Kevin Hilman khil...@ti.com --- arch/arm/mach-omap2/cpuidle34xx.c | 54 ++-- 1 files changed, 39 insertions(+), 15 deletions(-) diff --git a/arch/arm

[PATCH 6/8] ARM: OMAP3: powerdomain data: add wake-up latency figures

2012-09-18 Thread Jean Pihet
/Power_Management_Device_Latencies_Measurement for a detailed explanation on where are the numbers coming from. Tested on OMAP3 Beagleboard in RET/OFF using wake-up latency constraints on MPU, CORE and PER. Signed-off-by: Jean Pihet j-pi...@ti.com Reviewed-by: Kevin Hilman khil...@ti.com --- arch/arm/mach

[PATCH 3/8] ARM: OMAP: omap_device: register to the per-device PM QoS framework

2012-09-18 Thread Jean Pihet
in RET/OFF using wake-up latency constraints on MPU, CORE and PER. Signed-off-by: Jean Pihet j-pi...@ti.com Cc: Paul Walmsley p...@pwsan.com --- arch/arm/plat-omap/omap_device.c | 81 +- 1 files changed, 80 insertions(+), 1 deletions(-) diff --git a/arch/arm

[PATCH 7/8] ARM: OMAP: convert I2C driver to PM QoS for latency constraints

2012-09-18 Thread Jean Pihet
. The I2C device latency timing is derived from the FIFO size and the clock speed and so is applicable to all OMAP SoCs. Signed-off-by: Jean Pihet j-pi...@ti.com --- arch/arm/plat-omap/i2c.c | 21 - drivers/i2c/busses/i2c-omap.c | 28 +--- include

[PATCH 8/8] ARM: OMAP: PM: remove the latency related functions from the API

2012-09-18 Thread Jean Pihet
/pm_qos.h and Documentation/power/pm_qos_interface.txt. Signed-off-by: Jean Pihet j-pi...@ti.com --- Documentation/arm/OMAP/omap_pm| 68 ++-- arch/arm/plat-omap/include/plat/omap-pm.h | 99 - arch/arm/plat-omap/omap-pm-noop.c | 88

[PATCH 2/8] ARM: OMAP2+: hwmod: manage the wake-up latency constraints

2012-09-18 Thread Jean Pihet
on OMAP3 Beagleboard and OMAP4 Pandaboard in RET/OFF using wake-up latency constraints on MPU, CORE and PER. Signed-off-by: Jean Pihet j-pi...@ti.com --- arch/arm/mach-omap2/omap_hwmod.c | 44 +- arch/arm/plat-omap/include/plat/omap_hwmod.h |5 +++ 2 files

Re: [PATCH v6 0/7] ARM: OMAP2+: PM: introduce the power domains functional states

2012-09-18 Thread Jean Pihet
Hi Paul, On Thu, Sep 13, 2012 at 9:04 AM, Jean Pihet jean.pi...@newoldbits.com wrote: On Thu, Sep 13, 2012 at 2:34 AM, Kevin Hilman khil...@deeprootsystems.com wrote: Jean Pihet jean.pi...@newoldbits.com writes: Here is a re-spin after some comments and suggestions after review

[PATCH] ARM: OMAP: SmartReflex: pass device dependent data via platform data

2012-09-14 Thread jean . pihet
From: Jean Pihet j-pi...@ti.com Remove the device dependent settings (cpu_is_xxx(), IP clock name) from the driver code and pass them instead via the platform data. This allows a clean separation of the driver code and the platform code. Signed-off-by: Jean Pihet j-pi...@ti.com --- arch/arm

[PATCH] ARM: OMAP: SmartReflex: fix error path in init function

2012-09-14 Thread jean . pihet
From: Jean Pihet j-pi...@ti.com Fix the error handling path in omap_sr_probe to correctly de-allocate resources in case of problems. Signed-off-by: Jean Pihet j-pi...@ti.com --- drivers/power/avs/smartreflex.c |8 1 files changed, 4 insertions(+), 4 deletions(-) diff --git

Re: [PATCH] ARM: OMAP: SmartReflex: fix error path in init function

2012-09-14 Thread Jean Pihet
Hi! On Fri, Sep 14, 2012 at 12:14 PM, jean.pi...@newoldbits.com wrote: From: Jean Pihet j-pi...@ti.com Fix the error handling path in omap_sr_probe to correctly de-allocate resources in case of problems. Please note that this patch applies on top of 'ARM: OMAP: SmartReflex: pass device

Re: [PATCH v6 0/7] ARM: OMAP2+: PM: introduce the power domains functional states

2012-09-13 Thread Jean Pihet
On Thu, Sep 13, 2012 at 2:34 AM, Kevin Hilman khil...@deeprootsystems.com wrote: Jean Pihet jean.pi...@newoldbits.com writes: Here is a re-spin after some comments and suggestions after review and discussions. Implement the functional states for the power domains: - unify the API to use

Re: [PATCH 5/7] ARM: OMAP2+: PM debug: trace the functional power domains states

2012-09-13 Thread Jean Pihet
HI Kevin, On Thu, Sep 13, 2012 at 1:47 AM, Kevin Hilman khil...@deeprootsystems.com wrote: Jean Pihet jean.pi...@newoldbits.com writes: Trace the power domain transitions using the functional power states, which include the power and logic states. Just to be clear, this means that a trace

Re: [PATCH 7/7] ARM: OMAP2+: PM: reorganize the powerdomain API in public and private parts

2012-09-13 Thread Jean Pihet
On Thu, Sep 13, 2012 at 2:11 AM, Kevin Hilman khil...@deeprootsystems.com wrote: Jean Pihet jean.pi...@newoldbits.com writes: The newly added code for functional power states re-defines the API to query and control the power domains settings. The API is now split in the following parts

Re: [PATCH 5/7] ARM: OMAP2+: PM debug: trace the functional power domains states

2012-09-13 Thread Jean Pihet
On Thu, Sep 13, 2012 at 1:47 AM, Kevin Hilman khil...@deeprootsystems.com wrote: Use of smp_processor_id() here will require the same care as pointed out by Roger Quadros in [PATCH] perf: Use raw_smp_processor_id insted of smp_processor_id. BTW it looks like get_cpu and put_cpu is the way to

[PATCH v6 0/7] ARM: OMAP2+: PM: introduce the power domains functional states

2012-09-12 Thread Jean Pihet
: - initial implementation, in RFC state Jean Pihet (6): ARM: OMAP2+: PM: introduce power domains functional states ARM: OMAP2+: PM: add a lock to protect the powerdomains next state ARM: OMAP2+: PM: use the functional power states API ARM: OMAP2+: PM: use power domain functional state in stats

[PATCH 1/7] ARM: OMAP2+: PM: introduce power domains functional states

2012-09-12 Thread Jean Pihet
as a guard against hardware implementations discrepancies, e.g. some power domains only support the RET logic state although reading the logic state registers (previous, current and next) always returns OFF. The DSS power domain on OMAP3 is an example. Signed-off-by: Jean Pihet j-pi...@ti.com Cc

[PATCH 2/7] ARM: OMAP2+: PM: add a lock to protect the powerdomains next state

2012-09-12 Thread Jean Pihet
the API functions can be called from atomic context (.i.e) either from cpuidle path or suspend path. [ambr...@ti.com: reported the atomic context issue and suggested to replace the initial mutex with a spinlock] Signed-off-by: Jean Pihet j-pi...@ti.com Reported-by: Ambresh K ambr...@ti.com

[PATCH 4/7] ARM: OMAP2+: PM: use power domain functional state in stats counters

2012-09-12 Thread Jean Pihet
-by: Jean Pihet j-pi...@ti.com --- arch/arm/mach-omap2/pm-debug.c| 15 --- arch/arm/mach-omap2/powerdomain.c | 12 ++-- arch/arm/mach-omap2/powerdomain.h |4 ++-- 3 files changed, 16 insertions(+), 15 deletions(-) diff --git a/arch/arm/mach-omap2/pm-debug.c b/arch/arm

[PATCH 5/7] ARM: OMAP2+: PM debug: trace the functional power domains states

2012-09-12 Thread Jean Pihet
Trace the power domain transitions using the functional power states, which include the power and logic states. While at it, fix the trace in the case a power domain did not hit the desired state, as reported by Paul Walmsley. Reported-by: Paul Walmsley p...@pwsan.com Signed-off-by: Jean Pihet j

[PATCH 3/7] ARM: OMAP2+: PM: use the functional power states API

2012-09-12 Thread Jean Pihet
instead of pwrdm_set_next_pwrst to program the power domains next states, - the function pwrdm_set_fpwrst, which programs the power domains power and logic settings, shall be used instead of omap_set_pwrdm_state. Signed-off-by: Jean Pihet j-pi...@ti.com --- arch/arm/mach-omap2/cpuidle34xx.c

[PATCH 6/7] ARM: OMAP2+: powerdomain: add error logs

2012-09-12 Thread Jean Pihet
From: Nishanth Menon n...@ti.com Silent failure makes debug hard. So, provide rate limited error messages in functional and oft-used code to prevent spam when something goes wrong. Signed-off-by: Nishanth Menon n...@ti.com --- arch/arm/mach-omap2/powerdomain.c | 177

[PATCH 7/7] ARM: OMAP2+: PM: reorganize the powerdomain API in public and private parts

2012-09-12 Thread Jean Pihet
header files is not part of this patch, this comes as a subsequent clean-up patch series. Signed-off-by: Jean Pihet j-pi...@ti.com --- arch/arm/mach-omap2/pm.c | 62 arch/arm/mach-omap2/pm.h |1 - arch/arm/mach-omap2/powerdomain.h | 112

Re: [PATCH] perf: Use pre-empt safe cpu_get/put insted of smp_processor_id

2012-09-06 Thread Jean Pihet
Hi Roger, On Fri, Aug 10, 2012 at 4:05 PM, Roger Quadros rog...@ti.com wrote: gets rid of below messages with CONFIG_DEBUG_PREEMPT enabled [ 28.832916] debug_smp_processor_id: 18 callbacks suppressed [ 28.832946] BUG: using smp_processor_id() in preemptible [] code:

Re: [PATCH] perf: Use pre-empt safe cpu_get/put insted of smp_processor_id

2012-09-06 Thread Jean Pihet
Fixed Paul's email address On Thu, Sep 6, 2012 at 8:56 PM, Jean Pihet jean.pi...@newoldbits.com wrote: Hi Roger, On Fri, Aug 10, 2012 at 4:05 PM, Roger Quadros rog...@ti.com wrote: gets rid of below messages with CONFIG_DEBUG_PREEMPT enabled [ 28.832916] debug_smp_processor_id: 18

Re: [PATCHv2 7/8] ir-rx51: Convert latency constraints to PM QoS API

2012-08-27 Thread Jean Pihet
, + PM_QOS_CPU_DMA_LATENCY, 10); Minor remark: it would be nice to have more detail on where the latency number 10 comes from. Is it fixed, is it linked to the baud rate etc? Here is my ack for the PM QoS API part: Acked-by: Jean Pihet j-pi...@ti.com Regards, Jean -- To unsubscribe from

Re: [PATCH 7/8] ir-rx51: Remove MPU wakeup latency adjustments

2012-08-24 Thread Jean Pihet
Hi Timo, On Fri, Aug 24, 2012 at 10:14 AM, Timo Kokkonen timo.t.kokko...@iki.fi wrote: Hi Jean, On 08/23/12 14:58, Jean Pihet wrote: Hi Timo, On Wed, Aug 22, 2012 at 9:50 PM, Timo Kokkonen timo.t.kokko...@iki.fi wrote: That is correct. The API to use is the PM QoS API which cpuidle uses

Re: [PATCH 7/8] ir-rx51: Remove MPU wakeup latency adjustments

2012-08-23 Thread Jean Pihet
Hi Timo, On Wed, Aug 22, 2012 at 9:50 PM, Timo Kokkonen timo.t.kokko...@iki.fi wrote: The ir-rx51 driver calls omap_pm_set_max_mpu_wakeup_lat() in order to avoid problems that occur when MPU goes to sleep in the middle of sending an IR code. Without such calls it takes ridiculously long for

[PATCH v5 0/8] ARM: OMAP2+: PM: introduce the power domains functional states

2012-08-15 Thread Jean Pihet
: - fix a bug in OMAP3 cpuidle which prevented the IO wake-ups in PER v2: - add the logic power states, - provide the power domains statistics by functional states v1: - initial implementation, in RFC state Jean Pihet (7): ARM: OMAP2+: PM: introduce power domains functional states ARM: OMAP2

[PATCH 1/8] ARM: OMAP2+: PM: introduce power domains functional states

2012-08-15 Thread Jean Pihet
and OMAP4 platforms are using common conversion routines. In the new API only the function pwrdm_set_next_fpwrst shall be used to change a power domain target state, along with the associated PWRDM_FUNC_* and PWRDM_LOGIC_* macros as the state parameters. Signed-off-by: Jean Pihet j-pi...@ti.com --- arch

[PATCH 2/8] ARM: OMAP2+: PM: introduce power domains achievable functional states

2012-08-15 Thread Jean Pihet
and reworked as per Nishant's suggestions. Signed-off-by: Jean Pihet j-pi...@ti.com Cc: Tero Kristo t-kri...@ti.com Cc: Nishanth Menon n...@ti.com --- arch/arm/mach-omap2/powerdomain.c | 152 +++-- arch/arm/mach-omap2/powerdomain.h |1 + 2 files changed, 130

[PATCH 3/8] ARM: OMAP2+: PM: add a lock to protect the powerdomains next state

2012-08-15 Thread Jean Pihet
pwrdm_set_next_fpwrst and pwrdm_read_next_fpwrst can be called from atomic context (.i.e) either from cpuidle path or suspend path. [ambr...@ti.com: reported the atomic context issue and suggested to replace the mutex with a spinlock] Signed-off-by: Jean Pihet j-pi...@ti.com Reported-by: Ambresh K ambr...@ti.com

[PATCH 4/8] ARM: OMAP2+: PM: use the functional power states API

2012-08-15 Thread Jean Pihet
be used instead of pwrdm_set_next_pwrst to program the power domains next states. Note: the internal code for power domains state management still uses the internal power states. Signed-off-by: Jean Pihet j-pi...@ti.com --- arch/arm/mach-omap2/cpuidle34xx.c | 58

[PATCH 6/8] ARM: OMAP2+: PM debug: trace the functional power domains states

2012-08-15 Thread Jean Pihet
Trace the power domain transitions using the functional power states, which include the power and logic states. While at it, fix the trace in the case a power domain did not hit the desired state, as reported by Paul Walmsley. Reported-by: Paul Walmsley p...@pwsan.com Signed-off-by: Jean Pihet j

[PATCH 8/8] ARM: OMAP2+: PM: reorganize the powerdomain API in public and private parts

2012-08-15 Thread Jean Pihet
. - the private or internal API, to be used by the low level PM code only: powerdomain*, pm-debug, hwmod, voltage, clockdomain. No functional change is introduced by this patch. Signed-off-by: Jean Pihet j-pi...@ti.com --- arch/arm/mach-omap2/powerdomain.h | 119

[PATCH 7/8] ARM: OMAP2+: powerdomain: add error logs

2012-08-15 Thread Jean Pihet
From: Nishanth Menon n...@ti.com Silent failure makes debug hard. So, provide rate limited error messages in functional and oft-used code to prevent spam when something goes wrong.. Signed-off-by: Nishanth Menon n...@ti.com --- arch/arm/mach-omap2/powerdomain.c | 72

[PATCH 5/8] ARM: OMAP2+: PM: use power domain functional state in stats counters

2012-08-15 Thread Jean Pihet
-by: Jean Pihet j-pi...@ti.com --- arch/arm/mach-omap2/pm-debug.c| 15 --- arch/arm/mach-omap2/powerdomain.c | 12 ++-- arch/arm/mach-omap2/powerdomain.h |4 ++-- 3 files changed, 16 insertions(+), 15 deletions(-) diff --git a/arch/arm/mach-omap2/pm-debug.c b/arch/arm

  1   2   3   4   5   6   7   8   9   10   >