Re: [PATCH 4/6] pinctrl: single: Add support for wake-up interrupts

2013-10-11 Thread Linus Walleij
On Thu, Oct 10, 2013 at 6:20 PM, Tony Lindgren t...@atomide.com wrote: * Linus Walleij linus.wall...@linaro.org [131010 09:19]: On Thu, Oct 10, 2013 at 6:00 PM, Tony Lindgren t...@atomide.com wrote: * Roger Quadros rog...@ti.com [131010 06:32]: I tried testing this with the USB EHCI driver

Re: [PATCH 4/6] pinctrl: single: Add support for wake-up interrupts

2013-10-11 Thread Linus Walleij
into the places where it's actually used, like the clock driver etc. The accessor functions to do some stuff over in the PRCMU was just adding a layer of cruft. Yours, Linus Walleij -- To unsubscribe from this list: send the line unsubscribe linux-omap in the body of a message to majord

Re: [PATCH 4/6] pinctrl: single: Add support for wake-up interrupts

2013-10-11 Thread Linus Walleij
On Fri, Oct 11, 2013 at 5:43 PM, Tony Lindgren t...@atomide.com wrote: * Linus Walleij linus.wall...@linaro.org [131011 03:40]: On Fri, Oct 11, 2013 at 10:56 AM, Roger Quadros rog...@ti.com wrote: The register handling is fine. But how do we deal with resource handling? e.g. the block

Re: [PATCH] pinctrl: single: call pcs_soc-rearm() whenever IRQ mask is changed

2013-10-11 Thread Linus Walleij
patches: Acked-by. Yours, Linus Walleij -- To unsubscribe from this list: send the line unsubscribe linux-omap in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH 1/1] gpio/omap: use gpiolib API to mark a GPIO used as an IRQ

2013-10-16 Thread Linus Walleij
to be maintained locally for 1) though. Signed-off-by: Javier Martinez Canillas javier.marti...@collabora.co.uk Patch applied. I had to merge in v3.12-rc4 to get the dependency fixes, so I guess you did something similar when developing this... Yours, Linus Walleij -- To unsubscribe from this list: send

Re: [PATCH 1/2] leds: lp55xx: handle enable pin in driver

2013-10-22 Thread Linus Walleij
of the enable pin. Signed-off-by: Sebastian Reichel s...@debian.org Looks good to me. Acked-by: Linus Walleij linus.wall...@linaro.org BTW: should we disable the GPIO when remove()ing the module? This is a topic of another patch but... Yours, Linus Walleij -- To unsubscribe from this list: send

Re: [PATCH 1/2] leds: lp55xx: handle enable pin in driver

2013-10-22 Thread Linus Walleij
On Tue, Oct 22, 2013 at 6:57 PM, Linus Walleij linus.wall...@linaro.org wrote: BTW: should we disable the GPIO when remove()ing the module? This is a topic of another patch but... Bah forget this stupid comment, I misread it, obviously you're doing this. Yours, Linus Walleij -- To unsubscribe

Re: [RFC PATCH 00/11] Embeddable Position Independent Executable

2013-10-23 Thread Linus Walleij
, but this is a better approach, especially nice since it is the solution to the multiplatform situation, as we need to select to copy code into that memory only on the specific target. I'll try to have a deeper look at this, please keep me on CC for this series. Yours, Linus Walleij -- To unsubscribe from

Re: [RFC 4/4] ASoC: RX-51: Add DT support to sound driver

2013-10-31 Thread Linus Walleij
On Sun, Oct 27, 2013 at 2:24 PM, Sebastian Reichel s...@debian.org wrote: +- eci-sw-gpio: GPIO for ECI SW +- speaker-amp-gpio: GPIO for Speaker Amp Can you please spell out the acronyms? ECI? SW? Amp? I guess SW=switch, Amp=amplifier, but ECI beats me. Yours, Linus Walleij -- To unsubscribe

Re: [PATCH] pinctrl: single: call pcs_soc-rearm() whenever IRQ mask is changed

2013-11-12 Thread Linus Walleij
On Fri, Oct 11, 2013 at 7:23 PM, Tony Lindgren t...@atomide.com wrote: * Linus Walleij linus.wall...@linaro.org [131011 09:27]: On Fri, Oct 11, 2013 at 6:13 PM, Roger Quadros rog...@ti.com wrote: On OMAPs the IO ring must be rearmed each time the pad wakeup configuration is changed. So call

Re: [PATCH 5/8] gpio: twl4030: Fix regression for twl gpio output

2013-11-18 Thread Linus Walleij
the LCD panel not turning on omap3 LDP for example. Cc: Linus Walleij linus.wall...@linaro.org Cc: Peter Ujfalusi peter.ujfal...@ti.com Cc: linux-g...@vger.kernel.org Signed-off-by: Tony Lindgren t...@atomide.com --- If this looks OK, I'd like to merge this as a fix via arm-soc tree along

Re: [PATCH 6/8] gpio: twl4030: Fix passing of pdata in the device tree case

2013-11-18 Thread Linus Walleij
the possible data. Cc: Linus Walleij linus.wall...@linaro.org Cc: linux-g...@vger.kernel.org Signed-off-by: Tony Lindgren t...@atomide.com --- If this looks OK, I'd like to merge this as a fix via arm-soc tree along with the other patches in this series as my later patches depend on patches

Re: [PATCH V4 0/4] DRIVERS: IRQCHIP: Add support for crossbar IP

2013-11-19 Thread Linus Walleij
in to a separate series. I'm pretty happy with the work and effort put into this now it's looking real elegant. FWIW: Acked-by: Linus Walleij linus.wall...@linaro.org Yours, Linus Walleij -- To unsubscribe from this list: send the line unsubscribe linux-omap in the body of a message to majord

Re: [PATCH] pinctrl: single: call pcs_soc-rearm() whenever IRQ mask is changed

2013-11-19 Thread Linus Walleij
as the interrupts-extended property is now merged in and I can also enable some minimal wake-up events for omap3. OK thanks for the heads-up, go ahead. Yours, Linus Walleij -- To unsubscribe from this list: send the line unsubscribe linux-omap in the body of a message to majord...@vger.kernel.org

Re: [RFC 01/23] gpio/omap: raw read and write endian fix

2013-11-19 Thread Linus Walleij
ACKs would be nice, but unless there are major objections this stays merged. Yours, Linus Walleij -- To unsubscribe from this list: send the line unsubscribe linux-omap in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH V2] gpio: omap: refresh patch be more aggressive with pm_runtime against v3.12-rc5

2013-11-29 Thread Linus Walleij
...@gmail.com I'd like Tony and/or Kevin to have a look at this from a PM point of view so I get some confirmation from the core maintainers that this is the way forward. Yours, Linus Walleij -- To unsubscribe from this list: send the line unsubscribe linux-omap in the body of a message to majord

Re: [RFC/RFT/PATCH V3] gpio: omap: refresh patch be more aggressive with pm_runtime against v3.12-rc5

2013-12-09 Thread Linus Walleij
...@gmail.com Kevin/Santosh: you're maintainers for this driver, can you ACK/NACK this patch? Yours, Linus Walleij -- To unsubscribe from this list: send the line unsubscribe linux-omap in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH 5/8] gpio: twl4030: Fix regression for twl gpio output

2013-12-09 Thread Linus Walleij
for this. Roger, Tony: what happened with this? Have you hashed this out? I ACK Roger's fixup too if that needs to be merged into the OMAP tree. Yours, Linus Walleij -- To unsubscribe from this list: send the line unsubscribe linux-omap in the body of a message to majord...@vger.kernel.org More majordomo

Re: [PATCH v2 1/1] gpio: twl4030: Fix regression for twl gpio LED output

2013-12-10 Thread Linus Walleij
/direction_in must return 0 if the operation succeeded. Also, don't update direction flag and output data if twl4030_set_gpio_direction() failed inside twl_direction_out(); Signed-off-by: Roger Quadros rog...@ti.com Patch applied for fixes with Tony's ACK. Thanks! Linus Walleij

Re: [PATCH 5/8] gpio: twl4030: Fix regression for twl gpio output

2013-12-10 Thread Linus Walleij
On Mon, Dec 9, 2013 at 6:10 PM, Tony Lindgren t...@atomide.com wrote: * Linus Walleij linus.wall...@linaro.org [131209 05:10]: On Tue, Dec 3, 2013 at 2:30 PM, Roger Quadros rog...@ti.com wrote: (...) This patch causes a regression with LED outputs (GPO) on twl4030 on 3.13-rc2. As one

Re: [RFC/RFT/PATCH V3] gpio: omap: refresh patch be more aggressive with pm_runtime against v3.12-rc5

2013-12-12 Thread Linus Walleij
want to switch this on and off use the compile option to enable/disable runtime PM altogether and do not wrap it like this. Yours, Linus Walleij -- To unsubscribe from this list: send the line unsubscribe linux-omap in the body of a message to majord...@vger.kernel.org More majordomo info at http

Re: [RFC/RFT/PATCH V3] gpio: omap: refresh patch be more aggressive with pm_runtime against v3.12-rc5

2013-12-12 Thread Linus Walleij
On Thu, Dec 12, 2013 at 7:28 PM, Felipe Balbi ba...@ti.com wrote: On Thu, Dec 12, 2013 at 07:19:35PM +0100, Linus Walleij wrote: One thing caught my eye, you add: +static void _aggressive_pm_runtime_get_sync(struct gpio_bank *bank) +static void _aggressive_pm_runtime_put(struct gpio_bank

Re: [RFCv4 06/11] misc: Introduce Nokia CMT driver

2013-12-16 Thread Linus Walleij
are you using a tasklet rather than a work for this? Yours, Linus Walleij -- To unsubscribe from this list: send the line unsubscribe linux-omap in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [RFCv4 06/11] misc: Introduce Nokia CMT driver

2013-12-16 Thread Linus Walleij
On Mon, Dec 16, 2013 at 1:15 PM, Sebastian Reichel s...@debian.org wrote: On Mon, Dec 16, 2013 at 10:48:06AM +0100, Linus Walleij wrote: I.e. it doesn't look device-specific at all, just like some generic glue code that could be useful to many such scenarios. I like the idea. Probably

Re: Re: [RFCv4 06/11] misc: Introduce Nokia CMT driver

2013-12-22 Thread Linus Walleij
but the development stopped. However such a subsystem is a generic problem of general interest and this would be one of the candidates for drivers/modem I think. Sadly creating it may be a lot of work, I don't know exactly. http://marc.info/?l=linux-kernelm=135027904405680w=2 Yours, Linus Walleij -- To unsubscribe

Re: [RFC PATCH] gpio: add GPIO hogging mechanism

2014-01-08 Thread Linus Walleij
way to solve the at91rm9200ek board use case. I don't know, because I don't know exactly what you mean by pinctrl-gpio. Yours, Linus Walleij -- To unsubscribe from this list: send the line unsubscribe linux-omap in the body of a message to majord...@vger.kernel.org More majordomo info at http

Re: [PATCH 3/4] power_supply: Introduce PSE compliant algorithm

2014-02-27 Thread Linus Walleij
functions and frameworks already now before it becomes impossible to contain. Yours, Linus Walleij -- To unsubscribe from this list: send the line unsubscribe linux-omap in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH 2/4] power_supply: Introduce generic psy charging driver

2014-02-27 Thread Linus Walleij
in, like return -EINVAL etc? Sorry for just making some random review of the header files, but this caught my attention and I couldn't resist. Yours, Linus Walleij -- To unsubscribe from this list: send the line unsubscribe linux-omap in the body of a message to majord...@vger.kernel.org More

Re: [PATCH 3/4] power_supply: Introduce PSE compliant algorithm

2014-02-27 Thread Linus Walleij
temp_mon_range[BATT_TEMP_NR_RNG]; + /* lowest temperature supported */ + s8 temp_low_lim; +} __packed; Why packed, and convert to kerneldoc for this struct. Yours, Linus Walleij -- To unsubscribe from this list: send the line unsubscribe linux-omap in the body of a message to majord

Re: [PATCH 2/4] power_supply: Introduce generic psy charging driver

2014-03-06 Thread Linus Walleij
On Fri, Feb 28, 2014 at 12:27 PM, Jenny Tc jenny...@intel.com wrote: On Thu, Feb 27, 2014 at 09:08:01PM +0100, Linus Walleij wrote: On Thu, Feb 20, 2014 at 6:53 AM, Jenny TC jenny...@intel.com wrote: +++ b/include/linux/power/power_supply_charger.h +#define MAX_CUR_VOLT_SAMPLES 3

Re: [PATCH 2/4] power_supply: Introduce generic psy charging driver

2014-03-06 Thread Linus Walleij
On Fri, Feb 28, 2014 at 6:01 PM, Pavel Machek pa...@ucw.cz wrote: On Thu 2014-02-27 21:08:01, Linus Walleij wrote: On Thu, Feb 20, 2014 at 6:53 AM, Jenny TC jenny...@intel.com wrote: +++ b/include/linux/power/power_supply_charger.h +#define MAX_CUR_VOLT_SAMPLES 3 +#define

Re: [PATCH 3/4] power_supply: Introduce PSE compliant algorithm

2014-03-06 Thread Linus Walleij
On Fri, Feb 28, 2014 at 11:07 AM, Jenny Tc jenny...@intel.com wrote: On Thu, Feb 27, 2014 at 09:18:57PM +0100, Linus Walleij wrote: On Tue, Feb 4, 2014 at 6:12 AM, Jenny TC jenny...@intel.com wrote: +static inline bool __is_battery_full + (long volt, long cur, long iterm, unsigned

Re: [PATCHv8 2/4] power_supply: Introduce generic psy charging driver

2014-03-12 Thread Linus Walleij
sorting algorithms. Any suggestions? You already have a kernel quicksort implementation in lib/sort.c. Please restructure the code to make use of this as it is already compiled into every kernel. Yours, Linus Walleij -- To unsubscribe from this list: send the line unsubscribe linux-omap

Re: [PATCH 2/4] power_supply: Introduce generic psy charging driver

2014-03-12 Thread Linus Walleij
On Fri, Mar 7, 2014 at 9:10 PM, Pavel Machek pa...@ucw.cz wrote: On Fri 2014-03-07 11:04:59, Linus Walleij wrote: On Fri, Feb 28, 2014 at 6:01 PM, Pavel Machek pa...@ucw.cz wrote: On Thu 2014-02-27 21:08:01, Linus Walleij wrote: On Thu, Feb 20, 2014 at 6:53 AM, Jenny TC jenny...@intel.com

Re: [PATCHv8 2/4] power_supply: Introduce generic psy charging driver

2014-03-12 Thread Linus Walleij
, + PSY_CHARGER_CABLE_TYPE_SE1 = 1 9, + PSY_CHARGER_CABLE_TYPE_MHL = 1 10, + PSY_CHARGER_CABLE_TYPE_B_DEVICE = 1 11, +}; I still disagree with using an enum as bitfield. Atleast #include linux/bitops.h and use BIT(0), BIT(1) etc to define the bits. Yours, Linus Walleij -- To unsubscribe from this list: send

Re: [PATCH 2/4] power_supply: Introduce generic psy charging driver

2014-03-14 Thread Linus Walleij
milivolt_t, miliamp_t, milisec_t etc... types. Storing milivolts in int, then having comment saying milivolts is just wrong. Hm! I bet the regulator subsystem maintainers have opinions on that. Yours, Linus Walleij -- To unsubscribe from this list: send the line unsubscribe linux-omap

Re: [PATCH 49/75] ARM: l2c: fix register naming

2014-03-28 Thread Linus Walleij
devices. Provide full auxiliary control register definitions. Signed-off-by: Russell King rmk+ker...@arm.linux.org.uk Acked-by: Linus Walleij linus.wall...@linaro.org For ux500. Yours, Linus Walleij -- To unsubscribe from this list: send the line unsubscribe linux-omap in the body of a message

Re: [PATCH 0/5] GPIO OMAP driver changes for v3.16

2014-04-10 Thread Linus Walleij
will take a closer look at this, it seems there is some cruft still in but let me look. Yours, Linus Walleij -- To unsubscribe from this list: send the line unsubscribe linux-omap in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH 4/5] gpio: omap: convert driver to use gpiolib irqchip

2014-04-10 Thread Linus Walleij
it's bisectable. Yours, Linus Walleij -- To unsubscribe from this list: send the line unsubscribe linux-omap in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [RFC PATCH 0/5] add gpio_chip_ops to hold GPIO operations

2014-04-22 Thread Linus Walleij
. I prefer a BIG fat patch converting everyone and its dog to the new vtable and removing the old function pointers. This can be based on the HEAD of my GPIO devel branch. It may be a good idea to use coccinelle for this refactoring in order not to miss any users. Yours, Linus Walleij

Re: [PATCH 11/11] pinctrl: single: Clear pin interrupts enabled by bootloader

2014-04-22 Thread Linus Walleij
request_irq for the driver specific wake-up events. Cc: Haojian Zhuang haojian.zhu...@linaro.org Cc: Linus Walleij linus.wall...@linaro.org Signed-off-by: Tony Lindgren t...@atomide.com Looks clean. Acked-by: Linus Walleij linus.wall...@linaro.org Shall I apply this patch or will you funnel

Re: [PATCH 0/5] GPIO OMAP driver changes for v3.16

2014-04-22 Thread Linus Walleij
. Isn't an edge IRQ more apropriate as default then? The code contains this: if (!bank-regs-leveldetect0 (type (IRQ_TYPE_LEVEL_LOW|IRQ_TYPE_LEVEL_HIGH))) return -EINVAL; Meaning sometimes the banks don't support level IRQs. Yours, Linus Walleij -- To unsubscribe from this list

Re: regressions in linux-next?

2014-04-22 Thread Linus Walleij
:-/ Yours, Linus Walleij -- To unsubscribe from this list: send the line unsubscribe linux-omap in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: regressions in linux-next?

2014-04-23 Thread Linus Walleij
:-( What about this: if (chip-irq_default_type != IRQ_TYPE_NONE) irq_set_irq_type(irq, chip-irq_default_type); This way you can pass IRQ_TYPE_NONE and nothing happens in the mapping. Yours, Linus Walleij -- To unsubscribe from this list: send the line unsubscribe linux-omap in the body

Re: [PATCH v2] gpio: omap: implement get_direction

2014-04-23 Thread Linus Walleij
, Linus Walleij -- To unsubscribe from this list: send the line unsubscribe linux-omap in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH 11/11] pinctrl: single: Clear pin interrupts enabled by bootloader

2014-04-23 Thread Linus Walleij
this is -rc material. Queued for fixes. Thanks! Yours, Linus Walleij -- To unsubscribe from this list: send the line unsubscribe linux-omap in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: regressions in linux-next?

2014-04-23 Thread Linus Walleij
On Wed, Apr 23, 2014 at 3:29 PM, Nishanth Menon n...@ti.com wrote: On 04/23/2014 08:01 AM, Linus Walleij wrote: What about this: if (chip-irq_default_type != IRQ_TYPE_NONE) irq_set_irq_type(irq, chip-irq_default_type); This way you can pass IRQ_TYPE_NONE and nothing happens

[PATCH] gpio: do not set up hardware for IRQ_TYPE_NONE

2014-04-23 Thread Linus Walleij
: Peter Ujfalusi peter.ujfal...@ti.com Cc: Ezequiel Garcia ezequiel.gar...@free-electrons.com Cc: Javier Martinez Canillas jav...@dowhile0.org Cc: Tony Lindgren t...@atomide.com Cc: Santosh Shilimkar santosh.shilim...@ti.com Cc: linux-omap linux-omap@vger.kernel.org Signed-off-by: Linus Walleij

Re: regressions in linux-next?

2014-04-23 Thread Linus Walleij
and if that fails we go back to this. I've pushed the current patch to linux-next. Yours, Linus Walleij -- To unsubscribe from this list: send the line unsubscribe linux-omap in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH v3] gpio: omap: implement get_direction

2014-04-24 Thread Linus Walleij
yegorsli...@googlemail.com Acked-by: Javier Martinez Canillas jav...@dowhile0.org --- Changes: v3: get rid of _get_gpio_direction() (Linus Walleij) v2: rework return value calculation Looks good to me, Kevin, Santosh? Part of me wants to list Javier as maintainer for this driver

Re: [PATCH v3] gpio: omap: implement get_direction

2014-04-24 Thread Linus Walleij
yegorsli...@googlemail.com Acked-by: Javier Martinez Canillas jav...@dowhile0.org --- Changes: v3: get rid of _get_gpio_direction() (Linus Walleij) v2: rework return value calculation This v3 version applied with Santosh's ACK. Yours, Linus Walleij -- To unsubscribe from this list

Re: [PATCH] gpio: always enable GPIO_OMAP on ARCH_OMAP

2014-05-09 Thread Linus Walleij
it for COMPILE_TEST builds and select the required GENERIC_IRQ_CHIP that may not already be enabled on other platforms. Signed-off-by: Arnd Bergmann a...@arndb.de Patch applied to my devel branch, this is not a fix to Torvalds HEAD AFAICT, but a fix to v3.16? Else poke me. Yours, Linus Walleij

Re: [PATCH] backlight: gpio-backlight: Fix warning when the GPIO is on a I2C chip

2014-05-09 Thread Linus Walleij
On Fri, May 9, 2014 at 5:42 AM, Jingoo Han jg1@samsung.com wrote: Linus Walleij, Is there any reason to keep these two functions such as gpiod_set_raw_value_cansleep() and gpiod_set_raw_value()? Yes, the former can *not* be called from interrupt context, and thus erroneous usage can

Re: [PATCH 1/2] gpio: omap: prepare and unprepare the debounce clock

2014-05-13 Thread Linus Walleij
that you can pull in. I want an explicit handshake with the platform maintainer for this kind of stuff. Yours, Linus Walleij -- To unsubscribe from this list: send the line unsubscribe linux-omap in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org

Re: Accessing GPIOs from userspace using recent kernels

2014-05-23 Thread Linus Walleij
() -- omap_gpio_request(). Looking at other GPIO drivers, it seems like omap_gpio_request() should eventually call pinctrl_request_gpio(). Would be useful if someone who knows about OMAP4/gpio/pinctrl could take a look at this. That is Tony Lindgren and the linux-omap mailing list. Yours, Linus Walleij

Re: [PATCH 2/2] gpio: of: Allow -gpio suffix for property names

2014-06-12 Thread Linus Walleij
. Fix the issue by breaking out of the loop if -EPROBE_DEFER is encountered. Signed-off-by: Tony Lindgren t...@atomide.com Patch applied for fixes with Thierry's Reveiwed-by tag. Yours, Linus Walleij -- To unsubscribe from this list: send the line unsubscribe linux-omap in the body of a message

Re: [PATCH v2 1/6] ARM: mm: cache-l2x0: Add base address argument to write_sec callback

2014-06-27 Thread Linus Walleij
: Acked-by: Linus Walleij linus.wall...@linaro.org Yours, Linus Walleij -- To unsubscribe from this list: send the line unsubscribe linux-omap in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH 1/3] gpio: omap: Remove unnecessary lockdep class

2014-07-08 Thread Linus Walleij
GPIO IRQs into their own lock class) there is no need to do this in a driver if it's using the GPIO irqchip helpers since gpiolib already assigns a lockdep class. Signed-off-by: Javier Martinez Canillas jmarti...@softcrates.net That's right. Patch applied. Yours, Linus Walleij

Re: [PATCH 2/3] gpio: omap: Remove unneeded include

2014-07-08 Thread Linus Walleij
to use gpiolib irqchip). Signed-off-by: Javier Martinez Canillas jmarti...@softcrates.net Patch applied. Yours, Linus Walleij -- To unsubscribe from this list: send the line unsubscribe linux-omap in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org

Re: [PATCH 3/3] gpio: omap: Add an omap prefix to all functions

2014-07-08 Thread Linus Walleij
functions so let's add an omap prefix to all of them. Signed-off-by: Javier Martinez Canillas jmarti...@softcrates.net Yeah that was very disturbing, patch applied, thanks! Yours, Linus Walleij -- To unsubscribe from this list: send the line unsubscribe linux-omap in the body of a message to majord

Re: [PATCH 1/3] pinctrl: bindings: Add OMAP pinctrl binding

2014-08-29 Thread Linus Walleij
skeleton of OMAP pinctrl bindings. This is compatible with pinctrl,single bindings and is meant purely as a reference point. Acked-by: Tony Lindgren t...@atomide.com Signed-off-by: Nishanth Menon n...@ti.com Applied this inline v2 version. Yours, Linus Walleij -- To unsubscribe from this list

Re: [PATCH 3/3] pinctrl: single: AM437x: Add pinctrl compatibility

2014-08-29 Thread Linus Walleij
have changed. Signed-off-by: Keerthy j-keer...@ti.com [n...@ti.com: minor updates] Signed-off-by: Nishanth Menon n...@ti.com Patch applied with Tony's ACK. Yours, Linus Walleij -- To unsubscribe from this list: send the line unsubscribe linux-omap in the body of a message to majord

Re: [PATCH 2/3] pinctrl: single: Add DRA7 pinctrl compatibility

2014-08-29 Thread Linus Walleij
-by: Nishanth Menon n...@ti.com Patch applied with Tony's ACK. Yours, Linus Walleij -- To unsubscribe from this list: send the line unsubscribe linux-omap in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH 2/3] kbuild: remove unnecessary variable initializaions

2014-09-23 Thread Linus Walleij
are also set to empty at the beginning of scripts/Makefile.build) Signed-off-by: Masahiro Yamada yamad...@jp.panasonic.com Acked-by: Linus Walleij linus.wall...@linaro.org Yours, Linus Walleij -- To unsubscribe from this list: send the line unsubscribe linux-omap in the body of a message

Re: [RESEND PATCH] gpio: omap: Fix interrupt names

2014-09-23 Thread Linus Walleij
...@linaro.org --- Requested to be resend by Javier with linux-gpio maintainers in CC. Original V1 of the patch: https://patchwork.kernel.org/patch/4757891/ Probably belongs to 3.18 kernel series at this point in time. Changes since v1: just picked up Acks. Patch applied. Yours, Linus Walleij

Re: [PATCH 4/8] usb: musb: Change to use new IO access

2014-11-25 Thread Linus Walleij
On Mon, Nov 24, 2014 at 8:05 PM, Tony Lindgren t...@atomide.com wrote: Change to use new IO access. This allows us to build in multiple MUSB glue layers. Cc: Fabio Baltieri fabio.balti...@linaro.org Cc: Lee Jones lee.jo...@linaro.org Cc: Linus Walleij linus.wall...@linaro.org Signed-off

Re: [PATCH v7 6/8] net: can: c_can: Disable pins when CAN interface is down

2014-11-27 Thread Linus Walleij
the SLEEP pin state by default on probe and use the DEFAULT pin state on CAN up and back to the SLEEP pin state on CAN down. Signed-off-by: Roger Quadros rog...@ti.com Reviewed-by: Linus Walleij linus.wall...@linaro.org I see you figured it out all by yourselves :D (Sorry for being absent

Re: [PATCH v5 6/8] net: can: c_can: Disable pins when CAN interface is down

2014-11-27 Thread Linus Walleij
things. Things like turning off a serial port from userspace, for example. That should put the pins to sleep. Yours, Linus Walleij -- To unsubscribe from this list: send the line unsubscribe linux-omap in the body of a message to majord...@vger.kernel.org More majordomo info at http

Re: [PATCH 6/8] usb: musb: Pass fifo_mode in platform data

2014-11-28 Thread Linus Walleij
On Mon, Nov 24, 2014 at 8:05 PM, Tony Lindgren t...@atomide.com wrote: This allows setting the correct fifo_mode when multiple MUSB glue layers are built-in. Cc: Fabio Baltieri fabio.balti...@linaro.org Cc: Lee Jones lee.jo...@linaro.org Cc: Linus Walleij linus.wall...@linaro.org Cc

Re: [PATCH 5/8] usb: musb: Change end point selection to use new IO access

2014-11-28 Thread Linus Walleij
On Mon, Nov 24, 2014 at 8:05 PM, Tony Lindgren t...@atomide.com wrote: This allows the endpoints to work when multiple MUSB glue layers are built in. Cc: Fabio Baltieri fabio.balti...@linaro.org Cc: Lee Jones lee.jo...@linaro.org Cc: Linus Walleij linus.wall...@linaro.org Cc: Apelete

Re: [PATCH] gpio / PM: Replace CONFIG_PM_RUNTIME with CONFIG_PM

2014-12-03 Thread Linus Walleij
in linux-next at the moment (via the linux-pm tree). Please let me know if it is OK to take this one into linux-pm. Go ahead. Should be no collissions. Reviewed-by: Linus Walleij linus.wall...@linaro.org Yours, Linus Walleij -- To unsubscribe from this list: send the line unsubscribe linux-omap

Re: [PATCH 1/1] gpio: omap: Fix bad device access with setup_irq()

2015-01-21 Thread Linus Walleij
King rmk+ker...@arm.linux.org.uk Cc: Felipe Balbi ba...@ti.com Cc: Javier Martinez Canillas jav...@dowhile0.org Cc: Kevin Hilman khil...@kernel.org Cc: Linus Walleij linus.wall...@linaro.org Cc: Russell King - ARM Linux li...@arm.linux.org.uk Cc: Santosh Shilimkar ssant...@kernel.org Signed

Re: [PATCH v3 14/21] ARM: imx6: convert GPC to stacked domains

2015-01-12 Thread Linus Walleij
nitpick on this nice patch series: every time I see virq my OCD triggers, as I think the v in virq stand for virtual. These irqs are no more virtual than any other Linux irq numbers, hwirq is more to the point. I just refer to these as irq (sans v) in any code I write. Yours, Linus Walleij

Re: [PATCH] gpio: pcf857x: restore the initial line state of all pcf lines

2015-01-14 Thread Linus Walleij
struct notifier_block foo_reboot_notifier = { .notifier_call = foo_reboot_handler, }; register_reboot_notifier(foo_reboot_notifier); Yours, Linus Walleij -- To unsubscribe from this list: send the line unsubscribe linux-omap in the body of a message to majord...@vger.kernel.org More

Re: [PATCH] gpio: pcf857x: restore the initial line state of all pcf lines

2015-03-18 Thread Linus Walleij
On Mon, Mar 16, 2015 at 9:46 AM, Kishon Vijay Abraham I kis...@ti.com wrote: On Wednesday 14 January 2015 05:28 PM, Linus Walleij wrote: #include linux/reboot.h static int foo_reboot_handler(struct notifier_block *this, unsigned long code

Re: [PATCH 1/2] pinctrl: bindings: pinctrl: Add support for TI's IODelay configuration

2015-03-17 Thread Linus Walleij
I guess this will be acceptable but you really need to reuse some more code between this driver and pinctrl-single.c if I read it right. Yours, Linus Walleij -- To unsubscribe from this list: send the line unsubscribe linux-omap in the body of a message to majord...@vger.kernel.org More majordomo

Re: [PATCH 1/2] gpio: omap: irq_shutdown: remove unnecessary call of gpiochip_unlock_as_irq

2015-03-09 Thread Linus Walleij
, remove unnecessary call of gpiochip_unlock_as_irq() from omap_gpio_irq_shutdown(). Signed-off-by: Grygorii Strashko grygorii.stras...@linaro.org Looks like a simple oversight. Patch applied. Yours, Linus Walleij -- To unsubscribe from this list: send the line unsubscribe linux-omap in the body

Re: [PATCH 1/2] pinctrl: bindings: pinctrl: Add support for TI's IODelay configuration

2015-03-10 Thread Linus Walleij
/pinctrl-bindings.txt We can add generic delay bindings to the list, it even seems like a good idea to do so, as it is likely something that will come up in other hardware and will be needed for ACPI etc going forward. Yours, Linus Walleij -- To unsubscribe from this list: send the line unsubscribe

Re: [PATCH 2/2] pinctrl: Introduce TI IOdelay configuration driver

2015-03-10 Thread Linus Walleij
with pinctrl-single if you anyway go down this path. I'll halt review here pending discussion on the bindings stuff. Yours, Linus Walleij -- To unsubscribe from this list: send the line unsubscribe linux-omap in the body of a message to majord...@vger.kernel.org More majordomo info at http

Re: [PATCH] gpio: pcf857x: restore the initial line state of all pcf lines

2015-03-25 Thread Linus Walleij
the system lock up? If the reboot notifier gets invoked after the shutdown handler then we could be sure that restoring the initial line state of the pcf lines wouldn't affect the devices connected to it. OK so does it? ftrace is your friend. Yours, Linus Walleij -- To unsubscribe from this list

Re: [PATCH v2 4/8] gpio: omap: drop 'gpio' param from omap_gpio_init_irq()

2015-03-27 Thread Linus Walleij
aaro.koski...@iki.fi Acked-by: Santosh Shilimkar ssant...@kernel.org Acked-by: Javier Martinez Canillas jav...@dowhile0.org Signed-off-by: Grygorii Strashko grygorii.stras...@linaro.org Patch applied. Yours, Linus Walleij -- To unsubscribe from this list: send the line unsubscribe linux-omap

Re: [PATCH v2 1/8] gpio: omap: convert omap_gpio_is_input() to use gpio offset

2015-03-27 Thread Linus Walleij
...@atomide.com Tested-by: Aaro Koskinen aaro.koski...@iki.fi Acked-by: Santosh Shilimkar ssant...@kernel.org Acked-by: Javier Martinez Canillas jav...@dowhile0.org Signed-off-by: Grygorii Strashko grygorii.stras...@linaro.org Patch applied. Yours, Linus Walleij -- To unsubscribe from this list: send

Re: [PATCH v2 8/8] gpio: omap: get rid of GPIO_INDEX() macro

2015-03-27 Thread Linus Walleij
-by: Santosh Shilimkar ssant...@kernel.org Acked-by: Javier Martinez Canillas jav...@dowhile0.org Signed-off-by: Grygorii Strashko grygorii.stras...@linaro.org Patch applied. Yours, Linus Walleij -- To unsubscribe from this list: send the line unsubscribe linux-omap in the body of a message

Re: [PATCH v2 5/8] gpio: omap: convert gpio irq functions to use GPIO offset

2015-03-27 Thread Linus Walleij
...@linaro.org Patch applied. Yours, Linus Walleij -- To unsubscribe from this list: send the line unsubscribe linux-omap in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH v2 6/8] gpio: omap: get rid of GPIO_BIT() macro

2015-03-27 Thread Linus Walleij
-by: Santosh Shilimkar ssant...@kernel.org Acked-by: Javier Martinez Canillas jav...@dowhile0.org Signed-off-by: Grygorii Strashko grygorii.stras...@linaro.org Patch applied. Yours, Linus Walleij -- To unsubscribe from this list: send the line unsubscribe linux-omap in the body of a message

Re: [PATCH v2 7/8] gpio: omap: get rid of omap_irq_to_gpio()

2015-03-27 Thread Linus Walleij
-by: Santosh Shilimkar ssant...@kernel.org Acked-by: Javier Martinez Canillas jav...@dowhile0.org Signed-off-by: Grygorii Strashko grygorii.stras...@linaro.org Patch applied. Yours, Linus Walleij -- To unsubscribe from this list: send the line unsubscribe linux-omap in the body of a message

Re: [PATCH v2 2/8] gpio: omap: simplify omap_set_gpio_dataout_x()

2015-03-27 Thread Linus Walleij
, Linus Walleij -- To unsubscribe from this list: send the line unsubscribe linux-omap in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH v2 3/8] gpio: omap: convert debounce functions switch to use gpio offset

2015-03-27 Thread Linus Walleij
() Tested-by: Tony Lindgren t...@atomide.com Tested-by: Aaro Koskinen aaro.koski...@iki.fi Acked-by: Santosh Shilimkar ssant...@kernel.org Acked-by: Javier Martinez Canillas jav...@dowhile0.org Signed-off-by: Grygorii Strashko grygorii.stras...@linaro.org Patch applied. Yours, Linus Walleij

Re: [PATCH 09/15] mfd: kill off set_irq_flags usage

2015-06-10 Thread Linus Walleij
: linux-arm-...@vger.kernel.org Cc: linux-...@vger.kernel.org Cc: linux-omap@vger.kernel.org Acked-by: Linus Walleij linus.wall...@linaro.org Yours, Linus Walleij -- To unsubscribe from this list: send the line unsubscribe linux-omap in the body of a message to majord...@vger.kernel.org More

Re: [RFT v2 45/48] genirq, gpio: Kill the first parameter 'irq' of irq_flow_handler_t

2015-06-04 Thread Linus Walleij
' of irq_flow_handler_t. To ease review, I have split the changes into several parts, though they should be merge as one to support bisecting. Signed-off-by: Jiang Liu jiang@linux.intel.com Acked-by: Linus Walleij linus.wall...@linaro.org Yours, Linus Walleij -- To unsubscribe from this list: send

Re: [PATCH] usb: dwc3: pci: make better use of gpiod API

2015-06-16 Thread Linus Walleij
-by: Linus Walleij linus.wall...@linaro.org Yours, Linus Walleij -- To unsubscribe from this list: send the line unsubscribe linux-omap in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH 1/7] gpio: omap: fix omap_gpio_free to not clean up irq configuration

2015-06-01 Thread Linus Walleij
of the three (!) maintainers on atleast these non-RFC patches? Yours, Linus Walleij -- To unsubscribe from this list: send the line unsubscribe linux-omap in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [RFC v1 05/25] gpio: Use irq_desc_get_xxx() to avoid redundant lookup of irq_desc

2015-06-01 Thread Linus Walleij
On Wed, May 20, 2015 at 11:59 AM, Jiang Liu jiang@linux.intel.com wrote: Use irq_desc_get_xxx() to avoid redundant lookup of irq_desc while we already have a pointer to corresponding irq_desc. Signed-off-by: Jiang Liu jiang@linux.intel.com Acked-by: Linus Walleij linus.wall

Re: [RFC/RFT PATCH 0/7] gpio: omap: rework and fixes

2015-06-01 Thread Linus Walleij
this as an excuse to apply patches 1-5 with Tony's test tag. The maintainers can cheer in if they want, I will anyway take the OMAP maintainers test tag as a good quality indication. Yours, Linus Walleij -- To unsubscribe from this list: send the line unsubscribe linux-omap in the body of a message

Re: [PATCH] gpio: omap: Fix missing raw locks conversion

2015-08-13 Thread Linus Walleij
and applying this patch for next. Thanks! Yours, Linus Walleij -- To unsubscribe from this list: send the line unsubscribe linux-omap in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [4.2-rc1][PATCH] gpio: omap: add missed spin_unlock_irqrestore in omap_gpio_irq_type

2015-08-13 Thread Linus Walleij
On Fri, Aug 7, 2015 at 9:34 AM, Grygorii Strashko grygorii.stras...@ti.com wrote: Hi Tony, On 08/07/2015 06:36 AM, Tony Lindgren wrote: * Linus Walleij linus.wall...@linaro.org [150716 01:38]: On Wed, Jun 24, 2015 at 4:54 PM, Grygorii Strashko grygorii.stras...@ti.com wrote: From

Re: [PATCH] gpiolib: irqchip: use different lockdep class for each gpio irqchip

2015-08-17 Thread Linus Walleij
On Fri, Aug 14, 2015 at 2:40 PM, Lars-Peter Clausen l...@metafoo.de wrote: On 08/14/2015 02:34 PM, Linus Walleij wrote: [...] Every chip will get their own lock class on the heap. But I think it is a bit kludgy. Is it not possible to have the lock key in struct gpio_chip be a real member

Re: [PATCH v2 1/2] gpiolib: irqchip: use different lockdep class for each gpio irqchip

2015-08-17 Thread Linus Walleij
Reported-by: Roger Quadros rog...@ti.com Tested-by: Roger Quadros rog...@ti.com Signed-off-by: Grygorii Strashko grygorii.stras...@ti.com --- Changes in v2: - removed accidental change in gpio chip structure description. This v2 patch applied. I see no better alternative. Yours, Linus Walleij

Re: [PATCH] gpio: omap: use raw locks for locking

2015-06-30 Thread Linus Walleij
development tree. Can you rebase this patch in Torvalds' HEAD, add Javier's ACK and resend? Please put me on the To: line, I have no time to read all mail that I'm only CC on. Yours, Linus Walleij -- To unsubscribe from this list: send the line unsubscribe linux-omap in the body of a message to majord

Re: [PATCH] gpiolib: irqchip: use different lockdep class for each gpio irqchip

2015-08-14 Thread Linus Walleij
, Linus Walleij -- To unsubscribe from this list: send the line unsubscribe linux-omap in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

<    1   2   3   4   5   >