[PATCH 0/2] OMAPDSS: DISPC: Improvements to DIGIT sync signal selection

2012-07-27 Thread Ricardo Neri
to correctly set/get the sync signal based on the available displays in the DIGIT channel. For the HDMI driver, handle the error in the selection of the source. BR, Ricardo Ricardo Neri (2): OMAPDSS: DISPC: Improve logic of selection of external sync signal OMAPDSS:HDMI: Improve error handling

[PATCH 1/2] OMAPDSS: DISPC: Improve logic of selection of external sync signal

2012-07-27 Thread Ricardo Neri
/setting the source. Signed-off-by: Ricardo Neri ricardo.n...@ti.com --- drivers/video/omap2/dss/dss.c | 19 +-- drivers/video/omap2/dss/dss.h |2 +- 2 files changed, 18 insertions(+), 3 deletions(-) diff --git a/drivers/video/omap2/dss/dss.c b/drivers/video/omap2/dss/dss.c

[PATCH 2/2] OMAPDSS:HDMI: Improve error handling at power on

2012-07-27 Thread Ricardo Neri
Handle the errors that may occur when selecting the source of the sync signal for the DIGIT channel of the display controller and when enabling the PHY. Signed-off-by: Ricardo Neri ricardo.n...@ti.com --- drivers/video/omap2/dss/hdmi.c | 10 -- 1 files changed, 8 insertions(+), 2

Re: [PATCH 0/2] OMAPDSS: DISPC: Improvements to DIGIT sync signal selection

2012-07-30 Thread Ricardo Neri
Hi Tomi, Archit, Thanks for your feedback. On 07/30/2012 06:48 AM, Archit Taneja wrote: On Monday 30 July 2012 04:41 PM, Tomi Valkeinen wrote: On Fri, 2012-07-27 at 19:21 -0500, Ricardo Neri wrote: Hello, DSS code wrongly assumes that VENC is always available as source for the external sync

[PATCH v2] OMAPDSS: DISPC: Improve DIGIT channel sync signal selection

2012-07-30 Thread Ricardo Neri
is selected. Signed-off-by: Ricardo Neri ricardo.n...@ti.com --- v2: use BUG_ON() to simplify handling of invalid cases. drivers/video/omap2/dss/dss.c | 13 +++-- 1 files changed, 11 insertions(+), 2 deletions(-) diff --git a/drivers/video/omap2/dss/dss.c b/drivers/video/omap2/dss/dss.c

[PATCH] OMAPDSS: HDMI: Disable PLL properly in case of error at power_on

2012-07-30 Thread Ricardo Neri
Small patch to disable the PLL appropriately before runtime_put in case an error occurs while enabling the PHY. Signed-off-by: Ricardo Neri ricardo.n...@ti.com --- drivers/video/omap2/dss/hdmi.c |3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git a/drivers/video/omap2/dss

Re: [PATCH v2] OMAPDSS: DISPC: Improve DIGIT channel sync signal selection

2012-07-31 Thread Ricardo Neri
On 07/31/2012 12:46 AM, Tomi Valkeinen wrote: On Mon, 2012-07-30 at 19:11 -0500, Ricardo Neri wrote: DSS code wrongly assumes that VENC is always available as source for the external sync signal for the display controller DIGIT channel. One cannot blindly rely only on the value of DSS_CONTROL

[no subject]

2012-07-31 Thread Ricardo Neri
From 8b0f9153d078b7182efd604ef8525d50899ce1a3 Mon Sep 17 00:00:00 2001 From: Ricardo Neri ricardo.n...@ti.com Date: Mon, 30 Jul 2012 17:54:59 -0500 Subject: [PATCH v3] OMAPDSS: DISPC: Improvements to DIGIT sync signal selection DSS code wrongly assumes that VENC is always available as source

[PATCH v3 RESEND] OMAPDSS: DISPC: Improvements to DIGIT sync signal selection

2012-07-31 Thread Ricardo Neri
-off-by: Ricardo Neri ricardo.n...@ti.com --- v3: instead of BUG_ON calls, select only if both VENC and HDMI are available. v2: use BUG_ON() to simplify handling of invalid cases. drivers/video/omap2/dss/dss.c | 12 ++-- 1 files changed, 10 insertions(+), 2 deletions(-) diff --git

Re:

2012-07-31 Thread Ricardo Neri
On 07/31/2012 06:52 PM, Ricardo Neri wrote: From 8b0f9153d078b7182efd604ef8525d50899ce1a3 Mon Sep 17 00:00:00 2001 From: Ricardo Neriricardo.n...@ti.com Date: Mon, 30 Jul 2012 17:54:59 -0500 Subject: [PATCH v3] OMAPDSS: DISPC: Improvements to DIGIT sync signal selection A small issue while

Re: [PATCH v3 RESEND] OMAPDSS: DISPC: Improvements to DIGIT sync signal selection

2012-08-01 Thread Ricardo Neri
On 08/01/2012 01:28 AM, Tomi Valkeinen wrote: On Tue, 2012-07-31 at 18:56 -0500, Ricardo Neri wrote: DSS code wrongly assumes that VENC is always available as source for the external sync signal for the display controller DIGIT channel. One cannot blindly write/read the value of DSS_CONTROL

[PATCH v4] OMAPDSS: DISPC: Improvements to DIGIT sync signal selection

2012-08-01 Thread Ricardo Neri
-off-by: Ricardo Neri ricardo.n...@ti.com --- v4: add WARN_ONs to signal invalid selections. v3: instead of BUG_ON calls, select only if both VENC and HDMI are available. v2: use BUG_ON() to simplify handling of invalid cases. drivers/video/omap2/dss/dss.c | 16 ++-- 1 files changed

Re: [alsa-devel] [PATCH 07/11] ASoC: omap-mcbsp: Sidetone: Use SIDLE bits in SYSCONFIG register to select noidle mode

2012-08-08 Thread Ricardo Neri
On 08/08/2012 04:11 AM, Peter Ujfalusi wrote: Instead of the callback (which modifies control module register) use the McBSP module's SYSCONFIG register to disable smart-idle mode when the sidetone is enabled. Store the original SIDLEMODE configuration and restore it when the sidetone has been

Re: [alsa-devel] [PATCH 07/11] ASoC: omap-mcbsp: Sidetone: Use SIDLE bits in SYSCONFIG register to select noidle mode

2012-08-09 Thread Ricardo Neri
Hi Peter, On 08/09/2012 02:05 AM, Peter Ujfalusi wrote: Hi Ricardo, On 08/09/2012 01:12 AM, Ricardo Neri wrote: Is this another case in which it is required to change the idle-mode on a per-use-case basis? In the past I was trying to do the same with HDMI [1]. In that case it was decided

[RFC] ASoC: snd_soc_jack for HDMI audio: does it make sense?

2012-08-20 Thread Ricardo Neri
Hello! I have been working on prototypes for the ASoC OMAP HDMI audio driver to propagate events from the HDMI output (e.g., display getting enabled/disabled/suspended). This for the users of the driver to react to such events. For instance, if the display is disabled or disconected, audio

Re: [RFC] ASoC: snd_soc_jack for HDMI audio: does it make sense?

2012-08-21 Thread Ricardo Neri
On 08/21/2012 07:39 AM, Clark, Rob wrote: On Tue, Aug 21, 2012 at 1:01 AM, Tomi Valkeinen tomi.valkei...@ti.com wrote: On Mon, 2012-08-20 at 20:47 -0500, Ricardo Neri wrote: Hello! I have been working on prototypes for the ASoC OMAP HDMI audio driver to propagate events from the HDMI output

Re: [alsa-devel] [RFC] ASoC: snd_soc_jack for HDMI audio: does it make sense?

2012-08-21 Thread Ricardo Neri
On 08/21/2012 08:16 AM, Mark Brown wrote: On Tue, Aug 21, 2012 at 02:30:51PM +0200, David Henningsson wrote: On 08/21/2012 02:05 PM, Mark Brown wrote: - sound/core/ctljack.c which was added later and provides separate in-kernel and userspace APIs and is currently only used by HDA.

Re: [alsa-devel] [RFC] ASoC: snd_soc_jack for HDMI audio: does it make sense?

2012-08-23 Thread Ricardo Neri
Hi Takashi, On 08/22/2012 02:55 AM, Takashi Iwai wrote: At Tue, 21 Aug 2012 19:58:02 -0500, Ricardo Neri wrote: On 08/21/2012 07:39 AM, Clark, Rob wrote: On Tue, Aug 21, 2012 at 1:01 AM, Tomi Valkeinen tomi.valkei...@ti.com wrote: On Mon, 2012-08-20 at 20:47 -0500, Ricardo Neri wrote

Re: [alsa-devel] [PATCH v3 00/15] ASoC: OMAP: Convert to use dmaengine

2012-09-24 Thread Ricardo Neri
and this causes a build break with omap2plus_defconfig. Not sure if this is expected, Most likely not. Tested-by: Ricardo Neri ricardo.n...@ti.com Ricardo -- To unsubscribe from this list: send the line unsubscribe linux-omap in the body of a message to majord...@vger.kernel.org More majordomo

[PATCH] ARM: OMAP4: hwmod data: Add McASP data port address space

2012-09-27 Thread Ricardo Neri
McASP has a configuration port and a data port. This patch adds the address space entry for the data port as described in the OMAP4 TRM. Also, add names to the address spaces. Signed-off-by: Ricardo Neri ricardo.n...@ti.com --- arch/arm/mach-omap2/omap_hwmod_44xx_data.c |6 ++ 1 files

Re: [PATCH] ARM: OMAP4: hwmod data: Add McASP data port address space

2012-10-09 Thread Ricardo Neri
Hi Benoit, Have you had a chance to look at this patch? Maybe you want me to submit it differently or to a different list? Thanks! Ricardo On 09/27/2012 11:33 AM, Ricardo Neri wrote: McASP has a configuration port and a data port. This patch adds the address space entry for the data port

Re: [PATCH] ARM: OMAP4: hwmod data: Add McASP data port address space

2012-10-11 Thread Ricardo Neri
Hi Benoit, Thanks for reviewing! On 10/11/2012 05:29 AM, Benoit Cousson wrote: Hi Ricardo, On 10/09/2012 04:15 PM, Ricardo Neri wrote: Hi Benoit, Have you had a chance to look at this patch? Maybe you want me to submit it differently or to a different list? Sorry, I missed it. It looks

[PATCH 1/6] OMAPDSS: HDMI: Rename resource variable at probe.

2012-10-15 Thread Ricardo Neri
Minor cleanup to give to the resource variable a more proper name. Signed-off-by: Ricardo Neri ricardo.n...@ti.com --- drivers/video/omap2/dss/hdmi.c |9 - 1 files changed, 4 insertions(+), 5 deletions(-) diff --git a/drivers/video/omap2/dss/hdmi.c b/drivers/video/omap2/dss/hdmi.c

[PATCH 0/6] Create platform device for audio support

2012-10-15 Thread Ricardo Neri
for audio, I also did minor cleanup to the OMAPDSS HDMI driver probe. BR, Ricardo Ricardo Neri (6): OMAPDSS: HDMI: Rename resource variable at probe. OMAPDSS: Convert to devm_ioremap OMAPDSS: HDMI: Make panel return error if cannot register driver OMAPDSS: HDMI: Uninit display if unable

[PATCH 5/6] OMAPDSS: HDMI: Handle error when initing the display at probe

2012-10-15 Thread Ricardo Neri
Do not blindly assume that the panel could be init'ed. While there, put mutex initialization in the same place. Signed-off-by: Ricardo Neri ricardo.n...@ti.com --- drivers/video/omap2/dss/hdmi.c | 14 +++--- 1 files changed, 11 insertions(+), 3 deletions(-) diff --git a/drivers/video

[PATCH 2/6] OMAPDSS: Convert to devm_ioremap

2012-10-15 Thread Ricardo Neri
Using devm_ioremap provides better memory handling and improves readability. Signed-off-by: Ricardo Neri ricardo.n...@ti.com --- drivers/video/omap2/dss/hdmi.c | 11 +++ 1 files changed, 7 insertions(+), 4 deletions(-) diff --git a/drivers/video/omap2/dss/hdmi.c b/drivers/video/omap2

[PATCH 6/6] OMAPDSS: HDMI: Create platform device to support audio

2012-10-15 Thread Ricardo Neri
are then used by domain-specific drivers; audio in this case. Also, this is in line with the DT implementation of HDMI, in which we will have a single node to describe this feature of the OMAP SoC. Signed-off-by: Ricardo Neri ricardo.n...@ti.com --- drivers/video/omap2/dss/hdmi.c | 68

[PATCH 4/6] OMAPDSS: HDMI: Uninit display if unable to register device

2012-10-15 Thread Ricardo Neri
The display must be uninit'ed in order to free the requested GPIOs. Signed-off-by: Ricardo Neri ricardo.n...@ti.com --- drivers/video/omap2/dss/hdmi.c |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/drivers/video/omap2/dss/hdmi.c b/drivers/video/omap2/dss/hdmi.c index

[PATCH 3/6] OMAPDSS: HDMI: Make panel return error if cannot register driver

2012-10-15 Thread Ricardo Neri
Do not assume blindly that the DSS driver was registered successfully. Signed-off-by: Ricardo Neri ricardo.n...@ti.com --- drivers/video/omap2/dss/hdmi_panel.c |4 +--- 1 files changed, 1 insertions(+), 3 deletions(-) diff --git a/drivers/video/omap2/dss/hdmi_panel.c b/drivers/video/omap2

Re: [PATCH 6/6] OMAPDSS: HDMI: Create platform device to support audio

2012-10-16 Thread Ricardo Neri
Hi Peter, Thanks for reviewing! On 10/16/2012 04:30 AM, Péter Ujfalusi wrote: On 10/16/2012 03:27 AM, Ricardo Neri wrote: Creating the accessory devices, such as audio, from the HDMI driver allows to regard HDMI as a single entity with audio an display functionality. This intends to follow

Re: [PATCH 2/6] OMAPDSS: Convert to devm_ioremap

2012-10-22 Thread Ricardo Neri
Hi Tomi, On 10/22/2012 02:22 AM, Tomi Valkeinen wrote: On 2012-10-16 04:27, Ricardo Neri wrote: Using devm_ioremap provides better memory handling and improves readability. Signed-off-by: Ricardo Neri ricardo.n...@ti.com --- drivers/video/omap2/dss/hdmi.c | 11 +++ 1 files

Re: [PATCH 6/6] OMAPDSS: HDMI: Create platform device to support audio

2012-10-22 Thread Ricardo Neri
Hi Tomi, Thanks for reviewing! On 10/22/2012 02:40 AM, Tomi Valkeinen wrote: On 2012-10-16 04:27, Ricardo Neri wrote: Creating the accessory devices, such as audio, from the HDMI driver allows to regard HDMI as a single entity with audio an display functionality. This intends to follow

Re: [PATCH 6/6] OMAPDSS: HDMI: Create platform device to support audio

2012-10-23 Thread Ricardo Neri
On 10/23/2012 04:37 AM, Tomi Valkeinen wrote: On 2012-10-23 03:48, Ricardo Neri wrote: +#if defined(CONFIG_OMAP4_DSS_HDMI_AUDIO) +#define HDMI_AUDIO_MEM_RESOURCE 0 +#define HDMI_AUDIO_DMA_RESOURCE 1 I don't see much point with these definitions. They are hdmi.c internal, so the audio

Re: [PATCH 6/6] OMAPDSS: HDMI: Create platform device to support audio

2012-10-23 Thread Ricardo Neri
On 10/23/2012 11:17 AM, Tomi Valkeinen wrote: On 2012-10-23 18:42, Ricardo Neri wrote: What registers does the audio side need to access? It only needs access to the DMA audio data port. All other operations that the audio driver needs are done through the omapdss audio interface. Hmm

Re: [PATCH 6/6] OMAPDSS: HDMI: Create platform device to support audio

2012-10-25 Thread Ricardo Neri
On 10/23/2012 11:29 PM, Tomi Valkeinen wrote: On 2012-10-23 20:21, Ricardo Neri wrote: If so, you could pass only that one address, instead of the whole HDMI register space? Yes, that could work. I thought about that but the common HDMI driver would have to know the the IP-specific register

Re: [PATCH 6/6] OMAPDSS: HDMI: Create platform device to support audio

2012-10-25 Thread Ricardo Neri
On 10/25/2012 09:54 AM, Tomi Valkeinen wrote: On 2012-10-25 17:31, Ricardo Neri wrote: On 10/23/2012 11:29 PM, Tomi Valkeinen wrote: On 2012-10-23 20:21, Ricardo Neri wrote: If so, you could pass only that one address, instead of the whole HDMI register space? Yes, that could work. I

[PATCH v2 0/7] Create platform device for audio support

2012-11-02 Thread Ricardo Neri
. *Obtain the DMA port address offset and size from the HDMI IP-specific library. v1 is accessible here: http://www.mail-archive.com/linux-omap@vger.kernel.org/msg77861.html BR, Ricardo Ricardo Neri (7): OMAPDSS: HDMI: Rename resource variable at probe. OMAPDSS: HDMI: Convert

[PATCH v2 1/7] OMAPDSS: HDMI: Rename resource variable at probe.

2012-11-02 Thread Ricardo Neri
Minor cleanup to give to the resource variable a more proper name. Signed-off-by: Ricardo Neri ricardo.n...@ti.com --- drivers/video/omap2/dss/hdmi.c |9 - 1 files changed, 4 insertions(+), 5 deletions(-) diff --git a/drivers/video/omap2/dss/hdmi.c b/drivers/video/omap2/dss/hdmi.c

[PATCH v2 2/7] OMAPDSS: HDMI: Convert to devm_request_and_ioremap

2012-11-02 Thread Ricardo Neri
Using devm_request_and_ioremap provides better memory handling and improves readability. Signed-off-by: Ricardo Neri ricardo.n...@ti.com --- drivers/video/omap2/dss/hdmi.c |6 ++ 1 files changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/video/omap2/dss/hdmi.c b/drivers/video

[PATCH v2 7/7] OMAPDSS: HDMI: Create platform device for audio support

2012-11-02 Thread Ricardo Neri
are then used by domain-specific drivers; audio in this case. Also, this is in line with the DT implementation of HDMI, in which we will have a single node to describe this feature of the OMAP SoC. Signed-off-by: Ricardo Neri ricardo.n...@ti.com --- drivers/video/omap2/dss/hdmi.c | 62

[PATCH v2 5/7] OMAPDSS: HDMI: Uninit display on device add error

2012-11-02 Thread Ricardo Neri
The display must be uninitialized in order to free the requested GPIOs. Signed-off-by: Ricardo Neri ricardo.n...@ti.com --- drivers/video/omap2/dss/hdmi.c |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/drivers/video/omap2/dss/hdmi.c b/drivers/video/omap2/dss/hdmi.c

[PATCH v2 4/7] OMAPDSS: HDMI: Handle panel init error at probe

2012-11-02 Thread Ricardo Neri
Do not blindly assume that the panel could be initialized. While there, group mutex initialization at a single place. Signed-off-by: Ricardo Neri ricardo.n...@ti.com --- drivers/video/omap2/dss/hdmi.c | 14 +++--- 1 files changed, 11 insertions(+), 3 deletions(-) diff --git a/drivers

[PATCH v2 3/7] OMAPDSS: HDMI: Make panel return dssdev register errors

2012-11-02 Thread Ricardo Neri
Do not assume blindly that the DSS driver was registered successfully. Signed-off-by: Ricardo Neri ricardo.n...@ti.com --- drivers/video/omap2/dss/hdmi_panel.c |4 +--- 1 files changed, 1 insertions(+), 3 deletions(-) diff --git a/drivers/video/omap2/dss/hdmi_panel.c b/drivers/video/omap2

[PATCH v2 6/7] OMAPDSS: HDMI: Add op to get audio DMA port address offset

2012-11-02 Thread Ricardo Neri
It could be possible that the DMA port differs accross diferent HDMI IPs. Thus, add an IP-specific function to obtain the address offset and size of the DMA data port. Signed-off-by: Ricardo Neri ricardo.n...@ti.com --- drivers/video/omap2/dss/dss_features.c|1 + drivers/video/omap2/dss

Re: [PATCH 1/6] ARM/dts: omap4-panda: Add pinmux configuration for HDMI

2012-11-05 Thread Ricardo Neri
Hi Tomi, On 11/05/2012 07:17 AM, Tomi Valkeinen wrote: Hi Ricardo, On 2012-11-05 15:14, Tomi Valkeinen wrote: From: Ricardo Neri ricardo.n...@ti.com Add the pinmux configuration for HDMI and TPD12S015A. Configure the gpios for the TPD12S015A and SDA, SCL and CEC for HDMI. Signed-off

Re: [PATCH v2 7/7] OMAPDSS: HDMI: Create platform device for audio support

2012-11-05 Thread Ricardo Neri
Hi Tomi, Thanks for reviewing. On 11/05/2012 02:46 AM, Tomi Valkeinen wrote: On 2012-11-03 02:31, Ricardo Neri wrote: Creating the accessory devices, such as audio, from the HDMI driver allows to regard HDMI as a single entity with audio an display functionality. This intends to follow

[PATCH v3 0/7] Create platform device for audio support

2012-11-05 Thread Ricardo Neri
, Ricardo Ricardo Neri (7): OMAPDSS: HDMI: Rename resource variable at probe. OMAPDSS: HDMI: Convert to devm_request_and_ioremap OMAPDSS: HDMI: Make panel return dssdev register errors OMAPDSS: HDMI: Handle panel init error at probe OMAPDSS: HDMI: Uninit display on device add error OMAPDSS

[PATCH v3 1/7] OMAPDSS: HDMI: Rename resource variable at probe.

2012-11-05 Thread Ricardo Neri
Minor cleanup to give to the resource variable a more proper name. Signed-off-by: Ricardo Neri ricardo.n...@ti.com --- drivers/video/omap2/dss/hdmi.c |9 - 1 files changed, 4 insertions(+), 5 deletions(-) diff --git a/drivers/video/omap2/dss/hdmi.c b/drivers/video/omap2/dss/hdmi.c

[PATCH v3 2/7] OMAPDSS: HDMI: Convert to devm_request_and_ioremap

2012-11-05 Thread Ricardo Neri
Using devm_request_and_ioremap provides better memory handling and improves readability. Signed-off-by: Ricardo Neri ricardo.n...@ti.com --- drivers/video/omap2/dss/hdmi.c |6 ++ 1 files changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/video/omap2/dss/hdmi.c b/drivers/video

[PATCH v3 6/7] OMAPDSS: HDMI: Add op to get audio DMA port address offset

2012-11-05 Thread Ricardo Neri
It could be possible that the DMA port differs accross diferent HDMI IPs. Thus, add an IP-specific function to obtain the address offset and size of the DMA data port. Signed-off-by: Ricardo Neri ricardo.n...@ti.com --- drivers/video/omap2/dss/dss_features.c|1 + drivers/video/omap2/dss

[PATCH v3 3/7] OMAPDSS: HDMI: Make panel return dssdev register errors

2012-11-05 Thread Ricardo Neri
Do not assume blindly that the DSS driver was registered successfully. Signed-off-by: Ricardo Neri ricardo.n...@ti.com --- drivers/video/omap2/dss/hdmi_panel.c |4 +--- 1 files changed, 1 insertions(+), 3 deletions(-) diff --git a/drivers/video/omap2/dss/hdmi_panel.c b/drivers/video/omap2

[PATCH v3 5/7] OMAPDSS: HDMI: Uninit display on device add error

2012-11-05 Thread Ricardo Neri
The display must be uninitialized in order to free the requested GPIOs. Signed-off-by: Ricardo Neri ricardo.n...@ti.com --- drivers/video/omap2/dss/hdmi.c |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/drivers/video/omap2/dss/hdmi.c b/drivers/video/omap2/dss/hdmi.c

[PATCH v3 7/7] OMAPDSS: HDMI: Create platform device for audio support

2012-11-05 Thread Ricardo Neri
are then used by domain-specific drivers; audio in this case. Also, this is in line with the DT implementation of HDMI, in which we will have a single node to describe this feature of the OMAP SoC. Signed-off-by: Ricardo Neri ricardo.n...@ti.com --- drivers/video/omap2/dss/hdmi.c | 62

[PATCH v3 4/7] OMAPDSS: HDMI: Handle panel init error at probe

2012-11-05 Thread Ricardo Neri
Do not blindly assume that the panel could be initialized. While there, group mutex initialization at a single place. Signed-off-by: Ricardo Neri ricardo.n...@ti.com --- drivers/video/omap2/dss/hdmi.c | 14 +++--- 1 files changed, 11 insertions(+), 3 deletions(-) diff --git a/drivers

[PATCH v2] OMAPDSS: Provide an interface for audio support in DSS

2012-05-03 Thread Ricardo Neri
transfers. The resources used for playback are released using audio_disable. Signed-off-by: Ricardo Neri ricardo.n...@ti.com --- Documentation/arm/OMAP/DSS | 38 ++ include/video/omapdss.h| 25 + 2 files changed, 63 insertions(+), 0

[PATCH v2] Provide interface for audio support in DSS

2012-05-03 Thread Ricardo Neri
audio functions may sleep. * In order to make the audio configuration parameters extensible, a struct omap_dss_audio is defined. This helps to easily add more config parameters in the future if/when required (e.g., speaker order configuration). BR, Ricardo Ricardo Neri (1): OMAPDSS: Provide

[PATCH v2 02/14] OMAPDSS: HDMI: Split video_enable into video_enable/disable

2012-05-03 Thread Ricardo Neri
To improve readability, split the video_enable HDMI IP operation into two separate functions for enabling and disabling video. The video_enable function is also modified to return an error value. While there, update these operations for the OMAP4 IP accordingly. Signed-off-by: Ricardo Neri

[PATCH v2 01/14] OMAPDSS: HDMI: Split audio_enable into audio_enable/disable

2012-05-03 Thread Ricardo Neri
To improve readability, split the audio_enable HDMI IP operation into two separate functions for enabling and disabling audio. The audio_enable function is also modified to return an error value. While there, update these operations for the OMAP4 IP accordingly. Signed-off-by: Ricardo Neri

[PATCH v2 08/14] OMAPDSS: HDMI: OMAP4: Expand configuration for IEC-60958 audio

2012-05-03 Thread Ricardo Neri
as they are actually IEC-60958 parameters. Signed-off-by: Ricardo Neri ricardo.n...@ti.com --- drivers/video/omap2/dss/ti_hdmi_4xxx_ip.c | 29 +++-- drivers/video/omap2/dss/ti_hdmi_4xxx_ip.h |4 +--- 2 files changed, 20 insertions(+), 13 deletions(-) diff --git a/drivers/video/omap2

[PATCH v2 09/14] OMAPDSS: HDMI: Relocate N/CTS calculation

2012-05-03 Thread Ricardo Neri
functionality is implemented in the driver. Signed-off-by: Ricardo Neri ricardo.n...@ti.com --- drivers/video/omap2/dss/hdmi.c| 42 + drivers/video/omap2/dss/ti_hdmi.h |1 + drivers/video/omap2/dss/ti_hdmi_4xxx_ip.c | 57 - drivers

[PATCH v2 03/14] OMAPDSS: HDMI: Remove ASoC codec

2012-05-03 Thread Ricardo Neri
patch, ASoC will use this new approach to expose HDMI audio to ALSA. Signed-off-by: Ricardo Neri ricardo.n...@ti.com --- drivers/video/omap2/dss/hdmi.c| 236 - drivers/video/omap2/dss/ti_hdmi_4xxx_ip.h |5 - 2 files changed, 0 insertions(+), 241

[PATCH v2 14/14] OMAPDSS: HDMI: Implement DSS driver interface for audio

2012-05-03 Thread Ricardo Neri
such functions might be called while holding a lock (this especially true for audio_start/stop). For the rest of the audio functions, a mutex could be used in the future as the enablement of resources might take too much time. Signed-off-by: Ricardo Neri ricardo.n...@ti.com --- drivers/video/omap2/dss/dss.h

[PATCH v2 13/14] OMAPDSS: HDMI: Panel: Simplify the name of the HDMI mutex

2012-05-03 Thread Ricardo Neri
As the hdmi_lock mutex is inside the hdmi struct, rename to simply lock. This is only a change in the name. There are not changes in functionality. Signed-off-by: Ricardo Neri ricardo.n...@ti.com --- drivers/video/omap2/dss/hdmi_panel.c | 41 + 1 files changed

[PATCH v2 05/14] OMAPDSS: HDMI: OMAP4: Remove invalid I2S settings

2012-05-03 Thread Ricardo Neri
According to the most up-to-date documentation from Texas Instruments, the configuration of High Bitrate Audio is not possible. Also, it is not possible to set polarity of the I2S Word Select signal. This patch removes the invalid settings. Signed-off-by: Ricardo Neri ricardo.n...@ti.com

[PATCH v2 12/14] OMAPDSS: HDMI: OMAP4: Remap speaker order to match ALSA order

2012-05-03 Thread Ricardo Neri
-FLC while the ALSA order is FL/FR/RL/RR/C/LFE/SL/SR. Refer to CEA-861 Section 6.6.2 for further details. Signed-off-by: Ricardo Neri ricardo.n...@ti.com --- drivers/video/omap2/dss/ti_hdmi_4xxx_ip.c |8 1 files changed, 8 insertions(+), 0 deletions(-) diff --git a/drivers/video/omap2

[PATCH v2 11/14] OMAPDSS: HDMI: Add an audio configuration function

2012-05-03 Thread Ricardo Neri
to 8 audio channels. Signed-off-by: Ricardo Neri ricardo.n...@ti.com --- drivers/video/omap2/dss/dss_features.c|1 + drivers/video/omap2/dss/ti_hdmi.h |5 + drivers/video/omap2/dss/ti_hdmi_4xxx_ip.c | 189 - drivers/video/omap2/dss

[PATCH v2 10/14] OMAPDSS: HDMI: Add support for more audio sample rates in N/CTS calculation

2012-05-03 Thread Ricardo Neri
Add support for more sample rates when calculating N and CTS. This covers all the audio sample rates that an HDMI source is allowed to transmit according to the HDMI 1.4a specification. Also, reorganize the logic for the calculation when using deep color. Signed-off-by: Ricardo Neri ricardo.n

[PATCH v2 07/14] OMAPDSS: HDMI: Decouple HDMI audio from ASoC

2012-05-03 Thread Ricardo Neri
Instead of having OMAPDSS HDMI audio functionality depending on the ASoC HDMI audio driver, use a new config option so that potential users, including ASoC, may select if needed. Signed-off-by: Ricardo Neri ricardo.n...@ti.com --- drivers/video/omap2/dss/Kconfig |4 drivers

[PATCH v2 04/14] OMAPDSS: HDMI: OMAP4: Remove CEA-861 audio infoframe and IEC-60958 enums

2012-05-03 Thread Ricardo Neri
Instead of having its own definitions for CEA-861 and IEC-60958, the HDMI driver should use those provided by ALSA. This patch removes the definitions that are already provided by ALSA. Signed-off-by: Ricardo Neri ricardo.n...@ti.com --- drivers/video/omap2/dss/ti_hdmi_4xxx_ip.c | 34

[PATCH v2 06/14] OMAPDSS: HDMI: Decouple wrapper enable/disable and audio start/stop

2012-05-03 Thread Ricardo Neri
-by: Axel Castaneda Gonzalez x0055...@ti.com Signed-off-by: Ricardo Neri ricardo.n...@ti.com --- drivers/video/omap2/dss/dss_features.c|2 ++ drivers/video/omap2/dss/ti_hdmi.h |6 ++ drivers/video/omap2/dss/ti_hdmi_4xxx_ip.c | 19 ++- 3 files changed, 22

[PATCH v2 00/14] OMAPDSS: HDMI: Prepare for DSS dev driver audio support and OMAP5

2012-05-03 Thread Ricardo Neri
header files. *Rephrase the description of several patches. BR, Ricardo Axel Castaneda Gonzalez (1): OMAPDSS: HDMI: Decouple wrapper enable/disable and audio start/stop Ricardo Neri (13): OMAPDSS: HDMI: Split audio_enable into audio_enable/disable OMAPDSS: HDMI: Split video_enable

Re: [PATCH 0/3] ARM: OMAP: Add platform devices for ASoC HDMI drivers

2012-05-03 Thread Ricardo Neri
Hi Tony, This is me again; asking if you had any chance to look at these patches. Thanks! Ricardo On 04/25/2012 06:29 PM, Ricardo Neri wrote: Hi Tony, I was wondering if you've had the time to take a look at these patches. Thanks! Ricardo On 04/17/2012 07:40 PM, Ricardo Neri wrote

Re: [PATCH v2 14/14] OMAPDSS: HDMI: Implement DSS driver interface for audio

2012-05-08 Thread Ricardo Neri
Hi Tomi, Thanks for taking the time to comment. On 05/07/2012 06:43 AM, Tomi Valkeinen wrote: Hi, On Thu, 2012-05-03 at 20:44 -0500, Ricardo Neri wrote: Implement the DSS device driver audio support interface in the HDMI panel driver and generic driver. The implementation relies on the IP

[PATCH v3] Provide interface for audio support in DSS

2012-05-09 Thread Ricardo Neri
to easily add more config parameters in the future if/when required (e.g., speaker order configuration). BR, Ricardo Ricardo Neri (1): OMAPDSS: Provide an interface for audio support Documentation/arm/OMAP/DSS | 45 include/video/omapdss.h

[PATCH v3] OMAPDSS: Provide an interface for audio support

2012-05-09 Thread Ricardo Neri
to play audio, to _ENABLED. The state _PLAYING is used when the audio is being rendered. Signed-off-by: Ricardo Neri ricardo.n...@ti.com --- Documentation/arm/OMAP/DSS | 45 include/video/omapdss.h| 34 + 2 files

[PATCH v3] OMAPDSS: HDMI: Implement DSS driver interface for audio

2012-05-09 Thread Ricardo Neri
disable audio. As the panel and audio states are protected by a mutex and a spinlock, a video thread and audio thread cannot concurrently execute audio functions. BR, Ricardo Ricardo Neri (1): OMAPDSS: HDMI: Implement DSS driver interface for audio drivers/video/omap2/dss/dss.h|8

[PATCH v3] OMAPDSS: HDMI: Implement DSS driver interface for audio

2012-05-09 Thread Ricardo Neri
protected by the audio lock. Signed-off-by: Ricardo Neri ricardo.n...@ti.com --- drivers/video/omap2/dss/dss.h|8 ++ drivers/video/omap2/dss/hdmi.c | 42 ++ drivers/video/omap2/dss/hdmi_panel.c | 140 ++ 3 files changed, 190 insertions

Re: [PATCH v2 14/14] OMAPDSS: HDMI: Implement DSS driver interface for audio

2012-05-09 Thread Ricardo Neri
On 05/09/2012 03:28 AM, Tomi Valkeinen wrote: On Tue, 2012-05-08 at 18:55 -0500, Ricardo Neri wrote: Hi Tomi, Thanks for taking the time to comment. On 05/07/2012 06:43 AM, Tomi Valkeinen wrote: Hi, On Thu, 2012-05-03 at 20:44 -0500, Ricardo Neri wrote: Implement the DSS device driver

Re: [PATCH v2 14/14] OMAPDSS: HDMI: Implement DSS driver interface for audio

2012-05-10 Thread Ricardo Neri
On 05/10/2012 02:54 AM, Tomi Valkeinen wrote: On Wed, 2012-05-09 at 23:12 -0500, Ricardo Neri wrote: Under the new strategy, in addition to not allowing the audio functions to be called from multiple threads, audio functions will fail if the sequence _CONFIGURED - _ENABLED - PLAYING

Re: [PATCH v2 14/14] OMAPDSS: HDMI: Implement DSS driver interface for audio

2012-05-11 Thread Ricardo Neri
On 05/11/2012 07:51 AM, Tomi Valkeinen wrote: On Thu, 2012-05-10 at 20:56 -0500, Ricardo Neri wrote: Sorry, some hunks where missing in the patch that I submitted yesterday. I just pushed a branch containing the whole most up-to-date series here: git://gitorious.org/omap-audio/linux

[PATCH 03/11] ASoC: OMAP: HDMI: Change error values in HDMI CPU DAI

2012-05-18 Thread Ricardo Neri
When getting the needed resources fails, return -ENODEV. This is more in line with other drivers do and it gives a more descriptive error. Signed-off-by: Ricardo Neri ricardo.n...@ti.com --- sound/soc/omap/omap-hdmi.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git

[PATCH 01/11] ASoC: OMAP: HDMI: Introduce codec

2012-05-18 Thread Ricardo Neri
specification. Signed-off-by: Ricardo Neri ricardo.n...@ti.com --- sound/soc/codecs/Kconfig |4 ++ sound/soc/codecs/Makefile|2 + sound/soc/codecs/omap-hdmi.c | 69 ++ sound/soc/omap/Kconfig |1 + 4 files changed, 76 insertions(+), 0

[PATCH 04/11] ASoC: OMAP: HDMI: Create a structure for private data of the CPU DAI

2012-05-18 Thread Ricardo Neri
using devm_kzalloc rather than using a static global variable. Signed-off-by: Ricardo Neri ricardo.n...@ti.com --- sound/soc/omap/omap-hdmi.c | 28 +++- 1 files changed, 19 insertions(+), 9 deletions(-) diff --git a/sound/soc/omap/omap-hdmi.c b/sound/soc/omap/omap-hdmi.c

[PATCH 02/11] ASoC: OMAP: HDMI: Update the platform device names

2012-05-18 Thread Ricardo Neri
-by: Ricardo Neri ricardo.n...@ti.com --- sound/soc/omap/omap-hdmi.c |2 +- sound/soc/omap/omap4-hdmi-card.c | 10 +- 2 files changed, 6 insertions(+), 6 deletions(-) diff --git a/sound/soc/omap/omap-hdmi.c b/sound/soc/omap/omap-hdmi.c index 38e0def..0925a46 100644 --- a/sound

[PATCH 06/11] ASoC: OMAP: HDMI: Expand configuration of hw_params

2012-05-18 Thread Ricardo Neri
Expand the configuration of the hw_params to include the IEC-60958 channel status word and the CEA-861 audio infoframe. The configuration of such structures depends on the snd_pcm_hw_params received. A omap_dss_audio is used to pass the configuration parameters to DSS. Signed-off-by: Ricardo Neri

[PATCH 10/11] ASoC: OMAP: HDMI: Make sound card naming more generic

2012-05-18 Thread Ricardo Neri
Rename all the relevant structures, variables and functions to not make specific reference to OMAP4. This is to make the driver encompass future OMAP versions that feature HDMI and not only OMAP4. These changes are only in naming. There are not functional changes. Signed-off-by: Ricardo Neri

[PATCH 07/11] ASoC: OMAP: HDMI: Improve how the display state is verified

2012-05-18 Thread Ricardo Neri
not have to look for it every time audio is to be played. Also, the CPU DAI startup function is called earlier than the card hw_param function. Hence and we can detect the state of the display earlier. While there, add a error message if the constraint cannot be applied. Signed-off-by: Ricardo

[PATCH 08/11] ASoC: OMAP: HDMI: Expand capabilities of the HDMI DAI

2012-05-18 Thread Ricardo Neri
, as this CPU DAI describes the HDMI source, it makes sense to include them. The limitation of capabilities as supported by the sink should be done in the ASoC HDMI codec. Signed-off-by: Ricardo Neri ricardo.n...@ti.com --- sound/soc/omap/omap-hdmi.c |2 +- sound/soc/omap/omap-hdmi.h |4

[PATCH 05/11] ASoC: OMAP: HDMI: Use the DSS audio interface

2012-05-18 Thread Ricardo Neri
new DAI operations are added: trigger, prepare and shutdown operations. At the moment, it is assumed that only one HDMI display is available in the system, as it is the case in OMAP4. However, in the future, one DAI for each HDMI display should be provided. Signed-off-by: Ricardo Neri ricardo.n

[PATCH 11/11] ASoC: OMAP: HDMI: Rename sound card source file

2012-05-18 Thread Ricardo Neri
Rename sound card driver source file to encompass not only OMAP4 but future OMAP versions that feature HDMI. Signed-off-by: Ricardo Neri ricardo.n...@ti.com --- sound/soc/omap/Makefile |4 +- sound/soc/omap/omap-hdmi-card.c | 87 ++ sound/soc

[PATCH 09/11] ASoC: OMAP: HDMI: Make build config options more generic

2012-05-18 Thread Ricardo Neri
change accordingly. Signed-off-by: Ricardo Neri ricardo.n...@ti.com --- sound/soc/omap/Kconfig |6 +++--- sound/soc/omap/Makefile |2 +- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/sound/soc/omap/Kconfig b/sound/soc/omap/Kconfig index 13afb2c..57a2fa7 100644 --- a/sound

[PATCH 00/11] ASoC: OMAP: HDMI: Use DSS audio interface and prepare for OMAP5

2012-05-18 Thread Ricardo Neri
-February/049065.html [8] http://www.mail-archive.com/linux-omap@vger.kernel.org/msg66600.html Ricardo Neri (11): ASoC: OMAP: HDMI: Introduce codec ASoC: OMAP: HDMI: Update the platform device names ASoC: OMAP: HDMI: Change error values in HDMI CPU DAI ASoC: OMAP: HDMI: Create a structure

Re: [PATCH 01/11] ASoC: OMAP: HDMI: Introduce codec

2012-05-18 Thread Ricardo Neri
On 05/18/2012 11:32 AM, Mark Brown wrote: On Fri, May 18, 2012 at 01:42:33AM -0500, Ricardo Neri wrote: Introduce codec for HDMI. At the moment, this is a dummy codec. In the future it will parse the EDID to modify the supported parameters, such as the number of channels and the sample rates

[PATCH] OMAPDSS: HDMI: OMAP4: Update IRQ flags for the HPD IRQ request

2012-05-21 Thread Ricardo Neri
IRQF_ONESHOT. Also, remove the IRQF_DISABLED as the flag is now a NOOP and has been deprecated. Signed-off-by: Ricardo Neri ricardo.n...@ti.com --- drivers/video/omap2/dss/ti_hdmi_4xxx_ip.c |6 +++--- 1 files changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/video/omap2/dss

[PATCH] OMAPDSS: HDMI: OMAP4: Fix request_irq for HPD

2012-05-21 Thread Ricardo Neri
will fail. Also, while there, I removed the IRQF_DISABLED flag as it is now deprecated. If you are OK with the change, I hope it could be merged for K3.5 otherwise HDMI will fail. [1].http://www.spinics.net/lists/linux-tip-commits/msg14974.html Ricardo Neri (1): OMAPDSS: HDMI: OMAP4: Update IRQ

Re: Compile err when enable CONFIG_SND_OMAP_SOC_OMAP_HDMI

2012-05-30 Thread Ricardo Neri
+Tomi Hi Xiao, On 05/30/2012 02:14 AM, Xiao Jiang wrote: Hello, After enable SND_OMAP_SOC_OMAP_HDMI with omap2plus_defconfig, I got some err infos with latest Linus's tree, does somebody also has the same issue? sound/soc/omap/omap-hdmi.c:45:24: error: field 'dss_audio' has incomplete type

Re: Compile err when enable CONFIG_SND_OMAP_SOC_OMAP_HDMI

2012-06-04 Thread Ricardo Neri
Hi Xiao, Tomi, Jarkko, On 05/30/2012 11:27 PM, Xiao Jiang wrote: Ricardo Neri wrote: +Tomi Hi Xiao, On 05/30/2012 02:14 AM, Xiao Jiang wrote: Hello, After enable SND_OMAP_SOC_OMAP_HDMI with omap2plus_defconfig, I got some err infos with latest Linus's tree, does somebody also has the same

Re: Compile err when enable CONFIG_SND_OMAP_SOC_OMAP_HDMI

2012-06-05 Thread Ricardo Neri
Hi Xiao, On 06/04/2012 11:15 PM, Xiao Jiang wrote: Ricardo Neri wrote: Hi Xiao, Tomi, Jarkko, On 05/30/2012 11:27 PM, Xiao Jiang wrote: Ricardo Neri wrote: +Tomi Hi Xiao, On 05/30/2012 02:14 AM, Xiao Jiang wrote: Hello, After enable SND_OMAP_SOC_OMAP_HDMI with omap2plus_defconfig, I got

[RFC] ARM: OMAP4: hwmod data: add HWMOD_SWSUP_SIDLE to dss_hdmi to data

2012-06-16 Thread Ricardo Neri
/linux-omap@vger.kernel.org/msg60226.html [2].http://www.mail-archive.com/linux-omap@vger.kernel.org/msg60236.html [3].http://www.mail-archive.com/linux-omap@vger.kernel.org/msg60316.html [4].http://www.mail-archive.com/linux-omap@vger.kernel.org/msg60252.html Signed-off-by: Ricardo Neri ricardo.n

Re: [RFC] ARM: OMAP4: hwmod data: add HWMOD_SWSUP_SIDLE to dss_hdmi to data

2012-06-19 Thread Ricardo Neri
On 06/18/2012 04:22 PM, Paul Walmsley wrote: Hi On Sat, 16 Jun 2012, Ricardo Neri wrote: I would like to revive an old discussion regarding how to use a particular idle mode for a specific use-case[1]. As per the OMAP4 documentation, audio over HDMI should be transmitted in no-idle mode

  1   2   3   >