Re: [PATCH 3/17] ARM: OMAP2: Add common register access for 24xx and 34xx

2008-04-07 Thread Russell King - ARM Linux
On Tue, Mar 18, 2008 at 04:02:01PM +0200, Tony Lindgren wrote: diff --git a/arch/arm/mach-omap2/cm.h b/arch/arm/mach-omap2/cm.h new file mode 100644 index 000..f575a87 --- /dev/null +++ b/arch/arm/mach-omap2/cm.h @@ -0,0 +1,142 @@ + +#ifndef __ASSEMBLER__ +/* Clock management global

Re: [PATCH 5/17] ARM: OMAP2: Change 24xx to use new register access

2008-04-07 Thread Russell King - ARM Linux
On Tue, Mar 18, 2008 at 04:02:03PM +0200, Tony Lindgren wrote: From: Paul Walmsley [EMAIL PROTECTED] This patch changes 24xx to use new register access, except for clock framework. Clock framework register access will get updates in the next patch. Hmm... @@ -187,13 +189,40 @@ static

Re: [PATCH 5/17] ARM: OMAP2: Change 24xx to use new register access

2008-04-09 Thread Russell King - ARM Linux
On Wed, Apr 09, 2008 at 08:57:13PM +, Tony Lindgren wrote: Here's how it now looks: Not quite. The point I was trying to make is: @@ -302,15 +288,17 @@ int eth_cs; unsigned long cs_mem_base; unsigned int muxed, rate; - struct clk *l3ck; + struct clk

Re: [PATCH 3/17] ARM: OMAP2: Add common register access for 24xx and 34xx

2008-04-14 Thread Russell King - ARM Linux
On Wed, Apr 09, 2008 at 08:50:06PM +, Tony Lindgren wrote: Hi, Thanks for looking through this big set, I'll repost the series with your comments fixed. Few comments below on what was changed. * Russell King - ARM Linux [EMAIL PROTECTED] [080407 16:21]: On Tue, Mar 18, 2008 at 04

Re: MMC/SD cards hotplug scenario

2008-05-21 Thread Russell King - ARM Linux
On Wed, May 21, 2008 at 11:42:04AM +0530, Madhusudhan Chikkature Rajashekar wrote: After the end of the I/O errors I can umount the partition that was mounted and I reinsert the card. That's rather expected - outstanding IO has to be errored when the medium is removed. It seem not to work

Re: MMC/SD cards hotplug scenario

2008-05-22 Thread Russell King - ARM Linux
On Fri, May 23, 2008 at 01:16:39AM +0530, Syed Mohammed, Khasim wrote: The obscene amount of noise here seems to be caused by ext2 being extremely persistent. This is generally a good thing for your data though. :) What is missing is a decent way for a block device to tell the upper

Re: [PATCH 01/02] ARM: OMAP: DMA: Don't mark channel active in omap_enable_channel_irq

2008-06-14 Thread Russell King - ARM Linux
On Fri, Jun 06, 2008 at 06:21:47PM -0700, Tony Lindgren wrote: From: Jarkko Nikula [EMAIL PROTECTED] Channel should be marked active only when DMA is really started. Otherwise just omap_request_dma, omap_dma_link_lch and omap_dma_unlink_lch will cause incorrect dump_stack().

Re: [PATCH 02/02] ARM: OMAP: Correcting the gpmc prefetch control register address

2008-06-14 Thread Russell King - ARM Linux
On Fri, Jun 06, 2008 at 06:21:48PM -0700, Tony Lindgren wrote: From: Thara Gopinath [EMAIL PROTECTED] Correcting the GPMC_PREFETCH_CONTROL register address Signed-off-by: Thara Gopinath [EMAIL PROTECTED] Signed-off-by: Tony Lindgren [EMAIL PROTECTED] Ok. -- To unsubscribe from this list:

Re: [PATCH 01/02] ARM: OMAP: DMA: Don't mark channel active in omap_enable_channel_irq

2008-06-14 Thread Russell King - ARM Linux
On Fri, Jun 06, 2008 at 06:21:47PM -0700, Tony Lindgren wrote: From: Jarkko Nikula [EMAIL PROTECTED] Channel should be marked active only when DMA is really started. Otherwise just omap_request_dma, omap_dma_link_lch and omap_dma_unlink_lch will cause incorrect dump_stack().

Re: [PATCH 02/02] ARM: OMAP: Correcting the gpmc prefetch control register address

2008-06-14 Thread Russell King - ARM Linux
On Fri, Jun 06, 2008 at 06:21:48PM -0700, Tony Lindgren wrote: From: Thara Gopinath [EMAIL PROTECTED] Correcting the GPMC_PREFETCH_CONTROL register address Signed-off-by: Thara Gopinath [EMAIL PROTECTED] Signed-off-by: Tony Lindgren [EMAIL PROTECTED] This looks like something for -rc. --

Re: [PATCH 05/21] ARM: OMAP: DMA: Remove __REG access

2008-06-14 Thread Russell King - ARM Linux
On Fri, Jun 06, 2008 at 06:30:37PM -0700, Tony Lindgren wrote: Remove __REG access in DMA code, use dma_read/write instead: - dynamically set the omap_dma_base based on the omap type - omap_read/write becomes dma_read/write - dma channel registers are read with dma_ch_read/write Cc:

Re: [PATCH 08/21] ARM: OMAP: SRAM: Move omap2 sram-fn.S to sram242x.S

2008-06-14 Thread Russell King - ARM Linux
On Fri, Jun 06, 2008 at 06:30:40PM -0700, Tony Lindgren wrote: This file will get split between sram242x.S and sram243x.S in following patch. Signed-off-by: Tony Lindgren [EMAIL PROTECTED] Please use '-M' so git diff detects renames. -- To unsubscribe from this list: send the line

Re: [PATCH 06/21] ARM: OMAP: DMA: Clean-up code

2008-06-14 Thread Russell King - ARM Linux
On Fri, Jun 06, 2008 at 06:30:38PM -0700, Tony Lindgren wrote: @@ -431,8 +474,8 @@ struct omap_dma_channel_params { extern void omap_set_dma_priority(int lch, int dst_port, int priority); extern int omap_request_dma(int dev_id, const char *dev_name, - void (*

Re: [PATCH 11/21] ARM: OMAP: McBSP: Prepare for splitting into omap1 and omap2 code

2008-06-14 Thread Russell King - ARM Linux
On Fri, Jun 06, 2008 at 06:30:43PM -0700, Tony Lindgren wrote: +#if defined(CONFIG_OMAP_MCBSP) || defined(CONFIG_OMAP_MCBSP_MODULE) + +static struct platform_device omap_mcbsp_devices[OMAP_MAX_MCBSP_COUNT]; +static int mcbsps_configured; + +void omap_mcbsp_register_board_cfg(struct

Re: [PATCH 10/21] ARM: OMAP: McBSP: Coding style cleanup on arch/arm/plat-omap/mcbsp.c

2008-06-14 Thread Russell King - ARM Linux
On Fri, Jun 06, 2008 at 06:30:42PM -0700, Tony Lindgren wrote: From: Eduardo Valentin [EMAIL PROTECTED] This patch fix lots of warnings and errors reported by scripts/checkpatch.pl on arch/arm/plat-omap/mcbsp.c. Signed-off-by: Eduardo Valentin [EMAIL PROTECTED] Acked-by: Felipe Balbi

Re: [PATCH 02/21] ARM: OMAP: DMTimer: Optimize by adding load and start

2008-06-14 Thread Russell King - ARM Linux
On Fri, Jun 06, 2008 at 06:30:34PM -0700, Tony Lindgren wrote: From: Richard Woodruff [EMAIL PROTECTED] This patch optimizes the timer load and start sequence. By combining the load and start a needless posted wait can be removed from the system timer execution path. * Before patch

Re: [PATCH 18/21] ARM: OMAP: Remove __REG access for multi-omap

2008-06-14 Thread Russell King - ARM Linux
On Fri, Jun 06, 2008 at 06:30:50PM -0700, Tony Lindgren wrote: This does not play nicely with multi-omap as it cannot be replaced by a function in io.c for omaps with different IO bases. Signed-off-by: Tony Lindgren [EMAIL PROTECTED] Ok. -- To unsubscribe from this list: send the line

Re: [PATCH 20/21] ARM: OMAP: Turn CM and PRM access into functions

2008-06-14 Thread Russell King - ARM Linux
On Fri, Jun 06, 2008 at 06:30:52PM -0700, Tony Lindgren wrote: Otherwise compiling in omap2 and omap3 will not work. Signed-off-by: Tony Lindgren [EMAIL PROTECTED] Ok. -- To unsubscribe from this list: send the line unsubscribe linux-omap in the body of a message to [EMAIL PROTECTED] More

Re: [PATCH 21/21] ARM: OMAP: Add OMAP chip type structure; clean up mach-omap2/id.c

2008-06-14 Thread Russell King - ARM Linux
On Fri, Jun 06, 2008 at 06:30:53PM -0700, Tony Lindgren wrote: omap_chip is set in mach-omap2/id.c by _set_omap_chip(). Other code should use the omap_chip_is() function to test against omap_chip. +/** + * omap_chip_is - test whether currently running OMAP matches a chip type + * @oc:

Re: [PATCH 01/02] ARM: OMAP: DMA: Don't mark channel active in omap_enable_channel_irq

2008-06-22 Thread Russell King - ARM Linux
On Mon, Jun 16, 2008 at 12:59:41PM +0300, Tony Lindgren wrote: * Russell King - ARM Linux [EMAIL PROTECTED] [080614 11:02]: On Fri, Jun 06, 2008 at 06:21:47PM -0700, Tony Lindgren wrote: From: Jarkko Nikula [EMAIL PROTECTED] Channel should be marked active only when DMA is really

Re: [PATCH 05/21] ARM: OMAP: DMA: Remove __REG access

2008-06-22 Thread Russell King - ARM Linux
On Tue, Jun 17, 2008 at 10:22:51AM +0300, Tony Lindgren wrote: Good catch, yes it can be static. Updated patch following. Ok. -- To unsubscribe from this list: send the line unsubscribe linux-omap in the body of a message to [EMAIL PROTECTED] More majordomo info at

Re: [PATCH 06/21] ARM: OMAP: DMA: Clean-up code

2008-06-22 Thread Russell King - ARM Linux
On Tue, Jun 17, 2008 at 10:27:11AM +0300, Tony Lindgren wrote: * Russell King - ARM Linux [EMAIL PROTECTED] [080614 11:13]: On Fri, Jun 06, 2008 at 06:30:38PM -0700, Tony Lindgren wrote: @@ -431,8 +474,8 @@ struct omap_dma_channel_params { extern void omap_set_dma_priority(int lch

Re: [PATCH 07/21] ARM: OMAP: SRAM: Move sram-fn.S from plat-omap to mach-omap1

2008-06-22 Thread Russell King - ARM Linux
On Tue, Jun 17, 2008 at 10:34:34AM +0300, Tony Lindgren wrote: * Tony Lindgren [EMAIL PROTECTED] [080607 04:31]: This file is omap1 specific. Here's this patch updated with diff -M to show rename. Ok. -- To unsubscribe from this list: send the line unsubscribe linux-omap in the body of a

Re: Git pull request for omap patches for post 2.6.26

2008-07-07 Thread Russell King - ARM Linux
On Thu, Jul 03, 2008 at 01:11:42PM +0300, Tony Lindgren wrote: Please pull the omap patches for post-2.6.26 from: git://git.kernel.org/pub/scm/linux/kernel/git/tmlind/linux-omap-2.6.git omap2-upstream I pulled this some time back but never merged it - but I did look at it. However, I never

Re: [PATCH 0/0] Power domain and clock domain patches for omap

2008-07-21 Thread Russell King - ARM Linux
On Wed, Jul 16, 2008 at 06:19:05PM +0300, Tony Lindgren wrote: I'm reposting the series to a wider audience as Russell King suspected that other archs may be interested in reviewing these too, or at least some parts of the code. It would be nice to have some comment on these patches from other

Re: [PATCH] ARM MMU: add strongly-ordered memory type

2008-08-07 Thread Russell King - ARM Linux
On Wed, Aug 06, 2008 at 07:21:14AM -0500, Woodruff, Richard wrote: Most of the weak memory attributes in newer ARMs are not exploited today in tree. I'll guess this was more a correctness and capability judgment from Russell. Not entirely true. We do as much as is safe to do - which is

Re: [PATCH] ARM MMU: add strongly-ordered memory type

2008-08-07 Thread Russell King - ARM Linux
On Thu, Aug 07, 2008 at 01:56:40PM -0500, Woodruff, Richard wrote: From: Russell King - ARM Linux [mailto:[EMAIL PROTECTED] Most of the weak memory attributes in newer ARMs are not exploited today in tree. I'll guess this was more a correctness and capability judgment from Russell

Re: [PATCH] ARM MMU: add strongly-ordered memory type

2008-08-07 Thread Russell King - ARM Linux
On Thu, Aug 07, 2008 at 03:38:55PM -0500, Woodruff, Richard wrote: From: Russell King - ARM Linux [mailto:[EMAIL PROTECTED] Is DEVICE really safe for things other than FIFOs with out the use of barriers? As far as I'm aware, yes - and that comment is based solely upon the fact

Re: [PATCH] ARM MMU: add strongly-ordered memory type

2008-08-07 Thread Russell King - ARM Linux
On Thu, Aug 07, 2008 at 10:20:33PM +0100, Russell King - ARM Linux wrote: In the case of arch/arm/mach-omap2/irq.c, reading the INTC_REVISION reg after masking should be a sufficient solution. And here's a patch to do exactly that. diff --git a/arch/arm/mach-omap2/irq.c b/arch/arm/mach-omap2

Re: [PATCH] ARM MMU: add strongly-ordered memory type

2008-08-08 Thread Russell King - ARM Linux
On Thu, Aug 07, 2008 at 06:07:50PM -0500, Woodruff, Richard wrote: If I write a series of control register commands to device A, then write a go operation to device B, I would hope all of A's writes had completed before B gets the go. SO gives you this. DEVICE may not with out barriers.

Re: [PATCH] ARM MMU: add strongly-ordered memory type

2008-08-08 Thread Russell King - ARM Linux
On Fri, Aug 08, 2008 at 12:44:49PM +0100, Catalin Marinas wrote: There are already CPUs with weaker memory ordering model than ARM (e.g. Alpha) and they are supported by Linux. Of course, there may be problems with drivers since most of them are developed in x86. There are, and they are

Re: [PATCH] ARM TLB: add v7wbi_{possible,always}_flags to {possible,always}_tlb_flags

2008-08-11 Thread Russell King - ARM Linux
On Mon, Aug 11, 2008 at 02:03:10PM -0600, Paul Walmsley wrote: Commit 2ccdd1e77da52ad494e9af46bf272d816830cb28 doesn't add v7wbi_possible_flags and v7wbi_always_flags to possible_tlb_flags and always_tlb_flags. This causes the L2 cache flush in clean_pmd_entry() (intended for Feroceon

Re: [PATCH 0/0] Power domain and clock domain patches for omap

2008-08-18 Thread Russell King - ARM Linux
On Wed, Jul 16, 2008 at 06:19:05PM +0300, Tony Lindgren wrote: This patch series contains power domain and clock domain specific patches for omap posted to linux-arm-kernel list during 2.6.25-rc5. I'm reposting the series to a wider audience as Russell King suspected that other archs may be

Re: [PATCH 01/16] ARM: OMAP2 Provide function to enable/disable uart clocks

2008-08-19 Thread Russell King - ARM Linux
On Fri, Jun 06, 2008 at 06:47:42PM -0700, Tony Lindgren wrote: This patch adds common function to enable/disable omap2/3 uart clocks. Enabled uarts are passed by bootloader in atags and clocks for these enabled uarts are touched. In some ways, this patch is a good thing, in others it's

Re: [PATCH 02/16] ARM: OMAP2: Split sleep.S into sleep242x.S and sleep243x.S

2008-08-19 Thread Russell King - ARM Linux
On Fri, Jun 06, 2008 at 07:12:28PM -0700, Tony Lindgren wrote: Some register offsets are different for 242x and 243x. This will allow compiling sleep code for both chips into the same kernel. Note that some PM patches are still missing. The PM patches will be added later on once the base

Re: [PATCH 04/16] ARM: OMAP: Fix sparse, checkpatch warnings in OMAP2/3 PRCM/PM code

2008-08-19 Thread Russell King - ARM Linux
On Fri, Jun 06, 2008 at 07:12:30PM -0700, Tony Lindgren wrote: static void omap2_clk_wait_ready(struct clk *clk) { - void __iomem *reg, *other_reg, *st_reg; - u32 bit; - - /* - * REVISIT: This code is pretty ugly. It would be nice to generalize - * it and pull it

Re: [PATCH 07/16] ARM: OMAP2: Add clkdm_get_pwrdm()

2008-08-19 Thread Russell King - ARM Linux
On Fri, Jun 06, 2008 at 07:12:33PM -0700, Tony Lindgren wrote: From: Paul Walmsley [EMAIL PROTECTED] Add clkdm_get_pwrdm() to the clockdomain code. It will return a pointer to the powerdomain struct that the clockdomain is contained within. Used by the PM code. Signed-off-by: Paul

Re: [PATCH 14/16] ARM: OMAP2: Misc updates from linux-omap tree

2008-08-19 Thread Russell King - ARM Linux
On Fri, Jun 06, 2008 at 07:12:40PM -0700, Tony Lindgren wrote: @@ -208,10 +365,12 @@ static int __init omap2_init_devices(void) /* please keep these calls, and their implementations above, * in alphabetical order so they're easier to sort through. */ - omap_init_i2c();

Re: [PATCH 00/16] Omap2 patches for post 2.6.26

2008-08-19 Thread Russell King - ARM Linux
On Fri, Jun 06, 2008 at 06:47:41PM -0700, Tony Lindgren wrote: This patch series contains various omap2 patchs from linux-omap tree. Big chunk of the patches still improve the clock code. Also more clean-up to allow compiling omap2 and omap3 support into the same kernel. The patch also adds

Re: [PATCH v2 03/20] mmc: support embedded data field in mmc_host

2010-08-04 Thread Russell King - ARM Linux
On Wed, Aug 04, 2010 at 02:24:39PM +0300, Ohad Ben-Cohen wrote: Hi Vitaly, On Tue, Aug 3, 2010 at 5:17 PM, Vitaly Wool vitalyw...@gmail.com wrote: On Mon, Aug 2, 2010 at 11:35 PM, Ohad Ben-Cohen o...@wizery.com wrote: I'm honestly trying to understand your concerns, but I'm afraid that

Re: [PATCH v2 03/20] mmc: support embedded data field in mmc_host

2010-08-06 Thread Russell King - ARM Linux
On Fri, Aug 06, 2010 at 01:02:24PM +0300, Ohad Ben-Cohen wrote: We have Russell's suggestion which is nice and simple, but it has the 1 device limitation. You could make it generic by doing something like this: #define set_device_data(name, type, index, data)\ ({

Re: [PATCH 1/3] ARM: mmu: Setup MT_MEMORY and MT_MEMORY_NONACHED L1 entries

2010-08-08 Thread Russell King - ARM Linux
On Sun, Aug 08, 2010 at 03:47:52PM +0530, Santosh Shilimkar wrote: @@ -475,6 +486,9 @@ static void __init build_mem_type_table(void) mem_types[MT_LOW_VECTORS].prot_l1 |= ecc_mask; mem_types[MT_HIGH_VECTORS].prot_l1 |= ecc_mask; mem_types[MT_MEMORY].prot_sect |= ecc_mask |

Re: [PATCH 1/3] ARM: mmu: Setup MT_MEMORY and MT_MEMORY_NONACHED L1 entries

2010-08-08 Thread Russell King - ARM Linux
On Sun, Aug 08, 2010 at 03:47:52PM +0530, Santosh Shilimkar wrote: This patch populates the L1 entries for MT_MEMORY and MT_MEMORY_NONACHED Spelling. types so that at boot-up, we can map memories outside system memory at page level granularity If you're only using MT_MEMORY_NONCACHED (it

Re: [PATCH v4 3/8] wireless: wl1271: add platform driver to get board data

2010-08-11 Thread Russell King - ARM Linux
On Thu, Aug 12, 2010 at 12:22:54AM +0530, DebBarma, Tarun Kanti wrote: True; however if we go by that argument than we can also assume pdata is valid, so that we would not need the below check. If pdev was ever NULL in a probe function, the kernel deserves to OOPS so that you have a backtrace

Re: [PATCH v4 3/8] wireless: wl1271: add platform driver to get board data

2010-08-11 Thread Russell King - ARM Linux
On Thu, Aug 12, 2010 at 12:57:18AM +0530, DebBarma, Tarun Kanti wrote: -Original Message- From: Felipe Balbi [mailto:felipe.ba...@nokia.com] Sent: Thursday, August 12, 2010 12:27 AM To: DebBarma, Tarun Kanti Cc: Balbi Felipe (Nokia-MS/Helsinki); Ohad Ben-Cohen; linux-

Re: [PATCH v4 3/8] wireless: wl1271: add platform driver to get board data

2010-08-12 Thread Russell King - ARM Linux
On Thu, Aug 12, 2010 at 09:40:19AM +0300, Ohad Ben-Cohen wrote: On Thu, Aug 12, 2010 at 12:25 AM, Russell King - ARM Linux li...@arm.linux.org.uk wrote: I've outlined a far simpler and easiler solution which avoids this kind of abuse, and given suggestions on how to extend it to support

Re: [PATCH 2/4] ARM: Allow optional UP processor functions for SMP kernels

2010-08-17 Thread Russell King - ARM Linux
On Tue, Aug 17, 2010 at 01:53:25PM +0300, Tony Lindgren wrote: diff --git a/arch/arm/include/asm/smp_plat.h b/arch/arm/include/asm/smp_plat.h index e621530..1c2f587 100644 --- a/arch/arm/include/asm/smp_plat.h +++ b/arch/arm/include/asm/smp_plat.h @@ -18,4 +18,13 @@ static inline int

Re: [PATCH 0/4] Hacks to allow booting ARM SMP kernel on UP ARMv7

2010-08-17 Thread Russell King - ARM Linux
On Tue, Aug 17, 2010 at 01:53:12PM +0300, Tony Lindgren wrote: Here are some experimental patches to allow booting ARMv7 SMP kernel on UP to some extent. Posting these early in case it is of any help as I know at least Bryan Wu is working on similar issues. I think these are compeltely the

Re: [PATCH 0/4] Hacks to allow booting ARM SMP kernel on UP ARMv7

2010-08-17 Thread Russell King - ARM Linux
On Tue, Aug 17, 2010 at 05:12:11PM +0300, Tony Lindgren wrote: Great, will give it a try hopefully tomorrow. Sounds like that's the way to deal with fixing up things when booting up older UP ARMv6 without the 32v6 support :) What I've also been debating about is adding another word to the

Re: [PATCH 0/4] Hacks to allow booting ARM SMP kernel on UP ARMv7

2010-08-19 Thread Russell King - ARM Linux
On Thu, Aug 19, 2010 at 12:57:06PM +0300, Tony Lindgren wrote: Looks like something is not quite right with smp_on_up part of __fixup_smp, returning early before smp_on_up does not produce that. It's probably overwriting some register it shouldn't be. I might be able to look at this sometime

Re: DSS2 broken with 36-rc1

2010-08-25 Thread Russell King - ARM Linux
I'll respond more fully when I'm back in September. On Wed, Aug 25, 2010 at 02:43:18PM +0300, Tomi Valkeinen wrote: I'll try to summarize how the framebuffer memory is used with OMAP: We have two kinds of memories: - SRAM - SDRAM We have two ways to get the memory (done with memblock):

Re: [PATCH 1/4] initial support for LogicPD's OMAP3530LV SOM and OMAP35x Torpedo dev boards

2010-09-02 Thread Russell King - ARM Linux
On Tue, Aug 24, 2010 at 11:53:37PM -0400, Jacob Tanenbaum wrote: +/* Micron MT46H32M32LF-6 */ +/* FIXME: borrowed from sdram-micron-mt46h32m32lf-6.h because on LogicPD + * boards we can't use the default values -- why? I suspect the reason + * lies in the boot strap code. We correct this part

Re: [PATCH 2/4] Low-level init of hsmmc controller for LogicPD's OMAP3530LV SOM and OMAP 35x Torpedo dev boards

2010-09-02 Thread Russell King - ARM Linux
On Tue, Aug 24, 2010 at 11:53:38PM -0400, Jacob Tanenbaum wrote: From: jake j...@glados.(none) Not a valid address... please fix. ARM: OMAP3LOGIC: Adding SDMMC support Add low-level initialization for hsmmc controller for LogicPD's OMAP 3530 LV SOM and OMAP

Re: [PATCH 4/4] Enabling Ethernet support for LogicPD's OMAP 3530LV SOM and OMAP 35x Torpedo dev board

2010-09-02 Thread Russell King - ARM Linux
On Tue, Aug 24, 2010 at 11:53:40PM -0400, Jacob Tanenbaum wrote: +static inline void __init board_smsc911x_init(void) +{ + /* OMAP3530 LV SOM board */ + if (machine_is_omap3530_lv_som()) { + board_smsc911x_data.gpio_irq = +

Re: [PATCH 2/4] Low-level init of hsmmc controller for LogicPD's OMAP3530LV SOM and OMAP 35x Torpedo dev boards

2010-09-02 Thread Russell King - ARM Linux
Basically same comments as previous patches. -- To unsubscribe from this list: send the line unsubscribe linux-omap in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH 0/4] Hacks to allow booting ARM SMP kernel on UP ARMv7

2010-09-02 Thread Russell King - ARM Linux
On Mon, Aug 30, 2010 at 03:55:27PM -0700, Tony Lindgren wrote: * Tony Lindgren t...@atomide.com [100820 04:59]: * Russell King - ARM Linux li...@arm.linux.org.uk [100819 13:13]: On Thu, Aug 19, 2010 at 12:57:06PM +0300, Tony Lindgren wrote: Looks like something is not quite right

Re: [PATCH 3/6] ARM: Fix v7wbi_tlb_flags for SMP on UP

2010-09-02 Thread Russell King - ARM Linux
On Thu, Sep 02, 2010 at 09:20:40AM -0700, Tony Lindgren wrote: From 253e91b76e104dbdf05c5c3eaf9cbf426972c938 Mon Sep 17 00:00:00 2001 From: Tony Lindgren t...@atomide.com Date: Wed, 1 Sep 2010 16:49:13 -0700 Subject: [PATCH 3/6] ARM: Fix v7wbi_tlb_flags for SMP on UP Fix v7wbi_tlb_flags for

Re: [PATCH 5/6] ARM: Don't set TLB ops broadcasting on UP ARMv7

2010-09-02 Thread Russell King - ARM Linux
On Thu, Sep 02, 2010 at 09:22:20AM -0700, Tony Lindgren wrote: From 8b22546af2ba9a0d96c2f419bfcec1f3c01a414d Mon Sep 17 00:00:00 2001 From: Tony Lindgren t...@atomide.com Date: Mon, 30 Aug 2010 14:03:28 -0700 Subject: [PATCH 5/6] ARM: Don't set TLB ops broadcasting on UP ARMv7 Don't set TLB

Re: [PATCH 1/6] ARM: Add inline function smp_on_up() for early init testing

2010-09-02 Thread Russell King - ARM Linux
On Thu, Sep 02, 2010 at 09:18:47AM -0700, Tony Lindgren wrote: From 7044c13594c3023da6095f8d432eda260bc3207f Mon Sep 17 00:00:00 2001 From: Tony Lindgren t...@atomide.com Date: Mon, 30 Aug 2010 14:00:54 -0700 Subject: [PATCH 1/6] ARM: Add inline function smp_on_up() for early init testing

Re: [PATCH 5/6] ARM: Don't set TLB ops broadcasting on UP ARMv7

2010-09-02 Thread Russell King - ARM Linux
On Thu, Sep 02, 2010 at 10:21:33AM -0700, Tony Lindgren wrote: * Russell King - ARM Linux li...@arm.linux.org.uk [100902 09:50]: On Thu, Sep 02, 2010 at 09:22:20AM -0700, Tony Lindgren wrote: From 8b22546af2ba9a0d96c2f419bfcec1f3c01a414d Mon Sep 17 00:00:00 2001 From: Tony Lindgren t

Re: [PATCH 5/6] ARM: Don't set TLB ops broadcasting on UP ARMv7

2010-09-02 Thread Russell King - ARM Linux
On Thu, Sep 02, 2010 at 11:13:17AM -0700, Tony Lindgren wrote: * Russell King - ARM Linux li...@arm.linux.org.uk [100902 10:54]: On Thu, Sep 02, 2010 at 10:21:33AM -0700, Tony Lindgren wrote: * Russell King - ARM Linux li...@arm.linux.org.uk [100902 09:50]: On Thu, Sep 02, 2010 at 09:22

Re: [PATCH 3/6] ARM: Fix v7wbi_tlb_flags for SMP on UP

2010-09-03 Thread Russell King - ARM Linux
On Thu, Sep 02, 2010 at 04:47:46PM -0700, Tony Lindgren wrote: Correction, only boots on SMP hardawre. On UP hardware I still need the following patch. This should fix that properly. arch/arm/Kconfig | 12 arch/arm/include/asm/assembler.h | 20

Re: [PATCH 3/6] ARM: Fix v7wbi_tlb_flags for SMP on UP

2010-09-03 Thread Russell King - ARM Linux
On Fri, Sep 03, 2010 at 10:07:34AM +0100, Russell King - ARM Linux wrote: On Thu, Sep 02, 2010 at 04:47:46PM -0700, Tony Lindgren wrote: Correction, only boots on SMP hardawre. On UP hardware I still need the following patch. This should fix that properly. Correction - the order

Re: [PATCH 3/6] ARM: Fix v7wbi_tlb_flags for SMP on UP

2010-09-03 Thread Russell King - ARM Linux
On Fri, Sep 03, 2010 at 10:04:03AM -0700, Tony Lindgren wrote: * Russell King - ARM Linux li...@arm.linux.org.uk [100903 02:02]: On Fri, Sep 03, 2010 at 10:07:34AM +0100, Russell King - ARM Linux wrote: On Thu, Sep 02, 2010 at 04:47:46PM -0700, Tony Lindgren wrote: Correction, only boots

Re: [PATCH 4/6] ARM: Do not call test_for_ipi or test_for_ltrirq on UP systems

2010-09-04 Thread Russell King - ARM Linux
On Thu, Sep 02, 2010 at 09:21:24AM -0700, Tony Lindgren wrote: Do not call test_for_ipi or test_for_ltrirq on UP systems. Note that we can't put test_for_ltriq into SMP statement as it's inlined into the code and the remaining lines of the macro would still run before UP macro line. I think

Re: [PATCH 4/6] ARM: Do not call test_for_ipi or test_for_ltrirq on UP systems

2010-09-04 Thread Russell King - ARM Linux
On Fri, Sep 03, 2010 at 05:30:57PM +0530, Shilimkar, Santosh wrote: diff --git a/arch/arm/kernel/entry-armv.S b/arch/arm/kernel/entry-armv.S index bb2ef60..b8c1ec7 100644 --- a/arch/arm/kernel/entry-armv.S +++ b/arch/arm/kernel/entry-armv.S @@ -40,6 +40,11 @@ bne asm_do_IRQ

Re: [PATCH 2/6] ARM: Use SMP and UP macros for cacheflush

2010-09-04 Thread Russell King - ARM Linux
On Fri, Sep 03, 2010 at 05:27:25PM +0530, Shilimkar, Santosh wrote: Since UP/SMP both cases are handled, the above patch can be something like this now... No - this results in the instruction used for ARMv6 SMP systems being changed to the ARMv7 instruction, which probably won't work. -- To

Re: [PATCH 6/6] omap: Fix SMP on UP interrupt handling for multi-omap

2010-09-04 Thread Russell King - ARM Linux
On Fri, Sep 03, 2010 at 05:36:27PM +0530, Shilimkar, Santosh wrote: -Original Message- From: linux-omap-ow...@vger.kernel.org [mailto:linux-omap- ow...@vger.kernel.org] On Behalf Of Tony Lindgren Sent: Thursday, September 02, 2010 9:54 PM To: Russell King - ARM Linux Cc: linux

Re: [PATCH 0/4] Hacks to allow booting ARM SMP kernel on UP ARMv7

2010-09-06 Thread Russell King - ARM Linux
On Mon, Sep 06, 2010 at 10:28:53AM +0100, Catalin Marinas wrote: I haven't followed your patches closely but can we restrict the ARMv6 SMP/UP support to only those cores that have TEX remapping (most of them probably)? We don't support TEX remapping on ARMv6. -- To unsubscribe from this list:

Re: [PATCH 0/4] Hacks to allow booting ARM SMP kernel on UP ARMv7

2010-09-06 Thread Russell King - ARM Linux
On Mon, Sep 06, 2010 at 10:38:30AM +0100, Catalin Marinas wrote: On Mon, 2010-09-06 at 10:34 +0100, Russell King - ARM Linux wrote: On Mon, Sep 06, 2010 at 10:28:53AM +0100, Catalin Marinas wrote: I haven't followed your patches closely but can we restrict the ARMv6 SMP/UP support to only

Re: [PATCH 0/4] Hacks to allow booting ARM SMP kernel on UP ARMv7

2010-09-06 Thread Russell King - ARM Linux
Here's my latest patch (which is combined from two patches.) Tony, could you follow up with patches for anything which is still required - I think there's two things you've addressed which this currently misses: 1. not initializing twd_base (I'm not convinced this is safe - rather making

Re: [PATCH v5 3/7] wireless: wl12xx: add platform data passing support

2010-09-06 Thread Russell King - ARM Linux
On Sat, Sep 04, 2010 at 02:23:19PM +0200, Michał Mirosław wrote: 2010/9/1 Ohad Ben-Cohen o...@wizery.com: Add a simple mechanism to pass platform data to the SDIO instances of wl12xx. This way there is no confusion over who owns the 'embedded data', typechecking is preserved, and no

Re: [PATCH 3/6] ARM: Fix v7wbi_tlb_flags for SMP on UP

2010-09-06 Thread Russell King - ARM Linux
On Mon, Sep 06, 2010 at 04:53:47PM +0100, Catalin Marinas wrote: On Mon, 2010-09-06 at 16:34 +0100, Russell King - ARM Linux wrote: On Mon, Sep 06, 2010 at 12:46:34PM +0100, Catalin Marinas wrote: Would this work with Thumb-2 kernel builds? Maybe you can add a W(instr) in the SMP/UP

Re: [PATCH v5 3/7] wireless: wl12xx: add platform data passing support

2010-09-15 Thread Russell King - ARM Linux
On Mon, Sep 06, 2010 at 09:42:41PM +0200, Michał Mirosław wrote: W dniu 6 września 2010 14:07 użytkownik Russell King - ARM Linux li...@arm.linux.org.uk napisał: On Sat, Sep 04, 2010 at 02:23:19PM +0200, Michał Mirosław wrote: 2010/9/1 Ohad Ben-Cohen o...@wizery.com: Add a simple

Re: [PATCH 02/14] omap: Map only available sram memory

2010-09-17 Thread Russell King - ARM Linux
On Fri, Sep 17, 2010 at 03:17:46PM +0530, Santosh Shilimkar wrote: Currently we map 1 MB section while setting up SRAM on OMAPs. The actual physcal OCM RAM available on OMAP SOCs is in order physical of KBs. This patch maps only available sram and removes some non necessary cpu_is_xxx

Re: [PATCH 03/14] davinci: map sram using MT_MEMORY_NONCACHED instead of MT_DEVICE

2010-09-17 Thread Russell King - ARM Linux
On Fri, Sep 17, 2010 at 03:17:47PM +0530, Santosh Shilimkar wrote: On Davinci SRAM is mapped as MT_DEVICE becasue of the section mapping pre-requisite instead of intended MT_MEMORY_NONCACHED Since the section mapping limitation gets fixed with first patch in this series, the

Re: [PATCH v8 3/6] OMAP2430: hwmod data: Add watchdog timer

2010-09-23 Thread Russell King - ARM Linux
On Thu, Sep 23, 2010 at 08:02:40PM +0530, Varadarajan, Charulatha wrote: +static struct omap_hwmod omap2430_wd_timer2_hwmod = { + .name = wd_timer2, + .class = omap2430_wd_timer_hwmod_class, + .main_clk = mpu_wdt_fck, Why are we going backwards to naming

Re: [PATCH] [OMAP] HTCHERALD: MMC, I2C, HTCPLD, SPI, TSC2046

2010-09-24 Thread Russell King - ARM Linux
On Fri, Sep 24, 2010 at 08:38:37AM -0700, Cory Maccarrone wrote: Not really sure, I wasn't the one who first came up with that mask. All I know is that it seems to work, and not just for my device, but lots of other HTC OMAP850 devices we've tried it on too. I'm interested though, what in

Re: [GIT PULL] omap2 sparse fixes

2010-09-27 Thread Russell King - ARM Linux
On Mon, Sep 27, 2010 at 07:11:37PM +0530, G, Manjunath Kondaiah wrote: Can you please check that? Will not merge for now until we figure out what changes with these patches. Then, I also noticed the following exports getting added: +EXPORT_SYMBOL(omap2_gp_clockevent_set_gptimer);

Re: [PATCH v3 5/5] OMAP: I2C: Convert i2c driver to use PM runtime api's

2010-09-28 Thread Russell King - ARM Linux
On Tue, Sep 28, 2010 at 12:29:01PM +0530, Nayak, Rajendra wrote: snip... static int omap_i2c_init(struct omap_i2c_dev *dev) @@ -356,6 +333,7 @@ static int omap_i2c_init(struct omap_i2c_dev *dev) unsigned long fclk_rate = 1200; unsigned long timeout;

Re: [PATCH 01/14] ARM: mmu: Setup MT_MEMORY and MT_MEMORY_NONCACHED L1 entries

2010-09-29 Thread Russell King - ARM Linux
On Wed, Sep 29, 2010 at 03:51:21PM +0100, Catalin Marinas wrote: Hi Santosh, Santosh Shilimkar santosh.shilim...@ti.com wrote: This patch populates the L1 entries for MT_MEMORY and MT_MEMORY_NONCACHED types so that at boot-up, we can map memories outside system memory at page level

Re: [PATCH 6/6] ARM: l2x0: Optimise the range based operations

2010-10-04 Thread Russell King - ARM Linux
On Tue, Sep 07, 2010 at 01:27:23PM +0530, Santosh Shilimkar wrote: For the big buffers which are in excess of cache size, the maintaince operations by PA are very slow. For such buffers the maintainace operations can be speeded up by using the WAY based method. This causes my Versatile Express

Re: [PATCH] ARM: Check for is_smp for tlb_ops and cache_ops boardcast

2010-10-06 Thread Russell King - ARM Linux
On Wed, Oct 06, 2010 at 07:44:14AM -0700, Tony Lindgren wrote: * Russell King - ARM Linux li...@arm.linux.org.uk [101005 15:24]: On Tue, Oct 05, 2010 at 03:19:52PM -0700, Tony Lindgren wrote: * Tony Lindgren t...@atomide.com [100907 20:04]: This should not be needed when running on UP

Re: [RFC] tidspbridge: use a parameter to allocate shared memory

2010-10-07 Thread Russell King - ARM Linux
On Thu, Oct 07, 2010 at 09:40:12AM +0200, Laurent Pinchart wrote: Hi Omar, On Thursday 07 October 2010 07:45:36 Omar Ramirez Luna wrote: tidspbridge driver uses a block of memory denominated SHared Memory to store info communicate with DSP, this SHM needs to be physically contiguous and

Re: [PATCH v2 09/10] OMAP2/3: Convert write/read functions to raw read/write

2010-10-07 Thread Russell King - ARM Linux
On Thu, Oct 07, 2010 at 07:17:08AM -0500, Menon, Nishanth wrote: -Original Message- From: linux-omap-ow...@vger.kernel.org [mailto:linux-omap- ow...@vger.kernel.org] On Behalf Of G, Manjunath Kondaiah Sent: Tuesday, September 21, 2010 5:01 AM To: linux-omap@vger.kernel.org

Re: [RFC] tidspbridge: use a parameter to allocate shared memory

2010-10-07 Thread Russell King - ARM Linux
On Thu, Oct 07, 2010 at 04:01:02PM +0200, Laurent Pinchart wrote: Do we have an infrastructure, or even an embryo thereof, to remove pages from the kernel's direct-mapped memory mapping at runtime ? The use of super pages probably complicates the matter. No, and yes, using section

Re: [PATCH v4] ARM: Fix sparse warnings due to variables conflicts.

2010-10-08 Thread Russell King - ARM Linux
On Fri, Oct 08, 2010 at 06:32:29AM -0500, Nishanth Menon wrote: Poddar, Sourav had written, on 10/08/2010 12:53 AM, the following: Fix the sparse warnings generated due to conflicts in variables used in readl/writel. drivers/net/smc91x.c:312:8: warning: symbol '__v' shadows an earlier one

Re: [PATCH 2/2] ftrace - add ftrace function_graph support on ARM

2010-10-09 Thread Russell King - ARM Linux
On Sat, Oct 09, 2010 at 11:20:50PM +0530, Rabin Vincent wrote: On Sun, Mar 7, 2010 at 1:48 AM, Russell King - ARM Linux li...@arm.linux.org.uk wrote: On Fri, Mar 05, 2010 at 04:36:47PM -0800, Tim Bird wrote: IRQENTRY_TEXT was added to vmlinux.lds.S (to eliminate a compiler error on kernel

Re: [PATCH 1/3] arm: mm: allow boards to fiddle with meminfo

2010-10-10 Thread Russell King - ARM Linux
On Sun, Oct 10, 2010 at 08:40:38PM +0300, Felipe Contreras wrote: So that they can reserve some memory. Signed-off-by: Felipe Contreras felipe.contre...@gmail.com --- arch/arm/include/asm/mach/arch.h |2 +- arch/arm/mm/init.c |7 --- 2 files changed, 5

Re: [PATCH 0/3] Add OMAP hardware spinlock misc driver

2010-10-18 Thread Russell King - ARM Linux
On Mon, Oct 18, 2010 at 02:46:55PM +0200, Peter Zijlstra wrote: On Mon, 2010-10-18 at 09:44 +0200, Ohad Ben-Cohen wrote: OMAP4 introduces a Spinlock hardware module, which provides hardware assistance for synchronization and mutual exclusion between heterogeneous processors and those not

Re: [PATCH] arm: omap: complete removal of machine_desc.io_pg_offst and .phys_io

2010-10-18 Thread Russell King - ARM Linux
On Mon, Oct 18, 2010 at 06:27:36PM +0530, Anand Gadiyar wrote: Commit 861bd81ee6 in linux-next as of 20101018 (arm: remove machine_desc.io_pg_offst and .phys_io) missed out on updating a few boards. This causes the build of omap2plus_defconfig to fail. Fix this. Not quite true. The patch

Re: [PATCH] arm: omap: complete removal of machine_desc.io_pg_offst and .phys_io

2010-10-18 Thread Russell King - ARM Linux
On Mon, Oct 18, 2010 at 03:12:30PM +0100, Russell King - ARM Linux wrote: On Mon, Oct 18, 2010 at 06:27:36PM +0530, Anand Gadiyar wrote: Commit 861bd81ee6 in linux-next as of 20101018 (arm: remove machine_desc.io_pg_offst and .phys_io) missed out on updating a few boards. This causes

Re: [PATCH 0/3] Add OMAP hardware spinlock misc driver

2010-10-20 Thread Russell King - ARM Linux
On Tue, Oct 19, 2010 at 04:31:30PM -0700, Daniel Walker wrote: On Mon, 2010-10-18 at 09:44 +0200, Ohad Ben-Cohen wrote: OMAP4 introduces a Spinlock hardware module, which provides hardware assistance for synchronization and mutual exclusion between heterogeneous processors and those not

Re: [PATCH] ARM: Fix data abort accessing proc_info from __lookup_processor_type (Re: [PATCH 03/10] ARM: hotplug cpu: Keep processor information, startup code __lookup_processor_type)

2010-10-23 Thread Russell King - ARM Linux
On Fri, Oct 22, 2010 at 11:51:08AM -0700, Tony Lindgren wrote: diff --git a/arch/arm/kernel/vmlinux.lds.S b/arch/arm/kernel/vmlinux.lds.S index 1953e3d..a58b91d 100644 --- a/arch/arm/kernel/vmlinux.lds.S +++ b/arch/arm/kernel/vmlinux.lds.S @@ -114,6 +114,7 @@ SECTIONS

Re: [PATCH 1/8] staging: tidspbridge - remove req_addr from proc_map

2010-10-28 Thread Russell King - ARM Linux
On Wed, Oct 27, 2010 at 11:19:47AM +0300, Felipe Contreras wrote: Yes, but this has to be done on every library/app that is using the dsp. It's much easier to do it on kernel side. Besides, at least on gst-dsp we want it to work for _all_ bridge versions, so it would be: @@ -829,7 +829,9

Re: [PATCH] ARM: io: Fix namespace conflicts.

2010-11-23 Thread Russell King - ARM Linux
On Tue, Nov 23, 2010 at 03:01:17PM +0100, Uwe Kleine-König wrote: I wonder if it's not better to make these static inlines instead. Then no naming conflicts can occur. And maybe we'd catch some more strange things because p gets a proper type. I don't know how this influences gcc though.

Re: [PATCH v2 1/4] drivers: hwspinlock: add generic framework

2010-11-26 Thread Russell King - ARM Linux
On Fri, Nov 26, 2010 at 10:53:10AM +0200, Ohad Ben-Cohen wrote: +int __hwspin_trylock(struct hwspinlock *hwlock, int mode, unsigned long *flags) +{ +     int ret; + +     if (unlikely(!hwlock)) { +             pr_err(invalid hwlock\n); These kind of errors can get very spammy

Re: [PATCH v2 1/4] drivers: hwspinlock: add generic framework

2010-11-26 Thread Russell King - ARM Linux
On Fri, Nov 26, 2010 at 12:16:39PM +0200, Ohad Ben-Cohen wrote: On Fri, Nov 26, 2010 at 11:18 AM, Russell King - ARM Linux li...@arm.linux.org.uk wrote: On Fri, Nov 26, 2010 at 10:53:10AM +0200, Ohad Ben-Cohen wrote: +int __hwspin_trylock(struct hwspinlock *hwlock, int mode, unsigned

Re: [PATCH v2 1/4] drivers: hwspinlock: add generic framework

2010-11-26 Thread Russell King - ARM Linux
On Sat, Nov 27, 2010 at 12:18:55AM +0200, Ohad Ben-Cohen wrote: But then there's the other (quite reasonable) claim that says we shouldn't crash the machine because of a non fatal bug: if a crappy driver messes up, the user (not the developer) will most probably prefer the machine to keep

Re: [PATCH 2/8] ARM: cns3xxx: Add support for SMP

2010-11-30 Thread Russell King - ARM Linux
On Tue, Nov 30, 2010 at 08:17:00PM +0300, Anton Vorontsov wrote: Nothing fancy needs to be done, just use generic SCU routines. Signed-off-by: Anton Vorontsov avoront...@mvista.com This I assume is an age old patch. diff --git a/arch/arm/mach-cns3xxx/include/mach/smp.h

  1   2   3   4   5   6   7   8   9   10   >