Convert all the printk(level) messages in the driver to pr_level().
Signed-off-by: Víctor Manuel Jáquez Leal vjaq...@igalia.com
---
arch/arm/plat-omap/dmtimer.c |5 ++---
1 files changed, 2 insertions(+), 3 deletions(-)
diff --git a/arch/arm/plat-omap/dmtimer.c b/arch/arm/plat-omap
Convert a printk(KERN_ERR) message in the driver to pr_err(), and
use WARN() instead of a custom log message with a stack dump.
Signed-off-by: Víctor Manuel Jáquez Leal vjaq...@igalia.com
---
arch/arm/plat-omap/dmtimer.c |6 ++
1 files changed, 2 insertions(+), 4 deletions(-)
diff --git
Convert a printk(KERN_ERR) message in the driver to pr_err().
v2:
* Replaced dump_stack() with WARN()
v3:
* Rebased against omap/master
Signed-off-by: Víctor Manuel Jáquez Leal vjaq...@igalia.com
---
arch/arm/plat-omap/dmtimer.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff
The drv module has a drv_init() and a drv_exit() whose only purpose is
to keep a reference counting which is not used at all.
This patch removes these functions and the reference count variable.
There is no functional changes.
Signed-off-by: Víctor Manuel Jáquez Leal vjaq...@igalia.com
The cod module has a cod_init() and a cod_exit() whose only purpose is
to keep a reference counting which is not used at all.
This patch removes these functions and the reference count variable.
There is no functional changes.
Signed-off-by: Víctor Manuel Jáquez Leal vjaq...@igalia.com
The rmm module has a rmm_init() and a rmm_exit() whose only purpose is
to keep a reference counting which is not used at all.
This patch removes these functions and the reference count variable.
There is no functional changes.
Signed-off-by: Víctor Manuel Jáquez Leal vjaq...@igalia.com
The disp module has a disp_init() and a disp_exit() whose only purpose
is to keep a reference counting which is not used at all.
This patch removes these functions and the reference count variable.
There is no functional changes.
Signed-off-by: Víctor Manuel Jáquez Leal vjaq...@igalia.com
The chnl module has a chnl_init() and a chnl_exit() whose only purpose
is to keep a reference counting which is not used at all.
This patch removes these functions and the reference count variable.
There is no functional changes.
Signed-off-by: Víctor Manuel Jáquez Leal vjaq...@igalia.com
The strm module has a strm_init() and a strm_exit() whose only purpose
is to keep a reference counting which is not used at all.
This patch removes these functions and the reference count variable.
There is no functional changes.
Signed-off-by: Víctor Manuel Jáquez Leal vjaq...@igalia.com
, where no functional changes were implied.
Víctor Manuel Jáquez Leal (17):
staging: tidspbridge: remove drv_init() and drv_exit()
staging: tidspbridge: remove cod_init() and cod_exit()
staging: tidspbridge: remove proc_init() and proc_exit()
staging: tidspbridge: remove node_init
The node module has a node_init() and a node_exit() whose only purpose
is to keep a reference counting which is not used at all.
This patch removes these functions and the reference count variable.
There is no functional changes.
Signed-off-by: Víctor Manuel Jáquez Leal vjaq...@igalia.com
The msg module has a msg_mod_init() and a msg_exit() whose only
purpose is to keep a reference counting which is not used at all.
This patch removes these functions and the reference count variable.
There is no functional changes.
Signed-off-by: Víctor Manuel Jáquez Leal vjaq...@igalia.com
-by: Víctor Manuel Jáquez Leal vjaq...@igalia.com
---
drivers/staging/tidspbridge/rmgr/nldr.c |7 ++-
1 files changed, 2 insertions(+), 5 deletions(-)
diff --git a/drivers/staging/tidspbridge/rmgr/nldr.c
b/drivers/staging/tidspbridge/rmgr/nldr.c
index a9d7a32..46086b5 100644
--- a/drivers
The gh module has a gh_init() and a gh_exit(), but they don't do
anything, they are just noops.
This patch removes these functions.
There is no functional changes.
Signed-off-by: Víctor Manuel Jáquez Leal vjaq...@igalia.com
---
drivers/staging/tidspbridge/gen/gh.c | 18
The proc module has a proc_init() and a proc_exit() whose only purpose
is to keep a reference counting which is not used at all.
This patch removes these functions and the reference count variable.
There is no functional changes.
Signed-off-by: Víctor Manuel Jáquez Leal vjaq...@igalia.com
The dynamic loader was called by node.c with an interface. This interface was
also modified to avoid the use of nldr_init() and nldr_exit().
There is not functional changes.
Signed-off-by: Víctor Manuel Jáquez Leal vjaq...@igalia.com
---
.../staging/tidspbridge/include/dspbridge/nldr.h |2
The dev module has a dev_init() and a dev_exit() whose only purpose is
to keep a reference counting which is not used at all.
This patch removes these functions and the reference count variable.
There is no functional changes.
Signed-off-by: Víctor Manuel Jáquez Leal vjaq...@igalia.com
No functional changes.
Signed-off-by: Víctor Manuel Jáquez Leal vjaq...@igalia.com
---
drivers/staging/tidspbridge/rmgr/mgr.c |9 ++---
1 files changed, 2 insertions(+), 7 deletions(-)
diff --git a/drivers/staging/tidspbridge/rmgr/mgr.c
b/drivers/staging/tidspbridge/rmgr/mgr.c
index
The dmm module has a dmm_init() and a dmm_exit() whose only purpose is
to keep a reference counting which is not used at all.
This patch removes these functions and the reference count variable.
There is no functional changes.
Signed-off-by: Víctor Manuel Jáquez Leal vjaq...@igalia.com
The cmm module has a cmm_init() and a cmm_exit() whose only purpose is
to keep a reference counting which is not used at all.
This patch removes these functions and the reference count variable.
There is no functional changes.
Signed-off-by: Víctor Manuel Jáquez Leal vjaq...@igalia.com
The io module has a io_init() and a io_exit() whose only purpose is to
keep a reference counting which is not used at all.
This patch removes these functions and the reference count variable.
There is no functional changes.
Signed-off-by: Víctor Manuel Jáquez Leal vjaq...@igalia.com
No functional changes.
According to Lindent, the file drv_internface.c had some lines with bad
indentation.
This commit is the output of Lindent.
Signed-off-by: Víctor Manuel Jáquez Leal vjaq...@igalia.com
---
drivers/staging/tidspbridge/rmgr/drv_interface.c | 22 +++---
1
Silence the warning when compiling drv_interface.c
Signed-off-by: Víctor Manuel Jáquez Leal vjaq...@igalia.com
---
drivers/staging/tidspbridge/rmgr/drv_interface.c |5 +++--
1 files changed, 3 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/tidspbridge/rmgr/drv_interface.c
b
to know if I could keep
moving in this direction.
Thanks
vmjl
Víctor Manuel Jáquez Leal (5):
staging: tidspbridge: more readable code
staging: tidspbridge: remove unused header
staging: tidspbridge: Lindent to drv_interface.c
staging: tidspbridge: silence the compiler
staging: tidspbridge
No functional changes.
The header file drv_interface.h was only used locally, hence there's no need
to have it.
Also the only prototyped functions were the file_operations callbacks, then
this commit moves them up to avoid prototyping too.
Signed-off-by: Víctor Manuel Jáquez Leal vjaq
Uppercase function names are not pretty. Also the code flow readability is
enhanced.
Signed-off-by: Víctor Manuel Jáquez Leal vjaq...@igalia.com
---
drivers/staging/tidspbridge/rmgr/drv_interface.c | 13 ++---
1 files changed, 6 insertions(+), 7 deletions(-)
diff --git a/drivers
drv_interface.c include several header files that are not really used.
Signed-off-by: Víctor Manuel Jáquez Leal vjaq...@igalia.com
---
drivers/staging/tidspbridge/rmgr/drv_interface.c |7 ---
1 files changed, 0 insertions(+), 7 deletions(-)
diff --git a/drivers/staging/tidspbridge/rmgr
-true assert
vmjl
Víctor Manuel Jáquez Leal (8):
staging: tidspbridge: more readable code
staging: tidspbridge: remove unused header
staging: tidspbridge: Lindent to drv_interface.c
staging: tidspbridge: silence the compiler
staging: tidspbridge: remove header inclusions
staging
No functional changes.
The header file drv_interface.h was only used locally, hence there's no need
to have it.
Also the only prototyped functions were the file_operations callbacks, then
this commit moves them up to avoid prototyping too.
Signed-off-by: Víctor Manuel Jáquez Leal vjaq
Instead of assign it to a global variable which is not used anymore.
---
drivers/staging/tidspbridge/rmgr/drv_interface.c |5 +
1 files changed, 1 insertions(+), 4 deletions(-)
diff --git a/drivers/staging/tidspbridge/rmgr/drv_interface.c
The variable offset is not used but in the debug log, so I don't see reason to
calculate it here.
Signed-off-by: Víctor Manuel Jáquez Leal vjaq...@igalia.com
---
drivers/staging/tidspbridge/rmgr/drv_interface.c |5 ++---
1 files changed, 2 insertions(+), 3 deletions(-)
diff --git a/drivers
The function dsp_deinit() always return true, so assert its output is
pointless. As consequence the variable were the returned value is stored, is
no longer needed.
Signed-off-by: Víctor Manuel Jáquez Leal vjaq...@igalia.com
---
drivers/staging/tidspbridge/rmgr/drv_interface.c |4 +---
1
Silence the warning when compiling drv_interface.c
Signed-off-by: Víctor Manuel Jáquez Leal vjaq...@igalia.com
---
drivers/staging/tidspbridge/rmgr/drv_interface.c |5 +++--
1 files changed, 3 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/tidspbridge/rmgr/drv_interface.c
b
No functional changes.
According to Lindent, the file drv_internface.c had some lines with bad
indentation.
This commit is the output of Lindent.
Signed-off-by: Víctor Manuel Jáquez Leal vjaq...@igalia.com
---
drivers/staging/tidspbridge/rmgr/drv_interface.c | 12 ++--
1 files
drv_interface.c include several header files that are not really used.
Signed-off-by: Víctor Manuel Jáquez Leal vjaq...@igalia.com
---
drivers/staging/tidspbridge/rmgr/drv_interface.c |7 ---
1 files changed, 0 insertions(+), 7 deletions(-)
diff --git a/drivers/staging/tidspbridge/rmgr
Uppercase function names are not pretty. Also the code flow readability is
enhanced.
Signed-off-by: Víctor Manuel Jáquez Leal vjaq...@igalia.com
---
drivers/staging/tidspbridge/rmgr/drv_interface.c | 13 ++---
1 files changed, 6 insertions(+), 7 deletions(-)
diff --git a/drivers
int', but argument 9 has type 'pgprot_t'
This patch fixes that warning message.
Signed-off-by: Víctor Manuel Jáquez Leal vjaq...@igalia.com
---
drivers/staging/tidspbridge/rmgr/drv_interface.c |5 +++--
1 files changed, 3 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/tidspbridge
CONFIG_TIDSPBRIDGE_DEBUG,
using only TIDSPBRIDGE_BACKTRACE for enabling the debug trace messages.
Signed-off-by: Víctor Manuel Jáquez Leal vjaq...@igalia.com
---
drivers/staging/tidspbridge/Kconfig|6 --
drivers/staging/tidspbridge/core/io_sm.c | 12
All the macros in dbc.h are removed now so this patch removes it completely.
Signed-off-by: Víctor Manuel Jáquez Leal vjaq...@igalia.com
---
drivers/staging/tidspbridge/core/chnl_sm.c |3 --
drivers/staging/tidspbridge/core/dsp-clock.c |3 --
drivers/staging/tidspbridge
at the end, and should be removed.
* Deleting them means less code to maintain
As the Emperor Joseph II told to Mozart in the motion picture Amadeus:
It's quality work. And there are simply too many notes, that's
all. Just cut a few and it will be perfect.
vmjl
Víctor Manuel Jáquez Leal (4):
staging
This macro is only valid when CONFIG_TIDSPBRDIGE_DEBUG is enabled and it only
prints a log message, it is not a real assertion mechanism like BUG_ON() or
WARN_ON().
It is better to remove them: less code to maintain.
Signed-off-by: Víctor Manuel Jáquez Leal vjaq...@igalia.com
---
drivers
41 matches
Mail list logo
