Re: [PATCH V3 1/2] of: Add generic device tree DMA helpers

2012-07-13 Thread Vinod Koul
On Wed, 2012-06-27 at 15:20 +, Arnd Bergmann wrote: Back from vacation... so restart the pending discussion Sorry, I believe I was just using the wrong terminology, and what I named the slave here would just be the client. This may have contributed to a lot of confusion before, so

Re: [PATCH V3 1/2] of: Add generic device tree DMA helpers

2012-07-13 Thread Vinod Koul
On Fri, 2012-07-06 at 13:36 +0200, Guennadi Liakhovetski wrote: On Mon, 25 Jun 2012, Arnd Bergmann wrote: [snip] The channel data in the device tree is still in a format that is specific to that dmaengine driver and interpreted by it. Using the regular dma_filter_fn prototype is not

Re: [PATCH V3 1/2] of: Add generic device tree DMA helpers

2012-07-19 Thread Vinod Koul
On Tue, 2012-07-17 at 19:24 +, Arnd Bergmann wrote: On Friday 13 July 2012, Vinod Koul wrote: Do you mean there must be a global table, or are you ok with putting the information about a channel into the device that uses the channel, as we do for most other subsystems (IRQ, GPIO

Re: [PATCH V3 1/2] of: Add generic device tree DMA helpers

2012-07-20 Thread Vinod Koul
On Fri, 2012-07-20 at 08:39 +, Arnd Bergmann wrote: On Friday 20 July 2012, Vinod Koul wrote: Required property: dmas: list of one or more dma specifiers, each consisting of - phandle pointing to dma controller node - flags word, a bit map that can hold these flags

Re: [PATCH V3 1/2] of: Add generic device tree DMA helpers

2012-07-20 Thread Vinod Koul
On Fri, 2012-07-20 at 11:08 +0200, Robert Jarzmik wrote: Vinod Koul vinod.k...@linux.intel.com writes: 4. A dma controller requiring complex configuration: dma: dmaengine@4800 { compatible = foo,foo-sdma reg = 0x4800 0x1000

Re: [PATCH V3 1/2] of: Add generic device tree DMA helpers

2012-07-26 Thread Vinod Koul
On Tue, 2012-07-24 at 14:07 -0500, Jon Hunter wrote: Hi Vinod, Required property: dmas: list of one or more dma specifiers, each consisting of - phandle pointing to dma controller node - flags word, a bit map that can hold these flags * 0x0001 channel can be

Re: [PATCH V3 1/2] of: Add generic device tree DMA helpers

2012-07-26 Thread Vinod Koul
On Thu, 2012-07-26 at 07:14 +, Arnd Bergmann wrote: On Thursday 26 July 2012, Vinod Koul wrote: But from a client POV it makes sense as with the given direction you would need a specific request line for a channel. So this is right. But direction is something I don't expect

Re: [PATCH V3 1/2] of: Add generic device tree DMA helpers

2012-07-31 Thread Vinod Koul
On Thu, 2012-07-26 at 10:53 -0500, Jon Hunter wrote: On 07/26/2012 06:28 AM, Vinod Koul wrote: On Thu, 2012-07-26 at 07:14 +, Arnd Bergmann wrote: On Thursday 26 July 2012, Vinod Koul wrote: But from a client POV it makes sense as with the given direction you would need a specific

Re: [PATCH V3 1/2] of: Add generic device tree DMA helpers

2012-07-31 Thread Vinod Koul
On Thu, 2012-07-26 at 12:43 -0500, Jon Hunter wrote: So yes I can see that a channel itself could be configured to support a given direction, but when we ask for a channel via dma_request_channel() we are going to get a channel that matches the criteria we pass using the filter

Re: [PATCH V3 1/2] of: Add generic device tree DMA helpers

2012-08-03 Thread Vinod Koul
On Wed, 2012-08-01 at 15:43 -0500, Jon Hunter wrote: Hi Vinod, On 07/31/2012 06:12 AM, Vinod Koul wrote: On Thu, 2012-07-26 at 12:43 -0500, Jon Hunter wrote: So yes I can see that a channel itself could be configured to support a given direction, but when we ask for a channel via

Re: [RFC] dmaengine: Moving TI SDMA driver to dmaengine - design plan

2011-07-12 Thread Vinod Koul
? -- ~Vinod Koul Intel Corp. -- To unsubscribe from this list: send the line unsubscribe linux-omap in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH v2 04/15] dmaengine: Pass no_wakeup parameter via device_prep_dma_cyclic() callback

2012-09-13 Thread Vinod Koul
On Thu, 2012-09-13 at 16:37 +0300, Peter Ujfalusi wrote: Change the parameter list of device_prep_dma_cyclic() so the DMA drivers can receive the no_wakeup request coming from client drivers. This feature can be used during audio operation to disable all audio related interrupts. We already

Re: [PATCH v2 03/15] dmaengine: Add no_wakeup parameter to dmaengine_prep_dma_cyclic()

2012-09-13 Thread Vinod Koul
On Thu, 2012-09-13 at 17:27 +0200, Lars-Peter Clausen wrote: Hi, Hm... Do you think it would work as well if we implement this by setting the callback for the descriptor to NULL? If the callback is NULL there is nothing to at the end of a transfer/period and the dma engine driver may

Re: [PATCH v2 03/15] dmaengine: Add no_wakeup parameter to dmaengine_prep_dma_cyclic()

2012-09-13 Thread Vinod Koul
On Thu, 2012-09-13 at 16:38 +0100, Russell King - ARM Linux wrote: On Thu, Sep 13, 2012 at 05:27:09PM +0200, Lars-Peter Clausen wrote: Hm... Do you think it would work as well if we implement this by setting the callback for the descriptor to NULL? If the callback is NULL there is nothing

Re: [PATCH v2 03/15] dmaengine: Add no_wakeup parameter to dmaengine_prep_dma_cyclic()

2012-09-14 Thread Vinod Koul
On Fri, 2012-09-14 at 10:13 +0200, Lars-Peter Clausen wrote: On 09/14/2012 05:26 AM, Vinod Koul wrote: On Thu, 2012-09-13 at 17:27 +0200, Lars-Peter Clausen wrote: Hi, Hm... Do you think it would work as well if we implement this by setting the callback for the descriptor to NULL

Re: [PATCH v2 03/15] dmaengine: Add no_wakeup parameter to dmaengine_prep_dma_cyclic()

2012-09-14 Thread Vinod Koul
On Fri, 2012-09-14 at 12:28 +0300, Peter Ujfalusi wrote: Hi, On 09/14/2012 11:50 AM, Vinod Koul wrote: Well, the idea was that the driver would disable interrupts if there is no callback to call, since there would be nothing to do in the interrupt handler anyway. But I guess the flags

Re: [PATCH v3 02/15] dmaengine: omap: Add support for pause/resume in cyclic dma mode

2012-09-16 Thread Vinod Koul
On Fri, 2012-09-14 at 15:05 +0300, Peter Ujfalusi wrote: - /* FIXME: not supported by platform private API */ - return -EINVAL; + /* Pause/Resume only allowed with cyclic mode */ + if (!c-cyclic) + return -EINVAL; This is not a dma restriction right? --

Re: [PATCH v3 00/15] ASoC: OMAP: Convert to use dmaengine

2012-09-16 Thread Vinod Koul
On Fri, 2012-09-14 at 15:05 +0300, Peter Ujfalusi wrote: Hello, dmaengine parts look good to me. How do you want to get this merged, dmaengine or ASoC tree? Changes since v2: - As it has been discussed the no_wakeup parameter has been replaced with flags for the dmaengine APIs

Re: [PATCH V6 2/2] dmaengine: add helper function to request a slave DMA channel

2012-09-16 Thread Vinod Koul
On Fri, 2012-09-14 at 17:41 -0500, Jon Hunter wrote: +/** + * dma_request_slave_channel - try to allocate an exclusive slave channel + * @dev: pointer to client device structure + * @name: slave channel name + */ +struct dma_chan *dma_request_slave_channel(struct device *dev,

Re: [alsa-devel] [PATCH v3 00/15] ASoC: OMAP: Convert to use dmaengine

2012-09-17 Thread Vinod Koul
On Mon, 2012-09-17 at 11:44 +0300, Peter Ujfalusi wrote: Hi Vinod, On 09/17/2012 06:17 AM, Vinod Koul wrote: On Fri, 2012-09-14 at 15:05 +0300, Peter Ujfalusi wrote: Hello, dmaengine parts look good to me. How do you want to get this merged, dmaengine or ASoC tree? Thank you, I

Re: [PATCH v3 02/15] dmaengine: omap: Add support for pause/resume in cyclic dma mode

2012-09-17 Thread Vinod Koul
by the audio stack. Signed-off-by: Peter Ujfalusi peter.ujfal...@ti.com CC: Russell King rmk+ker...@arm.linux.org.uk --- Acked-by: Vinod Koul vinod.k...@linux.intel.com -- ~Vinod -- To unsubscribe from this list: send the line unsubscribe linux-omap in the body of a message to majord

Re: [PATCH v3 03/15] dmaengine: Add flags parameter to dmaengine_prep_dma_cyclic()

2012-09-17 Thread Vinod Koul
the from audio to ask dma drivers to suppress interrupts (if DMA_PREP_INTERRUPT is cleared) when it is supported on the platform. Signed-off-by: Peter Ujfalusi peter.ujfal...@ti.com CC: Lars-Peter Clausen l...@metafoo.de --- Acked-by: Vinod Koul vinod.k...@linux.intel.com -- ~Vinod

Re: [PATCH v3 04/15] dmaengine: Pass flags via device_prep_dma_cyclic() callback

2012-09-17 Thread Vinod Koul
is cleared from the flags. Acked-by: Vinod Koul vinod.k...@linux.intel.com -- ~Vinod -- To unsubscribe from this list: send the line unsubscribe linux-omap in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH v3 05/15] dmaengine: omap-dma: Add support to suppress interrupts in cyclic mode

2012-09-17 Thread Vinod Koul
support this type of mode. Acked-by: Vinod Koul vinod.k...@linux.intel.com -- ~Vinod -- To unsubscribe from this list: send the line unsubscribe linux-omap in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH V6 2/2] dmaengine: add helper function to request a slave DMA channel

2012-09-17 Thread Vinod Koul
On Mon, 2012-09-17 at 11:59 +, Arnd Bergmann wrote: On Monday 17 September 2012, Vinod Koul wrote: I believe that Jon is on vacation this week, so if this is the only issue holding up the merge, maybe you can change this in his patch directly, or I can send an updated version if you

Re: [PATCH V6 2/2] dmaengine: add helper function to request a slave DMA channel

2012-09-17 Thread Vinod Koul
On Mon, 2012-09-17 at 23:36 +0100, Russell King - ARM Linux wrote: I believe that Jon is on vacation this week, so if this is the only issue holding up the merge, maybe you can change this in his patch directly, or I can send an updated version if you prefer. I worry that too much is

Re: [PATCH v2 04/15] dmaengine: Pass no_wakeup parameter via device_prep_dma_cyclic() callback

2012-09-18 Thread Vinod Koul
On Tue, 2012-09-18 at 09:31 +0100, Russell King - ARM Linux wrote: On Mon, Sep 17, 2012 at 11:01:23AM +0200, Linus Walleij wrote: On Thu, Sep 13, 2012 at 3:37 PM, Peter Ujfalusi peter.ujfal...@ti.com wrote: Change the parameter list of device_prep_dma_cyclic() so the DMA drivers can

Re: [PATCH V6 2/2] dmaengine: add helper function to request a slave DMA channel

2012-09-24 Thread Vinod Koul
On Mon, 2012-09-24 at 17:25 -0500, Jon Hunter wrote: For DT bindings, I think the binding itself shouldn't change based on my work but I would like these same bindings to help build the DMA engine code mappings. Now would it make sense to NOT merge these changes for 3.7 and postpone

Re: [RFC PATCH 10/13] spi: omap2-mcspi: dma_request_slave_channel() support for DT platforms

2012-09-27 Thread Vinod Koul
On Fri, 2012-09-21 at 14:37 -0400, Matt Porter wrote: On Fri, Sep 21, 2012 at 08:42:47AM -0700, Tony Lindgren wrote: Can't we come up with a version of dma_request_slave_channel that works both ways for now: mcspi_dma-dma_rx = dma_request_slave_channel_compat(mask,

Re: [RFC PATCH 08/13] mmc: omap_hsmmc: limit max_segs with the EDMA DMAC

2012-09-27 Thread Vinod Koul
On Fri, 2012-09-21 at 19:47 +0100, Russell King - ARM Linux wrote: On Fri, Sep 21, 2012 at 10:45:29PM +0530, S, Venkatraman wrote: On Thu, Sep 20, 2012 at 8:13 PM, Matt Porter mpor...@ti.com wrote: The EDMA DMAC has a hardware limitation that prevents supporting scatter gather lists with

Re: [RFC PATCH 08/13] mmc: omap_hsmmc: limit max_segs with the EDMA DMAC

2012-10-02 Thread Vinod Koul
On Mon, 2012-10-01 at 12:39 -0400, Matt Porter wrote: Anything you can show at this point? ;) I'd be happy to drop the half-hack for a real API. If not, I'm going to carry that to v2 atm. This is what I had done sometime back. Feel free to update diff --git a/include/linux/dmaengine.h

Re: [PATCH V6 2/2] dmaengine: add helper function to request a slave DMA channel

2012-10-15 Thread Vinod Koul
On Tue, 2012-10-16 at 10:43 +0800, Shawn Guo wrote: On Tue, Sep 25, 2012 at 10:05:01AM +0530, Vinod Koul wrote: On Mon, 2012-09-24 at 17:25 -0500, Jon Hunter wrote: For DT bindings, I think the binding itself shouldn't change based on my work but I would like these same bindings to help

Re: [RFC 00/12] OMAP DMA engine conversion

2012-05-14 Thread Vinod Koul
On Mon, 2012-04-23 at 17:04 +0100, Russell King - ARM Linux wrote: For the full text, please see http://lists.arm.linux.org.uk/lurker/message/20120418.100954.7fa7acf8.en.html This version contains updates for some of the comments received from the previous round, and adds the OMAP1/2 MMC

Re: [RFC 00/12] OMAP DMA engine conversion

2012-05-15 Thread Vinod Koul
On Tue, 2012-05-15 at 08:41 +0100, Russell King - ARM Linux wrote: On Tue, May 15, 2012 at 09:49:24AM +0530, Vinod Koul wrote: On Mon, 2012-04-23 at 17:04 +0100, Russell King - ARM Linux wrote: For the full text, please see http://lists.arm.linux.org.uk/lurker/message

Re: RFC: changing DMA slave configuration API

2012-06-10 Thread Vinod Koul
On Sun, 2012-06-10 at 12:22 +0100, Russell King - ARM Linux wrote: On Sun, Jun 10, 2012 at 07:19:47PM +0800, Barry Song wrote: 2012/6/10 Russell King - ARM Linux li...@arm.linux.org.uk: Dan, Vinod, There's a change I would like to do to the DMA slave configuration. It's currently a

Re: RFC: changing DMA slave configuration API

2012-06-12 Thread Vinod Koul
On Mon, 2012-06-11 at 17:33 +0800, Dong Aisheng wrote: I think it is a good idea. And I would like to extend it even a little bit. Do we have any users of peripheral to peripheral slave dma? Yes, IMX sdma does support such kind of transfer. The driver still does not support it currently.

Re: RFC: changing DMA slave configuration API

2012-06-12 Thread Vinod Koul
On Mon, 2012-06-11 at 09:24 +0100, Russell King - ARM Linux wrote: On Mon, Jun 11, 2012 at 10:20:49AM +0530, Vinod Koul wrote: I think it is a good idea. And I would like to extend it even a little bit. Do we have any users of peripheral to peripheral slave dma? IIRC that is not the case

Re: [RFC 0/3] Add cyclic DMA support to OMAP DMA engine driver

2012-06-25 Thread Vinod Koul
Hi Russell, What is the status of the virtual dma and the series you have posted previously. Is it ready for merge? I would be away for 10days starting coming Thursday. So please let me know On Fri, 2012-06-22 at 09:59 +0100, Russell King - ARM Linux wrote: These three patches add support for

Re: [PATCH V3 1/2] of: Add generic device tree DMA helpers

2012-06-25 Thread Vinod Koul
On Mon, 2012-06-25 at 11:51 -0500, Jon Hunter wrote: Hi Russell, On 06/22/2012 06:12 PM, Russell King - ARM Linux wrote: Before this goes much further... one fairly obvious and important point must be made. You're designing an API here. You're designing it *WITHOUT* involving the

Re: [PATCH V3 1/2] of: Add generic device tree DMA helpers

2012-06-26 Thread Vinod Koul
On Mon, 2012-06-25 at 20:30 +, Arnd Bergmann wrote: dma_request_channel is called with some information about the channel provided in its arguments, and the driver might get that from a number of places. Today, we just ask for a channel with specific mask. Further filtering is done in

Re: [PATCH V3 1/2] of: Add generic device tree DMA helpers

2012-06-26 Thread Vinod Koul
On Tue, 2012-06-26 at 14:59 +, Arnd Bergmann wrote: On Tuesday 26 June 2012, Vinod Koul wrote: Today, we just ask for a channel with specific mask. Further filtering is done in filter function as we request a channel, not a specific one. In most slave cases, we need a specific channel

Re: [PATCH V3 1/2] of: Add generic device tree DMA helpers

2012-06-27 Thread Vinod Koul
On Tue, 2012-06-26 at 20:27 +, Arnd Bergmann wrote: On Tuesday 26 June 2012, Vinod Koul wrote: On Tue, 2012-06-26 at 14:59 +, Arnd Bergmann wrote: On Tuesday 26 June 2012, Vinod Koul wrote: Today, we just ask for a channel with specific mask. Further filtering is done

Re: [PATCH V6 2/2] dmaengine: add helper function to request a slave DMA channel

2012-11-15 Thread Vinod Koul
On Fri, 2012-11-09 at 14:01 -0600, Jon Hunter wrote: Hi Vinod, A few people have been asking me if getting device-tree support for DMA engine is plan for record for v3.8. I know that you were working through implementing a common interface and so I wanted to check how that is going. Do you

Re: [PATCH V6 2/2] dmaengine: add helper function to request a slave DMA channel

2012-11-28 Thread Vinod Koul
the branch to my next. It should show up in linux-next tomorrow Please check Thanks -- Vinod Koul Intel Corp. -- To unsubscribe from this list: send the line unsubscribe linux-omap in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo

Re: [PATCH] of: dma: Fix-up for warnings !CONFIG_OF

2012-11-29 Thread Vinod Koul
On Thu, 2012-11-29 at 16:24 -0600, Jon Hunter wrote: When compiling the kernel with DMA engine support enabled and device-tree support disabled, the following warnings are observed. Thanks, already committed same change last night. In file included from drivers/dma/dmaengine.c:65:0:

Re: [PATCH V6 2/2] dmaengine: add helper function to request a slave DMA channel

2012-12-20 Thread Vinod Koul
, just merged and pushed those. Pull request should show up in couple of days. Thanks -- Vinod Koul Intel Corp. -- To unsubscribe from this list: send the line unsubscribe linux-omap in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo

Re: Build failure with DMA_OMAP=m and a caller built-in

2013-01-08 Thread Vinod Koul
On Mon, Jan 07, 2013 at 08:38:34PM +, Russell King - ARM Linux wrote: On Mon, Jan 07, 2013 at 12:21:06PM -0800, Tony Lindgren wrote: * Ben Hutchings b...@decadent.org.uk [130105 21:29]: Various drivers use omap_dma_filter_fn() but don't depend on DMA_OMAP. This is fine because there

Re: [RESEND][PATCH] dma: edma: fix slave config dependency on direction

2013-01-20 Thread Vinod Koul
On Thu, Jan 10, 2013 at 01:41:04PM -0500, Matt Porter wrote: The edma_slave_config() implementation depends on the direction field such that it will not properly configure a slave channel when called without direction set. This fixes the implementation so that the slave config is copied as

Re: [PATCH v7 07/10] dmaengine: add dma_request_slave_channel_compat()

2013-02-12 Thread Vinod Koul
t...@atomide.com Acked-by: Arnd Bergmann a...@arndb.de Acked-by: Vinod Koul vinod.k...@intel.com --- include/linux/dmaengine.h | 16 1 file changed, 16 insertions(+) diff --git a/include/linux/dmaengine.h b/include/linux/dmaengine.h index bfcdecb..17d8ffd 100644

Re: crypto: omap-sham, omap-aes and dma_request_slave_channel_compat()

2013-02-26 Thread Vinod Koul
On Tue, Feb 26, 2013 at 03:52:05PM -0700, Mark A. Greer wrote: [CC'ing more people lists.] On Tue, Feb 26, 2013 at 11:36:46AM -0700, Tim Gardner wrote: Whats up with commits 0e87e73f4abe1ada69cf780fe2550c6361a1b53b and b4b87a934c30fb91cbdd18ae028acdc361e1cf0f. As far as I can tell,

Re: crypto: omap-sham, omap-aes and dma_request_slave_channel_compat()

2013-02-27 Thread Vinod Koul
On Wed, Feb 27, 2013 at 09:36:03PM +, Arnd Bergmann wrote: On Wednesday 27 February 2013, Vinod Koul wrote: Yes we had agreed that I will send it. I have applied this one now, and will send second PULL request to Linus soon. Arnd, The second patch of dw_dmac you wnated

Re: [PATCH V3 2/2] dmaengine: OMAP: Register SDMA controller with Device Tree DMA driver

2013-04-01 Thread Vinod Koul
On Mon, Apr 01, 2013 at 12:48:26PM -0500, Jon Hunter wrote: Vinod, On 03/20/2013 11:36 AM, Tony Lindgren wrote: * Jon Hunter jon-hun...@ti.com [130319 09:08]: Vinod, Tony, Benoit, On 02/26/2013 12:27 PM, Jon Hunter wrote: If the device-tree blob is present during boot, then register

Re: [RFC v2] dmaengine: omap-dma: Start DMA without delay for cyclic channels

2013-04-09 Thread Vinod Koul
On Tue, Apr 09, 2013 at 09:19:31AM +0200, Peter Ujfalusi wrote: On 04/09/2013 08:52 AM, Santosh Shilimkar wrote: I suggest Peter resend the patch with also Grant + Linus W cc:d so they can queue it unless there are other related patches pending somewhere else. Am curious on your

Re: [PATCH] dmaengine: omap-dma: Start DMA without delay for cyclic channels

2013-04-09 Thread Vinod Koul
On Tue, Apr 09, 2013 at 04:33:06PM +0200, Peter Ujfalusi wrote: cyclic DMA is only used by audio which needs DMA to be started without a delay. If the DMA for audio is started using the tasklet we experience random channel switch (to be more precise: channel shift). Reported-by: Peter

Re: [PATCH 1/3] dmaengine: add dma_get_slave_sg_limits()

2013-07-18 Thread Vinod Koul
On Thu, Jul 18, 2013 at 11:46:39AM -0500, Joel Fernandes wrote: From: Matt Porter mpor...@ti.com Add a dmaengine API to retrieve slave SG transfer limits. The API is optionally implemented by dmaengine drivers and when unimplemented will return a NULL pointer. A client driver using this

Re: [PATCH] dma: edma: add device_slave_caps() support

2013-07-24 Thread Vinod Koul
On Wed, Jul 24, 2013 at 01:55:24PM -0500, Joel Fernandes wrote: On 07/24/2013 03:40 AM, Lars-Peter Clausen wrote: On 07/24/2013 10:28 AM, Fernandes, Joel wrote: Vinod, or Dan- If this patch looks ok, can you please merge in for -rc cycle? This patch is required to fix MMC support on AM33xx.

Re: [PATCH] dma: edma: add device_slave_caps() support

2013-07-25 Thread Vinod Koul
On Wed, Jul 24, 2013 at 02:36:26PM -0500, Joel Fernandes wrote: Also another point worth considering is the approach Russell suggested, I havent gotten a chance to dig deeper but if I understood it correctly then programming the device_dma_parameters should be the right thing to do.

Re: [PATCH 1/3] dmaengine: add dma_get_slave_sg_limits()

2013-07-29 Thread Vinod Koul
On Thu, Jul 18, 2013 at 01:57:33PM -0500, Joel Fernandes wrote: On 07/18/2013 12:08 PM, Russell King - ARM Linux wrote: As for the maximum number of scatterlist entries, really that's a bug in the DMA engine implementations if they can't accept arbitary lengths. I've created DMA engine

Re: [PATCH] dma: edma: add device_slave_caps() support

2013-07-29 Thread Vinod Koul
On Thu, Jul 25, 2013 at 12:53:51PM +0530, Vinod Koul wrote: On Wed, Jul 24, 2013 at 02:36:26PM -0500, Joel Fernandes wrote: Also another point worth considering is the approach Russell suggested, I havent gotten a chance to dig deeper but if I understood it correctly

Re: [PATCH] DMA: let filter functions of of_dma_simple_xlate possible check of_node

2013-08-26 Thread Vinod Koul
On Mon, Aug 26, 2013 at 03:18:00PM +0200, Laurent Pinchart wrote: Hi Richard, (Dropping Dan Williams from the CC list as his e-mail address doesn't seem to be valid anymore) Hmm. Looking at the patch, I'm not sure it's right. This patch simply passes all the specfier args

Re: [PATCH] DMA: let filter functions of of_dma_simple_xlate possible check of_node

2013-08-28 Thread Vinod Koul
On Mon, Aug 26, 2013 at 08:15:17PM +0200, Arnd Bergmann wrote: On Monday 26 August 2013 19:40:57 Vinod Koul wrote: And the selection should be done for the cases where you dont have programmable mux in dmac. For programmable ones passing slave_id in dma_slave_config should be fine

Re: [PATCH v4 2/6] dma: edma: Write out and handle MAX_NR_SG at a given time

2013-09-02 Thread Vinod Koul
On Thu, Aug 29, 2013 at 06:05:41PM -0500, Joel Fernandes wrote: Process SG-elements in batches of MAX_NR_SG if they are greater than MAX_NR_SG. Due to this, at any given time only those many slots will be used in the given channel no matter how long the scatter list is. We keep track of how

Re: [PATCH v3 5/5] dma: cppi41: add support for suspend and resume

2013-09-22 Thread Vinod Koul
On Sun, Sep 22, 2013 at 04:50:04PM +0200, Daniel Mack wrote: This patch adds support for suspend/resume functionality to the cppi41 DMA driver. The steps necessary to make the system resume properly were figured out by trial-and-error. The code as it stands now is the minimum that has to be

Re: [PATCH v3 2/5] dma: cppi41: s/deinit_cpii41/deinit_cppi41/

2013-09-22 Thread Vinod Koul
On Sun, Sep 22, 2013 at 04:50:01PM +0200, Daniel Mack wrote: Fix a misspelled function name. Signed-off-by: Daniel Mack zon...@gmail.com Applied, thanks ~Vinod -- -- To unsubscribe from this list: send the line unsubscribe linux-omap in the body of a message to majord...@vger.kernel.org More

Re: [PATCH v3 1/5] dma: cppi41: pass around device instead of platform_device

2013-09-22 Thread Vinod Koul
On Sun, Sep 22, 2013 at 04:50:00PM +0200, Daniel Mack wrote: Instead of passing around struct plafform_device, use struct device and save one level of dereferencing. This affects the following functions: * cppi41_add_chans * purge_descs * deinit_cpii41 * init_descs * init_cppi41 *

Re: [PATCH v3 3/5] dma: cppi41: add shortcut to pdev-dev in cppi41_dma_probe()

2013-09-22 Thread Vinod Koul
On Sun, Sep 22, 2013 at 04:50:02PM +0200, Daniel Mack wrote: Makes the code more readable and compact. No functional change. Signed-off-by: Daniel Mack zon...@gmail.com Applied, thanks ~Vinod -- -- To unsubscribe from this list: send the line unsubscribe linux-omap in the body of a message

Re: [PATCH v3 4/5] dma: cppi41: only allocate descriptor memory once

2013-09-22 Thread Vinod Koul
On Sun, Sep 22, 2013 at 04:50:03PM +0200, Daniel Mack wrote: cdd-cd and cdd-descs_phys are allocated DESCS_AREAS times from init_descs() and freed as often from purge_descs(). This leads to both memory leaks and double-frees. Fix this by pulling the calls to dma_{alloc,free}_coherent() out

Re: [PATCH v3 5/5] dma: cppi41: add support for suspend and resume

2013-09-23 Thread Vinod Koul
On Mon, Sep 23, 2013 at 07:53:11AM +0200, Daniel Mack wrote: On 23.09.2013 06:09, Vinod Koul wrote: On Sun, Sep 22, 2013 at 04:50:04PM +0200, Daniel Mack wrote: +#ifdef CONFIG_PM_SLEEP a +static int cppi41_suspend(struct device *dev) +{ + struct cppi41_dd *cdd

Re: [PATCH v3 5/5] dma: cppi41: add support for suspend and resume

2013-09-23 Thread Vinod Koul
On Sun, Sep 22, 2013 at 04:50:04PM +0200, Daniel Mack wrote: This patch adds support for suspend/resume functionality to the cppi41 DMA driver. The steps necessary to make the system resume properly were figured out by trial-and-error. The code as it stands now is the minimum that has to be

Re: [alsa-devel] [PATCH 23/51] DMA-API: dma: pl08x: add dma_set_mask_and_coherent() call

2013-09-23 Thread Vinod Koul
On Thu, Sep 19, 2013 at 10:48:01PM +0100, Russell King wrote: The DMA API requires drivers to call the appropriate dma_set_mask() functions before doing any DMA mapping. Add this required call to the AMBA PL08x driver. Signed-off-by: Russell King rmk+ker...@arm.linux.org.uk Acked-by: Vinod

Re: [alsa-devel] [PATCH 43/51] DMA-API: dma: edma.c: no need to explicitly initialize DMA masks

2013-09-23 Thread Vinod Koul
-off-by: Russell King rmk+ker...@arm.linux.org.uk Acked-by: Vinod Koul vinod.k...@intel.com This also brings me question that should we force the driver to use the dma_set_mask_and_coherent() API or they have below flexiblity too? ~Vinod --- drivers/dma/edma.c |6 ++ 1 files changed

Re: [alsa-devel] [PATCH 24/51] DMA-API: dma: pl330: add dma_set_mask_and_coherent() call

2013-09-23 Thread Vinod Koul
doing any DMA mapping. Add this required call to the AMBA PL08x driver. ^--- copy and paste error - should of course be PL330 Fixed, thanks. with fixed changelog... Acked-by: Vinod Koul vinod.k...@intel.com ~Vinod -- -- To unsubscribe from this list: send the line

Re: [PATCH v3 4/5] dma: cppi41: only allocate descriptor memory once

2013-09-23 Thread Vinod Koul
On Mon, Sep 23, 2013 at 04:51:06PM +0200, Sebastian Andrzej Siewior wrote: On 09/23/2013 06:17 AM, Vinod Koul wrote: Looks fine, Sebastian cna you test it pls Just noticed that you already applied some of them. I just got back after a few weeks of. Will review test as soon as I get

Re: [PATCH 2/3] dma: edma: Add support for Cyclic DMA

2013-10-21 Thread Vinod Koul
On Mon, Sep 23, 2013 at 06:05:14PM -0500, Joel Fernandes wrote: @@ -449,6 +455,138 @@ static struct dma_async_tx_descriptor *edma_prep_slave_sg( return vchan_tx_prep(echan-vchan, edesc-vdesc, tx_flags); } +static struct dma_async_tx_descriptor *edma_prep_dma_cyclic( + struct

Re: [PATCH 1/3] dma: edma: Split out PaRAM set calculations into its own function

2013-10-21 Thread Vinod Koul
On Mon, Sep 23, 2013 at 06:05:13PM -0500, Joel Fernandes wrote: PaRAM set calculation is abstracted into its own function to enable better reuse for other DMA cases such as cyclic. We adapt the Slave SG case to use the new function. This provides a much cleaner abstraction to the internals

Re: [PATCH 3/3] dma: edma: Increase maximum SG limit to 20

2013-10-21 Thread Vinod Koul
On Mon, Sep 23, 2013 at 06:05:15PM -0500, Joel Fernandes wrote: davinci-pcm uses 16 as the no.of periods. With this, in EDMA we have to allocate atleast 17 slots: 1 slot for channel, and 16 slots the periods. Due to this, the MAX_NR_SG limitation causes problems, set it to 20 to make cyclic

Re: [PATCH 2/3] dma: edma: Add support for Cyclic DMA

2013-10-24 Thread Vinod Koul
On Tue, Oct 22, 2013 at 10:30:43AM -0500, Joel Fernandes wrote: On 10/21/2013 01:53 AM, Vinod Koul wrote: On Mon, Sep 23, 2013 at 06:05:14PM -0500, Joel Fernandes wrote: + nr_periods = (buf_len / period_len) + 1; ? consider the case of buf = period_len, above makes nr_period = 2

Re: [PATCH 2/3] dma: edma: Add support for Cyclic DMA

2013-10-31 Thread Vinod Koul
On Thu, Oct 24, 2013 at 12:57:02PM -0500, Joel Fernandes wrote: Rebased on slave-dma/next branch and reapplied: Looks like your MUA caused lines to get wrapped and patch is corrupt, can you pls resend again using git-send email. I tried even the patch from patchworks but that too failed!

Re: [PATCH v2] dma: edma: Add support for Cyclic DMA

2013-11-11 Thread Vinod Koul
On Thu, Oct 31, 2013 at 04:31:23PM -0500, Joel Fernandes wrote: Using the PaRAM configuration function that we split for reuse by the different DMA types, we implement Cyclic DMA support. For the cyclic case, we pass different configuration parameters to this function, and handle all the

Re: cppi41: pending patches

2013-11-12 Thread Vinod Koul
On Tue, Oct 22, 2013 at 12:14:02PM +0200, Sebastian Andrzej Siewior wrote: Hi Vinod, this series contains patches which are floating on the mainling list so I hope it is easier to collect them. It contains two of Daniel's which were not yet applied and two of mine. The patch redo descriptor

Re: [PATCH RFC 00/26] Migrate more OMAP DMA code to DMA engine

2014-01-09 Thread Vinod Koul
On Thu, Jan 02, 2014 at 03:08:36PM +, Russell King - ARM Linux wrote: The following patch series moves code to setup the DMA hardware and service interrupts from the hardware to the DMA engine driver. This reduces the dependency on the legacy DMA implementation. Didnt the code getting

Re: [PATCH 00/26] OMAP dma engine rework

2014-03-18 Thread Vinod Koul
On Mon, Feb 10, 2014 at 09:25:31PM +0530, Russell King - ARM Linux wrote: This is the current set of patches for the OMAP DMA engine rework, which should now work correctly on OMAP1 platforms thanks to Tony's testing. It would be good to get this validated by others across a range of OMAP

Re: [PATCH] dma: omap-dma: Implement device_slave_caps callback

2014-03-29 Thread Vinod Koul
On Fri, Mar 07, 2014 at 03:36:44PM +0200, Peter Ujfalusi wrote: With the callback implemented omap-dma can provide information to client drivers regarding to supported address widths, directions, residue granularity, etc. Applied, thanks -- ~Vinod -- To unsubscribe from this list: send the

Re: [PATCH 00/26] OMAP dma engine rework

2014-04-02 Thread Vinod Koul
On Sat, Mar 29, 2014 at 06:13:06PM +, Russell King - ARM Linux wrote: On Tue, Mar 18, 2014 at 09:18:45PM +0530, Vinod Koul wrote: On Mon, Feb 10, 2014 at 09:25:31PM +0530, Russell King - ARM Linux wrote: This is the current set of patches for the OMAP DMA engine rework, which should

Re: [PATCH v2 05/14] arm: common: edma: Select event queue 1 as default when booted with DT

2014-04-11 Thread Vinod Koul
On Fri, Apr 11, 2014 at 12:38:00PM +0300, Peter Ujfalusi wrote: On 04/11/2014 11:56 AM, Sekhar Nori wrote: On Friday 11 April 2014 02:20 PM, Peter Ujfalusi wrote: On 04/11/2014 11:17 AM, Sekhar Nori wrote: On Tuesday 01 April 2014 06:36 PM, Peter Ujfalusi wrote: Use the EVENTQ_1 for

Re: [PATCH v2 05/14] arm: common: edma: Select event queue 1 as default when booted with DT

2014-04-11 Thread Vinod Koul
On Fri, Apr 11, 2014 at 02:32:28PM +0300, Peter Ujfalusi wrote: Hi Vinod, On 04/11/2014 12:42 PM, Vinod Koul wrote: On Fri, Apr 11, 2014 at 12:38:00PM +0300, Peter Ujfalusi wrote: On 04/11/2014 11:56 AM, Sekhar Nori wrote: On Friday 11 April 2014 02:20 PM, Peter Ujfalusi wrote: On 04

Re: [PATCH v2 05/14] arm: common: edma: Select event queue 1 as default when booted with DT

2014-04-11 Thread Vinod Koul
On Fri, Apr 11, 2014 at 03:23:54PM +0300, Peter Ujfalusi wrote: On 04/11/2014 02:31 PM, Vinod Koul wrote: I would say that it is channel based config. I don't see the reason why would one mix different priorities on a configured channel between descriptors. If not then we can add

Re: [PATCH v2 03/14] dma: edma: Add support for DMA_PAUSE/RESUME operation

2014-04-11 Thread Vinod Koul
On Tue, Apr 01, 2014 at 04:06:04PM +0300, Peter Ujfalusi wrote: Pause/Resume can be used by the audio stack when the stream is paused/resumed The edma platform code has support for this and the legacy audio stack used this. Signed-off-by: Peter Ujfalusi peter.ujfal...@ti.com ---

Re: [PATCH v2 08/14] DMA: edma: Use different eventq for cyclic channels

2014-04-11 Thread Vinod Koul
On Thu, Apr 10, 2014 at 11:36:30AM -0500, Joel Fernandes wrote: On 04/01/2014 08:06 AM, Peter Ujfalusi wrote: To improve latency with cyclic DMA operation it is preferred to use different eventq/tc than the default which is used by all other drivers (mmc, spi, i2c, etc). When preparing

Re: [PATCH v2 00/14] dma: edma: Fixes for cyclic (audio) operation

2014-04-11 Thread Vinod Koul
On Tue, Apr 01, 2014 at 04:06:01PM +0300, Peter Ujfalusi wrote: Hi, This is basically a resend of the previous series: https://lkml.org/lkml/2014/3/13/119 with removed ASoC patches (most of them are applied already). Changes since v1: - ASoC patches removed - Comments from Andriy

Re: [PATCH 1/1] dma: edma: fix incorrect SG list handling

2014-04-14 Thread Vinod Koul
On Mon, Apr 14, 2014 at 02:01:11PM +0530, Sekhar Nori wrote: Vinod, On Wednesday 19 March 2014 11:25 AM, Sekhar Nori wrote: The code to handle any length SG lists calls edma_resume() even before edma_start() is called. This is incorrect because edma_resume() enables edma events on the

Re: [PATCH v3 00/10] dma: edma: Fixes for cyclic (audio) operation

2014-04-22 Thread Vinod Koul
On Mon, Apr 14, 2014 at 02:41:55PM +0300, Peter Ujfalusi wrote: Hi, Changes since v2: - Dropped patch 10 from v2 (simplify direction configuration...) - Dropped the channel priority related patches since we are going to go via different route for configuring the priority. - Added ACK

Re: [PATCH] dmaengine: edma: Add DMA memcpy support

2014-04-22 Thread Vinod Koul
On Fri, Apr 18, 2014 at 09:50:33PM -0500, Joel Fernandes wrote: We add DMA memcpy support to EDMA driver. Successful tests performed using dmatest kernel module. Copy alignment is set to DMA_SLAVE_BUSWIDTH_4_BYTES and users must ensure length is aligned so that copy is performed fully.

Re: [PATCH] [FIX] dmaengine: virt-dma: Free descriptor after callback

2014-04-22 Thread Vinod Koul
On Fri, Apr 18, 2014 at 11:34:50AM -0500, Joel Fernandes wrote: On 04/18/2014 03:50 AM, Russell King - ARM Linux wrote: On Thu, Apr 17, 2014 at 07:56:50PM -0500, Joel Fernandes wrote: Free the vd (virt descriptor) after the callback is called. In EDMA driver atleast which uses virt-dma, we

Re: [PATCH] dmaengine: edma: No need save/restore interrupt flags during spin_lock in IRQ

2014-04-23 Thread Vinod Koul
On Thu, Apr 17, 2014 at 12:58:33AM -0500, Joel Fernandes wrote: The vchan lock in edma_callback is acquired in hard interrupt context. As interrupts are already disabled, there's no point in save/restoring interrupt mask bit or cpsr flags. Get rid of flags local variable and use spin_lock

Re: [RESEND] dmaengine: edma: Add channel number to debug prints

2014-04-29 Thread Vinod Koul
On Thu, Apr 24, 2014 at 10:29:50AM +0300, Peter Ujfalusi wrote: It helps to identify issues if we have some information regarding to the channel which the event is associated. Signed-off-by: Peter Ujfalusi peter.ujfal...@ti.com Acked-by: Joel Fernandes jo...@ti.com Applied, thanks --

Re: [patch V2 0/6] dma: edma: Provide granular residue accounting

2014-04-29 Thread Vinod Koul
On Mon, Apr 28, 2014 at 03:47:37PM -0500, Joel Fernandes wrote: On 04/28/2014 05:49 AM, Thomas Gleixner wrote: A simpler version to provide granular residue accounting and readout for EDMA. Delta to V1: - Removed the double read of the address in PaRAM - Simplified

Re: [patch V2 0/6] dma: edma: Provide granular residue accounting

2014-04-29 Thread Vinod Koul
On Tue, Apr 29, 2014 at 11:25:02PM -0500, Joel Fernandes wrote: On 04/29/2014 03:46 AM, Vinod Koul wrote: [..] commit 770f0f3a20188b7e17db2790803b9da925dc0b94 Author: Thomas Gleixner t...@linutronix.de Date: Mon Apr 28 10:49:43 2014 + dmaengine: edma: Make reading

Re: [PATCH v3 00/13] ARM/DT: edma: IP configuration from hardware and cleanups

2014-05-21 Thread Vinod Koul
On Tue, May 20, 2014 at 04:26:09PM +0530, Sekhar Nori wrote: On Monday 19 May 2014 10:23 PM, Peter Ujfalusi wrote: On 05/19/2014 04:06 PM, Sekhar Nori wrote: On Friday 16 May 2014 05:47 PM, Peter Ujfalusi wrote: Hi, Changes since v2: - Comments from Sekhar and Arnd has been addressed

Re: [PATCH 0/2] dma: edma: Allow to disable eDMA IRQ during cyclic transfer

2014-07-28 Thread Vinod Koul
On Wed, Jul 16, 2014 at 03:29:19PM +0300, Peter Ujfalusi wrote: Hi, After this series clients can ask to not receive notifications after each period. In this case we can disable the completion interrupt since the position reporting does not rely on it for cyclic mode. Patchset for ASoC

  1   2   >