Re: [PATCHv2 2/2] Input: ads7846 - configure pendown gpio as input

2011-02-03 Thread Wolfram Sang
. | Wolfram Sang| Industrial Linux Solutions | http://www.pengutronix.de/ | signature.asc Description: Digital signature

Re: [PATCH v3 1/2] ads7846: fix gpio free without requesting

2011-02-03 Thread Wolfram Sang
); err_free_gpio: - if (ts-gpio_pendown != -1) + if (gpio_is_valid(ts-gpio_pendown)) You could do the same in the remove-path. Regards, Wolfram -- Pengutronix e.K. | Wolfram Sang| Industrial Linux Solutions | http

Re: [PATCH v3 1/2] ads7846: fix gpio free without requesting

2011-02-03 Thread Wolfram Sang
e.K. | Wolfram Sang| Industrial Linux Solutions | http://www.pengutronix.de/ | signature.asc Description: Digital signature

Re: [PATCH v3 2/2] Input: ads7846: use gpio_request_one to configure pendown_gpio

2011-02-03 Thread Wolfram Sang
...@mail.ru Since the two are won't be merged Acked-by: Wolfram Sang w.s...@pengutronix.de -- Pengutronix e.K. | Wolfram Sang| Industrial Linux Solutions | http://www.pengutronix.de/ | signature.asc Description: Digital signature

Re: [PATCH v3 2/2] Input: ads7846: use gpio_request_one to configure pendown_gpio

2011-02-03 Thread Wolfram Sang
, that was what I was suggesting, too Acked-by: Wolfram Sang w.s...@pengutronix.de -- Pengutronix e.K. | Wolfram Sang| Industrial Linux Solutions | http://www.pengutronix.de/ | signature.asc Description: Digital signature

Re: [PATCH v3 2/2] Input: ads7846: use gpio_request_one to configure pendown_gpio

2011-02-04 Thread Wolfram Sang
e.K. | Wolfram Sang| Industrial Linux Solutions | http://www.pengutronix.de/ | signature.asc Description: Digital signature

Re: [PATCH v3 2/2] Input: ads7846: use gpio_request_one to configure pendown_gpio

2011-02-04 Thread Wolfram Sang
On Fri, Feb 04, 2011 at 07:46:18PM +0530, G, Manjunath Kondaiah wrote: On Fri, Feb 04, 2011 at 03:08:47PM +0100, Wolfram Sang wrote: On Fri, Feb 04, 2011 at 07:02:50PM +0530, G, Manjunath Kondaiah wrote: On Thu, Feb 03, 2011 at 09:19:53AM -0800, Dmitry Torokhov wrote: On Thu, Feb 03

Re: [PATCHv11 1/6] i2c: omap: Optimise the remove code

2012-07-12 Thread Wolfram Sang
e.K. | Wolfram Sang| Industrial Linux Solutions | http://www.pengutronix.de/ | signature.asc Description: Digital signature

Re: [PATCHv11 2/6] i2c: omap: Use SET_RUNTIME_PM_OPS

2012-07-12 Thread Wolfram Sang
On Thu, Jun 28, 2012 at 08:41:28PM +0530, Shubhrajyoti D wrote: Use SET_RUNTIME_PM_OPS macro to set runtime functions. Acked-by: Felipe Balbi ba...@ti.com Signed-off-by: Shubhrajyoti D shubhrajy...@ti.com Applied to next, thanks. -- Pengutronix e.K. | Wolfram Sang

Re: [PATCHv11 3/6] i2c: omap: Do not initialise the completion everytime

2012-07-12 Thread Wolfram Sang
. | Wolfram Sang| Industrial Linux Solutions | http://www.pengutronix.de/ | signature.asc Description: Digital signature

Re: [PATCHv11 4/6] i2c: omap: Remove the definition of SYSS_RESETDONE_MASK

2012-07-12 Thread Wolfram Sang
#include linux/i2c-omap.h #include linux/pm_runtime.h +#include plat/omap_hwmod.h Hmmm, so far the driver has no plat/mach dependencies and now this gets added. Need to think about it a bit more... -- Pengutronix e.K. | Wolfram Sang| Industrial Linux

Re: [PATCHv11 5/6] i2c: omap: Correct I2C revision for OMAP3

2012-07-12 Thread Wolfram Sang
-by: Shubhrajyoti D shubhrajy...@ti.com Applied to next, thanks. -- Pengutronix e.K. | Wolfram Sang| Industrial Linux Solutions | http://www.pengutronix.de/ | signature.asc Description: Digital signature

Re: [PATCHv11 6/6] i2c: omap: Recover from Bus Busy condition

2012-07-12 Thread Wolfram Sang
This has to wait a little bit until I can spend time on the recovery framework (which is still in the queue, sadly :( ). There might be some consolidation. -- Pengutronix e.K. | Wolfram Sang| Industrial Linux Solutions | http

Re: [PATCHv11 0/6] I2C cleanups

2012-07-12 Thread Wolfram Sang
. | Wolfram Sang| Industrial Linux Solutions | http://www.pengutronix.de/ | signature.asc Description: Digital signature

Re: [PATCHv7 00/24] I2C big cleanup

2012-08-16 Thread Wolfram Sang
the traffic causes some overhead here :) Thanks, Wolfram -- Pengutronix e.K. | Wolfram Sang| Industrial Linux Solutions | http://www.pengutronix.de/ | signature.asc Description: Digital signature

Re: [PATCH] I2C: OMAP: xfer: fix runtime PM get/put balance on error

2012-08-18 Thread Wolfram Sang
Hilman khil...@ti.com --- This patch applies to current i2c-embedded/for-next branch This one is needed for v3.6. Can you queue this up as a fix for v3.6-rc? Done, applied to -current, thanks! -- Pengutronix e.K. | Wolfram Sang| Industrial Linux

Re: [PATCHv7 20/23] i2c: omap: switch to threaded IRQ support

2012-09-11 Thread Wolfram Sang
) { struct omap_i2c_dev *dev = dev_id; + irqreturn_t ret = IRQ_HANDLED; Shouldn't that be IRQ_NONE? -- Pengutronix e.K. | Wolfram Sang| Industrial Linux Solutions | http://www.pengutronix.de/ | signature.asc Description: Digital

Re: [PATCHv7 19/23] i2c: omap: always return IRQ_HANDLED

2012-09-11 Thread Wolfram Sang
just drop this patch since the code gets removed soon anyhow? Or is patch 20/23 changing something I don't see yet? -- Pengutronix e.K. | Wolfram Sang| Industrial Linux Solutions | http://www.pengutronix.de/ | signature.asc Description

Re: [PATCHv7 18/23] i2c: omap: remove redundant status read

2012-09-11 Thread Wolfram Sang
); if (ret 0) goto out; -- 1.7.5.4 -- Pengutronix e.K. | Wolfram Sang| Industrial Linux Solutions | http://www.pengutronix.de/ | signature.asc Description: Digital signature

Re: [PATCHv7 00/23]I2C big cleanup

2012-09-11 Thread Wolfram Sang
Looks mostly good, thanks. Only a few comments. Oh, and I still get reports about a section mismatch ;) -- Pengutronix e.K. | Wolfram Sang| Industrial Linux Solutions | http://www.pengutronix.de/ | signature.asc Description: Digital

Re: [PATCHv7 00/23]I2C big cleanup

2012-09-12 Thread Wolfram Sang
I donot see the warning. Am I missing something? I deleted my logfiles already. Ignore it for now, if it comes up again with your new series, I will give a more detailed pointer. Thanks, Wolfram -- Pengutronix e.K. | Wolfram Sang| Industrial

Re: [PATCHv7 20/23] i2c: omap: switch to threaded IRQ support

2012-09-12 Thread Wolfram Sang
On Wed, Sep 12, 2012 at 11:55:39AM +0530, Shubhrajyoti wrote: On Wednesday 12 September 2012 03:21 AM, Wolfram Sang wrote: -omap_i2c_isr(int this_irq, void *dev_id) +omap_i2c_isr(int irq, void *dev_id) { struct omap_i2c_dev *dev = dev_id; +irqreturn_t ret

Re: [PATCHv8 00/23]I2C big cleanup

2012-09-12 Thread Wolfram Sang
. | Wolfram Sang| Industrial Linux Solutions | http://www.pengutronix.de/ | signature.asc Description: Digital signature

Re: [PATCHv7 00/23]I2C big cleanup

2012-09-12 Thread Wolfram Sang
On Wed, Sep 12, 2012 at 12:18:50PM +0200, Wolfram Sang wrote: I donot see the warning. Am I missing something? I deleted my logfiles already. Ignore it for now, if it comes up again with your new series, I will give a more detailed pointer. Sorry, the section mismatch was not related

Re: [PATCH] omap-i2c: fix incorrect log message when using a device tree

2012-09-12 Thread Wolfram Sang
). Signed-off-by: Florian Vaussard florian.vauss...@epfl.ch Pushed to -next, thanks. -- Pengutronix e.K. | Wolfram Sang| Industrial Linux Solutions | http://www.pengutronix.de/ | signature.asc Description: Digital signature

Re: [PATCHv8 00/23]I2C big cleanup

2012-09-13 Thread Wolfram Sang
are passing. Feel free to add: Tested-by: Kevin Hilman khil...@ti.com Thanks. That indeed increases confidence in this series. I won't add the tags to the tree, though, since that would mean rebasing. All the best, Wolfram -- Pengutronix e.K. | Wolfram Sang

Re: [PATCH 1/4] i2c: introduce i2c-cbus driver

2012-09-13 Thread Wolfram Sang
much like I2C, neither. There is no ACK/NACK/START/STOP, so I wonder if it should be in i2c after all... Jean, maybe you want to have a glimpse on this as well? Regards, Wolfram -- Pengutronix e.K. | Wolfram Sang| Industrial Linux Solutions

Re: [PATCH 1/4] i2c: introduce i2c-cbus driver

2012-09-14 Thread Wolfram Sang
); +MODULE_AUTHOR(Juha Yrjölä); +MODULE_AUTHOR(David Weinehall); +MODULE_AUTHOR(Mikko Ylinen); +MODULE_AUTHOR(Felipe Balbi); +MODULE_AUTHOR(Aaro Koskinen aaro.koski...@iki.fi); +MODULE_LICENSE(GPL); So much for now. Regards, Wolfram -- Pengutronix e.K. | Wolfram Sang

Re: [PATCH 1/4] i2c: introduce i2c-cbus driver

2012-09-20 Thread Wolfram Sang
On Wed, Sep 19, 2012 at 11:08:13PM +0300, Aaro Koskinen wrote: On Fri, Sep 14, 2012 at 12:08:06PM +0200, Wolfram Sang wrote: On Mon, Sep 03, 2012 at 11:23:22PM +0300, Aaro Koskinen wrote: Add i2c driver to enable access to devices behind CBUS on Nokia Internet Tablets. The patch

Re: [PATCH] ARM: OMAP: convert I2C driver to PM QoS for MPU latency constraints

2012-10-06 Thread Wolfram Sang
. | Wolfram Sang| Industrial Linux Solutions | http://www.pengutronix.de/ | signature.asc Description: Digital signature

Re: [PATCH] i2c: omap: ensure writes to dev-buf_len are ordered

2012-11-01 Thread Wolfram Sang
. | Wolfram Sang| Industrial Linux Solutions | http://www.pengutronix.de/ | signature.asc Description: Digital signature

Re: [PATCH] i2c: omap: fix spurious IRQs: disable/enable IRQ at INTC when idle

2012-11-01 Thread Wolfram Sang
left for 3.7 that I missed? Thanks, Wolfram -- Pengutronix e.K. | Wolfram Sang| Industrial Linux Solutions | http://www.pengutronix.de/ | signature.asc Description: Digital signature

Re: [PATCHv9 06/10] I2C: OMAP: Fix the crash in i2c remove

2012-05-12 Thread Wolfram Sang
(dev-base); kfree(dev); -- 1.7.5.4 -- Pengutronix e.K. | Wolfram Sang| Industrial Linux Solutions | http://www.pengutronix.de/ | signature.asc Description: Digital signature

Re: [PATCHv9 00/10] I2C fixes

2012-05-12 Thread Wolfram Sang
conflicts. - Prevents the XDUF flag to be set if the underflow condition is not met. - As per discussion in [1] .Adds a patch to rename the 1p153 errata and use the unique id instead as the section number in the recent errata docs has changed. v9: Fix the comments from Wolfram Sang Patch

Re: [PATCHv10 00/11] I2C fixes

2012-06-11 Thread Wolfram Sang
id instead as the section number in the recent errata  docs has changed. v9: Fix the comments from Wolfram Sang v10: Add a patch from Neil to the series. Fix kevin comments update the patches with comments. Shubhrajyoti, thanks for the updates. Wolfgang, with these updates

Re: [PATCH v2 00/17] Big OMAP I2C Cleanup

2012-06-14 Thread Wolfram Sang
. It will take some time until I pick this series anyhow, because I want people to have time to donate Tested-by tags. -- Pengutronix e.K. | Wolfram Sang| Industrial Linux Solutions | http://www.pengutronix.de/ | signature.asc Description: Digital

Re: [PATCHv8 10/13] I2C: OMAP: simplify num_bytes handling

2012-06-18 Thread Wolfram Sang
. | Wolfram Sang| Industrial Linux Solutions | http://www.pengutronix.de/ | signature.asc Description: Digital signature

Re: [PATCHv8 11/13] I2C: OMAP: decrease indentation level on data handling

2012-06-18 Thread Wolfram Sang
) errata_omap3_i462(dev, stat, err)) goto complete; -- 1.7.5.4 -- Pengutronix e.K. | Wolfram Sang| Industrial Linux Solutions | http://www.pengutronix.de/ | signature.asc Description: Digital signature

Re: [PATCHv8 13/13] I2C: OMAP: simplify omap_i2c_ack_stat()

2012-06-18 Thread Wolfram Sang
)); continue; } -- 1.7.5.4 -- Pengutronix e.K. | Wolfram Sang| Industrial Linux Solutions | http://www.pengutronix.de/ | signature.asc Description: Digital signature

Re: [PATCHv8 00/13] I2C cleanups

2012-06-18 Thread Wolfram Sang
without knowing the platform too much. For that reason, I'd be really appreciating Tested-by or even Reviewed-by tags! This series mainly is the cleanups rebased on i2c-embedded/for-next branch. Thanks. Regards, Wolfram -- Pengutronix e.K. | Wolfram Sang

Re: [PATCHv8 13/13] I2C: OMAP: simplify omap_i2c_ack_stat()

2012-06-19 Thread Wolfram Sang
On Tue, Jun 19, 2012 at 02:50:23PM +0530, Shubhrajyoti Datta wrote: On Mon, Jun 18, 2012 at 9:00 PM, Wolfram Sang w.s...@pengutronix.de wrote: On Mon, Jun 18, 2012 at 08:00:28PM +0530, Shubhrajyoti D wrote: From: Felipe Balbi ba...@ti.com stat BIT(1) is the same as BIT(1), Not true

Re: [PATCHv8 02/10] I2C: OMAP: Fix the mismatch of pm_runtime enable and disable

2012-04-23 Thread Wolfram Sang
); + pm_runtime_disable(pdev-dev); iounmap(dev-base); kfree(dev); mem = platform_get_resource(pdev, IORESOURCE_MEM, 0); -- 1.7.5.4 -- Pengutronix e.K. | Wolfram Sang| Industrial Linux Solutions | http://www.pengutronix.de

Re: [PATCHv8 07/10] I2C: OMAP: Handle error check for pm runtime

2012-04-23 Thread Wolfram Sang
(pdev-dev); pm_runtime_disable(pdev-dev); -- 1.7.5.4 Thanks, Wolfram -- Pengutronix e.K. | Wolfram Sang| Industrial Linux Solutions | http://www.pengutronix.de/ | signature.asc Description: Digital signature

Re: [PATCHv8 09/10] I2C: OMAP: Do not set the XUDF if the underflow is not reached

2012-04-23 Thread Wolfram Sang
description, I can't know all terminology for all architectures. -- Pengutronix e.K. | Wolfram Sang| Industrial Linux Solutions | http://www.pengutronix.de/ | signature.asc Description: Digital signature

Re: [PATCHv8 08/10] I2C: OMAP: fix missing handling of errata I2C_OMAP3_1P153

2012-04-23 Thread Wolfram Sang
) dev-errata |= I2C_OMAP3_1P153; -- 1.7.5.4 -- Pengutronix e.K. | Wolfram Sang| Industrial Linux Solutions | http://www.pengutronix.de/ | signature.asc Description: Digital signature

Re: [PATCHv8 06/10] I2C: OMAP: Fix the crash in i2c remove

2012-04-23 Thread Wolfram Sang
, OMAP_I2C_CON_REG, 0); + pm_runtime_put(pdev-dev); pm_runtime_disable(pdev-dev); iounmap(dev-base); kfree(dev); -- 1.7.5.4 -- Pengutronix e.K. | Wolfram Sang| Industrial Linux Solutions | http://www.pengutronix.de

Re: [PATCHv8 00/10] I2C fixes

2012-04-23 Thread Wolfram Sang
On Thu, Apr 19, 2012 at 06:58:11PM +0530, Shubhrajyoti D wrote: This patch series seperates the fixes from other changes from [2] I also noticed this one in my build. Can you check? WARNING: modpost: Found 1 section mismatch(es). -- Pengutronix e.K. | Wolfram Sang

Re: [PATCHv8 04/10] I2C: OMAP: Fix the error handling

2012-04-23 Thread Wolfram Sang
. | Wolfram Sang| Industrial Linux Solutions | http://www.pengutronix.de/ | signature.asc Description: Digital signature

Re: [PATCHv8 06/10] I2C: OMAP: Fix the crash in i2c remove

2012-04-24 Thread Wolfram Sang
On Tue, Apr 24, 2012 at 11:44:15PM +0530, Shubhrajyoti wrote: On Monday 23 April 2012 10:19 PM, Wolfram Sang wrote: [ 154.901153] Exception stack(0xdf9b9fb0 to 0xdf9b9ff8) [ 154.907104] 9fa0: beaf1f04 4006be00 000f 000c

Re: [PATCH V2] omap-serial: add RS485 mode support

2011-12-20 Thread Wolfram Sang
to bring bad news, but software RS485 is not mainlinable [1]. You can browse linux-serial for RS485 to find more threads about it. Regards, Wolfram [1] http://article.gmane.org/gmane.linux.serial/3619/ -- Pengutronix e.K. | Wolfram Sang| Industrial

Re: [PATCH RFC 1/2] watchdog : omap_wdt : Implement WDIOC_GETBOOTSTATUS for omap3+

2012-01-24 Thread Wolfram Sang
-api.txt for further info. Yes, not all drivers follow this style, sadly. Regards, Wolfram -- Pengutronix e.K. | Wolfram Sang| Industrial Linux Solutions | http://www.pengutronix.de/ | signature.asc Description: Digital signature

Re: [PATCH] Revert ARM: OMAP: convert I2C driver to PM QoS for MPU latency constraints

2012-11-14 Thread Wolfram Sang
-arm-kernelm=135219411617621w=2 Hmm, any ideas how to avoid such things in the future? Signed-off-by: Paul Walmsley p...@pwsan.com Applied to for-current, thanks! -- Pengutronix e.K. | Wolfram Sang| Industrial Linux Solutions | http

Re: [PATCH] i2c: omap: Move the remove constraint

2012-11-14 Thread Wolfram Sang
shubhrajy...@ti.com Good catch, the change definitely makes sense. Feel free to add: Acked-by: Jean Pihet j-pi...@ti.com Since I just reverted the QoS patch, I suppose this gets merged into the original patch when resent? -- Pengutronix e.K. | Wolfram Sang

Re: [PATCH] i2c: omap: adopt pinctrl support

2012-11-14 Thread Wolfram Sang
: registered GPIOs 477 to 500 on device: tca6424a Signed-off-by: Sebastien Guiriec s-guir...@ti.com looks good to me also, should go in v3.8 merge window: Reviewed-by: Felipe Balbi ba...@ti.com Applied to for-next, thanks! -- Pengutronix e.K. | Wolfram Sang

Re: [PATCH v2] i2c: omap: ensure writes to dev-buf_len are ordered

2012-11-14 Thread Wolfram Sang
agree adding a comment here is a good idea. -- Pengutronix e.K. | Wolfram Sang| Industrial Linux Solutions | http://www.pengutronix.de/ | signature.asc Description: Digital signature

Re: [PATCHv3 0/7] i2c: omap: updates

2012-11-14 Thread Wolfram Sang
. -- Pengutronix e.K. | Wolfram Sang| Industrial Linux Solutions | http://www.pengutronix.de/ | signature.asc Description: Digital signature

Re: [PATCH v3] i2c: omap: ensure writes to dev-buf_len are ordered

2012-11-14 Thread Wolfram Sang
to for-current, thanks! -- Pengutronix e.K. | Wolfram Sang| Industrial Linux Solutions | http://www.pengutronix.de/ | signature.asc Description: Digital signature

Re: [PATCH 0/8] I2C patches for v3.8 merge window

2012-11-14 Thread Wolfram Sang
, there are a few comments unaddressed it seems to me (reading in hot path, barriers). Please make sure these are properly handled and resend as a seperate series (all patches V4). Bonus point if you rebase it to my for-next, which I will push out soon. -- Pengutronix e.K. | Wolfram

[PATCH] i2c: omap: don't save a value only needed for read-clearing

2012-11-14 Thread Wolfram Sang
Signed-off-by: Wolfram Sang wolf...@the-dreams.de --- This makes one of my code analyzers happy and makes me a part of the i2c-omap-patch crowd \o/ drivers/i2c/busses/i2c-omap.c |3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/i2c/busses/i2c-omap.c b/drivers/i2c

Re: [PATCH] i2c: omap: don't save a value only needed for read-clearing

2012-11-14 Thread Wolfram Sang
. -- Pengutronix e.K. | Wolfram Sang| Industrial Linux Solutions | http://www.pengutronix.de/ | signature.asc Description: Digital signature

Re: [RESEND PATCH v3 1/4] i2c: introduce i2c-cbus driver

2012-11-16 Thread Wolfram Sang
Balbi ba...@ti.com Acked-by: Tony Lindgren t...@atomide.com Signed-off-by: Aaro Koskinen aaro.koski...@iki.fi Cc: Wolfram Sang w.s...@pengutronix.de Mostly good, but the devicetree binding description is missing. Please add a proper file with the same name as the driver to Documentation/devicetree

Re: [PATCHv3] i2c: omap: Move the remove constraint

2012-11-16 Thread Wolfram Sang
are completed by then. Acked-by: Jean Pihet j-pi...@ti.com Signed-off-by: Shubhrajyoti D shubhrajy...@ti.com Applied to for-next. Please let me know if it should go to for-current. -- Pengutronix e.K. | Wolfram Sang| Industrial Linux Solutions

Re: [PATCH v4 1/4] i2c: introduce i2c-cbus-gpio driver

2012-11-19 Thread Wolfram Sang
Balbi ba...@ti.com Acked-by: Tony Lindgren t...@atomide.com Signed-off-by: Aaro Koskinen aaro.koski...@iki.fi Applied to for-next, thanks! -- Pengutronix e.K. | Wolfram Sang| Industrial Linux Solutions | http://www.pengutronix.de

Re: [PATCH 065/493] i2c: remove use of __devexit_p

2012-11-22 Thread Wolfram Sang
by related bus drivers (see entries I2C OVER PARALLEL PORT and I2C/SMBUS CONTROLLER DRIVERS FOR PC in MAINTAINERS for examples of meaningful groups.) I agree with Jean here. Is there a V2 planned? With a change like this? -- Pengutronix e.K. | Wolfram Sang

Re: [PATCHv2] i2c: omap: Remove the OMAP_I2C_FLAG_RESET_REGS_POSTIDLE flag

2012-11-28 Thread Wolfram Sang
. | Wolfram Sang| Industrial Linux Solutions | http://www.pengutronix.de/ | signature.asc Description: Digital signature

Re: [PATCH] i2c: omap: errata i462: fix incorrect ack for arbitration lost interrupt

2013-01-23 Thread Wolfram Sang
On Sun, Jan 20, 2013 at 02:32:58AM +0200, Aaro Koskinen wrote: The errata handling function acks wrong interrupt in case of Arbitration lost. Fix it. Discovered during code review, the real impact of the bug is unknown. Signed-off-by: Aaro Koskinen aaro.koski...@iki.fi Applied to current,

Re: [PATCH] i2c: omap: fix draining irq handling

2013-01-23 Thread Wolfram Sang
On Sun, Jan 20, 2013 at 08:37:02PM +0200, Aaro Koskinen wrote: Commit 0bdfe0cb803dce699ff337c35d8e97ac355fa417 (i2c: omap: sanitize exit path) changed the interrupt handler to exit early and complete the transfer after the draining IRQ is handled. As a result, the ARDY may not be cleared

Re: [PATCH REBASE 0/6] i2c: omap: misc changes

2013-01-23 Thread Wolfram Sang
On Mon, Jan 14, 2013 at 09:16:28PM +0200, Felipe Balbi wrote: Hi, On Fri, Dec 14, 2012 at 06:34:03PM +0200, Felipe Balbi wrote: this is just a rebase of the previous series adding support for amount of bytes transferred upon NACK. Well, actually the patches implementing transferred

[RFC 38/42] arch/arm/plat-omap: don't check resource with devm_ioremap_resource

2013-05-10 Thread Wolfram Sang
devm_ioremap_resource does sanity checks on the given resource. No need to duplicate this in the driver. Signed-off-by: Wolfram Sang w...@the-dreams.de --- arch/arm/plat-omap/dmtimer.c |7 +-- 1 file changed, 1 insertion(+), 6 deletions(-) diff --git a/arch/arm/plat-omap/dmtimer.c b

[RFC 34/42] drivers/video/omap2/dss: don't check resource with devm_ioremap_resource

2013-05-10 Thread Wolfram Sang
devm_ioremap_resource does sanity checks on the given resource. No need to duplicate this in the driver. Signed-off-by: Wolfram Sang w...@the-dreams.de --- drivers/video/omap2/dss/hdmi.c |7 +-- 1 file changed, 1 insertion(+), 6 deletions(-) diff --git a/drivers/video/omap2/dss/hdmi.c b

[RFC 33/42] drivers/video/omap2: don't check resource with devm_ioremap_resource

2013-05-10 Thread Wolfram Sang
devm_ioremap_resource does sanity checks on the given resource. No need to duplicate this in the driver. Signed-off-by: Wolfram Sang w...@the-dreams.de --- drivers/video/omap2/vrfb.c |5 - 1 file changed, 5 deletions(-) diff --git a/drivers/video/omap2/vrfb.c b/drivers/video/omap2

[RFC 09/42] drivers/i2c/busses: don't check resource with devm_ioremap_resource

2013-05-10 Thread Wolfram Sang
devm_ioremap_resource does sanity checks on the given resource. No need to duplicate this in the driver. Signed-off-by: Wolfram Sang w...@the-dreams.de --- drivers/i2c/busses/i2c-davinci.c|6 +- drivers/i2c/busses/i2c-designware-platdrv.c |6 +- drivers/i2c/busses/i2c

[PATCH 26/33] drivers/video/omap2/dss: don't check resource with devm_ioremap_resource

2013-05-16 Thread Wolfram Sang
devm_ioremap_resource does sanity checks on the given resource. No need to duplicate this in the driver. Signed-off-by: Wolfram Sang w...@the-dreams.de --- drivers/video/omap2/dss/hdmi.c |4 1 file changed, 4 deletions(-) diff --git a/drivers/video/omap2/dss/hdmi.c b/drivers/video

[PATCH 25/33] drivers/video/omap2: don't check resource with devm_ioremap_resource

2013-05-16 Thread Wolfram Sang
devm_ioremap_resource does sanity checks on the given resource. No need to duplicate this in the driver. Signed-off-by: Wolfram Sang w...@the-dreams.de --- drivers/video/omap2/vrfb.c |5 - 1 file changed, 5 deletions(-) diff --git a/drivers/video/omap2/vrfb.c b/drivers/video/omap2

[PATCH] i2c: busses: remove superfluous comment

2013-05-17 Thread Wolfram Sang
The comment already got copypasted around and is not really useful. Remove it. Signed-off-by: Wolfram Sang w...@the-dreams.de --- drivers/i2c/busses/i2c-davinci.c|1 - drivers/i2c/busses/i2c-designware-platdrv.c |1 - drivers/i2c/busses/i2c-omap.c |1 - 3

Re: [PATCH] i2c: Let users disable Probe an I2C bus for certain devices

2013-06-04 Thread Wolfram Sang
On Tue, Jun 04, 2013 at 08:33:42PM +0300, Grygorii Strashko wrote: Currently the I2C devices instantiation Method 3 Probe an I2C bus for certain devices (see Documentation/i2c/instantiating-devices) is always enabled for all platforms (boards) and can't be disabled. Not true. Set .class = 0

Re: [PATCH 1/2] i2c: omap: convert to module_platform_driver()

2013-06-05 Thread Wolfram Sang
The similar patch already exists: https://patchwork.kernel.org/patch/2448251/ - [v2,1/2] RTC: rtc-twl: Fix rtc_reg_map initialization from Peter Ujfalusi So, I think it is best if you resend this patch after all the fixes it needs are applied or you resend the series with all patches it

Re: [PATCH] i2c: Let users disable Probe an I2C bus for certain devices

2013-06-07 Thread Wolfram Sang
3) Thinking about Mainline: To reach the same target - no I2C detection - and taking into account above assumption No changes in default behavior the following will need to be done: - change i2c-omap/i2c-gpio DT bindings and add parameter which will allow to change .class value for

[RFC] i2c: add deprecation warning for class based instantiation

2013-06-07 Thread Wolfram Sang
for drivers who want to disable class based in the near future to gain boot-up time, so users relying on this technique can switch to something better. They really should. Signed-off-by: Wolfram Sang w...@the-dreams.de --- drivers/i2c/busses/i2c-omap.c |2 +- drivers/i2c/i2c-core.c|6

Re: [PATCH] i2c: Let users disable Probe an I2C bus for certain devices

2013-06-07 Thread Wolfram Sang
That sounds good to me - I can prepare patch for i2c-omap.c. But, there is still an open question regarding *i2c-gpio.c* which, actually, a source of biggest part of delay. Why should the DEPRECATED flag not work with i2c-gpio? signature.asc Description: Digital signature

Re: [PATCH v5] i2c: omap: correct usage of the interrupt enable register

2013-06-12 Thread Wolfram Sang
On Mon, Jun 03, 2013 at 10:37:20AM +0300, Oleksandr Dmytryshyn wrote: We've been lucky not to have any interrupts fire during the suspend path, otherwise we would have unpredictable behaviour in the kernel. Based on the logic of the kernel code interrupts from i2c should be prohibited during

Re: [PATCH v5] i2c: omap: correct usage of the interrupt enable register

2013-06-19 Thread Wolfram Sang
On Mon, Jun 03, 2013 at 10:37:20AM +0300, Oleksandr Dmytryshyn wrote: We've been lucky not to have any interrupts fire during the suspend path, otherwise we would have unpredictable behaviour in the kernel. Based on the logic of the kernel code interrupts from i2c should be prohibited during

Re: [RFC] i2c: add deprecation warning for class based instantiation

2013-06-19 Thread Wolfram Sang
On Fri, Jun 07, 2013 at 11:09:26AM +0200, Wolfram Sang wrote: Class based instantiation can cause huge delays when booting. This mechanism was used when it was not possible to describe slaves on I2C busses. We now have other mechanisms, so most embedded I2C will not need classes

Re: [RFC] i2c: add deprecation warning for class based instantiation

2013-06-20 Thread Wolfram Sang
Hi, Sorry, for delayed reply - I've had problems with my e-mail. You still have. This message has unwanted linebreaks. I've tested this patch on our TI K3.4 product kernel with additional change below: Thanks. [0.662567] (null): This adapter will soon drop class based instantiation

[PATCH 04/12] drivers/mmc/host: don't use devm_pinctrl_get_select_default() in probe

2013-07-10 Thread Wolfram Sang
Since commit ab78029 (drivers/pinctrl: grab default handles from device core), we can rely on device core for setting the default pins. Compile tested only. Acked-by: Linus Walleij linus.wall...@linaro.org (personally at LCE13) Signed-off-by: Wolfram Sang w...@the-dreams.de --- drivers/mmc/host

[PATCH 02/12] drivers/i2c/busses: don't use devm_pinctrl_get_select_default() in probe

2013-07-10 Thread Wolfram Sang
Since commit ab78029 (drivers/pinctrl: grab default handles from device core), we can rely on device core for setting the default pins. Compile tested only. Acked-by: Linus Walleij linus.wall...@linaro.org (personally at LCE13) Signed-off-by: Wolfram Sang w...@the-dreams.de --- drivers/i2c

Re: [PATCH 02/12] drivers/i2c/busses: don't use devm_pinctrl_get_select_default() in probe

2013-08-07 Thread Wolfram Sang
On Wed, Jul 10, 2013 at 04:57:37PM +0100, Wolfram Sang wrote: Since commit ab78029 (drivers/pinctrl: grab default handles from device core), we can rely on device core for setting the default pins. Compile tested only. Acked-by: Linus Walleij linus.wall...@linaro.org (personally at LCE13

Re: [PATCH] i2c-omap: always send stop after nack

2013-08-19 Thread Wolfram Sang
Hi, Which means your original patch starts to make a lot more sense. I wonder is this is really what we should be doing though - breaking out of the loop, I mean. Yup, that is fine. I applied the old patch with Acks from Hein and Felipe to -next. Thanks! It looks like TI's i2c-davinci

Re: [PATCH] i2c-omap: always send stop after nack

2013-08-19 Thread Wolfram Sang
On Mon, Aug 19, 2013 at 08:57:02AM -0500, Felipe Balbi wrote: On Mon, Aug 19, 2013 at 02:11:23PM +0200, Wolfram Sang wrote: Hi, Which means your original patch starts to make a lot more sense. I wonder is this is really what we should be doing though - breaking out of the loop, I

[PATCH RESEND] i2c: move of helpers into the core

2013-08-19 Thread Wolfram Sang
. So, fix the drivers and documentation, too. Signed-off-by: Wolfram Sang w...@the-dreams.de --- Sigh, hitting the CC threshold on vger again. So resending to the lists only. BTW this patch is based on -rc4 and was tested on an AT91 board. More tests very welcome. Thanks! Documentation/acpi

Re: [PATCH RESEND] i2c: move of helpers into the core

2013-08-19 Thread Wolfram Sang
However this patch fails to apply onto either v3.11-rc4 or v3.11-rc6: Argh, did not drop the MPC patch before rebasing :( So either pick the patch i2c: powermac: fix return path on error before, pull the branch [1], or force me to resend ;) Thanks! [1]

Re: [PATCH RESEND] i2c: move of helpers into the core

2013-08-19 Thread Wolfram Sang
On Mon, Aug 19, 2013 at 09:46:04PM +0200, Thierry Reding wrote: On Mon, Aug 19, 2013 at 07:59:40PM +0200, Wolfram Sang wrote: [...] diff --git a/drivers/i2c/i2c-core.c b/drivers/i2c/i2c-core.c [...] +#if IS_ENABLED(CONFIG_OF) +static void of_i2c_register_devices(struct i2c_adapter *adap

[PATCH V2] i2c: move of helpers into the core

2013-08-21 Thread Wolfram Sang
. So, fix the drivers and documentation, too. Acked-by: Sylwester Nawrocki s.nawro...@amsung.com Acked-by: Rob Herring rob.herr...@calxeda.com Reviewed-by: Felipe Balbi ba...@ti.com Acked-by: Rafael J. Wysocki rafael.j.wyso...@intel.com Signed-off-by: Wolfram Sang w...@the-dreams.de --- V1 - V2

[PATCH V3] i2c: move of helpers into the core

2013-08-22 Thread Wolfram Sang
. So, fix the drivers and documentation, too. Acked-by: Rob Herring rob.herr...@calxeda.com Reviewed-by: Felipe Balbi ba...@ti.com Acked-by: Rafael J. Wysocki rafael.j.wyso...@intel.com Tested-by: Sylwester Nawrocki s.nawro...@samsung.com Signed-off-by: Wolfram Sang w...@the-dreams.de --- V2-V3

Re: [PATCH V3] i2c: move of helpers into the core

2013-08-23 Thread Wolfram Sang
On Thu, Aug 22, 2013 at 06:00:14PM +0200, Wolfram Sang wrote: I2C of helpers used to live in of_i2c.c but experience (from SPI) shows that it is much cleaner to have this in the core. This also removes a circular dependency between the helpers and the core, and so we can finally register child

Re: [PATCH v5] gpio: pcf857x: Add OF support

2013-08-27 Thread Wolfram Sang
The driver should support the same chip models reardless of whether it's used with or without DT. If an entry in the OF table has no corresponding entry in the I2C table I would consider that as a driver bug. Linus Walleij posted a patch to support DT only probing, but too many side-effects

Re: [PATCH] i2c: omap: Clear ARDY bit twice

2013-10-10 Thread Wolfram Sang
On Mon, Oct 07, 2013 at 01:41:59PM +0300, Taras Kondratiuk wrote: Initially commit cb527ede1bf6ff2008a025606f25344b8ed7b4ac i2c-omap: Double clear of ARDY status in IRQ handler added a workaround for undocumented errata ProDB0017052. But then commit 1d7afc95946487945cc7f5019b41255b72224b70

[PATCH 2/4] drivers/mmc/host: don't use devm_pinctrl_get_select_default() in probe

2013-10-13 Thread Wolfram Sang
Since commit ab78029 (drivers/pinctrl: grab default handles from device core), we can rely on device core for setting the default pins. Compile tested only. Acked-by: Linus Walleij linus.wall...@linaro.org (personally at LCE13) Signed-off-by: Wolfram Sang w...@the-dreams.de --- drivers/mmc/host

[PATCH 0/4] remove devm_pinctrl_get_select_default from drivers

2013-10-13 Thread Wolfram Sang
The core does this automatically, no need to do this explicitly in drivers. Those patchces should go via the respective subtrees. Thanks! Wolfram Sang (4): drivers/gpu/drm/tilcdc: don't use devm_pinctrl_get_select_default() in probe drivers/mmc/host: don't use

Re: [PATCH 4/8] i2c: omap: Fix missing device tree flags for omap2

2013-11-13 Thread Wolfram Sang
On Wed, Nov 13, 2013 at 06:35:33PM -0800, Tony Lindgren wrote: As we claim to support device tree for mach-omap2, we should have the necessary flags in the driver to make it usable. Cc: Wolfram Sang w...@the-dreams.de Cc: linux-...@vger.kernel.org Signed-off-by: Tony Lindgren t

  1   2   >