Dmitry Torokhov dmitry.torok...@gmail.com wrote:
Hi Yuanhan,
On Tue, Jan 08, 2013 at 10:57:53PM +0800, Yuanhan Liu wrote:
The current kfifo API take the kfifo size as input, while it rounds
_down_ the size to power of 2 at __kfifo_alloc. This may introduce
potential issue.
Take the code
The signedness of char is ambiguous for 8 bit data, which is why an API would
normally use u8 (or s8, I guess).
Since this is known to be character data, I would think char would be fine. I
am assuming C compilers would never assume multibyte chars.
Regards,
Andy
Laurent Pinchart
On Sun, 2008-11-30 at 01:40 +0100, Hans Verkuil wrote:
On Sunday 30 November 2008 00:31:38 Andy Walls wrote:
On Sat, 2008-11-29 at 18:52 +0100, Hans Verkuil wrote:
Hi all,
This is hopefully the final version. All earlier comments have been
incorporated into this patch. I also made
