Re: [PATCH] drm/omap: tiler: add hibernation callback

2015-03-18 Thread Rob Clark
, which appropriately assigns the suspend and hibernation handlers and move omap_dmm_resume under CONFIG_PM_SLEEP to avoid build warnings. Signed-off-by: Grygorii Strashko grygorii.stras...@linaro.org Reviewed-by: Rob Clark robdcl...@gmail.com --- drivers/gpu/drm/omapdrm/omap_dmm_tiler.c

Re: [PATCH/RESEND 0/9] drm: tilcdc driver fixes

2014-06-28 Thread Rob Clark
On Fri, Jun 27, 2014 at 6:08 PM, Darren Etheridge detheri...@ti.com wrote: Guido, On 06/17/2014 09:17 AM, Guido Martínez wrote: The tilcdc driver could be compiled as a module, but was severely broken and could not be used as such. This patchset attempts to fix the issues preventing a

Re: [PATCH] drm/tilcdc: Defer probe if no encoders/connectors found

2013-12-18 Thread Rob Clark
again. This patch replaces the returncode -ENXIO with -EPROBE_DEFER to get a working setup even if tilcdc_panel probes after tilcdc. yeah, that is probably better than relying on late_initcall() hacks.. Signed-off-by: Rob Clark robdcl...@gmail.com Signed-off-by: Markus Pargmann m

Re: [PATCH 3/4] drm: omap: Enable DT support for DMM

2013-09-16 Thread Rob Clark
On Mon, Sep 16, 2013 at 2:28 AM, Archit Taneja arc...@ti.com wrote: On Friday 13 September 2013 07:44 PM, Rob Clark wrote: On Fri, Sep 13, 2013 at 5:14 AM, Archit Taneja arc...@ti.com wrote: Enable use of DT for DMM/Tiler. Originally worked on by Andy Gross. looks good.. but do we want

Re: [PATCH 3/4] drm: omap: Enable DT support for DMM

2013-09-13 Thread Rob Clark
On Fri, Sep 13, 2013 at 5:14 AM, Archit Taneja arc...@ti.com wrote: Enable use of DT for DMM/Tiler. Originally worked on by Andy Gross. looks good.. but do we want to get information about # of LUT's, etc, from DT? Or did we decide that we can reliably get this from the hw? I lost track of

Re: Latest randconfig build errors

2013-04-13 Thread Rob Clark
On Mon, Mar 4, 2013 at 1:46 PM, Tony Lindgren t...@atomide.com wrote: drivers/gpu/drm/tilcdc/tilcdc_slave.o:(.data+0x54): multiple definition of `__mod_of_device_table' drivers/gpu/drm/tilcdc/tilcdc_tfp410.o:(.data+0x54): first defined here drivers/gpu/drm/tilcdc/tilcdc_panel.o:(.data+0x54):

Re: Latest randconfig build errors

2013-04-13 Thread Rob Clark
On Sat, Apr 13, 2013 at 5:45 PM, Thierry Reding thierry.red...@avionic-design.de wrote: On Sat, Apr 13, 2013 at 08:54:22AM -0400, Rob Clark wrote: On Mon, Mar 4, 2013 at 1:46 PM, Tony Lindgren t...@atomide.com wrote: drivers/gpu/drm/tilcdc/tilcdc_slave.o:(.data+0x54): multiple definition

Re: [PATCH] drm/omap: Take a fb reference in omap_plane_update()

2013-04-09 Thread Rob Clark
unreferenced by the apply-worker. This is in addition to the exisitng reference/unreference in update_pin(), which is taken for the scanout of the plane's current framebuffer, and an unreference the previous framebuffer. Signed-off-by: Archit Taneja arc...@ti.com Cc: Rob Clark robdcl...@gmail.com

Re: [PATCH] drm/omap: Take a fb reference in omap_plane_update()

2013-04-09 Thread Rob Clark
-off-by: Archit Taneja arc...@ti.com Cc: Rob Clark robdcl...@gmail.com --- drivers/gpu/drm/omapdrm/omap_plane.c |6 ++ 1 file changed, 6 insertions(+) diff --git a/drivers/gpu/drm/omapdrm/omap_plane.c b/drivers/gpu/drm/omapdrm/omap_plane.c index 2882cda..8d225d7 100644 --- a/drivers

Re: [PATCH 1/4] drm/omap: Don't return from modeset_init if a panel doesn't satisfy omapdrm requirements

2013-03-05 Thread Rob Clark
Reviewed-by: Rob Clark robdcl...@gmail.com --- drivers/gpu/drm/omapdrm/omap_drv.c |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/omapdrm/omap_drv.c b/drivers/gpu/drm/omapdrm/omap_drv.c index 079c54c..77b7225 100644 --- a/drivers/gpu/drm/omapdrm

Re: [PATCH 3/4] drm/omap: Make fixed resolution panels work

2013-03-05 Thread Rob Clark
On Tue, Mar 5, 2013 at 9:17 AM, Archit Taneja arc...@ti.com wrote: The omapdrm driver requires omapdss panel drivers to expose ops like detect, set_timings and check_timings. These can be NULL for fixed panel DPI, DBI, DSI and SDI drivers. At some places, there are no checks to see if the panel

Re: [PATCH] omapdrm: Make fixed resolution panels work

2013-02-14 Thread Rob Clark
On Thu, Feb 14, 2013 at 6:52 AM, Archit Taneja arc...@ti.com wrote: The omapdrm driver requires omapdss panel drivers to expose ops like detect, set_timings and check_timings. These can be NULL for fixed panel DPI, DBI, DSI and SDI drivers. At some places, there are no checks to see if the

Re: [PATCH 2/4] drm/i2c: nxp-tda998x (v3)

2013-01-31 Thread Rob Clark
On Wed, Jan 30, 2013 at 8:23 PM, Sebastian Hesselbarth sebastian.hesselba...@gmail.com wrote: On 01/29/2013 06:23 PM, Rob Clark wrote: Driver for the NXP TDA998X i2c hdmi encoder slave. Rob, good to see a driver for TDA998x comming! I'd love to test it on CuBox (mach-dove

Re: [PATCH 2/4] drm/i2c: nxp-tda998x (v3)

2013-01-31 Thread Rob Clark
On Thu, Jan 31, 2013 at 2:14 PM, Sebastian Hesselbarth sebastian.hesselba...@gmail.com wrote: On 01/31/2013 03:23 PM, Rob Clark wrote: On Wed, Jan 30, 2013 at 8:23 PM, Sebastian Hesselbarth sebastian.hesselba...@gmail.com wrote: On 01/29/2013 06:23 PM, Rob Clark wrote

[PATCH 0/4] TI LCDC DRM driver

2013-01-29 Thread Rob Clark
/linux/log/?h=tilcdc-next Rob Clark (4): drm/tilcdc: add TI LCD Controller DRM driver (v4) drm/i2c: nxp-tda998x (v3) drm/tilcdc: add encoder slave (v2) drm/tilcdc: add support for LCD panels (v5) .../devicetree/bindings/drm/tilcdc/panel.txt | 59 ++ .../devicetree/bindings/drm

[PATCH 3/4] drm/tilcdc: add encoder slave (v2)

2013-01-29 Thread Rob Clark
Add output panel driver for i2c encoder slaves. v1: original v2: add DT bindings docs, and minor updates for review comments Signed-off-by: Rob Clark robdcl...@gmail.com Reviewed-by: Daniel Vetter daniel.vet...@ffwll.ch Tested-by: Koen Kooi k...@dominion.thruhere.net --- .../devicetree/bindings

[PATCH 4/4] drm/tilcdc: add support for LCD panels (v5)

2013-01-29 Thread Rob Clark
struct, add DT bindings docs Signed-off-by: Rob Clark robdcl...@gmail.com Tested-by: Koen Kooi k...@dominion.thruhere.net --- .../devicetree/bindings/drm/tilcdc/panel.txt | 59 +++ drivers/gpu/drm/tilcdc/Kconfig | 3 + drivers/gpu/drm/tilcdc/Makefile

[PATCH 2/4] drm/i2c: nxp-tda998x (v3)

2013-01-29 Thread Rob Clark
Driver for the NXP TDA998X i2c hdmi encoder slave. v1: original v2: fix npix/nline programming v3: add Kconfig, fix dup'd MODULE_DESCRIPTION Signed-off-by: Rob Clark robdcl...@gmail.com Reviewed-by: Daniel Vetter daniel.vet...@ffwll.ch Tested-by: Koen Kooi k...@dominion.thruhere.net --- drivers

Re: [PATCH 1/4] drm/tilcdc: add TI LCD Controller DRM driver (v3)

2013-01-28 Thread Rob Clark
On Mon, Jan 28, 2013 at 3:56 AM, Mohammed, Afzal af...@ti.com wrote: Hi Rob, On Fri, Jan 25, 2013 at 20:22:55, Rob Clark wrote: On Fri, Jan 25, 2013 at 8:15 AM, Mohammed, Afzal af...@ti.com wrote: It's not about being simple, but not doing the wrong way, here you are relying on a platform

Re: [PATCH 1/4] drm/tilcdc: add TI LCD Controller DRM driver (v3)

2013-01-25 Thread Rob Clark
On Fri, Jan 25, 2013 at 7:19 AM, Mohammed, Afzal af...@ti.com wrote: Hi Rob, On Wed, Jan 23, 2013 at 04:06:22, Rob Clark wrote: A simple DRM/KMS driver for the TI LCD Controller found in various smaller TI parts (AM33xx, OMAPL138, etc). This driver uses the +void tilcdc_crtc_update_clk

Re: [PATCH 1/4] drm/tilcdc: add TI LCD Controller DRM driver (v3)

2013-01-25 Thread Rob Clark
On Fri, Jan 25, 2013 at 8:15 AM, Mohammed, Afzal af...@ti.com wrote: Hi Rob, On Fri, Jan 25, 2013 at 19:29:40, Rob Clark wrote: On Fri, Jan 25, 2013 at 7:19 AM, Mohammed, Afzal af...@ti.com wrote: On Wed, Jan 23, 2013 at 04:06:22, Rob Clark wrote: A simple DRM/KMS driver for the TI LCD

Re: [PATCH 2/4] drm/i2c: nxp-tda998x (v2)

2013-01-24 Thread Rob Clark
On Thu, Jan 24, 2013 at 5:57 AM, Daniel Vetter dan...@ffwll.ch wrote: On Tue, Jan 22, 2013 at 04:36:23PM -0600, Rob Clark wrote: Driver for the NXP TDA998X i2c hdmi encoder slave. v1: original v2: fix npix/nline programming Signed-off-by: Rob Clark robdcl...@gmail.com Just one bikeshed

Re: [PATCH 3/4] drm/tilcdc: add encoder slave

2013-01-24 Thread Rob Clark
On Thu, Jan 24, 2013 at 6:43 AM, Daniel Vetter dan...@ffwll.ch wrote: On Tue, Jan 22, 2013 at 04:36:24PM -0600, Rob Clark wrote: Add output panel driver for i2c encoder slaves. Signed-off-by: Rob Clark robdcl...@gmail.com A few questions below, otherwise Reviewed-by: Daniel Vetter

Re: [PATCH 3/4] drm/tilcdc: add encoder slave

2013-01-24 Thread Rob Clark
On Thu, Jan 24, 2013 at 7:01 AM, Daniel Vetter dan...@ffwll.ch wrote: On Tue, Jan 22, 2013 at 04:36:24PM -0600, Rob Clark wrote: Add output panel driver for i2c encoder slaves. Signed-off-by: Rob Clark robdcl...@gmail.com Found some more stuff ... [cut] +static const struct

Re: [PATCH 4/4] drm/tilcdc: add support for LCD panels (v4)

2013-01-24 Thread Rob Clark
On Thu, Jan 24, 2013 at 7:08 AM, Daniel Vetter dan...@ffwll.ch wrote: On Tue, Jan 22, 2013 at 04:36:25PM -0600, Rob Clark wrote: Add an output panel driver for LCD panels. Tested with LCD3 cape on beaglebone. v1: original v2: s/of_find_node_by_name()/of_get_child_by_name()/ from Pantelis

Re: [PATCH 1/4] drm/tilcdc: add TI LCD Controller DRM driver (v3)

2013-01-23 Thread Rob Clark
16:36:22 -0600 Rob Clark robdcl...@gmail.com wrote: A simple DRM/KMS driver for the TI LCD Controller found in various smaller TI parts (AM33xx, OMAPL138, etc). This driver uses the CMA helpers. Currently only the TFP410 DVI encoder is supported (tested with beaglebone + DVI cape

Re: [PATCH 2/4] drm/i2c: nxp-tda998x (v2)

2013-01-23 Thread Rob Clark
On Wed, Jan 23, 2013 at 3:42 AM, Jean-Francois Moine moin...@free.fr wrote: On Tue, 22 Jan 2013 16:36:23 -0600 Rob Clark robdcl...@gmail.com wrote: Driver for the NXP TDA998X i2c hdmi encoder slave. v1: original v2: fix npix/nline programming Signed-off-by: Rob Clark robdcl...@gmail.com

Re: [PATCH 1/4] drm/tilcdc: add TI LCD Controller DRM driver (v3)

2013-01-23 Thread Rob Clark
On Wed, Jan 23, 2013 at 7:36 AM, Russell King - ARM Linux li...@arm.linux.org.uk wrote: On Wed, Jan 23, 2013 at 07:24:33AM -0600, Rob Clark wrote: On Wed, Jan 23, 2013 at 3:42 AM, Jean-Francois Moine moin...@free.fr wrote: Hi Rob, As I wanted to re-use your nxp-tda998x driver

Re: [PATCH v3 00/12] video: da8xx-fb: am335x DT support

2013-01-23 Thread Rob Clark
On Wed, Jan 23, 2013 at 6:27 AM, Mohammed, Afzal af...@ti.com wrote: Hi, On Wed, Jan 23, 2013 at 00:15:09, Rob Clark wrote: Wouldn't it be better to delete da8xx-fb.* and switch to Rob Clarks DRM based driver for this IP block? we probably can't delete da8xx-fb, but I think it would

Re: [PATCH 1/4] drm/tilcdc: add TI LCD Controller DRM driver (v3)

2013-01-23 Thread Rob Clark
On Wed, Jan 23, 2013 at 8:13 AM, Rob Clark robdcl...@gmail.com wrote: On Wed, Jan 23, 2013 at 7:36 AM, Russell King - ARM Linux li...@arm.linux.org.uk wrote: On Wed, Jan 23, 2013 at 07:24:33AM -0600, Rob Clark wrote: On Wed, Jan 23, 2013 at 3:42 AM, Jean-Francois Moine moin...@free.fr wrote

Re: [PATCH v3 00/12] video: da8xx-fb: am335x DT support

2013-01-22 Thread Rob Clark
On Tue, Jan 22, 2013 at 11:03 AM, Koen Kooi k...@dominion.thruhere.net wrote: Op 22 jan. 2013, om 17:51 heeft Afzal Mohammed af...@ti.com het volgende geschreven: Hi, This series adds DT support to da8xx-fb driver (device found on DaVinci and AM335x SoC's). It does certain cleanup's in

[PATCH 0/4] TI LCDC DRM driver

2013-01-22 Thread Rob Clark
the OF display helper series for 3.9. These patches and their dependencies can also be found here: git://people.freedesktop.org/~robclark/linux tilcdc-next http://cgit.freedesktop.org/~robclark/linux/log/?h=tilcdc-next Rob Clark (4): drm/tilcdc: add TI LCD Controller DRM driver (v3) drm

[PATCH 2/4] drm/i2c: nxp-tda998x (v2)

2013-01-22 Thread Rob Clark
Driver for the NXP TDA998X i2c hdmi encoder slave. v1: original v2: fix npix/nline programming Signed-off-by: Rob Clark robdcl...@gmail.com --- drivers/gpu/drm/i2c/Makefile | 3 + drivers/gpu/drm/i2c/tda998x_drv.c | 908 ++ 2 files changed, 911

[PATCH 3/4] drm/tilcdc: add encoder slave

2013-01-22 Thread Rob Clark
Add output panel driver for i2c encoder slaves. Signed-off-by: Rob Clark robdcl...@gmail.com --- drivers/gpu/drm/tilcdc/Kconfig| 12 ++ drivers/gpu/drm/tilcdc/Makefile | 1 + drivers/gpu/drm/tilcdc/tilcdc_drv.c | 5 +- drivers/gpu/drm/tilcdc/tilcdc_slave.c | 380

[PATCH 4/4] drm/tilcdc: add support for LCD panels (v4)

2013-01-22 Thread Rob Clark
Add an output panel driver for LCD panels. Tested with LCD3 cape on beaglebone. v1: original v2: s/of_find_node_by_name()/of_get_child_by_name()/ from Pantelis Antoniou v3: add backlight support v4: rebase to latest of video timing helpers Signed-off-by: Rob Clark robdcl...@gmail.com

[PATCH] ARM: OMAP2+: fix build break for omapdrm

2013-01-20 Thread Rob Clark
Fixes compile break with 3.8-rc4. Signed-off-by: Rob Clark robdcl...@gmail.com --- arch/arm/mach-omap2/drm.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/arch/arm/mach-omap2/drm.c b/arch/arm/mach-omap2/drm.c index 4c7566c..2a2cfa8 100644 --- a/arch/arm/mach-omap2/drm.c

Re: [RFC 0/4] TI LCDC DRM driver

2013-01-10 Thread Rob Clark
On Thu, Jan 10, 2013 at 6:05 PM, Laurent Pinchart laurent.pinch...@ideasonboard.com wrote: On Thursday 10 January 2013 10:16:10 Dave Airlie wrote: On Wed, Jan 9, 2013 at 2:11 PM, Rob Clark robdcl...@gmail.com wrote: Updated version of DRM driver for TI LCD Controller. Since the initial

[RFC 0/4] TI LCDC DRM driver

2013-01-08 Thread Rob Clark
patches, adding support for HDMI output via NXP TDA998x i2c encoder are fairly preliminary, but basically working (for some definitions of working). At this point, there is only basic DVI output support. Audio, HDCP, etc, can come later. Rob Clark (4): RFC: drm/lcdc: add TI LCD Controller DRM

[PATCH 2/4] RFC: drm/lcdc: add support for LCD panels (v2)

2013-01-08 Thread Rob Clark
Antoniou Signed-off-by: Rob Clark robdcl...@gmail.com --- drivers/gpu/drm/lcdc/Kconfig | 2 + drivers/gpu/drm/lcdc/Makefile | 1 + drivers/gpu/drm/lcdc/lcdc_drv.c | 3 + drivers/gpu/drm/lcdc/lcdc_panel.c | 458 ++ drivers/gpu/drm/lcdc

[PATCH 3/4] RFC: drm/i2c: nxp-tda998x

2013-01-08 Thread Rob Clark
Driver for the NXP TDA998X i2c hdmi encoder slave. Signed-off-by: Rob Clark robdcl...@gmail.com --- drivers/gpu/drm/i2c/Makefile | 3 + drivers/gpu/drm/i2c/tda998x_drv.c | 907 ++ 2 files changed, 910 insertions(+) create mode 100644 drivers/gpu/drm

[PATCH 4/4] RFC: drm/lcdc: add encoder slave

2013-01-08 Thread Rob Clark
Add output panel driver for i2c encoder slaves. Signed-off-by: Rob Clark robdcl...@gmail.com --- drivers/gpu/drm/lcdc/Kconfig | 12 ++ drivers/gpu/drm/lcdc/Makefile | 1 + drivers/gpu/drm/lcdc/lcdc_drv.c | 5 +- drivers/gpu/drm/lcdc/lcdc_slave.c | 384

Re: [RFC] drm/lcdc: add TI LCD Controller DRM driver

2012-12-17 Thread Rob Clark
On Mon, Dec 17, 2012 at 7:56 AM, Tomi Valkeinen tomi.valkei...@ti.com wrote: On 2012-12-14 02:04, Rob Clark wrote: A simple DRM/KMS driver for the TI LCD Controller found in various smaller TI parts (AM33xx, OMAPL138, etc). This driver uses the CMA helpers. Currently only the TFP410 DVI

Re: [RFC] drm/lcdc: add TI LCD Controller DRM driver

2012-12-17 Thread Rob Clark
On Mon, Dec 17, 2012 at 8:39 AM, Rob Clark robdcl...@gmail.com wrote: I'm not very enthusiastic about adding ti-lcdc specific panel/chip drivers. It's not really a big deal if it's only kernel code, but you add device-tree bindings also, which is an external API that you need to support after

Re: [RFC] drm/lcdc: add TI LCD Controller DRM driver

2012-12-17 Thread Rob Clark
On Mon, Dec 17, 2012 at 9:26 AM, Sekhar Nori nori.sek...@gmail.com wrote: Hi Rob, On Monday, December 17, 2012, Rob Clark wrote: On Mon, Dec 17, 2012 at 8:39 AM, Rob Clark robdcl...@gmail.com wrote: I'm not very enthusiastic about adding ti-lcdc specific panel/chip drivers. It's

[RFC] drm/lcdc: add TI LCD Controller DRM driver

2012-12-13 Thread Rob Clark
) will be loaded. Signed-off-by: Rob Clark robdcl...@gmail.com --- drivers/gpu/drm/Kconfig| 2 + drivers/gpu/drm/Makefile | 1 + drivers/gpu/drm/lcdc/Kconfig | 11 + drivers/gpu/drm/lcdc/Makefile | 8 + drivers/gpu/drm/lcdc/lcdc_crtc.c | 544

Re: [PATCH] staging: drm/omap: fix missing include on omap_crtc

2012-11-29 Thread Rob Clark
On 11/28/2012 06:55 AM, Enric Balletbo i Serra wrote: From: Enric Balletbo i Serra eballe...@iseebcn.com This fixes following error: | ... | CC [M] drivers/staging/omapdrm/omap_crtc.o | .../omapdrm/omap_crtc.c:22:22: fatal error: drm_mode.h: No such file or directory | ... fwiw, I have

Re: [PATCH] drm/omap: use omapdss low level API

2012-11-16 Thread Rob Clark
On Fri, Nov 16, 2012 at 12:44 AM, Archit Taneja arc...@ti.com wrote: On Friday 16 November 2012 05:30 AM, Rob Clark wrote: +static void omap_crtc_set_lcd_config(struct omap_overlay_manager *mgr, + const struct dss_lcd_mgr_config *config) +{ + struct omap_crtc *omap_crtc

Re: [PATCH] ARM: add get_user() support for 8 byte types

2012-11-15 Thread Rob Clark
On Thu, Nov 15, 2012 at 3:19 AM, Arnd Bergmann a...@arndb.de wrote: On Tuesday 13 November 2012, Russell King - ARM Linux wrote: You're missing something; that is one of the greatest powers of open source. The many eyes (and minds) effect. Someone out there probably has a solution to

Re: [PATCH] ARM: add get_user() support for 8 byte types

2012-11-15 Thread Rob Clark
On Thu, Nov 15, 2012 at 7:39 AM, Arnd Bergmann a...@arndb.de wrote: On Thursday 15 November 2012, Rob Clark wrote: On Thu, Nov 15, 2012 at 3:19 AM, Arnd Bergmann a...@arndb.de wrote: On Tuesday 13 November 2012, Russell King - ARM Linux wrote: You're missing something; that is one

[PATCH] ARM: add get_user() support for 8 byte types

2012-11-15 Thread Rob Clark
From: Rob Clark r...@ti.com A new atomic modeset/pageflip ioctl being developed in DRM requires get_user() to work for 64bit types (in addition to just put_user()). v1: original v2: pass correct size to check_uaccess, and better handling of narrowing double word read with __get_user_xb

[PATCH] ARM: add get_user() support for 8 byte types

2012-11-13 Thread Rob Clark
From: Rob Clark r...@ti.com A new atomic modeset/pageflip ioctl being developed in DRM requires get_user() to work for 64bit types (in addition to just put_user()). v1: original v2: pass correct size to check_uaccess, and better handling of narrowing double word read with __get_user_xb

Re: [PATCH] ARM: add get_user() support for 8 byte types

2012-11-12 Thread Rob Clark
On Mon, Nov 12, 2012 at 4:46 AM, Will Deacon will.dea...@arm.com wrote: On Fri, Nov 09, 2012 at 09:17:33PM +, Rob Clark wrote: From: Rob Clark r...@ti.com A new atomic modeset/pageflip ioctl being developed in DRM requires get_user() to work for 64bit types (in addition to just put_user

Re: [PATCH] ARM: add get_user() support for 8 byte types

2012-11-12 Thread Rob Clark
On Mon, Nov 12, 2012 at 8:38 AM, Will Deacon will.dea...@arm.com wrote: On Mon, Nov 12, 2012 at 01:46:57PM +, Rob Clark wrote: On Mon, Nov 12, 2012 at 4:46 AM, Will Deacon will.dea...@arm.com wrote: On Fri, Nov 09, 2012 at 09:17:33PM +, Rob Clark wrote: @@ -122,22 +124,35 @@ extern

Re: [PATCH] ARM: add get_user() support for 8 byte types

2012-11-12 Thread Rob Clark
On Mon, Nov 12, 2012 at 1:27 PM, Russell King - ARM Linux li...@arm.linux.org.uk wrote: On Fri, Nov 09, 2012 at 03:17:33PM -0600, Rob Clark wrote: From: Rob Clark r...@ti.com A new atomic modeset/pageflip ioctl being developed in DRM requires get_user() to work for 64bit types (in addition

Re: [PATCH] ARM: add get_user() support for 8 byte types

2012-11-12 Thread Rob Clark
On Mon, Nov 12, 2012 at 5:08 PM, Russell King - ARM Linux li...@arm.linux.org.uk wrote: On Mon, Nov 12, 2012 at 01:58:32PM -0600, Rob Clark wrote: On Mon, Nov 12, 2012 at 1:27 PM, Russell King - ARM Linux li...@arm.linux.org.uk wrote: On Fri, Nov 09, 2012 at 03:17:33PM -0600, Rob Clark wrote

Re: [PATCH] ARM: add get_user() support for 8 byte types

2012-11-12 Thread Rob Clark
On Mon, Nov 12, 2012 at 5:53 PM, Russell King - ARM Linux li...@arm.linux.org.uk wrote: On Mon, Nov 12, 2012 at 05:33:41PM -0600, Rob Clark wrote: I'm sort of thinking maybe we want to change 'switch (sizeof(*(__p)))' with 'switch (sizeof(typeof(x)))' in case someone ignores the compiler

[PATCH] ARM: add get_user() support for 8 byte types

2012-11-09 Thread Rob Clark
From: Rob Clark r...@ti.com A new atomic modeset/pageflip ioctl being developed in DRM requires get_user() to work for 64bit types (in addition to just put_user()). Signed-off-by: Rob Clark r...@ti.com --- arch/arm/include/asm/uaccess.h | 25 - arch/arm/lib/getuser.S

Re: [PATCH 12/12] OMAPDSS: DPI: always use DSI PLL if available

2012-11-07 Thread Rob Clark
On Wed, Nov 7, 2012 at 4:01 AM, Tomi Valkeinen tomi.valkei...@ti.com wrote: On 2012-11-06 16:40, Rob Clark wrote: I mean, similar to how we handle the subdev for dmm.. the omap_drm_init() does the platform_driver_register() for the dmm device before the platform_driver_register() for omapdrm

Re: [PATCH 12/12] OMAPDSS: DPI: always use DSI PLL if available

2012-11-07 Thread Rob Clark
On Wed, Nov 7, 2012 at 9:13 AM, Tomi Valkeinen tomi.valkei...@ti.com wrote: On 2012-11-07 16:32, Rob Clark wrote: On Wed, Nov 7, 2012 at 4:01 AM, Tomi Valkeinen tomi.valkei...@ti.com wrote: Hotplugging is not some abstract future scenario, we already have hardware that could use

Re: [PATCH 12/12] OMAPDSS: DPI: always use DSI PLL if available

2012-11-06 Thread Rob Clark
On Tue, Nov 6, 2012 at 7:41 AM, Tomi Valkeinen to...@iki.fi wrote: On 2012-11-05 16:21, Rob Clark wrote: On 11/05/2012 02:55 AM, Tomi Valkeinen wrote: But even then, choosing the manager is not easy, as whoever chooses the manager needs to observe all the possible displays used at the same

Re: [PATCH 12/12] OMAPDSS: DPI: always use DSI PLL if available

2012-11-05 Thread Rob Clark
On 11/05/2012 02:55 AM, Tomi Valkeinen wrote: But even then, choosing the manager is not easy, as whoever chooses the manager needs to observe all the possible displays used at the same time... Right. I was wondering if omapfb/omapdrm could understand the 'all possible displays information'

[PATCH] drm/omap: only advertise rotation prop if supported

2012-10-25 Thread Rob Clark
From: Rob Clark r...@ti.com For hardware that does not have DMM/TILER, there is no rotation, so no point in getting userspace's hopes up. Signed-off-by: Rob Clark r...@ti.com --- drivers/staging/omapdrm/omap_drv.c | 27 +++ drivers/staging/omapdrm/omap_plane.c | 34

[PATCH] drm/omap: fix issue w/ fb attached to multiple CRTCs

2012-10-12 Thread Rob Clark
From: Rob Clark r...@ti.com When the fb is detached from one CRTC/plane, paddr was set back to zero. But really we don't want to do this because the fb could still be attached to other CRTC/plane(s). This originally worked like this to catch cases of freeing a pinned fb (but with the refcnt'ing

Re: [PATCH] drm/omap: add more new timings fields

2012-09-10 Thread Rob Clark
On Mon, Sep 10, 2012 at 12:50 AM, Tomi Valkeinen tomi.valkei...@ti.com wrote: On Fri, 2012-09-07 at 12:59 -0500, Rob Clark wrote: From: Rob Clark r...@ti.com Without these, DVI is broken. Signed-off-by: Rob Clark r...@ti.com --- Greg, it looks like the omapdss changes which added

[PATCH] drm/omap: add more new timings fields

2012-09-07 Thread Rob Clark
From: Rob Clark r...@ti.com Without these, DVI is broken. Signed-off-by: Rob Clark r...@ti.com --- Greg, it looks like the omapdss changes which added these fields, as well as the interlaced field, where merged in Linux 3.5-rc5. So I think both this and the 'update for interlaced' patch

Re: Converting OMAP's custom vram allocator

2012-09-06 Thread Rob Clark
On Wed, Sep 5, 2012 at 5:08 AM, Tomi Valkeinen tomi.valkei...@ti.com wrote: Hi, OMAP has a custom video ram allocator, which I'd like to remove and use the standard dma allocation functions. There are two problems for which I'd like to hear suggestions or comments: First one is that the

[PATCH] drm/omap: update for interlaced

2012-09-05 Thread Rob Clark
From: Rob Clark r...@ti.com 'struct omap_video_timings' was updated w/ a 'bool interlaced'. Without a matching update in omap_connector, this field could have undefined values from the stack, which isn't quite ideal. Update the fxns to convert omapdss-drm timings structs, and zero-init 'struct

[PATCH 2/2] drm/omap: invert dimensions on crtc when rotated

2012-09-04 Thread Rob Clark
From: Rob Clark r...@ti.com If rotated 90 or 270, we need to invert the dimensions used by drm core for calculating if the dimensions of an attached fb are correct. Signed-off-by: Rob Clark r...@ti.com --- drivers/staging/omapdrm/omap_crtc.c |7 +++ 1 file changed, 7 insertions(+) diff

[PATCH 1/2] drm: support for rotated scanout

2012-09-04 Thread Rob Clark
From: Rob Clark r...@ti.com For drivers that can support rotated scanout, the extra parameter checking in drm-core, while nice, tends to get confused. To solve this drivers can set the crtc or plane invert_dimensions field so that the dimension checking takes into account the rotation

[PATCH] drm/omap: hold a ref to the bo while waiting for flip

2012-09-04 Thread Rob Clark
From: Rob Clark r...@ti.com Since the plane hasn't yet taken a reference, we need to hold a reference while waiting to ensure the backing GEM bo doesn't get freed from under us. Signed-off-by: Rob Clark r...@ti.com --- drivers/staging/omapdrm/omap_crtc.c | 16 ++-- 1 file changed

Re: [PATCH 2/2] Expose the OMAP Z-Order property through DRM

2012-08-16 Thread Rob Clark
On Thu, Aug 16, 2012 at 8:00 AM, Ville Syrjälä ville.syrj...@linux.intel.com wrote: On Wed, Aug 15, 2012 at 03:18:02PM -0500, Rob Clark wrote: From: Andre Renaud an...@bluewatersys.com Added support for zorder changes through DRM plane properties Signed-off-by: Andre Renaud

[PATCH 0/2] drm/omap: properties patches

2012-08-15 Thread Rob Clark
From: Rob Clark r...@ti.com Re-sending the earlier rotation property patch, plus Andre's z-order property patch rebased on latest staging-next. Andre Renaud (1): Expose the OMAP Z-Order property through DRM Rob Clark (1): staging: drm/omap: add rotation properties drivers/staging/omapdrm

[PATCH 1/2] staging: drm/omap: add rotation properties

2012-08-15 Thread Rob Clark
From: Rob Clark r...@ti.com Use tiled buffers for rotated/reflected scanout, with CRTC and plane properties as the interface for userspace to configure rotation. Signed-off-by: Rob Clark r...@ti.com --- drivers/staging/omapdrm/omap_crtc.c | 10 +++ drivers/staging/omapdrm

[PATCH 2/2] Expose the OMAP Z-Order property through DRM

2012-08-15 Thread Rob Clark
From: Andre Renaud an...@bluewatersys.com Added support for zorder changes through DRM plane properties Signed-off-by: Andre Renaud an...@bluewatersys.com Signed-off-by: Rob Clark r...@ti.com --- drivers/staging/omapdrm/omap_drv.h |1 + drivers/staging/omapdrm/omap_plane.c | 19

Re: [PATCH v2 09/13] OMAPDSS: SDI: Create a function to set timings

2012-08-14 Thread Rob Clark
On Tue, Aug 14, 2012 at 11:56 AM, Archit Taneja arc...@ti.com wrote: On Tuesday 14 August 2012 07:14 PM, Tomi Valkeinen wrote: On Thu, 2012-08-09 at 17:19 +0530, Archit Taneja wrote: Create function omapdss_sdi_set_timings(). Configuring new timings is done the same way as before, SDI is

Re: [PATCH] staging: omapdrm: Remove unnecessary memcpy

2012-08-10 Thread Rob Clark
On Thu, Aug 9, 2012 at 12:13 AM, Andy Gross andy.gr...@ti.com wrote: Removed the unnecessary copy of the memory page addresses when programming the DMM/PAT and all support code for the lut copy. The original intent was to have this code in place for suspend/resume functionality w.r.t.

Re: [PATCH] staging: omapdrm: Fix DMM sparse warnings

2012-08-09 Thread Rob Clark
: warning: Using plain integer as NULL pointer Signed-off-by: Andy Gross andy.gr...@ti.com Signed-off-by: Rob Clark rob.cl...@linaro.org --- drivers/staging/omapdrm/omap_dmm_tiler.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/omapdrm

Re: [RFC 0/3] solving omapdrm/omapdss layering issues

2012-08-03 Thread Rob Clark
On Fri, Aug 3, 2012 at 1:01 AM, Semwal, Sumit sumit.sem...@ti.com wrote: Hi Rob, Tomi, On Thu, Aug 2, 2012 at 7:46 PM, Rob Clark rob.cl...@linaro.org wrote: On Thu, Aug 2, 2012 at 8:15 AM, Tomi Valkeinen tomi.valkei...@ti.com wrote: On Thu, 2012-08-02 at 07:45 -0500, Rob Clark wrote: On Thu

Re: [RFC 0/3] solving omapdrm/omapdss layering issues

2012-08-02 Thread Rob Clark
On Thu, Aug 2, 2012 at 8:15 AM, Tomi Valkeinen tomi.valkei...@ti.com wrote: On Thu, 2012-08-02 at 07:45 -0500, Rob Clark wrote: On Thu, Aug 2, 2012 at 2:13 AM, Tomi Valkeinen tomi.valkei...@ti.com wrote: On Wed, 2012-08-01 at 09:25 -0500, Rob Clark wrote: On Wed, Aug 1, 2012 at 4:21 AM, Tomi

Re: [PATCH] staging: drm/omap: remove reclaim_buffers callback

2012-08-01 Thread Rob Clark
, the callback for reclaim_buffers is removed from omapdrm. Signed-off-by: Chandrabhanu Mahapatra cmahapa...@ti.com Signed-off-by: Rob Clark r...@ti.com --- drivers/staging/omapdrm/omap_drv.c |1 - 1 file changed, 1 deletion(-) diff --git a/drivers/staging/omapdrm/omap_drv.c b/drivers

Re: [PATCH] drm: refcnt drm_framebuffer

2012-08-01 Thread Rob Clark
On Wed, Aug 1, 2012 at 6:36 AM, Ville Syrjälä ville.syrj...@linux.intel.com wrote: On Tue, Jul 31, 2012 at 02:28:29PM -0500, Rob Clark wrote: On Tue, Jul 31, 2012 at 12:47 PM, Chris Wilson ch...@chris-wilson.co.uk wrote: On Tue, 31 Jul 2012 12:41:28 -0500, Rob Clark rob.cl...@linaro.org

Re: [RFC 0/3] solving omapdrm/omapdss layering issues

2012-08-01 Thread Rob Clark
On Wed, Aug 1, 2012 at 4:21 AM, Tomi Valkeinen tomi.valkei...@ti.com wrote: On Tue, 2012-07-31 at 09:45 -0500, Rob Clark wrote: On Tue, Jul 31, 2012 at 8:40 AM, Tomi Valkeinen tomi.valkei...@ti.com wrote: It's not really about being friendly. Omapdss tries to do as little as possible

Re: [RFC 0/3] solving omapdrm/omapdss layering issues

2012-08-01 Thread Rob Clark
On Wed, Aug 1, 2012 at 11:46 AM, Archit Taneja arc...@ti.com wrote: Hi, On Wednesday 01 August 2012 07:55 PM, Rob Clark wrote: On Wed, Aug 1, 2012 at 4:21 AM, Tomi Valkeinen tomi.valkei...@ti.com wrote: On Tue, 2012-07-31 at 09:45 -0500, Rob Clark wrote: On Tue, Jul 31, 2012 at 8:40 AM

Re: [RFC 0/3] solving omapdrm/omapdss layering issues

2012-08-01 Thread Rob Clark
On Wed, Aug 1, 2012 at 11:53 AM, Rob Clark rob.cl...@linaro.org wrote: On Wed, Aug 1, 2012 at 11:46 AM, Archit Taneja arc...@ti.com wrote: Hi, On Wednesday 01 August 2012 07:55 PM, Rob Clark wrote: On Wed, Aug 1, 2012 at 4:21 AM, Tomi Valkeinen tomi.valkei...@ti.com wrote: On Tue, 2012

Re: [PATCH] staging: drm/omap: remove reclaim_buffers callback

2012-08-01 Thread Rob Clark
support and so the callback for reclaim_buffers is being removed from omapdrm. Signed-off-by: Chandrabhanu Mahapatra cmahapa...@ti.com Signed-off-by: Rob Clark r...@ti.com --- drivers/staging/omapdrm/omap_drv.c |1 - 1 file changed, 1 deletion(-) diff --git a/drivers/staging/omapdrm

Re: [RFC 0/3] solving omapdrm/omapdss layering issues

2012-08-01 Thread Rob Clark
On Wed, Aug 1, 2012 at 12:38 PM, Tomi Valkeinen tomi.valkei...@ti.com wrote: On Wed, 2012-08-01 at 11:53 -0500, Rob Clark wrote: Ok.. this would help. I'll take a look. I do request that interfaces/panels don't set any mgr/timing related registers. I had to comment all this stuff out in my

Re: [RFC 0/3] solving omapdrm/omapdss layering issues

2012-07-31 Thread Rob Clark
On Tue, Jul 31, 2012 at 8:40 AM, Tomi Valkeinen tomi.valkei...@ti.com wrote: Hi, On Fri, 2012-07-27 at 20:07 -0500, Rob Clark wrote: From: Rob Clark r...@ti.com I've been working for the better part of the week on solving some of the omapdss vs kms mismatches, which is one of the bigger

[PATCH] drm: refcnt drm_framebuffer

2012-07-31 Thread Rob Clark
From: Rob Clark r...@ti.com This simplifies drm fb lifetime, and if the crtc/plane needs to hold a ref to the fb when disabling a pipe until the next vblank, this avoids the need to make disabling an overlay synchronous. This is a problem that shows up when userspace is using a drm plane

Re: [PATCH] drm: refcnt drm_framebuffer

2012-07-31 Thread Rob Clark
On Tue, Jul 31, 2012 at 12:00 PM, Chris Wilson ch...@chris-wilson.co.uk wrote: On Tue, 31 Jul 2012 11:20:21 -0500, Rob Clark rob.cl...@linaro.org wrote: From: Rob Clark r...@ti.com This simplifies drm fb lifetime, and if the crtc/plane needs to hold a ref to the fb when disabling a pipe until

Re: [PATCH] drm: refcnt drm_framebuffer

2012-07-31 Thread Rob Clark
On Tue, Jul 31, 2012 at 12:47 PM, Chris Wilson ch...@chris-wilson.co.uk wrote: On Tue, 31 Jul 2012 12:41:28 -0500, Rob Clark rob.cl...@linaro.org wrote: On Tue, Jul 31, 2012 at 12:00 PM, Chris Wilson ch...@chris-wilson.co.uk wrote: On Tue, 31 Jul 2012 11:20:21 -0500, Rob Clark rob.cl

Re: [PATCH] drm: refcnt drm_framebuffer

2012-07-31 Thread Rob Clark
On Tue, Jul 31, 2012 at 12:47 PM, Chris Wilson ch...@chris-wilson.co.uk wrote: On Tue, 31 Jul 2012 12:41:28 -0500, Rob Clark rob.cl...@linaro.org wrote: On Tue, Jul 31, 2012 at 12:00 PM, Chris Wilson ch...@chris-wilson.co.uk wrote: On Tue, 31 Jul 2012 11:20:21 -0500, Rob Clark rob.cl

[RFC 0/3] solving omapdrm/omapdss layering issues

2012-07-27 Thread Rob Clark
From: Rob Clark r...@ti.com I've been working for the better part of the week on solving some of the omapdss vs kms mismatches, which is one of the bigger remaining issues in the TODO before moving omapdrm out of staging. The biggest place that this shows up is in GO bit handling. Basically

[RFC 1/3] OMAPDSS: expose dispc for use from omapdrm

2012-07-27 Thread Rob Clark
From: Rob Clark r...@ti.com Not very clean, just for proof of concept. Signed-off-by: Rob Clark r...@ti.com --- drivers/video/omap2/dss/apply.c |4 ++- drivers/video/omap2/dss/dispc.c | 76 ++- drivers/video/omap2/dss/dss.h |2 ++ drivers/video

[RFC 2/3] omap2+: use dss_dispc hwmod for omapdrm

2012-07-27 Thread Rob Clark
From: Rob Clark r...@ti.com We need this so that platform_get_irq() works when drm core sets up the irq handling. Signed-off-by: Rob Clark r...@ti.com --- arch/arm/mach-omap2/drm.c | 24 +++- 1 file changed, 11 insertions(+), 13 deletions(-) diff --git a/arch/arm/mach

[RFC 3/3] drm/omap: use dispc directly

2012-07-27 Thread Rob Clark
From: Rob Clark r...@ti.com This is still work in progress, but it nicely solves the omapdss vs drm impedence mismatches, and properly fixes unpin confusion vs GO bit status. As an added bonus, we also no longer leave the last overlay buffer pinned. Adding the previously missing vblank event

Re: [PATCH] staging: drm/omap: add rotation properties

2012-06-29 Thread Rob Clark
On Fri, Jun 29, 2012 at 5:46 AM, Tomi Valkeinen tomi.valkei...@ti.com wrote: On Wed, 2012-06-27 at 09:06 -0500, Rob Clark wrote: From: Rob Clark r...@ti.com Use tiled buffers for rotated/reflected scanout, with CRTC and plane properties as the interface for userspace to configure rotation

Re: [PATCH] staging: drm/omap: add rotation properties

2012-06-27 Thread Rob Clark
On Wed, Jun 27, 2012 at 9:06 AM, Rob Clark rob.cl...@linaro.org wrote: From: Rob Clark r...@ti.com Use tiled buffers for rotated/reflected scanout, with CRTC and plane properties as the interface for userspace to configure rotation. btw, I assume the potential controversial part of the patch

[PATCH] staging: drm/omap: add rotation properties

2012-06-27 Thread Rob Clark
From: Rob Clark r...@ti.com Use tiled buffers for rotated/reflected scanout, with CRTC and plane properties as the interface for userspace to configure rotation. Signed-off-by: Rob Clark r...@ti.com --- drivers/staging/omapdrm/omap_crtc.c | 17 + drivers/staging/omapdrm

Re: [PATCH] staging: drm/omap: add rotation properties

2012-06-27 Thread Rob Clark
On Wed, Jun 27, 2012 at 2:40 PM, Greg KH g...@kroah.com wrote: On Wed, Jun 27, 2012 at 09:06:26AM -0500, Rob Clark wrote: From: Rob Clark r...@ti.com Use tiled buffers for rotated/reflected scanout, with CRTC and plane properties as the interface for userspace to configure rotation. Signed

[PATCH] staging: drm/omap: update TODO

2012-06-27 Thread Rob Clark
From: Rob Clark r...@ti.com Update TODO file, which had been neglected. Signed-off-by: Rob Clark r...@ti.com --- drivers/staging/omapdrm/TODO |7 ++- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/drivers/staging/omapdrm/TODO b/drivers/staging/omapdrm/TODO index 55b1837

  1   2   >