Re: [PATCH] usb: musb: use put_sync_suspend instead of put_sync

2011-08-12 Thread Sonasath, Moiz
Felipe, On Fri, Aug 12, 2011 at 9:40 AM, Pandita, Vikram vikram.pand...@ti.com wrote: On Fri, Aug 12, 2011 at 6:55 AM, Pandita, Vikram vikram.pand...@ti.com wrote: On Fri, Aug 12, 2011 at 2:01 AM, Felipe Balbi ba...@ti.com wrote: Hi, (sorry for top-posting) Moiz, are we going to

Re: [PATCH] USB: OTG: Use work_queue in set_vbus for TWL6030 transciever

2011-06-27 Thread Sonasath, Moiz
Todd, On Sat, Jun 25, 2011 at 1:31 AM, Todd Poynor toddpoy...@google.com wrote: On Fri, Jun 24, 2011 at 10:14:03AM -0500, Moiz Sonasath wrote: ... +     if (enabled) +             twl-vbus_enable = 1; +     else +             twl-vbus_enable = 0; + Suggest twl-vbus_enable = enabled;    

RE: [PATCH V3 2/2]OMAP: Disable internal I2C pull-ups in OMAP3630

2010-03-22 Thread Sonasath, Moiz
Tony, -Original Message- From: Sonasath, Moiz Sent: Friday, February 26, 2010 1:15 PM To: linux-omap@vger.kernel.org Cc: t...@atomide.com; Sonasath, Moiz; Pais, Allen; Pandita, Vikram Subject: [PATCH V3 2/2]OMAP: Disable internal I2C pull-ups in OMAP3630 From: Moiz Sonasath m

RE: [PATCH 1/2] omap: Disable TWL4030/5030 I2C1/I2C4 internal pull-ups

2010-02-17 Thread Sonasath, Moiz
Hello Eduardo, -Original Message- From: Eduardo Valentin [mailto:eduardo.valen...@nokia.com] Sent: Wednesday, February 17, 2010 1:46 AM To: Sonasath, Moiz Cc: linux-omap@vger.kernel.org; sa...@linux.intel.com; t...@atomide.com; Pais, Allen Subject: Re: [PATCH 1/2] omap: Disable

RE: [PATCH 1/2] omap: Disable GAIA I2C1/I2C4 internal pull-ups

2010-02-02 Thread Sonasath, Moiz
Tony/Allen/Paul, -Original Message- From: linux-omap-ow...@vger.kernel.org [mailto:linux-omap- ow...@vger.kernel.org] On Behalf Of Tony Lindgren Sent: Tuesday, February 02, 2010 10:56 AM To: Pais, Allen Cc: linux-omap@vger.kernel.org Subject: Re: [PATCH 1/2] omap: Disable GAIA

RE: [PATCH 1/2] omap: Disable GAIA I2C1/I2C4 internal pull-ups

2010-02-02 Thread Sonasath, Moiz
Paul, -Original Message- From: Paul Walmsley [mailto:p...@pwsan.com] Sent: Monday, February 01, 2010 9:37 PM To: Pais, Allen Cc: linux-omap@vger.kernel.org; Sonasath, Moiz; t...@atomide.com Subject: Re: [PATCH 1/2] omap: Disable GAIA I2C1/I2C4 internal pull-ups Hi Allen

RE: [PATCH 2/2] omap i2c: add a timeout to the busy waiting

2009-12-17 Thread Sonasath, Moiz
Alex, -Original Message- From: Menon, Nishanth Sent: Thursday, December 17, 2009 7:59 AM To: Menon, Nishanth; ben-li...@fluff.org; linux-omap@vger.kernel.org; linux-...@vger.kernel.org; Sonasath, Moiz; Pandita, Vikram Subject: Re: [PATCH 2/2] omap i2c: add a timeout to the busy

RE: [RFC] MUSB: Workaround for Ethernet data alignment issue

2009-12-14 Thread Sonasath, Moiz
Nilkesh, -Original Message- From: linux-omap-ow...@vger.kernel.org [mailto:linux-omap- ow...@vger.kernel.org] On Behalf Of Pandita, Vikram Sent: Monday, December 14, 2009 11:39 AM To: Patra, Nilkesh; linux-...@vger.kernel.org Cc: linux-omap@vger.kernel.org; David Brownell; Gadiyar,

RE: I2C broken on OMAP 2430SDP?

2009-12-02 Thread Sonasath, Moiz
any 2430SDP platform to test. Regards Moiz Sonasath -Original Message- From: Paul Walmsley [mailto:p...@pwsan.com] Sent: Tuesday, December 01, 2009 10:01 AM To: linux-omap@vger.kernel.org Cc: Sonasath, Moiz Subject: I2C broken on OMAP 2430SDP? Hi, just wanted to mention

RE: [PATCH V4 3/3] OMAP: I2C: Add mpu wake up latency constraint in i2c

2009-11-23 Thread Sonasath, Moiz
-Original Message- From: Kalle Jokiniemi [mailto:kalle.jokini...@digia.com] Sent: Tuesday, October 27, 2009 7:02 AM To: Sonasath, Moiz Cc: khil...@deeprootsystems.com; linux-omap@vger.kernel.org; Jarkko Nikula; Paul Walmsley; Menon, Nishanth; Pandita, Vikram; jouni.hogander Subject

RE: [PATCH V4 3/3] OMAP: I2C: Add mpu wake up latency constraint in i2c

2009-10-23 Thread Sonasath, Moiz
Hello Jokiniemi! -Original Message- From: Kalle Jokiniemi [mailto:kalle.jokini...@digia.com] Sent: Wednesday, October 21, 2009 6:51 AM To: khil...@deeprootsystems.com Cc: linux-omap@vger.kernel.org; Kalle Jokiniemi; Sonasath, Moiz; Jarkko Nikula; Paul Walmsley; Menon, Nishanth

RE: [PATCH RESEND] I2C: OMAP: Add missing wakeup events

2009-10-13 Thread Sonasath, Moiz
Hello Aaro! -Original Message- From: Aaro Koskinen [mailto:aaro.koski...@nokia.com] Sent: Tuesday, October 13, 2009 4:52 AM To: Sonasath, Moiz Cc: ben-li...@fluff.org; linux-...@vger.kernel.org; linux- o...@vger.kernel.org Subject: Re: [PATCH RESEND] I2C: OMAP: Add missing wakeup

RE: [PATCH RESEND] I2C: OMAP: Add missing wakeup events

2009-10-12 Thread Sonasath, Moiz
Hello Aaro! -Original Message- From: linux-omap-ow...@vger.kernel.org [mailto:linux-omap- ow...@vger.kernel.org] On Behalf Of Aaro Koskinen Sent: Monday, October 12, 2009 5:21 AM To: ben-li...@fluff.org; linux-...@vger.kernel.org Cc: linux-omap@vger.kernel.org; j-pakarav...@ti.com

RE: [PATCH 1/1] OMAP: I2C: Add mpu wake up latency constraint in i2c

2009-10-07 Thread Sonasath, Moiz
Hello Jokiniemi, -Original Message- From: Kalle Jokiniemi [mailto:kalle.jokini...@digia.com] Sent: Wednesday, October 07, 2009 10:01 AM To: Nishanth Menon Cc: Pandita, Vikram; khil...@deeprootsystems.com; Sonasath, Moiz; jhnik...@gmail.com; linux-omap@vger.kernel.org; jouni.hogander

RE: [PATCH 3/3] [OMAP:I2C]OMAP3430 Silicon Errata 1.153

2009-08-20 Thread Sonasath, Moiz
Hi Paul, -Original Message- From: Paul Walmsley [mailto:p...@pwsan.com] Sent: Sunday, August 16, 2009 12:39 PM To: Sonasath, Moiz Cc: linux-...@vger.kernel.org; linux-omap@vger.kernel.org; Menon, Nishanth; Pandita, Vikram Subject: RE: [PATCH 3/3] [OMAP:I2C]OMAP3430 Silicon Errata

RE: [PATCH 3/3] [OMAP:I2C]OMAP3430 Silicon Errata 1.153

2009-08-10 Thread Sonasath, Moiz
-Original Message- From: linux-i2c-ow...@vger.kernel.org [mailto:linux-i2c- ow...@vger.kernel.org] On Behalf Of Sonasath, Moiz Sent: Monday, August 03, 2009 3:20 PM To: Paul Walmsley Cc: linux-...@vger.kernel.org; linux-omap@vger.kernel.org; Menon, Nishanth; Pandita, Vikram

RE: [PATCH 3/3] [OMAP:I2C]OMAP3430 Silicon Errata 1.153

2009-08-03 Thread Sonasath, Moiz
-Original Message- From: Paul Walmsley [mailto:p...@pwsan.com] Sent: Monday, August 03, 2009 2:36 AM To: Sonasath, Moiz Cc: linux-...@vger.kernel.org; linux-omap@vger.kernel.org; Menon, Nishanth; Pandita, Vikram Subject: Re: [PATCH 3/3] [OMAP:I2C]OMAP3430 Silicon Errata 1.153

[PATCH 0/3] [OMAP:I2C] Small bug fixes and errata 1.153

2009-07-21 Thread Sonasath, Moiz
This patch includes the following: - Bug in reading the RXSTAT/TXSTAT values from I2C_BUFFSTAT - In case of a NACK|ARDY|AL interrupts return from the ISR - OMAP3430 silicon errata 1.153 Signed-off-by: Moiz Sonasathm-sonas...@ti.com Signed-off-by: Vikram panditavikram.pand...@ti.com Moiz

[PATCH 1/3] [OMAP:I2C]Bug in reading the RXSTAT/TXSTAT values from the I2C_BUFFSTAT register

2009-07-21 Thread Sonasath, Moiz
Fix bug in reading the I2C_BUFFSTAT register for getting byte count on RX/TX interrupt. On Interrupt: I2C_STAT[RDR], read 'RXSTAT' from I2C_BUFFSTAT[8-13] On Interrupt: I2C_STAT[XDR] read 'TXSTAT' from I2C_BUFFSTAT[0-5] Signed-off-by: Jagadeesh Pakaravoorj-pakarav...@ti.com

[PATCH 2/3] [OMAP:I2C]In case of a NACK|ARDY|AL return from the ISR

2009-07-21 Thread Sonasath, Moiz
In case of a NACK or ARDY or AL interrupt, complete the request. There is no need to service the RRDY/RDR or XRDY/XDR interrupts. Refer TRM SWPU114: Figure 18-31.I2C Master Transmitter Mode, Interrupt Method, in F/S and HS Modes

[PATCH 3/3] [OMAP:I2C]OMAP3430 Silicon Errata 1.153

2009-07-21 Thread Sonasath, Moiz
When an XRDY/XDR is hit, wait for XUDF before writing data to DATA_REG. Otherwise some data bytes can be lost while transferring them from the memory to the I2C interface. Do a Busy-wait for XUDF, before writing data to DATA_REG. While waiting if there is NACK | AL, set the appropriate error

RE: [PATCH 3/3] [OMAP:I2C]OMAP3430 Silicon Errata 1.153

2009-07-20 Thread Sonasath, Moiz
Sonasath, Moiz wrote: When an XRDY/XDR is hit, wait for XUDF before writing data to DATA_REG. Otherwise some data bytes can be lost while transferring them from the memory to the I2C interface. Do a Busy-wait for XUDF, before writing data to DATA_REG. While waiting if there is NACK

RE: [PATCH 3/3] [OMAP:I2C]OMAP3430 Silicon Errata 1.153

2009-07-16 Thread Sonasath, Moiz
Hello Nishant, Comments inlined, Regards Moiz Sonasath -Original Message- From: Menon, Nishanth Sent: Wednesday, July 15, 2009 6:03 PM To: Sonasath, Moiz Cc: linux-omap@vger.kernel.org; Kamat, Nishant; Paul Walmsley; Pandita, Vikram Subject: Re: [PATCH 3/3] [OMAP:I2C]OMAP3430 Silicon

RE: [PATCH 2/3] [OMAP:I2C]In case of a NACK|ARDY|AL return from the ISR

2009-07-15 Thread Sonasath, Moiz
Hello Nishant, Comments inlined: Regards Moiz Sonasath Linux Baseport Team, Dallas 214-567-5514 -Original Message- From: Menon, Nishanth Sent: Tuesday, July 14, 2009 5:22 PM To: Sonasath, Moiz; linux-omap@vger.kernel.org Cc: Kamat, Nishant; Paul Walmsley Subject: RE: [PATCH 2/3

RE: [PATCH 3/3] [OMAP:I2C]OMAP3430 Silicon Errata 1.153

2009-07-15 Thread Sonasath, Moiz
Hello Nishant, Comments inlined: Regards Moiz Sonasath Linux Baseport Team, Dallas 214-567-5514 -Original Message- From: Menon, Nishanth Sent: Tuesday, July 14, 2009 6:23 PM To: Sonasath, Moiz Cc: linux-omap@vger.kernel.org; Kamat, Nishant; Paul Walmsley Subject: Re: [PATCH 3/3

RE: [PATCH 3/3] [OMAP:I2C]OMAP3430 Silicon Errata 1.153

2009-07-15 Thread Sonasath, Moiz
Hello Nishant, Comments inlined, Regards Moiz Sonasath -Original Message- From: Menon, Nishanth Sent: Wednesday, July 15, 2009 4:43 PM To: Sonasath, Moiz Cc: linux-omap@vger.kernel.org; Kamat, Nishant; Paul Walmsley Subject: Re: [PATCH 3/3] [OMAP:I2C]OMAP3430 Silicon Errata 1.153

RE: [PATCH 3/3] [OMAP:I2C]OMAP3430 Silicon Errata 1.153

2009-07-15 Thread Sonasath, Moiz
Hello Nishant! I am also not sure, if the count=100; value will be enough time for the XUDF to be set. If not then it will keep running into timeout errors. Regards Moiz Sonasath -Original Message- From: Menon, Nishanth Sent: Wednesday, July 15, 2009 5:27 PM To: Sonasath, Moiz Cc

RE: [PATCH 3/3] [OMAP:I2C]OMAP3430 Silicon Errata 1.153

2009-07-15 Thread Sonasath, Moiz
value so that we don't fall in the timeout case under normal operation. May be someone can give a pointer here. Regards Moiz Sonasath -Original Message- From: Menon, Nishanth Sent: Wednesday, July 15, 2009 5:32 PM To: Sonasath, Moiz Cc: linux-omap@vger.kernel.org; Kamat, Nishant; Paul

[PATCH 0/3] [OMAP:I2C] Small bug fixes and errata 1.153

2009-07-14 Thread Sonasath, Moiz
This patch includes the following: - Bug in reading the RXSTAT/TXSTAT values from I2C_BUFFSTAT - In case of a NACK|ARDY|AL interrupts return from the ISR - OMAP3430 silicon errata 1.153 Signed-off-by: Moiz Sonasathm-sonas...@ti.com Signed-off-by: Vikram panditavikram.pand...@ti.com Moiz

[PATCH 1/3] [OMAP:I2C]Bug in reading the RXSTAT/TXSTAT values from the I2C_BUFFSTAT register

2009-07-14 Thread Sonasath, Moiz
Fix bug in reading the I2C_BUFFSTAT register for getting byte count on RX/TX interrupt. On Interrupt: I2C_STAT[RDR], read 'RXSTAT' from I2C_BUFFSTAT[8-13] On Interrupt: I2C_STAT[XDR] read 'TXSTAT' from I2C_BUFFSTAT[0-5] Signed-off-by: Moiz Sonasathm-sonas...@ti.com

[PATCH 2/3] [OMAP:I2C]In case of a NACK|ARDY|AL return from the ISR

2009-07-14 Thread Sonasath, Moiz
In case of a NACK or ARDY or AL interrupt, complete the request. There is no need to service the RRDY/RDR or XRDY/XDR interrupts. Refer TRM SWPU114: Figure 18-31.I2C Master Transmitter Mode, Interrupt Method, in F/S and HS Modes

[PATCH 3/3] [OMAP:I2C]OMAP3430 Silicon Errata 1.153

2009-07-14 Thread Sonasath, Moiz
When an XRDY/XDR is hit, wait for XUDF before writing data to DATA_REG. Otherwise some data bytes can be lost while transferring them from the memory to the I2C interface. Do a Busy-wait for XUDF, before writing data to DATA_REG. While waiting if there is NACK | AL, set the appropriate error

RE: [PATCH] [RFC][OMAP3:I2C]Workaround for OMAP3430 I2C silicon errata 1.153

2009-07-08 Thread Sonasath, Moiz
Hello Paul! I am working on this issue and will get back soon. Regards Moiz Sonasath Linux Baseport Team, Dallas 214-567-5514 -Original Message- From: Paul Walmsley [mailto:p...@pwsan.com] Sent: Wednesday, July 08, 2009 11:51 AM To: Sonasath, Moiz Cc: linux-omap@vger.kernel.org

[PATCH] [RFC] Potential bug in defining 'irq field' of 'ifmap structure'

2009-07-06 Thread Sonasath, Moiz
From: Moiz Sonasath m-sonas...@ti.com There seems to be a bug in the ioctl implementation in /kernel/net/core/dev.c dev_ifsioc_locked() case SIOCGIFMAP: ifr-ifr_map.irq = dev-irq; // ?? type mismatch Here ifr-ifr_map.irq) is of type unsigned char dev-irq is

[PATCH] [RFC][OMAP3:I2C]Workaround for OMAP3430 I2C silicon errata 1.153

2009-06-22 Thread Sonasath, Moiz
This patch includes the workarround for I2C Errata 1.153: When an XRDY/XDR is hit, wait for XUDF before writing data to DATA_REG Signed-off-by: Jagadeesh Bhaskar Pakaravoor j-pakarav...@ti.com Signed-off by: Nishant Kamat nska...@ti.com Signed-off-by: Moiz Sonasathm-sonas...@ti.com ---