Re: [PATCH] gpio: omap: Fix missing raw locks conversion

[Linus Walleij]

On Wed, Aug 5, 2015 at 4:37 PM, Axel Lin axel@ingics.com wrote:

 Fix below build warning:
   CC  drivers/gpio/gpio-omap.o
 drivers/gpio/gpio-omap.c: In function 'omap_gpio_irq_type':
 drivers/gpio/gpio-omap.c:504:3: warning: passing argument 1 of 
 'spin_unlock_irqrestore' from incompatible pointer type [enabled by default]
 include/linux/spinlock.h:360:29: note: expected 'struct spinlock_t *' but 
 argument is of type 'struct raw_spinlock_t *'

 Fixes: commit 4dbada2be460 (gpio: omap: use raw locks for locking)
 Signed-off-by: Axel Lin axel@ingics.com

Fixed by merging in -rc4 and applying this patch for next.

Thanks!

Yours,
Linus Walleij
--
To unsubscribe from this list: send the line unsubscribe linux-omap in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[PATCH] gpio: omap: Fix missing raw locks conversion

[Axel Lin]

Fix below build warning:
  CC  drivers/gpio/gpio-omap.o
drivers/gpio/gpio-omap.c: In function 'omap_gpio_irq_type':
drivers/gpio/gpio-omap.c:504:3: warning: passing argument 1 of 
'spin_unlock_irqrestore' from incompatible pointer type [enabled by default]
include/linux/spinlock.h:360:29: note: expected 'struct spinlock_t *' but 
argument is of type 'struct raw_spinlock_t *'

Fixes: commit 4dbada2be460 (gpio: omap: use raw locks for locking)
Signed-off-by: Axel Lin axel@ingics.com
---
 drivers/gpio/gpio-omap.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpio/gpio-omap.c b/drivers/gpio/gpio-omap.c
index dba67b2..466fe70 100644
--- a/drivers/gpio/gpio-omap.c
+++ b/drivers/gpio/gpio-omap.c
@@ -501,7 +501,7 @@ static int omap_gpio_irq_type(struct irq_data *d, unsigned 
type)
raw_spin_lock_irqsave(bank-lock, flags);
retval = omap_set_gpio_triggering(bank, offset, type);
if (retval) {
-   spin_unlock_irqrestore(bank-lock, flags);
+   raw_spin_unlock_irqrestore(bank-lock, flags);
goto error;
}
omap_gpio_init_irq(bank, offset);
-- 
2.1.0



--
To unsubscribe from this list: send the line unsubscribe linux-omap in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html