Re: [PATCH] media:platform: OMAP3 camera support needs VIDEOBUF2_DMA_CONTIG

2014-07-17 Thread Laurent Pinchart
Hi Peter,

Thank you for the patch.

On Friday 04 July 2014 09:51:47 Peter Meerwald wrote:
 drivers/built-in.o: In function `isp_video_open':
 /src/linux/drivers/media/platform/omap3isp/ispvideo.c:1253: undefined
 reference to `vb2_dma_contig_memops' drivers/built-in.o: In function
 `omap3isp_video_init':
 /src/linux/drivers/media/platform/omap3isp/ispvideo.c:1344: undefined
 reference to `vb2_dma_contig_init_ctx'
 /src/linux/drivers/media/platform/omap3isp/ispvideo.c:1350: undefined
 reference to `vb2_dma_contig_cleanup_ctx' drivers/built-in.o: In function
 `omap3isp_video_cleanup':
 /src/linux/drivers/media/platform/omap3isp/ispvideo.c:1381: undefined
 reference to `vb2_dma_contig_cleanup_ctx' make: *** [vmlinux] Error 1
 
 Signed-off-by: Peter Meerwald pme...@pmeerw.net

Acked-by: Laurent Pinchart laurent.pinch...@ideasonboard.com

and applied to my tree, with the select VIDEOBUF2_DMA_CONTIG and select 
OMAP_IOMMU lines swapped below to keep them alphabetically sorted.

 ---
 
 not sure if this is the right way to fix, at least my kernel compiles
 
  drivers/media/platform/Kconfig | 1 +
  1 file changed, 1 insertion(+)
 
 diff --git a/drivers/media/platform/Kconfig b/drivers/media/platform/Kconfig
 index 8108c69..e1ff228 100644
 --- a/drivers/media/platform/Kconfig
 +++ b/drivers/media/platform/Kconfig
 @@ -95,6 +95,7 @@ config VIDEO_OMAP3
   tristate OMAP 3 Camera support
   depends on VIDEO_V4L2  I2C  VIDEO_V4L2_SUBDEV_API  ARCH_OMAP3
   select ARM_DMA_USE_IOMMU
 + select VIDEOBUF2_DMA_CONTIG
   select OMAP_IOMMU
   ---help---
 Driver for an OMAP 3 camera controller.

-- 
Regards,

Laurent Pinchart

--
To unsubscribe from this list: send the line unsubscribe linux-omap in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[PATCH] media:platform: OMAP3 camera support needs VIDEOBUF2_DMA_CONTIG

2014-07-04 Thread Peter Meerwald
drivers/built-in.o: In function `isp_video_open':
/src/linux/drivers/media/platform/omap3isp/ispvideo.c:1253: undefined reference 
to `vb2_dma_contig_memops'
drivers/built-in.o: In function `omap3isp_video_init':
/src/linux/drivers/media/platform/omap3isp/ispvideo.c:1344: undefined reference 
to `vb2_dma_contig_init_ctx'
/src/linux/drivers/media/platform/omap3isp/ispvideo.c:1350: undefined reference 
to `vb2_dma_contig_cleanup_ctx'
drivers/built-in.o: In function `omap3isp_video_cleanup':
/src/linux/drivers/media/platform/omap3isp/ispvideo.c:1381: undefined reference 
to `vb2_dma_contig_cleanup_ctx'
make: *** [vmlinux] Error 1

Signed-off-by: Peter Meerwald pme...@pmeerw.net
---

not sure if this is the right way to fix, at least my kernel compiles

 drivers/media/platform/Kconfig | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/media/platform/Kconfig b/drivers/media/platform/Kconfig
index 8108c69..e1ff228 100644
--- a/drivers/media/platform/Kconfig
+++ b/drivers/media/platform/Kconfig
@@ -95,6 +95,7 @@ config VIDEO_OMAP3
tristate OMAP 3 Camera support
depends on VIDEO_V4L2  I2C  VIDEO_V4L2_SUBDEV_API  ARCH_OMAP3
select ARM_DMA_USE_IOMMU
+   select VIDEOBUF2_DMA_CONTIG
select OMAP_IOMMU
---help---
  Driver for an OMAP 3 camera controller.
-- 
1.9.1

--
To unsubscribe from this list: send the line unsubscribe linux-omap in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html