Re: [PATCH 0/4] Patches to make multi-soc handling in entry-armv.S easier
* Tony Lindgren t...@atomide.com [101204 19:00]: * Nicolas Pitre n...@fluxnic.net [101204 18:26]: On Sat, 4 Dec 2010, Tony Lindgren wrote: My only problem with your approach is the global addition of asm_irq_base and asm_irq_flags in generic code which might not be useful and/or appropriate for all targets. If you were confining them to some OMAP specific file then I wouldn't mind as much. Looking at the patch I see that you had omap_irq_base before. Why wasn't that sufficient? Only omap_irq_flags would be missing. I guess I was thinking this is something that might help others to build more machines into one defconfig. If that's not the case, sure these can be kept omap specific. After a quick browsing of the entry-macro.S files, looks like there's some similar ifdeffery for get_irqnr_* macros that just might be possible to clear out with asm_irq_base and asm_irq_flags: arch/arm/mach-davinci/include/mach/entry-macro.S arch/arm/mach-s5p64x0/include/mach/entry-macro.S arch/arm/mach-ixp4xx/include/mach/entry-macro.S arch/arm/mach-h720x/include/mach/entry-macro.S arch/arm/plat-mxc/include/mach/entry-macro.S Maybe let's wait a while to see if there are other use cases, if not, I'll make them omap specific. OK, no other people interested, will post the omap specific versions as a reply to this message. Regards, Tony -- To unsubscribe from this list: send the line unsubscribe linux-omap in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 0/4] Patches to make multi-soc handling in entry-armv.S easier
* Nicolas Pitre n...@fluxnic.net [101203 21:39]: On Fri, 3 Dec 2010, Tony Lindgren wrote: Hi all, I've got some patches almost ready to go to merge the omap1 configs into a single omap1_defconfig. While working on getting that done, I had to come up with a better solution for entry-armv.S macros to detect the soc we're running on. I suggest we add asm_irq_base and asm_irq_flags as in the first patch in this series does. This way we can do the soc based detection in init_irq or similar place. This might help also the multi-arm work too. Did you see Eric Miao's patch series that introduces runtime IRQ demux handler support? http://www.spinics.net/linux/lists/arm-kernel/msg92836.html That is likely to be a better solution. Yeah that works too, although is a bit heavier for simple cases. In the omap case just the irq base is different between omap2 vs omap3. And only level2 interrupt bit is different omap7xx vs omap16xx. Handling the difference between omap2/3 and omap4 would be the use case for handle_arch_irq. Currently that too can be handled without handle_arch_irq, but from multi-arm point of view handle_arch_irq is needed in the long run. I can do things either way quite easily for sure. But my preference would be to have both options available. This is because asm_irq_base and asm_irq_flags can be used to reduce 15 omap1 defconfigs into one defconfig with quite minimal changes. And for omap2+, these patches allow getting rid of the SoC detection code in entry-macro.S. Also, after these patches, moving to use handle_arch_irq can be done a bit easier later on. Regards, Tony -- To unsubscribe from this list: send the line unsubscribe linux-omap in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 0/4] Patches to make multi-soc handling in entry-armv.S easier
On Sat, 4 Dec 2010, Tony Lindgren wrote: * Nicolas Pitre n...@fluxnic.net [101203 21:39]: On Fri, 3 Dec 2010, Tony Lindgren wrote: Hi all, I've got some patches almost ready to go to merge the omap1 configs into a single omap1_defconfig. While working on getting that done, I had to come up with a better solution for entry-armv.S macros to detect the soc we're running on. I suggest we add asm_irq_base and asm_irq_flags as in the first patch in this series does. This way we can do the soc based detection in init_irq or similar place. This might help also the multi-arm work too. Did you see Eric Miao's patch series that introduces runtime IRQ demux handler support? http://www.spinics.net/linux/lists/arm-kernel/msg92836.html That is likely to be a better solution. Yeah that works too, although is a bit heavier for simple cases. In the omap case just the irq base is different between omap2 vs omap3. And only level2 interrupt bit is different omap7xx vs omap16xx. Handling the difference between omap2/3 and omap4 would be the use case for handle_arch_irq. Currently that too can be handled without handle_arch_irq, but from multi-arm point of view handle_arch_irq is needed in the long run. I can do things either way quite easily for sure. But my preference would be to have both options available. This is because asm_irq_base and asm_irq_flags can be used to reduce 15 omap1 defconfigs into one defconfig with quite minimal changes. And for omap2+, these patches allow getting rid of the SoC detection code in entry-macro.S. Also, after these patches, moving to use handle_arch_irq can be done a bit easier later on. My only problem with your approach is the global addition of asm_irq_base and asm_irq_flags in generic code which might not be useful and/or appropriate for all targets. If you were confining them to some OMAP specific file then I wouldn't mind as much. Looking at the patch I see that you had omap_irq_base before. Why wasn't that sufficient? Only omap_irq_flags would be missing. Nicolas -- To unsubscribe from this list: send the line unsubscribe linux-omap in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 0/4] Patches to make multi-soc handling in entry-armv.S easier
* Nicolas Pitre n...@fluxnic.net [101204 18:26]: On Sat, 4 Dec 2010, Tony Lindgren wrote: My only problem with your approach is the global addition of asm_irq_base and asm_irq_flags in generic code which might not be useful and/or appropriate for all targets. If you were confining them to some OMAP specific file then I wouldn't mind as much. Looking at the patch I see that you had omap_irq_base before. Why wasn't that sufficient? Only omap_irq_flags would be missing. I guess I was thinking this is something that might help others to build more machines into one defconfig. If that's not the case, sure these can be kept omap specific. After a quick browsing of the entry-macro.S files, looks like there's some similar ifdeffery for get_irqnr_* macros that just might be possible to clear out with asm_irq_base and asm_irq_flags: arch/arm/mach-davinci/include/mach/entry-macro.S arch/arm/mach-s5p64x0/include/mach/entry-macro.S arch/arm/mach-ixp4xx/include/mach/entry-macro.S arch/arm/mach-h720x/include/mach/entry-macro.S arch/arm/plat-mxc/include/mach/entry-macro.S Maybe let's wait a while to see if there are other use cases, if not, I'll make them omap specific. Regards, Tony -- To unsubscribe from this list: send the line unsubscribe linux-omap in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
[PATCH 0/4] Patches to make multi-soc handling in entry-armv.S easier
Hi all, I've got some patches almost ready to go to merge the omap1 configs into a single omap1_defconfig. While working on getting that done, I had to come up with a better solution for entry-armv.S macros to detect the soc we're running on. I suggest we add asm_irq_base and asm_irq_flags as in the first patch in this series does. This way we can do the soc based detection in init_irq or similar place. This might help also the multi-arm work too. Regards, Tony --- Tony Lindgren (4): ARM: Add asm_irq_base and asm_irq_flags for entry-armv.S macros omap2+: Use asm_irq_base for entry-macro.S omap1: Use asm_irq_flags for entry-macro.S omap1: Use get_irqnr_preamble arch/arm/include/asm/irq.h |2 + arch/arm/kernel/entry-armv.S | 13 arch/arm/mach-omap1/include/mach/entry-macro.S | 20 +++-- arch/arm/mach-omap1/irq.c |4 +++ arch/arm/mach-omap2/include/mach/entry-macro.S | 37 +++- arch/arm/mach-omap2/io.c | 20 + arch/arm/plat-omap/include/plat/irqs.h |2 + 7 files changed, 49 insertions(+), 49 deletions(-) -- Signature -- To unsubscribe from this list: send the line unsubscribe linux-omap in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 0/4] Patches to make multi-soc handling in entry-armv.S easier
On Fri, 3 Dec 2010, Tony Lindgren wrote: Hi all, I've got some patches almost ready to go to merge the omap1 configs into a single omap1_defconfig. While working on getting that done, I had to come up with a better solution for entry-armv.S macros to detect the soc we're running on. I suggest we add asm_irq_base and asm_irq_flags as in the first patch in this series does. This way we can do the soc based detection in init_irq or similar place. This might help also the multi-arm work too. Did you see Eric Miao's patch series that introduces runtime IRQ demux handler support? http://www.spinics.net/linux/lists/arm-kernel/msg92836.html That is likely to be a better solution. Nicolas -- To unsubscribe from this list: send the line unsubscribe linux-omap in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html