Re: [PATCH 00/11] ARM: OMAP: OMAP5 AM43x DSS
On Tuesday 20 May 2014 11:01 AM, Archit Taneja wrote: Hi, On Friday 16 May 2014 01:44 PM, Tomi Valkeinen wrote: On 12/05/14 18:48, Tony Lindgren wrote: Also, I'm wondering why we still have .clk and .opt_clks entries in the hwmod data for am43xx and omap5 which are both device tree based with all the clocks coming from .dts files? I think they are needed for the omap_device/hwmod stuff to work. Only omapdss driver knows about the clocks defined in the .dts files, and the omap_device/hwmod code still needs to do the reset and maybe some other tasks that require the clocks. We're already populating the hwmod data from dts entries, that's done by omap_device_build_from_dt. Why aren't we doing that for dt defined clocks? I'd rather not start adding new data that will then just be removed, that's what people call pointless extra churn. I don't know why. I have to say I'm not 100% sure if that's done or not, but at least I can't find where it's done. The reason why clocks are needed from hwmod data is because we still don't populate hwmod fields like main_clk and opt_clock from DT clocks. The reason why this isn't done yet is because we currently haven't figured out a clean way to tell hwmod what clock is the main_clk, and what clocks are optional clocks. One of the proposed methods was to assume the clock named to be fck as main_clk, and the remaining clocks as optional clocks for hwmod. That method wasn't agreed upon, this looks like the thread which discusses this: http://marc.info/?l=linux-arm-kernelm=138928084823142w=2 So I started to look through this again and I realized most of the opt clock information is actually unused within hwmod and does not even need to be there. I just proposed an RFC here to clean some of that [1] The only modules which do need this seem to be gpio and dss (though we still need to check if all the newer platforms need this, or this is one of those things just carried forward because some old platform had an issue with gpio and dss ocp reset) As far as DSS is concerned, this is used within the custom reset function (not within hwmod) in display.c in mach-omap2/ Its just that the current code relies on hwmod structures, which can very easily now extract this from DT instead. That just leaves gpio, which should be the only clock information that will have to exist in hwmod till we figure out how to move it to DT. All the main_clks from hwmod can very easily to moved to DT as already proposed using something like 'fck' to identify them. [1] http://marc.info/?l=linux-omapm=140057445618162w=2 Archit -- To unsubscribe from this list: send the line unsubscribe linux-omap in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 00/11] ARM: OMAP: OMAP5 AM43x DSS
Hi, On Friday 16 May 2014 01:44 PM, Tomi Valkeinen wrote: On 12/05/14 18:48, Tony Lindgren wrote: Also, I'm wondering why we still have .clk and .opt_clks entries in the hwmod data for am43xx and omap5 which are both device tree based with all the clocks coming from .dts files? I think they are needed for the omap_device/hwmod stuff to work. Only omapdss driver knows about the clocks defined in the .dts files, and the omap_device/hwmod code still needs to do the reset and maybe some other tasks that require the clocks. We're already populating the hwmod data from dts entries, that's done by omap_device_build_from_dt. Why aren't we doing that for dt defined clocks? I'd rather not start adding new data that will then just be removed, that's what people call pointless extra churn. I don't know why. I have to say I'm not 100% sure if that's done or not, but at least I can't find where it's done. The reason why clocks are needed from hwmod data is because we still don't populate hwmod fields like main_clk and opt_clock from DT clocks. The reason why this isn't done yet is because we currently haven't figured out a clean way to tell hwmod what clock is the main_clk, and what clocks are optional clocks. One of the proposed methods was to assume the clock named to be fck as main_clk, and the remaining clocks as optional clocks for hwmod. That method wasn't agreed upon, this looks like the thread which discusses this: http://marc.info/?l=linux-arm-kernelm=138928084823142w=2 Archit -- To unsubscribe from this list: send the line unsubscribe linux-omap in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 00/11] ARM: OMAP: OMAP5 AM43x DSS
On 12/05/14 18:48, Tony Lindgren wrote: Also, I'm wondering why we still have .clk and .opt_clks entries in the hwmod data for am43xx and omap5 which are both device tree based with all the clocks coming from .dts files? I think they are needed for the omap_device/hwmod stuff to work. Only omapdss driver knows about the clocks defined in the .dts files, and the omap_device/hwmod code still needs to do the reset and maybe some other tasks that require the clocks. We're already populating the hwmod data from dts entries, that's done by omap_device_build_from_dt. Why aren't we doing that for dt defined clocks? I'd rather not start adding new data that will then just be removed, that's what people call pointless extra churn. I don't know why. I have to say I'm not 100% sure if that's done or not, but at least I can't find where it's done. Tomi signature.asc Description: OpenPGP digital signature
Re: [PATCH 00/11] ARM: OMAP: OMAP5 AM43x DSS
On 12/05/14 17:36, Tony Lindgren wrote: * Tomi Valkeinen tomi.valkei...@ti.com [140512 06:26]: Hi Tony, On 09/05/14 14:56, Tomi Valkeinen wrote: Hi, Here are arch/arm/ patches to add display support for OMAP5 and AM43x. I have these in my tree, in a branch I will send to Tony for merging. Most of these patches have already been around the lists, but I wanted to send them one more time to verify that all looks right and everybody is fine with them. I have pushed these to: git://git.kernel.org/pub/scm/linux/kernel/git/tomba/linux.git 3.16/omap If you're fine with these, I think we can consider that branch stable. There are probably still a few display related .dts changed for the board coming up, but I'll add those on top of the current commits. Please coordinate things with Paul and Tero so you at least have proper acks for the hwmod and and clock patches. In general we really want to queue hwmod and clock changes separately as those can easily mess up things in a bad way like we've already seen with overlapping hwmod entries in the .dts files. I don't think the clock dts changes can be separated from the other dts changes, as the new 'dss_l3_iclk' clock node is required by the omap5.dtsi when adding the DSS support. The HWMOD patches can go separately. Tomi signature.asc Description: OpenPGP digital signature
Re: [PATCH 00/11] ARM: OMAP: OMAP5 AM43x DSS
Hi Tony, On 09/05/14 14:56, Tomi Valkeinen wrote: Hi, Here are arch/arm/ patches to add display support for OMAP5 and AM43x. I have these in my tree, in a branch I will send to Tony for merging. Most of these patches have already been around the lists, but I wanted to send them one more time to verify that all looks right and everybody is fine with them. I have pushed these to: git://git.kernel.org/pub/scm/linux/kernel/git/tomba/linux.git 3.16/omap If you're fine with these, I think we can consider that branch stable. There are probably still a few display related .dts changed for the board coming up, but I'll add those on top of the current commits. I also have pushed OMAP5 and AM43xx related OMAPDSS patches to my for-next branch, so with 3.16/omap branch and linux-next, the omap5 and am43xx displays should be functional. How do you want to handle getting the 3.16/omap branch to linux-next? Will you take ownership of the branch, and push it to linux-next? Tomi signature.asc Description: OpenPGP digital signature
Re: [PATCH 00/11] ARM: OMAP: OMAP5 AM43x DSS
* Tomi Valkeinen tomi.valkei...@ti.com [140512 06:26]: Hi Tony, On 09/05/14 14:56, Tomi Valkeinen wrote: Hi, Here are arch/arm/ patches to add display support for OMAP5 and AM43x. I have these in my tree, in a branch I will send to Tony for merging. Most of these patches have already been around the lists, but I wanted to send them one more time to verify that all looks right and everybody is fine with them. I have pushed these to: git://git.kernel.org/pub/scm/linux/kernel/git/tomba/linux.git 3.16/omap If you're fine with these, I think we can consider that branch stable. There are probably still a few display related .dts changed for the board coming up, but I'll add those on top of the current commits. Please coordinate things with Paul and Tero so you at least have proper acks for the hwmod and and clock patches. In general we really want to queue hwmod and clock changes separately as those can easily mess up things in a bad way like we've already seen with overlapping hwmod entries in the .dts files. Also, I'm wondering why we still have .clk and .opt_clks entries in the hwmod data for am43xx and omap5 which are both device tree based with all the clocks coming from .dts files? I also have pushed OMAP5 and AM43xx related OMAPDSS patches to my for-next branch, so with 3.16/omap branch and linux-next, the omap5 and am43xx displays should be functional. The panel parts look OK to me no problem. How do you want to handle getting the 3.16/omap branch to linux-next? Will you take ownership of the branch, and push it to linux-next? Ideally we'd have small topic branches of clock changes, hwmod changes and .dts changes that we can all merge in as needed. Regards, Tony -- To unsubscribe from this list: send the line unsubscribe linux-omap in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 00/11] ARM: OMAP: OMAP5 AM43x DSS
On 12/05/14 17:36, Tony Lindgren wrote: * Tomi Valkeinen tomi.valkei...@ti.com [140512 06:26]: Hi Tony, On 09/05/14 14:56, Tomi Valkeinen wrote: Hi, Here are arch/arm/ patches to add display support for OMAP5 and AM43x. I have these in my tree, in a branch I will send to Tony for merging. Most of these patches have already been around the lists, but I wanted to send them one more time to verify that all looks right and everybody is fine with them. I have pushed these to: git://git.kernel.org/pub/scm/linux/kernel/git/tomba/linux.git 3.16/omap If you're fine with these, I think we can consider that branch stable. There are probably still a few display related .dts changed for the board coming up, but I'll add those on top of the current commits. Please coordinate things with Paul and Tero so you at least have proper acks for the hwmod and and clock patches. In general we really want to queue hwmod and clock changes separately as those can easily mess up things in a bad way like we've already seen with overlapping hwmod entries in the .dts files. Ok. I'm fine with splitting the series if that's easiest way to manage it. Paul, Tero? Also, I'm wondering why we still have .clk and .opt_clks entries in the hwmod data for am43xx and omap5 which are both device tree based with all the clocks coming from .dts files? I think they are needed for the omap_device/hwmod stuff to work. Only omapdss driver knows about the clocks defined in the .dts files, and the omap_device/hwmod code still needs to do the reset and maybe some other tasks that require the clocks. Tomi signature.asc Description: OpenPGP digital signature
Re: [PATCH 00/11] ARM: OMAP: OMAP5 AM43x DSS
* Tomi Valkeinen tomi.valkei...@ti.com [140512 07:58]: On 12/05/14 17:36, Tony Lindgren wrote: * Tomi Valkeinen tomi.valkei...@ti.com [140512 06:26]: Hi Tony, On 09/05/14 14:56, Tomi Valkeinen wrote: Hi, Here are arch/arm/ patches to add display support for OMAP5 and AM43x. I have these in my tree, in a branch I will send to Tony for merging. Most of these patches have already been around the lists, but I wanted to send them one more time to verify that all looks right and everybody is fine with them. I have pushed these to: git://git.kernel.org/pub/scm/linux/kernel/git/tomba/linux.git 3.16/omap If you're fine with these, I think we can consider that branch stable. There are probably still a few display related .dts changed for the board coming up, but I'll add those on top of the current commits. Please coordinate things with Paul and Tero so you at least have proper acks for the hwmod and and clock patches. In general we really want to queue hwmod and clock changes separately as those can easily mess up things in a bad way like we've already seen with overlapping hwmod entries in the .dts files. Ok. I'm fine with splitting the series if that's easiest way to manage it. Paul, Tero? Also, I'm wondering why we still have .clk and .opt_clks entries in the hwmod data for am43xx and omap5 which are both device tree based with all the clocks coming from .dts files? I think they are needed for the omap_device/hwmod stuff to work. Only omapdss driver knows about the clocks defined in the .dts files, and the omap_device/hwmod code still needs to do the reset and maybe some other tasks that require the clocks. We're already populating the hwmod data from dts entries, that's done by omap_device_build_from_dt. Why aren't we doing that for dt defined clocks? I'd rather not start adding new data that will then just be removed, that's what people call pointless extra churn. Regards, Tony -- To unsubscribe from this list: send the line unsubscribe linux-omap in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
[PATCH 00/11] ARM: OMAP: OMAP5 AM43x DSS
Hi, Here are arch/arm/ patches to add display support for OMAP5 and AM43x. I have these in my tree, in a branch I will send to Tony for merging. Most of these patches have already been around the lists, but I wanted to send them one more time to verify that all looks right and everybody is fine with them. Tomi Archit Taneja (1): ARM: OMAP2+: hwmod: OMAP5 DSS hwmod data Sathya Prakash M R (4): ARM: AM43xx: hwmod: add DSS hwmod data ARM: dts: am43xx: add ti,set-rate-parent for disp_clk ARM: dts: am4372.dtsi: add DSS information ARM: dts: am437x-gp-evm: add LCD data Tomi Valkeinen (6): ARM: dts: am43x-epos-evm: add LCD data ARM: dts: omap5-clocks.dtsi: add dss iclk ARM: dts: omap5-clocks.dtsi: add ti,set-rate-parent to dss_dss_clk ARM: dts: omap5.dtsi: add DSS nodes ARM: dts: omap5-uevm.dts: add tca6424a ARM: dts: omap5-uevm.dts: add display nodes arch/arm/boot/dts/am4372.dtsi | 30 +++ arch/arm/boot/dts/am437x-gp-evm.dts| 97 ++ arch/arm/boot/dts/am43x-epos-evm.dts | 101 ++ arch/arm/boot/dts/am43xx-clocks.dtsi | 1 + arch/arm/boot/dts/omap5-uevm.dts | 89 + arch/arm/boot/dts/omap5.dtsi | 70 +++ arch/arm/boot/dts/omap54xx-clocks.dtsi | 9 + arch/arm/mach-omap2/omap_hwmod_43xx_data.c | 104 +++ arch/arm/mach-omap2/omap_hwmod_54xx_data.c | 283 + arch/arm/mach-omap2/prcm43xx.h | 1 + 10 files changed, 785 insertions(+) -- 1.9.1 -- To unsubscribe from this list: send the line unsubscribe linux-omap in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
