Re: [PATCH 01/11] mmc: omap: fix error return code

2015-08-25 Thread Ulf Hansson
On 23 August 2015 at 02:11, Julia Lawall julia.law...@lip6.fr wrote: Return a negative error code on failure. A simplified version of the semantic match that finds this problem is as follows: (http://coccinelle.lip6.fr/) // smpl @@ identifier ret; expression e1,e2; @@ ( if (\(ret

[PATCH 01/11] mmc: omap: fix error return code

2015-08-22 Thread Julia Lawall
Return a negative error code on failure. A simplified version of the semantic match that finds this problem is as follows: (http://coccinelle.lip6.fr/) // smpl @@ identifier ret; expression e1,e2; @@ ( if (\(ret 0\|ret != 0\)) { ... return ret; } | ret = 0 ) ... when != ret = e1 when !=