Re: [PATCH v2 1/2] omap3 nand: cleanup for not to use GPMC virtual address

2010-05-17 Thread Vimal Singh
On Mon, May 17, 2010 at 9:52 AM, Ghorai, Sukumar s-gho...@ti.com wrote: [...] @@ -108,11 +108,27 @@ static u32 gpmc_read_reg(int idx)        return __raw_readl(gpmc_base + idx);  } +static void gpmc_cs_write_byte(int cs, int idx, u8 val) +{ +       void __iomem *reg_addr; + +    

RE: [PATCH v2 1/2] omap3 nand: cleanup for not to use GPMC virtual address

2010-05-17 Thread Ghorai, Sukumar
-Original Message- From: Vimal Singh [mailto:vimal.neww...@gmail.com] Sent: 2010-05-17 19:57 To: Ghorai, Sukumar Cc: linux-omap@vger.kernel.org; artem.bityuts...@nokia.com; t...@atomide.com; sako...@gmail.com; linux-...@lists.infradead.org Subject: Re: [PATCH v2 1/2] omap3 nand

RE: [PATCH v2 1/2] omap3 nand: cleanup for not to use GPMC virtual address

2010-05-16 Thread Ghorai, Sukumar
nand: cleanup for not to use GPMC virtual address On Fri, May 14, 2010 at 8:53 PM, Sukumar Ghorai s-gho...@ti.com wrote: [...] diff --git a/arch/arm/mach-omap2/gpmc-onenand.c b/arch/arm/mach- omap2/gpmc-onenand.c index 7bb6922..5d66817 --- a/arch/arm/mach-omap2/gpmc-onenand.c +++ b/arch

RE: [PATCH v2 1/2] omap3 nand: cleanup for not to use GPMC virtual address

2010-05-16 Thread Ghorai, Sukumar
Tony, -Original Message- From: Tony Lindgren [mailto:t...@atomide.com] Sent: 2010-05-15 05:29 To: Ghorai, Sukumar Cc: linux-omap@vger.kernel.org; linux-...@lists.infradead.org; sako...@gmail.com; m...@compulab.co.il; artem.bityuts...@nokia.com Subject: Re: [PATCH v2 1/2] omap3 nand

[PATCH v2 1/2] omap3 nand: cleanup for not to use GPMC virtual address

2010-05-14 Thread Sukumar Ghorai
Necessary function added in GPMC module and used by nand driver. This is for not to use GPMC address directly from nand driver. Also it was passing GPMC base address from board files and that is removed. Signed-off-by: Sukumar Ghorai s-gho...@ti.com --- arch/arm/mach-omap2/board-cm-t35.c

Re: [PATCH v2 1/2] omap3 nand: cleanup for not to use GPMC virtual address

2010-05-14 Thread Tony Lindgren
* Sukumar Ghorai s-gho...@ti.com [100514 08:18]: Necessary function added in GPMC module and used by nand driver. This is for not to use GPMC address directly from nand driver. Also it was passing GPMC base address from board files and that is removed. Great, this is starting to look good!

Re: [PATCH v2 1/2] omap3 nand: cleanup for not to use GPMC virtual address

2010-05-14 Thread Vimal Singh
On Fri, May 14, 2010 at 8:53 PM, Sukumar Ghorai s-gho...@ti.com wrote: [...] diff --git a/arch/arm/mach-omap2/gpmc-onenand.c b/arch/arm/mach-omap2/gpmc-onenand.c index 7bb6922..5d66817 --- a/arch/arm/mach-omap2/gpmc-onenand.c +++ b/arch/arm/mach-omap2/gpmc-onenand.c @@ -301,7 +301,7 @@