RE: [PATCH v4 1/3] omap3 gpmc: functionality enhancement

2010-05-28 Thread Ghorai, Sukumar
-Original Message- From: linux-omap-ow...@vger.kernel.org [mailto:linux-omap- ow...@vger.kernel.org] On Behalf Of Vimal Singh Sent: Thursday, May 27, 2010 11:56 PM To: Ghorai, Sukumar Cc: linux-omap@vger.kernel.org Subject: Re: [PATCH v4 1/3] omap3 gpmc: functionality enhancement

Re: [PATCH v4 1/3] omap3 gpmc: functionality enhancement

2010-05-28 Thread Vimal Singh
@vger.kernel.org Subject: Re: [PATCH v4 1/3] omap3 gpmc: functionality enhancement On Thu, May 27, 2010 at 6:54 PM, Sukumar Ghorai s-gho...@ti.com wrote: [...] -static unsigned                gpmc_cs_map; +static unsigned        int gpmc_cs_map;        /* flag for cs which are initialized */ Tab

RE: [PATCH v4 1/3] omap3 gpmc: functionality enhancement

2010-05-28 Thread Ghorai, Sukumar
-Original Message- From: Vimal Singh [mailto:vimal.neww...@gmail.com] Sent: Friday, May 28, 2010 9:14 PM To: Ghorai, Sukumar Cc: linux-omap@vger.kernel.org Subject: Re: [PATCH v4 1/3] omap3 gpmc: functionality enhancement On Fri, May 28, 2010 at 12:03 PM, Ghorai, Sukumar s-gho

Re: [PATCH v4 1/3] omap3 gpmc: functionality enhancement

2010-05-28 Thread Vimal Singh
: linux-omap@vger.kernel.org Subject: Re: [PATCH v4 1/3] omap3 gpmc: functionality enhancement On Thu, May 27, 2010 at 6:54 PM, Sukumar Ghorai s-gho...@ti.com wrote: [...] -static unsigned                gpmc_cs_map; +static unsigned        int gpmc_cs_map;        /* flag for cs which

RE: [PATCH v4 1/3] omap3 gpmc: functionality enhancement

2010-05-28 Thread Ghorai, Sukumar
-Original Message- From: Vimal Singh [mailto:vimal.neww...@gmail.com] Sent: Saturday, May 29, 2010 12:20 AM To: Ghorai, Sukumar Cc: linux-omap@vger.kernel.org Subject: Re: [PATCH v4 1/3] omap3 gpmc: functionality enhancement On Fri, May 28, 2010 at 11:50 PM, Ghorai, Sukumar s

[PATCH v4 1/3] omap3 gpmc: functionality enhancement

2010-05-27 Thread Sukumar Ghorai
few functions added in gpmc module and to be used by other drivers like NAND. E.g.: - ioctl function - ecc functions Signed-off-by: Sukumar Ghorai s-gho...@ti.com --- arch/arm/mach-omap2/gpmc.c | 219 ++-- arch/arm/plat-omap/include/plat/gpmc.h |

Re: [PATCH v4 1/3] omap3 gpmc: functionality enhancement

2010-05-27 Thread Vimal Singh
On Thu, May 27, 2010 at 6:54 PM, Sukumar Ghorai s-gho...@ti.com wrote: [...] -static unsigned                gpmc_cs_map; +static unsigned        int gpmc_cs_map;        /* flag for cs which are initialized */ Tab should be after 'int', not before. [...] @@ -456,13 +565,22 @@