Re: [PATCHv2 02/12] ARM: OMAP2+: hwmod code/data: fix 32K sync timer

2012-07-05 Thread Kevin Hilman
Paul Walmsley p...@pwsan.com writes: Hi Benoît On Wed, 4 Jul 2012, Benoit Cousson wrote: @@ -1141,8 +1144,16 @@ static void _enable_sysc(struct omap_hwmod *oh) sf = oh-class-sysc-sysc_flags; if (sf SYSC_HAS_SIDLEMODE) { - idlemode = (oh-flags HWMOD_SWSUP_SIDLE) ?

Re: [PATCHv2 02/12] ARM: OMAP2+: hwmod code/data: fix 32K sync timer

2012-07-04 Thread Paul Walmsley
On Wed, 4 Jul 2012, Paul Walmsley wrote: So the updated patch below uses a clockdomain data flag for this instead. Here's a version that's a little cleaner. No functional changes. - Paul From: Paul Walmsley p...@pwsan.com Date: Wed, 4 Jul 2012 05:22:53 -0600 Subject: [PATCH] ARM: OMAP2+:

Re: [PATCHv2 02/12] ARM: OMAP2+: hwmod code/data: fix 32K sync timer

2012-07-04 Thread Kevin Hilman
Paul Walmsley p...@pwsan.com writes: On Wed, 4 Jul 2012, Paul Walmsley wrote: So the updated patch below uses a clockdomain data flag for this instead. Here's a version that's a little cleaner. No functional changes. - Paul From: Paul Walmsley p...@pwsan.com Date: Wed, 4 Jul 2012

Re: [PATCHv2 02/12] ARM: OMAP2+: hwmod code/data: fix 32K sync timer

2012-07-04 Thread Paul Walmsley
On Wed, 4 Jul 2012, Kevin Hilman wrote: Tested-by: Kevin Hilman khil...@ti.com I confirm this version is now allowing CORE to hit retention during suspend. Thanks, want me to add your S-o-b also? - Paul -- To unsubscribe from this list: send the line unsubscribe linux-omap in the body of a

Re: [PATCHv2 02/12] ARM: OMAP2+: hwmod code/data: fix 32K sync timer

2012-07-04 Thread Benoit Cousson
Hi Paul, On 07/04/2012 02:48 PM, Paul Walmsley wrote: Hi Benoît, On Fri, 15 Jun 2012, Cousson, Benoit wrote: My point is simple, we should not add any new custom flag when all the information to detect such exception are already there in the current data and represent accurately what

Re: [PATCHv2 02/12] ARM: OMAP2+: hwmod code/data: fix 32K sync timer

2012-07-04 Thread Benoit Cousson
Hi Kevin, On 07/04/2012 04:27 PM, Kevin Hilman wrote: [...] Tested-by: Kevin Hilman khil...@ti.com I confirm this version is now allowing CORE to hit retention during suspend. Benoit, I hope this is OK with you. We need a fix for this in v3.5 since this is last core bug preventing

Re: [PATCHv2 02/12] ARM: OMAP2+: hwmod code/data: fix 32K sync timer

2012-07-04 Thread Tero Kristo
On Wed, 2012-07-04 at 18:14 +0200, Benoit Cousson wrote: Hi Kevin, On 07/04/2012 04:27 PM, Kevin Hilman wrote: [...] Tested-by: Kevin Hilman khil...@ti.com I confirm this version is now allowing CORE to hit retention during suspend. Benoit, I hope this is OK with you. We

Re: [PATCHv2 02/12] ARM: OMAP2+: hwmod code/data: fix 32K sync timer

2012-07-04 Thread Benoit Cousson
On 07/04/2012 06:41 PM, Tero Kristo wrote: On Wed, 2012-07-04 at 18:14 +0200, Benoit Cousson wrote: Hi Kevin, On 07/04/2012 04:27 PM, Kevin Hilman wrote: [...] Tested-by: Kevin Hilman khil...@ti.com I confirm this version is now allowing CORE to hit retention during suspend. Benoit, I

Re: [PATCHv2 02/12] ARM: OMAP2+: hwmod code/data: fix 32K sync timer

2012-07-04 Thread Benoit Cousson
Hi Paul, On 07/04/2012 02:53 PM, Paul Walmsley wrote: On Wed, 4 Jul 2012, Paul Walmsley wrote: So the updated patch below uses a clockdomain data flag for this instead. Here's a version that's a little cleaner. No functional changes. [...] @@ -1141,8 +1144,16 @@ static void

Re: [PATCHv2 02/12] ARM: OMAP2+: hwmod code/data: fix 32K sync timer

2012-07-04 Thread Paul Walmsley
Hi Benoît On Wed, 4 Jul 2012, Benoit Cousson wrote: @@ -1141,8 +1144,16 @@ static void _enable_sysc(struct omap_hwmod *oh) sf = oh-class-sysc-sysc_flags; if (sf SYSC_HAS_SIDLEMODE) { - idlemode = (oh-flags HWMOD_SWSUP_SIDLE) ? -

Re: [PATCHv2 02/12] ARM: OMAP2+: hwmod code/data: fix 32K sync timer

2012-07-04 Thread Paul Walmsley
On Wed, 4 Jul 2012, Benoit Cousson wrote: On 07/04/2012 06:41 PM, Tero Kristo wrote: On Wed, 2012-07-04 at 18:14 +0200, Benoit Cousson wrote: On OMAP4 as well? I've just tried with the hwmod fix for AESS and USB and still cannot reach RET. Am I missing some other patches for OMAP4?

Re: [PATCHv2 02/12] ARM: OMAP2+: hwmod code/data: fix 32K sync timer

2012-07-04 Thread Paul Walmsley
Hi Benoît On Wed, 4 Jul 2012, Benoit Cousson wrote: From: Paul Walmsley p...@pwsan.com Date: Wed, 4 Jul 2012 05:22:53 -0600 Subject: [PATCH] ARM: OMAP2+: hwmod code/clockdomain data: fix 32K sync timer [...] @@ -1208,8 +1219,13 @@ static void _idle_sysc(struct omap_hwmod *oh)

Re: [PATCHv2 02/12] ARM: OMAP2+: hwmod code/data: fix 32K sync timer

2012-06-15 Thread Cousson, Benoit
Hi Paul, On 6/15/2012 2:18 AM, Paul Walmsley wrote: On Thu, 14 Jun 2012, Cousson, Benoit wrote: On 6/14/2012 8:04 PM, Paul Walmsley wrote: On Thu, 14 Jun 2012, Cousson, Benoit wrote: (attribution lost) Furthermore, the PRCM will never request target idle for this IP block while the

Re: [PATCHv2 02/12] ARM: OMAP2+: hwmod code/data: fix 32K sync timer

2012-06-14 Thread Cousson, Benoit
Hi Paul, On 6/11/2012 2:45 AM, Paul Walmsley wrote: Kuvin discovered that commit c8d82ff68fb6873691536cf33021977efbf5593c I guess you meant Kevin? (ARM: OMAP2/3: hwmod data: Add 32k-sync timer data to hwmod database) broke CORE idle on OMAP3. This prevents device low power states. The

Re: [PATCHv2 02/12] ARM: OMAP2+: hwmod code/data: fix 32K sync timer

2012-06-14 Thread Paul Walmsley
Hi On Thu, 14 Jun 2012, Cousson, Benoit wrote: On 6/11/2012 2:45 AM, Paul Walmsley wrote: Kuvin discovered that commit c8d82ff68fb6873691536cf33021977efbf5593c I guess you meant Kevin? ... The IP block itself pbobably does not have any native idle typo Thanks for noticing these,

Re: [PATCHv2 02/12] ARM: OMAP2+: hwmod code/data: fix 32K sync timer

2012-06-14 Thread Cousson, Benoit
On 6/14/2012 8:04 PM, Paul Walmsley wrote: Hi On Thu, 14 Jun 2012, Cousson, Benoit wrote: On 6/11/2012 2:45 AM, Paul Walmsley wrote: Kuvin discovered that commit c8d82ff68fb6873691536cf33021977efbf5593c I guess you meant Kevin? ... The IP block itself pbobably does not have any native

Re: [PATCHv2 02/12] ARM: OMAP2+: hwmod code/data: fix 32K sync timer

2012-06-14 Thread Paul Walmsley
On Thu, 14 Jun 2012, Cousson, Benoit wrote: On 6/14/2012 8:04 PM, Paul Walmsley wrote: On Thu, 14 Jun 2012, Cousson, Benoit wrote: (attribution lost) Furthermore, the PRCM will never request target idle for this IP block while the kernel is running, due to the sleep dependency that

[PATCHv2 02/12] ARM: OMAP2+: hwmod code/data: fix 32K sync timer

2012-06-10 Thread Paul Walmsley
Kevin discovered that commit c8d82ff68fb6873691536cf33021977efbf5593c (ARM: OMAP2/3: hwmod data: Add 32k-sync timer data to hwmod database) broke CORE idle on OMAP3. This prevents device low power states. The root cause is that the 32K sync timer IP block does not support smart-idle mode[1], and