Re: [PATCHv4 0/2] McBSP: OMAP3: Add sidetone feature

2010-02-19 Thread Peter Ujfalusi
On Thursday 18 February 2010 22:22:29 ext Jarkko Nikula wrote: I still have two concern: 1. port number vs. index difference inside driver code is not enough It's just confusing if a machine driver and internal API (mcbsp.c) has to use different indexing. See:

Re: [PATCHv4 0/2] McBSP: OMAP3: Add sidetone feature

2010-02-19 Thread Ilkka Koskinen
On Thu, 18 Feb 2010, ext Jarkko Nikula wrote: On Thu, 18 Feb 2010 20:42:27 +0200 Ilkka Koskinen ilkka.koski...@nokia.com wrote: The first patch implements McBSP sidetone feature on OMAP3 while the second one provides ALSA interface for using it. The patch set is based on the patch Eduardo

Re: [PATCHv4 0/2] McBSP: OMAP3: Add sidetone feature

2010-02-19 Thread Jarkko Nikula
On Fri, 19 Feb 2010 10:34:32 +0200 Peter Ujfalusi peter.ujfal...@nokia.com wrote: I'm not sure, but you might need to configure the taps as well to have the correct sidetone. Also I have a recollection, that the McBSP sidetone requires DSP mode (TDM) in order to operate correctly, so on

Re: [PATCHv4 0/2] McBSP: OMAP3: Add sidetone feature

2010-02-19 Thread Jarkko Nikula
On Fri, 19 Feb 2010 12:05:40 +0200 (EET) Ilkka Koskinen ikosk...@nokia.com wrote: 2. I cannot change the sidetone level with alsamixer I think with the previous patch set, it was impossible to set the other channel's gain as Peter pointed out. But at least now that I try, i can change it

Re: [PATCHv4 0/2] McBSP: OMAP3: Add sidetone feature

2010-02-19 Thread Jarkko Nikula
On Fri, 19 Feb 2010 15:37:17 +0200 Eero Nurkkala ext-eero.nurkk...@nokia.com wrote: It seems to work with I2S too. For both channels? I don't recall so.. and for the one channel only, the FIR doesn't behave expectedly? (maybe this works [1,0,..0], but more sophisticated ones may not..)

[PATCHv4 0/2] McBSP: OMAP3: Add sidetone feature

2010-02-18 Thread Ilkka Koskinen
The first patch implements McBSP sidetone feature on OMAP3 while the second one provides ALSA interface for using it. The patch set is based on the patch Eduardo Valentin sent to alsa-devel mailing list in October 2009. Channel gain control and enabling the sidetone have been moved to ALSA

Re: [PATCHv4 0/2] McBSP: OMAP3: Add sidetone feature

2010-02-18 Thread Jarkko Nikula
On Thu, 18 Feb 2010 20:42:27 +0200 Ilkka Koskinen ilkka.koski...@nokia.com wrote: The first patch implements McBSP sidetone feature on OMAP3 while the second one provides ALSA interface for using it. The patch set is based on the patch Eduardo Valentin sent to alsa-devel mailing list in