Re: [PATCH 2/2] omap3: sr: improve errors handling

2010-07-12 Thread Artem Bityutskiy
On Fri, 2010-07-09 at 16:20 +0300, Artem Bityutskiy wrote: From: Artem Bityutskiy artem.bityuts...@nokia.com Do not forget to check the 'platform_device_add_data()' error code in 'omap_device_build_ss()'. Signed-off-by: Artem Bityutskiy artem.bityuts...@nokia.com Please, discard this

Re: [PATCH 2/2] omap3: sr: improve errors handling

2010-07-09 Thread Nishanth Menon
Artem Bityutskiy had written, on 07/09/2010 08:20 AM, the following: From: Artem Bityutskiy artem.bityuts...@nokia.com Do not forget to check the 'platform_device_add_data()' error code in 'omap_device_build_ss()'. Signed-off-by: Artem Bityutskiy artem.bityuts...@nokia.com Acked-by: Nishanth

RE: [PATCH 2/2] omap3: sr: improve errors handling

2010-07-09 Thread Artem Bityutskiy
On Fri, 2010-07-09 at 20:35 +0530, Gopinath, Thara wrote: -Original Message- From: Artem Bityutskiy [mailto:dedeki...@gmail.com] Sent: Friday, July 09, 2010 6:50 PM To: linux-omap@vger.kernel.org Cc: Menon, Nishanth; Kevin Hilman; Gopinath, Thara; Peter p2 De Schrijver Subject:

Re: [PATCH 2/2] omap3: sr: improve errors handling

2010-07-09 Thread Nishanth Menon
Artem Bityutskiy had written, on 07/09/2010 10:44 AM, the following: On Fri, 2010-07-09 at 20:35 +0530, Gopinath, Thara wrote: -Original Message- From: Artem Bityutskiy [mailto:dedeki...@gmail.com] Sent: Friday, July 09, 2010 6:50 PM To: linux-omap@vger.kernel.org Cc: Menon, Nishanth;

Re: [PATCH 2/2] omap3: sr: improve errors handling

2010-07-09 Thread Artem Bityutskiy
On Fri, 2010-07-09 at 10:51 -0500, Nishanth Menon wrote: So the logic is: 1. The subject line is a short description which gives the idea what the commit is about. So, my subject line says: 1.1. It is about omap3 (which is true) 1.2. It is about sr (which is true) I think Thara's

RE: [PATCH 2/2] omap3: sr: improve errors handling

2010-07-09 Thread Menon, Nishanth
-Original Message- From: Artem Bityutskiy [mailto:dedeki...@gmail.com] Sent: Friday, July 09, 2010 10:51 AM On Fri, 2010-07-09 at 10:51 -0500, Nishanth Menon wrote: So the logic is: 1. The subject line is a short description which gives the idea what the commit is about.

RE: [PATCH 2/2] omap3: sr: improve errors handling

2010-07-09 Thread Artem Bityutskiy
On Fri, 2010-07-09 at 11:00 -0500, Menon, Nishanth wrote: -Original Message- From: Artem Bityutskiy [mailto:dedeki...@gmail.com] Sent: Friday, July 09, 2010 10:51 AM On Fri, 2010-07-09 at 10:51 -0500, Nishanth Menon wrote: So the logic is: 1. The subject line is a