, there is mmc_set_clock() method, but it isn't exported. Anyway,
I have another issue with some specific code which also requires the
same function to be exported.
--
With Best Regards,
Andy Shevchenko
--
To unsubscribe from this list: send the line unsubscribe linux-omap in
the body of a message to majord
to test:
(chnlId = CHNL_MAXCHANNELS || chnlld 0)
--
With Best Regards,
Andy Shevchenko
--
To unsubscribe from this list: send the line unsubscribe linux-omap in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
From: Andy Shevchenko ext-andriy.shevche...@nokia.com
Remove useless macroses. They were doing nothing, so it's clear to just get rid
of them.
Signed-off-by: Andy Shevchenko ext-andriy.shevche...@nokia.com
---
arch/arm/plat-omap/include/dspbridge/memdefs.h |3 ---
drivers/dsp/bridge/wmd
From: Andy Shevchenko ext-andriy.shevche...@nokia.com
Try to use simple_strtol() kernel native method instead.
However, there are opened questions:
- why type of Atoi() is s32 if the sign is used only to detect base?
- should we really to check hex integers like DEAD0123h?
- how many spaces
I miss?
--
With Best Regards,
Andy Shevchenko
--
To unsubscribe from this list: send the line unsubscribe linux-omap in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
?
This is the question about l vs ul.
+ } else if (*pch (pch[strlen(pch) - 1] | 0x20 == 'h')) {
perhaps tolower(x)
Yep, I saw only internal macro in lib/vsprintf.c, but totally forgot
about ctype.h.
--
With Best Regards,
Andy Shevchenko
--
To unsubscribe from this list: send the line
From: Andy Shevchenko ext-andriy.shevche...@nokia.com
Try to use simple_strtoul() kernel native method instead.
However, there are opened questions:
- why type of Atoi() is s32 if the sign is used only to detect base?
- should we really to check hex integers like DEAD0123h?
- how many spaces
* types not a
reason to bring some useless patches.
Look:
[a...@localhost linux-2.6]$ git grep -n -w u32 | wc
76327 388062 5253203
I guess you don't need further exlanations here.
--
With Best Regards,
Andy Shevchenko
--
To unsubscribe from this list: send the line unsubscribe linux-omap
such as gumstix.
--
With Best Regards,
Andy Shevchenko
--
To unsubscribe from this list: send the line unsubscribe linux-omap in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
).
--
With Best Regards,
Andy Shevchenko
--
To unsubscribe from this list: send the line unsubscribe linux-omap in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
,
Andy Shevchenko
--
To unsubscribe from this list: send the line unsubscribe linux-omap in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
On Wed, Jun 23, 2010 at 4:02 PM, Ohad Ben-Cohen o...@wizery.com wrote:
Add TI's DSP Bridge generic utilities driver sources
Signed-off-by: Andy Shevchenko ext-andriy.shevche...@nokia.com
+++ b/drivers/staging/tidspbridge/gen/uuidutil.c
Following part could be significantly simplified
There is recently added hex_to_bin() kernel's method which we could use
instead of custom long function.
Signed-off-by: Andy Shevchenko andy.shevche...@gmail.com
Cc: Ohad Ben-Cohen o...@wizery.com
Cc: Greg Kroah-Hartman gre...@suse.de
Cc: linux-omap@vger.kernel.org
---
drivers/staging
++);
--
1.6.3.3
--
With Best Regards,
Andy Shevchenko
--
To unsubscribe from this list: send the line unsubscribe linux-omap in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
opened questions about
http://dev.omapzoom.org/?p=tidspbridge/kernel-dspbridge.git;a=commit;h=b8af1123b47741086ef5a307ad1ec8fec6fc7f0d
--
With Best Regards,
Andy Shevchenko
--
To unsubscribe from this list: send the line unsubscribe linux-omap in
the body of a message to majord...@vger.kernel.org
;
}
- return simple_strtoul(pch, NULL, base);
+ ret_val = strict_strtoul(pch, base, res);
+
+ return ret_val ? : res;
May be better to use explicit values in condition?
--
With Best Regards,
Andy Shevchenko
--
To unsubscribe from this list: send the line unsubscribe linux-omap in
the body
From: Andy Shevchenko ext-andriy.shevche...@nokia.com
strcmp() should do the job without additional memory allocation and
strncpy()/strcmp() calls.
Additionally fix spelling.
Signed-off-by: Andy Shevchenko ext-andriy.shevche...@nokia.com
---
drivers/dsp/bridge/rmgr/node.c | 15
From: Andy Shevchenko ext-andriy.shevche...@nokia.com
Check input value before dereferencing it.
Signed-off-by: Andy Shevchenko ext-andriy.shevche...@nokia.com
---
drivers/dsp/bridge/wmd/tiomap3430.c |7 ++-
1 files changed, 6 insertions(+), 1 deletions(-)
diff --git a/drivers/dsp
From: Andy Shevchenko ext-andriy.shevche...@nokia.com
Signed-off-by: Andy Shevchenko ext-andriy.shevche...@nokia.com
---
drivers/dsp/bridge/rmgr/nldr.c | 15 ++-
1 files changed, 14 insertions(+), 1 deletions(-)
diff --git a/drivers/dsp/bridge/rmgr/nldr.c b/drivers/dsp/bridge/rmgr
From: Andy Shevchenko ext-andriy.shevche...@nokia.com
Before this check zlLib already dereferenced on one hand and DBC_Require()
checks for NULL on other hand.
Signed-off-by: Andy Shevchenko ext-andriy.shevche...@nokia.com
---
drivers/dsp/bridge/pmgr/dbll.c | 34
From: Andy Shevchenko ext-andriy.shevche...@nokia.com
Signed-off-by: Andy Shevchenko ext-andriy.shevche...@nokia.com
---
drivers/dsp/bridge/rmgr/drv.c |4
1 files changed, 4 insertions(+), 0 deletions(-)
diff --git a/drivers/dsp/bridge/rmgr/drv.c b/drivers/dsp/bridge/rmgr/drv.c
index
);
+
+err2:
+ unregister_chrdev_region(dev, 1);
+
+err1:
+ return result;
}
/* This function is invoked during unlinking of the bridge module from the
--
With Best Regards,
Andy Shevchenko
do you
think?
As far as I see this is not the dsp status but just a word to collect
errors. More logical in this piece of your code is to use result word
instead of status.
--
With Best Regards,
Andy Shevchenko
--
To unsubscribe from this list: send the line unsubscribe linux-omap in
the body
From: Andy Shevchenko ext-andriy.shevche...@nokia.com
Theoretically list could be deleted before we go into the for loop.
Additionally we could delete list immediately if it becomes empty.
Signed-off-by: Andy Shevchenko ext-andriy.shevche...@nokia.com
---
drivers/dsp/bridge/rmgr/drv.c |9
From: Andy Shevchenko ext-andriy.shevche...@nokia.com
Check list pointer at every itteration because it could be deleted before we go
into the for loop.
Reworked version of the previous attempts.
Signed-off-by: Andy Shevchenko ext-andriy.shevche...@nokia.com
---
drivers/dsp/bridge/rmgr/drv.c
From: Andy Shevchenko ext-andriy.shevche...@nokia.com
- Remove LST_Init() and LST_Exit() calls because they are doing nothing except
tracing, Thus, remove tracing as well.
- Remove DBC_* calls. It's internal kernel business whether to have those
assertions.
- Switch to list_head structure
From: Andy Shevchenko ext-andriy.shevche...@nokia.com
* Use native list_empty() method instead of LST_IsEmpty() inside list.c. Remove
extra local variables.
* Move methods from list.c as inline functions in the list.h. Get rid of list.c
at all.
* Use list_head natively instead of LST_ELEM
From: Andy Shevchenko ext-andriy.shevche...@nokia.com
* Remove LST_Init() and LST_Exit() calls because they are doing nothing except
tracing, Thus, remove tracing as well.
* Remove DBC_* calls. It's internal kernel business whether to have those
assertions.
* Switch to list_head structure
,
Andy Shevchenko
--
To unsubscribe from this list: send the line unsubscribe linux-omap in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
From: Andy Shevchenko ext-andriy.shevche...@nokia.com
Instead of MEM_Calloc()/MEM_Free() use kzalloc()/kfree() calls. Thus we get rid
of mem.h dependency.
Signed-off-by: Andy Shevchenko ext-andriy.shevche...@nokia.com
---
arch/arm/plat-omap/include/dspbridge/list.h | 11 ++-
1 files
From: Andy Shevchenko ext-andriy.shevche...@nokia.com
Instead of MEM_Calloc()/MEM_Free() use kzalloc()/kfree() calls. Thus we get rid
of mem.h dependency.
Signed-off-by: Andy Shevchenko ext-andriy.shevche...@nokia.com
---
arch/arm/plat-omap/include/dspbridge/list.h | 11 ++-
1 files
From: Andy Shevchenko ext-andriy.shevche...@nokia.com
* Use native list_empty() method instead of LST_IsEmpty() inside list.c. Remove
extra local variables.
* Move methods from list.c as inline functions in the list.h. Get rid of list.c
at all.
* Use list_head natively instead of LST_ELEM
list_head in
whole dsp bridge driver.
--
With Best Regards,
Andy Shevchenko
--
To unsubscribe from this list: send the line unsubscribe linux-omap in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
From: Andy Shevchenko ext-andriy.shevche...@nokia.com
Instead of MEM_Calloc()/MEM_Free() use kzalloc()/kfree() calls. Thus we get rid
of mem.h dependency.
Signed-off-by: Andy Shevchenko ext-andriy.shevche...@nokia.com
---
arch/arm/plat-omap/include/dspbridge/list.h | 10 +-
1 files
From: Andy Shevchenko ext-andriy.shevche...@nokia.com
* Remove LST_Init() and LST_Exit() calls because they are doing nothing except
tracing, Thus, remove tracing as well.
* Remove DBC_* calls. It's internal kernel business whether to have those
assertions.
* Switch to list_head structure
From: Andy Shevchenko ext-andriy.shevche...@nokia.com
* Change struct LST_ELEM to struct list_head in whole dsp bridge driver
* Remove useless commentaries
* Minor change in the services/mem.c:
...
struct list_head *last = mMan.lst.head;
struct list_head *curr = last-next
On Thu, Sep 3, 2009 at 12:17 PM, Artem Bityutskiydedeki...@gmail.com wrote:
On Thu, 2009-09-03 at 12:06 +0300, Andy Shevchenko wrote:
@@ -590,7 +589,7 @@ DSP_STATUS CMM_GetInfo(struct CMM_OBJECT *hCmmMgr,
/* next node. */
pCurNode
On Thu, Sep 3, 2009 at 12:31 PM, Andy
Shevchenkoandy.shevche...@gmail.com wrote:
On Thu, Sep 3, 2009 at 12:17 PM, Artem Bityutskiydedeki...@gmail.com wrote:
On Thu, 2009-09-03 at 12:06 +0300, Andy Shevchenko wrote:
@@ -590,7 +589,7 @@ DSP_STATUS CMM_GetInfo(struct CMM_OBJECT *hCmmMgr
From: Andy Shevchenko ext-andriy.shevche...@nokia.com
* Change struct LST_ELEM to struct list_head in whole dsp bridge driver
* Remove useless commentaries
* Minor change in the services/mem.c:
...
struct list_head *last = mMan.lst.head;
struct list_head *curr = last-next
From: Andy Shevchenko ext-andriy.shevche...@nokia.com
I doubt about usefulness of removed piece of code. But it seems to be not used
because of unchanged value of bJustWokeDSP.
Signed-off-by: Andy Shevchenko ext-andriy.shevche...@nokia.com
---
drivers/dsp/bridge/rmgr/node.c | 17
From: Andy Shevchenko ext-andriy.shevche...@nokia.com
Instead of MEM_Calloc()/MEM_Free() use kzalloc()/kfree() calls. Thus we get rid
of mem.h dependency.
Signed-off-by: Andy Shevchenko ext-andriy.shevche...@nokia.com
---
arch/arm/plat-omap/include/dspbridge/list.h | 11 +--
1 files
From: Andy Shevchenko ext-andriy.shevche...@nokia.com
* Use native list_empty() method instead of LST_IsEmpty() inside list.c. Remove
extra local variables.
* Move methods from list.c as inline functions in the list.h. Get rid of list.c
at all.
* Use list_head natively instead of LST_ELEM
to native list_head in
whole dsp bridge driver.
All patches are rebased against android-bridge-2.6.29 kernel branch of the
kernel-dspbridge repository.
--
With Best Regards,
Andy Shevchenko
--
To unsubscribe from this list: send the line unsubscribe linux-omap in
the body of a message to majord
From: Andy Shevchenko ext-andriy.shevche...@nokia.com
* Change struct LST_ELEM to struct list_head in whole dsp bridge driver
* Remove useless commentaries
* Minor change in the services/mem.c:
...
struct list_head *last = mMan.lst.head;
struct list_head *curr = last-next
will look into. But probably this mean to revert back to
MEM_* calls when we would like to create or destroy list head...
--
With Best Regards,
Andy Shevchenko
--
To unsubscribe from this list: send the line unsubscribe linux-omap in
the body of a message to majord...@vger.kernel.org
More majordomo info
From: Andy Shevchenko ext-andriy.shevche...@nokia.com
Signed-off-by: Andy Shevchenko ext-andriy.shevche...@nokia.com
---
drivers/dsp/bridge/rmgr/proc.c |1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/drivers/dsp/bridge/rmgr/proc.c b/drivers/dsp/bridge/rmgr/proc.c
index
-2.6.29 kernel branch of the
kernel-dspbridge repository.
Please, review them. Thank you.
--
With Best Regards,
Andy Shevchenko
--
To unsubscribe from this list: send the line unsubscribe linux-omap in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org
From: Andy Shevchenko ext-andriy.shevche...@nokia.com
Change LST_Create() to the MEM_Calloc() and INIT_LIST_HEAD() pair in optimal
way.
Use MEM_Free() instead of LST_Delete(). We can use it without checking because
MEM_Free() validates input parameter.
Signed-off-by: Andy Shevchenko ext
From: Andy Shevchenko ext-andriy.shevche...@nokia.com
* Change struct LST_ELEM to struct list_head in whole dsp bridge driver
* Remove useless commentaries
* Minor change in the services/mem.c:
...
struct list_head *last = mMan.lst.head;
struct list_head *curr = last-next
From: Andy Shevchenko ext-andriy.shevche...@nokia.com
Current DSP bridge driver still contains redudant pieces of CSL code. Get rid
of it finally.
Signed-off-by: Andy Shevchenko ext-andriy.shevche...@nokia.com
---
arch/arm/plat-omap/include/dspbridge/csl.h | 135 --
drivers
From: Andy Shevchenko ext-andriy.shevche...@nokia.com
* Remove LST_Init() and LST_Exit() calls because they are doing nothing except
tracing, Thus, remove tracing as well.
* Remove DBC_* calls. It's internal kernel business whether to have those
assertions.
* Move methods from list.c
From: Andy Shevchenko ext-andriy.shevche...@nokia.com
Change LST_Create() to the MEM_Calloc() and INIT_LIST_HEAD() pair in optimal
way.
Use MEM_Free() instead of LST_Delete(). We can use it without checking because
MEM_Free() validates input parameter.
Signed-off-by: Andy Shevchenko ext
From: Andy Shevchenko ext-andriy.shevche...@nokia.com
Including the list.h in some files looks redundant. So, remove those lines.
Signed-off-by: Andy Shevchenko ext-andriy.shevche...@nokia.com
---
drivers/dsp/bridge/pmgr/chnl.c |1 -
drivers/dsp/bridge/pmgr/dmm.c |1
From: Andy Shevchenko ext-andriy.shevche...@nokia.com
Current DSP bridge driver still contains redudant pieces of CSL code. Get rid
of it finally.
Change atoi(s) to the kernel's simple_strtol(s, NULL, 10).
Signed-off-by: Andy Shevchenko ext-andriy.shevche...@nokia.com
---
arch/arm/plat-omap
Hello.
This version is slightly improved (I drop out atoi() wrapper).
--
With Best Regards,
Andy Shevchenko
--
To unsubscribe from this list: send the line unsubscribe linux-omap in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo
From: Andy Shevchenko ext-andriy.shevche...@nokia.com
Current DSP bridge driver still contains redudant pieces of CSL code. Get rid
of it finally.
Change CSL_atoi(s) to the kernel's simple_strtol(s, NULL, 10) in place.
Signed-off-by: Andy Shevchenko ext-andriy.shevche...@nokia.com
---
arch/arm
From: Andy Shevchenko ext-andriy.shevche...@nokia.com
* Remove KFILE_Init(), KFILE_Exit() and tracing stuff
* Simplify KFILE_Seek()
* Simplify error checker in KFILE_Open after filp_open() call
* Remove pid/tgid related code: it seems totally useless here
* Get rid of KFILE_FileObj, use regular
opensourced components are committed to the
linux-omap tree, but official kernels are provided from certain
repository.
Is there any how-to or update instruction I can follow?
Perhaps more useful to ask in maemo.org.
--
With Best Regards,
Andy Shevchenko
--
To unsubscribe from this list: send the line
sed -e s/\$token\/$new/g $TMPFILE1 $file
dos2unix actually one expression for sed, AFAIK.
And new sed versions (starting from 3.8?) have -i which means 'in place'.
P.S. And personally I prefer to use perl :-)
--
With Best Regards,
Andy Shevchenko
--
To unsubscribe from this list
From: Andy Shevchenko ext-andriy.shevche...@nokia.com
There are two patches which simplify registry API.
Andy Shevchenko (2):
DSPBRIDGE: OSAL: Simplify REG API
DSPBRIDGE: OSAL: Remove unused registry variables
arch/arm/plat-omap/include/dspbridge/dbreg.h |3 -
arch/arm/plat-omap
From: Andy Shevchenko ext-andriy.shevche...@nokia.com
Signed-off-by: Andy Shevchenko ext-andriy.shevche...@nokia.com
---
arch/arm/plat-omap/include/dspbridge/dbreg.h |3 ---
drivers/dsp/bridge/rmgr/drv_interface.c | 12
drivers/dsp/bridge/services/cfg.c|5
From: Andy Shevchenko ext-andriy.shevche...@nokia.com
Simplify REG API by removing useless input parameters.
Signed-off-by: Andy Shevchenko ext-andriy.shevche...@nokia.com
---
arch/arm/plat-omap/include/dspbridge/reg.h | 102
drivers/dsp/bridge/rmgr/dbdcd.c
From: Andy Shevchenko ext-andriy.shevche...@nokia.com
There are two patches which simplify registry API.
Andy Shevchenko (2):
DSPBRIDGE: OSAL: Simplify REG API
DSPBRIDGE: OSAL: Remove unused registry variables
arch/arm/plat-omap/include/dspbridge/dbreg.h |3 -
arch/arm/plat-omap
From: Andy Shevchenko ext-andriy.shevche...@nokia.com
* Clean up dbreg.h - there are plenty of unused definitions
* Move necessary constants to the dbdefs.h
* Remove dbreg.h inclusion from other files
Signed-off-by: Andy Shevchenko ext-andriy.shevche...@nokia.com
---
arch/arm/plat-omap/include
From: Andy Shevchenko ext-andriy.shevche...@nokia.com
There are several patches which simplify registry API and code.
Andy Shevchenko (5):
DSPBRIDGE: OSAL: Simplify REG API
DSPBRIDGE: OSAL: Remove unused registry variables
DSPBRIDGE: OSAL: Clean up dbreg.h and move it
DSPBRIDGE: OSAL
From: Andy Shevchenko ext-andriy.shevche...@nokia.com
Change implementation of registry to a linked list.
In future this will became to some static structures and probably list for
DCD_REGKEY array.
Signed-off-by: Andy Shevchenko ext-andriy.shevche...@nokia.com
---
drivers/dsp/bridge/services
From: Andy Shevchenko ext-andriy.shevche...@nokia.com
Simplify REG API by removing useless input parameters.
Signed-off-by: Andy Shevchenko ext-andriy.shevche...@nokia.com
---
arch/arm/plat-omap/include/dspbridge/reg.h | 102
drivers/dsp/bridge/rmgr/dbdcd.c
From: Andy Shevchenko ext-andriy.shevche...@nokia.com
Signed-off-by: Andy Shevchenko ext-andriy.shevche...@nokia.com
---
arch/arm/plat-omap/include/dspbridge/dbreg.h |3 ---
drivers/dsp/bridge/rmgr/drv_interface.c | 12
drivers/dsp/bridge/services/cfg.c|5
From: Andy Shevchenko ext-andriy.shevche...@nokia.com
Remove printS() debuggin method. It's mostly useless and at least dangerous
because of absence of boundary check.
Signed-off-by: Andy Shevchenko ext-andriy.shevche...@nokia.com
---
drivers/dsp/bridge/services/regsup.c | 23
From: Andy Shevchenko ext-andriy.shevche...@nokia.com
includecheck found few duplicates. So, clean up them.
Signed-off-by: Andy Shevchenko ext-andriy.shevche...@nokia.com
---
drivers/dsp/bridge/rmgr/disp.c |1 -
drivers/dsp/bridge/rmgr/drv_interface.c |1 -
drivers/dsp/bridge
On Wed, 2011-08-17 at 16:04 +0530, Deepthy Ravi wrote:
From: Vaibhav Hiremath hvaib...@ti.com
Defines the two functions only when CONFIG_MEDIA_CONTROLLER
is enabled.
Is it not a driver's option to be dependent on MEDIA_CONTROLLER?
--
Andy Shevchenko andriy.shevche...@linux.intel.com
Intel
, obviously.
--
Andy Shevchenko andriy.shevche...@linux.intel.com
Intel Finland Oy
--
To unsubscribe from this list: send the line unsubscribe linux-omap in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
On Fri, May 6, 2011 at 2:34 PM, Varadarajan, Charulatha ch...@ti.com wrote:
On Fri, May 6, 2011 at 14:44, Adrian Hunter adrian.hun...@nokia.com wrote:
From: Andy Shevchenko ext-andriy.shevche...@nokia.com
Add patch description here.
You mean something like following:
The code contains
The code contains the similarities in the error path of probe function. Let's
combine them at one place.
Signed-off-by: Andy Shevchenko ext-andriy.shevche...@nokia.com
Signed-off-by: Adrian Hunter adrian.hun...@nokia.com
---
drivers/mmc/host/omap_hsmmc.c | 17 ++---
1 files changed
There are two places where the same calculations are done. Let's split them to
separate function.
In addition the new function is simplified by usage DIV_ROUND_UP kernel macro.
Signed-off-by: Andy Shevchenko ext-andriy.shevche...@nokia.com
Signed-off-by: Adrian Hunter adrian.hun...@nokia.com
/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
--
With Best Regards,
Andy Shevchenko
--
To unsubscribe from this list: send the line unsubscribe linux-omap in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
--
With Best Regards,
Andy Shevchenko
--
To unsubscribe from this list: send the line unsubscribe linux-omap in
the body of a message to majord...@vger.kernel.org
More
On Wed, Jan 30, 2013 at 8:41 AM, Matt Porter mpor...@ti.com wrote:
On Mon, Jan 28, 2013 at 09:27:24PM +0200, Andy Shevchenko wrote:
On Tue, Jan 15, 2013 at 10:32 PM, Matt Porter mpor...@ti.com wrote:
Adds support for parsing the TI EDMA DT data into the required
EDMA private API platform
= ~(0xff shift);
+ mux |= xbar_chans[i][0] shift;
+ writel(mux, (void *)((u32)xbar + offset));
+ }
--
With Best Regards,
Andy Shevchenko
--
To unsubscribe from this list: send the line unsubscribe linux-omap in
the body of a message to majord
No go.
Check the 4b7e450fb5cefb5865c77999a675330206ab3b8a
And update you tree, please.
--
With Best Regards,
Andy Shevchenko
--
To unsubscribe from this list: send the line unsubscribe linux-omap in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org
;
u16 chan_count;
- struct omap_dma_lch *chan;
};
enum {
--
Andy Shevchenko andriy.shevche...@linux.intel.com
Intel Finland Oy
--
To unsubscribe from this list: send the line unsubscribe linux-omap in
the body of a message to majord...@vger.kernel.org
More majordomo info
,
+ OMAP_DMA_REG_32BIT,
+};
+
+struct omap_dma_reg {
+ u16 offset;
+ u8 stride;
+ u8 type;
+};
+
/* System DMA platform data structure */
struct omap_system_dma_plat_info {
struct omap_dma_dev_attr *dma_attr;
--
Andy Shevchenko andriy.shevche
version with all the
drivers converted.
JFYI: there is nice project called codespell [1].
[1] git://github.com/lucasdemarchi/codespell.git
--
Andy Shevchenko andriy.shevche...@linux.intel.com
Intel Finland Oy
--
To unsubscribe from this list: send the line unsubscribe linux-omap in
the body
think you may just incorporate that patch into your series.
--
Andy Shevchenko andriy.shevche...@intel.com
Intel Finland Oy
--
To unsubscribe from this list: send the line unsubscribe linux-omap in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org
On Wed, Nov 18, 2015 at 5:51 PM, Arnd Bergmann <a...@arndb.de> wrote:
> On Wednesday 18 November 2015 17:43:04 Andy Shevchenko wrote:
>> >
>> > I assume that the sst-firmware.c case is a mistake, it should just use a
>> > plain DMA_SLAVE and not DMA_MEMCPY.
>
torm which does nothing useful
(IIRC Russel's opinion).
On the other hand there are a lot of drivers that are used on the set
of platforms starting from legacy and abandoned ones (like AVR32) to
relatively new and newest.
And I'm not a fan of those thousands of API calls either.
--
With Bes
sure how valid are these...
>
> I just had a look myself. carma has been removed fortunately in linux-next,
> so we don't have to worry about that any more.
>
> I assume that the sst-firmware.c case is a mistake, it should just use a
> plain DMA_SLAVE and not DMA_MEMCPY.
Other way around.
--
With Best Regards,
Andy Shevchenko
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
ntation/dmaengine/client.txt| 23 ++---
> arch/arm/mach-davinci/devices-da8xx.c | 95 +-
> arch/arm/mach-davinci/devices.c | 19
> arch/arm/mach-davinci/dm355.c | 28 --
> arch/arm/mach-davinci/dm365.c | 30 --
> arch/arm/mac
el on success or an error pointer.
> + */
> +struct dma_chan *dma_request_chan_by_mask(const dma_cap_mask_t *mask)
> +{
> + struct dma_chan *chan;
> +
> + if (!mask)
> + return ERR_PTR(-ENODEV);
> +
> + chan = __dma_request_channel(mask, NUL
_slave.filter_map.filter_fn = edma_filter_fn;
One nitpick here.
I think filter_map.filter_fn naming is duplicate.
What about
dma_device
.filter -> filter data (or .filter_data)
.map -> mappings
.map_count -> # of entries in mappings
.fn -> filter function
What do you
t; ecc->dma_slave.filter_map.map = info->slave_map;
> ecc->dma_slave.filter_map.mapcnt = info->slavecnt;
> ecc->dma_slave.filter_map.filter_fn = edma_filter_fn;
> }
>
> When neither DT or ACPI lookup is available the dma_request_chan() will
> t
On Tue, Dec 1, 2015 at 11:56 AM, Peter Ujfalusi <peter.ujfal...@ti.com> wrote:
> On 11/30/2015 04:51 PM, Andy Shevchenko wrote:
>>> +struct dma_chan *dma_request_chan(struct device *dev, const char *name)
>>> +{
>>> + struct dma_device *device, *_d;
>
arm/mach-davinci/dm355.c | 28 --
> arch/arm/mach-davinci/dm365.c | 30 +--
> arch/arm/mach-davinci/dm644x.c| 12 +++
> arch/arm/mach-davinci/dm646x.c| 11 +++
> drivers/dma/dmaengine.c | 160
> +-
> drivers/dma/edma.c| 24 +
> drivers/mmc/host/davinci_mmc.c| 52 +++
> drivers/spi/spi-davinci.c | 76 +---
> include/linux/dmaengine.h | 31 +++
> include/linux/platform_data/edma.h| 5 ++
> 12 files changed, 330 insertions(+), 213 deletions(-)
>
> --
> 2.6.3
>
--
With Best Regards,
Andy Shevchenko
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
rue;
> +
> bitmap_and(has.bits, want->bits, device->cap_mask.bits,
> DMA_TX_TYPE_END);
> return bitmap_equal(want->bits, has.bits, DMA_TX_TYPE_END);
> --
> 2.6.3
>
--
With Best Regards,
Andy Shevchenko
--
To unsubscribe from this list: send the line &quo
dma_request_channel(const
> dma_cap_mask_t *mask,
> struct dma_chan *dma_request_slave_channel_reason(struct device *dev,
> const char *name);
> struct dma_chan *dma_request_slave_channel(struct device *dev, const char
> *name);
> +
>
gt; - list_del_rcu(>global_node);
> - } else if (err)
> - pr_debug("%s: failed to get %s: (%d)\n",
> -__func__, dma_chan_name(chan), err);
> -
On Tue, Dec 1, 2015 at 11:47 AM, Peter Ujfalusi <peter.ujfal...@ti.com> wrote:
> On 11/30/2015 04:35 PM, Andy Shevchenko wrote:
>> On Mon, Nov 30, 2015 at 3:45 PM, Peter Ujfalusi <peter.ujfal...@ti.com>
>> wrote:
>>> Treat as true condition the case when the m
map through platform data
Why not unified device properties?
--
With Best Regards,
Andy Shevchenko
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
On Fri, Nov 20, 2015 at 2:30 PM, Peter Ujfalusi <peter.ujfal...@ti.com> wrote:
> On 11/20/2015 02:24 PM, Andy Shevchenko wrote:
>> On Fri, Nov 20, 2015 at 12:58 PM, Arnd Bergmann <a...@arndb.de> wrote:
>>> On Friday 20 November 2015 12:25:06 Peter Ujfalusi wrote:
>
99 matches
Mail list logo
