Re: [PATCH v5 2/3] extcon: Palmas Extcon Driver

2013-05-26 Thread Chanwoo Choi
Hi Kishon, I have some comment about this patch and upload modified patch to following repository (extcon-for-palmas). - http://git.kernel.org/cgit/linux/kernel/git/chanwoo/extcon.git/commit/?h=extcon-for-palmasid=f2b7cb80699cbe1a5fd6c97ef2c600915f8d7f2c This patchset include patch related to

Re: [PATCH 3/3] usb: dwc3: use extcon fwrk to receive connect/disconnect notification

2013-05-26 Thread Chanwoo Choi
/dwc3/dwc3-omap.c | 80 +-- include/linux/usb/dwc3-omap.h | 30 2 files changed, 62 insertions(+), 48 deletions(-) delete mode 100644 include/linux/usb/dwc3-omap.h I check the code about extcon framework. Acked-by: Chanwoo Choi cw00.c

Re: [PATCH v5 2/3] extcon: Palmas Extcon Driver

2013-05-27 Thread Chanwoo Choi
On 05/27/2013 02:54 PM, Kishon Vijay Abraham I wrote: Hi, On Monday 27 May 2013 11:04 AM, Chanwoo Choi wrote: Hi Kishon, I have some comment about this patch and upload modified patch to following repository (extcon-for-palmas). - http://git.kernel.org/cgit/linux/kernel/git/chanwoo

Re: [PATCH v2] usb: dwc3: use extcon fwrk to receive connect/disconnect notification

2013-05-27 Thread Chanwoo Choi
2 files changed, 85 insertions(+), 48 deletions(-) delete mode 100644 include/linux/usb/dwc3-omap.h I think that usb or other maintainer have to confirm this patch for applying extcon-next branch. Thanks, Chanwoo Choi -- To unsubscribe from this list: send the line unsubscribe linux-omap

Re: [PATCH v6] extcon: Palmas Extcon Driver

2013-05-27 Thread Chanwoo Choi
-by: Sebastien Guiriec s-guir...@ti.com Signed-off-by: Chanwoo Choi cw00.c...@samsung.com Signed-off-by: Myungjoo Ham myungjoo@samsung.com --- Changes from v5: * removed regulator calls from palmas-usb as some platforms wont need it. These are now done in dwc3-omap.c as it is needed for OMAP

Re: [PATCH 3/3] usb: dwc3: use extcon fwrk to receive connect/disconnect notification

2013-05-30 Thread Chanwoo Choi
= dwc3_omap_dma_mask; + Thanks, Chanwoo Choi -- To unsubscribe from this list: send the line unsubscribe linux-omap in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH 0/5] dwc3: omap: adapt dwc3 to use extcon framework

2013-06-11 Thread Chanwoo Choi
Hi Kishon, Sorry for late reply. I applied patch1,2 on extcon-linus branch. - http://git.kernel.org/cgit/linux/kernel/git/chanwoo/extcon.git/log/?h=extcon-linus But, I have comment of patch 3 about dt API. I send comment on patch 3 mailing thread. Thanks, Chanwoo Choi On 06/04/2013 01:13 AM

Re: [PATCH 0/5] dwc3: omap: adapt dwc3 to use extcon framework

2013-06-11 Thread Chanwoo Choi
, Chanwoo Choi On 06/04/2013 01:13 AM, Kishon Vijay Abraham I wrote: The first three patches deals with cleanup of extcon inorder to get through compilation without any issues. It also adds an API to get extcon device from dt node which I felt was missing. The next two patches deals with adapt

Re: [PATCH 1/5] extcon: Add an API to get extcon device from dt node

2013-06-11 Thread Chanwoo Choi
) { return NULL; Thanks, Chanwoo Choi -- To unsubscribe from this list: send the line unsubscribe linux-omap in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

[PATCH] extcon: Add an API to get extcon device from dt node

2013-06-11 Thread Chanwoo Choi
From: Kishon Vijay Abraham I kis...@ti.com Added an API of_extcon_get_extcon_dev() to be used by drivers to get extcon device in the case of dt boot (this can be used instead of extcon_get_extcon_dev()). Signed-off-by: Kishon Vijay Abraham I kis...@ti.com Signed-off-by: Chanwoo Choi cw00.c

Re: [PATCH] extcon: Add an API to get extcon device from dt node

2013-06-13 Thread Chanwoo Choi
On 06/12/2013 03:55 PM, Kishon Vijay Abraham I wrote: Hi Chanwoo Choi, On Wednesday 12 June 2013 07:09 AM, Chanwoo Choi wrote: From: Kishon Vijay Abraham I kis...@ti.com Added an API of_extcon_get_extcon_dev() to be used by drivers to get extcon device in the case of dt boot (this can

[PATCH v2] extcon: Add an API to get extcon device from dt node

2013-06-14 Thread Chanwoo Choi
From: Kishon Vijay Abraham I kis...@ti.com Added an API of_extcon_get_extcon_dev() to be used by drivers to get extcon device in the case of dt boot (this can be used instead of extcon_get_extcon_dev()). Signed-off-by: Kishon Vijay Abraham I kis...@ti.com Signed-off-by: Chanwoo Choi cw00.c

Re: [PATCH v2] extcon: Add an API to get extcon device from dt node

2013-06-14 Thread Chanwoo Choi
On 06/14/2013 05:36 PM, Kishon Vijay Abraham I wrote: Hi, On Friday 14 June 2013 12:45 PM, Chanwoo Choi wrote: From: Kishon Vijay Abraham I kis...@ti.com Added an API of_extcon_get_extcon_dev() to be used by drivers to get extcon device in the case of dt boot (this can be used instead

Re: [PATCH v4] usb: dwc3: use extcon fwrk to receive connect/disconnect

2013-06-16 Thread Chanwoo Choi
a/include/linux/usb/dwc3-omap.h b/include/linux/usb/dwc3-omap.h deleted file mode 100644 index 5615f4d..000 It looks good if you add exception handler about return value of extcon_register_interest(). Acked-by: Chanwoo Choi cw00.c...@samsung.com But, we have to apply this patch after all

Re: [PATCH v5] usb: dwc3: use extcon fwrk to receive connect/disconnect

2013-06-24 Thread Chanwoo Choi
Balbi ba...@ti.com Acked-by: Chanwoo Choi cw00.c...@samsung.com --- This patch should be applied after all of the extcon patchset will be applied because this patch has dependency of extcon patch related to DT. http://goo.gl/Tu3qW Changes from v4: * checked the return values

Re: [PATCH v6] usb: dwc3: use extcon fwrk to receive connect/disconnect

2013-07-15 Thread Chanwoo Choi
-off-by: Kishon Vijay Abraham I kis...@ti.com Acked-by: Felipe Balbi ba...@ti.com Acked-by: Chanwoo Choi cw00.c...@samsung.com --- This patch should be applied after all of the extcon patchset will be applied because this patch has dependency of extcon patch related to DT. http://goo.gl/Tu3qW

Re: [PATCH 1/2] extcon: palmas: Added a new compatible type *ti,palmas-usb-vid*

2013-08-13 Thread Chanwoo Choi
=26ece4f0b7d2264282d9077d1843ff1e98189b6c Thanks, Chanwoo Choi -- To unsubscribe from this list: send the line unsubscribe linux-omap in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH v2] extcon: palmas: Modified the compatible type to *ti,palmas-usb-vid*

2013-08-19 Thread Chanwoo Choi
been published in a release kernel? If so, it makes No. This was merged only in 3.11-rc1. So I think we should take this version? Chanwoo can you take this patch? This patch will be included in 3.12-rc* after 3.12-rc1. and this patch is applied on extcon-linus branch. Thanks, Chanwoo Choi

Re: [PATCH v2] extcon: palmas: Modified the compatible type to *ti,palmas-usb-vid*

2013-08-19 Thread Chanwoo Choi
retain the old values? What is the meaning of old value? previous value related to extcon-twl.txt? The extcon-twl.txt was included in 3.11 kernel and extcon-palmas.txt will be inclued in 3.12 kernel through char-misc repo of GregKH. Thanks, Chanwoo Choi -- To unsubscribe from this list: send

Re: [PATCH 1/2] extcon: extcon-dra7xx: Add extcon driver for USB ID detection

2013-08-19 Thread Chanwoo Choi
(DRA7x USB Connector driver); +MODULE_LICENSE(GPL); +MODULE_DEVICE_TABLE(of, of_dra7xx_match_tbl); Thanks, Chanwoo Choi -- To unsubscribe from this list: send the line unsubscribe linux-omap in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org

Re: [PATCH 1/2] extcon: extcon-dra7xx: Add extcon driver for USB ID detection

2013-08-20 Thread Chanwoo Choi
for detection isn't appropriate for extcon device driver. Instead, I will consider whether to support polling method or not on extcon core. Thanks, Chanwoo Choi -- To unsubscribe from this list: send the line unsubscribe linux-omap in the body of a message to majord...@vger.kernel.org More majordomo

Re: [PATCH 1/2] extcon: extcon-dra7xx: Add extcon driver for USB ID detection

2013-08-20 Thread Chanwoo Choi
meant, you prefer interrupt method for cable detection over polling . Right, my mistake. I prefer interrupt method. Thanks, Chanwoo CHoi -- To unsubscribe from this list: send the line unsubscribe linux-omap in the body of a message to majord...@vger.kernel.org More majordomo info at http

Re: [PATCH v3 1/3] extcon: extcon-gpio-usbvid: Generic USB VBUS/ID detection via GPIO

2013-08-28 Thread Chanwoo Choi
); + +MODULE_ALIAS(platform:gpio-usbvid); +MODULE_AUTHOR(George Cherian george.cher...@ti.com); +MODULE_DESCRIPTION(GPIO based USB Connector driver); +MODULE_LICENSE(GPL); +MODULE_DEVICE_TABLE(of, of_gpio_usbvid_match_tbl); Cheers, Chanwoo Choi -- To unsubscribe from this list: send the line

Re: [PATCH v3 1/3] extcon: extcon-gpio-usbvid: Generic USB VBUS/ID detection via GPIO

2013-08-29 Thread Chanwoo Choi
Hi George, On 08/29/2013 11:21 AM, George Cherian wrote: Hi Chanwoo, Thanks for the review and sorry for all the trivial mistakes. On 8/29/2013 7:05 AM, Chanwoo Choi wrote: Hi George, You didn't modify this patchset about my comment on v1 patchset. Please pay attention to comment

Re: [PATCH v3 1/3] extcon: extcon-gpio-usbvid: Generic USB VBUS/ID detection via GPIO

2013-08-29 Thread Chanwoo Choi
On 08/29/2013 04:30 PM, George Cherian wrote: Hi Chanwoo, On 8/29/2013 11:53 AM, Chanwoo Choi wrote: [snip] You should keep following naming stlye. extcon-gpio-usbvid.c is wrong naming style. - extcon-[device name].c - extcon-gpio-usbvid.c - extcon-dra7xx.c or etc. Actually dra7xx

Re: [PATCH v3 1/3] extcon: extcon-gpio-usbvid: Generic USB VBUS/ID detection via GPIO

2013-08-29 Thread Chanwoo Choi
On 08/29/2013 08:48 PM, George Cherian wrote: On 8/29/2013 4:07 PM, Chanwoo Choi wrote: On 08/29/2013 04:30 PM, George Cherian wrote: Hi Chanwoo, On 8/29/2013 11:53 AM, Chanwoo Choi wrote: [snip] You should keep following naming stlye. extcon-gpio-usbvid.c is wrong naming style. - extcon

Re: [PATCH v3 1/3] extcon: extcon-gpio-usbvid: Generic USB VBUS/ID detection via GPIO

2013-08-29 Thread Chanwoo Choi
Hi George, On 08/29/2013 10:45 PM, George Cherian wrote: Hi Chanwoo, On 8/29/2013 5:42 PM, Chanwoo Choi wrote: [big snip ] I tested various development board based on Samsung Exynos series SoC. Although some gpio of Exynos series SoC set high state(non zero, 1) as default value

Re: [PATCH v3 1/3] extcon: extcon-gpio-usbvid: Generic USB VBUS/ID detection via GPIO

2013-08-30 Thread Chanwoo Choi
Hi George, On 08/30/2013 03:15 PM, George Cherian wrote: Hi Chanwoo, On 8/30/2013 5:41 AM, Chanwoo Choi wrote: Hi George, On 08/29/2013 10:45 PM, George Cherian wrote: Hi Chanwoo, On 8/29/2013 5:42 PM, Chanwoo Choi wrote: [big snip ] I tested various development board based

Re: [PATCH v3 1/3] extcon: extcon-gpio-usbvid: Generic USB VBUS/ID detection via GPIO

2013-08-30 Thread Chanwoo Choi
Hi George, In addition, I add answer about that device driver control gpio pin directly. On 08/30/2013 03:15 PM, George Cherian wrote: Hi Chanwoo, On 8/30/2013 5:41 AM, Chanwoo Choi wrote: Hi George, On 08/29/2013 10:45 PM, George Cherian wrote: Hi Chanwoo, On 8/29/2013 5:42 PM

[PATCH 1/2] extcon: of: Remove unnecessary function call by using the name of device_node

2014-03-18 Thread Chanwoo Choi
This patch remove unnecessary function call in of_extcon_get_extcon_dev() by using the name of device_node structure. Signed-off-by: Chanwoo Choi cw00.c...@samsung.com --- drivers/extcon/of_extcon.c | 12 ++-- 1 file changed, 2 insertions(+), 10 deletions(-) diff --git a/drivers/extcon

[PATCH 2/2] extcon: Move OF helper function to extcon core and change function name

2014-03-18 Thread Chanwoo Choi
This patch move simply OF helper function to extcon core and change function name as following: - of_extcon_get_extcon_dev() - extcon_get_edev_by_phandle() Signed-off-by: Chanwoo Choi cw00.c...@samsung.com --- drivers/extcon/Kconfig | 4 --- drivers/extcon/Makefile | 2

[PATCH 0/2] extcon: of: Update OF helper function

2014-03-18 Thread Chanwoo Choi
Thisp patchset remove unnecessary function call in of_extcon_get_extcon_dev() which get the extcon device from devicetree. Also, this patchset move OF helper func to extcon core and change function name as following: - of_extcon_get_extcon_dev() - extcon_get_edev_by_phandle() Chanwoo Choi (2

Re: [PATCH 1/2] extcon: of: Remove unnecessary function call by using the name of device_node

2014-03-19 Thread Chanwoo Choi
Hi, On 03/19/2014 09:08 PM, Kishon Vijay Abraham I wrote: Hi, On Tuesday 18 March 2014 05:34 PM, Chanwoo Choi wrote: This patch remove unnecessary function call in of_extcon_get_extcon_dev() by using the name of device_node structure. Signed-off-by: Chanwoo Choi cw00.c...@samsung.com

Re: [PATCH 1/2] extcon: of: Remove unnecessary function call by using the name of device_node

2014-03-20 Thread Chanwoo Choi
Hi, On 03/20/2014 02:20 PM, Kishon Vijay Abraham I wrote: Hi, On Thursday 20 March 2014 07:52 AM, Chanwoo Choi wrote: Hi, On 03/19/2014 09:08 PM, Kishon Vijay Abraham I wrote: Hi, On Tuesday 18 March 2014 05:34 PM, Chanwoo Choi wrote: This patch remove unnecessary function call

Re: extcon-next regression ?

2014-04-23 Thread Chanwoo Choi
palmas_usb.7: failed to register extcon device [3.250493] palmas-usb: probe of palmas_usb.7 failed with error -22 Any ideas ?? bisected down to: commit 854b85057cc6b90a326b731174b6c6dbbf34222a Author: Chanwoo Choi cw00.c...@samsung.com Date: Mon Apr 21 19:46:51 2014 +0900 extcon: Add

Re: extcon-next regression ?

2014-04-23 Thread Chanwoo Choi
to register extcon device [3.250493] palmas-usb: probe of palmas_usb.7 failed with error -22 Any ideas ?? bisected down to: commit 854b85057cc6b90a326b731174b6c6dbbf34222a Author: Chanwoo Choi cw00.c...@samsung.com Date: Mon Apr 21 19:46:51 2014 +0900 extcon: Add

Re: extcon-next regression ?

2014-04-24 Thread Chanwoo Choi
Hi, On 04/24/2014 03:47 PM, Felipe Balbi wrote: Hi, On Thu, Apr 24, 2014 at 02:35:44PM +0900, Chanwoo Choi wrote: Hi Felipe, Thanks for your test and review. On 04/24/2014 03:28 AM, Felipe Balbi wrote: Hi, On Wed, Apr 23, 2014 at 12:20:52PM -0500, Felipe Balbi wrote: I've been

Re: [RESEND PATCH 0/2] Add dt support for extcon gpio driver

2014-11-05 Thread Chanwoo Choi
busy for other jobs. But, I will review this patchset and test it on my board within 3~4 days. Best Regards, Chanwoo Choi -- To unsubscribe from this list: send the line unsubscribe linux-omap in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org

Re: [RESEND PATCH 1/2] extcon: gpio: Add dt support for the driver

2014-11-11 Thread Chanwoo Choi
/* __EXTCON_GPIO_H__ */ Thanks, Chanwoo Choi -- To unsubscribe from this list: send the line unsubscribe linux-omap in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [RESEND PATCH 2/2] extcon: gpio: Add support for using cable names

2014-11-11 Thread Chanwoo Choi
cables by using devm_extcon_dev_allocate(). Thanks, Chanwoo Choi ret = devm_extcon_dev_register(pdev-dev, extcon_data-edev); if (ret 0) return ret; -- To unsubscribe from this list: send the line unsubscribe linux-omap in the body of a message to majord

Re: [PATCH v2 1/7] extcon: usb-gpio: Introduce gpio usb extcon driver

2015-01-26 Thread Chanwoo Choi
, + .of_match_table = usb_extcon_dt_match, + }, +}; + +module_platform_driver(usb_extcon_driver); + +MODULE_AUTHOR(Roger Quadros rog...@ti.com); +MODULE_DESCRIPTION(USB GPIO extcon driver); +MODULE_LICENSE(GPL v2); Thanks, Chanwoo Choi -- To unsubscribe from this list: send the line unsubscribe

Re: [PATCH v4 1/1] extcon: usb-gpio: Introduce gpio usb extcon driver

2015-02-02 Thread Chanwoo Choi
Hi Roger, Looks good to me. Applied it on v3.21 queue. Thanks, Chanwoo Choi On 02/02/2015 07:21 PM, Roger Quadros wrote: This driver observes the USB ID pin connected over a GPIO and updates the USB cable extcon states accordingly. The existing GPIO extcon driver is not suitable

Re: [PATCH v2 2/7] usb: extcon: Fix USB-Host cable name

2015-02-02 Thread Chanwoo Choi
Hi Roger, On 02/02/2015 06:09 PM, Roger Quadros wrote: Chanwoo, On 02/02/15 07:04, Chanwoo Choi wrote: Hi Roger, On 01/30/2015 11:05 PM, Roger Quadros wrote: Hi, On 30/01/15 13:04, Roger Quadros wrote: Felipe Chanwoo, On 26/01/15 14:15, Roger Quadros wrote: The recommended name

Re: [PATCH v2 2/7] usb: extcon: Fix USB-Host cable name

2015-02-02 Thread Chanwoo Choi
On 02/02/2015 07:01 PM, Roger Quadros wrote: On 02/02/15 11:55, Chanwoo Choi wrote: Hi Roger, On 02/02/2015 06:09 PM, Roger Quadros wrote: Chanwoo, On 02/02/15 07:04, Chanwoo Choi wrote: Hi Roger, On 01/30/2015 11:05 PM, Roger Quadros wrote: Hi, On 30/01/15 13:04, Roger Quadros wrote

Re: [PATCH 1/5] extcon: gpio-usb: Introduce gpio usb extcon driver

2015-01-20 Thread Chanwoo Choi
Hi Roger, On 01/20/2015 02:52 AM, Roger Quadros wrote: This driver observes the USB ID pin connected over a GPIO and updates the USB cable extcon states accordingly. The existing GPIO extcon driver is not suitable for this purpose as it needs to be taught to understand USB cable states and

Re: [PATCH v2 1/7] extcon: usb-gpio: Introduce gpio usb extcon driver

2015-01-26 Thread Chanwoo Choi
Hi Roger, On 01/27/2015 01:27 AM, Roger Quadros wrote: Hi Chanwoo, All your comments are valid. Need some clarification on one comment. On 26/01/15 15:56, Chanwoo Choi wrote: Hi Roger, This patch looks good to me. But I add some comment. If you modify some comment, I'll apply

Re: [PATCH v3 1/7] extcon: usb-gpio: Introduce gpio usb extcon driver

2015-01-28 Thread Chanwoo Choi
, + }, +}; + +module_platform_driver(usb_extcon_driver); + +MODULE_AUTHOR(Roger Quadros rog...@ti.com); +MODULE_DESCRIPTION(USB GPIO extcon driver); +MODULE_LICENSE(GPL v2); Thanks, Chanwoo Choi -- To unsubscribe from this list: send the line unsubscribe linux-omap in the body of a message

Re: [PATCH v2 2/7] usb: extcon: Fix USB-Host cable name

2015-02-01 Thread Chanwoo Choi
the specific cable name(USB-Host or USB-HOST) without any standard way. So, I have plan to define common cable name in extcon header file by using capital letter. Thanks, Chanwoo Choi -- To unsubscribe from this list: send the line unsubscribe linux-omap in the body of a message to majord

Re: [PATCH v3 1/7] extcon: usb-gpio: Introduce gpio usb extcon driver

2015-02-01 Thread Chanwoo Choi
Hi Roger, On 01/30/2015 11:03 PM, Roger Quadros wrote: On 30/01/15 02:11, Chanwoo Choi wrote: Hi Roger, On 01/28/2015 09:15 PM, Roger Quadros wrote: This driver observes the USB ID pin connected over a GPIO and updates the USB cable extcon states accordingly. The existing GPIO extcon

Re: [PATCH v2 1/7] extcon: usb-gpio: Introduce gpio usb extcon driver

2015-01-27 Thread Chanwoo Choi
Hi Roger, On 01/28/2015 12:38 AM, Roger Quadros wrote: Chanwoo, On 27/01/15 03:54, Chanwoo Choi wrote: Hi Roger, On 01/27/2015 01:27 AM, Roger Quadros wrote: Hi Chanwoo, All your comments are valid. Need some clarification on one comment. On 26/01/15 15:56, Chanwoo Choi wrote: Hi

Re: [PATCH v4 1/1] extcon: usb-gpio: Introduce gpio usb extcon driver

2015-03-16 Thread Chanwoo Choi
for this purpose, no? 'extcon_cable_name' global variable is not used on extcon driver directly. It is just recommended cable name. I have plan to use standard cable name for extcon driver instead of that each extcon driver define the cable name. [snip] Thanks, Chanwoo Choi -- To unsubscribe from

Re: [PATCH v3 1/7] extcon: usb-gpio: Introduce gpio usb extcon driver

2015-01-29 Thread Chanwoo Choi
for extcon cable name as soon because it has potential isseu about the conflict of extcon cable name between subsystems. So, I recommend to use a captical letter as USB-HOST instead of USB-Host. If other extcon driver don't use the captical letter, I'll fix it. [snip] Thanks, Chanwoo Choi

Re: [PATCH v3 1/7] extcon: usb-gpio: Introduce gpio usb extcon driver

2015-01-29 Thread Chanwoo Choi
Hi Roger, On 01/29/2015 08:26 PM, Roger Quadros wrote: Chanwoo, On 29/01/15 03:49, Chanwoo Choi wrote: Hi Roger, We need to discuss one point about 'id_irqwake'. I don't recommend to use 'id_irqwake' field. And I catch build warning by using select keywork in Kconfig. It is my wrong

Re: [PATCH v3 1/2] extcon: palmas: Support GPIO based USB ID detection

2015-07-31 Thread Chanwoo Choi
Hi Roger, Looks good to me. But, I add one comment about mdelay. If you modify it, you can add my acked-by message. Acked-by: Chanwoo Choi cw00.c...@samsung.com Also, You must recevie the ack message from MFD maintainer (Lee Jones). On Fri, Jul 31, 2015 at 8:08 PM, Roger Quadros rog...@ti.com

Re: [PATCH v2 1/2] extcon: fix hang and extcon_get/set_cable_state().

2015-07-30 Thread Chanwoo Choi
Hi Roger, I add minor comment about code clean. After I modified it by myself, I applied it on extcon-fixes. Best Regards, Chanwoo Choi On 07/07/2015 10:06 PM, Roger Quadros wrote: Users of find_cable_index_by_name() will cause a kernel hang as the while loop counter is never incremented

Re: [PATCH 2/2] extcon: Fix extcon_cable_get_state() from getting old state after notification

2015-07-31 Thread Chanwoo Choi
this by first changing the extcon state variable and then notifying listeners. Signed-off-by: Roger Quadros rog...@ti.com --- drivers/extcon/extcon.c | 14 ++ 1 file changed, 10 insertions(+), 4 deletions(-) Applied it. Thanks, Chanwoo Choi diff --git a/drivers/extcon/extcon.c

Re: [PATCH v2 1/2] extcon: palmas: Support GPIO based USB ID detection

2015-07-31 Thread Chanwoo Choi
{ + extcon_set_cable_state(palmas_usb-edev, USB-HOST, true); ditto. Use the extcon_set_cable_state_() with extcon id. [snip] Thanks, Chanwoo Choi -- To unsubscribe from this list: send the line unsubscribe linux-omap in the body of a message to majord...@vger.kernel.org More majordomo info at http

Re: [PATCH v4 1/2] extcon: palmas: Support GPIO based USB ID detection

2015-08-09 Thread Chanwoo Choi
Hi Lee, This patch modified the header file in the MFD directory (include/linux/mfd/palmas.h). After you review this patch, I'll apply it on extcon-next and sent the pull request for Linux 4.3. Thanks, Chanwoo Choi On 08/07/2015 05:24 PM, Roger Quadros wrote: Hi Lee / Samuel, On 03/08/15

Re: [PATCH v2 2/2] ARM: dts: am57xx-beagle-x15: use palmas-usb for USB2

2015-08-05 Thread Chanwoo Choi
about pull request of extcon for v4.3 after v4.2-rc6 releas. Thanks, Chanwoo Choi -- To unsubscribe from this list: send the line unsubscribe linux-omap in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH v2 1/2] extcon: fix hang and extcon_get/set_cable_state().

2015-07-27 Thread Chanwoo Choi
Hi Roger, On 07/27/2015 07:39 PM, Roger Quadros wrote: Chanwoo, On 10/07/15 18:54, Chanwoo Choi wrote: Hi Roger, Thanks for your working. I'll review, test and apply it on next week because I'm on vacation now. Can you please take this for -rc cycle? Thanks. I'm sorry for delay

Re: [PATCH v2 1/2] extcon: fix hang and extcon_get/set_cable_state().

2015-07-10 Thread Chanwoo Choi
Hi Roger, Thanks for your working. I'll review, test and apply it on next week because I'm on vacation now. Thanks, Chanwoo Choi On Tue, Jul 7, 2015 at 3:06 PM, Roger Quadros rog...@ti.com wrote: Users of find_cable_index_by_name() will cause a kernel hang as the while loop counter is never

[PATCH v2 1/3] extcon: palmas: Add the support for VBUS detection by using GPIO

2015-12-29 Thread Chanwoo Choi
From: Felipe Balbi <ba...@ti.com> This patch support for VBUS detection by using GPIO pin. Signed-off-by: Felipe Balbi <ba...@ti.com> Signed-off-by: Chanwoo Choi <cw00.c...@samsung.com> --- drivers/extcon/extcon-palmas.c | 50 ++

[PATCH v2 2/3] arm: boot: dts: beaglex15: Remove ID GPIO

2015-12-29 Thread Chanwoo Choi
bi <ba...@ti.com> Signed-off-by: Chanwoo Choi <cw00.c...@samsung.com> --- arch/arm/boot/dts/am57xx-beagle-x15.dts | 2 -- 1 file changed, 2 deletions(-) diff --git a/arch/arm/boot/dts/am57xx-beagle-x15.dts b/arch/arm/boot/dts/am57xx-beagle-x15.dts index d9ba6b879fc1..be4990608c77 100644 --- a

[PATCH v2 0/3] arm: beaglex15: fix USB Gadget

2015-12-29 Thread Chanwoo Choi
This patchset make the extcon-palmas.c more generic style and then send v2 patchset. I add the Felipe comment of v1 patchset as following: But, I have not test on real board because I don't have it. Just, I modify this patchset based on v1 patchset[1] from Felipe Balbi. - Felipe comment of this

[PATCH v2 3/3] arm: boot: beaglex15: pass correct interrupt

2015-12-29 Thread Chanwoo Choi
using this GPIO-based interrupt mechanism for notifying about VBUS. [1] https://github.com/beagleboard/beagleboard-x15/blob/master/BeagleBoard-X15_RevA2.pdf Signed-off-by: Felipe Balbi <ba...@ti.com> [cw00.choi: Use the 'vbus-gpio' property instead of 'interrupts-extended'] Signed-off-by:

Re: [PATCH] extcon: palmas: add support for using VBUSDET output

2015-11-20 Thread Chanwoo Choi
Hi Felipe, On Fri, Nov 20, 2015 at 11:37 PM, Felipe Balbi <ba...@ti.com> wrote: > > Hi Chanwoo, > > Chanwoo Choi <cw00.c...@samsung.com> writes: >> Hi Felipe, >> >> On 2015년 11월 20일 14:33, Chanwoo Choi wrote: >>> Hi Felipe, >>> >&g

Re: [PATCH] extcon: palmas: add support for using VBUSDET output

2015-11-20 Thread Chanwoo Choi
Hi Felipe, On 2015. 11. 20. 오후 11:37, Felipe Balbi wrote: > > Hi Chanwoo, > > Chanwoo Choi <cw00.c...@samsung.com> writes: >> Hi Felipe, >> >> On 2015년 11월 20일 14:33, Chanwoo Choi wrote: >>> Hi Felipe, >>> >>> Looks good to me.

Re: [PATCH] extcon: palmas: add support for using VBUSDET output

2015-11-20 Thread Chanwoo Choi
Hi, On Sat, Nov 21, 2015 at 12:05 AM, Chanwoo Choi <cwcho...@gmail.com> wrote: > Hi Felipe, > > On Fri, Nov 20, 2015 at 11:37 PM, Felipe Balbi <ba...@ti.com> wrote: >> >> Hi Chanwoo, >> >> Chanwoo Choi <cw00.c...@samsung.com> writes: >>

Re: [PATCH 2/2] arm: boot: beaglex15: pass correct interrupt

2015-11-20 Thread Chanwoo Choi
Hi, On Sat, Nov 21, 2015 at 1:42 AM, Chanwoo Choi <cwcho...@gmail.com> wrote: > Hi, > > On 2015. 11. 20. 오후 2:39, Chanwoo Choi wrote: >> Hi, >> >> On 2015년 11월 13일 02:53, Felipe Balbi wrote: >>> According to latest schematics [1], GPIO_1/VBUSDET >>

Re: [PATCH] extcon: palmas: add support for using VBUSDET output

2015-11-19 Thread Chanwoo Choi
LMAS_VBUS_IRQ); > status = devm_request_threaded_irq(palmas_usb->dev, > palmas_usb->vbus_irq, NULL, > palmas_vbus_irq_handler, > Thanks, Chanwoo Choi -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH] extcon: palmas: add support for using VBUSDET output

2015-11-19 Thread Chanwoo Choi
Hi Felipe, On 2015년 11월 20일 14:33, Chanwoo Choi wrote: > Hi Felipe, > > Looks good to me. But I have one comment. > > On 2015년 11월 13일 02:57, Felipe Balbi wrote: >> TPS659038 can remux its GPIO_1 as VBUSDET output, >> which can be tied to a SoC GPIO and used as a VBUS

Re: [PATCH 2/2] arm: boot: beaglex15: pass correct interrupt

2015-11-19 Thread Chanwoo Choi
1 IRQ_TYPE_EDGE_RISING>; > }; > > }; > I check the schematic file. The GPIO4_21 pin is connected as following: - GPIO_1/VBUSDET -> PMIC_VBUS_DET -> VBUS_DET -> AM5728 GPIO4_21 pin Reviewed-by: Chanwoo Choi <cw00.c...@samsung.com> Thanks, Chanwo

Re: [PATCH 1/1] usb: phy: omap-otg: do not write to unallocated memory

2015-11-19 Thread Chanwoo Choi
Hi, The same patch was already reviewed and applied on usb.git repository[1] [1] https://git.kernel.org/cgit/linux/kernel/git/balbi/usb.git/commit/?h=testing/fixes=2c2025b41aeff57963f9ae2dd909fea704c625ab Thanks, Chanwoo Choi On 2015년 11월 20일 08:43, Heinrich Schuchardt wrote: > The curr