have been easier to with Coccinelle instead of by hand...
regards,
dan carpenter
--
To unsubscribe from this list: send the line unsubscribe linux-omap in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
randomly to the left.
regards,
dan carpenter
--
To unsubscribe from this list: send the line unsubscribe linux-omap in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
On Wed, Sep 12, 2012 at 11:11:27AM +0300, Dan Carpenter wrote:
On Tue, Sep 11, 2012 at 07:06:52PM +0300, Eduardo Valentin wrote:
From: J Keerthy j-keer...@ti.com
Removes checkpatch warnings on omap-bandgap.c.
Which checkpatch.pl warnings
to vmalloc()ed memory yet?
regards,
dan carpenter
--
To unsubscribe from this list: send the line unsubscribe linux-omap in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
On Wed, Sep 12, 2012 at 12:19:00PM +0300, Valentin, Eduardo wrote:
Hello Dan,
On Wed, Sep 12, 2012 at 11:26 AM, Dan Carpenter
dan.carpen...@oracle.com wrote:
On Wed, Sep 12, 2012 at 11:11:27AM +0300, Dan Carpenter wrote:
On Tue, Sep 11, 2012 at 07:06:52PM +0300, Eduardo Valentin wrote
We may as well fix this potential leak so we don't have to listen to
the static checkers complain.
Signed-off-by: Dan Carpenter erro...@gmail.com
---
Btw. This function returns -EBUSY on success. Was that really what
you want?
diff --git a/drivers/usb/dwc3/debugfs.c b/drivers/usb/dwc3
ret should be signed here for the error handling to work.
Signed-off-by: Dan Carpenter dan.carpen...@oracle.com
diff --git a/drivers/usb/phy/omap-usb2.c b/drivers/usb/phy/omap-usb2.c
index 15ab3d6..d36c282 100644
--- a/drivers/usb/phy/omap-usb2.c
+++ b/drivers/usb/phy/omap-usb2.c
@@ -120,7
CodingStyle, same for the other similar
changes.
It doesn't mean you have to right justify things, it just means
indented. The original code is fine here and the new code is fine
here. It's up to whoever writes the code to decide.
regards,
dan carpenter
signature.asc
Description: Digital
-vm_page_prot, vma-vm_flags);
regards,
dan carpenter
signature.asc
Description: Digital signature
/stable_kernel_rules.txt. It's short.
regards,
dan carpenter
signature.asc
Description: Digital signature
?
Probably that's not stable material.
regards,
dan carpenter
signature.asc
Description: Digital signature
On Tue, Jan 31, 2012 at 12:19:52PM +0100, Víctor M. Jáquez L. wrote:
On Tue, Jan 31, 2012 at 11:05:43AM +0300, Dan Carpenter wrote:
On Tue, Jan 31, 2012 at 12:12:20AM +0100, Víctor Manuel Jáquez Leal wrote:
Silence the warning when compiling drv_interface.c
Signed-off-by: Víctor
On Tue, Jan 31, 2012 at 12:09:17PM -0600, Omar Ramirez Luna wrote:
On Tue, Jan 31, 2012 at 2:17 AM, Dan Carpenter dan.carpen...@oracle.com
wrote:
On Mon, Jan 30, 2012 at 07:20:17PM -0600, Omar Ramirez Luna wrote:
There are two members of pr_ctxt allocated during bridge_open that
are never
On Tue, Jan 31, 2012 at 12:19:00PM -0600, Ramirez Luna, Omar wrote:
On Tue, Jan 31, 2012 at 2:21 AM, Dan Carpenter dan.carpen...@oracle.com
wrote:
On Mon, Jan 30, 2012 at 07:20:18PM -0600, Omar Ramirez Luna wrote:
This structure is still used after it has been freed, since it
is being
On Tue, Jan 31, 2012 at 09:39:00PM +0200, Felipe Contreras wrote:
On Tue, Jan 31, 2012 at 8:43 PM, Dan Carpenter dan.carpen...@oracle.com
wrote:
How often do people rmmod things on a production system? Hopefully,
never right?
That's right... At least in recent versions
We always return zero instead of the id we found.
Signed-off-by: Dan Carpenter dan.carpen...@oracle.com
---
I don't have this hardware so it's not tested.
diff --git a/drivers/usb/dwc3/core.c b/drivers/usb/dwc3/core.c
index 7c9df63..73df745 100644
--- a/drivers/usb/dwc3/core.c
+++ b/drivers/usb
message and handle the condition
instead of printing a stack dump? The user should be triggering
stack dumps. What on earth?
regards,
dan carpenter
signature.asc
Description: Digital signature
On Fri, Feb 10, 2012 at 09:42:32PM +0200, Felipe Contreras wrote:
On Fri, Feb 10, 2012 at 8:00 PM, Dan Carpenter dan.carpen...@oracle.com
wrote:
On Fri, Feb 10, 2012 at 01:30:48AM +0200, Felipe Contreras wrote:
It's not an oops, it's a warning, and again, it depends on the
firmware being
We added another kind of plane in 66a0f9e4ac OMAPDSS: Use WB fifo for
GFX overlay so this array needs a new entry as well.
Signed-off-by: Dan Carpenter dan.carpen...@oracle.com
---
Static checker work. I don't have a way to test this.
diff --git a/drivers/video/omap2/dss/dispc.c b/drivers/video
(). Anything higher than
OMAP_DSS_WB will trigger a BUG() in DISPC_FIR_COEF_H_OFFSET().
So it's not rock hard logic at all.
regards,
dan carpenter
--
To unsubscribe from this list: send the line unsubscribe linux-omap in
the body of a message to majord...@vger.kernel.org
More majordomo info at http
.
regards,
dan carpenter
--
To unsubscribe from this list: send the line unsubscribe linux-omap in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
On Mon, Jan 21, 2013 at 10:25:24AM +0300, Dan Carpenter wrote:
On Thu, Jan 17, 2013 at 04:47:46PM -0800, Greg Kroah-Hartman wrote:
On Thu, Jan 10, 2013 at 03:36:57AM -0600, Omar Ramirez Luna wrote:
Patches for staging-next, fixing comments and suggestions provided
by Chen Gang
);
omap_bandgap_writel(bg_ptr, r, reg);
}
It's called like:
rmw_bits(bg_ptr, tsr-bgap_mask_ctrl, tsr-mask_freeze_mask, 1);
regards,
dan carpenter
--
To unsubscribe from this list: send the line unsubscribe linux-omap in
the body of a message to majord...@vger.kernel.org
More majordomo info at http
is misleading and annoying.
regards,
dan carpenter
--
To unsubscribe from this list: send the line unsubscribe linux-omap in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
On Fri, Mar 15, 2013 at 09:00:10AM -0400, Eduardo Valentin wrote:
Follow Documentation/CodingStyle while doing omap_bandgap_adc_to_mcelsius.
Someone should probably fix CodingStyle to be more clear. That's
not what was intended at all... :/
regards,
dan carpenter
--
To unsubscribe from
it's misleading when it doesn't do
anything. It's simpler if the code is simple.
regards,
dan carpenter
--
To unsubscribe from this list: send the line unsubscribe linux-omap in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
:
return 0;
}
The bunny hop has introduced a bug and this always returns success.
regards,
dan carpenter
--
To unsubscribe from this list: send the line unsubscribe linux-omap in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
, int val,
if (ret 0)
goto exit;
- mutex_lock(bg_ptr-bg_mutex);
+ spin_lock(bg_ptr-lock);
These need to disable interrupts because we take the spin lock in
the IRQ handler.
regards,
dan carpenter
--
To unsubscribe from this list: send the line unsubscribe linux
patch 33 and 47? You should probably be able to
redo those without changing the rest.
regards,
dan carpenter
--
To unsubscribe from this list: send the line unsubscribe linux-omap in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
On Sat, Mar 16, 2013 at 08:39:11AM -0400, Eduardo Valentin wrote:
Hey Dan,
On 15-03-2013 17:22, Dan Carpenter wrote:
On Fri, Mar 15, 2013 at 08:59:57AM -0400, Eduardo Valentin wrote:
Change the way the omap_bandgap_power is written so that it has only
one exit entry (Documentation
On Sat, Mar 16, 2013 at 08:49:20AM -0400, Eduardo Valentin wrote:
On 16-03-2013 04:39, Dan Carpenter wrote:
On Fri, Mar 15, 2013 at 09:00:21AM -0400, Eduardo Valentin wrote:
if (ret) {
dev_err(bg_ptr-dev, failed to read thot\n);
- return -EIO;
+ ret = -EIO
rmw_bits. And for that you need the sensor index.
No. I'm suggesting that you re-write the driver to pass the tsr
pointer directly instead of the index.
regards,
dan carpenter
--
To unsubscribe from this list: send the line unsubscribe linux-omap in
the body of a message to majord
On Sat, Mar 16, 2013 at 08:41:30AM -0400, Eduardo Valentin wrote:
On 16-03-2013 04:59, Dan Carpenter wrote:
On Fri, Mar 15, 2013 at 09:00:35AM -0400, Eduardo Valentin wrote:
@@ -502,9 +504,9 @@ int _omap_bandgap_write_threshold(struct omap_bandgap
*bg_ptr, int id, int val,
if (ret 0
Thanks.
Acked-by: Dan Carpenter dan.carpen...@orcle.com
regards,
dan carpenter
--
To unsubscribe from this list: send the line unsubscribe linux-omap in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
an idiot.
regards,
dan carpenter
--
To unsubscribe from this list: send the line unsubscribe linux-omap in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
-off-by line so that git am
doesn't include the diff stat in the changelog.
regards,
dan carpenter
--
To unsubscribe from this list: send the line unsubscribe linux-omap in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
On Mon, Mar 18, 2013 at 03:38:38PM -0400, Eduardo Valentin wrote:
On 18-03-2013 15:16, Dan Carpenter wrote:
On Mon, Mar 18, 2013 at 10:59:10AM -0400, Eduardo Valentin wrote:
Even if the IRQ is not firing because it is ONE_SHOT and disable
at INTC level, the IRQ handler must use
These look nice. Thanks for breaking up the move and api rename
into separate patches.
regards,
dan carpenter
--
To unsubscribe from this list: send the line unsubscribe linux-omap in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo
ret needs to be signed for the error handling to work.
Signed-off-by: Dan Carpenter dan.carpen...@oracle.com
---
I can't compile this.
diff --git a/drivers/usb/phy/phy-omap-usb2.c b/drivers/usb/phy/phy-omap-usb2.c
index 844ab68..d266861 100644
--- a/drivers/usb/phy/phy-omap-usb2.c
+++ b/drivers
'!' has higher precedence than '' so this doesn't work as intended
although since RESETDONE is 1 it would work if none of the other bits
are set.
Signed-off-by: Dan Carpenter dan.carpen...@oracle.com
---
Untested.
diff --git a/drivers/mmc/host/omap_hsmmc.c b/drivers/mmc/host/omap_hsmmc.c
index
dispc_set_tv_pclk(t-timings.pixel_clock * 1000);
^^
Patch added a dereference.
673
674 mutex_unlock(hdmi.lock);
regards,
dan carpenter
--
To unsubscribe from this list: send the line unsubscribe linux-omap in
the body of a message
/* Disable wakeup behavior */
590 if (mcbsp-pdata-has_wakeup)
Patch introduces an unchecked dereference.
591 MCBSP_WRITE(mcbsp, WAKEUPEN, 0);
592
regards,
dan carpenter
--
To unsubscribe from this list: send the line
-state_counter[pwrdm-state] = 1;
regards,
dan carpenter
--
To unsubscribe from this list: send the line unsubscribe linux-omap in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
err_free_mem_region:
1468 release_mem_region(res-start, resource_size(res));
^^
Existing unchecked dereferences.
1469 return ret;
1470 }
regards,
dan carpenter
--
To unsubscribe from this list: send the line unsubscribe linux
On Thu, Aug 22, 2013 at 08:16:28PM +0530, Balaji T K wrote:
On Thursday 22 August 2013 06:26 PM, Dan Carpenter wrote:
'!' has higher precedence than '' so this doesn't work as intended
although since RESETDONE is 1 it would work if none of the other bits
are set.
Hi Dan,
Thanks
Static checkers complain that testing for both next and !next is
duplicative.
Signed-off-by: Dan Carpenter dan.carpen...@oracle.com
diff --git a/drivers/mmc/host/omap_hsmmc.c b/drivers/mmc/host/omap_hsmmc.c
index 2a629fbde613..bfb0dbd052c0 100644
--- a/drivers/mmc/host/omap_hsmmc.c
+++ b/drivers
The of_get_hsmmc_pdata() function returns NULL on error, it doesn't
return ERR_PTRs.
Signed-off-by: Dan Carpenter dan.carpen...@oracle.com
diff --git a/drivers/mmc/host/omap_hsmmc.c b/drivers/mmc/host/omap_hsmmc.c
index bfb0dbd052c0..76dbc7b759c2 100644
--- a/drivers/mmc/host/omap_hsmmc.c
+++ b
.
570 of_property_read_u32(np, ram-bits, (u32
*)config-ram_bits);
571 of_property_read_u32(np, power, (u32 *)pdata-power);
regards,
dan carpenter
--
To unsubscribe from this list: send the line unsubscribe linux-omap in
the body of a message to majord
ret should be signed. It's only used for zero and negative error
codes.
Signed-off-by: Dan Carpenter dan.carpen...@oracle.com
diff --git a/drivers/usb/dwc3/dwc3-omap.c b/drivers/usb/dwc3/dwc3-omap.c
index ef4936f..9dcfbe7 100644
--- a/drivers/usb/dwc3/dwc3-omap.c
+++ b/drivers/usb/dwc3/dwc3
left 2 */
734 REG_FLD_MOD(base, HDMI_CORE_FC_AUDSCHNLS(6), 5, 3, 0);
735 /* Channel number left 3*/
regards,
dan carpenter
--
To unsubscribe from this list: send the line unsubscribe linux-omap in
the body of a message to majord...@vger.kernel.org
More majordomo info at http
The regulator_disable() doesn't accept NULL pointers.
Signed-off-by: Dan Carpenter dan.carpen...@oracle.com
diff --git a/drivers/video/fbdev/omap2/dss/pll.c
b/drivers/video/fbdev/omap2/dss/pll.c
index 50bc62c5..335ffac 100644
--- a/drivers/video/fbdev/omap2/dss/pll.c
+++ b/drivers/video/fbdev
The WARN() macro has to take a condition. The current code will just
print the stack trace and the function name instead of the intended
warning message.
Signed-off-by: Dan Carpenter <dan.carpen...@oracle.com>
diff --git a/drivers/video/fbdev/omap2/dss/dss.h
b/drivers/video/fbdev/oma
ble. It's useful on by
itself. I always put the person who wrote the original patch in the To:
header so they can review and comment if I have made a mistake.
regards,
dan carpenter
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
DSI_IRQ_SYNC_LOST was ORed twice so we can remove one.
Signed-off-by: Dan Carpenter <dan.carpen...@oracle.com>
diff --git a/drivers/video/fbdev/omap2/dss/dsi.c
b/drivers/video/fbdev/omap2/dss/dsi.c
index b3606de..e86df6d 100644
--- a/drivers/video/fbdev/omap2/dss/dsi.c
+++ b/drivers/video
54 matches
Mail list logo
