Hi Vitaly,
On Tue, Aug 3, 2010 at 5:17 PM, Vitaly Wool vitalyw...@gmail.com wrote:
On Mon, Aug 2, 2010 at 11:35 PM, Ohad Ben-Cohen o...@wizery.com wrote:
I'm honestly trying to understand your concerns, but I'm afraid that
just saying it's a hack is not too informative. Can you please
explain
On Wed, Aug 4, 2010 at 2:41 PM, Russell King - ARM Linux
li...@arm.linux.org.uk wrote:
On Wed, Aug 04, 2010 at 02:24:39PM +0300, Ohad Ben-Cohen wrote:
On Tue, Aug 3, 2010 at 5:17 PM, Vitaly Wool vitalyw...@gmail.com wrote:
On Mon, Aug 2, 2010 at 11:35 PM, Ohad Ben-Cohen o...@wizery.com wrote
On Fri, Aug 6, 2010 at 10:07 AM, Linus Walleij
linus.ml.wall...@gmail.com wrote:
2010/8/4 Ohad Ben-Cohen o...@wizery.com:
On Wed, Aug 4, 2010 at 2:41 PM, Russell King - ARM Linux
Why not arrange for a small piece of code to be built into the kernel
when this driver is selected as a module
Hi Hiroshi,
On Mon, Jun 14, 2010 at 7:51 PM, Fernando Guzman Lugo x0095...@ti.com wrote:
As pointed by Ben Ohand, the variable rq_full flag is a global
variable, so if there are multiple mailbox users there will be
conflics. Now there is a full flag per mailbox queue.
Reported-by: Ohad Ben
Hi Rene,
On Wed, Jun 9, 2010 at 8:38 AM, Guzman Lugo, Fernando
fernando.l...@ti.com wrote:
On Tue, Jun 8, 2010 at 7:16 PM, Sapiens, Rene rene.sapi...@ti.com wrote:
In mbox_rx_work() you are removing the lines that enable back the mbox irq
for the RX case, but inside __mbox_rx_interrupt()
On Tue, Aug 10, 2010 at 6:00 PM, Sapiens, Rene rene.sapi...@ti.com wrote:
Hi Ohad,
Sure I will do it.
Thanks a lot, Rene !
Ohad.
Regards,
Rene
-Original Message-
From: Ohad Ben-Cohen [mailto:o...@wizery.com]
Sent: Tuesday, August 10, 2010 9:43 AM
To: Guzman Lugo, Fernando
On Tue, Jul 6, 2010 at 8:42 PM, Nicolas Pitre n...@fluxnic.net wrote:
Another function pair would be needed instead, which would do almost
like the suspend/resume code is already doing. Something like:
/*
* Indicate to the core SDIO layer that we're not requiring that the
* function
)
Patches are based on linux-next (as of Aug 7th), and tested
on ZOOM2.
Please note that I am going to have a very limited email access
in the next three weeks, so I might not respond right away.
Thanks,
Ohad Ben-Cohen (9):
wireless: wl1271: make wl12xx.h common to both spi and sdio
wireless: wl1271
Move wl12xx.h outside of the spi-specific location,
so it can be shared with both spi and sdio solutions.
Signed-off-by: Ohad Ben-Cohen o...@wizery.com
---
drivers/net/wireless/wl12xx/wl1251_sdio.c |2 +-
drivers/net/wireless/wl12xx/wl1251_spi.c |2 +-
drivers/net/wireless/wl12xx
Make it possible for the set power method to indicate a
success/failure return value. This is needed to support
more complex power on/off operations such as bringing up
(and down) sdio functions.
Signed-off-by: Ohad Ben-Cohen o...@wizery.com
---
drivers/net/wireless/wl12xx/wl1271.h |2
Remove the hard coded irq information, and instead take
the irq information from the board's platform data.
Signed-off-by: Ohad Ben-Cohen o...@wizery.com
---
drivers/net/wireless/wl12xx/wl1271_sdio.c | 18 +-
1 files changed, 9 insertions(+), 9 deletions(-)
diff --git
The wl1271 device is using a reference clock that may change
between board to board.
Make the ref_clock parameter configurable by the board
files that set up the device, instead of having a hard coded
value in the driver source itself.
Signed-off-by: Ohad Ben-Cohen o...@wizery.com
---
drivers
Make this go away:
drivers/mmc/host/omap_hsmmc.c: In function 'omap_hsmmc_suspend':
drivers/mmc/host/omap_hsmmc.c:2328: warning: unused variable 'state'
Signed-off-by: Ohad Ben-Cohen o...@wizery.com
---
drivers/mmc/host/omap_hsmmc.c |1 -
1 files changed, 0 insertions(+), 1 deletions
Add a fixed regulator vmmc device to enable power control
of the wl1271 wlan device.
Signed-off-by: Ohad Ben-Cohen o...@wizery.com
---
arch/arm/mach-omap2/board-zoom-peripherals.c | 35 ++
1 files changed, 35 insertions(+), 0 deletions(-)
diff --git a/arch/arm/mach
Prepare for mmc3 regulator power control by splitting the power
control functions of mmc2 and mmc3, and expecting mmc3 to have
a single, dedicated, regulator support.
Signed-off-by: Ohad Ben-Cohen o...@wizery.com
---
arch/arm/mach-omap2/hsmmc.c | 10 --
drivers/mmc/host/omap_hsmmc.c
Add MMC3 support on ZOOM, which has the wl1271 device hardwired to.
The wl1271 is a 4-wire, 1.8V, embedded SDIO WLAN device with an
external IRQ line, and power-controlled by a GPIO-based fixed regulator.
Signed-off-by: Ohad Ben-Cohen o...@wizery.com
---
arch/arm/mach-omap2/board-zoom
Dynamically create and register a platform driver, that will
be used to to receive board-specific information like irq and
reference clock numbers.
The driver is created dynamically in order to avoid the 1-device
limitation of a fixed platform driver name.
Signed-off-by: Ohad Ben-Cohen o
On Wed, Aug 11, 2010 at 12:55 PM, Adrian Hunter adrian.hun...@nokia.com wrote:
Ohad Ben-Cohen wrote:
Make this go away:
drivers/mmc/host/omap_hsmmc.c: In function 'omap_hsmmc_suspend':
drivers/mmc/host/omap_hsmmc.c:2328: warning: unused variable 'state'
Was done a while ago.
Are you sure
On Wed, Aug 11, 2010 at 1:52 PM, Roger Quadros roger.quad...@nokia.com wrote:
On 08/11/2010 01:05 PM, Hunter Adrian (Nokia-MS/Helsinki) wrote:
Ohad Ben-Cohen wrote:
Prepare for mmc3 regulator power control by splitting the power
control functions of mmc2 and mmc3, and expecting mmc3 to have
On Wed, Aug 11, 2010 at 12:01 PM, Roger Quadros roger.quad...@nokia.com wrote:
Also shouldn't .nonremovable be set to true? as this is a non-removable card
slot.
This doesn't seem to have any effect on SDIO, but it can't hurt.
Thanks!
regards,
-roger
--
To unsubscribe from this list:
On Wed, Aug 11, 2010 at 11:37 AM, Roger Quadros roger.quad...@nokia.com wrote:
+ .ocr_mask = MMC_VDD_165_195,
Do we really need to specify ocr_mask here?
Removed, thanks!
--
To unsubscribe from this list: send the line unsubscribe linux-omap in
the body of a message to
On Wed, Aug 11, 2010 at 1:05 PM, Adrian Hunter adrian.hun...@nokia.com wrote:
Ohad Ben-Cohen wrote:
Prepare for mmc3 regulator power control by splitting the power
control functions of mmc2 and mmc3, and expecting mmc3 to have
a single, dedicated, regulator support.
Why? Can't
Move wl12xx.h outside of the spi-specific location,
so it can be shared with both spi and sdio solutions.
Signed-off-by: Ohad Ben-Cohen o...@wizery.com
---
drivers/net/wireless/wl12xx/wl1251_sdio.c |2 +-
drivers/net/wireless/wl12xx/wl1251_spi.c |2 +-
drivers/net/wireless/wl12xx
Make it possible for the set power method to indicate a
success/failure return value. This is needed to support
more complex power on/off operations such as bringing up
(and down) sdio functions.
Signed-off-by: Ohad Ben-Cohen o...@wizery.com
---
drivers/net/wireless/wl12xx/wl1271.h |2
Dynamically create and register a platform driver, that will
be used to to receive board-specific information like irq and
reference clock numbers.
The driver is created dynamically in order to avoid the 1-device
limitation of a fixed platform driver name.
Signed-off-by: Ohad Ben-Cohen o
Remove the hard coded irq information, and instead take
the irq information from the board's platform data.
Signed-off-by: Ohad Ben-Cohen o...@wizery.com
---
drivers/net/wireless/wl12xx/wl1271_sdio.c | 18 +-
1 files changed, 9 insertions(+), 9 deletions(-)
diff --git
The wl1271 device is using a reference clock that may change
between board to board.
Make the ref_clock parameter configurable by the board
files that set up the device, instead of having a hard coded
value in the driver source itself.
Signed-off-by: Ohad Ben-Cohen o...@wizery.com
---
drivers
Make this go away:
drivers/mmc/host/omap_hsmmc.c: In function 'omap_hsmmc_suspend':
drivers/mmc/host/omap_hsmmc.c:2328: warning: unused variable 'state'
Signed-off-by: Ohad Ben-Cohen o...@wizery.com
---
drivers/mmc/host/omap_hsmmc.c |1 -
1 files changed, 0 insertions(+), 1 deletions
Add a fixed regulator vmmc device to enable power control
of the wl1271 wlan device.
Signed-off-by: Ohad Ben-Cohen o...@wizery.com
---
arch/arm/mach-omap2/board-zoom-peripherals.c | 35 ++
1 files changed, 35 insertions(+), 0 deletions(-)
diff --git a/arch/arm/mach
Add MMC3 support on ZOOM, which has the wl1271 device hardwired to.
The wl1271 is a 4-wire, 1.8V, embedded SDIO WLAN device with an
external IRQ line, and power-controlled by a GPIO-based fixed regulator.
Signed-off-by: Ohad Ben-Cohen o...@wizery.com
---
arch/arm/mach-omap2/board-zoom
Hi Felipe,
On Wed, Aug 11, 2010 at 9:47 PM, Felipe Balbi felipe.ba...@nokia.com wrote:
+ pdata = pdev-dev.platform_data;
+ if (!pdata) {
+ wl1271_error(no platform data);
+ return -ENODEV;
+ }
+
+ pdriver = container_of(pdev-dev.driver,
Hi Kishore,
On Wed, Aug 11, 2010 at 11:09 PM, kishore kadiyala
kishorek.kadiy...@gmail.com wrote:
Since you specified the voltage source is fixed, and if MMC3 has any
dedicated regulator as MMC1 MMC2 you can go with
Roger's comments.
You are reading an old batch of the patches.
Scroll down
To: DebBarma, Tarun Kanti
Cc: Balbi Felipe (Nokia-MS/Helsinki); Ohad Ben-Cohen; linux-
wirel...@vger.kernel.org; linux-...@vger.kernel.org; linux-
o...@vger.kernel.org; Ido Yariv; Mark Brown; linux-arm-
ker...@lists.infradead.org; Chikkature Rajashekar, Madhusudhan; Coelho
Luciano (Nokia-MS
Hi Vitaly,
On Thu, Aug 12, 2010 at 12:34 AM, Vitaly Wool vitalyw...@gmail.com wrote:
On Wed, Aug 11, 2010 at 10:10 PM, Ohad Ben-Cohen o...@wizery.com wrote:
Think of several wl1271 devices, each of which is represented by two
devices; an SDIO function, and a platform device. The SDIO function
On Wed, Aug 11, 2010 at 9:35 PM, DebBarma, Tarun Kanti
tarun.ka...@ti.com wrote:
- wl-if_ops-power(wl, true);
- set_bit(WL1271_FLAG_GPIO_POWER, wl-flags);
+ int ret = wl-if_ops-power(wl, true);
Just a minor comment, need a blank line here?
Can't hurt, thanks.
+ if (ret ==
On Thu, Aug 12, 2010 at 12:25 AM, Russell King - ARM Linux
li...@arm.linux.org.uk wrote:
I've outlined a far simpler and easiler solution
which avoids this kind of abuse, and given suggestions on how to extend
it to support multiple instances.
Do you mean:
On Thursday, August 12, 2010, Russell King - ARM Linux
li...@arm.linux.org.uk wrote:
On Thu, Aug 12, 2010 at 09:40:19AM +0300, Ohad Ben-Cohen wrote:
On Thu, Aug 12, 2010 at 12:25 AM, Russell King - ARM Linux
li...@arm.linux.org.uk wrote:
I've outlined a far simpler and easiler solution
which
King. Currently only a single device is
supported; multi-device support will be introduced only when/if required
Patches are based on 2.6.36-rc3 and tested on ZOOM3.
Thanks,
Ohad Ben-Cohen (7):
wireless: wl1271: make wl12xx.h common to both spi and sdio
wireless: wl1271: support return value
Move wl12xx.h outside of the spi-specific location,
so it can be shared with both spi and sdio solutions.
Signed-off-by: Ohad Ben-Cohen o...@wizery.com
---
drivers/net/wireless/wl12xx/wl1251_sdio.c |2 +-
drivers/net/wireless/wl12xx/wl1251_spi.c |2 +-
drivers/net/wireless/wl12xx
Make it possible for the set power method to indicate a
success/failure return value. This is needed to support
more complex power on/off operations such as bringing up
(and down) sdio functions.
Signed-off-by: Ohad Ben-Cohen o...@wizery.com
---
drivers/net/wireless/wl12xx/wl1271.h |2
Add a simple mechanism to pass platform data to the
SDIO instances of wl12xx.
This way there is no confusion over who owns the 'embedded data',
typechecking is preserved, and no possibility for the wrong driver to
pick up the data.
Originally proposed by Russell King.
Signed-off-by: Ohad Ben
Remove the hard coded irq information, and instead take
the irq information from the board's platform data.
Signed-off-by: Ohad Ben-Cohen o...@wizery.com
---
drivers/net/wireless/wl12xx/wl1271_sdio.c | 14 +++---
1 files changed, 7 insertions(+), 7 deletions(-)
diff --git a/drivers
The wl1271 device is using a reference clock that may change
between board to board.
Make the ref_clock parameter configurable by the board
files that set up the device, instead of having a hard coded
value in the driver source itself.
Signed-off-by: Ohad Ben-Cohen o...@wizery.com
---
drivers
Add MMC3 support on ZOOM, which is hardwired to the wl1271 device.
The wl1271 is a 4-wire, 1.8V, embedded SDIO WLAN device with an
external IRQ line, and power-controlled by a GPIO-based fixed regulator.
Signed-off-by: Ohad Ben-Cohen o...@wizery.com
---
arch/arm/mach-omap2/board-zoom
Add a fixed regulator vmmc device to enable power control
of the wl1271 wlan device.
Signed-off-by: Ohad Ben-Cohen o...@wizery.com
---
arch/arm/mach-omap2/board-zoom-peripherals.c | 35 ++
1 files changed, 35 insertions(+), 0 deletions(-)
diff --git a/arch/arm/mach
2010/9/6 Michał Mirosław mir...@gmail.com:
W dniu 6 września 2010 14:07 użytkownik Russell King - ARM Linux
li...@arm.linux.org.uk napisał:
On Sat, Sep 04, 2010 at 02:23:19PM +0200, Michał Mirosław wrote:
2010/9/1 Ohad Ben-Cohen o...@wizery.com:
Add a simple mechanism to pass platform data
On Wed, Sep 1, 2010 at 11:26 PM, Ohad Ben-Cohen o...@wizery.com wrote:
This patchset adds wl1271 support on ZOOM2/3 boards.
Tony, John, let me please suggest merging this through the wireless tree.
wl1271 is a moving target - it keeps changing in the wireless tree and
merging this patchset
On Wed, Sep 15, 2010 at 6:34 PM, Tony Lindgren t...@atomide.com wrote:
* John W. Linville linvi...@tuxdriver.com [100915 06:21]:
On Wed, Sep 15, 2010 at 01:08:18PM +0200, Vitaly Wool wrote:
On Wed, Sep 15, 2010 at 11:21 AM, Ohad Ben-Cohen o...@wizery.com wrote:
On Wed, Sep 1, 2010 at 11:26
This patchset adds wl1271 support on ZOOM2/3 boards.
Only basic support is included; power manipulation is submitted separately as
SDIO Runtime PM support.
Changes since v5:
- rebase to wireless-testing
- remove 2nd copy from wl12xx_platform_data (keep the 1st one though)
Thanks,
Ohad Ben
Remove the hard coded irq information, and instead take
the irq information from the board's platform data.
Signed-off-by: Ohad Ben-Cohen o...@wizery.com
---
drivers/net/wireless/wl12xx/wl1271_sdio.c | 15 ---
1 files changed, 8 insertions(+), 7 deletions(-)
diff --git a/drivers
The wl1271 device is using a reference clock that may change
between board to board.
Make the ref_clock parameter configurable by board settings
instead of having a hard coded value in the sources.
Signed-off-by: Ohad Ben-Cohen o...@wizery.com
---
drivers/net/wireless/wl12xx/wl1271.h
Add a fixed regulator vmmc device to enable power control
of the wl1271 wlan device.
Signed-off-by: Ohad Ben-Cohen o...@wizery.com
---
arch/arm/mach-omap2/board-zoom-peripherals.c | 35 ++
1 files changed, 35 insertions(+), 0 deletions(-)
diff --git a/arch/arm/mach
Add MMC3 support on ZOOM, which has the wl1271 device hardwired to.
The wl1271 is a 4-wire, 1.8V, embedded SDIO WLAN device with an
external IRQ line, and power-controlled by a GPIO-based fixed regulator.
Signed-off-by: Ohad Ben-Cohen o...@wizery.com
---
arch/arm/mach-omap2/board-zoom
On Thu, Sep 16, 2010 at 12:17 PM, Teemu Paasikivi
ext-teemu.3.paasik...@nokia.com wrote:
On Thu, 2010-09-16 at 01:22 +0200, ext Ohad Ben-Cohen wrote:
Move wl12xx.h outside of the spi-specific location,
so it can be shared with both spi and sdio solutions.
Signed-off-by: Ohad Ben-Cohen o
Move wl12xx.h outside of the spi-specific location,
so it can be shared with both spi and sdio solutions.
Update all users of spi/wl12xx.h accordingly
Signed-off-by: Ohad Ben-Cohen o...@wizery.com
---
MAINTAINERS |2 +-
arch/arm/mach-omap2/board
Hi John,
On Thu, Sep 16, 2010 at 1:16 PM, Ohad Ben-Cohen o...@wizery.com wrote:
Move wl12xx.h outside of the spi-specific location,
so it can be shared with both spi and sdio solutions.
Update all users of spi/wl12xx.h accordingly
Signed-off-by: Ohad Ben-Cohen o...@wizery.com
On Thu, Sep 16, 2010 at 7:44 PM, Tony Lindgren t...@atomide.com wrote:
These are usually aligned with tabs before the = sign.
Fixed.
Acked-by: Tony Lindgren t...@atomide.com
Thanks, Tony.
--
To unsubscribe from this list: send the line unsubscribe linux-omap in
the body of a message to
On Thu, Sep 16, 2010 at 9:40 PM, Luciano Coelho
luciano.coe...@nokia.com wrote:
+ int ret = wl-if_ops-power(wl, true);
I think it look nicer if you keep the int ret in one line by itself
and then do a ret = wl-if_ops... on another one.
Fixed.
+static int wl1271_sdio_power_on(struct
On Thu, Sep 16, 2010 at 8:35 PM, Luciano Coelho
luciano.coe...@nokia.com wrote:
Acked-by: Luciano Coelho luciano.coe...@nokia.com
I just wonder why the wl12xx.h move wasn't detected as a rename. Did
you forget to use the -M option in format-patch?
I thought it's because I stripped the SPI_
Hi Hari,
On Thu, Aug 12, 2010 at 12:44 AM, Kanigeri, Hari h-kanige...@ti.com wrote:
+/* Attempt to acquire a spinlock once */
+int hwspinlock_trylock(struct hwspinlock *handle)
+{
+ int retval = 0;
+
+ if (WARN_ON(handle == NULL))
+ return -EINVAL;
+
+
On Thu, Sep 23, 2010 at 2:20 PM, Felipe Balbi ba...@ti.com wrote:
Hi Luca,
On Thu, Sep 23, 2010 at 07:17:33AM -0500, Luciano Coelho wrote:
On Thu, 2010-09-23 at 13:45 +0200, ext Felipe Balbi wrote:
On Thu, Sep 23, 2010 at 03:20:03AM -0500, Luciano Coelho wrote:
static struct mtd_partition
On Fri, Oct 1, 2010 at 10:33 PM, Anand Gadiyar gadi...@ti.com wrote:
Fix this build break when CONFIG_WL12XX_PLATFORM_DATA is not set.
A similar fix was already submitted and is pending to be merged
(http://permalink.gmane.org/gmane.linux.kernel.wireless.general/56595)
There are still many
On Sat, Oct 2, 2010 at 1:02 AM, Anand Gadiyar gadi...@ti.com wrote:
I picked up your patch and the warnings are gone. The key difference
was I missed marking the alternative function as an inline.
Ok, thanks for the update.
Without that, I was seeing warnings like these:
On Mon, Oct 4, 2010 at 2:20 PM, G, Manjunath Kondaiah manj...@ti.com wrote:
Can you post complete boot log? so far, it failed on one blaze and
one 3430sdp both of them are having es2.0
Sure:
wizery.com/ohad/blaze-linux-omap.txt.gz
Summary of my setup:
- Blaze ES2.0
- linux-omap-2.6 master
On Mon, Oct 4, 2010 at 9:49 AM, G, Manjunath Kondaiah manj...@ti.com wrote:
Booting with zoom3 seems to be fine but observed issues with omap4 blaze
board.
FWIW, for me it worked just fine with blaze
--
To unsubscribe from this list: send the line unsubscribe linux-omap in
the body of a
On Mon, Oct 4, 2010 at 2:13 PM, G, Manjunath Kondaiah manj...@ti.com wrote:
ES2.0 or ES1.0?
2.0
-Manjunath
--
To unsubscribe from this list: send the line unsubscribe linux-omap in
the body of a message to majord...@vger.kernel.org
More majordomo info at
On Mon, Oct 4, 2010 at 2:52 PM, G, Manjunath Kondaiah manj...@ti.com wrote:
Remove nosmp from your bootargs and try.
Indeed, it doesn't boot.
wizery.com/ohad/blaze-linux-omap-smp.txt.gz
-Manjunath
--
To unsubscribe from this list: send the line unsubscribe linux-omap in
the body of a
Hi Sanjay,
On Wed, Oct 13, 2010 at 12:57 PM, csan...@mistralsolutions.com wrote:
Sanjay Kumar Champati (5):
ARM: Supported MMC 2 features for OMAP3EVM
ARM: Supported for Standard SDIO driver on OMAP3EVM for WL1271 DC
ARM: Supported for BT enable on OMAP3EVM for WL1271 DC
ARM: Added ALSA
OMAP4 introduces a Spinlock hardware module, which provides hardware
assistance for synchronization and mutual exclusion between heterogeneous
processors and those not operating under a single, shared operating system
(e.g. OMAP4 has dual Cortex-A9, dual Cortex-M3 and a C64x+ DSP).
The intention
to drivers/misc, general cleanups, document]
Signed-off-by: Ohad Ben-Cohen o...@wizery.com
Cc: Benoit Cousson b-cous...@ti.com
Cc: Tony Lindgren t...@atomide.com
---
Documentation/misc-devices/omap_hwspinlock.txt | 199 +
drivers/misc/Kconfig | 10 +
drivers/misc
From: Benoit Cousson b-cous...@ti.com
Add hwspinlock hwmod data for OMAP4 chip
Signed-off-by: Cousson, Benoit b-cous...@ti.com
Signed-off-by: Hari Kanigeri h-kanige...@ti.com
Signed-off-by: Ohad Ben-Cohen o...@wizery.com
Cc: Paul Walmsley p...@pwsan.com
---
arch/arm/mach-omap2
...@ti.com
Signed-off-by: Hari Kanigeri h-kanige...@ti.com
Signed-off-by: Ohad Ben-Cohen o...@wizery.com
Cc: Benoit Cousson b-cous...@ti.com
---
arch/arm/mach-omap2/Makefile |1 +
arch/arm/mach-omap2/hwspinlock.c | 67 ++
2 files changed, 68 insertions
On Mon, Oct 18, 2010 at 3:43 PM, Peter Zijlstra pet...@infradead.org wrote:
Right, so the problem is that there simply is no way to do atomic memory
access from these auxiliary processing units wrt the main CPU?
Yes. There are a few relevant system-wide limitations, one of them is
that simply
On Mon, Oct 18, 2010 at 5:32 PM, Peter Zijlstra pet...@infradead.org wrote:
Sure, but you can 'easily' extend your coherency protocols with support
In our case, there are no coherency protocols supported between the
A9, M3 and the DSP.
--
To unsubscribe from this list: send the line unsubscribe
On Tue, Oct 19, 2010 at 5:46 PM, Greg KH g...@kroah.com wrote:
On Mon, Oct 18, 2010 at 09:44:33AM +0200, Ohad Ben-Cohen wrote:
+#else /* !CONFIG_OMAP_HWSPINLOCK */
+
+static inline struct omap_hwspinlock *omap_hwspinlock_request(void)
+{
+ return ERR_PTR(-ENOSYS);
+}
One note, do you
On Tue, Oct 19, 2010 at 6:58 PM, Kevin Hilman
khil...@deeprootsystems.com wrote:
+ * This spin_trylock_irqsave serves two purposes:
+
+ * 1. Disable local interrupts and preemption, in order to
+ * minimize the period of time in which the hwspinlock
+ * is taken (so
On Tue, Oct 19, 2010 at 7:01 PM, Grant Likely grant.lik...@secretlab.ca wrote:
+ struct omap_hwspinlock *omap_hwspinlock_request(void);
...
ERR_PTR() is only appropriate when the caller actually cares about the
failure code and has different behaviour depending on the result.
Agree; the
On Tue, Oct 19, 2010 at 7:21 PM, Arnd Bergmann a...@arndb.de wrote:
On Monday 18 October 2010 09:44:33 Ohad Ben-Cohen wrote:
+ int omap_hwspin_lock(struct omap_hwspinlock *hwlock, unsigned long
*flags);
...
+ The flags parameter is a pointer to where the interrupts state
On Tue, Oct 19, 2010 at 7:03 PM, Kevin Hilman
khil...@deeprootsystems.com wrote:
+postcore_initcall(hwspinlocks_init);
Any reason this needs to be a postcore_initcall? Are there users of
hwspinlocks this early in boot?
i2c-omap, which is subsys_initcall (the I2C bus is shared between the
A9
On Tue, Oct 19, 2010 at 10:58 PM, Arnd Bergmann a...@arndb.de wrote:
If a hwspinlock is taken over a long period of time, its other user
(with which we try to achieve synchronization) might be polling the
OMAP interconnect for too long (trying to take the hwspinlock) and
thus preventing it to
[resubmitting due to l-o being dropped from this discussion fork.
Thanks Russell for catching this]
On Wed, Oct 20, 2010 at 1:31 AM, Daniel Walker dwal...@codeaurora.org wrote:
On Mon, 2010-10-18 at 09:44 +0200, Ohad Ben-Cohen wrote:
OMAP4 introduces a Spinlock hardware module, which provides
On Tue, Oct 19, 2010 at 7:16 PM, Kevin Hilman
khil...@deeprootsystems.com wrote:
Ohad Ben-Cohen o...@wizery.com writes:
From: Simon Que s...@ti.com
Add driver for OMAP's Hardware Spinlock module.
The OMAP Hardware Spinlock module, initially introduced in OMAP4,
provides hardware assistance
On Wed, Oct 20, 2010 at 1:12 AM, Grant Likely grant.lik...@secretlab.ca wrote:
On Tue, Oct 19, 2010 at 3:02 PM, Ohad Ben-Cohen o...@wizery.com wrote:
...
i2c-omap, which is subsys_initcall (the I2C bus is shared between the
A9 and the M3 on some OMAP4 boards).
...
Man. this is getting ugly. I
On Wed, Oct 20, 2010 at 1:53 AM, Kevin Hilman
khil...@deeprootsystems.com wrote:
And to allow early board code to reserve specific hwspinlock numbers
for predefined use-cases, we probably want to be before arch_initcall.
There's no reason for board code to have to do this at initcall time.
If
On Wed, Oct 20, 2010 at 8:37 PM, Kevin Hilman
khil...@deeprootsystems.com wrote:
Let's take the i2c-omap for example.
It sounds like it must have a predefined hwspinlock, but what if:
1. It will use omap_hwspinlock_request() to dynamically allocate a hwspinlock
2. Obviously, the hwspinlock
On Tue, Oct 19, 2010 at 11:08 PM, Arnd Bergmann a...@arndb.de wrote:
Right. There are two more things to consider though:
If you know that interrupts are disabled, you may still want to avoid
having to save the interrupt flag to the stack, to save some cycles
saving and restoring it. I don't
[removed that bouncing email address we had all along :]
On Thu, Oct 21, 2010 at 1:58 AM, Kevin Hilman
khil...@deeprootsystems.com wrote:
Why would we need platform-specific function pointers here ? I'm not
sure I'm following this one.
So that board code (built-in) does not call the
On Thu, Oct 21, 2010 at 10:36 AM, Kamoolkar, Mugdha mug...@ti.com wrote:
khil...@deeprootsystems.com wrote:
Yes, that would indeed simplify things.
Balaji, Nishant, are you OK with this ?
The problem with this approach is that the i2c driver would have to
sync up on the shared memory
On Thu, Oct 21, 2010 at 11:04 AM, Arnd Bergmann a...@arndb.de wrote:
On Thursday 21 October 2010, Ohad Ben-Cohen wrote:
This sounds like adding a set of API that resembles spin_{unlock,lock}_irq.
My gut feeling here is that while this may be useful and simple at
certain places, it is somewhat
On Fri, Oct 22, 2010 at 11:59 AM, Kamoolkar, Mugdha mug...@ti.com wrote:
From: Ohad Ben-Cohen [mailto:o...@wizery.com]
I agree.
But we seem to have this sort of problem anyway:
...
That is true. Perhaps we should consider adding a software
implementation over HW spinlocks.
Yes
On Mon, Oct 25, 2010 at 9:02 PM, Tony Lindgren t...@atomide.com wrote:
if you feel that (2) is justifiable/desirable, I would be more
than happy to submit that version.
Yes (2) please. I would assume there will be more use of this. And then
we (or probably me again!) don't have to deal with
/gmane.linux.ports.arm.omap/40901
Benoit Cousson (1):
OMAP4: hwmod data: Add hwspinlock
Ohad Ben-Cohen (1):
drivers: hwspinlock: add generic framework
Simon Que (2):
drivers: hwspinlock: add OMAP implementation
omap: add hwspinlock device
Documentation/hwspinlock.txt | 339
/null
+++ b/drivers/hwspinlock/hwspinlock.h
@@ -0,0 +1,61 @@
+/*
+ * Hardware spinlocks internal header
+ *
+ * Copyright (C) 2010 Texas Instruments Incorporated - http://www.ti.com
+ *
+ * Contact: Ohad Ben-Cohen o...@wizery.com
+ *
+ * This program is free software; you can redistribute
From: Benoit Cousson b-cous...@ti.com
Add hwspinlock hwmod data for OMAP4 chip
Signed-off-by: Cousson, Benoit b-cous...@ti.com
Signed-off-by: Hari Kanigeri h-kanige...@ti.com
Signed-off-by: Ohad Ben-Cohen o...@wizery.com
Cc: Paul Walmsley p...@pwsan.com
---
arch/arm/mach-omap2
: adapt to generic hwspinlock api, tidy up]
Signed-off-by: Simon Que s...@ti.com
Signed-off-by: Hari Kanigeri h-kanige...@ti.com
Signed-off-by: Krishnamoorthy, Balaji T balaj...@ti.com
Signed-off-by: Ohad Ben-Cohen o...@wizery.com
Cc: Benoit Cousson b-cous...@ti.com
Cc: Kevin Hilman khil
...@ti.com
Signed-off-by: Hari Kanigeri h-kanige...@ti.com
Signed-off-by: Ohad Ben-Cohen o...@wizery.com
Cc: Benoit Cousson b-cous...@ti.com
Cc: Kevin Hilman khil...@deeprootsystems.com
Cc: Paul Walmsley p...@pwsan.com
---
arch/arm/mach-omap2/Makefile |1 +
arch/arm/mach-omap2/hwspinlock.c
Power to the wl12xx wlan device is controlled by a fixed regulator.
Boards that have the wl12xx should select REGULATOR_FIXED_VOLTAGE so
users will not be baffled.
Signed-off-by: Ohad Ben-Cohen o...@wizery.com
---
arch/arm/mach-omap2/Kconfig |3 +++
1 files changed, 3 insertions(+), 0
On Wed, Nov 24, 2010 at 1:23 AM, Ionut Nicu ionut.n...@mindbit.ro wrote:
At iounmap_base you unmap state-io_base, but that's set only after this
check. You should probably iounmap(io_base).
Of course. Thanks.
Regards,
Ionut.
--
To unsubscribe from this list: send the line unsubscribe
Hi Mugdha,
On Wed, Nov 24, 2010 at 9:44 AM, Kamoolkar, Mugdha mug...@ti.com wrote:
How do multiple clients get a handle that they can use? Are they expected to
share the handle they get from the call above?
Currently, yes.
What if they are independent
clients with no means of communication
On Thu, Nov 25, 2010 at 5:59 AM, David Brownell davi...@pacbell.net wrote:
My rule of thumb is that nothing is generic
until at least three whatever-it-is instances
plug in to it. Sometimes this is called
the Rule of Three.
Other than OMAP, what's providing hardware
spinlocks that plug
1 - 100 of 776 matches
Mail list logo
