On Thursday 26 August 2010 23:56:49 ext G, Manjunath Kondaiah wrote:
From: Manjunatha GK manj...@ti.com
Fixes sparse warning for the below error
drivers/mfd/twl4030-codec.c:118:5: error: symbol
'twl4030_codec_disable_resource' redeclared with different type
(originally declared at
Hi,
this is audio related file, so use the alsa-devel for this patch, and also CC
the maintainers (Jarkko, Liam, Mark, and me).
On Thursday 26 August 2010 23:56:44 ext G, Manjunath Kondaiah wrote:
From: Manjunatha GK manj...@ti.com
This patch fixes sparse warning due non declaration of
McBSP SRG (Sample Rate Generator) and FSG (Frame Sync
Generator) is only needed to be enabled, when McBSP
is master.
In McBSP slave mode, the SRG, and FSG can be kept disabled,
which might save some power at the end in this configuration.
Signed-off-by: Peter Ujfalusi peter.ujfal...@nokia.com
pointer dereference would occur.
Fix this by removing the muxing code and let the bootloader or board file
to do it if necessary. Remove also omap2_mcbsp_ops as there is no use for
it.
Signed-off-by: Jarkko Nikula jhnik...@gmail.com
Sounds reasonable.
Acked-by: Peter Ujfalusi peter.ujfal
Kondaiah manj...@ti.com
Cc: alsa-de...@alsa-project.org
Cc: Jarkko Nikula jhnik...@gmail.com
Cc: Peter Ujfalusi peter.ujfal...@nokia.com
Cc: Liam Girdwood l...@slimlogic.co.uk
Cc: Mark Brown broo...@opensource.wolfsonmicro.com
Cc: Tony Lindgren t...@atomide.com
Cc: Nishanth Menon n...@ti.com
, SPCR1, MCBSP_READ_CACHE(mcbsp_rx, SPCR1));
} else {
- complete(mcbsp_rx-tx_irq_completion);
+ complete(mcbsp_rx-rx_irq_completion);
}
return IRQ_HANDLED;
Acked-by: Peter Ujfalusi peter.ujfal...@nokia.com
--
To unsubscribe from this list: send the line
From: Jarkko Nikula jhnik...@gmail.com
An errata workaround for omap24xx is not setting the buffering disable bit
25 what is the purpose but channel enable bit 7 instead.
Background for this fix is the DMA stalling issue with ASoC omap-mcbsp
driver. Peter Ujfalusi peter.ujfal...@nokia.com has
for OMAP4, but we are not able to verify it.
---
Jarkko Nikula (1):
omap: dma: Fix buffering disable bit setting for omap24xx
Peter Ujfalusi (1):
OMAP3: DMA: Errata: sDMA FIFO draining does not finish
arch/arm/plat-omap/dma.c | 37 ++--
arch/arm
to NoStandby before disabling
the channel, and wait for the drain to finish, than configure sDMA to
SmartStandby again.
Signed-off-by: Peter Ujfalusi peter.ujfal...@nokia.com
---
arch/arm/plat-omap/dma.c | 35 +++-
arch/arm/plat-omap/include/plat/dma.h |3
On Friday 01 October 2010 10:45:12 ext Nishanth Menon wrote:
...
- l = ~OMAP_DMA_CCR_EN;
- dma_write(l, CCR(lch));
+ /* OMAP3 Errata: sDMA FIFO draining does not finish */
would be informative to give the iXYZ id as well for some of these
erratas might scale across processors.
In
On Friday 01 October 2010 12:29:54 ext G, Manjunath Kondaiah wrote:
But yes, it would make the code much more readable, and we
can easily track, which errata has been already addressed.
This is already done as a part of dma hwmod which is under review.
OK, so we shall not bother with this
On Friday 01 October 2010 12:45:47 ext G, Manjunath Kondaiah wrote:
Apologies, but does that mean:
a) the errata i541 is handled as well as part of hwmod series?
No.
b) the patch needs to be ported ontop of hwmod series?
Yes.
I think these fixes should be sent for 2.6.36, and I
From: Jarkko Nikula jhnik...@gmail.com
An errata workaround for omap24xx is not setting the buffering disable bit
25 what is the purpose but channel enable bit 7 instead.
Background for this fix is the DMA stalling issue with ASoC omap-mcbsp
driver. Peter Ujfalusi peter.ujfal...@nokia.com has
to NoStandby before disabling
the channel, and wait for the drain to finish, than configure sDMA to
SmartStandby again.
Signed-off-by: Peter Ujfalusi peter.ujfal...@nokia.com
---
arch/arm/plat-omap/dma.c | 35 +++-
arch/arm/plat-omap/include/plat/dma.h |3
Standby - but this is not
working all the time).
PS: the same errata might exist for OMAP4, but we are not able to verify it.
---
Jarkko Nikula (1):
omap: dma: Fix buffering disable bit setting for omap24xx
Peter Ujfalusi (1):
OMAP3: DMA: Errata: sDMA FIFO draining does not finish
arch/arm
On Friday 01 October 2010 14:50:37 David Cohen wrote:
+ l = sys_cf = dma_read(OCP_SYSCONFIG);
Shouldn't it be avoided?
I'm restoring the OCP_SYSCONFIG register later on, and reusing 'l' here to
avoid
confusing expression when moving the sDMA to NoStandby.
I could as well
On Friday 01 October 2010 15:24:41 ext Felipe Balbi wrote:
I think David is concerned about multiple assigments in one line.
CodingStyle asks to avoid that. So probably:
Yes, I did noticed that after I've sent the reply.
sys_cf = dma_read(OCP_SYSCONFIG);
l = sys_cf;
would make
unrelated sDMA activity (which takes sDMA out from Standby - but this is not
working all the time).
PS: the same errata might exist for OMAP4, but we are not able to verify it.
---
Jarkko Nikula (1):
omap: dma: Fix buffering disable bit setting for omap24xx
Peter Ujfalusi (1):
OMAP3: DMA: Errata
to NoStandby before disabling
the channel, and wait for the drain to finish, than configure sDMA to
SmartStandby again.
Signed-off-by: Peter Ujfalusi peter.ujfal...@nokia.com
Acked-by: Jarkko Nikula jhnik...@gmail.com
---
arch/arm/plat-omap/dma.c | 36
From: Jarkko Nikula jhnik...@gmail.com
An errata workaround for omap24xx is not setting the buffering disable bit
25 what is the purpose but channel enable bit 7 instead.
Background for this fix is the DMA stalling issue with ASoC omap-mcbsp
driver. Peter Ujfalusi peter.ujfal...@nokia.com has
On Friday 01 October 2010 15:17:16 David Cohen wrote:
No problem with those two variables, but you're doing multiple
assignments in one line. You could do something like this:
l = dma_read(OCP_SYSCONFIG);
sys_cf = l;
I have sent the v3 with this fixed.
Thanks you,
Péter
--
To unsubscribe
On Monday 04 October 2010 10:36:16 ext G, Manjunath Kondaiah wrote:
are going to have:
DMA_ERRATA_i541_OMAP2, and DMA_ERRATA_i541_OMAP3 to
For OMAP2, you should use DMA_ERRATA_IFRAME_BUFFERING since it is
different type of issue.
Thanks!
I'll do that.
-Manjunath
--
Péter
--
To
Convert the errata handling of buffering disable on
OMAP2 platforms.
Signed-off-by: Peter Ujfalusi peter.ujfal...@nokia.com
---
arch/arm/plat-omap/dma.c |7 +--
1 files changed, 5 insertions(+), 2 deletions(-)
diff --git a/arch/arm/plat-omap/dma.c b/arch/arm/plat-omap/dma.c
index
/null
CTRL+Z; fg; CTRL+Z; fg; ...
On OMAP2 we can not recover from this problem. The board has to be rebooted,
while OMAP3 can be recovered by reseting the sDMA channel, or introducing
unrelated sDMA activity (which takes sDMA out from Standby - but this is not
working all the time).
---
Peter
On Monday 04 October 2010 11:29:16 ext Peter Ujfalusi wrote:
Hello,
Will resend, since
I'll wait for comments on v4 series, and I'll send the v5 later today after the
comments to reduce the noise.
--
Péter
--
To unsubscribe from this list: send the line unsubscribe linux-omap in
the body
From: ext Jarkko Nikula jhnik...@gmail.com
An errata workaround for omap24xx is not setting the buffering disable bit
25 what is the purpose but channel enable bit 7 instead.
Background for this fix is the DMA stalling issue with ASoC omap-mcbsp
driver. Peter Ujfalusi peter.ujfal...@nokia.com
Use flags for errata handling.
Signed-off-by: Peter Ujfalusi peter.ujfal...@nokia.com
---
arch/arm/plat-omap/dma.c | 10 ++
1 files changed, 10 insertions(+), 0 deletions(-)
diff --git a/arch/arm/plat-omap/dma.c b/arch/arm/plat-omap/dma.c
index 6914ccf..ae0ff64 100644
--- a/arch/arm
On Monday 04 October 2010 12:17:41 ext G, Manjunath Kondaiah wrote:
...
+ /* OMAP3 Errata i541: sDMA FIFO draining does not finish */
This logic is required for multiple erratas.
As Tony requested, I have added a variable for flags to handle the different
erratas. I even added a
Hello,
Will resend, since
On Monday 04 October 2010 11:18:10 ext Peter Ujfalusi wrote:
...
ext Jarkko Nikula (1):
omap: dma: Fix buffering disable bit setting for omap24xx
Our mail server changed Jarkko's name.
Sorry.
--
Péter
--
To unsubscribe from this list: send the line unsubscribe
On Monday 04 October 2010 09:23:18 ext G, Manjunath Kondaiah wrote:
No errata numbers numbers used with TI errata documents till omap2430.
Errata numbers avaialable from omap3430 onwards.
For OMAP3 the errata number is i541, but I do not know the
iXYZ number for OMAP2 class.
Being said
On Monday 04 October 2010 08:55:46 ext G, Manjunath Kondaiah wrote:
2/2 is applicable for all omap2plus except omap4. So far 2/2 workaround is
not used with TI internal trees.
We experimented that also on 2420 and it seemed to help but since the
lockup was unrecovable I went thinking if
to NoStandby before disabling
the channel, and wait for the drain to finish, than configure sDMA to
SmartStandby again.
Signed-off-by: Peter Ujfalusi peter.ujfal...@nokia.com
Acked-by: Jarkko Nikula jhnik...@gmail.com
Acked-by : Santosh Shilimkar santosh.shilim...@ti.com
Acked-by : G, Manjunath
Change the errata handling to use flags instead of cpu_is_*
cpu_class_* in the code.
The errata flags are initialized at init time.
In runtime we are using the dma_errata variable (via the
IS_DMA_ERRATA macro) to execute the required errata workaround.
Signed-off-by: Peter Ujfalusi peter.ujfal
to NoStandby before disabling
the channel, and wait for the drain to finish, than configure sDMA to
SmartStandby again.
Signed-off-by: Peter Ujfalusi peter.ujfal...@nokia.com
Acked-by: Jarkko Nikula jhnik...@gmail.com
Acked-by : Santosh Shilimkar santosh.shilim...@ti.com
Acked-by : G, Manjunath
From: Jarkko Nikula jhnik...@gmail.com
An errata workaround for omap24xx is not setting the buffering disable bit
25 what is the purpose but channel enable bit 7 instead.
Background for this fix is the DMA stalling issue with ASoC omap-mcbsp
driver. Peter Ujfalusi peter.ujfal...@nokia.com has
Peter Ujfalusi (2):
OMAP3: DMA: Errata i541: sDMA FIFO draining does not finish
OMAP: DMA: Use flags for errata handling
arch/arm/plat-omap/dma.c | 88 +
arch/arm/plat-omap/include/plat/dma.h |4 ++
2 files changed, 82 insertions(+), 10
Hello,
I have only one question...
On Saturday 02 October 2010 00:35:32 ext Paul Walmsley wrote:
...
+/* McBSP CLKS source switching function */
+
+int omap2_mcbsp_set_clks_src(u8 id, u8 fck_src_id)
+{
+ struct omap_mcbsp *mcbsp;
+ struct clk *fck_src;
+ char *fck_src_name;
.
If you decide to rebuild, than you can add my (for patch 6-7):
Acked-by: Peter Ujfalusi peter.ujfal...@nokia.com
--
Péter
--
To unsubscribe from this list: send the line unsubscribe linux-omap in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org
On Tuesday 05 October 2010 15:29:35 ext Jarkko Nikula wrote:
It seems these comments where accidentally added so remove them.
Signed-off-by: Jarkko Nikula jhnik...@gmail.com
Cc: Paul Walmsley p...@pwsan.com
Acked-by: Peter Ujfalusi peter.ujfal...@nokia.com
--
To unsubscribe from this list
-by: Jarkko Nikula jhnik...@gmail.com
Cc: Paul Walmsley p...@pwsan.com
Acked-by: Peter Ujfalusi peter.ujfal...@nokia.com
--
To unsubscribe from this list: send the line unsubscribe linux-omap in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo
On Tuesday 05 October 2010 19:37:39 ext Kishon Vijay Abraham I wrote:
Signed-off-by: Kishon Vijay Abraham I kis...@ti.com
Signed-off-by: Charulatha V ch...@ti.com
Signed-off-by: Shubhrajyoti D shubhrajy...@ti.com
Cc: Partha Basak p-bas...@ti.com
---
arch/arm/mach-omap2/mcbsp.c |
On Wednesday 06 October 2010 09:12:34 ext Varadarajan, Charulatha wrote:
This patch series would not break OMAP1 as they do not touch
the omap_mcbsp_register_board_cfg() in mach-omap1.
But the plat-omap/mcbsp will not going to be able to prope on OMAP1, or did I
missed something?
Snip:
@@
Hello,
On Wednesday 06 October 2010 10:01:28 ext Varadarajan, Charulatha wrote:
This patch series is targeted to implement mcbsp driver in
hwmod way and to make use of pm_runtime APIs.
This patch series is tested on OMAP3 4 and yet to be tested
on OMAP2.
There are few clarifications
Hi,
On Friday 08 October 2010 09:20:19 ext Varadarajan, Charulatha wrote:
Sorry I am confused.
With hwmod implementation, there is a device register code for mcbsp
devices in mach-omap2/mcbsp.c and a probe in plat-omap/mcbsp.c. The base
address, dma info are not part of pdata and are
On Thursday 14 October 2010 17:51:15 ext Varadarajan, Charulatha wrote:
Yes, this need to be fixed, but it can be done later, it does
not need to be
part of the hwmod series.
Okay.
This problem there for a long time, and so far no one complained, or fixed it.
Probably there are no users
.
Signed-off-by: Adrian Hunter adrian.hun...@nokia.com
Acked-by: Peter Ujfalusi peter.ujfal...@nokia.com
--
To unsubscribe from this list: send the line unsubscribe linux-omap in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Hi,
On 12/21/10 09:40, ext Kishon Vijay Abraham I wrote:
McBSP2/3 in OMAP3 has sidetone feature which requires autoidle
to be disabled before starting the sidetone. Also SYSCONFIG
register has to be set with smart idle or no idle depending on the
dma op mode (threshold or element sync). For
On 01/04/11 11:26, ext ABRAHAM, KISHON VIJAY wrote:
1. How we select the WAKE events from McBSP?
We need XRDYEN, and RRDYEN bits for wake (in WAKEUPEN register),
Ahh.. Ok. This setting still need to be present. Will add it in my
next patch version.
Thanks.
Thanks.
On 01/20/11 17:26, ext Koyamangalath, Abhilash wrote:
Hi all
While testing audio capture (using arecord e,g.),I'm getting only noise in
the (zeroed out) output buffers on the OMAP3 EVM.
I have enabled AUXL and AUXR mic inputs through alsamixer, which according to
the schematics are
Hi,
On 01/31/2011 04:50 PM, ext Kishon Vijay Abraham I wrote:
McBSP2/3 in OMAP3 has sidetone feature which requires autoidle
to be disabled before starting the sidetone. Also SYSCONFIG
register has to be set with smart idle or no idle depending on the
dma op mode (threshold or element sync).
Looks good, but...
On 01/31/2011 04:50 PM, ext Kishon Vijay Abraham I wrote:
Modify OMAP2+ McBSP to use omap hwmod framework APIs
Signed-off-by: Kishon Vijay Abraham I kis...@ti.com
Signed-off-by: Charulatha V ch...@ti.com
Signed-off-by: Shubhrajyoti D shubhrajy...@ti.com
---
-omap/include/plat/mcbsp.h | 14 +-
arch/arm/plat-omap/mcbsp.c | 60 +++-
5 files changed, 966 insertions(+), 205 deletions(-)
Looks good,
Acked-by: Peter Ujfalusi peter.ujfal...@nokia.com
--
To unsubscribe from this list: send the line unsubscribe linux-omap in
the body
Looks, but:
On 01/31/2011 04:50 PM, ext Kishon Vijay Abraham I wrote:
From: Charulatha V ch...@ti.com
Add McBSP hwmod data for OMAP2430.
Added a revision member inorder to facilitate the driver to
differentiate between mcbsp in different omap.
Signed-off-by: Charulatha V ch...@ti.com
and Beagle plays
fine and N810 too with some tweaks (not related to this set).
I have not tested the series on HW, but it looks OK for me as well.
All:
Acked-by: Peter Ujfalusi peter.ujfal...@nokia.com
--
To unsubscribe from this list: send the line unsubscribe linux-omap in
the body of a message
-omap/include/plat/mcbsp.h | 14 --
1 files changed, 0 insertions(+), 14 deletions(-)
Acked-by: Peter Ujfalusi peter.ujfal...@nokia.com
--
To unsubscribe from this list: send the line unsubscribe linux-omap in
the body of a message to majord...@vger.kernel.org
More majordomo info
On Tuesday 12 January 2010 18:05:15 ext Aggarwal, Anuj wrote:
Hi,
I want to check the status of suspend/resume functionality when audio
subsystem is being used. Specifically, has some one tried the following
tests on their omap3 based platforms:
a) echo mem /sys/power/state, when audio
Hello,
I think there are some inconsistency in a way how for example the SPCR1 and
SPCR2 registers are used.
On Thursday 14 January 2010 18:13:36 ext Janusz Krzysztofik wrote:
Change the way McBSP registers are updated: use cached values instead of
relying upon those read back from the
Hello Janusz,
On Friday 15 January 2010 18:43:11 ext Janusz Krzysztofik wrote:
--- git/arch/arm/plat-omap/mcbsp.c.orig2010-01-14 00:36:14.0
+0100 +++ git/arch/arm/plat-omap/mcbsp.c 2010-01-14 02:05:23.0
+0100 @@ -114,7 +114,8 @@ static irqreturn_t omap_mcbsp_tx_irq_han
features, as
well as solve the problem of possible register corruption, experienced on
OMAP1510 based Amstrad Delta board at least.
Please make a followup patch for the unneeded masking of status bits as we
discussed regarding to patch 4.
Acked-by: Peter Ujfalusi peter.ujfal...@nokia.com
On Saturday 23 January 2010 01:14:59 ext Candelaria Villareal, Jorge wrote:
From: Misael Lopez Cruz x0052...@ti.com
Allow client drivers to set the data_type (16, 32) and the
sync_mode (element, packet, etc) of the audio dma transferences.
McBSP dai driver configures it for a data type of
On Thursday 11 February 2010 13:14:18 ext Jarkko Nikula wrote:
On Thu, 11 Feb 2010 10:49:48 +
Liam Girdwood l...@slimlogic.co.uk wrote:
I do agree this makes good sense for boards that are very similar and
have different audio options/config, but in this case the ASoC mach
drivers
On Wednesday 17 February 2010 09:03:39 ext Jarkko Nikula wrote:
On Tue, 16 Feb 2010 11:19:25 -0700
Gary Thomas g...@mlbassoc.com wrote:
I need to connect the OMAP (3530) to a 24bit CODEC. So far
my attempts at getting this to go have not gone well. Then
I ran across this comment in
Hello,
Looks good, but I have one comment, you can consider if you like it...
...
+static int omap_mcbsp2_st_set_mode(struct snd_kcontrol *kcontrol,
+ struct snd_ctl_elem_value *ucontrol)
+{
+ u8 value = ucontrol-value.integer.value[0];
+
+ if (value ==
Hello,
On Thursday 18 February 2010 15:24:13 ext Jarkko Nikula wrote:
On Thu, 18 Feb 2010 14:37:14 +0200
Ilkka Koskinen ilkka.koski...@nokia.com wrote:
static inline void __devexit omap34xx_device_exit(struct omap_mcbsp
*mcbsp) {
- if (cpu_is_omap34xx())
+ if
On Thursday 18 February 2010 15:06:21 ext Jarkko Nikula wrote:
On Wed, 17 Feb 2010 16:45:58 +0200
Ilkka Koskinen ilkka.koski...@nokia.com wrote:
The first patch implements McBSP sidetone feature on OMAP3 while the
second one provides ALSA interface for using it.
Do I have something
On Thursday 18 February 2010 14:37:15 Koskinen Ilkka (Nokia-D/Tampere) wrote:
...
+static int omap_mcbsp_set_st_channel_vol(struct snd_kcontrol *kcontrol,
+ struct snd_ctl_elem_value *ucontrol,
+ int id, int channel)
+{
On Thursday 18 February 2010 22:22:29 ext Jarkko Nikula wrote:
I still have two concern:
1. port number vs. index difference inside driver code is not enough
It's just confusing if a machine driver and internal API (mcbsp.c) has
to use different indexing. See:
/mcbsp.c | 402
++- sound/soc/omap/omap-mcbsp.c |
138 +++
sound/soc/omap/omap-mcbsp.h |2 +
5 files changed, 603 insertions(+), 1 deletions(-)
Both looks OK for me:
Acked-by: Peter Ujfalusi peter.ujfal...@nokia.com
Use the new delay calback function to report the delay through
ALSA for application caused by the internal FIFO.
Signed-off-by: Peter Ujfalusi peter.ujfal...@nokia.com
---
sound/soc/omap/omap-mcbsp.c | 26 ++
1 files changed, 26 insertions(+), 0 deletions(-)
diff --git
as
zero.
Signed-off-by: Peter Ujfalusi peter.ujfal...@nokia.com
---
include/sound/soc-dai.h |6 ++
include/sound/soc.h |7 +++
sound/soc/soc-core.c| 18 ++
3 files changed, 31 insertions(+), 0 deletions(-)
diff --git a/include/sound/soc-dai.h b/include
).
Signed-off-by: Peter Ujfalusi peter.ujfal...@nokia.com
---
arch/arm/plat-omap/include/plat/mcbsp.h |6 +++
arch/arm/plat-omap/mcbsp.c | 55 +++
2 files changed, 61 insertions(+), 0 deletions(-)
diff --git a/arch/arm/plat-omap/include/plat/mcbsp.h
b
Create a soc level wrapper for pcm_pointer callback.
This will facilitate the soc level handling of different
HW buffers in the audio path.
Signed-off-by: Peter Ujfalusi peter.ujfal...@nokia.com
---
sound/soc/soc-core.c | 19 ++-
1 files changed, 18 insertions(+), 1 deletions
Wake-up from McBSP ports are needed, especially when the THRESHOLD
dma mode is in use for audio playback.
Signed-off-by: Peter Ujfalusi peter.ujfal...@nokia.com
---
arch/arm/mach-omap2/pm34xx.c |8 ++--
1 files changed, 6 insertions(+), 2 deletions(-)
diff --git a/arch/arm/mach-omap2
of sound-2.6 topic/asoc
cleanly as well.
Obviously the last patch depends on the OMAP platform patch.
---
Peter Ujfalusi (5):
ASoC: core: fix tailing whitespace in soc_pcm_apply_symmetry
ASoC: core: soc level wrapper for pcm_pointer callback
ASoC: core: Add delay operation to snd_soc_dai_ops
My editor removes the tailing spaces, which causes problems when
changing the soc-core.c
Removing the space.
Signed-off-by: Peter Ujfalusi peter.ujfal...@nokia.com
---
sound/soc/soc-core.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/sound/soc/soc-core.c b/sound/soc
On Wednesday 03 March 2010 15:08:05 Ujfalusi Peter (Nokia-D/Tampere) wrote:
Wake-up from McBSP ports are needed, especially when the THRESHOLD
dma mode is in use for audio playback.
Signed-off-by: Peter Ujfalusi peter.ujfal...@nokia.com
Hmmm, please disregard this patch, I have forgot
The use of the spin lock, which supposed to protect the the
dma_op_mode causing INFO: inconsistent lock state on
playback start.
Remove the spin locks around the dma_op_mode, when it's
purpuse is to protect the dma_op_mode.
Signed-off-by: Peter Ujfalusi peter.ujfal...@nokia.com
---
arch/arm/plat
.
Remove the spin locks around the dma_op_mode, when it's
purpuse is to protect the dma_op_mode.
Signed-off-by: Peter Ujfalusi peter.ujfal...@nokia.com
---
You may wish to double read the message above, as it's quite
confusing =)
Yes it is ;)
I have left one spinlock around the dma_op_mode
On Tuesday 27 October 2009 14:00:09 ext Mark Brown wrote:
I have to confess that I'm still not entirely clear what the lock is
supposed to be doing or why it's OK to drop it. I gather that it's just
that dmap_on_mode() doesn't need a lock at all?
In my opinion it does not need a lock.
If
On Tuesday 27 October 2009 16:00:00 ext Jarkko Nikula wrote:
On Tue, 27 Oct 2009 13:07:23 +0200
Eero Nurkkala ext-eero.nurkk...@nokia.com wrote:
Otherwise, that spinlocking is highly unnecessary and things are
far better without than with it. The only case it could be useful
is in SMPs,
On Wednesday 28 October 2009 08:53:34 Nurkkala Eero.An (EXT-Offcode/Oulu) wrote:
Yeah, maybe I took the SMP safeness into play without looking any code,
my bad =) I was remembering a different version of this McBSP thing, now
that I looked into it, it looked different.
Right, I reviewed the
APLL_CTL register is configured by the twl4030-codec MFD
driver.
Remove code, which makes changes in the APLL_CTL register,
and replace those with checks against the configured
audio_mclk configuration done in the MFD driver.
Signed-off-by: Peter Ujfalusi peter.ujfal...@nokia.com
---
sound/soc
Move the APLL_CTL register configuration to the twl4030-codec
MFD driver.
Provide also a function for childs to query the audio_mclk
frequency.
Signed-off-by: Peter Ujfalusi peter.ujfal...@nokia.com
---
drivers/mfd/twl4030-codec.c | 40 +
include/linux
Set the codec-bias_level to SND_SOC_BIAS_OFF before changing
the initial bias level to STANDBY.
Signed-off-by: Peter Ujfalusi peter.ujfal...@nokia.com
---
sound/soc/codecs/twl4030.c |1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/sound/soc/codecs/twl4030.c b/sound/soc
branch,
since this fixes some real anomalies brought in by the cleanup of the twl4030
codec related drivers.
These problems were hidden before because of the inconsistent handling of bits
and states in the codec driver in the past.
Thank you,
---
Peter Ujfalusi (5):
MFD: TWL4030: Add audio_mclk
Add audio_mclk to the twl4030-codec MFD
Signed-off-by: Peter Ujfalusi peter.ujfal...@nokia.com
---
include/linux/i2c/twl4030.h |1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/include/linux/i2c/twl4030.h b/include/linux/i2c/twl4030.h
index 42d6c72..c188961 100644
audio_mclk value is going to be handled by the
twl4030-codec MFD driver, configure the correct
value for boards, which is using the twl4030 audio.
Signed-off-by: Peter Ujfalusi peter.ujfal...@nokia.com
---
arch/arm/mach-omap2/board-3430sdp.c |1 +
arch/arm/mach-omap2/board-omap3beagle.c
On Monday 02 November 2009 19:30:35 ext Mark Brown wrote:
On Mon, Nov 02, 2009 at 02:34:53PM +0200, Peter Ujfalusi wrote:
Move the APLL_CTL register configuration to the twl4030-codec
MFD driver.
Provide also a function for childs to query the audio_mclk
frequency.
This all looks good
On Tuesday 03 November 2009 15:44:38 ext Mark Brown wrote:
on board. Another reason is that we have other part of the twl, which
needs resources from the codec part, but it is not loaded through the
codec MFD, so providing the needed information is kind of tricky with
that setup.
I had
On Monday 02 November 2009 19:27:20 ext Mark Brown wrote:
On Mon, Nov 02, 2009 at 02:34:55PM +0200, Peter Ujfalusi wrote:
APLL_CTL register is configured by the twl4030-codec MFD
driver.
Remove code, which makes changes in the APLL_CTL register,
and replace those with checks against
Configure the APLL_INFREQ field in the APLL_CTL register
based on the platform data.
Provide also a function for childs to query the audio_mclk
frequency.
Signed-off-by: Peter Ujfalusi peter.ujfal...@nokia.com
---
drivers/mfd/twl4030-codec.c | 35
handling of bits
and states in the codec driver in the past.
---
Peter Ujfalusi (4):
MFD: TWL4030: Add audio_mclk to the codec platform data
OMAP: Configure audio_mclk for twl4030-codec MFD
MFD: twl4030-codec: APLL_INFREQ handling in the MFD driver
ASoC: TWL4030: Do not modify the APLL_CTL
APLL_CTL register is configured by the twl4030-codec MFD
driver.
Remove code, which makes changes in the APLL_CTL register,
and replace those with checks against the configured
audio_mclk configuration done in the MFD driver.
Signed-off-by: Peter Ujfalusi peter.ujfal...@nokia.com
---
sound/soc
Add audio_mclk to the platform data struct for the
twl4030-codec MFD driver.
Signed-off-by: Peter Ujfalusi peter.ujfal...@nokia.com
---
include/linux/i2c/twl4030.h |1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/include/linux/i2c/twl4030.h b/include/linux/i2c/twl4030.h
audio_mclk value is going to be handled by the
twl4030-codec MFD driver, configure the correct
value for boards, which is using the twl4030 audio.
Signed-off-by: Peter Ujfalusi peter.ujfal...@nokia.com
---
arch/arm/mach-omap2/board-3430sdp.c |1 +
arch/arm/mach-omap2/board-omap3beagle.c
Hello Tony,
On Wednesday 04 November 2009 09:58:18 Ujfalusi Peter (Nokia-D/Tampere) wrote:
audio_mclk value is going to be handled by the
twl4030-codec MFD driver, configure the correct
value for boards, which is using the twl4030 audio.
Signed-off-by: Peter Ujfalusi peter.ujfal
On Thursday 29 October 2009 09:15:24 ext Jarkko Nikula wrote:
On Thu, 29 Oct 2009 08:35:51 +0200
Peter Ujfalusi peter.ujfal...@nokia.com wrote:
The spinlocks are unnecessary. In the above example, you get the same
with just return mcbsp-dma_op_mode;
- Peter's patch is a good
On Thursday 19 November 2009 21:48:26 ext Anuj Aggarwal wrote:
[Anuj] Yes, w/o audio, it goes into suspend neatly.
After going through the entire patch series [PATCHv5 00/20] OMAP
ASoC changes in DMA utilization, which I missed earlier, I found that the
sysfs entry dma_op_mode can be toggled
Wake-up from McBSP ports are needed, especially when the THRESHOLD
dma mode is in use for audio playback.
Signed-off-by: Peter Ujfalusi peter.ujfal...@nokia.com
---
arch/arm/mach-omap2/pm34xx.c |8 ++--
1 files changed, 6 insertions(+), 2 deletions(-)
diff --git a/arch/arm/mach-omap2
Hello,
On Thursday 03 December 2009 09:49:05 ext Jarkko Nikula wrote:
On Tue, 1 Dec 2009 04:10:07 +0100
Janusz Krzysztofik jkrzy...@tis.icnet.pl wrote:
Change the way McBSP registers are maintained: store values written to
the device in a cache in order to make use of those cached values
1 - 100 of 1965 matches
Mail list logo
