Re: Regression for non-eMMC cards with commit fa550189?

this requirement can be removed and fixed in the host driver somehow. Please get back to me if you need some more assistance around this matter. Kind regards Ulf Hansson On 28 May 2012 21:21, Tony Lindgren t...@atomide.com wrote: Hi Ulf Chris, Looks like commit fa550189 (mmc: core: Prevent

Re: [PATCH 2/4] mmc: omap_hsmmc: Enable SDIO IRQ using a GPIO in idle mode

by a pm_runtime_put* in some form. Then you will be able to remove the active_pinmux variable entirely, since you know the runtime callbacks is the only place were you need to handle the gpio irq enable|disable. Kind regards Ulf Hansson + host-sdio_irq_en = (enable != 0) ? true : false

[PATCH 14/27] mmc: omap_hsmmc: Move away from using deprecated APIs

. Cc: Balaji T K balaj...@ti.com Cc: linux-omap@vger.kernel.org Signed-off-by: Ulf Hansson ulf.hans...@linaro.org --- drivers/mmc/host/omap_hsmmc.c | 37 +++-- 1 file changed, 3 insertions(+), 34 deletions(-) diff --git a/drivers/mmc/host/omap_hsmmc.c b/drivers/mmc

[PATCH 13/27] mmc: omap: Remove redundant suspend and resume callbacks

jarkko.lavi...@nokia.com Cc: linux-omap@vger.kernel.org Signed-off-by: Ulf Hansson ulf.hans...@linaro.org --- drivers/mmc/host/omap.c | 53 --- 1 file changed, 53 deletions(-) diff --git a/drivers/mmc/host/omap.c b/drivers/mmc/host/omap.c index b94f38e

Re: [PATCH V3] ARM: OMAP2+: omap_device: maintain sane runtime pm status around suspend/resume

to inactivate devices during system suspend. Kind regards Ulf Hansson Looks reasonable to me. Looks like this should be considered for -stable - Nishanth, what do you think? Every product kernel since 3.4 needed to be hacked (we have hacked in different ways so far) to work around

Re: [PATCH v3 2/3] mmc: omap_hsmmc: Pin remux workaround to support SDIO interrupt on AM335x.

likely want to signal the SDIO irq as soon as possible. Then you should use mmc_signal_sdio_irq instead. In the other case, when waking up from system suspend, you should be able to completely rely on that the mmc_sdio_resume from the core layer, will handle the IRQ. Kind regards Ulf Hansson

Re: [PATCH v3 2/3] mmc: omap_hsmmc: Pin remux workaround to support SDIO interrupt on AM335x.

On 19 November 2013 14:37, Andreas Fenkart afenk...@gmail.com wrote: Hi Ulf, 2013/11/19 Ulf Hansson ulf.hans...@linaro.org: On 18 November 2013 08:53, Andreas Fenkart afenk...@gmail.com wrote: +static irqreturn_t omap_hsmmc_cirq(int irq, void *dev_id) +{ + struct omap_hsmmc_host

Re: [RFC PATCH v3 1/8] mmc: omap_hsmmc: use devm_regulator API

); mmc_slot(host).set_power = NULL; } While you are touching this code I would suggest to convert to mmc_regulator_get_supply instead. That mean the vmmc_aux change name to vqmmc though, so you need to adapt for this as well then. Kind regards Ulf Hansson -- 1.7.5.4 -- To unsubscribe from

Re: [RFC PATCH v3 2/8] mmc: omap_hsmmc: handle vcc and vcc_aux independently

problem is handled by the mmc core layer. I certainly think you shall adopt your code to it. Kind regards Ulf Hansson - if (regulator_is_enabled(host-vcc) 0 || - (host-vcc_aux regulator_is_enabled(host-vcc_aux))) { - int vdd = ffs(mmc_slot

Re: [RFC PATCH v3 2/8] mmc: omap_hsmmc: handle vcc and vcc_aux independently

On 10 December 2013 12:48, Balaji T K balaj...@ti.com wrote: On Tuesday 10 December 2013 04:39 PM, Ulf Hansson wrote: On 21 November 2013 15:20, Balaji T K balaj...@ti.com wrote: handle vcc and vcc_aux independently to reduce indent. Signed-off-by: Balaji T K balaj...@ti.com --- drivers

Re: [PATCH 6/9] mmc: omap_hsmmc: Enable SDIO interrupt

On 24 March 2014 15:59, Andreas Fenkart afenk...@gmail.com wrote: Hi, 2014-03-24 13:43 GMT+01:00 Ulf Hansson ulf.hans...@linaro.org: On 21 March 2014 17:17, Balaji T K balaj...@ti.com wrote: From: Andreas Fenkart afenk...@gmail.com There have been various patches floating around

Re: [PATCH 6/9] mmc: omap_hsmmc: Enable SDIO interrupt

On 24 March 2014 17:34, Andreas Fenkart afenk...@gmail.com wrote: 2014-03-24 17:02 GMT+01:00 Ulf Hansson ulf.hans...@linaro.org: On 24 March 2014 15:59, Andreas Fenkart afenk...@gmail.com wrote: Hi, 2014-03-24 13:43 GMT+01:00 Ulf Hansson ulf.hans...@linaro.org: On 21 March 2014 17:17, Balaji

Re: [PATCH/RFC 3/4] of/clk: Register clocks suitable for Runtime PM with the PM core

of_device_make_bus_id(dev-dev); + of_clk_register_runtime_pm_clocks(np, dev-dev); + What about other device than platform devices? Could we handle the DT binding at driver core at probe instead? Kind regards Ulf Hansson return dev; } EXPORT_SYMBOL

Re: [PATCH 0/6] PM / clock_ops: Add helpers combining generic runtime and generic clock PM

generic runtime and clock helpers - [4/6] ARM: omap: Use generic runtime and clock helpers - [5/6] drivers: sh: Use generic runtime and clock helpers Then convert the above power domains implementations to the generic power domain? Would that work? Kind regards Ulf Hansson - [6/6] of/clk: Use

Re: [PATCH/RFC 3/4] of/clk: Register clocks suitable for Runtime PM with the PM core

callbacks, instead of from the power domain, right? Just to clarify, that's my view as well. Kind regards Ulf Hansson I believe, though, that for devices that are not inside a controllable power domain, this might be a good solution. Best regards, Tomasz -- To unsubscribe from this list: send

Re: [PATCH/RFC 3/4] of/clk: Register clocks suitable for Runtime PM with the PM core

. + USE_PLATFORM_PM_SLEEP_OPS What about other buses beside the platfrom bus. Certainly we need to handle devices attached to any other subsystem type as well. Kind regards Ulf Hansson -- To unsubscribe from this list: send the line unsubscribe linux-omap in the body of a message to majord...@vger.kernel.org More

Re: [PATCH/RFC 3/4] of/clk: Register clocks suitable for Runtime PM with the PM core

On 2 May 2014 16:35, Geert Uytterhoeven ge...@linux-m68k.org wrote: Hi Ulf, On Fri, May 2, 2014 at 10:56 AM, Ulf Hansson ulf.hans...@linaro.org wrote: +static int of_clk_pm_runtime_suspend(struct device *dev) +{ + int ret; + + ret = pm_generic_runtime_suspend(dev

Re: [PATCH/RFC 3/4] of/clk: Register clocks suitable for Runtime PM with the PM core

On 2 May 2014 16:58, Geert Uytterhoeven ge...@linux-m68k.org wrote: Hi Ulf, Tomasz, On Fri, May 2, 2014 at 10:13 AM, Ulf Hansson ulf.hans...@linaro.org wrote: +static int of_clk_register(struct device *dev, struct clk *clk) +{ + int error; + + if (!dev-pm_domain

Re: [PATCH v2 1/6] mmc: omap_hsmmc: use devm_clk_get

); -- 1.7.5.4 Kind regards Ulf Hansson -- To unsubscribe from this list: send the line unsubscribe linux-omap in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH v2 1/6] mmc: omap_hsmmc: use devm_clk_get

On 12 May 2014 15:33, Balaji T K balaj...@ti.com wrote: On Monday 12 May 2014 02:03 PM, Ulf Hansson wrote: On 9 May 2014 18:46, Balaji T K balaj...@ti.com wrote: With devm_clk_get conversion clk_put can be removed in clean up path Signed-off-by: Balaji T K balaj...@ti.com --- drivers

Re: [PATCH v2] mmc: omap: Use DIV_ROUND_UP instead of open coded

On 3 May 2014 03:07, Axel Lin axel@ingics.com wrote: Also uses NSEC_PER_SEC and USEC_PER_SEC instead of hard-coded value. This makes the intention more clear. Signed-off-by: Axel Lin axel@ingics.com Thanks Axel! Will include this patch in the next PR to Chris. Kind regards Ulf

Re: [PATCH v11 0/6] mmc: omap_hsmmc: Enable SDIO IRQ

this patchset - I will include it in the next PR I send to Chris. Kind regards Ulf Hansson -- To unsubscribe from this list: send the line unsubscribe linux-omap in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH v2 0/6] mmc: omap_hsmmc: convert to use devm_* and fixes

++ 3 files changed, 40 insertions(+), 57 deletions(-) create mode 100644 include/linux/omap-dmaengine.h Thanks Balaji, I will include this patchset in the next PR I send to Chris. Kind regards Ulf Hansson -- 1.7.5.4 -- To unsubscribe from this list: send the line unsubscribe linux

Re: [PATCH] mmc: omap_hsmmc: use IS_ERR macro for error checking

On 15 May 2014 15:23, Balaji T K balaj...@ti.com wrote: Debounce clock is optional, use IS_ERR macro instead of NULL pointer check. Signed-off-by: Balaji T K balaj...@ti.com Thanks Balaji, I will include this in the next PR I send to Chris. Kind regards Ulf Hansson -- To unsubscribe from

Re: [PATCH 0/4] randconfig fixes for mmc

On 5 June 2014 23:14, Arnd Bergmann a...@arndb.de wrote: Hi Chris, Ulf, These are small fixes from my randconfig testing, almost all for older bugs, please apply to a tree you see appropriate. Thanks Arnd! Applied for fixes. Kind regards Uffe Arnd Arnd Bergmann (4): mmc:

Re: [PATCH v14 0/6] mmc: omap_hsmmc: Enable SDIO IRQ

/pinctrl configuration even when runtime suspend is not configured - drop runtime state from debugfs output - rebased onto current mmc-next 06732b84b4cf Thanks! Applied for next. Kind regards Ulf Hansson v13 - fix compile breaks if !CONFIG_PM - additional patch: install dummy pm runtime

Re: [PATCH 0/5] MMC cleanup of dev_pm_ops and .owner

On 12 August 2014 18:14, Peter Griffin peter.grif...@linaro.org wrote: This series cleans up a few platform drivers in how they are declaring there dev_pm_ops structs, and gets rid of a few now redundant #else conditions. Also it removes the .owner field of drivers which use

Re: [PATCH] mmc: omap_hsmmc: Add small delay after enabling power

ramp up/down time? Then I think it maybe should be a part of the regulator code/DT. Kind regards Uffe Signed-off-by: Thorsten Einsbein thorsten.eisb...@head-acoustics.de Signed-off-by: Stefan Roese s...@denx.de Cc: Ulf Hansson ulf.hans...@linaro.org Cc: Balaji T K balaj...@ti.com

Re: [PATCH] MAINTAINERS: omap_hsmmc: remove myself from MAINTAINERS

On 17 September 2014 19:20, Balaji T K balaji...@gmail.com wrote: As I won't be able to maintain omap_hsmmc driver Signed-off-by: Balaji T K balaji...@gmail.com Sorry to see you go Balaji. Thanks for all your support! Patch applied for next. Kind regards Uffe --- MAINTAINERS | 3 +-- 1

Re: [PATCH 0/6] unshare and simplify omap_hsmmc platform struct

On 22 September 2014 13:55, Andreas Fenkart afenk...@gmail.com wrote: mmci and omap_hsmmc share very little fields in the platform mmci? Should be omap right? I noticed the similar typo for one of the patches as well. Kind regards Uffe struct. unsharing significantly simplifies the

Re: [PATCH v2 0/9] unshare and simplify omap_hsmmc platform struct

On 29 September 2014 11:32, Andreas Fenkart afenk...@gmail.com wrote: v2: - replace erroneous mmci by omap1/2 - add description to all patches - full compile check with: CONFIG_MACH_OMAP3_BEAGLE=y CONFIG_MACH_DEVKIT8000=y CONFIG_MACH_OMAP_LDP=y

Re: [PATCH v2 0/9] unshare and simplify omap_hsmmc platform struct

On 3 October 2014 15:00, Ulf Hansson ulf.hans...@linaro.org wrote: On 29 September 2014 11:32, Andreas Fenkart afenk...@gmail.com wrote: v2: - replace erroneous mmci by omap1/2 - add description to all patches - full compile check with: CONFIG_MACH_OMAP3_BEAGLE=y

Re: [PATCH v4 00/10] ARM: OMAP1/2+: MMC: separate platform data for mmc and mmc hs driver

On 8 November 2014 15:33, Andreas Fenkart afenk...@gmail.com wrote: v4: - rework patch descriptions - dropped patch removing unused defines in mach-omap2/mmc.h - rebase 3.18.0-rc3 - compile test omap1 and omap2 compile tested OMAP1: CONFIG_MACH_OMAP_INNOVATOR=y CONFIG_MACH_OMAP_H2=y

Re: [PATCH 0/3] mmc: omap_hsmmc: make more use of mmc library functionality

On 8 November 2014 00:52, NeilBrown ne...@suse.de wrote: omap_hsmmc currently duplicates some work that can be done for it by common code, and consequently does not benefit from extra functionality in that common code. In particular, mmc_of_parse and the slot-gpio library are not used. This

Re: [PATCH 0/3] mmc: omap_hsmmc: make more use of mmc library functionality

Thanks. What should I rebase against? Is 3.18-rc sufficient or is there some other tree I should work against? Thanks, NeilBrown git://git.linaro.org/people/ulf.hansson/mmc.git Kind regards Uffe -- To unsubscribe from this list: send the line unsubscribe linux-omap in the body of a

Re: [PATCH 2/3] ARM: edma: Rename header file for dmaengine filter function definition

On 27 November 2014 at 11:41, Peter Ujfalusi peter.ujfal...@ti.com wrote: Rename the include/linux/edma.h to include/linux/edma-dmaengine.h Signed-off-by: Peter Ujfalusi peter.ujfal...@ti.com For the mmc parts: Acked-by: Ulf Hansson ulf.hans...@linaro.org --- arch/arm/common/edma.c

Re: [PATCH] ARM / PM: Replace CONFIG_PM_RUNTIME with CONFIG_PM

On 6 December 2014 at 03:50, Rafael J. Wysocki r...@rjwysocki.net wrote: From: Rafael J. Wysocki rafael.j.wyso...@intel.com After commit b2b49ccbdd54 (PM: Kconfig: Set PM_RUNTIME if PM_SLEEP is selected) PM_RUNTIME is always set if PM is set, so #ifdef blocks depending on CONFIG_PM_RUNTIME

Re: [PATCH v5 0/4] Fixes for SDIO interrupts for dw_mmc

On 3 December 2014 at 00:42, Doug Anderson diand...@chromium.org wrote: Bing Zhao at Marvell found a problem with dw_mmc where interrupts weren't firing sometimes. He tracked it down to a read-modify-write problem with the INTMASK. These patches fix the problem. Note: I've picked up a

Re: [PATCH 2/3] mmc: omap_hsmmc: use slot-gpio library for gpio support.

On 11 December 2014 at 22:43, NeilBrown ne...@suse.de wrote: Using the common code removes some code duplication, and makes it easier to switch to using mmc_of_parse() which will remove more duplication. As hsmmc has a slightly different interrupt service routine for card-detect, enhance

Re: [PATCH 1/3] mmc: omap_hsmmc: remove prepare/complete system suspend support.

On 11 December 2014 at 22:43, NeilBrown ne...@suse.de wrote: The only function of these 'prepare' and 'complete' is to disable the 'card detect' irq during suspend. The commit which added this, commit a48ce884d5819d5df2cf1139ab3c43f8e9e419b3 mmc: omap_hsmmc: Introduce

Re: [PATCH 2a/3] mmc: core: Allow host driver to provide isr for card-detect interrupts.

On 20 December 2014 at 00:07, NeilBrown ne...@suse.de wrote: One of the reasons omap_hsmmc doesn't use the slot-gpio library is that it has some non-standard functionality in the card-detect interrupt service routine. To make it possible for omap_hsmmc (and maybe others) to be converted to

Re: [PATCH 2a/3] mmc: core: Allow host driver to provide isr for card-detect interrupts.

On 23 December 2014 at 09:48, NeilBrown ne...@suse.de wrote: On Mon, 22 Dec 2014 16:35:40 +0100 Ulf Hansson ulf.hans...@linaro.org wrote: On 20 December 2014 at 00:07, NeilBrown ne...@suse.de wrote: One of the reasons omap_hsmmc doesn't use the slot-gpio library is that it has some non

Re: [PATCH v5 0/4] Fixes for SDIO interrupts for dw_mmc

On 19 December 2014 at 20:02, Doug Anderson diand...@chromium.org wrote: Ulf, On Fri, Dec 19, 2014 at 2:17 AM, Ulf Hansson ulf.hans...@linaro.org wrote: On 3 December 2014 at 00:42, Doug Anderson diand...@chromium.org wrote: Bing Zhao at Marvell found a problem with dw_mmc where interrupts

Re: [PATCH 1/3] mmc: core: Allow host driver to provide isr for card-detect interrupts.

On 24 December 2014 at 22:20, NeilBrown ne...@suse.de wrote: One of the reasons omap_hsmmc doesn't use the slot-gpio library is that it has some non-standard functionality in the card-detect interrupt service routine. To make it possible for omap_hsmmc (and maybe others) to be converted to

Re: [PATCH v5 0/4] Fixes for SDIO interrupts for dw_mmc

On 2 January 2015 at 18:11, Tony Lindgren t...@atomide.com wrote: * Doug Anderson diand...@chromium.org [150102 09:09]: Ulf, On Tue, Dec 30, 2014 at 2:29 AM, Ulf Hansson ulf.hans...@linaro.org wrote: In v5, I don't find a patch 1/4. Anyway, I have taken patch 2-4. Ah, maybe because

Re: How to manage SDIO interrupts with a runtime power managed host.

On 27 January 2015 at 12:47, NeilBrown ne...@suse.de wrote: The (libertas) wifi chip in my GTA04 is connected to an OMAP3 HS_MMC port as an SDIO card. When I configure it (via devicetree) to respond to the SD interrupt line (rather than polling for SD interrupts) it doesn't work well at all.

Re: [PATCH 3/3] mmc: omap_hsmmc: switch to 1-bit before turning off clocks if interrupts expected.

On 28 January 2015 at 00:35, NeilBrown ne...@suse.de wrote: According to section 7.1.2 of http://www.sandisk.com/media/File/OEM/Manuals/SD_SDIO_specsv1.pdf In the case where the interrupt mechanism is used to wake the host while the card is in a low power state (i.e. no clocks), Both

Re: [PATCH 0/3] Convert omap_hsmmc to use common devicetree parsing code.

On 12 January 2015 at 20:23, NeilBrown ne...@suse.de wrote: This is another resend with mmc_gpio_set_cd_isr() now returning void and being EXPORTed. I included WARN_ON(ctx-cd_gpio_isr); to guard against misuse. My goal is to get omap_hsmmc to use the common code for parsing of,

Re: [PATCH] ARM: OMAP2: HSMMC: explicit fields to declare cover/card detect pin

On 20 March 2015 at 15:53, Andreas Fenkart afenk...@gmail.com wrote: board-rx51 has no card detect pin in the mmc slot, but can detect that the (cell-phone) cover has been removed and the card is accessible. The semantics between cover/card detect differ, the gpio on the slot informs you after

Re: [PATCH 6/6] mmc: omap_hsmmc: use generic slot-gpio isr to manage card detect pin

On 3 March 2015 at 13:28, Andreas Fenkart afenk...@gmail.com wrote: Signed-off-by: Andreas Fenkart afenk...@gmail.com Thanks! Applied. Kind regards Uffe --- drivers/mmc/host/omap_hsmmc.c | 13 - 1 file changed, 13 deletions(-) diff --git a/drivers/mmc/host/omap_hsmmc.c

Re: [PATCH 5/6] mmc: omap_hsmmc: simplify card/cover detect isr

On 3 March 2015 at 13:28, Andreas Fenkart afenk...@gmail.com wrote: strip the card dectet logic from cover detect isr and vice versa the generic mmc_gpio_cd_irqt isr, uses 200ms on removal/insertion, hence that should be fine here as well Signed-off-by: Andreas Fenkart afenk...@gmail.com

Re: [PATCH] ARM: OMAP2: HSMMC: explicit fields to declare cover/card detect pin

On 20 March 2015 at 15:53, Andreas Fenkart afenk...@gmail.com wrote: board-rx51 has no card detect pin in the mmc slot, but can detect that the (cell-phone) cover has been removed and the card is accessible. The semantics between cover/card detect differ, the gpio on the slot informs you after

Re: [PATCH 0/2] Remove mmc_host enable/disable methods.

On 25 March 2015 at 22:43, NeilBrown n...@brown.name wrote: Only omap_hsmmc uses enable and disable, and this seems to be largely for historical reasons and is no longer necessary. I have tested these patches with an OMAP3 with an uSD card on mmc0 and a wifi SDIO device on mmc1. NeilBrown

Re: [PATCH 2/4] mmc: core: allow non-blocking form of mmc_claim_host

On 23 March 2015 at 10:58, Ulf Hansson ulf.hans...@linaro.org wrote: On 24 February 2015 at 03:42, NeilBrown ne...@suse.de wrote: Change the handling for the 'abort' flag so that if it is set, but we can claim the host, then do the claim, rather than aborting. When the abort is async

Re: [PATCH] mmc: omap_hsmmc: add hibernation support

On 27 February 2015 at 12:24, grygorii.stras...@linaro.org wrote: From: Russ Dill russ.d...@ti.com Setting a dev_pm_ops suspend/resume pair but not a set of hibernation functions means those pm functions will not be called upon hibernation. Fix this by using SET_SYSTEM_SLEEP_PM_OPS, which

Re: [PATCH 0/6] mmc: omap_hsmmc: simplify cover/card detect logic

On 3 March 2015 at 13:28, Andreas Fenkart afenk...@gmail.com wrote: These patches are trying to clean up the cover/card detect logic. Mobile phones (some) have no card detect pin, but can detect if the cover is removed. The purpose is the same; detect if card is being added/removed, but

Re: [PATCH 1/2] mmc: omap_hsmmc: stop using .enable and .disable method.

On 26 March 2015 at 02:18, NeilBrown ne...@suse.de wrote: On Thu, 26 Mar 2015 08:43:37 +1100 NeilBrown n...@brown.name wrote: enable and disable are only used to get and put runtime pm references. .set_ios already does this itself, and other drivers just do it in set_ios and .request

Re: [PATCH 1/2] mmc: omap_hsmmc: stop using .enable and .disable method.

On 26 March 2015 at 08:38, Ulf Hansson ulf.hans...@linaro.org wrote: On 26 March 2015 at 02:18, NeilBrown ne...@suse.de wrote: On Thu, 26 Mar 2015 08:43:37 +1100 NeilBrown n...@brown.name wrote: enable and disable are only used to get and put runtime pm references. .set_ios already does

Re: [PATCH 3/4] mmc: sdio: support switching to 1-bit before turning off clocks

On 24 February 2015 at 03:42, NeilBrown ne...@suse.de wrote: According to section 7.1.2 of http://www.sandisk.com/media/File/OEM/Manuals/SD_SDIO_specsv1.pdf In the case where the interrupt mechanism is used to wake the host while the card is in a low power state (i.e. no clocks),

Re: [PATCH 1/4] mmc: core: fold mmc_set_bus_width calls into sdio_enable_4bit_bus.

On 24 February 2015 at 03:42, NeilBrown ne...@suse.de wrote: Every call to sdio_enable_4bit_bus is followed (on success) but a call /s /but / by to mmc_set_bus_width(). To simplify the code, include those calls directly in sdio_enable_4bit_bus(). Signed-off-by: NeilBrown n...@brown.name

Re: [PATCH 2/4] mmc: core: allow non-blocking form of mmc_claim_host

On 24 February 2015 at 03:42, NeilBrown ne...@suse.de wrote: Change the handling for the 'abort' flag so that if it is set, but we can claim the host, then do the claim, rather than aborting. When the abort is async this just means that a race between aborting an allowing a claim is resolved

Re: [PATCH 0/5] PM / clock_ops: provide default runtime ops and cleanup users

/pm_runtime.c| 47 ++ include/linux/pm_clock.h | 10 6 files changed, 54 insertions(+), 143 deletions(-) I guess you don't need more acks/reviewed by for this patchset. Still, and also for my own reference. Acked-by: Ulf Hansson

Re: [PATCH] mmc: core: add missing pm event in mmc_pm_notify to fix hib restore

On 23 April 2015 at 12:43, grygorii.stras...@linaro.org wrote: From: Grygorii Strashko grygorii.stras...@linaro.org The PM_RESTORE_PREPARE is not handled now in mmc_pm_notify(), as result mmc_rescan() could be scheduled and executed at late hibernation restore stages when MMC device is

Re: [PATCH 0/3] Introduce SET_NOIRQ_SYSTEM_SLEEP_PM_OPS and use it

For the patchset. Reviewed-by: Ulf Hansson ulf.hans...@linaro.org Kind regards Uffe -- To unsubscribe from this list: send the line unsubscribe linux-omap in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH 05/13] mmc: omap_hsmmc: Support for deferred probing when requesting DMA channels

-EPROBE_DEFER Signed-off-by: Peter Ujfalusi peter.ujfal...@ti.com CC: Ulf Hansson ulf.hans...@linaro.org With the minor change above. Acked-by: Ulf Hansson ulf.hans...@linaro.org Kind regards Uffe --- drivers/mmc/host/omap_hsmmc.c | 22 ++ 1 file changed, 10 insertions

Re: [PATCH 07/13] mmc: davinci_mmc: Support for deferred probing when requesting DMA channels

-off-by: Peter Ujfalusi peter.ujfal...@ti.com CC: Ulf Hansson ulf.hans...@linaro.org Acked-by: Ulf Hansson ulf.hans...@linaro.org Kind regards Uffe --- drivers/mmc/host/davinci_mmc.c | 26 +++--- 1 file changed, 15 insertions(+), 11 deletions(-) diff --git a/drivers/mmc

Re: [PATCH 04/13] mmc: omap_hsmmc: No need to check DMA channel validity at module remove

On 26 May 2015 at 15:25, Peter Ujfalusi peter.ujfal...@ti.com wrote: The driver will not probe without valid DMA channels so no need to check if they are valid when the module is removed. Signed-off-by: Peter Ujfalusi peter.ujfal...@ti.com CC: Ulf Hansson ulf.hans...@linaro.org Acked-by: Ulf

Re: [PATCH 5/5] mmc: omap_hsmmc: Change wake-up interrupt to use generic wakeirq

. Acked-by: Ulf Hansson ulf.hans...@linaro.org Kind regards Uffe --- drivers/mmc/host/omap_hsmmc.c | 51 +++ 1 file changed, 8 insertions(+), 43 deletions(-) diff --git a/drivers/mmc/host/omap_hsmmc.c b/drivers/mmc/host/omap_hsmmc.c index 9df2b68

Re: [PATCH] mmc: omap_hsmmc: Update driver to support without regulators

[...] Hi Ulf, Just to clarify do you have an issue with this patch or in general you rather nothave !CONFIG_REGULATOR supported? If its the latter then wouldit be better to remove the !CONFIG_REGULATOR portion from this driver all together. I don't like this patch as is, as it seems like

Re: [PATCH 1/1 linux-next] mmc: omap: use for_each_sg() for scatterlist parsing

On 16 June 2015 at 21:15, Fabian Frederick f...@skynet.be wrote: See Documentation/DMA-API.txt - Part Id Signed-off-by: Fabian Frederick f...@skynet.be Thanks, applied! Kind regards Uffe --- This is untested. drivers/mmc/host/omap.c | 5 +++-- 1 file changed, 3 insertions(+), 2

Re: [PATCH 0/3] omap_hsmmc: Fix card enumeration failure on

On 16 June 2015 at 12:37, Vignesh R vigne...@ti.com wrote: Hi, When using omap_hsmmc driver, if sd-card repeatedly plug unplugged multiple times quickly, card enumeration stops after few iterations. This can be easily reproduced on DRA74X EVM which uses omap_hsmmc driver. This patch series

Re: [PATCH] mmc: omap_hsmmc: Update driver to support without regulators

On 14 July 2015 at 21:29, Franklin S Cooper Jr fcoo...@ti.com wrote: From: Roger Quadros rog...@ti.com Update driver to support without regulators. Without this patch boards that do not enable regulator config options will fail to boot with a kernel panic. I guess that's because the rootfs

Re: [PATCH v2 07/11] mmc: host: omap_hsmmc: add tuning support

On 25 August 2015 at 11:05, Kishon Vijay Abraham I kis...@ti.com wrote: From: Balaji T K balaj...@ti.com MMC tuning procedure is required to support SD card UHS1-SDR104 mode and EMMC HS200 mode. The tuning function omap_execute_tuning() will only be called by the MMC/SD core if the

Re: [PATCH v2 16/16] mmc: host: omap_hsmmc: use mmc_of_parse_voltage to get ocr_avail

On 3 August 2015 at 14:26, Kishon Vijay Abraham I kis...@ti.com wrote: From: Roger Quadros rog...@ti.com For platforms that doesn't have explicit regulator control in MMC, populate voltage-ranges in MMC device tree node and use mmc_of_parse_voltage to get ocr_avail I don't like this. If we

Re: [PATCH 01/11] mmc: omap: fix error return code

On 23 August 2015 at 02:11, Julia Lawall julia.law...@lip6.fr wrote: Return a negative error code on failure. A simplified version of the semantic match that finds this problem is as follows: (http://coccinelle.lip6.fr/) // smpl @@ identifier ret; expression e1,e2; @@ ( if (\(ret

Re: [PATCH v2 16/16] mmc: host: omap_hsmmc: use "mmc_of_parse_voltage" to get ocr_avail

On 11 November 2015 at 11:26, Roger Quadros <rog...@ti.com> wrote: > Hi, > > On 25/08/15 17:50, Ulf Hansson wrote: >> On 3 August 2015 at 14:26, Kishon Vijay Abraham I <kis...@ti.com> wrote: >>> From: Roger Quadros <rog...@ti.com> >>> >>>

Re: All OMAP platforms: MMC is broken

On 7 October 2015 at 17:52, Tony Lindgren <t...@atomide.com> wrote: > * Ulf Hansson <ulf.hans...@linaro.org> [151007 06:46]: >> On 7 October 2015 at 15:26, Tony Lindgren <t...@atomide.com> wrote: >> >> > Good idea, how about something like the follow

Re: All OMAP platforms: MMC is broken

On 7 October 2015 at 15:26, Tony Lindgren wrote: > * Russell King - ARM Linux [151007 05:50]: >> On Tue, Oct 06, 2015 at 08:37:11AM -0700, Tony Lindgren wrote: >> > * Russell King - ARM Linux [151006 08:04]: >> > > On Tue, Oct

Re: [PATCH 1/2] Revert "mmc: host: omap_hsmmc: use regulator_is_enabled to find pbias status"

On 7 October 2015 at 15:22, Tony Lindgren wrote: > This reverts commit c55d7a0553643a7e8f120688b82b594471084d3c. > > Without reverting this commit we get "unbalanced disables for pbias_mmc_omap4" > errors on omap4430. It seems that 4430 and 4460 behave in a different way for >

Re: [PATCH 2/2] mmc: host: omap_hsmmc: Fix MMC for omap3 legacy booting

On 7 October 2015 at 15:22, Tony Lindgren wrote: > Starting with commit 7d607f917008 ("mmc: host: omap_hsmmc: use > devm_regulator_get_optional() for vmmc") MMC on omap3 stopped working > for legacy booting. > > This is because legacy booting sets up some of the resource in the

Re: All OMAP platforms: MMC is broken

On 6 October 2015 at 11:44, Tony Lindgren wrote: > * Russell King - ARM Linux [151006 02:04]: >> On Mon, Oct 05, 2015 at 07:38:13PM +0100, Russell King - ARM Linux wrote: >> > On Mon, Oct 05, 2015 at 10:11:56AM -0700, Tony Lindgren wrote: >> > > * Tony

Re: [PATCH v3 13/15] mmc: host: omap_hsmmc: use regulator_is_enabled to find pbias status

On 27 August 2015 at 14:47, Kishon Vijay Abraham I kis...@ti.com wrote: Hi Uffe, On Thursday 27 August 2015 06:12 PM, Ulf Hansson wrote: On 27 August 2015 at 14:41, Ulf Hansson ulf.hans...@linaro.org wrote: On 27 August 2015 at 11:14, Kishon Vijay Abraham I kis...@ti.com wrote: Use

Re: [PATCH v3 13/15] mmc: host: omap_hsmmc: use regulator_is_enabled to find pbias status

On 27 August 2015 at 14:41, Ulf Hansson ulf.hans...@linaro.org wrote: On 27 August 2015 at 11:14, Kishon Vijay Abraham I kis...@ti.com wrote: Use regulator_is_enabled of pbias regulator to find pbias regulator status instead of maintaining a custom bookkeeping pbias_enabled variable. Doesn't

Re: [PATCH v3 00/15] omap_hsmmc: regulator usage cleanup and fixes

On 27 August 2015 at 11:13, Kishon Vijay Abraham I kis...@ti.com wrote: This patch series does the following *) Uses devm_regulator_get_optional() for vmmc and then removes the CONFIG_REGULATOR check altogether. *) return on -EPROBE_DEFER and any other fatal errors *) enable/disable

Re: [PATCH v3 13/15] mmc: host: omap_hsmmc: use regulator_is_enabled to find pbias status

On 27 August 2015 at 11:14, Kishon Vijay Abraham I kis...@ti.com wrote: Use regulator_is_enabled of pbias regulator to find pbias regulator status instead of maintaining a custom bookkeeping pbias_enabled variable. Doesn't this cause a problem for the scenario when the initial state of the

Re: [PATCH v3 0/2] regulator: Fix pbias regulator enable

On 4 September 2015 at 14:00, Kishon Vijay Abraham I wrote: > vsel_reg and enable_reg of the pbias regulator descriptor should actually > have the offset from syscon. > > However after > "ARM: dts: : add minimal l4 bus layout with control module > support" > vsel_reg and enable_reg

Re: [PATCH v2 0/6] regulator: Fix pbias regulator enable

+Olof On 3 September 2015 at 08:50, Kishon Vijay Abraham I wrote: > vsel_reg and enable_reg of the pbias regulator descriptor should actually > have the offset from syscon. > > However after > "ARM: dts: : add minimal l4 bus layout with control module > support" > vsel_reg and

Re: [PATCH v2 00/16] omap_hsmmc: regulator usage cleanup and fixes

On 3 August 2015 at 14:26, Kishon Vijay Abraham I kis...@ti.com wrote: Changes from v1: *) return on -EPROBE_DEFER and other fatal errors. (Don't return only if the return value is -ENODEV) *) Remove the beagle x15 dts patch. It can be part of a different series. *) Avoid using

Re: [PATCH v9 0/4] Allow USB devices to remain runtime-suspended when sleeping

eroo.c | 10 +- > drivers/misc/mei/pci-me.c | 5 +++-- > drivers/misc/mei/pci-txe.c| 5 +++-- > drivers/usb/core/port.c | 6 ++ > drivers/usb/core/usb.c| 11 ++- > include/linux/device.h| 2 ++ > include/linux/pm.h

Re: [PATCH] mmc: pwrseq_simple: Fix regression with optional GPIOs

On 8 December 2015 at 01:32, Tony Lindgren <t...@atomide.com> wrote: > * Ulf Hansson <ulf.hans...@linaro.org> [151207 16:20]: >> +Linus >> >> On 7 December 2015 at 23:54, Tony Lindgren <t...@atomide.com> wrote: >> > Commit ce037275861e (&qu

Re: [PATCH] mmc: pwrseq_simple: Fix regression with optional GPIOs

+Linus On 7 December 2015 at 23:54, Tony Lindgren wrote: > Commit ce037275861e ("mmc: pwrseq_simple: use GPIO descriptors array API") > changed the handling MMC power sequence so GPIOs no longer are optional. > > This broke SDIO WLAN at least for omap5 that can't yet use the

Re: [PATCH] mmc: pwrseq_simple: Fix regression with optional GPIOs

On 18 December 2015 at 17:14, Tony Lindgren <t...@atomide.com> wrote: > * Ulf Hansson <ulf.hans...@linaro.org> [151207 16:20]: >> +Linus >> >> On 7 December 2015 at 23:54, Tony Lindgren <t...@atomide.com> wrote: >> > Commit ce037275861e (&qu

Re: [PATCH] mmc: pwrseq_simple: Fix regression with optional GPIOs

On 18 December 2015 at 23:31, Tony Lindgren <t...@atomide.com> wrote: > * Ulf Hansson <ulf.hans...@linaro.org> [151218 14:20]: >> On 18 December 2015 at 17:14, Tony Lindgren <t...@atomide.com> wrote: >> > * Ulf Hansson <ulf.hans...@linaro.org> [151207 16:2

Re: [PATCH] mmc: omap_hsmmc: No need to check DMA channel validity at module remove

On 3 November 2015 at 12:37, Peter Ujfalusi <peter.ujfal...@ti.com> wrote: > The driver will not probe without valid DMA channels so no need to check > if they are valid when the module is removed. > > Signed-off-by: Peter Ujfalusi <peter.ujfal...@ti.com> > CC: Ulf Hans