Re: [PATCH 004/182] gpio: generic: factor into gpio_chip struct

2015-12-13 Thread Linus Walleij
On Thu, Dec 10, 2015 at 12:08 AM, Michael Welling wrote: > On Wed, Dec 09, 2015 at 02:12:40PM +0100, Linus Walleij wrote: > ... >> - ret = gpiochip_add(>gc); >> + ret = gpiochip_add_data(gc, NULL); >> if (ret) { > > gpiochip_add is still mentioned in the dev_err

Re: [PATCH 004/182] gpio: generic: factor into gpio_chip struct

2015-12-13 Thread Gregory Fong
On Wed, Dec 9, 2015 at 5:12 AM, Linus Walleij wrote: > The separate struct bgpio_chip has been a pain to handle, both > by being confusingly similar in name to struct gpio_chip and > for being contained inside a struct so that struct gpio_chip > is contained in a struct

Re: [PATCH 004/182] gpio: generic: factor into gpio_chip struct

2015-12-10 Thread Lee Jones
On Wed, 09 Dec 2015, Linus Walleij wrote: > The separate struct bgpio_chip has been a pain to handle, both > by being confusingly similar in name to struct gpio_chip and > for being contained inside a struct so that struct gpio_chip > is contained in a struct contained in a struct, making several

Re: [PATCH 004/182] gpio: generic: factor into gpio_chip struct

2015-12-09 Thread Liviu Dudau
On Wed, Dec 09, 2015 at 02:12:40PM +0100, Linus Walleij wrote: > The separate struct bgpio_chip has been a pain to handle, both > by being confusingly similar in name to struct gpio_chip and > for being contained inside a struct so that struct gpio_chip > is contained in a struct contained in a

RE: [PATCH 004/182] gpio: generic: factor into gpio_chip struct

2015-12-09 Thread Hartley Sweeten
On Wednesday, December 09, 2015 6:13 AM, Linus Walleij wrote: > The separate struct bgpio_chip has been a pain to handle, both > by being confusingly similar in name to struct gpio_chip and > for being contained inside a struct so that struct gpio_chip > is contained in a struct contained in a

Re: [PATCH 004/182] gpio: generic: factor into gpio_chip struct

2015-12-09 Thread Michael Welling
On Wed, Dec 09, 2015 at 02:12:40PM +0100, Linus Walleij wrote: ... > @@ -55,16 +54,16 @@ static int moxart_gpio_probe(struct platform_device *pdev) > return ret; > } > > - bgc->gc.label = "moxart-gpio"; > - bgc->gc.request = gpiochip_generic_request; > -

Re: [PATCH 004/182] gpio: generic: factor into gpio_chip struct

2015-12-09 Thread Krzysztof Kozlowski
On 09.12.2015 22:12, Linus Walleij wrote: > The separate struct bgpio_chip has been a pain to handle, both > by being confusingly similar in name to struct gpio_chip and > for being contained inside a struct so that struct gpio_chip > is contained in a struct contained in a struct, making several

Re: [PATCH 004/182] gpio: generic: factor into gpio_chip struct

2015-12-09 Thread Tony Lindgren
* Linus Walleij [151209 05:14]: > The separate struct bgpio_chip has been a pain to handle, both > by being confusingly similar in name to struct gpio_chip and > for being contained inside a struct so that struct gpio_chip > is contained in a struct contained in a