Re: [rds-devel] net-next pull request: RDS

2010-09-15 Thread Or Gerlitz
Andrew Grover wrote: Once net-next gets pushed to mainline and Roland pulls from that, then we'll be in a good position to put these helpers where they should go, and change other ULPs to use them. Andy, as Roland commented, you can push such helpers through Dave once Roland made a review

Re: [PATCH v2] ibsim: allocate mft according to number of switch ports

2010-09-15 Thread Eli Dorfman (Voltaire)
allocate mft according to number of switch ports calculate number of port masks according to number of switch ports and allocate MFT accordingly Signed-off-by: Eli Dorfman e...@voltaire.com --- ibsim/sim.h |5 ++--- ibsim/sim_mad.c |5 +++-- ibsim/sim_net.c |5 +++-- 3 files

BUG_ON fired in rds

2010-09-15 Thread Eli Cohen
Hi Andy, I see BUG_ON(irqs_disabled()) fired in rds where rds_rdma_free_op() is called from interrupt handler. Below is the call stack that shows this. [ 8785.787801] kernel BUG at /var/tmp/OFED_topdir/BUILD/ofa_kernel-1.5.2/net/rds/rdma.c:453! [ 8785.796852] invalid opcode: [#1] SMP [

RE: [patch] infiniband: nes_cm: remove unneeded variable

2010-09-15 Thread Latif, Faisal
-Original Message- From: Dan Carpenter [mailto:erro...@gmail.com] Sent: Wednesday, September 15, 2010 11:33 AM To: Latif, Faisal Cc: Tung, Chien Tin; Roland Dreier; Or Gerlitz; linux- r...@vger.kernel.org; kernel-janit...@vger.kernel.org Subject: [patch] infiniband: nes_cm: remove

how to safely tear down a cm_id?

2010-09-15 Thread Zach Brown
Hi gang, We're chasing some bugs in RDS. In trying to explore possible causes I found that I don't really understand the sequence of events needed to safely tear down a cm_id. I'm worried that we have cm event callbacks being processed in the ib_cm thread racing with our krds thread which is

RE: how to safely tear down a cm_id?

2010-09-15 Thread Hefty, Sean
rdma_disconnect(cm_id); rdma_destroy_qp(cm_id); rdma_destroy_id(cm_id); We blow through all of those without waiting for anything specifically CM related. We could wait for some send and receive work completions, sure, but we might not if the

Re: how to safely tear down a cm_id?

2010-09-15 Thread Zach Brown
rdma_destroy_id will block until all CM callbacks complete. rdma_disconnect does not. It merely issues or responds to a disconnect request. If it issues a disconnect request, then a disconnect callback will eventually follow, possibly before rdma_disconnect returns. Thanks, that's just

Re: [PATCH] [IPOIB] Check for a MTU overflow on the GSO path

2010-09-15 Thread Jason Gunthorpe
On Wed, Sep 15, 2010 at 02:27:39PM +0200, Or Gerlitz wrote: Jason Gunthorpe wrote: The code to check that the send packet size is less than the MTU is only invoked in the non-GSO case. This lets packets which are too large pass through. Jason, Did you get here following code inspection