Re: [patch v2 02/37] add opcodes to ib_pack.h

2011-08-15 Thread Bart Van Assche
On Sun, Jul 24, 2011 at 9:43 PM, rpear...@systemfabricworks.com wrote: Bring up to date with the current version of the IBTA spec.        - add new opcodes for RC and RD        - add new groups of opcodes for CN and XRC Signed-off-by: Bob Pearson rpear...@systemfabricworks.com ---  

[PATCH 1/2] librdmacm: Fix resource leak in error flow

2011-08-15 Thread Dotan Barak
Prevent resource leak by destroying the event channel before returning from function in an error flow. Signed-off-by: Dotan Barak dot...@dev.mellanox.co.il --- diff --git a/src/cma.c b/src/cma.c index bad1ba3..1367779 100755 --- a/src/cma.c +++ b/src/cma.c @@ -2122,8 +2122,11 @@ int

[PATCH 2/2] librdmacm: fix resource leaks when CMA_CREATE_MSG_CMD_RESP fails

2011-08-15 Thread Dotan Barak
If the macro CMA_CREATE_MSG_CMD_RESP is being called and there is a failure, the macro should release the allocated resources before returning from the called function Signed-off-by: Dotan Barak dot...@dev.mellanox.co.il --- diff --git a/src/cma.c b/src/cma.c index bad1ba3..0512187 100755 ---

Re: [patch v2 12/37] add rxe_verbs.h

2011-08-15 Thread Bart Van Assche
On Sun, Jul 24, 2011 at 9:43 PM, rpear...@systemfabricworks.com wrote: +static inline int pkey_match(u16 key1, u16 key2) +{ + return (((key1 0x7fff) != 0) + ((key1 0x7fff) == (key2 0x7fff)) + ((key1 0x8000) || (key2 0x8000))) ? 1 : 0; +} Shouldn't the

Re: [patch v2 12/37] add rxe_verbs.h

2011-08-15 Thread Bart Van Assche
On Sun, Jul 24, 2011 at 9:43 PM, rpear...@systemfabricworks.com wrote: + rxe_qp.c:char *rxe_qp_state_name[] = { One more comment about rxe_verbs.h: why is the above declaration present in this header file ? As far as I can see it's only used in rxe_qp.c and not in any other source file. Bart.

Re: [patch v2 13/37] add rxe_verbs.c

2011-08-15 Thread Bart Van Assche
On Sun, Jul 24, 2011 at 9:43 PM, rpear...@systemfabricworks.com wrote: +static int rxe_query_port(struct ib_device *dev, + u8 port_num, struct ib_port_attr *attr) +{ + struct rxe_dev *rxe = to_rdev(dev); + struct rxe_port *port; + + if (unlikely(port_num

Re: [patch v2 13/37] add rxe_verbs.c

2011-08-15 Thread Bart Van Assche
On Sun, Jul 24, 2011 at 9:43 PM, rpear...@systemfabricworks.com wrote: + for (i = 0; i ARRAY_SIZE(rxe_dev_attributes); ++i) { + err = device_create_file(dev-dev, rxe_dev_attributes[i]); + if (err) { + pr_warn(device_create_file failed, +

Re: [patch v2 13/37] add rxe_verbs.c

2011-08-15 Thread Bart Van Assche
On Mon, Aug 15, 2011 at 4:45 PM, Greg KH gre...@suse.de wrote: On Mon, Aug 15, 2011 at 04:33:14PM +0200, Bart Van Assche wrote: On Sun, Jul 24, 2011 at 9:43 PM,  rpear...@systemfabricworks.com wrote: +   for (i = 0; i ARRAY_SIZE(rxe_dev_attributes); ++i) { +           err =

Re: [patch v2 13/37] add rxe_verbs.c

2011-08-15 Thread Greg KH
On Mon, Aug 15, 2011 at 04:58:44PM +0200, Bart Van Assche wrote: On Mon, Aug 15, 2011 at 4:45 PM, Greg KH gre...@suse.de wrote: On Mon, Aug 15, 2011 at 04:33:14PM +0200, Bart Van Assche wrote: On Sun, Jul 24, 2011 at 9:43 PM,  rpear...@systemfabricworks.com wrote: +   for (i = 0; i

[Bug 41212] New: [regression] [3.1-git] ipoib causes kernel panic (NULL pointer dereference)

2011-08-15 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=41212 Summary: [regression] [3.1-git] ipoib causes kernel panic (NULL pointer dereference) Product: Networking Version: 2.5 Kernel Version: 3.1-git Platform: All OS/Version:

Re: [patch v2 13/37] add rxe_verbs.c

2011-08-15 Thread Greg KH
On Mon, Aug 15, 2011 at 06:02:23PM +0200, Bart Van Assche wrote: On Mon, Aug 15, 2011 at 5:07 PM, Greg KH gre...@suse.de wrote: For a device, you HAVE to be creating these attributes before the hotplug event is sent out, and to do that, you need to set the correct pointer before registering

Re: [patch v2 21/37] add rxe_qp.c

2011-08-15 Thread Bart Van Assche
On Sun, Jul 24, 2011 at 9:43 PM, rpear...@systemfabricworks.com wrote: +char *rxe_qp_state_name[] = { + [QP_STATE_RESET]= RESET, + [QP_STATE_INIT] = INIT, + [QP_STATE_READY]= READY, + [QP_STATE_DRAIN]= DRAIN, + [QP_STATE_DRAINED] =

RE: [patch v2 02/37] add opcodes to ib_pack.h

2011-08-15 Thread Bob Pearson
Originally I had xrc support in rxe but there was nothing in Roland's tree to support it so I stripped it out. I was experimenting with congestion notification to see if there was a way to slow down spewing by fast Ethernet devices but that wasn't working, also all the MAD support was stripped

Re: [patch v2 13/37] add rxe_verbs.c

2011-08-15 Thread Bart Van Assche
On Sun, Jul 24, 2011 at 9:43 PM, rpear...@systemfabricworks.com wrote: +static ssize_t rxe_show_skb_num(struct device *device, + struct device_attribute *attr, char *buf) +{ + struct rxe_dev *rxe = container_of(device, struct rxe_dev, +

Re: [patch v2 21/37] add rxe_qp.c

2011-08-15 Thread Jason Gunthorpe
On Mon, Aug 15, 2011 at 06:13:57PM +0200, Bart Van Assche wrote: On Sun, Jul 24, 2011 at 9:43 PM, rpear...@systemfabricworks.com wrote: +char *rxe_qp_state_name[] = { + [QP_STATE_RESET]= RESET, + [QP_STATE_INIT] = INIT, + [QP_STATE_READY]= READY, +

Re: Question about dead code int he libibverbs

2011-08-15 Thread Roland Dreier
On Sun, Aug 14, 2011 at 4:08 AM, Dotan Barak dot...@dev.mellanox.co.il wrote: I read the code of the libibverbs and I noticed the following code:     file: memory.c     function ibv_madvise_range(): The code: snip start     if (node) {     tmp = __mm_prev(node);   

[PATCH] libibmad/dump.c: Add IsOptionalIPDSupported into mad_dump_portcapmask

2011-08-15 Thread Hal Rosenstock
Signed-off-by: Hal Rosenstock h...@mellanox.com --- diff --git a/src/dump.c b/src/dump.c index 29fb742..b0388dd 100644 --- a/src/dump.c +++ b/src/dump.c @@ -542,6 +542,8 @@ void mad_dump_portcapmask(char *buf, int bufsz, void *val, int valsz) s += sprintf(s,

[PATCH] libibmad: Add support for PortInfo CapabilityMask2

2011-08-15 Thread Hal Rosenstock
Signed-off-by: Hal Rosenstock h...@mellanox.com --- diff --git a/include/infiniband/mad.h b/include/infiniband/mad.h index 6d65a29..25c1141 100644 --- a/include/infiniband/mad.h +++ b/include/infiniband/mad.h @@ -772,6 +772,7 @@ enum MAD_FIELDS { /* * More PortInfo fields

[PATCH] libibmad/dump.c: Allow 0 (extended speed active) in mad_dump_linkspeed

2011-08-15 Thread Hal Rosenstock
for PortInfo:LinkSpeedEnabled Signed-off-by: Hal Rosenstock h...@mellanox.com --- diff --git a/src/dump.c b/src/dump.c index 29fb742..00831a3 100644 --- a/src/dump.c +++ b/src/dump.c @@ -244,6 +244,9 @@ void mad_dump_linkspeed(char *buf, int bufsz, void *val, int valsz) int speed =

[PATCH] infiniband-diags/smpquery: Add support for extended link speeds

2011-08-15 Thread Hal Rosenstock
Signed-off-by: Hal Rosenstock h...@mellanox.com --- diff --git a/man/smpquery.8 b/man/smpquery.8 index afd02db..c4cb8f2 100644 --- a/man/smpquery.8 +++ b/man/smpquery.8 @@ -6,8 +6,8 @@ smpquery \- query InfiniBand subnet management attributes .SH SYNOPSIS .B smpquery [\-d(ebug)] [\-e(rr_show)]

[PATCH] infiniband-diags/saquery: Add extended link speed support for PortInfoRecord queries

2011-08-15 Thread Hal Rosenstock
Signed-off-by: Hal Rosenstock h...@mellanox.com --- diff --git a/man/saquery.8 b/man/saquery.8 index 4a3102d..56fbbee 100644 --- a/man/saquery.8 +++ b/man/saquery.8 @@ -1,4 +1,4 @@ -.TH SAQUERY 8 March 28, 2010 OpenIB OpenIB Diagnostics +.TH SAQUERY 8 March 14, 2011 OpenIB OpenIB Diagnostics

[PATCH] infiniband-diags/perfquery: Add support for extended link speeds

2011-08-15 Thread Hal Rosenstock
PortExtendedSpeedsCounters attribute Signed-off-by: Hal Rosenstock h...@mellanox.com --- diff --git a/man/perfquery.8 b/man/perfquery.8 index 7acc60c..8635e41 100644 --- a/man/perfquery.8 +++ b/man/perfquery.8 @@ -1,4 +1,4 @@ -.TH PERFQUERY 8 Jun 16, 2010 OpenIB OpenIB Diagnostics +.TH PERFQUERY