Re: [patch v2 02/37] add opcodes to ib_pack.h

2011-08-20 Thread Bart Van Assche
On Mon, Aug 15, 2011 at 6:15 PM, Bob Pearson rpear...@systemfabricworks.com wrote: I want to eventually complete the IB transport parts of the driver although they are not used by RoCE. They would be useful for a soft IB implementation with say an FPGA based MAC/PHY. The long term goal is to

Re: [patch v2 31/37] add rxe.c

2011-08-20 Thread Bart Van Assche
On Sun, Jul 24, 2011 at 9:43 PM, rpear...@systemfabricworks.com wrote: +int rxe_fast_comp = 2; +module_param_named(fast_comp, rxe_fast_comp, int, 0644); +MODULE_PARM_DESC(fast_comp, fast path call to completer + (0=no, 1=no int context, 2=any context)); + +int rxe_fast_resp =

Re: [patch v2 06/37] add rxe_param.h

2011-08-20 Thread Bart Van Assche
On Sun, Jul 24, 2011 at 9:43 PM, rpear...@systemfabricworks.com wrote: +enum rxe_mtu { + RXE_MTU_INVALID = 0, + RXE_MTU_256 = 1, + RXE_MTU_512 = 2, + RXE_MTU_1024= 3, + RXE_MTU_2048= 4, + RXE_MTU_4096= 5, + RXE_MTU_8192= 6, +}; Do the

Re: [patch v2 29/37] add rxe_dma.c

2011-08-20 Thread Bart Van Assche
On Sun, Jul 24, 2011 at 9:43 PM, rpear...@systemfabricworks.com wrote: +static u64 rxe_dma_map_single(struct ib_device *dev, + void *cpu_addr, size_t size, + enum dma_data_direction direction) +{ +

Re: [patch v2 20/37] add rxe_cq.c

2011-08-20 Thread Bart Van Assche
On Sun, Jul 24, 2011 at 9:43 PM, rpear...@systemfabricworks.com wrote: +int rxe_cq_chk_attr(struct rxe_dev *rxe, struct rxe_cq *cq, + int cqe, int comp_vector, struct ib_udata *udata) +{ + int count; + + if (cqe = 0) { + pr_warn(cqe(%d) = 0\n, cqe); +

Re: [patch v2 27/37] add rxe_resp.c

2011-08-20 Thread Bart Van Assche
On Sun, Jul 24, 2011 at 9:43 PM, rpear...@systemfabricworks.com wrote: +static char *resp_state_name[] = { + [RESPST_NONE] = NONE, Shouldn't that be const char * const instead of char * ? +/* rxe_recv calls here to add a request packet to the input queue */