[PATCH 33/57] infiniband: irq: Remove IRQF_DISABLED

2011-09-21 Thread Yong Zhang
Since commit [c58543c8: genirq: Run irq handlers with interrupts disabled], We run all interrupt handlers with interrupts disabled and we even check and yell when an interrupt handler returns with interrupts enabled (see commit [b738a50a: genirq: Warn when handler enables interrupts]). So now

Re: [PATCH] infiniband-diags: ibnetdisc Wrap header for use in C++ code

2011-09-21 Thread Bart Van Assche
On Tue, Sep 20, 2011 at 7:45 PM, Ira Weiny wei...@llnl.gov wrote: +#ifdef __cplusplus +extern C { +#endif +  #include stdio.h  #include infiniband/mad.h  #include iba/ib_types.h It is bad style to surround #include directives with 'extern C'. Bart. -- To unsubscribe from this list: send

Re: [PATCH/ibsim] Provide support for SubnSet(GUIDInfo)

2011-09-21 Thread Hal Rosenstock
On Mon, Sep 19, 2011 at 4:06 PM, Jason Gunthorpe jguntho...@obsidianresearch.com wrote: On Mon, Sep 19, 2011 at 03:55:24PM -0400, Hal Rosenstock wrote: Is this just to make the set of guidinfo simple ? Longer term, this should support a GUIDCap 1 but I suppose that could be a follow on

Re: creating common ib_types.h for linux and windows

2011-09-21 Thread Alex Netes
On 14:23 Tue 20 Sep , Hefty, Sean wrote: Why to test for __WIN__ instead of _WIN32 (defined both when building 32-bit and 64-bit code -- see also http://msdn.microsoft.com/en-us/library/b0084kay%28v=vs.80%29.aspx) ? I have no idea. This is just what's currently in the code. I can

[PATCH] mlx4_core: fix allocation size

2011-09-21 Thread Eli Cohen
The num_free field of mlx4_buddy has a type of array of unsigned int while it was allocated as an array of pointers. On 64 bit platforms it would allocate twice more than required. Fix this by allocating the correct size for the type. Signed-off-by: Eli Cohen e...@mellanox.co.il ---

RE: creating common ib_types.h for linux and windows

2011-09-21 Thread Smith, Stan
-Original Message- From: linux-rdma-ow...@vger.kernel.org [mailto:linux-rdma-ow...@vger.kernel.org] On Behalf Of Alex Netes Sent: Wednesday, September 21, 2011 6:30 AM To: Hefty, Sean Cc: Bart Van Assche; linux-rdma (linux-rdma@vger.kernel.org); Hal Rosenstock (hal.rosenst...@gmail.com);

Re: [infiniband-diags] [libibmad] Support new ibccquery congestion control tool

2011-09-21 Thread Hal Rosenstock
Hi Al, On Mon, Sep 19, 2011 at 6:06 PM, Albert Chu ch...@llnl.gov wrote: The following patches add a new tool ibccquery to infiniband-diags.  It supports the querying of various congestion control settings.  Related updates to libibmad are also included. Looks good to me :-) Just a few

Re: [PATCH/RFC] mlx4_core: Clean up error flow in mlx4_register_mac()

2011-09-21 Thread Or Gerlitz
On 9/20/2011 10:53 AM, Roland Dreier wrote: Fix a leak of entry if radix_tree_insert() fails. Also, reduce the indentation and make the flow easier to read Looks fine to me Acked-by: Or Gerlitz ogerl...@mellanox.com Yevgeny? Or. -- To unsubscribe from this list: send the line unsubscribe

RE: [PATCH/RFC] mlx4_core: Clean up error flow in mlx4_register_mac()

2011-09-21 Thread Yevgeny Petrilin
Fix a leak of entry if radix_tree_insert() fails. Also, reduce the indentation and make the flow easier to read Looks fine to me Acked-by: Or Gerlitz ogerl...@mellanox.com Yevgeny? The fix is OK. -- To unsubscribe from this list: send the line unsubscribe linux-rdma in the body of a

Re: [infiniband-diags] [libibmad] Support new ibccquery congestion control tool

2011-09-21 Thread Ira Weiny
On Wed, 21 Sep 2011 07:17:38 -0700 Hal Rosenstock hal.rosenst...@gmail.com wrote: Hi Al, On Mon, Sep 19, 2011 at 6:06 PM, Albert Chu ch...@llnl.gov wrote: The following patches add a new tool ibccquery to infiniband-diags.  It supports the querying of various congestion control settings.  

RE: creating common ib_types.h for linux and windows

2011-09-21 Thread Hefty, Sean
What is your end goal? To have one code base for OpenSM that would be able to be compiled on both Linux and Windows based on __WIN__ definition? My end goal is to decrease the maintenance cost porting opensm to Windows. Ideally, I'd like to have a common code base for opensm, similar to what

[PATCH] IB/qib: Correct nfreectxts for multiple HCAs

2011-09-21 Thread Mike Marciniszyn
The code that was recently introduced to report the number of free contexts is flawed for multiple HCAs: /* Return the number of free user ports (contexts) available. */ return scnprintf(buf, PAGE_SIZE, %u\n, dd-cfgctxts - dd-first_user_ctxt -

Re: [PATCH/ibsim] Provide support for SubnSet(GUIDInfo)

2011-09-21 Thread Jason Gunthorpe
On Wed, Sep 21, 2011 at 09:04:45AM -0400, Hal Rosenstock wrote: On Mon, Sep 19, 2011 at 4:06 PM, Jason Gunthorpe jguntho...@obsidianresearch.com wrote: On Mon, Sep 19, 2011 at 03:55:24PM -0400, Hal Rosenstock wrote: Is this just to make the set of guidinfo simple ? Longer term, this

Re: [PATCH] infiniband-diags: ibnetdisc Wrap header for use in C++ code

2011-09-21 Thread Ira Weiny
On Wed, 21 Sep 2011 03:11:04 -0700 Bart Van Assche bvanass...@acm.org wrote: On Tue, Sep 20, 2011 at 7:45 PM, Ira Weiny wei...@llnl.gov wrote: +#ifdef __cplusplus +extern C { +#endif +  #include stdio.h  #include infiniband/mad.h  #include iba/ib_types.h It is bad style to

[PATCH] Set BuildArch to noarch

2011-09-21 Thread Goldwyn Rodrigues
A documentation package should be built as noarch since it does not carry any binaries. Also removed executable permissions from dhcp/dhcp-3.0.4/*.patch Signed-off-by: Goldwyn Rodrigues rgold...@suse.de --- ofed-docs.spec |1 + 1 files changed, 1

Re: [infiniband-diags] [libibmad] Support new ibccquery congestion control tool

2011-09-21 Thread Ira Weiny
On Wed, 21 Sep 2011 08:49:34 -0700 Ira Weiny wei...@llnl.gov wrote: On Wed, 21 Sep 2011 07:17:38 -0700 Hal Rosenstock hal.rosenst...@gmail.com wrote: Hi Al, snip On 0001-Support-ibccquery-congestion-control-query-tool.patch, I'm worried about the following: + /* XXX:

Re: [PATCH] mlx4_core: fix allocation size

2011-09-21 Thread Roland Dreier
Thanks, applied (and I also queued up a fix for the same bug in mthca) -- To unsubscribe from this list: send the line unsubscribe linux-rdma in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [infiniband-diags] [libibmad] Support new ibccquery congestion control tool

2011-09-21 Thread Albert Chu
Hey Hal, Ira answered most of the important stuff already. But some extra details ... Second the current alignment breaks libibmad. So it would be a lot more code to support the miss-alignment and would probably have to be changed anyway. As far as I can tell, all the code in libibmad

ib-diags: compatability issue with ibstat

2011-09-21 Thread Hefty, Sean
commit 1344cb3feacafc462440dabfa5997c5205486d83 added support for FDR10 in a way that is not compatible with Windows support. Windows does not use files to read attribute information. I will probably need to obtain the necessary information using ibverbs on windows by reading port attributes.

Re: ib-diags: compatability issue with ibstat

2011-09-21 Thread Ira Weiny
On Wed, 21 Sep 2011 12:06:12 -0700 Hefty, Sean sean.he...@intel.com wrote: commit 1344cb3feacafc462440dabfa5997c5205486d83 added support for FDR10 in a way that is not compatible with Windows support. Windows does not use files to read attribute information. Ok, I think you meant commit

RE: ib-diags: compatability issue with ibstat

2011-09-21 Thread Hefty, Sean
Does this mean ibstatus does not work on Windows? We do not support any of the scripts on windows. As far as I could tell, the scripts look like they just do post-processing of available output. How are you proposing the addition to ibverbs? It seems this would break ABI there. On

Re: ib-diags: compatability issue with ibstat

2011-09-21 Thread Ira Weiny
On Wed, 21 Sep 2011 15:23:45 -0700 Hefty, Sean sean.he...@intel.com wrote: Does this mean ibstatus does not work on Windows? We do not support any of the scripts on windows. As far as I could tell, the scripts look like they just do post-processing of available output. Good to know,

Re: ib-diags: compatability issue with ibstat

2011-09-21 Thread Jason Gunthorpe
On Wed, Sep 21, 2011 at 03:32:54PM -0700, Ira Weiny wrote: To be clear I am not against using ibverbs on the linux side. It sounds like that would be the best move going forward. Technically umad already needs to use verbs on Linux because that is the only way to get the subnet timeout value

Re: ib-diags: compatability issue with ibstat

2011-09-21 Thread Ira Weiny
On Wed, 21 Sep 2011 15:32:54 -0700 Ira Weiny wei...@llnl.gov wrote: On Wed, 21 Sep 2011 15:23:45 -0700 Hefty, Sean sean.he...@intel.com wrote: Does this mean ibstatus does not work on Windows? We do not support any of the scripts on windows. As far as I could tell, the scripts