[PATCH 3/5] net/mlx4_core: remove module param controlling the vlan table size

2011-10-10 Thread Or Gerlitz
Enable the maximum size (128) supported by the device for the shadow vlans table, without a module param to override it. This table is only used by the IBoE control plane for setting a vlan index into an RC/UC QP context or UD Address Handle. Signed-off-by: Or Gerlitz ogerl...@mellanox.com ---

[PATCH 4/5] ib/core: add support for extended performance counters in sysfs

2011-10-10 Thread Or Gerlitz
issue a PMA classportinfo query towards the HW driver, and if extended counters are supported, expose new sysfs entries which allow to read them. Signed-off-by: Vu Pham v...@mellanox.com Signed-off-by: Or Gerlitz ogerl...@mellanox.com --- --- drivers/infiniband/core/sysfs.c | 100

[PATCH 5/5] ib/mlx4: added support for extended PMA counters under IBoE

2011-10-10 Thread Or Gerlitz
With the HW counters being 64bit ones, use the existing IBoE PMA counters to support also extended counters. Signed-off-by: Vu Pham v...@mellanox.com Signed-off-by: Or Gerlitz ogerl...@mellanox.com --- drivers/infiniband/hw/mlx4/mad.c | 49 - 1 files

Re: libmlx4 and setting the doorbell qpn

2011-10-10 Thread Roland Dreier
On Sat, Oct 8, 2011 at 8:12 AM, Bart Van Assche bvanass...@acm.org wrote: While reviewing the compiler warnings triggered by the libmlx4 source code, I came across this statement in src/qp.c:        *(uint32_t *) ctrl-reserved |= qp-doorbell_qpn; which triggers this warning:    

Re: [PATCH 3/5] net/mlx4_core: remove module param controlling the vlan table size

2011-10-10 Thread Roland Dreier
-static int log_num_vlan; -module_param_named(log_num_vlan, log_num_vlan, int, 0444); -MODULE_PARM_DESC(log_num_vlan, Log2 max number of VLANs per ETH port (0-7)); Can we really do this? Doesn't this break anyone who has this option configured in modprobe.conf? This is one reason why I

libmlx4: Pass the argument foreign to AM_INIT_AUTOMAKE()

2011-10-10 Thread Bart Van Assche
Tell automake explicitly that the libmlx4 package is not a GNU package. This change makes it possible to regenerate the configure script via autoreconf instead of only via autogen.sh. Signed-off-by: Bart Van Assche bvanass...@acm.org --- configure.in |2 +- 1 files changed, 1 insertions(+),

[PATCH] libibverbs: Make it easy to interpret struct ibv_gid as four 32-bit words

2011-10-10 Thread Bart Van Assche
Signed-off-by: Bart Van Assche bvanass...@acm.org --- include/infiniband/verbs.h |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/include/infiniband/verbs.h b/include/infiniband/verbs.h index ad9d524..656abb8 100644 --- a/include/infiniband/verbs.h +++

[PATCH] libmlx4: Fix a compiler warning

2011-10-10 Thread Bart Van Assche
Avoid that link_local_gid() triggers the following compiler warning: dereferencing type-punned pointer will break strict-aliasing rules Signed-off-by: Bart Van Assche bvanass...@acm.org --- src/verbs.c |8 +++- 1 files changed, 3 insertions(+), 5 deletions(-) diff --git a/src/verbs.c

Re: [PATCH 3/3] RDMA/nes: Support for Packed And Unaligned fpdus

2011-10-10 Thread Roland Dreier
Applied, but... --- /dev/null +++ b/drivers/infiniband/hw/nes/nes_mgt.c +void nes_replenish_mgt_rq(struct nes_vnic_mgt *mgtvnic) Most of these functions are only used in nes_mgt.c and can be made static. I fixed that up. +                       barrier(); barrier() is only a compiler

Re: libmlx4 and setting the doorbell qpn

2011-10-10 Thread Roland Dreier
On Mon, Oct 10, 2011 at 10:36 AM, Bart Van Assche bvanass...@acm.org wrote: If I interpret the above correctly, if two pointers point to the same memory location but have different types (other than char *) and both pointers are used to store a value, then with -fstrict-aliasing enabled the

Re: libmlx4: Pass the argument foreign to AM_INIT_AUTOMAKE()

2011-10-10 Thread Roland Dreier
Thanks... I already have this locally (waiting to get my kernel.org tree back up and/or have time to set up a github mirror before I push this out) - R. On Mon, Oct 10, 2011 at 10:41 AM, Bart Van Assche bvanass...@acm.org wrote: Tell automake explicitly that the libmlx4 package is not a GNU

RE: [PATCH -next] infiniband: fix ipath_chip_init.c build errors

2011-10-10 Thread Mike Marciniszyn
As do I. I've confirmed that patch does no harm, but I would like to see the error. Which of the github repos exposes the error? Mike -Original Message- From: Roland Dreier [mailto:rol...@purestorage.com] Sent: Friday, October 07, 2011 5:21 PM To: Randy Dunlap Cc: Stephen

Re: [PATCH -next] infiniband: fix ipath_chip_init.c build errors

2011-10-10 Thread Randy Dunlap
On 10/10/11 11:57, Mike Marciniszyn wrote: As do I. I've confirmed that patch does no harm, but I would like to see the error. Which of the github repos exposes the error? I saw it in linux-next of 20111007. Mike -Original Message- From: Roland Dreier

RE: [PATCH 3/3] RDMA/nes: Support for Packed And Unaligned fpdus

2011-10-10 Thread Latif, Faisal
Thanks, I will test it again to make sure. Faisal -Original Message- From: rol...@purestorage.com [mailto:rol...@purestorage.com] On Behalf Of Roland Dreier Sent: Monday, October 10, 2011 1:05 PM To: Latif, Faisal Cc: linux-rdma@vger.kernel.org Subject: Re: [PATCH 3/3]

Re: [PATCH -next] infiniband: fix ipath_chip_init.c build errors

2011-10-10 Thread Roland Dreier
On Fri, Oct 7, 2011 at 3:05 PM, Randy Dunlap rdun...@xenotime.net wrote: First I saw it was in today's linux-next (20111007). Got it... a latent problem exposed by some include clean up, probably. Applied, thanks. -- To unsubscribe from this list: send the line unsubscribe linux-rdma in the

RE: [PATCH 2/3] RDMA/nes: Print ip address for critcal errors

2011-10-10 Thread Latif, Faisal
Hi Roland, Sorry for late reply. Yes %pI4 would be a lot cleaner. Do you want me to resubmit this patch again? Thanks Faisal -Original Message- From: rol...@purestorage.com [mailto:rol...@purestorage.com] On Behalf Of Roland Dreier Sent: Thursday, October 06, 2011 2:54 PM To:

Re: [PATCH 2/3] RDMA/nes: Print ip address for critcal errors

2011-10-10 Thread Roland Dreier
Actually I fixed it up myself, please check my result :) On Mon, Oct 10, 2011 at 12:00 PM, Latif, Faisal faisal.la...@intel.com wrote: Hi Roland, Sorry for late reply. Yes %pI4 would be a lot cleaner. Do you want me to resubmit this patch again? Thanks Faisal -Original Message-

Re: libmlx4 and setting the doorbell qpn

2011-10-10 Thread Yann Droneaud
Le lundi 10 octobre 2011 à 09:28 -0700, Roland Dreier a écrit : actually I think the relevant definitions are: struct mlx4_wqe_ctrl_seg *ctrl; and struct mlx4_wqe_ctrl_seg { uint32_towner_opcode; uint8_t reserved[3]; ...

Re: [PATCH -next] infiniband: fix ipath_chip_init.c build errors

2011-10-10 Thread Stephen Rothwell
On Mon, 10 Oct 2011 12:02:29 -0700 Roland Dreier rol...@purestorage.com wrote: On Fri, Oct 7, 2011 at 3:05 PM, Randy Dunlap rdun...@xenotime.net wrote: First I saw it was in today's linux-next (20111007). Got it... a latent problem exposed by some include clean up, probably. Almost

Re: [PATCH] libmlx4: Fix a compiler warning

2011-10-10 Thread Roland Dreier
On Mon, Oct 10, 2011 at 10:47 AM, Bart Van Assche bvanass...@acm.org wrote: -       uint32_t hi = *(uint32_t *)(gid-raw); -       uint32_t lo = *(uint32_t *)(gid-raw + 4); -       if (hi == htonl(0xfe80) lo == 0) -               return 1; +       uint32_t hi = gid-u32[0]; +      

linux-next: build failure after merge of the infiniband tree

2011-10-10 Thread Stephen Rothwell
Hi all, After merging the infiniband tree, today's linux-next build (x86_64 allmodconfig) failed like this: drivers/infiniband/hw/nes/nes_mgt.c: In function 'get_fpdu_info': drivers/infiniband/hw/nes/nes_mgt.c:328:3: error: 'NES_DBG_PAU' undeclared (first use in this function)