RE: [PATCH V2] libibverbs: Allow arbitrary int values for MTU

2013-07-16 Thread Hefty, Sean
Jeff's patch doesn't break old binaries, old binaries, running with normal IB MTUs work fine. The structure layouts all stay the same, etc. FWIW, I did a simple test to confirm this. I installed a stock git HEAD libibverbs into $HOME/libibverbs-HEAD and a libibverbs with the MTU patch

Re: [PATCH v3 11/13] IB/srp: Make HCA completion vector configurable

2013-07-16 Thread Sagi Grimberg
On 7/15/2013 9:23 PM, Bart Van Assche wrote: On 15/07/2013 7:29, Sagi Grimberg wrote: srp_daemon is a package designated for the customer to automatically detect targets in the IB fabric. From our experience here in Mellanox, customers/users like automatic plugplay tools. They are reluctant to

Re: [PATCH v3 11/13] IB/srp: Make HCA completion vector configurable

2013-07-16 Thread Bart Van Assche
On 16/07/2013 4:11, Sagi Grimberg wrote: This sounds like a nice Idea, but there an inherent problem about applications coming and going while the connections are static (somewhat), how can you control pinning an arbitrary application running (over SRP devices of-course) at certain point of

Re: [PATCH v3 11/13] IB/srp: Make HCA completion vector configurable

2013-07-16 Thread Sagi Grimberg
On 7/16/2013 1:58 PM, Bart Van Assche wrote: On 16/07/2013 4:11, Sagi Grimberg wrote: This sounds like a nice Idea, but there an inherent problem about applications coming and going while the connections are static (somewhat), how can you control pinning an arbitrary application running (over

[PATCH] mlx5: qp: variable may be used uninitialized

2013-07-16 Thread Andi Shyti
in the sq_overhead() function, if qp_typ is equal to IB_QPT_RC, size will be used uninitialized. Signed-off-by: Andi Shyti a...@etezian.org --- drivers/infiniband/hw/mlx5/qp.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/infiniband/hw/mlx5/qp.c

Re: [PATCH V2] libibverbs: Allow arbitrary int values for MTU

2013-07-16 Thread Jason Gunthorpe
On Tue, Jul 16, 2013 at 08:04:08AM +, Hefty, Sean wrote: Jeff's patch doesn't break old binaries, old binaries, running with normal IB MTUs work fine. The structure layouts all stay the same, etc. FWIW, I did a simple test to confirm this. I installed a stock git HEAD

Re: [PATCH v3 11/13] IB/srp: Make HCA completion vector configurable

2013-07-16 Thread Bart Van Assche
On 14/07/2013 3:43, Sagi Grimberg wrote: Just wrote a small patch to allow srp_daemon spread connection across HCA's completion vectors. Hello Sagi, How about the following approach: - Add support for reading the completion vector from srp_daemon.conf, similar to how several other

Re: [PATCH V2] libibverbs: Allow arbitrary int values for MTU

2013-07-16 Thread Jeff Squyres (jsquyres)
On Jul 16, 2013, at 10:47 AM, Jason Gunthorpe jguntho...@obsidianresearch.com wrote: A source change is completely unvaoidable. Supporting the new MTU values requires updated source. I don't really care one way or the other; I'll submit whatever patch people want. :-) But FWIW, I tend to

Re: [PATCH 3.11-rc1] mlx5 core: Fix __udivdi3 when compiling for 32 bit arches

2013-07-16 Thread David Miller
From: Randy Dunlap rdun...@infradead.org Date: Mon, 15 Jul 2013 08:52:18 -0700 On 07/15/13 07:56, Tim Gardner wrote: Cc: Eli Cohen e...@mellanox.com Signed-off-by: Tim Gardner tim.gard...@canonical.com I reported this last week and Eli wrote: I have this fixed in my tree and we run the

[PATCH librdmacm 4/8] configure: Apply updates proposed by autoupdate

2013-07-16 Thread Yann Droneaud
'autoupdate' is a tool to help developer to update configure.ac. This patch applies a few fixes as suggested by autoupdate. Signed-off-by: Yann Droneaud ydrone...@opteya.com --- configure.ac | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/configure.ac

[PATCH librdmacm 5/8] configure: Use automake's option subdir-objects

2013-07-16 Thread Yann Droneaud
Following advice in Autotool Mythbuster [1], option subdir-objects can be used to have Makefiles create object files in the same directory than theirs source files. It reduces clobbering in the build directory. [1] Autotool Mythbuster, by Diego Elio Flameeyes Petten`o

[PATCH librdmacm 7/8] Remove executable mode bit on plain text files

2013-07-16 Thread Yann Droneaud
Source code and man page should not be executable. Signed-off-by: Yann Droneaud ydrone...@opteya.com --- include/rdma/rdma_cma.h | 0 man/rdma_accept.3 | 0 man/rdma_connect.3| 0 man/rdma_create_qp.3 | 0 man/rdma_getaddrinfo.3| 0 man/rdma_join_multicast.3 | 0

[PATCH librdmacm 2/8] Makefile.am: Fix an automake warning

2013-07-16 Thread Yann Droneaud
From: Bart Van Assche bvanass...@acm.org Fix the following automake warning message: Makefile.am:1: `INCLUDES' is the old name for `AM_CPPFLAGS' (or `*_CPPFLAGS') A quote from the automake manual: INCLUDES This does the same job as AM_CPPFLAGS (or any per-target _CPPFLAGS

[PATCH librdmacm 3/8] autogen.sh: Use autoreconf in autogen.sh

2013-07-16 Thread Yann Droneaud
From: Jeff Squyres jsquy...@cisco.com The old sequence of Autotools commands listed in autogen.sh is no longer correct. Instead, just use the single autoreconf command, which will invoke all the Right Autotools commands in the correct order. Signed-off-by: Jeff Squyres jsquy...@cisco.com

[PATCH librdmacm 6/8] Add .gitignore rules

2013-07-16 Thread Yann Droneaud
Add the list of files/patterns to be exclueded from git status output. Additionally it will prevent such files/patterns to be added and committed. Signed-off-by: Yann Droneaud ydrone...@opteya.com --- .gitignore | 64 +

[PATCH librdmacm 8/8] Open files with close on exec flag

2013-07-16 Thread Yann Droneaud
File opened by librdmacm are not supposed to be inherited across exec*(), most of the files are of no use for another program, and others cannot be used without the associated memory mapping. This patch changes fopen() open() and socket() to always set close on exec flag. This patch also add

[PATCH librdmacm 1/8] Add foreign option to AM_INIT_AUTOMAKE

2013-07-16 Thread Yann Droneaud
From: Bart Van Assche bvanass...@acm.org Switch to the modern form of the AM_INIT_AUTOMAKE macro and tell automake that the librdmacm package does not follow the GNU standards. This change makes it possible to use 'autoreconf' for the librdmacm package. Signed-off-by: Bart Van Assche

Re: [PATCH V2] libibverbs: Allow arbitrary int values for MTU

2013-07-16 Thread Roland Dreier
On Tue, Jul 16, 2013 at 10:11 AM, Jeff Squyres (jsquyres) jsquy...@cisco.com wrote: - doing it this way preserves ABI, so existing binaries are safe I still don't get this. Wouldn't an existing binary be pretty surprised to get a value wildly out of range of the enum? - R. -- To unsubscribe

[PATCH -next] IB/mlx5: use module_pci_driver to simplify the code

2013-07-16 Thread Wei Yongjun
From: Wei Yongjun yongjun_...@trendmicro.com.cn Use the module_pci_driver() macro to make the code simpler by eliminating module_init and module_exit calls. Signed-off-by: Wei Yongjun yongjun_...@trendmicro.com.cn --- drivers/infiniband/hw/mlx5/main.c | 13 + 1 file changed, 1

RE: [PATCH V2] libibverbs: Allow arbitrary int values for MTU

2013-07-16 Thread Hefty, Sean
A source change is completely unvaoidable. Supporting the new MTU values requires updated source. I don't really care one way or the other; I'll submit whatever patch people want. :-) But FWIW, I tend to believe the Doug/Jason position: - MTU really needs to be a plain integer

RE: [PATCH librdmacm 3/8] autogen.sh: Use autoreconf in autogen.sh

2013-07-16 Thread Hefty, Sean
Thanks - I pulled in these patches, but see below: diff --git a/autogen.sh b/autogen.sh index f433312..6c9233e 100755 --- a/autogen.sh +++ b/autogen.sh @@ -1,9 +1,4 @@ #! /bin/sh set -x -test -d ./config || mkdir ./config Without the above line, the build fails. I added it back in.