RE: [PATCH librdmacm 3/8] autogen.sh: Use autoreconf in autogen.sh

2013-07-17 Thread Yann Droneaud
Hi, Le 17.07.2013 06:22, Hefty, Sean a écrit : Thanks - I pulled in these patches, but see below: Thanks. diff --git a/autogen.sh b/autogen.sh index f433312..6c9233e 100755 --- a/autogen.sh +++ b/autogen.sh @@ -1,9 +1,4 @@ #! /bin/sh set -x -test -d ./config || mkdir ./config Without

Re: [PATCH librdmacm 3/8] autogen.sh: Use autoreconf in autogen.sh

2013-07-17 Thread Or Gerlitz
On 17/07/2013 07:22, Hefty, Sean wrote: Thanks - I pulled in these patches, but see below: Hi Sean, If you do this house cleanup, could you also address the below build warnings. I can see them when I build rpm from the 1.0.17 tar ball, but not when doing plain make on the latest git,

[PATCH v2] RDMA/cma: silence GCC warning

2013-07-17 Thread Paul Bolle
Building cma.o triggers this GCC warning: drivers/infiniband/core/cma.c: In function ‘rdma_resolve_addr’: drivers/infiniband/core/cma.c:465:23: warning: ‘port’ may be used uninitialized in this function [-Wmaybe-uninitialized] drivers/infiniband/core/cma.c:426:5: note: ‘port’ was

Re: [PATCH v3 11/13] IB/srp: Make HCA completion vector configurable

2013-07-17 Thread Sagi Grimberg
On 7/16/2013 6:11 PM, Bart Van Assche wrote: On 14/07/2013 3:43, Sagi Grimberg wrote: Just wrote a small patch to allow srp_daemon spread connection across HCA's completion vectors. Hello Sagi, How about the following approach: - Add support for reading the completion vector from

[PATCH FIXES for-3.11 4/4] IB/ipoib: Fix pkey-change flow for Virtualization environments

2013-07-17 Thread Or Gerlitz
From: Erez Shitrit ere...@mellanox.com IPoIB's required behaviour w.r.t to the pkey used by the device is the following: - For parent interfaces (e.g ib0, ib1, etc) who are created automatically as a result of hot-plug events from the IB core, the driver needs to take whatever pkey vlaue it

[PATCH FIXES for-3.11 1/4] IB/core: Create QP1 using the pkey index which contains the default pkey

2013-07-17 Thread Or Gerlitz
From: Jack Morgenstein ja...@dev.mellanox.co.il Currently, QP1 is created using pkey index 0. This patch simply looks for the index containing the default pkey, rather than hard-coding pkey index 0. This change will have no effect in Native mode, since QP0 and QP1 are created before the SM

[PATCH FIXES for-3.11 3/4] IB/ipoib: Make sure child devices use valid/proper pkeys

2013-07-17 Thread Or Gerlitz
Make sure that the IB invalid pkey (0x or 0x8000) isn't used for child devices. Also, make sure to always set the full membership bit for the pkey of devices created by rtnl link ops. Signed-off-by: Or Gerlitz ogerl...@mellanox.com --- drivers/infiniband/ulp/ipoib/ipoib_main.c|2 +-

[PATCH FIXES for-3.11 2/4] IB/mlx4: Use default pkey when creating tunnel QPs

2013-07-17 Thread Or Gerlitz
From: Jack Morgenstein ja...@dev.mellanox.co.il When creating tunnel QPs for special QP tunneling, look for the default pkey in the slave's virtual pkey table. If it is present, use the real pkey index where the default pkey is located. If the default pkey is not found in the pkey table, use the

[PATCH FIXES for-3.11 0/4] Pkey fixes for IB core and IPoIB

2013-07-17 Thread Or Gerlitz
Hi Roland, This set of fixes is critical for Virtualization environments when the VM para-virtualized PKEY table isn't fully configured at the time the VF is probed, or when the management pkey is provisioned to non-zero index in the VF pkey table. The first three patches are pretty much few

[PATCH REPOST FIXES for-3.11 1/4] IB/core: Create QP1 using the pkey index which contains the default pkey

2013-07-17 Thread Or Gerlitz
From: Jack Morgenstein ja...@dev.mellanox.co.il Currently, QP1 is created using pkey index 0. This patch simply looks for the index containing the default pkey, rather than hard-coding pkey index 0. This change will have no effect in Native mode, since QP0 and QP1 are created before the SM

[PATCH REPOST FIXES for-3.11 4/4] IB/ipoib: Fix pkey-change flow for Virtualization environments

2013-07-17 Thread Or Gerlitz
From: Erez Shitrit ere...@mellanox.com IPoIB's required behaviour w.r.t to the pkey used by the device is the following: - For parent interfaces (e.g ib0, ib1, etc) who are created automatically as a result of hot-plug events from the IB core, the driver needs to take whatever pkey vlaue it

Re: [PATCH -next] IB/mlx5: use module_pci_driver to simplify the code

2013-07-17 Thread Eli Cohen
Looks to me like a convenience that we may need to give up later should we need to put any code in the init or cleanup functions. On Wed, Jul 17, 2013 at 09:56:41AM +0800, Wei Yongjun wrote: From: Wei Yongjun yongjun_...@trendmicro.com.cn Use the module_pci_driver() macro to make the code

Re: [PATCH] mlx5: qp: variable may be used uninitialized

2013-07-17 Thread Eli Cohen
Acked-by: Eli Cohen e...@mellanox.com On Tue, Jul 16, 2013 at 03:35:01PM +0200, Andi Shyti wrote: in the sq_overhead() function, if qp_typ is equal to IB_QPT_RC, size will be used uninitialized. Signed-off-by: Andi Shyti a...@etezian.org --- drivers/infiniband/hw/mlx5/qp.c | 2 +- 1 file

Re: [patch -next] mlx5: return -EFAULT instead of -EPERM

2013-07-17 Thread Eli Cohen
Acked-by Eli Cohen e...@mellanox.com On Wed, Jul 10, 2013 at 01:58:59PM +0300, Dan Carpenter wrote: For copy_to/from_user() failure, the correct error code is -EFAULT not -EPERM. Signed-off-by: Dan Carpenter dan.carpen...@oracle.com diff --git a/drivers/infiniband/hw/mlx5/mr.c

RE: [PATCH REPOST FIXES for-3.11 1/4] IB/core: Create QP1 using the pkey index which contains the default pkey

2013-07-17 Thread Hefty, Sean
diff --git a/drivers/infiniband/core/mad.c b/drivers/infiniband/core/mad.c index dc3fd1e..9be6754 100644 --- a/drivers/infiniband/core/mad.c +++ b/drivers/infiniband/core/mad.c @@ -2663,6 +2663,7 @@ static int ib_mad_port_start(struct ib_mad_port_private *port_priv) int ret, i;

Re: [PATCH V2] libibverbs: Allow arbitrary int values for MTU

2013-07-17 Thread Doug Ledford
On 07/16/2013 08:16 PM, Roland Dreier wrote: On Tue, Jul 16, 2013 at 10:11 AM, Jeff Squyres (jsquyres) jsquy...@cisco.com wrote: - doing it this way preserves ABI, so existing binaries are safe I still don't get this. Wouldn't an existing binary be pretty surprised to get a value wildly

RE: [PATCH v2] RDMA/cma: silence GCC warning

2013-07-17 Thread Hefty, Sean
Building cma.o triggers this GCC warning: drivers/infiniband/core/cma.c: In function ‘rdma_resolve_addr’: drivers/infiniband/core/cma.c:465:23: warning: ‘port’ may be used uninitialized in this function [-Wmaybe-uninitialized] drivers/infiniband/core/cma.c:426:5: note: ‘port’ was

RE: [PATCH V2] libibverbs: Allow arbitrary int values for MTU

2013-07-17 Thread Hefty, Sean
I hadn't looked at the kernel side yet; I was waiting for the userspace side to sort itself out first. I think it makes sense to start with how user space can get the data. Without eating up reserved fields, we're starting with 8 bit values. Hmm. 16 bits is probably enough for the MTU

[PATCH] RDMA/nes: Reversing commit bca1935ccdec to silence allmodconfig build warning

2013-07-17 Thread Tatyana Nikolova
Reversing commit Fix compilation error when nes_debug is enabled which removes variables nes_tcp_state_str and nes_iwarp_state_str, assuming that they aren't defined. However, they are defined within a #ifdef NES_DEBUG statement, which if enabled causes defined but not used compiler warning,

Re: [PATCH V2] libibverbs: Allow arbitrary int values for MTU

2013-07-17 Thread Steve Wise
On 7/17/2013 4:41 PM, Hefty, Sean wrote: I hadn't looked at the kernel side yet; I was waiting for the userspace side to sort itself out first. I think it makes sense to start with how user space can get the data. Without eating up reserved fields, we're starting with 8 bit values. Hmm. 16

RE: [PATCH V3 for-next 3/4] IB/core: Export ib_create/destroy_flow through uverbs

2013-07-17 Thread Hefty, Sean
+ssize_t ib_uverbs_create_flow(struct ib_uverbs_file *file, + const char __user *buf, int in_len, + int out_len) +{ + struct ib_uverbs_create_flow cmd; + struct ib_uverbs_create_flow_resp resp; + struct ib_uobject

Re: [PATCH V2] libibverbs: Allow arbitrary int values for MTU

2013-07-17 Thread Jeff Squyres (jsquyres)
On Jul 17, 2013, at 5:44 PM, Steve Wise sw...@opengridcomputing.com wrote: The iwarp drivers just report the nearest mtu enum. Apps don't need it for iwarp like they do for ib. For RC, it doesn't matter much. So the fact that RoCE and iWARP lie about their MTU isn't a huge deal. It's