On 3/4/2014 9:49 AM, Or Gerlitz wrote:
On 04/03/2014 02:01, Nicholas A. Bellinger wrote:
This is necessary because even though IB_SEND_SIGNALED is
not set for RDMA WRITEs + READs, during a QP failure event
the work requests will be returned with exception status
from the TX completion queue.
On 03/03/2014 06:44, Mike Christie wrote:
The xmit_task callout does handle failures like EINVAL. If the above map
calls fail then you would get infinite retries. You would currently want
to do the mapping in the init_task callout instead.
If it makes it easier on the driver implementation then
On 3/4/2014 11:38 AM, Or Gerlitz wrote:
On 03/03/2014 06:44, Mike Christie wrote:
The xmit_task callout does handle failures like EINVAL. If the above map
calls fail then you would get infinite retries. You would currently want
to do the mapping in the init_task callout instead.
If it makes it
On 04/03/2014 11:59, Sagi Grimberg wrote:
On 3/4/2014 11:38 AM, Or Gerlitz wrote:
On 03/03/2014 06:44, Mike Christie wrote:
The xmit_task callout does handle failures like EINVAL. If the above
map
calls fail then you would get infinite retries. You would currently
want
to do the mapping in
Allow the user to specify GID addresses (AF_IB) into riostream example.
Signed-off-by: Hal Rosenstock h...@mellanox.com
---
Change since v1:
Added brief description
diff --git a/examples/riostream.c b/examples/riostream.c
index a1d3671..4c0d21f 100644
--- a/examples/riostream.c
+++
From: Kumar Sanghvi kuma...@chelsio.com
Based on original work by Casey Leedom lee...@chelsio.com
Signed-off-by: Kumar Sanghvi kuma...@chelsio.com
---
drivers/net/ethernet/chelsio/cxgb4/cxgb4.h | 1 +
drivers/net/ethernet/chelsio/cxgb4/t4_hw.c | 106 +++
From: Kumar Sanghvi kuma...@chelsio.com
We'd come in with SGE_FL_BUFFER_SIZE[0] and [1] both equal to 64KB and the
extant logic would flag that as an error.
Based on original work by Casey Leedom lee...@chelsio.com
Signed-off-by: Kumar Sanghvi kuma...@chelsio.com
---
From: Kumar Sanghvi kuma...@chelsio.com
Based on original work by Casey Leedom lee...@chelsio.com
Signed-off-by: Kumar Sanghvi kuma...@chelsio.com
---
drivers/net/ethernet/chelsio/cxgb4/cxgb4.h | 9 ++-
drivers/net/ethernet/chelsio/cxgb4/sge.c | 91 --
2 files
From: Steve Wise sw...@opengridcomputing.com
Need to do an sfence after both the WC and regular PIDX DB write.
Otherwise the host might reorder things and cause work request corruption
(seen with NFSRDMA).
Signed-off-by: Steve Wise sw...@opengridcomputing.com
---
From: Steve Wise sw...@opengridcomputing.com
There is a race when moving a QP from RTS-CLOSING where a SQ work
request could be posted after the FW receives the RDMA_RI/FINI WR.
The SQ work request will never get processed, and should be completed
with FLUSHED status. Function c4iw_flush_sq(),
From: Steve Wise sw...@opengridcomputing.com
Based on original work by Anand Priyadarshee ana...@chelsio.com.
Signed-off-by: Steve Wise sw...@opengridcomputing.com
---
drivers/infiniband/hw/cxgb4/cm.c| 24
drivers/net/ethernet/chelsio/cxgb4/t4_msg.h | 1 +
From: Steve Wise sw...@opengridcomputing.com
Some HW platforms can reorder read operations, so we must rmb() after
we see a valid gen bit in a CQE but before we read any other fields
from the CQE.
Signed-off-by: Steve Wise sw...@opengridcomputing.com
---
drivers/infiniband/hw/cxgb4/t4.h | 1 +
From: Steve Wise sw...@opengridcomputing.com
1) timedout endpoint processing can be starved. If there is continual
CPL messages flowing into the driver, the endpoint timeout processing
can be starved. This condition exposed the other bugs below.
Solution: In process_work(), call
From: Steve Wise sw...@opengridcomputing.com
Signed-off-by: Steve Wise sw...@opengridcomputing.com
---
drivers/infiniband/hw/cxgb4/iw_cxgb4.h | 1 +
drivers/infiniband/hw/cxgb4/qp.c | 6 --
2 files changed, 5 insertions(+), 2 deletions(-)
diff --git
From: Steve Wise sw...@opengridcomputing.com
find_route() must treat loopback as a valid
egress interface.
Signed-off-by: Steve Wise sw...@opengridcomputing.com
---
drivers/infiniband/hw/cxgb4/cm.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git
From: Steve Wise sw...@opengridcomputing.com
40G devices need a bigger windows, so default 40G devices to snd 512K
rcv 1024K.
Fixed a bug that shows up with recv window sizes that exceed the size of
the RCV_BUFSIZ field in opt0 (= 1024K :). If the recv window exceeds
this, then we specify the
From: Steve Wise sw...@opengridcomputing.com
Signed-off-by: Steve Wise sw...@opengridcomputing.com
---
drivers/infiniband/hw/cxgb4/device.c | 41 +-
drivers/infiniband/hw/cxgb4/iw_cxgb4.h | 2 ++
drivers/infiniband/hw/cxgb4/qp.c | 59 +---
From: Steve Wise sw...@opengridcomputing.com
Signed-off-by: Steve Wise sw...@opengridcomputing.com
---
drivers/infiniband/hw/cxgb4/device.c | 6 --
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/drivers/infiniband/hw/cxgb4/device.c
b/drivers/infiniband/hw/cxgb4/device.c
index
From: Steve Wise sw...@opengridcomputing.com
Signed-off-by: Steve Wise sw...@opengridcomputing.com
---
drivers/infiniband/hw/cxgb4/cm.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/infiniband/hw/cxgb4/cm.c b/drivers/infiniband/hw/cxgb4/cm.c
index f6891b8..95b3c01 100644
---
From: Steve Wise sw...@opengridcomputing.com
Based on original work from Jay Hernandez j...@chelsio.com
Signed-off-by: Steve Wise sw...@opengridcomputing.com
---
drivers/infiniband/hw/cxgb4/cq.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git
From: Steve Wise sw...@opengridcomputing.com
There is a race between ULP threads doing an accept/reject, and the
ingress processing thread handling close/abort for the same connection.
The accept/reject path needs to hold the lock to serialize these paths.
Signed-off-by: Steve Wise
From: Kumar Sanghvi kuma...@chelsio.com
Currently ring_tx_db() can deadlock if a db_full interrupt fires and is
run on the same while ring_tx_db() has the db lock held. It needs to
disable interrupts since it serializes with an interrupt handler.
Based on original work by Steve Wise
From: Steve Wise sw...@opengridcomputing.com
Always release the neigh entry in rx_pkt().
Based on original work by Santosh Rastapur sant...@chelsio.com.
Signed-off-by: Steve Wise sw...@opengridcomputing.com
---
drivers/infiniband/hw/cxgb4/cm.c | 5 +++--
1 file changed, 3 insertions(+), 2
From: Steve Wise sw...@opengridcomputing.com
Signed-off-by: Steve Wise sw...@opengridcomputing.com
---
drivers/infiniband/hw/cxgb4/cm.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/infiniband/hw/cxgb4/cm.c b/drivers/infiniband/hw/cxgb4/cm.c
index
From: Steve Wise sw...@opengridcomputing.com
To avoid racing with other threads doing close/flush/whatever, rx_data()
should hold the endpoint mutex.
Signed-off-by: Steve Wise sw...@opengridcomputing.com
---
drivers/infiniband/hw/cxgb4/cm.c | 16 +---
1 file changed, 9
From: Steve Wise sw...@opengridcomputing.com
Signed-off-by: Steve Wise sw...@opengridcomputing.com
---
drivers/infiniband/hw/cxgb4/cm.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/infiniband/hw/cxgb4/cm.c b/drivers/infiniband/hw/cxgb4/cm.c
index f4a9ebe..e7c6dfd 100644
---
Commit 0034b29 (cxgb4: Don't assume LSO only uses SGL path in t4_eth_xmit())
introduced a regression causing chip-hang. This patch needs more debugging and
more work. So reverting for now.
Signed-off-by: Hariprasad Shenai haripra...@chelsio.com
---
drivers/net/ethernet/chelsio/cxgb4/sge.c | 32
From: Steve Wise sw...@opengridcomputing.com
Added some missing debug stats.
Use uninitialized_var().
Initialize reserved fields in a FW work request.
Signed-off-by: Steve Wise sw...@opengridcomputing.com
---
drivers/infiniband/hw/cxgb4/cq.c | 2 +-
drivers/infiniband/hw/cxgb4/mem.c
From: Steve Wise sw...@opengridcomputing.com
When processing an MPA Start Request, if the listening
endpoint is DEAD, then abort the connection.
If the IWCM returns an error, then we must abort the connection and
release resources. Also abort_connection() should not post a CLOSE
event, so clean
From: Kumar Sanghvi kuma...@chelsio.com
Based on original work by Casey Leedom lee...@chelsio.com
Signed-off-by: Kumar Sanghvi kuma...@chelsio.com
---
drivers/net/ethernet/chelsio/cxgb4/sge.c | 18 +-
drivers/net/ethernet/chelsio/cxgb4/t4_regs.h | 6 ++
2 files changed,
From: Steve Wise sw...@opengridcomputing.com
Signed-off-by: Steve Wise sw...@opengridcomputing.com
---
drivers/infiniband/hw/cxgb4/cq.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/infiniband/hw/cxgb4/cq.c b/drivers/infiniband/hw/cxgb4/cq.c
index 88de3aa..c0673ac
From: Steve Wise sw...@opengridcomputing.com
The current logic suffers from a slow response time to disable user DB
usage, and also fails to avoid DB FIFO drops under heavy load. This commit
fixes these deficiencies and makes the avoidance logic more optimal.
This is done by more efficiently
From: Steve Wise sw...@opengridcomputing.com
These are generated by HW in some error cases and need to be
silently discarded.
Signed-off-by: Steve Wise sw...@opengridcomputing.com
---
drivers/infiniband/hw/cxgb4/cq.c | 24
1 file changed, 20 insertions(+), 4
From: Steve Wise sw...@opengridcomputing.com
The max depth of a fastreg mr depends on whether the device supports DSGL or
not. So
compute it dynamically based on the device support and the module use_dsgl
option.
Signed-off-by: Steve Wise sw...@opengridcomputing.com
---
From: Steve Wise sw...@opengridcomputing.com
If cxgb4_ofld_send() returns 0, then send_fw_pass_open_req() must
free the request skb and the saved skb with the tcp header.
Signed-off-by: Steve Wise sw...@opengridcomputing.com
---
drivers/infiniband/hw/cxgb4/cm.c | 9 -
1 file changed, 8
Another MASTER SM with lower priority sends HANDOVER to our SM,
before our SM *starts* polling it.
In sm_state_mgr_start_polling() there is no validation whether
p_polling_sm is valid.
Signed-off-by: Alex Netes ale...@mellanox.com
---
include/opensm/osm_sm.h |2 +-
opensm/osm_drop_mgr.c
On 3/4/2014 6:07 AM, Alex Netes wrote:
Another MASTER SM with lower priority sends HANDOVER to our SM,
before our SM *starts* polling it.
In sm_state_mgr_start_polling() there is no validation whether
p_polling_sm is valid.
Signed-off-by: Alex Netes ale...@mellanox.com
Thanks. Applied.
On 3/4/2014 1:25 PM, Or Gerlitz wrote:
On 04/03/2014 11:59, Sagi Grimberg wrote:
On 3/4/2014 11:38 AM, Or Gerlitz wrote:
On 03/03/2014 06:44, Mike Christie wrote:
The xmit_task callout does handle failures like EINVAL. If the
above map
calls fail then you would get infinite retries. You would
On 3/4/2014 2:01 AM, Nicholas A. Bellinger wrote:
From: Nicholas Bellinger n...@linux-iscsi.org
This patch changes IB_WR_FAST_REG_MR + IB_WR_LOCAL_INV related
work requests to include a ISER_FRWR_LI_WRID value in order to
signal isert_cq_tx_work() that these requests should be ignored.
This is
On 3/4/2014 2:00 AM, Nicholas A. Bellinger wrote:
From: Nicholas Bellinger n...@linux-iscsi.org
Hi Or Sagi,
This series addresses a number of active I/O shutdown related issues
in iser-target code that have come up recently during stress testing.
Note there is still a seperate iser-target
On 04/03/2014 16:44, Sagi Grimberg wrote:
@@ -1707,10 +1707,17 @@ int iscsi_queuecommand(struct Scsi_Host
*host, struct scsi_cmnd *sc)
goto prepd_fault;
}
}
- if (session-tt-xmit_task(task)) {
-
Hello.
On 03/04/2014 03:41 PM, Hariprasad Shenai wrote:
From: Steve Wise sw...@opengridcomputing.com
Added some missing debug stats.
Use uninitialized_var().
Initialize reserved fields in a FW work request.
You should really split this patch.
Signed-off-by: Steve Wise
On 03/04/2014 03:41 PM, Hariprasad Shenai wrote:
From: Steve Wise sw...@opengridcomputing.com
Based on original work by Anand Priyadarshee ana...@chelsio.com.
Signed-off-by: Steve Wise sw...@opengridcomputing.com
[...]
diff --git a/drivers/infiniband/hw/cxgb4/cm.c
On 3/4/2014 6:16 PM, Or Gerlitz wrote:
On 04/03/2014 16:44, Sagi Grimberg wrote:
@@ -1707,10 +1707,17 @@ int iscsi_queuecommand(struct Scsi_Host
*host, struct scsi_cmnd *sc)
goto prepd_fault;
}
}
- if
On Tue, 2014-03-04 at 18:11 +0530, Hariprasad Shenai wrote:
From: Kumar Sanghvi kuma...@chelsio.com
Based on original work by Casey Leedom lee...@chelsio.com
trivial comments:
diff --git a/drivers/net/ethernet/chelsio/cxgb4/sge.c
b/drivers/net/ethernet/chelsio/cxgb4/sge.c
@@ -2031,21
BTW, if you're frustrated from having to send these patches so many
times because of changes being requested, this is the main reason
why you shouldn't queue up such enormous numbers of patches at one
time.
Please try to keep your future submissions sizes more reasonable,
perhaps ~10 patches or
Hello.
On 03/04/2014 08:43 PM, Joe Perches wrote:
From: Kumar Sanghvi kuma...@chelsio.com
Based on original work by Casey Leedom lee...@chelsio.com
trivial comments:
diff --git a/drivers/net/ethernet/chelsio/cxgb4/sge.c
b/drivers/net/ethernet/chelsio/cxgb4/sge.c
@@ -2031,21
On Tue, 2014-03-04 at 23:22 +0300, Sergei Shtylyov wrote:
On 03/04/2014 08:43 PM, Joe Perches wrote:
From: Kumar Sanghvi kuma...@chelsio.com
+ CH_WARN(adap, SGE idma%u, queue%u, maybe stuck state%u %dsecs
+ (debug0=%#x, debug11=%#x)\n,
Probably better with the
On Mon, Mar 3, 2014 at 7:15 PM, Hefty, Sean sean.he...@intel.com wrote:
[...]
If a CM REQ actually gets to the remote side, it could be rejected as an
invalid GID, and the client could retry the request.
Retrying the request is practically calling
1. rdma_resolve_addr
2. rdma_resolve_route
3.
If a CM REQ actually gets to the remote side, it could be rejected as an
invalid GID, and the client could retry the request.
Retrying the request is practically calling
1. rdma_resolve_addr
2. rdma_resolve_route
3. rdma_connect
Yep - the entire setup is broken. If the wrong remote
If a CM REQ actually gets to the remote side, it could be rejected as
an
invalid GID, and the client could retry the request.
Retrying the request is practically calling
1. rdma_resolve_addr
2. rdma_resolve_route
3. rdma_connect
Yep - the entire setup is broken. If the wrong
On Thu, 2014-02-27 at 13:05 -0500, David Miller wrote:
From: Steve Wise sw...@opengridcomputing.com
Date: Thu, 27 Feb 2014 11:11:49 -0600
-static int allow_db_fc_on_t5;
-module_param(allow_db_fc_on_t5, int, 0644);
-MODULE_PARM_DESC(allow_db_fc_on_t5,
- Allow DB Flow
On Tue, 2014-03-04 at 16:51 +0200, Sagi Grimberg wrote:
On 3/4/2014 2:01 AM, Nicholas A. Bellinger wrote:
From: Nicholas Bellinger n...@linux-iscsi.org
This patch changes IB_WR_FAST_REG_MR + IB_WR_LOCAL_INV related
work requests to include a ISER_FRWR_LI_WRID value in order to
signal
On Tue, 2014-03-04 at 17:17 +0200, Sagi Grimberg wrote:
On 3/4/2014 2:00 AM, Nicholas A. Bellinger wrote:
From: Nicholas Bellinger n...@linux-iscsi.org
Hi Or Sagi,
This series addresses a number of active I/O shutdown related issues
in iser-target code that have come up recently
On Tue, Mar 04, 2014 at 13:22:26 -0500, David Miller wrote:
BTW, if you're frustrated from having to send these patches so many
times because of changes being requested, this is the main reason
why you shouldn't queue up such enormous numbers of patches at one
time.
Please try to keep
On Tue, Mar 04, 2014 at 23:22:46 +, Ben Hutchings wrote:
On Thu, 2014-02-27 at 13:05 -0500, David Miller wrote:
From: Steve Wise sw...@opengridcomputing.com
Date: Thu, 27 Feb 2014 11:11:49 -0600
-static int allow_db_fc_on_t5;
-module_param(allow_db_fc_on_t5, int, 0644);
56 matches
Mail list logo
