On 03/10/14 17:08, Paul E. McKenney wrote:
On Mon, Mar 10, 2014 at 04:02:13PM +0100, Yann Droneaud wrote:
Hi,
Le lundi 10 mars 2014 à 15:26 +0100, Bart Van Assche a écrit :
On 03/10/14 14:33, Yann Droneaud wrote:
Le lundi 10 mars 2014 à 13:22 +0100, Bart Van Assche a écrit :
Suppress the
On 02/18/14 15:32, Moni Shoua wrote:
Ha ha. Take another look. That's what I was just explaining about! :) On
line 1743 when curr_master is non-NULL then Smatch doesn't complain
because it understands about the relationship between curr_master and
curr_netdev. But here it is complaining about
On 03/11/14 16:30, Sagi Grimberg wrote:
State FAIL_FAST must come *after* stated BLOCKED. Do you think that
taking the lock
once the rport transitions to state BLOCKED suffices? I'm aiming to
avoid this lock in
the sunny-day flow. Taking this lock always to protect against some
error flow
On Sat, 08 Mar 2014 14:13:44 -0600
Steve Wise sw...@opengridcomputing.com wrote:
On 3/8/2014 1:20 PM, Steve Wise wrote:
I removed your change and started debugging original crash that
happens on top-o-tree. Seems like rq_next_pages is screwed up. It
should always be = rq_respages,
On Mar 12, 2014, at 9:33, Jeff Layton jlay...@redhat.com wrote:
On Sat, 08 Mar 2014 14:13:44 -0600
Steve Wise sw...@opengridcomputing.com wrote:
On 3/8/2014 1:20 PM, Steve Wise wrote:
I removed your change and started debugging original crash that
happens on top-o-tree. Seems like
Hi Trond,
I think this patch is still 'off-by-one'. We'll take a look at this today.
Thanks,
Tom
On 3/12/14 9:05 AM, Trond Myklebust wrote:
On Mar 12, 2014, at 9:33, Jeff Layton jlay...@redhat.com wrote:
On Sat, 08 Mar 2014 14:13:44 -0600
Steve Wise sw...@opengridcomputing.com wrote:
On
On Wed, 12 Mar 2014 10:05:24 -0400
Trond Myklebust trond.mykleb...@primarydata.com wrote:
On Mar 12, 2014, at 9:33, Jeff Layton jlay...@redhat.com wrote:
On Sat, 08 Mar 2014 14:13:44 -0600
Steve Wise sw...@opengridcomputing.com wrote:
On 3/8/2014 1:20 PM, Steve Wise wrote:
I
On Mar 12, 2014, at 10:28, Jeffrey Layton jlay...@redhat.com wrote:
On Wed, 12 Mar 2014 10:05:24 -0400
Trond Myklebust trond.mykleb...@primarydata.com wrote:
On Mar 12, 2014, at 9:33, Jeff Layton jlay...@redhat.com wrote:
On Sat, 08 Mar 2014 14:13:44 -0600
Steve Wise
On Wed, 12 Mar 2014 11:03:52 -0400
Trond Myklebust trond.mykleb...@primarydata.com wrote:
On Mar 12, 2014, at 10:28, Jeffrey Layton jlay...@redhat.com wrote:
On Wed, 12 Mar 2014 10:05:24 -0400
Trond Myklebust trond.mykleb...@primarydata.com wrote:
On Mar 12, 2014, at 9:33, Jeff
Hi All,
This patch series provides miscelleneous fixes for Chelsio T4/T5 adapters
related to cxgb4 related to sge and mtu. And includes DB Drop avoidance
and other misc. fixes on iw-cxgb4.
The patches series is created against David Miller's 'net-next' tree.
And includes patches on cxgb4 and
From: Steve Wise sw...@opengridcomputing.com
Signed-off-by: Steve Wise sw...@opengridcomputing.com
---
drivers/infiniband/hw/cxgb4/cq.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/infiniband/hw/cxgb4/cq.c b/drivers/infiniband/hw/cxgb4/cq.c
index 88de3aa..c0673ac
From: Steve Wise sw...@opengridcomputing.com
Always release the neigh entry in rx_pkt().
Based on original work by Santosh Rastapur sant...@chelsio.com.
Signed-off-by: Steve Wise sw...@opengridcomputing.com
---
drivers/infiniband/hw/cxgb4/cm.c | 2 +-
1 file changed, 1 insertion(+), 1
From: Kumar Sanghvi kuma...@chelsio.com
Based on original work by Casey Leedom lee...@chelsio.com
Signed-off-by: Kumar Sanghvi kuma...@chelsio.com
---
drivers/net/ethernet/chelsio/cxgb4/cxgb4.h | 9 ++-
drivers/net/ethernet/chelsio/cxgb4/sge.c | 90 --
2 files
From: Steve Wise sw...@opengridcomputing.com
Based on original work by Anand Priyadarshee ana...@chelsio.com.
Signed-off-by: Steve Wise sw...@opengridcomputing.com
---
drivers/infiniband/hw/cxgb4/cm.c| 24
drivers/net/ethernet/chelsio/cxgb4/t4_msg.h | 1 +
From: Steve Wise sw...@opengridcomputing.com
Need to do an sfence after both the WC and regular PIDX DB write.
Otherwise the host might reorder things and cause work request corruption
(seen with NFSRDMA).
Signed-off-by: Steve Wise sw...@opengridcomputing.com
---
From: Steve Wise sw...@opengridcomputing.com
These are generated by HW in some error cases and need to be
silently discarded.
Signed-off-by: Steve Wise sw...@opengridcomputing.com
---
drivers/infiniband/hw/cxgb4/cq.c | 24
1 file changed, 20 insertions(+), 4
From: Steve Wise sw...@opengridcomputing.com
Based on original work from Jay Hernandez j...@chelsio.com
Signed-off-by: Steve Wise sw...@opengridcomputing.com
---
drivers/infiniband/hw/cxgb4/cq.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git
From: Steve Wise sw...@opengridcomputing.com
Signed-off-by: Steve Wise sw...@opengridcomputing.com
---
drivers/infiniband/hw/cxgb4/cm.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/infiniband/hw/cxgb4/cm.c b/drivers/infiniband/hw/cxgb4/cm.c
index 0663fc4..87bd3c8 100644
---
From: Steve Wise sw...@opengridcomputing.com
40G devices need a bigger windows, so default 40G devices to snd 512K
rcv 1024K.
Fixed a bug that shows up with recv window sizes that exceed the size of
the RCV_BUFSIZ field in opt0 (= 1024K :). If the recv window exceeds
this, then we specify the
Signed-off-by: Hariprasad Shenai haripra...@chelsio.com
---
drivers/infiniband/hw/cxgb4/resource.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/infiniband/hw/cxgb4/resource.c
b/drivers/infiniband/hw/cxgb4/resource.c
index d9bc9ba..67df71a 100644
---
From: Steve Wise sw...@opengridcomputing.com
We cannot save the mapped length using the rdma max_page_list_len field
of the ib_fast_reg_page_list struct because the core code uses it. This
results in an incorrect unmap of the page list in c4iw_free_fastreg_pbl().
I found this with dma map
From: Steve Wise sw...@opengridcomputing.com
find_route() must treat loopback as a valid
egress interface.
Signed-off-by: Steve Wise sw...@opengridcomputing.com
---
drivers/infiniband/hw/cxgb4/cm.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git
From: Kumar Sanghvi kuma...@chelsio.com
Based on original work by Casey Leedom lee...@chelsio.com
Signed-off-by: Kumar Sanghvi kuma...@chelsio.com
---
drivers/net/ethernet/chelsio/cxgb4/sge.c | 18 +-
drivers/net/ethernet/chelsio/cxgb4/t4_regs.h | 6 ++
2 files changed,
From: Steve Wise sw...@opengridcomputing.com
The current logic suffers from a slow response time to disable user DB
usage, and also fails to avoid DB FIFO drops under heavy load. This commit
fixes these deficiencies and makes the avoidance logic more optimal.
This is done by more efficiently
From: Steve Wise sw...@opengridcomputing.com
Signed-off-by: Steve Wise sw...@opengridcomputing.com
---
drivers/infiniband/hw/cxgb4/device.c | 6 --
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/drivers/infiniband/hw/cxgb4/device.c
b/drivers/infiniband/hw/cxgb4/device.c
index
From: Steve Wise sw...@opengridcomputing.com
Signed-off-by: Steve Wise sw...@opengridcomputing.com
---
drivers/infiniband/hw/cxgb4/iw_cxgb4.h | 1 +
drivers/infiniband/hw/cxgb4/qp.c | 6 --
2 files changed, 5 insertions(+), 2 deletions(-)
diff --git
From: Kumar Sanghvi kuma...@chelsio.com
Commit 0034b29 (cxgb4: Don't assume LSO only uses SGL path in t4_eth_xmit())
introduced a regression where-in length was calculated wrongly for LSO path,
causing chip hangs.
So, correct the calculation of len.
Fixes: 0034b29 (cxgb4: Don't assume LSO only
From: Steve Wise sw...@opengridcomputing.com
Signed-off-by: Steve Wise sw...@opengridcomputing.com
---
drivers/infiniband/hw/cxgb4/cm.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/infiniband/hw/cxgb4/cm.c b/drivers/infiniband/hw/cxgb4/cm.c
index
From: Steve Wise sw...@opengridcomputing.com
The max depth of a fastreg mr depends on whether the device supports DSGL or
not. So
compute it dynamically based on the device support and the module use_dsgl
option.
Signed-off-by: Steve Wise sw...@opengridcomputing.com
---
From: Steve Wise sw...@opengridcomputing.com
Signed-off-by: Steve Wise sw...@opengridcomputing.com
---
drivers/infiniband/hw/cxgb4/device.c | 41 +-
drivers/infiniband/hw/cxgb4/iw_cxgb4.h | 2 ++
drivers/infiniband/hw/cxgb4/qp.c | 59 +---
From: Steve Wise sw...@opengridcomputing.com
To avoid racing with other threads doing close/flush/whatever, rx_data()
should hold the endpoint mutex.
Signed-off-by: Steve Wise sw...@opengridcomputing.com
---
drivers/infiniband/hw/cxgb4/cm.c | 16 +---
1 file changed, 9
From: Steve Wise sw...@opengridcomputing.com
If cxgb4_ofld_send() returns 0, then send_fw_pass_open_req() must
free the request skb and the saved skb with the tcp header.
Signed-off-by: Steve Wise sw...@opengridcomputing.com
---
drivers/infiniband/hw/cxgb4/cm.c | 9 -
1 file changed, 8
From: Steve Wise sw...@opengridcomputing.com
There is a race when moving a QP from RTS-CLOSING where a SQ work
request could be posted after the FW receives the RDMA_RI/FINI WR.
The SQ work request will never get processed, and should be completed
with FLUSHED status. Function c4iw_flush_sq(),
From: Steve Wise sw...@opengridcomputing.com
1) timedout endpoint processing can be starved. If there is continual
CPL messages flowing into the driver, the endpoint timeout processing
can be starved. This condition exposed the other bugs below.
Solution: In process_work(), call
From: Steve Wise sw...@opengridcomputing.com
Some HW platforms can reorder read operations, so we must rmb() after
we see a valid gen bit in a CQE but before we read any other fields
from the CQE.
Signed-off-by: Steve Wise sw...@opengridcomputing.com
---
drivers/infiniband/hw/cxgb4/t4.h | 1 +
From: Steve Wise sw...@opengridcomputing.com
Signed-off-by: Steve Wise sw...@opengridcomputing.com
---
drivers/infiniband/hw/cxgb4/cm.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/infiniband/hw/cxgb4/cm.c b/drivers/infiniband/hw/cxgb4/cm.c
index 9708987..f62801a 100644
---
From: Steve Wise sw...@opengridcomputing.com
Added some missing debug stats.
Use uninitialized_var().
Initialize reserved fields in a FW work request.
Signed-off-by: Steve Wise sw...@opengridcomputing.com
---
drivers/infiniband/hw/cxgb4/cq.c | 2 +-
drivers/infiniband/hw/cxgb4/mem.c
From: Kumar Sanghvi kuma...@chelsio.com
Based on original work by Casey Leedom lee...@chelsio.com
Signed-off-by: Kumar Sanghvi kuma...@chelsio.com
---
drivers/net/ethernet/chelsio/cxgb4/cxgb4.h | 1 +
drivers/net/ethernet/chelsio/cxgb4/t4_hw.c | 106 +++
From: Steve Wise sw...@opengridcomputing.com
There is a race between ULP threads doing an accept/reject, and the
ingress processing thread handling close/abort for the same connection.
The accept/reject path needs to hold the lock to serialize these paths.
Signed-off-by: Steve Wise
From: Kumar Sanghvi kuma...@chelsio.com
We'd come in with SGE_FL_BUFFER_SIZE[0] and [1] both equal to 64KB and the
extant logic would flag that as an error.
Based on original work by Casey Leedom lee...@chelsio.com
Signed-off-by: Kumar Sanghvi kuma...@chelsio.com
---
From: Steve Wise sw...@opengridcomputing.com
When processing an MPA Start Request, if the listening
endpoint is DEAD, then abort the connection.
If the IWCM returns an error, then we must abort the connection and
release resources. Also abort_connection() should not post a CLOSE
event, so clean
On 3/12/2014 12:17 PM, Bart Van Assche wrote:
On 02/18/14 15:32, Moni Shoua wrote:
Ha ha. Take another look. That's what I was just explaining about! :) On
line 1743 when curr_master is non-NULL then Smatch doesn't complain
because it understands about the relationship between curr_master and
On 3/12/2014 12:15 PM, Bart Van Assche wrote:
On 03/10/14 17:08, Paul E. McKenney wrote:
On Mon, Mar 10, 2014 at 04:02:13PM +0100, Yann Droneaud wrote:
Hi,
Le lundi 10 mars 2014 à 15:26 +0100, Bart Van Assche a écrit :
On 03/10/14 14:33, Yann Droneaud wrote:
Le lundi 10 mars 2014 à 13:22
On Tue, 2014-03-11 at 22:42 -0500, cls...@linux.vnet.ibm.com wrote:
[...]
Index: b/include/linux/mlx5/driver.h
===
--- a/include/linux/mlx5/driver.h
+++ b/include/linux/mlx5/driver.h
@@ -51,10 +51,10 @@ enum {
};
enum {
-
From: Hariprasad Shenai haripra...@chelsio.com
Date: Wed, 12 Mar 2014 21:20:35 +0530
Added module option named adjust_win, defaulted to 1, that allows
disabling the 40G window bump. This allows a user to specify the exact
default window sizes via module options snd_win and rcv_win.
This is
From: Hariprasad Shenai haripra...@chelsio.com
Date: Wed, 12 Mar 2014 21:20:15 +0530
V6:
In patch 8/31, move the existing neigh_release() call right before the
if(!e) test, that way you don't need a completely new label and code block
to fix this bug - thanks to review by David
-Original Message-
From: David Miller [mailto:da...@davemloft.net]
Sent: Wednesday, March 12, 2014 2:51 PM
To: haripra...@chelsio.com
Cc: net...@vger.kernel.org; linux-rdma@vger.kernel.org;
rol...@purestorage.com;
d...@chelsio.com; sw...@opengridcomputing.com; lee...@chelsio.com;
Added module option named adjust_win, defaulted to 1, that allows
disabling the 40G window bump. This allows a user to specify the exact
default window sizes via module options snd_win and rcv_win.
This is terrible. As is the existing other TCP tweaking module
parameters.
You can
You can just use the TCP settings the kernel already provides for
the real TCP stack.
Do you mean use sysctl_tcp_*mem, sysctl_tcp_timestamps,
sysctl_tcp_window_scaling,
etc?
I'll look into this.
And the socket memory limits, which we use to compute default window
sizes.
How's
On 3/12/2014 1:34 PM, Ben Hutchings wrote:
On Tue, 2014-03-11 at 22:42 -0500, cls...@linux.vnet.ibm.com wrote:
[...]
Index: b/include/linux/mlx5/driver.h
===
--- a/include/linux/mlx5/driver.h
+++ b/include/linux/mlx5/driver.h
@@
From: Steve Wise sw...@opengridcomputing.com
Date: Wed, 12 Mar 2014 16:29:27 -0500
You can just use the TCP settings the kernel already provides for
the real TCP stack.
Do you mean use sysctl_tcp_*mem, sysctl_tcp_timestamps,
sysctl_tcp_window_scaling,
etc?
I'll look into this.
How's this look (compile-tested only)? Note I had to export some of the
tcp limits.
Well, the problem is that you've dug your own hole already.
You can't just remove these existing module parameters that users can
set. They are user visible APIs, you can't just remove them.
The
[[Sorry, the first effort at this reply fell afoul of netdev’s HTML email
filter and my Mail Agent’s default modes. — Casey]]
On Mar 12, 2014, at 12:51 PM, David Miller da...@davemloft.net wrote:
This is becomming beyond tiring.
Im really sorry for how much work this has turned into David.
From: Casey Leedom lee...@chelsio.com
Date: Wed, 12 Mar 2014 16:43:33 -0700
Should we revisit that decision and ask Hari to submit a series of
much smaller patch sets (one at a time obviously)?
That might be a good idea, honestly.
--
To unsubscribe from this list: send the line unsubscribe
Hello,
Recently I did a test like this:
1. I have host A and host B. I set ib0 on host A 192.168.0.1, I set ib0 on
host B 192.168.0.2.
2. I start a guestOS C on host A, and I do a RDMA migration from host A to
host B.
3. During the RDMA migration, I make host B power off(It
55 matches
Mail list logo
