On 03/28/14 06:50, sean.he...@intel.com wrote:
+ while ((len = recv(sock, buffer, NL_MSG_BUF_SIZE, 0)) 0) {
+ nlh = (struct nlmsghdr *)buffer;
+ while ((NLMSG_OK(nlh, len)) (nlh-nlmsg_type != NLMSG_DONE))
{
+ struct ifaddrmsg *ifa = (struct
The code was indented too far and also kernel style says we should have
curly braces.
Signed-off-by: Dan Carpenter dan.carpen...@oracle.com
diff --git a/drivers/infiniband/hw/mlx4/main.c
b/drivers/infiniband/hw/mlx4/main.c
index 6cb8546..8d9d6b8 100644
--- a/drivers/infiniband/hw/mlx4/main.c
My static checker complains that the sprintf() here can overflow.
drivers/infiniband/hw/mlx4/main.c:1836 mlx4_ib_alloc_eqs()
error: format string overflow. buf_size: 32 length: 69
This seems like a valid complaint. The dev-pdev-bus-name string
can be 48 characters long. I just
The c4iw_alloc_ucontext_resp struct has a 4 byte hole after the last
member and we should clear it before passing it to the user.
Fixes: 05eb23893c2c ('cxgb4/iw_cxgb4: Doorbell Drop Avoidance Bug Fixes')
Signed-off-by: Dan Carpenter dan.carpen...@oracle.com
diff --git
Hi Chuck,
On 03/27/2014 04:59 PM, Chuck Lever wrote:
Hi-
On Mar 27, 2014, at 12:53 AM, Reiter Rafael rafael.rei...@ims.co.at wrote:
On 03/26/2014 07:15 PM, Chuck Lever wrote:
Hi Rafael-
I’ll take a look. Can you report your HCA and how you reproduce this issue?
The HCA is Mellanox
Hi,
Le vendredi 28 mars 2014 à 11:24 +0300, Dan Carpenter a écrit :
The c4iw_alloc_ucontext_resp struct has a 4 byte hole after the last
member and we should clear it before passing it to the user.
Fixes: 05eb23893c2c ('cxgb4/iw_cxgb4: Doorbell Drop Avoidance Bug Fixes')
Signed-off-by: Dan
From: Yann Droneaud
Hi,
Le vendredi 28 mars 2014 11:24 +0300, Dan Carpenter a crit :
The c4iw_alloc_ucontext_resp struct has a 4 byte hole after the last
member and we should clear it before passing it to the user.
Fixes: 05eb23893c2c ('cxgb4/iw_cxgb4: Doorbell Drop Avoidance Bug
Hi,
Le vendredi 28 mars 2014 à 12:35 -0400, Mike Marciniszyn a écrit :
This patch series modified the ib_sg_dma API to
eliminate the .dma_len and .dma_address methods.
In all present cases that overload these methods
(ipath, qib, ehca), the lack of these methods are
compensated for by code
The method has been removed.
Suggested-by: Bart Van Assche bvanass...@acm.org
Cc: Bart Van Assche bvanass...@acm.org
Reviewed-by: Dennis Dalessandro dennis.dalessan...@intel.com
Signed-off-by: Mike Marciniszyn mike.marcinis...@intel.com
---
drivers/infiniband/hw/ehca/ehca_mrmw.c | 12
On 03/28/14 16:51, Weiny, Ira wrote:
On 03/28/14 06:50, sean.he...@intel.com wrote:
+ while ((len = recv(sock, buffer, NL_MSG_BUF_SIZE, 0)) 0) {
+ nlh = (struct nlmsghdr *)buffer;
+ while ((NLMSG_OK(nlh, len)) (nlh-nlmsg_type !=
NLMSG_DONE)) {
+
thanks - merged
--
To unsubscribe from this list: send the line unsubscribe linux-rdma in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
The code was incorrectly using sg_dma_address() and
sg_dma_len() instead of ib_sg_dma_address() and
ib_sg_dma_len().
This prevents srpt from functioning with the
Intel HCA and indeed will corrupt memory
badly.
Cc: sta...@vger.kernel.org
Cc: Bart Van Assche bvanass...@acm.org
Reviewed-by: Dennis
The method has been removed.
Suggested-by: Bart Van Assche bvanass...@acm.org
Cc: Bart Van Assche bvanass...@acm.org
Cc: Hoang-Nam Nguyen hngu...@de.ibm.com
Cc: Christoph Raisch rai...@de.ibm.com
Reviewed-by: Dennis Dalessandro dennis.dalessan...@intel.com
Signed-off-by: Mike Marciniszyn
This patch just cc's ehca folks.
Sorry I forgot on first one.
Mike
Subject: [PATCH v2] IB/ehca: remove ib_sg_dma_address() and ib_sg_dma_len()
This patch series modified the ib_sg_dma API to
eliminate the .dma_len and .dma_address methods.
In all present cases that overload these methods
(ipath, qib, ehca), the lack of these methods are
compensated for by code changes to the driver .map_sg
to insure that the vanilla sg_dma_address() and
The lack of these methods is compensated for by code changes
to .map_sg to insure that the vanilla sg_dma_address() and
sg_dma_len() will do the same thing as the equivalent
former ib_sg_dma_address() and ib_sg_dma_len() calls
into the drivers.
Suggested-by: Bart Van Assche bvanass...@acm.org
Cc:
The code is replaced by driver specific
changes and avoids the pointer NULL test
for drivers that don't overload these
operations.
Suggested-by: Bart Van Assche bvanass...@acm.org
Cc: Bart Van Assche bvanass...@acm.org
Reviewed-by: Dennis Dalessandro dennis.dalessan...@intel.com
Tested-by: Vinod
These methods appear to only mimic the sg_dma_address()
and sg_dma_len() behavior.
They can be safely removed.
Suggested-by: Bart Van Assche bvanass...@acm.org
Cc: Bart Van Assche bvanass...@acm.org
Cc: Hoang-Nam Nguyen hngu...@de.ibm.com
Cc: Christoph Raisch rai...@de.ibm.com
Reviewed-by:
Remove the overload for .dma_len and .dma_address
The lack of these methods is compensated for by code changes
to .map_sg to insure that the vanilla sg_dma_address() and
sg_dma_len() will do the same thing as the equivalent
former ib_sg_dma_address() and ib_sg_dma_len() calls
into the drivers.
It's just a matter of making patch [PATCH 1/4] IB/core: Remove overload in
ib_sg_dma* the last one.
BTW, You might want to provide a better explanation in the drivers functions
remove patches (just duplicate the explanation).
Take a look at the latest series.
Mike
This patch series modified the ib_sg_dma API to
eliminate the .dma_len and .dma_address methods.
In all present cases that overload these methods
(ipath, qib, ehca), the lack of these methods are
compensated for by code changes to the driver .map_sg
to insure that the vanilla sg_dma_address() and
Le vendredi 28 mars 2014 à 13:26 -0400, Mike Marciniszyn a écrit :
This patch series modified the ib_sg_dma API to
eliminate the .dma_len and .dma_address methods.
In all present cases that overload these methods
(ipath, qib, ehca), the lack of these methods are
compensated for by code
Le vendredi 28 mars 2014 à 13:26 -0400, Mike Marciniszyn a écrit :
The lack of these methods is compensated for by code changes
to .map_sg to insure that the vanilla sg_dma_address() and
sg_dma_len() will do the same thing as the equivalent
former ib_sg_dma_address() and ib_sg_dma_len() calls
On 03/28/14 06:50, sean.he...@intel.com wrote:
+ while ((len = recv(sock, buffer, NL_MSG_BUF_SIZE, 0)) 0) {
+ nlh = (struct nlmsghdr *)buffer;
+ while ((NLMSG_OK(nlh, len)) (nlh-nlmsg_type !=
NLMSG_DONE)) {
+ struct ifaddrmsg *ifa = (struct
From: Steve Wise sw...@opengridcomputing.com
Date: Wed, 26 Mar 2014 10:25:22 -0500
Acked-by: Steve Wise sw...@opengridcomputing.com
Note: This fix applies only to net-next because the commit that introduced
this is still
pending in net-next:
commit
The lack of these methods is compensated for by code changes
to .map_sg to insure that the vanilla sg_dma_address() and
sg_dma_len() will do the same thing as the equivalent
former ib_sg_dma_address() and ib_sg_dma_len() calls
into the drivers.
The introduction of this patch required that the
And struct ipath_dma_mapping_ops was converted to C99 initializer.
This is now mentioned in the ipath patch.
Subject: [PATCH 16/16] ibacm: remove processing of IP's from ibacm_addr.cfg
From: Ira Weiny ira.we...@intel.com
Flag an error and do not process IP's which may appear in this file.
It probably makes sense to make this configurable, with the default to no
longer process IP addresses in the
From: cls...@linux.vnet.ibm.com
Date: Thu, 27 Mar 2014 09:28:13 -0500
This patch is to resolve some hangs we are seeing when doing PCI error
injection
to Mellanox Infiniband cards. With this patch we make mlx4 driver send an
IB_EVENT_DEVICE_FATAL
to the users and added this event to event
On Fri, Mar 28, 2014 at 1:47 PM, David Miller da...@davemloft.net wrote:
I'm assuming Roland will take this in via his tree.
Yes, hoping for some feedback from Mellanox people.
- R.
--
To unsubscribe from this list: send the line unsubscribe linux-rdma in
the body of a message to
: Or Gerlitz ogerl...@mellanox.com
Cc: Roi Dayan r...@mellanox.com
Cc: linux-rdma@vger.kernel.org
---
drivers/infiniband/ulp/iser/iser_verbs.c |5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
--- linux-next-20140328.orig/drivers/infiniband/ulp/iser/iser_verbs.c
+++ linux
On Mar 28, 2014, at 2:42 AM, Senn Klemens klemens.s...@ims.co.at wrote:
Hi Chuck,
On 03/27/2014 04:59 PM, Chuck Lever wrote:
Hi-
On Mar 27, 2014, at 12:53 AM, Reiter Rafael rafael.rei...@ims.co.at wrote:
On 03/26/2014 07:15 PM, Chuck Lever wrote:
Hi Rafael-
I’ll take a look.
On 3/29/2014 1:30 AM, Chuck Lever wrote:
On Mar 28, 2014, at 2:42 AM, Senn Klemens klemens.s...@ims.co.at wrote:
Hi Chuck,
On 03/27/2014 04:59 PM, Chuck Lever wrote:
Hi-
On Mar 27, 2014, at 12:53 AM, Reiter Rafael rafael.rei...@ims.co.at wrote:
On 03/26/2014 07:15 PM, Chuck Lever wrote:
On Mar 28, 2014, at 4:06 PM, sagi grimberg sa...@mellanox.com wrote:
On 3/29/2014 1:30 AM, Chuck Lever wrote:
On Mar 28, 2014, at 2:42 AM, Senn Klemens klemens.s...@ims.co.at wrote:
Hi Chuck,
On 03/27/2014 04:59 PM, Chuck Lever wrote:
Hi-
On Mar 27, 2014, at 12:53 AM, Reiter Rafael
On 3/29/2014 3:05 AM, Chuck Lever wrote:
On Mar 28, 2014, at 4:06 PM, sagi grimberg sa...@mellanox.com wrote:
On 3/29/2014 1:30 AM, Chuck Lever wrote:
On Mar 28, 2014, at 2:42 AM, Senn Klemens klemens.s...@ims.co.at wrote:
Hi Chuck,
On 03/27/2014 04:59 PM, Chuck Lever wrote:
Hi-
On Mar
35 matches
Mail list logo
