Re: [ANNOUNCE] libibverbs 1.1.8 is released

2014-05-07 Thread Or Gerlitz
On 05/05/2014 22:19, Roland Dreier wrote: Matan Barak (1): Add general definitions to support uverbs extensions Or Gerlitz (1): Add receive flow steering support Roland, due to a mistake I made in the rebased flow-steering patch I handed you -- I was nominated as the author

Re: [PATCH 1/9] IB/srp: Fix kernel-doc warnings

2014-05-07 Thread Sagi Grimberg
On 5/6/2014 3:50 PM, Bart Van Assche wrote: Avoid that the kernel-doc tool warns about missing argument descriptions for the ib_srp.[ch] source files. Signed-off-by: Bart Van Assche bvanass...@acm.org Cc: Roland Dreier rol...@purestorage.com Cc: David Dillow d...@thedillows.org Cc: Sagi

Re: [PATCH 2/9] IB/srp: Introduce an additional local variable

2014-05-07 Thread Sagi Grimberg
On 5/6/2014 3:51 PM, Bart Van Assche wrote: This patch does not change any functionality. Signed-off-by: Bart Van Assche bvanass...@acm.org Cc: Roland Dreier rol...@purestorage.com Cc: David Dillow d...@thedillows.org Cc: Sagi Grimberg sa...@mellanox.com Cc: Vu Pham v...@mellanox.com Cc:

Re: [PATCH 3/9] IB/srp: Introduce srp_alloc_fmr_pool()

2014-05-07 Thread Sagi Grimberg
On 5/6/2014 3:52 PM, Bart Van Assche wrote: Introduce the srp_alloc_fmr_pool() function. Only set srp_dev-fmr_max_size if FMR pool creation succeeded. This change is safe since that variable is only used if FMR pool creation succeeded. Signed-off-by: Bart Van Assche bvanass...@acm.org Cc:

Re: [PATCH 4/9] IB/srp: Introduce srp_map_fmr()

2014-05-07 Thread Sagi Grimberg
On 5/6/2014 3:53 PM, Bart Van Assche wrote: This patch does not change any functionality. Signed-off-by: Bart Van Assche bvanass...@acm.org Cc: Roland Dreier rol...@purestorage.com Cc: David Dillow d...@thedillows.org Cc: Sagi Grimberg sa...@mellanox.com Cc: Vu Pham v...@mellanox.com Cc:

Re: [PATCH 5/9] IB/srp: Introduce srp_finish_mapping()

2014-05-07 Thread Sagi Grimberg
On 5/6/2014 3:53 PM, Bart Van Assche wrote: This patch does not change any functionality. Signed-off-by: Bart Van Assche bvanass...@acm.org Cc: Roland Dreier rol...@purestorage.com Cc: David Dillow d...@thedillows.org Cc: Sagi Grimberg sa...@mellanox.com Cc: Vu Pham v...@mellanox.com Cc:

Re: [PATCH 6/9] IB/srp: Make srp_alloc_req_data() reallocate request data

2014-05-07 Thread Sagi Grimberg
On 5/6/2014 3:54 PM, Bart Van Assche wrote: This patch is needed by the patch that adds fast registration support. Signed-off-by: Bart Van Assche bvanass...@acm.org Cc: Roland Dreier rol...@purestorage.com Cc: David Dillow d...@thedillows.org Cc: Sagi Grimberg sa...@mellanox.com Cc: Vu Pham

[PATCH opensm] osm_port_info_rcv.c: Fixed calculation of min_data_vls

2014-05-07 Thread Hal Rosenstock
From: Tomer Cohen tome...@mellanox.com Date: Sun, 13 Apr 2014 15:26:47 +0300 Bug description: opensm is not using future value of op_vls when calculating subnet's minimal op_vl. opensm calculates minimal op_vls (sm-p_subn-min_data_vl) when receiving pi mads, and the linkmgr

Re: [PATCH 2/9] IB/srp: Introduce an additional local variable

2014-05-07 Thread Bart Van Assche
On 05/07/14 12:37, Sagi Grimberg wrote: On 5/6/2014 3:51 PM, Bart Van Assche wrote: This patch does not change any functionality. Signed-off-by: Bart Van Assche bvanass...@acm.org Cc: Roland Dreier rol...@purestorage.com Cc: David Dillow d...@thedillows.org Cc: Sagi Grimberg

Re: [PATCH 6/9] IB/srp: Make srp_alloc_req_data() reallocate request data

2014-05-07 Thread Bart Van Assche
On 05/07/14 12:50, Sagi Grimberg wrote: On 5/6/2014 3:54 PM, Bart Van Assche wrote: -static void srp_free_req_data(struct srp_target_port *target) +static void srp_free_req_data(struct srp_target_port *target, + struct srp_request *req_ring) { struct ib_device *ibdev

RE: [PATCH 2/5] ib/mad: update module to pr_* style print messages

2014-05-07 Thread Weiny, Ira
On Mon, May 05, 2014 at 09:44:47PM -0400, ira.we...@intel.com wrote: From: Ira Weiny ira.we...@intel.com Also combine previously line broken user-visible strings as per Documentation/CodingStyle These seem like nice cleanups, however it would be much nicer to use the dev_* versions

RE: [PATCH 3/5] ib/mad: Add pr_notice messages for various umad/mad registration failures

2014-05-07 Thread Weiny, Ira
On Mon, May 05, 2014 at 09:44:48PM -0400, ira.we...@intel.com wrote: From: Ira Weiny ira.we...@intel.com An empty commit message is not good enough for the mainline kernel, please describe motivation at least. Will do. I am worried about log DOS potential here, it looks like many of

RE: [PATCH 4/5] ib/mad: add new ioctl to user space to support new registration options

2014-05-07 Thread Weiny, Ira
On Mon, May 05, 2014 at 09:44:49PM -0400, ira.we...@intel.com wrote: +struct ib_user_mad_reg_req2 { + __u32 id; + __u32 qpn; + __u8mgmt_class; + __u8mgmt_class_version; + __u16 res; + __u32 flags; + __u64 method_mask[2]; + __u8oui[3]; /*

Re: [PATCH 9/9] IB/srp: Add fast registration support

2014-05-07 Thread Bart Van Assche
On 05/07/14 13:34, Sagi Grimberg wrote: +module_param(prefer_fr, bool, 0444); +MODULE_PARM_DESC(prefer_fr, + Whether to use FR if both FMR and FR are supported); Will it be better to make it a per-target attribute? Hello Sagi, The only reason I introduced this kernel module

Re: [PATCH 4/5] ib/mad: add new ioctl to user space to support new registration options

2014-05-07 Thread Jason Gunthorpe
On Wed, May 07, 2014 at 02:39:26PM +, Weiny, Ira wrote: On Mon, May 05, 2014 at 09:44:49PM -0400, ira.we...@intel.com wrote: +struct ib_user_mad_reg_req2 { + __u32 id; + __u32 qpn; + __u8mgmt_class; + __u8mgmt_class_version; + __u16 res; + __u32 flags;

Re: [PATCH 2/5] ib/mad: update module to pr_* style print messages

2014-05-07 Thread Jason Gunthorpe
On Wed, May 07, 2014 at 02:30:04PM +, Weiny, Ira wrote: On Mon, May 05, 2014 at 09:44:47PM -0400, ira.we...@intel.com wrote: From: Ira Weiny ira.we...@intel.com Also combine previously line broken user-visible strings as per Documentation/CodingStyle These seem like nice

Re: [PATCH 2/9] IB/srp: Introduce an additional local variable

2014-05-07 Thread Sagi Grimberg
On 5/7/2014 4:52 PM, Bart Van Assche wrote: On 05/07/14 12:37, Sagi Grimberg wrote: On 5/6/2014 3:51 PM, Bart Van Assche wrote: This patch does not change any functionality. Signed-off-by: Bart Van Assche bvanass...@acm.org Cc: Roland Dreier rol...@purestorage.com Cc: David Dillow

Re: [PATCH 6/9] IB/srp: Make srp_alloc_req_data() reallocate request data

2014-05-07 Thread Sagi Grimberg
On 5/7/2014 5:11 PM, Bart Van Assche wrote: On 05/07/14 12:50, Sagi Grimberg wrote: On 5/6/2014 3:54 PM, Bart Van Assche wrote: -static void srp_free_req_data(struct srp_target_port *target) +static void srp_free_req_data(struct srp_target_port *target, + struct srp_request

Re: [PATCH 9/9] IB/srp: Add fast registration support

2014-05-07 Thread Sagi Grimberg
On 5/7/2014 5:59 PM, Bart Van Assche wrote: On 05/07/14 13:34, Sagi Grimberg wrote: +module_param(prefer_fr, bool, 0444); +MODULE_PARM_DESC(prefer_fr, + Whether to use FR if both FMR and FR are supported); Will it be better to make it a per-target attribute? Hello Sagi, The only

[PATCH opensm] osm_subnet.c: Enhance opensm conf file documentation for PerfMgr options

2014-05-07 Thread Hal Rosenstock
Reviewed-by: Ira Weiny ira.we...@intel.com Signed-off-by: Hal Rosenstock h...@mellanox.com --- diff --git a/opensm/osm_subnet.c b/opensm/osm_subnet.c index f30d852..8ee62d9 100644 --- a/opensm/osm_subnet.c +++ b/opensm/osm_subnet.c @@ -2628,28 +2628,35 @@ int osm_subn_output_conf(FILE *out, IN

[PATCH v2 opensm] osm_subnet.c: Enhance opensm conf file documentation for PerfMgr options

2014-05-07 Thread Hal Rosenstock
Reviewed-by: Ira Weiny ira.we...@intel.com Signed-off-by: Hal Rosenstock h...@mellanox.com --- Change from version 1: Formatted properly for posting to linux-rdma diff --git a/opensm/osm_subnet.c b/opensm/osm_subnet.c index f30d852..8ee62d9 100644 --- a/opensm/osm_subnet.c +++

Re: [PATCH] mellanox: Logging message cleanups

2014-05-07 Thread David Miller
Joe, please get rid of the initial empty line you're adding to fw.c and resubmit with Amir's ACK. Thanks. -- To unsubscribe from this list: send the line unsubscribe linux-rdma in the body of a message to majord...@vger.kernel.org More majordomo info at

[ANNOUNCE] libmlx4 1.0.6 is released

2014-05-07 Thread Roland Dreier
libmlx4 is a library that allows programs to use RDMA verbs for direct access to RDMA (currently InfiniBand and iWARP) hardware from userspace. The new stable release, 1.0.6, is available from http://www.openfabrics.org/downloads/mlx4/libmlx4-1.0.6.tar.gz with sha1sum

Re: [ANNOUNCE] libibverbs 1.1.8 is released

2014-05-07 Thread Roland Dreier
On Wed, May 7, 2014 at 1:48 AM, Or Gerlitz ogerl...@mellanox.com wrote: Roland, due to a mistake I made in the rebased flow-steering patch I handed you -- I was nominated as the author instead of Matan, our flow-steering maintainer.. can you please git reword this commit in your libibverbs

[PATCH v2 1/5] ib/umad: update module to [pr|dev]_* style print messages

2014-05-07 Thread ira . weiny
From: Ira Weiny ira.we...@intel.com Use dev_* style print when struct device is available. Also combine previously line broken user-visible strings as per Documentation/CodingStyle However, never break user-visible strings such as printk messages, because that breaks the ability to grep for

[PATCH v2 2/5] ib/mad: update module to [pr|dev]_* style print messages

2014-05-07 Thread ira . weiny
From: Ira Weiny ira.we...@intel.com Use dev_* style print when struct device is available. Also combine previously line broken user-visible strings as per Documentation/CodingStyle However, never break user-visible strings such as printk messages, because that breaks the ability to grep for